@centralu/host-linux-x64 0.1.0-beta.25 → 0.1.0-beta.27

package/host/remote-install.mjs

@@ -11,7 +11,7 @@ import { spawnSync } from 'node:child_process'
 import { createHash, randomBytes } from 'node:crypto'
 import { chmodSync, existsSync, mkdirSync, readdirSync, readFileSync, realpathSync, renameSync, rmSync, statSync, writeFileSync } from 'node:fs'
 import { homedir } from 'node:os'
-import { basename, join } from 'node:path'
+import { basename, join, win32 } from 'node:path'
 import { pathToFileURL } from 'node:url'
 
 const WORD = /^[0-9A-Za-z][0-9A-Za-z.+-]{0,63}$/
@@ -176,9 +176,15 @@ function alive(pid) {
   }
 }
 
-/** The system's tar. On Windows the one in System32 (bsdtar): a GNU tar on PATH reads `C:` as a host */
-function tarProgram() {
-  return process.platform === 'win32' ? join(process.env.SystemRoot || 'C:\\Windows', 'System32', 'tar.exe') : 'tar'
+/**
+ * The system's tar. On Windows the one in System32 (bsdtar): a GNU tar on PATH reads `C:` as a host. Named by its whole
+ * path: a `SystemRoot` that is not one from a drive's root is not used (the host's `systemTool` rule, which this script
+ * cannot import), since Windows looks a relative program path up in the working directory first (#428).
+ */
+export function tarProgram(platform = process.platform, env = process.env) {
+  if (platform !== 'win32') return 'tar'
+  const root = /^[A-Za-z]:[\\/]/.test(env.SystemRoot ?? '') ? env.SystemRoot : 'C:\\Windows'
+  return win32.join(root, 'System32', 'tar.exe')
 }
 
 /** The tarball's bytes, refused unless their sha512 is the integrity the hub read from the signed metadata */
@@ -258,15 +264,15 @@ export async function install(p, { dataDir = process.env.CC_DATA_DIR || join(hom
       const partial = join(l.root, `.partial-${p.version}-${process.pid}`)
       rmSync(partial, { recursive: true, force: true })
       try {
-        for (const [i, pkg] of p.packages.entries()) {
+        for (const pkg of p.packages) {
           const bytes = await fetchChecked(pkg)
-          const file = join(partial, `${i}.tgz`)
           const dest = join(partial, 'node_modules', ...pkg.name.split('/'))
           mkdirSync(dest, { recursive: true })
-          writeFileSync(file, bytes)
-          const r = spawnSync(tarProgram(), ['-xzf', file, '-C', dest, '--strip-components', '1'], { encoding: 'utf8', windowsHide: true })
+          // No path among the arguments (#849): Windows' tar takes its arguments in the ANSI code page, so a profile
+          // folder outside it (a name in another script) reached it as "?????" and the unpack failed. The archive comes
+          // on stdin, and the destination is the working folder, which Windows hands over whole
+          const r = spawnSync(tarProgram(), ['-xzf', '-', '--strip-components', '1'], { cwd: dest, input: bytes, encoding: 'utf8', windowsHide: true, maxBuffer: 16 * 1024 * 1024 })
           if (r.status !== 0) throw new Refusal('unpack', `${pkg.name}: ${(r.stderr || r.error?.message || '').trim().split('\n').at(-1)}`)
-          rmSync(file, { force: true })
         }
         const pkgDir = join(partial, 'node_modules', ...parts.pkg.split('/'))
         if (!existsSync(join(pkgDir, parts.host))) throw new Refusal('no_host', p.platform)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@centralu/host-linux-x64",
-  "version": "0.1.0-beta.25",
+  "version": "0.1.0-beta.27",
   "description": "Centralu's host without the window, for Linux on x86-64: what a hub installs on a linked machine",
   "license": "MIT",
   "author": "ijun17",