@celonis/content-cli 1.2.2 → 1.2.4

package/commands/configuration-management/module.js

@@ -93,6 +93,9 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
                 if ((options.packageKeys && options.keysByVersion) || (!options.packageKeys && !options.keysByVersion)) {
                     throw new Error("Please provide either --packageKeys or --keysByVersion, but not both.");
                 }
+                if (options.gitProfile && !options.gitBranch) {
+                    throw new Error("Please specify a branch using --gitBranch when using a Git profile.");
+                }
                 options.withDependencies = (_a = options.withDependencies) !== null && _a !== void 0 ? _a : false;
                 yield new config_command_service_1.ConfigCommandService(context).batchExportPackages(options.packageKeys, options.keysByVersion, options.withDependencies, options.gitBranch, options.unzip);
             });
@@ -104,6 +107,9 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
         }
         batchImportPackages(context, command, options) {
             return __awaiter(this, void 0, void 0, function* () {
+                if (options.gitProfile && !options.gitBranch) {
+                    throw new Error("Please specify a branch using --gitBranch when using a Git profile.");
+                }
                 yield new config_command_service_1.ConfigCommandService(context).batchImportPackages(options.file, options.directory, options.overwrite, options.gitBranch);
             });
         }

package/commands/deployment/deployment-api.js

@@ -87,9 +87,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
             return __awaiter(this, void 0, void 0, function* () {
                 const queryParams = new URLSearchParams();
                 queryParams.set("deployableType", deployableType);
-                if (packageKey) {
-                    queryParams.set("packageKey", packageKey);
-                }
+                queryParams.set("packageKey", packageKey);
                 return this.httpClient()
                     .get(`/pacman/api/deployments/targets?${queryParams.toString()}`)
                     .catch((e) => {

package/commands/deployment/module.js

@@ -67,7 +67,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
                 .beta()
                 .description("List all targets for a given deployable type and package key")
                 .requiredOption("--deployableType <deployableType>", "The type of the deployable")
-                .option("--packageKey <packageKey>", "Identifier of the package to list targets for")
+                .requiredOption("--packageKey <packageKey>", "Identifier of the package to list targets for")
                 .option("--json", "Return the response as a JSON file")
                 .action(this.listTargets);
         }

package/commands/git-profile/git-profile-command.service.js

@@ -33,6 +33,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
                 const questions = new question_service_1.QuestionService();
                 try {
                     profile.name = yield questions.ask("Name of the Git profile to create: ");
+                    this.gitProfileService.validateProfileName(profile.name);
                     profile.username = yield questions.ask("Your Git username: ");
                     profile.repository = yield questions.ask("Your repository (format: repoOwner/repoName): ");
                     const type = yield questions.ask("Authentication type: HTTPS (1), SSH token (2): ");
@@ -52,11 +53,14 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
                     if (setAsDefault) {
                         yield this.makeDefaultProfile(profile.name);
                     }
+                    logger_1.logger.info("Git Profile created successfully!");
+                }
+                catch (e) {
+                    logger_1.logger.error(e.toString());
                 }
                 finally {
                     yield questions.close();
                 }
-                logger_1.logger.info("Git Profile created successfully!");
             });
         }
         listProfiles() {

package/core/command/module-handler.js

@@ -197,7 +197,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
                     this.printBetaNoticeIfBetaCommand();
                     this.printBetaNoticeIfBetaOptions();
                     this.printDeprecationNoticeIfDeprecated();
-                    yield handler(this.ctx, this.cmd, this.cmd.opts());
+                    yield handler(this.ctx, this.cmd, this.cmd.optsWithGlobals());
                 }
                 catch (error) {
                     logger_1.logger.error(`An unexpected error occured executing a command: ${error}`);
@@ -218,7 +218,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
             if (this.cmd.isBeta) {
                 return;
             }
-            const providedOptions = this.cmd.opts();
+            const providedOptions = this.cmd.optsWithGlobals();
             for (const option of this.cmd.options) {
                 const optionName = option.attributeName();
                 if (option.isBeta && Object.hasOwn(providedOptions, optionName)) {

package/core/git-profile/git-profile.service.js

@@ -81,6 +81,11 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
                 encoding: "utf-8",
             });
         }
+        validateProfileName(name) {
+            if (GitProfileService.INVALID_FILENAME_CHARS.test(name)) {
+                throw new Error(`Invalid profile name "${name}". The following characters are not allowed: / \\ : * ? " < > |`);
+            }
+        }
         buildProfileFromEnvVariables() {
             return __awaiter(this, void 0, void 0, function* () {
                 const profileVariables = this.getProfileEnvVariables();
@@ -131,4 +136,5 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
         }
     }
     exports.GitProfileService = GitProfileService;
+    GitProfileService.INVALID_FILENAME_CHARS = /[\/\\:*?"<>|.]/;
 });

package/lib/commands/deployment/deployment-api.d.ts

@@ -7,7 +7,7 @@ export declare class DeploymentApi {
     getDeployments(filter: GetDeploymentsRequest, limit?: string, offset?: string): Promise<DeploymentTransport[]>;
     getActiveDeploymentsForPackage(packageKey: string, targetIds?: string[], limit?: string, offset?: string): Promise<DeploymentTransport[]>;
     getActiveDeploymentForTarget(targetId: string): Promise<DeploymentTransport>;
-    getTargets(deployableType: string, packageKey?: string): Promise<TargetTransport[]>;
+    getTargets(deployableType: string, packageKey: string): Promise<TargetTransport[]>;
     getDeployables(flavor?: string): Promise<DeployableTransport[]>;
     private addPaginationParams;
 }

package/lib/commands/deployment/deployment.service.d.ts

@@ -6,6 +6,6 @@ export declare class DeploymentService {
     getDeployments(jsonResponse: boolean, packageKey?: string, targetId?: string, deployableType?: string, status?: string, createdBy?: string, limit?: string, offset?: string): Promise<void>;
     getActiveDeploymentForTarget(targetId: string, jsonResponse: boolean): Promise<void>;
     getActiveDeploymentsForPackage(packageKey: string, jsonResponse: boolean, targetIds?: string[], limit?: string, offset?: string): Promise<void>;
-    getTargets(jsonResponse: boolean, deployableType: string, packageKey?: string): Promise<void>;
+    getTargets(jsonResponse: boolean, deployableType: string, packageKey: string): Promise<void>;
     getDeployables(jsonResponse: boolean, flavor?: string): Promise<void>;
 }

package/lib/core/git-profile/git-profile.service.d.ts

@@ -6,10 +6,12 @@ export declare class GitProfileService {
     private readonly homedir;
     private readonly gitProfileContainerPath;
     private readonly configContainer;
+    private static readonly INVALID_FILENAME_CHARS;
     findProfile(profileName: string): Promise<GitProfile>;
     makeDefaultProfile(profileName: string): Promise<GitProfile>;
     getDefaultProfile(): string;
     storeProfile(profile: GitProfile): void;
+    validateProfileName(name: string): void;
     private buildProfileFromEnvVariables;
     private storeConfig;
     private createProfileContainerIfNotExists;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@celonis/content-cli",
-  "version": "1.2.2",
+  "version": "1.2.4",
   "description": "CLI Tool to help manage content in Celonis Platform",
   "main": "content-cli.js",
   "bin": {