@celilo/cli 1.7.0 → 1.9.0

package/CELILO_CORE_MODULES.md

@@ -37,7 +37,9 @@ Each entry: `module id` — what it is — **provides** / **requires** capabilit
 - **axon** — Axon Networks Q1000K ISP router driver (Brightspeed-branded); port-forwarding + public-IP discovery + DHCP DNS + DHCP address-pool bounds via the TR-181 CGI API. **provides:** `firewall`, `dhcp_server`. Fork of **greenwave** — identical protocol, differing only in the vendor extension prefix (`X_AXON_` vs `X_GWS_`/`X_LANTIQ_COM_`). Pick by device: Q1000K → **axon**, C4000XG → **greenwave**. Two device behaviours shape this driver and are not shared by **greenwave** (celilo#739): the router **regenerates** `Pool.1.DNSServers` from its own upstream resolver list every ~15 min and on any config commit, so `setDhcpDns` also writes `Device.DNS.X_AXON_CustomServer` — the *input* to that computation, which survives — and **technitium re-asserts** the pool value on `timer.tick.1m`. Optional `dhcp_pool_start`/`dhcp_pool_end` bound the leased range; set them below the addresses IPAM allocates, because **IPAM has no knowledge of the router's DHCP pool** and nothing otherwise stops the router leasing an address celilo already assigned.
 - **greenwave** — GreenWave C4000XG ISP router driver; port-forwarding + public-IP discovery via REST. **provides:** `firewall`, `dhcp_server`. Legacy device; new deployments on Axon hardware want **axon**.
 - **iptables** — iptables firewall + NAT; cross-VLAN port exposure with recursive upstream delegation. Converge model: `exposeService` registers into the shared-core port-forward registry, then renders the complete ruleset and applies it atomically via `iptables-restore` (default-DROP FORWARD + coarse zone-tier matrix; SSH-free). **REQUIRES the networks it has legs on and defines none of them** (`requires.networks: [{from: $self:zones}]`) — the required set is resolved from the same `zones` value that says which NICs the box has, so the legs and the declared networks are ONE list. They used to be two: `zones` and a `provided_networks` array this module wrote into system config from its install hook, with nothing forcing them to agree. A leg whose network has no declared subnet classifies `alien`, and on a firewall with a recorded baseline an alien interface is DISABLED — so under-declaring was never cosmetic. `firewall-interface-classification` §3/D8 reached that conclusion for the test harness; `networks-are-declared-not-written` applies it in production and deletes `provided_networks` outright (breaking: iptables 3.0.0). celilo supplies each range, asking the operator when it holds none. **provides:** `firewall`.
+- **dnsmasq-dhcp** — a DHCP-only dnsmasq in **`internal`**, providing the zone-scoped `dhcp_server` capability for a network with no upstream router to serve it. **provides:** `dhcp_server` (zone `internal`). The other two `dhcp_server` providers, **axon** and **greenwave**, do not run a DHCP server at all — they drive an ISP router's built-in one over its API, which works only while the home network shares a broadcast domain with that router. Put `internal` behind the celilo firewall and DHCP discovery, being a broadcast, no longer reaches it: celilo could describe that topology and not make it work. Importing this module at all depends on well-known-provider uniqueness being scoped PER ZONE (celilo#1028), since axon/greenwave already claim `dhcp_server` fleet-wide. **`port=0` is load-bearing**: dnsmasq ships a resolver as well as a DHCP server, and `dns_internal` is a different capability with its own providers — two resolvers answering on one network is a split-brain that is very hard to see from outside. celilo's transactional artifacts go to `/var/lib/celilo/config-state/` via `applyRenderedConfig`'s `statePath`, NOT beside the managed fragment, because dnsmasq parses every file in `/etc/dnsmasq.d` and a `.celilo-bak` there is configuration the daemon reads. It declares a `requires.system` and is placed by celilo like any other module; an earlier shape declared none, which meant no host in the inventory, an `apt-get` shelled over SSH from a hook, and an operator-typed address — and which also evaded `validateMachineRoleForModule`, the check that refuses to place a non-firewall module on a multi-interface router.
 - **knot-unbound-internal** — split-horizon internal DNS via Knot (authoritative) + Unbound (recursive); lightweight, plain apt, no .NET. **provides:** `dns_internal`. Ships a base-module-aspect (`modules/knot-unbound-internal/base-module-aspect/`).
+- **knot-unbound-secondary** — a read-only secondary for **knot-unbound-internal**: Knot transfers every managed zone from the primary and Unbound serves the same split-horizon view. Lives in **`dmz`**, symmetric with the primary (design D5e) — NOT in `internal` as first written. That placement was chosen deliberately and the reasoning is worth keeping: design D5a records the secondary's justification as weak on purpose, since steady state is already a single resolver address and the one recurring non-bug case a secondary covers is redeploying the primary, which blanks fleet DNS for the duration. Same-zone covers that completely. A split placement buys zone-level independence, which D5a explicitly declined, and would not deliver it anyway — celilo has no host anti-affinity, so both LXCs land on the container service's `default_target_node`. **provides:** `dns_internal_secondary`, carrying its OWN addresses rather than being advertised by the primary: if the primary carried them its published data would be stale from the moment this module deployed until something recomputed it, and recomputing means redeploying the primary — the manual step D5 exists to remove. **requires:** `dns_internal` (hard, and honestly declared: it sat under `optional` until celilo#854, because the import-time secret gate refused a consumer over a `tsig_key` it never reads). Its protected-zone ingress is a `*_ingress_ip` / `source: infrastructure` variable that `ensureIngressIps` allocates from `network.internal.subnet`, so the operator types none of the three addresses the fork's version asked for. Registering it as a transfer peer on the primary is `registerTransferPeer` (design D5f) — ⚠️ the empty peer state MUST render an explicit `deny: on`, because a knot acl with `action: transfer` and no `address:` matches ANY source and `knotc conf-check` accepts that silently.
 - **technitium** — internal split-horizon DNS resolver + authoritative server (web UI + HTTP API); heavier alternative to knot-unbound. **provides:** `dns_internal`. Ships a base-module-aspect (`modules/technitium/base-module-aspect/`).
 - **namecheap** — public DNS A-record management via Namecheap Dynamic DNS API (HTTP, no browser automation). A caller supplies a NAME and nothing else: the address is the source IP of celilo's own update, re-derived on every assert. Registering `<domain>` also claims `www.<domain>` and vice versa (best effort, reported back as `outputs.companion_fqdn` so the framework's `public_dns` check watches it — Namecheap answers `ErrCount 0` for `www` updates it does not apply). DDNS passwords are keyed by the **registrable domain**, never the FQDN. **provides:** `dns_registrar`.
 - **wireguard** — owns the admin WireGuard tunnel on the firewall host: interface, listen port, peers (as records), and client subnet are module config rather than hand-maintained state. Exposes the listen port and **registers the client subnet as a trusted source**, so VPN reach into the managed zones is in the firewall registry and every converge re-emits it. **REQUIRES the `control-plane-vpn` network and READS its range** (`requires.networks`; `client_subnet` is a `source: system` derive of `network.control-plane-vpn.subnet`). It does not write that network and has no way to — celilo owns the namespace, and the deploy will not reach any hook until the network is defined, asking for a range if one is missing. So `wg0` is attributable the moment it exists. This replaces a declare-before-you-create ordering inside `on_install`, which could only narrow the window and not close it: a consumer that captured config before the hook started could not see a value the hook wrote, whatever order it wrote it in, and that is exactly what left `wg0` unattributable (celilo#759). `health_check` still asserts the declaration matches what the tunnel serves — what it catches now is divergence, celilo's network having changed since the module resolved its config. That same key is what the internal resolver's split-horizon view consumes. Adopts a running tunnel in place (existing key retained; `wg syncconf`, never `wg-quick down`) because that tunnel is the operator's recovery path. **Adoption is a one-time IMPORT and it ENDS.** The marker is `registered_peers` — celilo's own config key, separate from the operator's `peers` so a machine can never rewrite what an operator typed. While that key has never been written the tunnel is not yet celilo's; the deploy that writes it (even as `[]`) CLAIMS the tunnel, importing whatever `[Peer]` blocks are running, and from then on the render is closed-world (`peers` ∪ `registered_peers`) with a `[Peer]` on the box in neither reported as drift by `on_install` and by `health_check`'s `unknown_peers`. An ABSENT `peers` declaration and a declared-EMPTY one are deliberately different (no `default: []` on either variable): they used to be the same value, so the module read every empty list as "adopt what is running", the last peer could not be revoked, and a hand-added peer rode along on every deploy unreported (celilo#765). On a tunnel celilo has not yet claimed, a declared-empty `peers` is REFUSED rather than obeyed — celilo's own variable-default seeding wrote a real `peers = []` row for every install of the previous version that never set one, so on the installed base an empty list cannot be told from a stored default, and obeying it would `wg syncconf` the admin tunnel down to zero peers. **PROVIDES `control_plane_vpn`** so another module can enrol clients without an operator editing YAML: `registerClient` / `revokeClient` write to `registered_peers` — the same key the adoption claim uses — and `getEndpoint` reads the server's public key LIVE off the host rather than storing a copy that could be republished after the key changed. `client_pool` is the range a consumer may allocate from, a strict subset of the client subnet, and `validate_config` REFUSES any operator-declared peer inside it: the two allocators cannot see each other, so the range is divided rather than negotiated, and that check is the only place a bad division is caught. ⚠️ Granting this capability grants fleet-wide reach — the tunnel's client subnet is a registered trusted source, so every client enrolled through it reaches every managed zone. **requires:** `firewall` (and the provider must support trusted-source registration — `iptables` does; the ISP-router drivers `greenwave` and `axon` do not).
@@ -73,6 +75,7 @@ Each entry: `module id` — what it is — **provides** / **requires** capabilit
 ## E2E fixtures & probes (not production apps)
 
 - **hello-foo** / **hello-bar** — hostless single-page sites (one hand-written `site/index.html`, no build step) published at a configurable `domain` + `path`. They exist so the caddy route-lifecycle e2e can put several independent routes on one caddy and watch them interact — celilo-website is the only other static-site module, and one site can't answer "does removing `/` break `/foo`?". **requires:** `public_web`, `dns_registrar`.
+- **hello-trespass** — TEST FIXTURE, never deploy. Its `on_install` hook attempts three things a hook has no business doing (read the master key at its default location, write into a sibling module's install tree, read the SSH private key / `remoteExec` another module's system) and REPORTS which succeeded rather than failing. It is the recurrence gate for `openspec/changes/hook-process-boundary`: each stage flips exactly one row and the test asserts the rows that stage does NOT claim still succeed, so a gate cannot quietly grow to cover work that was never done. **requires:** nothing.
 - **hello-private-foo** / **hello-private-bar** — the `private_web` twins of the pair above: hostless single-page sites published through the fleet-only ingress. Two of them for the same reason — one consumer cannot answer "does withdrawing `/foo` leave `/bar` alone?", and per-consumer scoping is exactly what `unregisterRoutes()` promises. Their hook is `private_web ?? public_web` with no branching after it, which is the spec's "same consumer code, either ingress" requirement made executable. **hello-private-foo** additionally calls `getCaCertificate()` and writes the PEM into its own site before publishing — the CA-bundling pattern a real consumer uses, and the only way to observe that the capability returned something usable. **requires:** `private_web`.
 - **source-forge-probe** — hostless e2e probe that exercises the `source_forge` capability (issue/revoke runner token) against a deployed Forgejo. **requires:** `source_forge`.
 - **test-ansible-output** — e2e fixture that runs 25×1s sleep tasks to assert Ansible output streams in real time. Not a real app.

package/CELILO_SUBSYSTEMS.md

@@ -32,7 +32,11 @@ see `openspec/specs/`. Companion doc: [CELILO_CORE_MODULES.md](./CELILO_CORE_MOD
 - **Network requirement + ensure (celilo owns the namespace)** — `apps/celilo/src/services/network-ensure.ts` (`ensureRequiredNetworks`), `NetworkRequirementSchema` / `getRequiredNetworkNames` in `apps/celilo/src/manifest/schema.ts`. A module declares `requires.networks: [{name}]` — a NAME, never a value; the schema is `.strict()` so a `subnet:` on the requirement is rejected with a message saying why. The deploy calls `ensureRequiredNetworks` in its interview phase, BEFORE generation and before any hook, and asks over the generic bus interview (`askText`, so it is answerable headless) for anything undefined. Which attributes a network has is celilo's answer, taken from `apps/celilo/schemas/system_config.json`: that file declares `network.<n>.gateway` for the routed segments and omits it for `control-plane-vpn`, so a gateway is never asked for a network that has none. Well-known names carry a `suggested` range there — deliberately NOT `default`, which `getDefaultConfiguration()` would seed at `system init`. Spec: `openspec/specs/network-declaration/spec.md`.
 - **The network write path (closed) + celilo's own discovery** — `celilo system apply-config` (`apps/celilo/src/cli/commands/system-apply-config.ts`) REFUSES the whole `network.` namespace, `network.bridge` excepted (a Proxmox bridge name is not addressing, and it is the one network key with a schema default). That is the automation surface a module hook shells out to, so closing it there is what makes "networks are celilo's" an authority rather than a convention every module has to remember. The refusal names the alternative — declare the network, read it with `$system:` — because a bare rejection sends a module author hunting for a typo. The one write that legitimately needed the surface moved INTO celilo: `celilo system discover-network` (`apps/celilo/src/services/network-discovery.ts`, `cli/commands/system-discover-network.ts`) parses the box's own `ip route` and records `network.internal.*` — or `network.secure-mgmt.*` when the box is off the internal LAN (#300). `celilo-mgmt` calls it and decides nothing; it used to parse and write this itself. Idempotent and never overwrites addressing already set. Recurrence gate: `test-integration/module/no-module-writes-networks.test.ts`.
 - **Firewall interface audit** — `apps/celilo/src/services/audit/interface-classification.ts` — reports per-firewall classification in `celilo audit`: alien interfaces by name and address (drift), and the blocking findings a converge refuses on — a carrier-grade NAT leg, an ambiguous external edge, a default route on the wrong leg.
-- **Zone taxonomy (canonical list)** — `apps/celilo/src/db/schema.ts` — `NETWORK_ZONES` is the single array; `NetworkZone` is DERIVED from it. Never hand-maintain a second copy: a duplicate that dropped a member made zone validation return null and silently fall back to a wrong-but-valid zone.
+- **Zone taxonomy (canonical list)** — `apps/celilo/src/db/schema.ts` — `NETWORK_ZONES` is the single array; `NetworkZone` is DERIVED from it. Never hand-maintain a second copy: a duplicate that dropped a member made zone validation return null and silently fall back to a wrong-but-valid zone. Two copies are unavoidable and BOTH are guarded: `modules/iptables`' `zones` picker (`test-integration/module/zone-options-cover-network-zones.test.ts` fails on any drift, and did when `isp-transit` was added to core alone) and the generated `schemas/module-manifest.schema.json` (`bun run check:schema`, run from `apps/celilo` — a FOURTH gate CI runs that the "Validation gates" list in CLAUDE.md does not name).
+  - **`isp-transit`** — the private segment between a celilo firewall and the router upstream of it. Non-placement and non-allocatable (it joins `external` and `control-plane-vpn` in the excluded set) because that router owns the addressing. It exists because on a DOWNSTREAM firewall the default route and the workload network share one interface, so `internal` meant both at once and every egress rule also reasoned about the workload network. A firewall with no separate transit leg declares `default_route_zone: internal` and behaves as it always did.
+- **Declared egress zone** — `modules/iptables` `default_route_zone`, consumed by `defaultRouteFinding` in `packages/capabilities/src/interface-classification.ts` — celilo already classifies whichever interface carries the default route; what it could not do is tell an INTENDED egress leg from a drifted one, so the comparison was hardcoded to "internal or external". Declaring the intent makes a wandered default route a finding. Defaults to `internal`.
+- **Capability-secret access is reference-driven** — `apps/celilo/src/capabilities/validation.ts` — `validateCapabilityAccess` fires on the `$capability:<name>.<secret>` paths the CONSUMER references, collected from its manifest AND from the templates `validateModuleTemplates` already parses at import. It used to iterate the secrets the PROVIDER declares, so requiring a capability that merely carries a secret put a module on the hook for that secret's `readable_by` list (celilo#854, celilo#1038). Reading a secret still goes through `checkCapabilitySecretAccess` at resolution time.
+- **Zone-first capability provider selection** — `apps/celilo/src/capabilities/lookup.ts` — one shared selection function used by both the direct lookup and the hook capability loader, which had drifted apart. Well-known-provider uniqueness is scoped per zone, which is what lets a second `dhcp_server` provider exist at all while `axon`/`greenwave` claim it fleet-wide.
 - **Control-plane network (`secure-mgmt`)** — `apps/celilo/src/hooks/capability-loader.ts` — `loadControlPlaneSubnet` returns the subnet of the zone `celilo-mgmt` is deployed in. `secure-mgmt` is a placement zone AND the control-plane tier, deliberately NOT in `ZONE_TIER_ORDER` (it is not part of the `dmz → app → secure` data-plane chain; it reaches every tier by trust). The firewall's `trustedSubnets` derives from this rather than assuming celilo-mgr sits on `internal`. Reported as an actionable gap by `checkControlPlaneNetwork` in `apps/celilo/src/services/fleet-checks.ts` when the management address matches no configured subnet.
 - **A deployed system's zone** — `apps/celilo/src/services/deployed-systems.ts` — for machine-pool deploys the zone recorded is the ZONE OF THE MACHINE, not `requires.system.zone` (which is only the minimum used to *select* a host, as with sizing). Three writers must agree: `recordDeployedSystemForModule`, `backfillModuleSystems`, and `apps/celilo/src/variables/context.ts` — the last runs latest and will overwrite the others.
 - **Host discovery ("which host serves module X?")** — `apps/celilo/src/cli/commands/module-where.ts` (`celilo module where <id> [--json]`, MCP `celilo_module_where`) — reads deployed hosts from `module_systems` via `getModuleSystems`, reconciles the live Proxmox node via `reconcilePlacement`, and adds a role-based reachability hint per zone. CI/build infra (builder VM, Forgejo runners) is out of scope (not in `module_systems`).
@@ -43,6 +47,7 @@ see `openspec/specs/`. Companion doc: [CELILO_CORE_MODULES.md](./CELILO_CORE_MOD
 - **Define a capability function** — `packages/capabilities/src/define-capability-function.ts` — `defineCapabilityFunction`.
 - **Canonical capability registry** — `packages/capabilities/src/capability-registry.ts` — `KNOWN_CAPABILITY_NAMES` (the authoritative list), `CapabilityRegistry` type. Public surface: `packages/capabilities/src/index.ts`.
 - **Loader (wires provider factories into hook contexts)** — `apps/celilo/src/hooks/capability-loader.ts` — `loadCapabilityFunctions`, `resolveFirewallNatIp`.
+- **Which provider a consumer actually resolved to (`capability_bindings`)** — `apps/celilo/src/services/capability-bindings.ts` — `recordCapabilityBinding`, `listCapabilityBindings`, `withBindingRecord`, written from the single return of `loadCapabilityFunctions`. The `capabilities` table is provider-side only, so celilo could answer "who COULD provide this" and never "who does this module actually use"; every caller needing the second question rebuilt the same approximation (the consumer's `requires` + `optional` crossed with `capabilities`), which names every provider a module MIGHT have bound to. `tango-nexus` declares four optional capabilities, is deployed against one off-fleet host, and that approximation carries three edges that do not exist. **The CALL is the binding, not the resolution** — the loader injects every registered capability regardless of what the consumer declared (its own comment: "not just required ones"), so recording what it resolves is a SUPERSET of even the permissive set. A consumer's hook invoking a method is the only event that separates the optional it uses from the ones it merely declares, which is why this matters most for the capabilities that mint nothing (`external_web`, `idp`, `source_forge`, `registry_publish`, `control_plane_vpn`, `apt_publish`) and therefore leave no artefact anywhere else. Recorded on ATTEMPT rather than success: a consumer that called a provider and got an error is standing on that provider, and hiding the edge exactly when the call fails hides it when it matters most. Unique on (consumer, capability) so a redeploy re-asserts and a provider swap rewrites in place; `bound_at` is LAST-SEEN, so a binding last exercised forty deploys ago is a queryable fact rather than a silent lie. Cascades on the consumer. It runs BESIDE `planConsumerCleanup`, never narrowing it — cleanup must still reach every provider that might hold minted state, including one whose binding row was never written. See celilo#1072.
 - **Ledger wrappers (stateful capabilities)** — `apps/celilo/src/services/dns-registrations.ts` (`withDnsRegistrationLedger`), `apps/celilo/src/services/dns-internal-records.ts` (`withDnsInternalLedger`).
 - **Public DNS ledger (`dns_registrations` + `dns_registration_consumers`)** — `apps/celilo/src/services/dns-registrations.ts` — records WHICH MODULE ASKED FOR WHICH NAME, and deliberately **no address**: the published value is source-detected on every assert and observable on demand from public DNS, and a stored copy is one careless read away from becoming an instruction again (celilo#626 — the 15-minute `refresh_registrations` replayed addresses written by an older celilo and took five public names dark for nine days while every in-fleet check stayed green). Consumers are a SET, not a column: the FK cascade on a single `consumer_module_id` decided when a LIVE record was forgotten, so a row now survives until its LAST consumer is removed (`openspec/changes/public-dns-reachability/design.md` D5). Orphaned rows are pruned on read (`pruneOrphanedRegistrations`) rather than by trigger — SQLite fires delete triggers for FK-cascaded deletes only with `recursive_triggers` on. `companion: true` marks a name celilo claimed on a module's behalf (`www.<domain>` ↔ `<domain>`) rather than one a module asked for; the provider reports it as `outputs.companion_fqdn` whether or not the claim reported success, because a provider's success response is not evidence of publication. Operator surface: `celilo dns registrations`.
 
@@ -175,6 +180,7 @@ runner seam (`execRunner` real / `createMockRunner` for tests) lives in
 ## Hooks & deploy
 
 - **Hook executor / ABI** — `apps/celilo/src/hooks/executor.ts` (`invokeHook`, `executeHookScript`, `checkRequiredCapabilities`), types in `apps/celilo/src/hooks/types.ts` (`HookContext`, `HookDefinition`, `HookName`). Named-hook runner: `apps/celilo/src/hooks/run-named-hook.ts`. Manifest hook config: `apps/celilo/src/hooks/load-hook-config.ts`.
+- **Hook process boundary (a hook is a program celilo RUNS)** — `apps/celilo/src/hooks/hook-protocol.ts` (the NDJSON frame union, `HOOK_PROTOCOL_VERSION`, `serializeError`/`deserializeError`), `apps/celilo/src/hooks/broker.ts` (`startBroker`, `capabilityShape`), `apps/celilo/src/hooks/hook-runner.ts` (the spawned shim — the ONLY thing that `import()`s module code). `executeHookScript` spawns `bun hook-runner.ts` over a Unix socket instead of importing; the nine `invokeHook` call sites and `defineHook` are unchanged. **The broker does not know what a capability is**: it sends a shape descriptor built by the same own-string-key walk `wrapWithLogging` does (functions → `methods`, everything else → `data`, which is where `stampProvider`'s `providerModuleId` lives), and the shim rebuilds forwarding proxies from it — so an optional method a provider did not implement is absent rather than present-and-throwing, and `if (cap.registerTrustedSource)` keeps answering correctly. A socket rather than stdout because module scripts spawn subprocesses and a grandchild writing to fd 1 would corrupt the frame stream. Two consequences worth knowing: the child's environment is an **allow-list** (`hookChildEnv` — `PATH`, `HOME`, `LANG`, `TZ`, `TMPDIR`, `CELILO_HOOK_*`, `CELILO_DEBUG`), so a hook reading any other operator variable now gets `undefined`; and a timeout is a real SIGTERM-then-SIGKILL with the broker refusing further capability calls, replacing a `Promise.race` that cancelled nothing and let a "timed out" hook go on writing DNS and firewall state (celilo#1003). Capability PROVIDER factories still load in-process — they ARE the broker's implementation. Stage 1 of `openspec/changes/hook-process-boundary`; it claims the environment and the process, not the filesystem (a hook can still compute the default master-key path) and not the network.
 - **Deploy pipeline** — `apps/celilo/src/services/module-deploy.ts`.
 - **DNS provider backfill** (re-emit registrations when a provider deploys) — `apps/celilo/src/services/dns-provider-backfill.ts` — `isDnsInternalProvider`, `backfillProviderDns`.
 - **Base-module aspects (fan-out across the fleet)** — `apps/celilo/src/services/aspect-runner.ts` — `planAspectFanOut`, `runAspectFanOut`, `maybeRunAspectForTrigger`. Aspect content lives in `modules/<m>/base-module-aspect/` (e.g. knot-unbound-internal, technitium). Two directions, with DELIBERATELY OPPOSITE failure semantics:

package/drizzle/0027_dns_internal_records_consumer_cascade.sql

@@ -0,0 +1,43 @@
+-- `dns_internal_records` cascades on its PROVIDER as well as its consumer, so
+-- swapping the internal DNS provider deletes the fleet's entire internal DNS
+-- ledger — including the `zone_routable_ip` view overrides the resolver's
+-- split-horizon config is reconciled from (celilo#1010).
+--
+-- `web_routes` does not do this. Its rows cascade on the consumer only, which is
+-- why a `public_web` provider swap keeps every route. The two tables' docblocks
+-- claim to be siblings and nothing marks the difference as a decision, because it
+-- was not one.
+--
+-- The claim on a capability-owned table is the CONSUMER
+-- (openspec/changes/capability-owned-tables D3/D8), and `dns_internal`'s
+-- declaration cannot express anything else. This makes the table agree with it.
+--
+-- `provider_module_id` STAYS. It is how a record is attributed to the resolver
+-- serving it and it is half the uniqueness key; only its ON DELETE action is
+-- wrong. It becomes a plain column with no foreign key rather than a cascade,
+-- so removing a provider leaves the ledger intact for the next one to reconcile
+-- from — which is the behaviour stage 1's provider-arrival backfill assumes.
+--
+-- SQLite cannot alter a foreign key, so the table is rebuilt. Order matters:
+-- `foreign_keys` is ON during migration, so the copy is made BEFORE the drop and
+-- the index is recreated after the rename. Same shape as
+-- `0021_dns_registration_consumers`.
+
+CREATE TABLE `__new_dns_internal_records` (
+	`id` integer PRIMARY KEY AUTOINCREMENT NOT NULL,
+	`provider_module_id` text NOT NULL,
+	`consumer_module_id` text NOT NULL,
+	`host` text NOT NULL,
+	`ip` text NOT NULL,
+	`zone_routable_ip` text,
+	`registered_at` integer DEFAULT (unixepoch()) NOT NULL,
+	FOREIGN KEY (`consumer_module_id`) REFERENCES `modules`(`id`) ON UPDATE no action ON DELETE cascade
+);
+--> statement-breakpoint
+INSERT INTO `__new_dns_internal_records` SELECT `id`, `provider_module_id`, `consumer_module_id`, `host`, `ip`, `zone_routable_ip`, `registered_at` FROM `dns_internal_records`;
+--> statement-breakpoint
+DROP TABLE `dns_internal_records`;
+--> statement-breakpoint
+ALTER TABLE `__new_dns_internal_records` RENAME TO `dns_internal_records`;
+--> statement-breakpoint
+CREATE UNIQUE INDEX `dns_internal_records_provider_host_idx` ON `dns_internal_records` (`provider_module_id`,`host`);

package/drizzle/0028_capability_bindings.sql

@@ -0,0 +1,26 @@
+-- Which provider a consumer actually resolved to.
+--
+-- `capabilities` is provider-side only. It answers "who could provide this" and
+-- has never answered "who does this module actually use", so every caller that
+-- needed the second question rebuilt the same approximation: the consumer's
+-- `requires` + `optional` crossed with `capabilities`. That names every provider
+-- a module MIGHT have bound to. A module declaring four optional capabilities
+-- and using one gets three false edges and no way to tell which is real.
+--
+-- A row is written when a consumer's hook first calls a method on an injected
+-- capability. Unique on (consumer, capability) so a redeploy re-asserts rather
+-- than duplicates, and a provider swap rewrites the provider in place.
+--
+-- `provider_module_id` is a plain column with no foreign key, matching
+-- `dns_internal_records` after 0027: removing a provider must not erase the
+-- record that a consumer was bound to it.
+CREATE TABLE `capability_bindings` (
+	`id` integer PRIMARY KEY AUTOINCREMENT NOT NULL,
+	`consumer_module_id` text NOT NULL,
+	`capability_name` text NOT NULL,
+	`provider_module_id` text NOT NULL,
+	`bound_at` integer DEFAULT (unixepoch()) NOT NULL,
+	FOREIGN KEY (`consumer_module_id`) REFERENCES `modules`(`id`) ON UPDATE no action ON DELETE cascade
+);
+--> statement-breakpoint
+CREATE UNIQUE INDEX `capability_bindings_consumer_capability_idx` ON `capability_bindings` (`consumer_module_id`,`capability_name`);

package/drizzle/0029_module_instances.sql

@@ -0,0 +1,58 @@
+-- Instances of a submodule (openspec/changes/submodules, D2 and D4).
+--
+-- An instance IS a row in `modules`, under a celilo-derived id. That is the
+-- decision this table exists to support rather than to work around: every
+-- deployment-state table in celilo keys on `module_id` and only on `module_id`
+-- (`module_systems` is PRIMARY KEY (module_id, name), `module_configs` is
+-- UNIQUE (module_id, key), `module_infrastructure` references it), so making an
+-- instance a module row means health, backup, fleet status, `module list` and
+-- the removal path all needed no change at all.
+--
+-- The alternative was adding an `instance_id` column to each of those tables and
+-- widening every key. It touches every reader and it fails QUIETLY: a query that
+-- still filters on module_id alone compiles clean and returns N rows where it
+-- expected one.
+--
+-- `module_id` is both the primary key and the FK, so an instance cannot exist
+-- without the module row it names, and dropping the module row drops this.
+--
+-- IDENTITY IS THE TRIPLE (parent_id, submodule, instance_key), never
+-- instance_key alone. Two parents may use the same key string and one parent may
+-- use the same key across two of its submodules; both are legal and neither
+-- collides. `instance_key` is opaque: celilo stores it and never interprets it,
+-- because a key derived from a display name orphans a running system the first
+-- time somebody is renamed at the identity provider.
+--
+-- `failure_reason` and `retryable` are NULL unless state = 'failed'. That is the
+-- Rule 3.4 exception (null meaning this whole section is absent) rather than a
+-- missing default. `retryable` is a column rather than something a caller infers
+-- from the reason text: a parent's reconcile loop reads it to decide whether to
+-- rebuild, and a missing interview answer will fail identically forever while a
+-- timed-out provision is worth another go. Forcing a caller to string-match the
+-- reason is how a reporter gets trusted by its shape and quietly answers wrong.
+
+CREATE TABLE `module_instances` (
+	`module_id` text PRIMARY KEY NOT NULL,
+	`parent_id` text NOT NULL,
+	`submodule` text NOT NULL,
+	`instance_key` text NOT NULL,
+	`label` text,
+	`state` text DEFAULT 'pending' NOT NULL,
+	`failure_reason` text,
+	`retryable` integer,
+	`created_at` integer DEFAULT (unixepoch()) NOT NULL,
+	`updated_at` integer DEFAULT (unixepoch()) NOT NULL,
+	FOREIGN KEY (`module_id`) REFERENCES `modules`(`id`) ON UPDATE no action ON DELETE cascade,
+	FOREIGN KEY (`parent_id`) REFERENCES `modules`(`id`) ON UPDATE no action ON DELETE cascade
+);
+--> statement-breakpoint
+-- The real identity. A database fact rather than a check somebody has to
+-- remember, so "this parent already has an instance under this key" cannot be
+-- got wrong by a caller.
+CREATE UNIQUE INDEX `module_instances_identity_idx` ON `module_instances` (`parent_id`,`submodule`,`instance_key`);--> statement-breakpoint
+-- Every reconcile call lists one parent's instances. That must not become a
+-- table scan once a fleet carries tens of them.
+CREATE INDEX `module_instances_parent_idx` ON `module_instances` (`parent_id`);--> statement-breakpoint
+-- `list` filters by state, and the collapsed operator view rolls health up per
+-- parent, which reads the same way.
+CREATE INDEX `module_instances_state_idx` ON `module_instances` (`state`);

package/drizzle/meta/_journal.json

@@ -190,6 +190,27 @@
       "when": 1784200000000,
       "tag": "0026_module_integrity_version",
       "breakpoints": true
+    },
+    {
+      "idx": 27,
+      "version": "6",
+      "when": 1784300000000,
+      "tag": "0027_dns_internal_records_consumer_cascade",
+      "breakpoints": true
+    },
+    {
+      "idx": 28,
+      "version": "6",
+      "when": 1784400000000,
+      "tag": "0028_capability_bindings",
+      "breakpoints": true
+    },
+    {
+      "idx": 29,
+      "version": "6",
+      "when": 1784400000000,
+      "tag": "0029_module_instances",
+      "breakpoints": true
     }
   ]
-}
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@celilo/cli",
-  "version": "1.7.0",
+  "version": "1.9.0",
   "description": "Celilo — home lab orchestration CLI",
   "type": "module",
   "bin": {
@@ -58,7 +58,7 @@
   "dependencies": {
     "@aws-sdk/client-s3": "^3.1109.0",
     "@aws-sdk/lib-storage": "^3.1101.0",
-    "@celilo/capabilities": "^2.4.0",
+    "@celilo/capabilities": "^3.0.0",
     "@celilo/cli-display": "^0.2.0",
     "@celilo/core": "^0.9.1",
     "@celilo/event-bus": "^0.6.0",

package/src/capabilities/validation.test.ts

@@ -824,5 +824,56 @@ describe('Capability Access Validation', () => {
       expect(refused.success).toBe(false);
       expect(refused.error).toContain('tsig_key');
     });
+
+    /**
+     * A reference in a TEMPLATE counts too. `resolver.ts` does refuse one at
+     * the point of use, so nothing is unsafe without this, but the refusal
+     * lands at generation rather than at import.
+     *
+     * That gap sits exactly where the repo sends people. CLAUDE.md's module
+     * Definition of Done says "Capability variable usage — Templates use
+     * `$capability:` syntax" and gives a `.tf.tpl` example, so the first author
+     * who follows that instruction with a RESTRICTED secret is the one who
+     * finds out late. No module in the tree references a capability from a
+     * template today, which is why the gap is currently invisible rather than
+     * absent.
+     */
+    test('a secret named only in a template is refused at import', async () => {
+      const manifest: ModuleManifest = {
+        celilo_contract: '1.0',
+        id: 'nosy-app',
+        name: 'Nosy App',
+        version: '1.0.0',
+        description: 'Test',
+        requires: { capabilities: [{ name: 'dns_internal', version: '1.0.0' }] },
+        provides: { capabilities: [{ name: 'private_web', version: '1.0.0', data: {} }] },
+        variables: { owns: [], imports: [] },
+      };
+
+      // The manifest names nothing. Only the .tf.tpl does.
+      const result = await validateCapabilityAccess(manifest, knotDb, ['dns_internal.tsig_key']);
+
+      expect(result.success).toBe(false);
+      expect(result.error).toContain("cannot access secret 'tsig_key'");
+    });
+
+    test('a non-secret template reference is still not a secret reference', async () => {
+      const manifest: ModuleManifest = {
+        celilo_contract: '1.0',
+        id: 'caddy-internal',
+        name: 'Caddy (fleet-only ingress)',
+        version: '1.0.0',
+        description: 'Test',
+        requires: { capabilities: [{ name: 'dns_internal', version: '1.0.0' }] },
+        provides: { capabilities: [{ name: 'private_web', version: '1.0.0', data: {} }] },
+        variables: { owns: [], imports: [] },
+      };
+
+      const result = await validateCapabilityAccess(manifest, knotDb, [
+        'dns_internal.server.ip.primary',
+      ]);
+
+      expect(result.success).toBe(true);
+    });
   });
 });

package/src/capabilities/validation.ts

@@ -21,11 +21,16 @@ export interface ValidationResult {
  *
  * @param manifest - Consumer module manifest
  * @param db - Database connection
+ * @param templateReferences - `<capability>.<path>` references found outside
+ *   the manifest, i.e. in the module's templates. Empty is the honest default
+ *   for a caller holding no template context; `module import` passes what the
+ *   template validator already parsed.
  * @returns Validation result
  */
 export async function validateCapabilityAccess(
   manifest: ModuleManifest,
   db: Database,
+  templateReferences: readonly string[] = [],
 ): Promise<ValidationResult> {
   // If module doesn't require capabilities, validation passes
   if (!manifest.requires?.capabilities || manifest.requires.capabilities.length === 0) {
@@ -35,7 +40,7 @@ export async function validateCapabilityAccess(
   // Get list of capabilities this module provides
   const consumerCapabilities = (manifest.provides?.capabilities || []).map((cap) => cap.name);
 
-  const references = collectCapabilityReferences(manifest);
+  const references = collectCapabilityReferences(manifest, templateReferences);
 
   // Check each required capability
   for (const requiredCapability of manifest.requires.capabilities) {
@@ -105,16 +110,25 @@ export async function validateCapabilityAccess(
  * lives — a `variables.owns[].derive_from`, a default, a capability data block —
  * without this having to track which fields may hold one.
  *
- * References made from a module's TEMPLATES are deliberately not collected here.
- * `src/variables/resolver.ts` checks access at the point of use, which is the
- * only place a template reference can be seen, and it refuses there.
+ * Template references are included too, supplied by the caller. `resolver.ts`
+ * does refuse a template reference at the point of use, so nothing is unsafe
+ * without them, but the refusal lands at generation rather than at import. That
+ * matters because a module's TEMPLATES are where this repo tells authors to put
+ * these: the Definition of Done in CLAUDE.md says "Capability variable usage —
+ * Templates use `$capability:` syntax" and gives a `.tf.tpl` example. A gate
+ * that does not fire where the documentation sends people is a gate with a hole
+ * in the shape of the instructions.
  */
-function collectCapabilityReferences(manifest: ModuleManifest): Set<string> {
-  return new Set(
-    parseVariables(JSON.stringify(manifest))
+function collectCapabilityReferences(
+  manifest: ModuleManifest,
+  templateReferences: readonly string[] = [],
+): Set<string> {
+  return new Set([
+    ...parseVariables(JSON.stringify(manifest))
       .filter((variable) => variable.type === 'capability')
       .map((variable) => variable.path),
-  );
+    ...templateReferences,
+  ]);
 }
 
 /**

package/src/cli/commands/module-show.ts

@@ -165,6 +165,7 @@ export async function handleModuleShowZone(args: string[]): Promise<CommandResul
     // compile error here rather than silently rendering as "Unknown zone". Both
     // `internal` and `secure-mgmt` were missing from the previous string-keyed map.
     const zoneDescriptions: Record<NetworkZone, string> = {
+      'isp-transit': 'ISP transit (Private segment to the router upstream of the firewall)',
       internal: 'Internal (Semi-trusted network behind the firewall)',
       dmz: 'DMZ (Public-facing services)',
       app: 'Application (Internal services)',

package/src/db/dns-internal-cascade-migration.test.ts

@@ -0,0 +1,184 @@
+/**
+ * Migration gate for celilo#1010, over a database that already holds records.
+ *
+ * `0027` rebuilds `dns_internal_records` to drop the foreign key on
+ * `provider_module_id`. A rebuild is copy, drop, rename — the most destructive
+ * shape a migration takes — and it will run on celilo-mgr, which holds the live
+ * internal DNS ledger including the `zone_routable_ip` view overrides the
+ * resolver's split-horizon config is reconciled from.
+ *
+ * Every other test in the suite starts from an empty database and can only prove
+ * the forward invariant. This one builds a database at the schema BEFORE the
+ * change, puts real rows in it, and runs the real migrator over it — the same
+ * shape as `dns-registrations-migration.test.ts`, and for the same reason: the
+ * installed base is where the risk is, and a clean-start suite cannot see it.
+ *
+ * Task 2.6 asks for backup and restore proven before this runs on celilo-mgr.
+ * This is the stronger half of that: it proves the migration PRESERVES the rows,
+ * so a restore is the fallback rather than the plan.
+ */
+
+import { Database } from 'bun:sqlite';
+import { afterEach, beforeEach, describe, expect, test } from 'bun:test';
+import { cpSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { drizzle } from 'drizzle-orm/bun-sqlite';
+import { migrate } from 'drizzle-orm/bun-sqlite/migrator';
+import { findMigrationsFolder } from './client';
+
+/** The last migration before this change — the schema celilo-mgr is on today. */
+const LAST_LEGACY_TAG = '0026_module_integrity_version';
+
+interface JournalEntry {
+  idx: number;
+  version: string;
+  when: number;
+  tag: string;
+  breakpoints: boolean;
+}
+
+/** A migrations folder truncated at `LAST_LEGACY_TAG`, built from the real files. */
+function legacyMigrationsFolder(into: string): string {
+  const source = findMigrationsFolder();
+  const journal = JSON.parse(readFileSync(join(source, 'meta', '_journal.json'), 'utf8')) as {
+    version: string;
+    dialect: string;
+    entries: JournalEntry[];
+  };
+  const cutoff = journal.entries.findIndex((e) => e.tag === LAST_LEGACY_TAG);
+  if (cutoff === -1) throw new Error(`Journal has no entry for ${LAST_LEGACY_TAG}`);
+  const kept = journal.entries.slice(0, cutoff + 1);
+
+  mkdirSync(join(into, 'meta'), { recursive: true });
+  for (const entry of kept) {
+    cpSync(join(source, `${entry.tag}.sql`), join(into, `${entry.tag}.sql`));
+  }
+  writeFileSync(
+    join(into, 'meta', '_journal.json'),
+    JSON.stringify({ ...journal, entries: kept }, null, 2),
+  );
+  return into;
+}
+
+describe('0027 over a database that already holds an internal DNS ledger', () => {
+  let tempDir: string;
+  let dbPath: string;
+
+  beforeEach(() => {
+    tempDir = mkdtempSync(join(tmpdir(), 'celilo-dnsint-'));
+    dbPath = join(tempDir, 'legacy.db');
+  });
+
+  afterEach(() => {
+    rmSync(tempDir, { recursive: true, force: true });
+  });
+
+  function openLegacyDatabase(): Database {
+    const sqlite = new Database(dbPath, { create: true });
+    sqlite.run('PRAGMA foreign_keys = ON');
+    migrate(drizzle(sqlite), {
+      migrationsFolder: legacyMigrationsFolder(join(tempDir, 'legacy-migrations')),
+    });
+    return sqlite;
+  }
+
+  function seedModule(sqlite: Database, id: string): void {
+    sqlite.run(
+      'INSERT INTO modules (id, name, source_path, version, manifest_data) VALUES (?, ?, ?, ?, ?)',
+      [id, id, `/srv/${id}`, '1.0.0', JSON.stringify({ id })],
+    );
+  }
+
+  function seedLedger(sqlite: Database): void {
+    seedModule(sqlite, 'technitium');
+    seedModule(sqlite, 'knot-unbound-internal');
+    seedModule(sqlite, 'caddy');
+    seedModule(sqlite, 'forgejo');
+    sqlite.run(
+      'INSERT INTO dns_internal_records (provider_module_id, consumer_module_id, host, ip, zone_routable_ip) VALUES (?, ?, ?, ?, ?)',
+      ['technitium', 'caddy', 'auth.example.org', '192.168.0.253', '10.0.10.14'],
+    );
+    sqlite.run(
+      'INSERT INTO dns_internal_records (provider_module_id, consumer_module_id, host, ip, zone_routable_ip) VALUES (?, ?, ?, ?, NULL)',
+      ['technitium', 'forgejo', 'git.example.org', '192.168.0.253'],
+    );
+  }
+
+  function runCurrentMigrations(sqlite: Database): void {
+    migrate(drizzle(sqlite), { migrationsFolder: findMigrationsFolder() });
+  }
+
+  test('the rebuild carries every row across, values intact', () => {
+    const sqlite = openLegacyDatabase();
+    seedLedger(sqlite);
+
+    runCurrentMigrations(sqlite);
+
+    const rows = sqlite
+      .query<
+        { host: string; ip: string; zone_routable_ip: string | null; provider_module_id: string },
+        []
+      >(
+        'SELECT host, ip, zone_routable_ip, provider_module_id FROM dns_internal_records ORDER BY host',
+      )
+      .all();
+    expect(rows).toHaveLength(2);
+    expect(rows[0]?.host).toBe('auth.example.org');
+    // The override is the value whose loss is silent: the resolver keeps
+    // answering, just with an address in-zone clients cannot route to.
+    expect(rows[0]?.zone_routable_ip).toBe('10.0.10.14');
+    expect(rows[1]?.zone_routable_ip).toBeNull();
+    // Attribution survives; only its ON DELETE action changed.
+    expect(rows[0]?.provider_module_id).toBe('technitium');
+    sqlite.close();
+  });
+
+  test('after migrating, removing the PROVIDER no longer empties the ledger', () => {
+    const sqlite = openLegacyDatabase();
+    seedLedger(sqlite);
+    runCurrentMigrations(sqlite);
+
+    sqlite.run('DELETE FROM modules WHERE id = ?', ['technitium']);
+
+    expect(
+      sqlite.query<{ c: number }, []>('SELECT COUNT(*) AS c FROM dns_internal_records').get()?.c,
+    ).toBe(2);
+    sqlite.close();
+  });
+
+  /**
+   * The behaviour that did NOT change. Dropping a foreign key is an easy way to
+   * lose the one you meant to keep, and nothing else would notice.
+   */
+  test('the consumer cascade still fires after the rebuild', () => {
+    const sqlite = openLegacyDatabase();
+    seedLedger(sqlite);
+    runCurrentMigrations(sqlite);
+
+    sqlite.run('DELETE FROM modules WHERE id = ?', ['caddy']);
+
+    const left = sqlite
+      .query<{ consumer_module_id: string }, []>(
+        'SELECT consumer_module_id FROM dns_internal_records',
+      )
+      .all();
+    expect(left.map((r) => r.consumer_module_id)).toEqual(['forgejo']);
+    sqlite.close();
+  });
+
+  /** The unique index is recreated by the rebuild, not left behind with the old table. */
+  test('the provider+host uniqueness survives the rebuild', () => {
+    const sqlite = openLegacyDatabase();
+    seedLedger(sqlite);
+    runCurrentMigrations(sqlite);
+
+    expect(() =>
+      sqlite.run(
+        'INSERT INTO dns_internal_records (provider_module_id, consumer_module_id, host, ip) VALUES (?, ?, ?, ?)',
+        ['technitium', 'forgejo', 'auth.example.org', '192.168.0.253'],
+      ),
+    ).toThrow();
+    sqlite.close();
+  });
+});