@celestia-island/hikari 0.55.117 → 0.55.118

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@celestia-island/hikari",
-  "version": "0.55.117",
+  "version": "0.55.118",
   "private": false,
   "type": "module",
   "description": "Hikari Vue 3 component library — production-grade UI components based on shittim-chest design system",

package/src/components/HkSectionCard.scss

@@ -0,0 +1,22 @@
+/* HkSectionCard — the standard titled section: heading + hint above one
+ * card. The ONLY spacing definition for that anatomy; consumers must not
+ * add their own margins/wrappers around it (2026-10-05 unification: two
+ * tabs of one page had drifted apart in hint position and body padding). */
+.hk-section-card {
+  display: flex;
+  flex-direction: column;
+  /* Heading block → body. One token, both axes of the rhythm (the header
+     carries its own 4px title→hint gap). */
+  gap: var(--space-12, 0.75rem);
+  min-width: 0;
+}
+
+/* Trailing notes under the card (the section's own footnote slot). No font
+   override: a footer may carry prose or a control — it only owns the
+   rhythm, so consumers stop inventing their own top margin. */
+.hk-section-card-footer {
+  display: flex;
+  flex-direction: column;
+  gap: var(--space-4, 0.25rem);
+  min-width: 0;
+}

package/src/components/HkSectionCard.styles.test.ts

@@ -0,0 +1,42 @@
+/**
+ * Style contract (house pattern: HkAboutModal.styles.test.ts) — the
+ * section card's class↔rule wiring. `sheetCompile.test.ts` proves every
+ * sheet COMPILES; nothing else proves the classes the component emits are
+ * the ones the sheet styles, so a rename on either side would silently
+ * orphan the rule (the #493 failure mode).
+ */
+import { describe, expect, it } from "vitest";
+import { readFileSync } from "node:fs";
+import { dirname, join } from "node:path";
+import { fileURLToPath } from "node:url";
+
+const here = dirname(fileURLToPath(import.meta.url));
+const tsx = readFileSync(join(here, "HkSectionCard.tsx"), "utf-8");
+const scss = readFileSync(join(here, "HkSectionCard.scss"), "utf-8");
+
+/** Every `hk-section-card*` class the component emits. */
+function emittedClasses(): string[] {
+  const found = new Set<string>();
+  for (const m of tsx.matchAll(/"(hk-section-card[a-z-]*)"/g)) found.add(m[1]!);
+  for (const m of tsx.matchAll(/\bhk-section-card[a-z-]*\b/g)) found.add(m[0]);
+  return [...found].sort();
+}
+
+describe("HkSectionCard styles", () => {
+  it("emits at least the wrapper and the footer (the guard is not vacuous)", () => {
+    const classes = emittedClasses();
+    expect(classes).toContain("hk-section-card");
+    expect(classes).toContain("hk-section-card-footer");
+  });
+
+  it("styles every class the component emits", () => {
+    for (const cls of emittedClasses()) {
+      expect(scss, `${cls} must have a rule`).toMatch(new RegExp(`\\.${cls}\\s*\\{`));
+    }
+  });
+
+  it("keeps the intra-section rhythm token on the wrapper and the footer", () => {
+    expect(scss).toMatch(/\.hk-section-card\s*\{[^}]*gap:\s*var\(--space-12/);
+    expect(scss).toMatch(/\.hk-section-card-footer\s*\{[^}]*gap:\s*var\(--space-4/);
+  });
+});

package/src/components/HkSectionCard.test.tsx

@@ -0,0 +1,156 @@
+import { afterEach, describe, expect, it } from "vitest";
+import { createApp, h } from "vue";
+
+import { HkSectionCard } from "./HkSectionCard";
+
+/**
+ * HkSectionCard contract — the section-level chrome standard:
+ * - the heading block carries the title and the hint (its ONLY place: the
+ *   drift this component exists to end was one section printing its hint
+ *   above the table and another below it)
+ * - the body is ONE card: flush for tables (padded default false), padded
+ *   when the body is not a table
+ * - `error` replaces the body with an alert and `loading` with a spinner,
+ *   both inside a PADDED card — a state is content, not a table
+ * - the optional `actions` slot reaches the header (the heading row's
+ *   trailing affordances), not the card
+ *
+ * (Repo test convention: raw createApp + document queries, no
+ * @vue/test-utils.)
+ */
+
+const mounts: Array<{ app: ReturnType<typeof createApp>; container: HTMLElement }> = [];
+
+afterEach(() => {
+  while (mounts.length) {
+    const { app, container } = mounts.pop()!;
+    app.unmount();
+    container.remove();
+  }
+});
+
+function mountCard(props: Record<string, unknown>, slots: Record<string, () => unknown> = {}) {
+  const container = document.createElement("div");
+  document.body.appendChild(container);
+  const app = createApp({
+    render: () => h(HkSectionCard, props as never, slots as never),
+  });
+  mounts.push({ app, container });
+  app.mount(container);
+  return container;
+}
+
+describe("HkSectionCard", () => {
+  it("renders the title and the hint in the heading block, above the card", () => {
+    const c = mountCard({ title: "Public domains", hint: "Where this instance is reachable." }, {
+      default: () => h("table", { class: "body-table" }, h("tbody")),
+    });
+    const header = c.querySelector(".hk-section-header")!;
+    expect(header.textContent).toContain("Public domains");
+    expect(header.textContent).toContain("Where this instance is reachable.");
+    // The hint belongs to the HEADER, never to the card body.
+    const card = c.querySelector(".hk-card")!;
+    expect(card.textContent).not.toContain("Where this instance is reachable.");
+    expect(card.querySelectorAll(".body-table")).toHaveLength(1);
+    // Header precedes the card in document order (the one rhythm).
+    expect(header.compareDocumentPosition(card) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
+  });
+
+  it("keeps a table body flush in the card and pads a non-table body on request", () => {
+    const flush = mountCard({ title: "T" }, { default: () => h("span", "row") });
+    // HkCard spells "no padding" as a body modifier — the body carries the
+    // padding decision, not the card shell.
+    expect(flush.querySelector(".hk-card-body")!.className).toContain("hk-card-body-unpadded");
+    const padded = mountCard({ title: "T", padded: true }, { default: () => h("span", "row") });
+    // HkCard carries the padding itself — no caller wrapper.
+    expect(padded.querySelector(".hk-card-body")!.className).not.toContain("hk-card-body-unpadded");
+  });
+
+  it("replaces the body with an alert on error, inside a padded card", () => {
+    const c = mountCard({ title: "T", error: "boom" }, { default: () => h("span", "row") });
+    expect(c.querySelector(".hk-alert")).not.toBeNull();
+    expect(c.textContent).toContain("boom");
+    expect(c.querySelector(".hk-card-body")!.className).not.toContain("hk-card-body-unpadded");
+    expect(c.textContent).not.toContain("row");
+  });
+
+  it("replaces the body with a centred spinner while loading", () => {
+    const c = mountCard({ title: "T", loading: true }, { default: () => h("span", "row") });
+    expect(c.querySelector(".hk-spinner")).not.toBeNull();
+    expect(c.querySelector(".hk-card-body")!.className).not.toContain("hk-card-body-unpadded");
+    expect(c.textContent).not.toContain("row");
+  });
+
+  it("lets error win when both error and loading are set", () => {
+    const c = mountCard({ title: "T", error: "boom", loading: true }, {
+      default: () => h("span", "row"),
+    });
+    expect(c.querySelector(".hk-alert")).not.toBeNull();
+    expect(c.querySelector(".hk-spinner")).toBeNull();
+    expect(c.textContent).toContain("boom");
+  });
+
+  it("forwards the description slot into the hint position", () => {
+    const c = mountCard({ title: "T" }, { description: () => h("span", "own hint") });
+    const header = c.querySelector(".hk-section-header")!;
+    expect(header.querySelector(".hk-section-header-description")!.textContent).toContain("own hint");
+    expect(c.querySelector(".hk-card")!.textContent).not.toContain("own hint");
+  });
+
+  it("forwards icon, level and dense to the heading", () => {
+    const Icon = () => h("svg", { class: "own-icon" });
+    const c = mountCard({ title: "T", icon: Icon, level: "h2", dense: true });
+    const header = c.querySelector(".hk-section-header")!;
+    expect(header.classList.contains("hk-section-header-dense")).toBe(true);
+    expect(header.querySelector("h2")).not.toBeNull();
+    expect(header.querySelector(".own-icon")).not.toBeNull();
+    const plain = mountCard({ title: "T" });
+    expect(plain.querySelector(".hk-section-header h3")).not.toBeNull();
+  });
+
+  it("forwards the actions slot into the heading row", () => {
+    const c = mountCard({ title: "T" }, { actions: () => h("button", { class: "hdr-act" }, "x") });
+    expect(c.querySelector(".hk-section-header")!.querySelector(".hdr-act")).not.toBeNull();
+    expect(c.querySelector(".hk-card")!.querySelector(".hdr-act")).toBeNull();
+  });
+
+  it("renders the footer under the card — and nothing when no footer is given", () => {
+    const c = mountCard({ title: "T" }, {
+      default: () => h("span", "row"),
+      footer: () => h("p", { class: "note" }, "keep this"),
+    });
+    const footer = c.querySelector(".hk-section-card-footer")!;
+    expect(footer.querySelector(".note")!.textContent).toBe("keep this");
+    // Under the CARD, not inside it, and after it in document order.
+    const card = c.querySelector(".hk-card")!;
+    expect(card.querySelector(".note")).toBeNull();
+    expect(card.compareDocumentPosition(footer) & Node.DOCUMENT_POSITION_FOLLOWING).toBeTruthy();
+
+    const bare = mountCard({ title: "T" });
+    expect(bare.querySelector(".hk-section-card-footer")).toBeNull();
+  });
+
+  it("renders no empty header wrapper when only one of the two slots is given", () => {
+    // R3 finding: forwarding an absent slot as a function returning
+    // undefined left an empty `.hk-section-header-actions` /
+    // `.hk-section-header-description` node behind — and in the column-flex
+    // heading a zero-height item still eats a gap slot.
+    const actionsOnly = mountCard({ title: "T" }, { actions: () => h("button", "x") });
+    expect(actionsOnly.querySelector(".hk-section-header-actions")).not.toBeNull();
+    expect(actionsOnly.querySelector(".hk-section-header-description")).toBeNull();
+
+    const descriptionOnly = mountCard({ title: "T" }, { description: () => h("span", "hint") });
+    expect(descriptionOnly.querySelector(".hk-section-header-description")).not.toBeNull();
+    expect(descriptionOnly.querySelector(".hk-section-header-actions")).toBeNull();
+
+    const neither = mountCard({ title: "T" });
+    expect(neither.querySelector(".hk-section-header-actions")).toBeNull();
+    expect(neither.querySelector(".hk-section-header-description")).toBeNull();
+  });
+
+  it("carries the count into the title and renders no hint paragraph when none is given", () => {
+    const c = mountCard({ title: "T", count: "3" });
+    expect(c.querySelector(".hk-section-header-count")!.textContent).toBe("3");
+    expect(c.querySelector(".hk-section-header-description")).toBeNull();
+  });
+});

package/src/components/HkSectionCard.tsx

@@ -0,0 +1,122 @@
+import { defineComponent, type Component, type PropType } from "vue";
+
+import HkAlert from "./HkAlert";
+import HkCard from "./HkCard";
+import { HkSectionHeader } from "./HkSectionHeader";
+import HkSpinner from "./HkSpinner";
+import "./HkSectionCard.scss";
+
+/**
+ * HkSectionCard — the standard titled SECTION: a heading (with an optional
+ * hint line) above ONE card that carries the body.
+ *
+ * This is the section-level twin of the page-level scaffold
+ * (`HkAdminTablePage`): a page whose content is several lists (settings
+ * categories, tab panels, dashboards) renders each as an HkSectionCard, so
+ * the heading→body rhythm, the hint typography and the body padding come
+ * from ONE definition instead of every caller hand-rolling `mt-3`,
+ * `p-4`/`padded={false}` wrappers and its own hint classes — the drift the
+ * 2026-10-05 audit found between two tabs of the same page (one table flush
+ * in the card with its hint above, the other wrapped in a padded div with
+ * its hint below).
+ *
+ * The body states follow `HkAdminTablePage`'s contract: `error` replaces
+ * the body with an alert, `loading` with a centred spinner — both inside a
+ * PADDED card (a state is content, not a table), while the normal body
+ * honours `padded` (default false: tables carry their own cell padding and
+ * sit flush in the card). `error` wins when both are set, as on the
+ * scaffold.
+ *
+ * The section owns the INTRA-section rhythm only (heading block → card). The
+ * page owns the gap BETWEEN sections: several siblings on one page need the
+ * parent's own `gap` (a flex/grid column), because this component adds no
+ * outer margin by design — otherwise a page that renders three sections
+ * would stack them flush.
+ *
+ * A `footer` slot renders trailing notes under the card (placeholder
+ * grammars, "what this list feeds" details) with the same rhythm, so those
+ * notes stop being a per-consumer margin.
+ *
+ * One deliberate difference from the scaffold: `loading` replaces the body
+ * whenever it is true, where `HkAdminTablePage` only replaces an EMPTY body
+ * (`loading && !rows.length`) and keeps populated rows on screen through a
+ * refresh. A section therefore passes `loading` for its FIRST load, not for
+ * every refetch — or it blanks a table the user is reading.
+ *
+ * ```tsx
+ * <HkSectionCard title={t("…")} hint={t("…")} loading={loading}>
+ *   <HkTable columns={columns} rows={rows} rowKey="id">{…}</HkTable>
+ * </HkSectionCard>
+ * ```
+ */
+export const HkSectionCard = defineComponent({
+  name: "HkSectionCard",
+  props: {
+    title: { type: String, required: true },
+    /** Explanatory line under the heading — the standard place for the
+     *  "what this list is for" copy every section used to spell its own. */
+    hint: { type: String, default: undefined },
+    icon: { type: [Object, Function] as PropType<Component>, default: undefined },
+    /** Heading level only; the visual size is fixed by the header styles. */
+    level: { type: String as PropType<"h2" | "h3" | "div">, default: "h3" },
+    /** Trailing count beside the title (e.g. "3"). */
+    count: { type: String, default: undefined },
+    /** Tighter header spacing for dense panels. */
+    dense: { type: Boolean, default: false },
+    /** Hard failure: replaces the body with an alert. */
+    error: { type: String, default: undefined },
+    /** In-flight: replaces the body with a centred spinner. */
+    loading: { type: Boolean, default: false },
+    /** Body padding for non-table content (tables stay flush). */
+    padded: { type: Boolean, default: false },
+  },
+  setup(props, { slots }) {
+    return () => {
+      const state = props.error ? "error" : props.loading ? "loading" : "body";
+      // Hoisted to an identifier: the CONDITIONAL inline form
+      // (`{slots.actions ? { actions: … } : undefined}` as children) lands in
+      // a child array, where the plain object is no longer normalized to
+      // slots and the button silently disappears. Hoisting fixes it; the
+      // bare inline literal happens to work, which is exactly why the
+      // conditional one is a trap.
+      // Each slot is spread CONDITIONALLY: forwarding an absent one as a
+      // function that returns undefined defeats HkSectionHeader's own
+      // empty-node guard, which renders an empty wrapper (and, in the
+      // column-flex heading, a phantom gap slot) — a whitespace-only
+      // regression the R3 review caught.
+      const headerSlots =
+        slots.actions || slots.description
+          ? {
+              ...(slots.actions ? { actions: () => slots.actions?.() } : {}),
+              ...(slots.description ? { description: () => slots.description?.() } : {}),
+            }
+          : undefined;
+      return (
+        <section class="hk-section-card">
+          <HkSectionHeader
+            title={props.title}
+            description={props.hint}
+            icon={props.icon}
+            level={props.level}
+            count={props.count}
+            dense={props.dense}
+          >
+            {headerSlots}
+          </HkSectionHeader>
+          <HkCard padded={state === "body" ? props.padded : true}>
+            {state === "error" ? (
+              <HkAlert message={props.error!} />
+            ) : state === "loading" ? (
+              <HkSpinner center />
+            ) : (
+              slots.default?.()
+            )}
+          </HkCard>
+          {slots.footer ? <div class="hk-section-card-footer">{slots.footer()}</div> : null}
+        </section>
+      );
+    };
+  },
+});
+
+export default HkSectionCard;

package/src/index.ts

@@ -818,6 +818,8 @@ export { HkCardList, HkListRow } from "./components/HkCardList";
 export { HkCardList as HCardList, HkListRow as HListRow } from "./components/HkCardList";
 export { HkSectionHeader, type SectionHeaderVariant } from "./components/HkSectionHeader";
 export { HkSectionHeader as HSectionHeader } from "./components/HkSectionHeader";
+export { HkSectionCard } from "./components/HkSectionCard";
+export { HkSectionCard as HSectionCard } from "./components/HkSectionCard";
 export { default as HFilterBar } from "./components/HkFilterBar";
 export { HkShareBar as HkShareBar } from "./components/HkShareBar";
 export { HkSecretRevealModal as HkSecretRevealModal } from "./components/HkSecretRevealModal";