@ccoalm/ccl-skills 0.7.0 → 0.9.0

package/dist/assets/marketplace/plugins/ccl-skills/skills/skill-extraction-workflow/scripts/test_validate_skill_cross_refs.sh

@@ -94,7 +94,37 @@ out="$(bash "$VALIDATE" "$TMP/skills/skill-a" 2>&1)"; rc=$?
 set -e
 [ "$rc" -eq 0 ] || fail "brace-glob cross-package reference must be skipped; rc=$rc\n$out"
 
-# (5) Self-check: the harness can fail (re-run case 1 shape).
+# (5) A relative reference inside references/*.md resolves from that Markdown
+# file's directory, matching normal Markdown navigation rather than SKILL root.
+mkdir -p "$TMP/skills/skill-a/references"
+cat > "$TMP/skills/skill-a/references/nested.md" <<'EOF'
+# Nested reference
+
+The sibling canonical is `../../skill-b/references/ok.md`.
+EOF
+set +e
+out="$(bash "$VALIDATE" "$TMP/skills/skill-a" 2>&1)"; rc=$?
+set -e
+[ "$rc" -eq 0 ] || fail "existing nested relative reference should pass; rc=$rc\n$out"
+
+# (6) The same source-relative rule still rejects a missing target.
+cat > "$TMP/skills/skill-a/references/nested.md" <<'EOF'
+# Nested reference
+
+The missing sibling file is `../../skill-b/references/missing.md`.
+EOF
+set +e
+out="$(bash "$VALIDATE" "$TMP/skills/skill-a" 2>&1)"; rc=$?
+set -e
+[ "$rc" -ne 0 ] || fail "dangling nested relative reference must fail validation"
+case "$out" in
+  *missing_markdown_references*../../skill-b/references/missing.md*) ;;
+  *) fail "dangling nested relative reference not reported as missing:\n$out" ;;
+esac
+
+rm "$TMP/skills/skill-a/references/nested.md"
+
+# (7) Self-check: the harness can fail (re-run case 1 shape).
 cat > "$TMP/skills/skill-a/SKILL.md" <<'EOF'
 ---
 name: skill-a

package/dist/assets/marketplace/plugins/ccl-skills/skills/skill-extraction-workflow/scripts/validate-skill.sh

@@ -74,13 +74,18 @@ roots.each do |root|
         next
       end
       next unless ref.start_with?("references/") || ref.start_with?("../")
-      candidate =
+      candidates =
         if ref.start_with?("../")
-          File.expand_path(ref, root)
+          # Relative Markdown references navigate from the document that
+          # contains them. SKILL.md still resolves from root because it lives
+          # there; references/*.md resolves from references/. Preserve the
+          # Preserve the legacy skill-root lookup as a compatibility fallback
+          # for older prose locators until those documents are migrated.
+          [File.expand_path(ref, File.dirname(path)), File.expand_path(ref, root)].uniq
         else
-          File.join(root, ref)
+          [File.join(root, ref)]
         end
-      missing << [File.basename(root), path.sub(root + "/", ""), ref] unless File.exist?(candidate)
+      missing << [File.basename(root), path.sub(root + "/", ""), ref] unless candidates.any? { |candidate| File.exist?(candidate) }
     end
   end
 end