@ccoalm/ccl-skills 0.7.0 → 0.8.0

package/dist/assets/marketplace/plugins/ccl-skills/skills/code-review/scripts/test_claude_review_probe.sh

@@ -1885,6 +1885,7 @@ PY
 # the skill tree. The runtime-surface classifier must be present there too.
 mkdir -p "$tmp_dir/harness/scripts"
 cp "$script_dir/claude_review.sh" "$tmp_dir/harness/scripts/"
+cp "$script_dir/normalize_review_timeout.sh" "$tmp_dir/harness/scripts/"
 cp "$script_dir/run_claude_capture.py" "$tmp_dir/harness/scripts/"
 cp "$script_dir/parse_review_json.py" "$tmp_dir/harness/scripts/"
 cp "$script_dir/parse_probe_result.py" "$tmp_dir/harness/scripts/"
@@ -1901,6 +1902,7 @@ PY
 # When the runtime classifier is absent, both review and challenge fail closed.
 mkdir -p "$tmp_dir/harness-no-runtime-parser/scripts"
 cp "$script_dir/claude_review.sh" "$tmp_dir/harness-no-runtime-parser/scripts/"
+cp "$script_dir/normalize_review_timeout.sh" "$tmp_dir/harness-no-runtime-parser/scripts/"
 cp "$script_dir/run_claude_capture.py" "$tmp_dir/harness-no-runtime-parser/scripts/"
 cp "$script_dir/parse_review_json.py" "$tmp_dir/harness-no-runtime-parser/scripts/"
 cp "$script_dir/classify_envelope.py" "$tmp_dir/harness-no-runtime-parser/scripts/"
@@ -1927,11 +1929,11 @@ done
 
 # Other local harness helpers are integrity inputs too; their absence must stop
 # instead of being laundered into an eligible provider fallback.
-for missing_helper in run_claude_capture.py classify_envelope.py parse_review_json.py; do
+for missing_helper in normalize_review_timeout.sh run_claude_capture.py classify_envelope.py parse_review_json.py; do
   helper_slug="${missing_helper%.py}"
   helper_dir="$tmp_dir/harness-no-$helper_slug/scripts"
   mkdir -p "$helper_dir"
-  for helper in claude_review.sh run_claude_capture.py parse_review_json.py parse_probe_result.py classify_envelope.py; do
+  for helper in claude_review.sh normalize_review_timeout.sh run_claude_capture.py parse_review_json.py parse_probe_result.py classify_envelope.py; do
     [ "$helper" = "$missing_helper" ] || cp "$script_dir/$helper" "$helper_dir/"
   done
   set +e
@@ -1951,7 +1953,10 @@ payload = json.load(open(sys.argv[2], encoding="utf-8"))
 assert payload["mode"] == "review", payload
 assert payload["status"] == "inconclusive", payload
 assert helper in payload["reason"], payload
-assert payload["reason_code"] == "policy_denied", payload
+expected_reason_code = (
+    "local_tool_failure" if helper == "normalize_review_timeout.sh" else "policy_denied"
+)
+assert payload["reason_code"] == expected_reason_code, payload
 assert payload["fallback_eligible"] is False, payload
 assert payload["next_action"] == "stop_reviewer_lane", payload
 PY

package/dist/assets/marketplace/plugins/ccl-skills/skills/code-review/scripts/test_review_client_compat.py

@@ -5,7 +5,10 @@ from __future__ import annotations
 
 import argparse
 import importlib.util
+import json
+import os
 from pathlib import Path
+import subprocess
 import sys
 import tempfile
 import unittest
@@ -420,7 +423,8 @@ class ReviewClientCompatibilityTest(unittest.TestCase):
     def test_kimi_bounds_inline_argv_exposure_and_file_backs_large_packets(self) -> None:
         wrapper = (SCRIPT_DIR / "kimi_review.sh").read_text(encoding="utf-8")
 
-        self.assertIn('[ "$TIMEOUT" -le 600 ] || TIMEOUT=600', wrapper)
+        self.assertIn('. "$SCRIPT_DIR/normalize_review_timeout.sh"', wrapper)
+        self.assertIn('TIMEOUT="$(normalize_review_timeout "$TIMEOUT")"', wrapper)
         self.assertIn("visible in process argv", wrapper)
         self.assertIn("MAX_INLINE_PROMPT_BYTES=16000", wrapper)
         self.assertIn('[ "$FORMAL_TIMEOUT" -le 120 ] || FORMAL_TIMEOUT=120', wrapper)
@@ -429,6 +433,77 @@ class ReviewClientCompatibilityTest(unittest.TestCase):
         self.assertIn('--agent-file "$AGENT_FILE"', wrapper)
         self.assertIn("mcp__code_review_packet__read_packet", wrapper)
 
+    def test_every_wrapper_guards_the_shared_timeout_normalizer(self) -> None:
+        for wrapper_name in (
+            "claude_review.sh",
+            "codex_review.sh",
+            "kimi_review.sh",
+            "opencode_review.sh",
+        ):
+            with self.subTest(wrapper=wrapper_name):
+                wrapper = (SCRIPT_DIR / wrapper_name).read_text(encoding="utf-8")
+                if wrapper_name == "claude_review.sh":
+                    guard = '[ -f "$script_dir/normalize_review_timeout.sh" ]'
+                    source = '. "$script_dir/normalize_review_timeout.sh"'
+                    missing_contract = (
+                        'emit_inconclusive_payload "Claude review helper missing: '
+                        'normalize_review_timeout.sh" local_tool_failure false '
+                        "stop_reviewer_lane"
+                    )
+                    missing_contracts = (missing_contract,)
+                else:
+                    guard = '[ -f "$SCRIPT_DIR/normalize_review_timeout.sh" ]'
+                    source = '. "$SCRIPT_DIR/normalize_review_timeout.sh"'
+                    missing_contracts = (
+                        "timeout_normalizer_missing",
+                        "local_tool_failure false",
+                    )
+                self.assertIn(guard, wrapper)
+                for missing_contract in missing_contracts:
+                    self.assertIn(missing_contract, wrapper)
+                self.assertLess(wrapper.index(guard), wrapper.index(source))
+
+    def test_every_wrapper_rejects_below_minimum_timeout_at_runtime(self) -> None:
+        with tempfile.TemporaryDirectory() as temp_dir:
+            opencode = Path(temp_dir) / "opencode"
+            opencode.write_text("#!/bin/sh\nexit 99\n", encoding="utf-8")
+            opencode.chmod(0o755)
+            environment = {**os.environ, "PATH": f"{temp_dir}:{os.environ['PATH']}"}
+            for wrapper_name in (
+                "claude_review.sh",
+                "codex_review.sh",
+                "kimi_review.sh",
+                "opencode_review.sh",
+            ):
+                with self.subTest(wrapper=wrapper_name):
+                    command = ["bash", str(SCRIPT_DIR / wrapper_name)]
+                    if wrapper_name == "claude_review.sh":
+                        command.append("review")
+                    elif wrapper_name == "opencode_review.sh":
+                        command.extend(("--implementer-family", "openai"))
+                    command.extend(("--timeout", "4"))
+                    completed = subprocess.run(
+                        command,
+                        check=False,
+                        capture_output=True,
+                        text=True,
+                        env=environment,
+                    )
+                    self.assertEqual(completed.returncode, 2, completed.stderr)
+                    payload = json.loads(completed.stdout)
+                    self.assertEqual(payload["status"], "inconclusive")
+                    self.assertEqual(payload["reason_code"], "invalid_input")
+                    expected_reason = (
+                        "--timeout must be an integer of at least 5 seconds"
+                        if wrapper_name == "claude_review.sh"
+                        else "invalid_timeout"
+                    )
+                    self.assertEqual(payload["reason"], expected_reason)
+                    eligibility = payload.get(
+                        "fallback_eligible", payload.get("cascade_eligible")
+                    )
+                    self.assertFalse(eligibility)
+
 
 if __name__ == "__main__":
     unittest.main()