@ccoalm/ccl-skills 0.18.10 → 0.18.12

package/dist/assets/marketplace/plugins/ccl-skills/skills/skill-extraction-workflow/scripts/test_ai_coding_implementation_gates.sh

@@ -270,7 +270,7 @@ assert_in_section "$PRE_FINAL_REF" '## Gate triggers and outcome contract' 'cite
 assert_same_line "$REPO_ROOT/AGENTS.md" '授权按用户已明确的交付目标判断' '只授权单项、只问状态、明确停止或限制范围时遵守该边界' "goal authority (root scope and stop)"
 assert_contains "$REPO_ROOT/docs/npm-release.md" 'Do not ask again for each prerequisite' "goal authority (release follows through)"
 assert_contains "$REPO_ROOT/skills/release-coordination/SKILL.md" 'Existing host permission checks and resource-owner requirements still apply' "goal authority (host and resource boundary)"
-assert_contains "$REPO_ROOT/skills/worktree-isolation/SKILL.md" '目标/批量授权内由 agent 完成的修复、新提交或新建 MR，先刷新检查、评审与状态，不重复请求权限' "goal authority (repair refreshes evidence)"
+assert_contains "$REPO_ROOT/skills/worktree-isolation/references/merge-and-teardown.md" '目标/批量授权内由 agent 完成的修复、新提交或新建 MR，先刷新检查、评审与状态，不重复请求权限' "goal authority (repair refreshes evidence)"
 assert_contains "$REPO_ROOT/skills/product-rd-workflow/references/refactoring-discipline.md" 'do not ask again merely because it involves refactoring' "quality gate (authorized cleanup)"
 assert_contains "$REPO_ROOT/skills/product-rd-workflow/references/refactoring-discipline.md" 'Do not abbreviate meaningful names, remove necessary explanations, pack statements, fragment responsibilities arbitrarily, or change the threshold/history just to satisfy a counter.' "quality gate (readability and metric integrity)"
 assert_contains "$REPO_ROOT/skills/product-rd-workflow/references/refactoring-discipline.md" 'Broader redesign and breaking changes retain their scope and approval checks.' "quality gate (scope and compatibility boundary)"
@@ -871,4 +871,143 @@ assert_contains "$DELEGATION_SKILL" 'method/evidence checkpoint, not renewed tas
 assert_contains "$DELEGATION_SKILL" 'unknown completion state or missing authority remains after bounded remediation' "delegation preserves unresolved blockers"
 assert_contains "$DELEGATION_SKILL" 'respecting explicit user limits' "delegation preserves user limits"
 
+# 9. Worktree teardown guard on every surface that restates removal (round 162).
+# `git worktree remove` without --force deletes gitignored files and exits 0, so
+# the pre-removal scan is the only guard for costly outputs. Each surface that
+# restates the removal carries the scan, its success condition and a pointer to
+# the canonical teardown section; the sweep below requires the same of any
+# Markdown surface added later. Rows are data so test_teardown_guard_pins.sh can
+# apply one mutation per row: kind|repo-relative file|scope|phrase|label, where
+# scope is a section heading (section, order) or the anchor of the line that
+# must carry the phrase (line); an order row's phrase reads `first ⟶ second`,
+# both inside the section and in that order.
+assert_order_in_section() {
+  local file="$1" heading="$2" pair="$3" label="$4"
+  local first="${pair%% ⟶ *}" second="${pair#* ⟶ }"
+  [[ "$first" != "$pair" && -n "$first" && -n "$second" ]] || fail "$label: order row must read 'first ⟶ second'"
+  [[ -f "$file" ]] || fail "$label: missing file $file"
+  local section a b
+  section="$(awk -v h="$heading" '$0 == h {inside = 1; next} inside && /^#/ {exit} inside {print}' "$file")"
+  [[ -n "$section" ]] || fail "$label: section not found or empty: $heading"
+  a="$(grep -n -F -m1 -- "$first" <<< "$section")" || fail "$label: \`$first\` absent from section $heading"
+  b="$(grep -n -F -m1 -- "$second" <<< "$section")" || fail "$label: \`$second\` absent from section $heading"
+  (( ${a%%:*} < ${b%%:*} )) || fail "$label: \`$first\` must come before \`$second\` in section $heading"
+}
+
+TEARDOWN_PINS="$(cat <<'PINS'
+section|skills/product-rd-workflow/references/worktree-mechanics.md|## Closeout Cleanup|the closeout section (`## 收尾`) of `worktree-isolation/references/merge-and-teardown.md`|product-rd cleanup names the canonical teardown
+section|skills/product-rd-workflow/references/worktree-mechanics.md|## Closeout Cleanup|you must run `git -C <path> status --ignored -s` from the primary checkout|product-rd cleanup scans gitignored outputs first
+section|skills/product-rd-workflow/references/worktree-mechanics.md|## Closeout Cleanup|It must exit 0; a failed scan counts as no scan|product-rd cleanup treats a failed scan as no scan
+section|skills/product-rd-workflow/references/worktree-mechanics.md|## Closeout Cleanup|copy costly ones (long-running results, collected data, trained artifacts) back to the primary checkout before removal|product-rd cleanup rescues costly outputs
+section|skills/product-rd-workflow/references/worktree-mechanics.md|## Closeout Cleanup|When unsure, treat an entry as costly|product-rd cleanup treats uncertain entries as costly
+section|skills/product-rd-workflow/references/worktree-mechanics.md|## Closeout Cleanup|wait for it to finish; never kill it to clean up|product-rd cleanup waits for in-flight side effects
+section|skills/product-rd-workflow/references/worktree-mechanics.md|## Closeout Cleanup|Never pass `--force` to `git worktree remove` or use `git branch -D`|product-rd cleanup forbids forced removal
+section|skills/product-rd-workflow/references/worktree-mechanics.md|## Closeout Cleanup|Never delete a permanent or integration branch, or any branch whose name contains `release`|product-rd cleanup keeps permanent and release branches
+order|skills/product-rd-workflow/references/worktree-mechanics.md|## Closeout Cleanup|status --ignored -s   # must exit 0 ⟶ git worktree remove <path>|product-rd recipe scans before it removes
+line|skills/multi-agent-delegation/references/multi-agent-delegation-playbook.md|Every worktree removal below must run the pre-removal scan|`worktree-isolation/references/merge-and-teardown.md`|delegation cleanup names the canonical teardown
+line|skills/multi-agent-delegation/references/multi-agent-delegation-playbook.md|Every worktree removal below must run the pre-removal scan|`git -C <worktree-path> status --ignored -s` must exit 0, and a failed scan counts as no scan|delegation cleanup scans gitignored outputs first
+line|skills/multi-agent-delegation/references/multi-agent-delegation-playbook.md|Every worktree removal below must run the pre-removal scan|Copy costly gitignored outputs the worker produced (long-running results, collected data, trained artifacts) into the target checkout before removal|delegation cleanup rescues costly outputs
+line|skills/multi-agent-delegation/references/multi-agent-delegation-playbook.md|Every worktree removal below must run the pre-removal scan|Record the scan exit status and each kept or dropped entry in `cleanup_proof`|delegation cleanup records the scan in cleanup_proof
+order|skills/multi-agent-delegation/references/multi-agent-delegation-playbook.md|## Handoff-Style Delivery Recipe|Every worktree removal below must run the pre-removal scan ⟶ For local-commit-only handoff|delegation scan precedes the removal paths
+line|skills/skill-extraction-workflow/references/extraction-lifecycle-handoff.md|**Isolate each change with a worktree, not a clone.**|`worktree-isolation/references/merge-and-teardown.md`|extraction worktree names the canonical teardown
+line|skills/skill-extraction-workflow/references/extraction-lifecycle-handoff.md|**Isolate each change with a worktree, not a clone.**|you must scan its gitignored outputs before removal (`git -C <worktree> status --ignored -s`, which must exit 0)|extraction worktree scans before removal
+line|skills/skill-extraction-workflow/references/extraction-lifecycle-handoff.md|**Isolate each change with a worktree, not a clone.**|copy any output that is costly to recreate back to the standing checkout|extraction worktree rescues costly outputs
+line|skills/worktree-isolation/references/merge-and-teardown.md|**任何方式删除单个 worktree 目录之前**|都必须先 `git -C <worktree路径> status --ignored -s` 扫 gitignored 产物|canonical scan precedes any removal
+line|skills/worktree-isolation/references/merge-and-teardown.md|**任何方式删除单个 worktree 目录之前**|① 该命令**必须 exit 0**|canonical scan must succeed
+line|skills/worktree-isolation/references/merge-and-teardown.md|**任何方式删除单个 worktree 目录之前**|② 输出非空即逐条判定保留/丢弃并向用户列出结论|canonical lists each kept or dropped entry
+line|skills/worktree-isolation/references/merge-and-teardown.md|**任何方式删除单个 worktree 目录之前**|③ 判据看**重算代价**|canonical judges by recompute cost
+line|skills/worktree-isolation/references/merge-and-teardown.md|**任何方式删除单个 worktree 目录之前**|宿主原生移除如 Claude Code `ExitWorktree` 的 remove|canonical scan covers host-native removal
+line|skills/worktree-isolation/references/merge-and-teardown.md|**交互式 merge 选项菜单**|删前照样先按上文扫 gitignored 产物|canonical handoff keeps the scan for external finishing skills
+order|skills/worktree-isolation/references/merge-and-teardown.md|## 收尾：worktree 一集成就清理（本地 + 远端，不留垃圾）|git -C <path> status --ignored -s  # sweep 之外 ⟶ git worktree remove <path>      # 删本地|canonical recipe scans before it removes
+PINS
+)"
+teardown_rows=0
+while IFS='|' read -r kind rel scope phrase label extra; do
+  [[ -n "$kind" ]] || continue
+  [[ -z "$extra" && -n "$label" ]] || fail "teardown guard: malformed pin row: $kind|$rel|$scope"
+  teardown_rows=$((teardown_rows + 1))
+  case "$kind" in
+    section) assert_in_section "$REPO_ROOT/$rel" "$scope" "$phrase" "teardown guard: $label" ;;
+    line) assert_same_line "$REPO_ROOT/$rel" "$scope" "$phrase" "teardown guard: $label" ;;
+    order) assert_order_in_section "$REPO_ROOT/$rel" "$scope" "$phrase" "teardown guard: $label" ;;
+    *) fail "teardown guard: unknown pin kind $kind in row $label" ;;
+  esac
+done <<< "$TEARDOWN_PINS"
+(( teardown_rows >= 20 )) || fail "teardown guard: only $teardown_rows pin rows parsed"
+
+# Sweep: a Markdown surface that names `worktree remove` must also carry the
+# ignored-output scan with its exit-0 requirement on the same line, and a
+# pointer to the canonical teardown, `worktree-isolation/references/merge-and-teardown.md`
+# (inside that package the package-relative path; the canonical file is itself
+# the target). It keys on the command because prose wording is not ours to
+# enumerate; prose-only removal steps are pinned per surface above. The set is
+# the repository's own Markdown as git lists it, tracked plus untracked files
+# git does not ignore, so local build output and caches stay out; outside a git
+# work tree there is no such set and the sweep fails rather than guess one.
+# specs/ and eval/ hold round records and evaluation inputs, not guidance, and
+# the append-only source register describes the defects it records, so none of
+# them is scanned. Anything git reports while listing, an unreadable file or a
+# failed classification fails the sweep, since a file it skipped would
+# otherwise pass unseen.
+teardown_list="$(mktemp "${TMPDIR:-/tmp}/teardown-sweep.XXXXXX")"
+trap 'rm -f "$teardown_list"' EXIT
+teardown_fail() { rm -f "$teardown_list"; fail "teardown guard sweep: $1"; }
+[[ "$(git -C "$REPO_ROOT" rev-parse --show-toplevel 2>/dev/null)" == "$REPO_ROOT" ]] ||
+  teardown_fail "not a git work tree, so the repository's Markdown cannot be listed"
+teardown_errors="$(git -C "$REPO_ROOT" ls-files -z --cached --others --exclude-standard -- '*.md' 2>&1 >"$teardown_list")" ||
+  teardown_fail "could not list the repository's Markdown: $teardown_errors"
+[[ -z "$teardown_errors" ]] || teardown_fail "git could not list every file: $teardown_errors"
+# One pass reads every listed file (a grep per file made this sweep the slowest
+# part of the fixture, which the pin walks run dozens of times). Its exit status
+# carries the verdict; the printed text only names what it found.
+teardown_rc=0
+teardown_report="$(python3 - "$teardown_list" "$REPO_ROOT" <<'PY'
+import sys
+listing, root = sys.argv[1:3]
+package = root + "/skills/worktree-isolation/"
+canonical = package + "references/merge-and-teardown.md"
+register = root + "/skills/skill-extraction-workflow/references/source-register.md"
+def shown(name):
+    return "".join(c if c.isprintable() else repr(c)[1:-1] for c in name)
+visited = False
+offenders = []
+for raw in open(listing, "rb").read().split(b"\0"):
+    if not raw:
+        continue
+    rel = raw.decode("utf-8", "surrogateescape")
+    path = root + "/" + rel
+    if rel.startswith(("specs/", "eval/")) or path == register:
+        continue
+    try:
+        text = open(path, "rb").read().decode("utf-8", "replace")
+    except OSError:
+        print(shown(rel))
+        sys.exit(5)
+    if "worktree remove" not in text:
+        continue
+    visited = visited or path == canonical
+    pointer = "references/merge-and-teardown.md" if path.startswith(package) else "worktree-isolation/references/merge-and-teardown.md"
+    if "status --ignored" not in text:
+        offenders.append(shown(rel) + ": no ignored-output scan")
+    elif not any("status --ignored" in line and "exit 0" in line for line in text.splitlines()):
+        offenders.append(shown(rel) + ": no exit-0 requirement on the scan line")
+    elif path != canonical and pointer not in text:
+        offenders.append(shown(rel) + ": no pointer to the canonical teardown")
+if offenders:
+    print("; ".join(offenders))
+    sys.exit(3)
+if not visited:
+    sys.exit(4)
+PY
+)" || teardown_rc=$?
+rm -f "$teardown_list"
+trap - EXIT
+case "$teardown_rc" in
+  0) ;;
+  3) fail "teardown guard sweep: $teardown_report" ;;
+  4) fail "teardown guard sweep: the canonical teardown was never scanned, so the listing is wrong" ;;
+  5) fail "teardown guard sweep: could not read $teardown_report" ;;
+  *) fail "teardown guard sweep: the classification pass failed" ;;
+esac
+
 echo "test_ai_coding_implementation_gates: ok"

package/dist/assets/marketplace/plugins/ccl-skills/skills/skill-extraction-workflow/scripts/test_check_ccl_regressions.sh

@@ -13,6 +13,7 @@
 #   - test_ai_coding_implementation_gates.sh
 #   - test_locale_independent_gates.sh
 #   - test_controlled_escalation_pins.sh
+#   - test_teardown_guard_pins.sh
 #   - test_check_ccl_size_budget.sh
 #   - test_check_ccl_skill_catalog.sh
 #   - test_check_ccl_parallel_stack_parity.sh
@@ -113,6 +114,9 @@ fast_tests=(
   # family 8 out of the fixture above and proves each pin reds under its own
   # applied deletion mutation in a throwaway copy (spec 031 review disposition).
   test_controlled_escalation_pins.sh
+  # Applied-mutation walk for the worktree teardown guard rows (family 9 of the
+  # fixture above) plus decoy surfaces for its sweep; throwaway copy, seconds.
+  test_teardown_guard_pins.sh
   test_check_ccl_size_budget.sh
   # Entrypoint guidance-form census (what counts as one rule, a prohibition, a
   # named baseline failure): synthetic fixtures plus the shipped entrypoint,

package/dist/assets/marketplace/plugins/ccl-skills/skills/skill-extraction-workflow/scripts/test_check_sync_pointers.sh

@@ -61,7 +61,7 @@ git -C "$REPO" config user.name "Test User"
 git -C "$REPO" branch -f fixture-base HEAD
 git -C "$REPO" switch -q -C fixture-work fixture-base
 git -C "$REPO" branch --set-upstream-to=fixture-base fixture-work >/dev/null 2>&1
-WT="$REPO/skills/worktree-isolation/SKILL.md"
+WT="$REPO/skills/worktree-isolation/references/merge-and-teardown.md"
 SEC4="$REPO/skills/requirement-doc-writer/references/security-four-questions.md"
 DTREF="$REPO/skills/skill-extraction-workflow/references/dual-track-review-gate.md"
 
@@ -77,7 +77,7 @@ replace_in_file "$WT" "合并执行协议（canonical" "合并落地协议（can
 run_sync
 assert_rc "$rc" 1 "reworded canonical section must block"
 assert_contains "sync_pointer_block: merge-exec-protocol-section" "$out" "block names the pair"
-git -C "$REPO" checkout -- skills/worktree-isolation/SKILL.md
+git -C "$REPO" checkout -- skills/worktree-isolation/references/merge-and-teardown.md
 
 # s2 RED: section heading renamed => 收尾节 pointer dangles (the pinned
 # literal carries the colon so a longer heading cannot substring-satisfy it).
@@ -85,6 +85,15 @@ replace_in_file "$WT" "## 收尾：" "## 收尾清理："
 run_sync
 assert_rc "$rc" 1 "renamed teardown heading must block"
 assert_contains "sync_pointer_block: worktree-teardown-section" "$out" "block names the pair"
+git -C "$REPO" checkout -- skills/worktree-isolation/references/merge-and-teardown.md
+
+# s2b RED: the entrypoint's forwarding sentence removed => the always-on
+# pointer still names the skill, but nothing in SKILL.md leads to the
+# reference that carries the teardown section and the merge protocol.
+replace_in_file "$REPO/skills/worktree-isolation/SKILL.md" "都在 \`references/merge-and-teardown.md\`" "见各 reference"
+run_sync
+assert_rc "$rc" 1 "a removed forwarding sentence must block"
+assert_contains "sync_pointer_block: worktree-reference-forwarding" "$out" "block names the forwarding pair"
 git -C "$REPO" checkout -- skills/worktree-isolation/SKILL.md
 
 # s3 RED: bootstrap side reworded => pointer literal lost on the source side.
@@ -314,7 +323,7 @@ replace_in_file "$WT" "**合并执行协议（canonical——" "（既往）合
 run_sync
 assert_rc "$rc" 1 "a demoted-to-narrative section label must block"
 assert_contains "sync_pointer_block: merge-exec-protocol-section" "$out" "block names the pair"
-git -C "$REPO" checkout -- skills/worktree-isolation/SKILL.md
+git -C "$REPO" checkout -- skills/worktree-isolation/references/merge-and-teardown.md
 
 # s24 RED: a compliant decoy line inserted before the real reflection makes
 # the extraction anchor ambiguous (scan requires exactly one hit).
@@ -358,7 +367,7 @@ run_sync
 assert_rc "$rc" 1 "two-sided drift must block"
 assert_contains "agent-context/session-start.md lost the registered pointer literal" "$out" "source side reported"
 assert_contains "canonical target" "$out" "target side reported in the same run"
-git -C "$REPO" checkout -- agent-context/session-start.md skills/worktree-isolation/SKILL.md
+git -C "$REPO" checkout -- agent-context/session-start.md skills/worktree-isolation/references/merge-and-teardown.md
 
 # s29a: the semantic gate resolves beside the validator, so pruning the IN-TREE
 # copy changes nothing — on a clean tree the validator still evaluates with its

package/dist/assets/marketplace/plugins/ccl-skills/skills/skill-extraction-workflow/scripts/test_controlled_escalation_pins.sh

@@ -11,6 +11,11 @@
 # tree. The pin list is parsed from the fixture itself so a new pin cannot be
 # added without automatically entering this walk.
 set -euo pipefail
+# The copy gets its own repository; inherited git variables (set inside git
+# hooks, for one) would point git at the real one instead.
+unset GIT_DIR GIT_WORK_TREE GIT_INDEX_FILE GIT_OBJECT_DIRECTORY \
+  GIT_ALTERNATE_OBJECT_DIRECTORIES GIT_COMMON_DIR GIT_CEILING_DIRECTORIES \
+  GIT_NAMESPACE
 
 script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 repo_root="$(cd "$script_dir/../../.." && pwd -P)"
@@ -27,6 +32,12 @@ cp -R "$repo_root/skills" "$tmp_root/skills"
 cp -R "$repo_root/agent-context" "$tmp_root/agent-context"
 cp -R "$repo_root/docs" "$tmp_root/docs"
 cp "$repo_root/AGENTS.md" "$tmp_root/AGENTS.md"
+# The fixture's teardown sweep lists the repository's Markdown through git, so
+# the copy needs an index; nothing is committed, which keeps user commit hooks
+# and signing out of the run.
+cp "$repo_root/.gitignore" "$tmp_root/.gitignore"
+git -C "$tmp_root" init -q
+git -C "$tmp_root" add -A
 copy_fixture="$tmp_root/$fixture_rel"
 copy_ref="$tmp_root/$ref_rel"
 [[ -f "$copy_fixture" && -f "$copy_ref" ]] || fail "copy is missing the fixture or the reference"
@@ -63,7 +74,7 @@ pin_count="$(wc -l < "$pins_file" | tr -d ' ')"
 raw_count="$(grep -c 'assert_in_section "\$EXTRACTION_METHOD_REF" "\$BLOCKED_VERIFICATION_SECTION"' "$repo_root/$fixture_rel")"
 [[ "$pin_count" == "$raw_count" ]] || fail "parser dropped family-8 assertions: parsed $pin_count of $raw_count calls"
 
-run_copy() { bash "$copy_fixture" 2>&1; }
+run_copy() { TMPDIR="$tmp_root" bash "$copy_fixture" 2>&1; }
 
 # Control: the unmutated copy is green, proving the harness reads the copy.
 control_out="$(run_copy)" || fail "pre-control not green: $control_out"