@ccoalm/ccl-skills 0.16.0 → 0.18.0

package/dist/assets/marketplace/plugins/ccl-skills/skills/code-review/scripts/test_review_client_compat.py

@@ -20,9 +20,28 @@ from unittest import mock
 
 
 SCRIPT_DIR = Path(__file__).resolve().parent
+
+
+def required_concerns(stage: str, *risk_tags: str) -> list[str]:
+    """The concern ids a plan owes, asked of the controller that enforces them.
+
+    A fixture holding its own copy of this list silently stops satisfying the gate
+    when the set changes, and the suite runner aborts at its first failing target,
+    so the drift surfaces rounds later. There is one owner; ask it.
+    """
+    argv = [sys.executable, str(SCRIPT_DIR / "review_gate.py"),
+            "--print-required-concerns", "--stage", stage]
+    for tag in risk_tags:
+        argv += ["--risk-tag", tag]
+    printed = subprocess.run(argv, capture_output=True, text=True, check=True).stdout.split()
+    assert printed, "the controller printed no required concerns"
+    return printed
 if str(SCRIPT_DIR) not in sys.path:
     sys.path.insert(0, str(SCRIPT_DIR))
 import review_gate
+
+# The unpatched runner, for the controller's own git reads under the provider mock.
+REAL_RUN = review_gate.run
 import kimi_packet_mcp
 
 SPEC = importlib.util.spec_from_file_location(
@@ -736,7 +755,7 @@ class CompletionFindingDispositionTest(unittest.TestCase):
                 {"concern": concern,
                  "conclusion": f"The synthetic completion fixture preserves {concern} boundaries.",
                  "evidence_refs": ["fixture"]}
-                for concern in ("correctness", "safety", "failure_paths", "tests_evidence", "compatibility")
+                for concern in required_concerns("build")
             ],
             "evidence": [{"id": "fixture", "result": "Synthetic exact-candidate completion and history fixture."}],
         })
@@ -781,7 +800,11 @@ class CompletionFindingDispositionTest(unittest.TestCase):
 
     def wrapper_result(self, command: list[str], **kwargs: object) -> subprocess.CompletedProcess:
         # Only the provider boundary is replaced. Packet, profile, chain and
-        # completion validation execute normally; no subprocess is launched.
+        # completion validation execute normally, and so do the controller's own
+        # git reads (contract discovery, the local review receipt); no provider
+        # subprocess is launched.
+        if command[0] == "git":
+            return REAL_RUN(command, **kwargs)
         self.assertTrue(command[0].endswith("kimi_review.sh"), command[0])
         self.provider_calls.append(list(command))
         profile_path = Path(command[command.index("--review-profile-file") + 1])

package/dist/assets/marketplace/plugins/ccl-skills/skills/code-review/scripts/test_review_client_order.sh

@@ -47,7 +47,7 @@ case "$client" in
   codex) family=openai; provider=openai; model=codex-local-default ;;
   *) exit 2 ;;
 esac
-concern_results='[{"concern":"correctness","conclusion":"Checked routing correctness."},{"concern":"safety","conclusion":"Checked fail-closed safety."},{"concern":"failure_paths","conclusion":"Checked fallback failure paths."},{"concern":"tests_evidence","conclusion":"Checked deterministic test evidence."},{"concern":"compatibility","conclusion":"Checked client-order compatibility."}]'
+concern_results='[{"concern":"correctness","conclusion":"Checked routing correctness."},{"concern":"safety","conclusion":"Checked fail-closed safety."},{"concern":"failure_paths","conclusion":"Checked fallback failure paths."},{"concern":"tests_evidence","conclusion":"Checked deterministic test evidence."},{"concern":"compatibility","conclusion":"Checked client-order compatibility."},{"concern":"claim_strength","conclusion":"Checked that no claim reaches past the client-order fixture."}]'
 
 if [ "$client" = "claude" ]; then
   case "$behavior" in
@@ -105,20 +105,35 @@ done
 
 printf 'diff --git a/x b/x\n--- a/x\n+++ b/x\n@@ -1 +1 @@\n-a\n+b\n' >"$WORK/diff.patch"
 printf 'diff --git a/c b/c\n--- a/c\n+++ b/c\n@@ -1 +1 @@\n-x\n+aws_key = "AKIAIOSFODNN7EXAMPLE"\n' >"$WORK/secret-diff.patch"
-cat >"$WORK/review-plan.json" <<'JSON'
-{
-  "intent": "Preserve independent reviewer routing while adding staged review.",
-  "acceptance": ["Client ordering and model-family exclusion remain deterministic."],
-  "self_review": [
-    {"concern": "correctness", "conclusion": "Routing preserves the first eligible independent result.", "evidence_refs": ["e1"]},
-    {"concern": "safety", "conclusion": "Terminal boundaries remain fail closed across clients.", "evidence_refs": ["e1"]},
-    {"concern": "failure_paths", "conclusion": "Candidate-local failures alone enter the fallback chain.", "evidence_refs": ["e1"]},
-    {"concern": "tests_evidence", "conclusion": "Deterministic stubs cover client order and attribution.", "evidence_refs": ["e1"]},
-    {"concern": "compatibility", "conclusion": "Existing client-order customization remains supported.", "evidence_refs": ["e1"]}
-  ],
-  "evidence": [{"id": "e1", "result": "Deterministic client routing contract fixture."}]
-}
-JSON
+# The plan's required concern set has ONE owner. A fixture keeping its own copy
+# stops satisfying the gate the moment that set changes, and the suite runner
+# aborts at its first failing target, so the drift surfaces rounds later -- five
+# fixtures drifted that way at once. Ask the controller instead.
+python3 - "$WORK/review-plan.json" "$DIR" <<'PY'
+import json
+import subprocess
+import sys
+from pathlib import Path
+
+plan_path, script_dir = Path(sys.argv[1]), Path(sys.argv[2])
+required = subprocess.run(
+    [sys.executable, str(script_dir / "review_gate.py"),
+     "--print-required-concerns", "--stage", "build"],
+    capture_output=True, text=True, check=True,
+).stdout.split()
+assert required, "the controller printed no required concerns"
+plan_path.write_text(json.dumps({
+    "intent": "Preserve independent reviewer routing while adding staged review.",
+    "acceptance": ["Client ordering and model-family exclusion remain deterministic."],
+    "self_review": [
+        {"concern": concern,
+         "conclusion": f"The deterministic client-routing stubs cover {concern}.",
+         "evidence_refs": ["e1"]}
+        for concern in required
+    ],
+    "evidence": [{"id": "e1", "result": "Deterministic client routing contract fixture."}],
+}, indent=2) + "\n", encoding="utf-8")
+PY
 
 reset_case() {
   rm -f "$WORK/state"/*