@cccarv82/freya 2.7.1 → 2.8.2

package/scripts/generate-weekly-report.js

@@ -1,23 +1,34 @@
+/**
+ * generate-weekly-report.js
+ * Generates a weekly Markdown report aggregating Tasks, Blockers, Career entries,
+ * and Project Updates from the SQLite database.
+ *
+ * Usage: node scripts/generate-weekly-report.js
+ */
+
 const fs = require('fs');
 const path = require('path');
 
-const { toIsoDate, isWithinRange } = require('./lib/date-utils');
+const { toIsoDate, safeParseToMs } = require('./lib/date-utils');
+const DataManager = require('./lib/DataManager');
+const { ready } = require('./lib/DataLayer');
 
-const DATA_DIR = path.join(__dirname, '../data');
-const REPORT_DIR = path.join(__dirname, '../docs/reports');
+// --- Configuration (BUG-30: use FREYA_WORKSPACE_DIR instead of __dirname) ---
+const WORKSPACE_DIR = process.env.FREYA_WORKSPACE_DIR
+  ? path.resolve(process.env.FREYA_WORKSPACE_DIR)
+  : path.join(__dirname, '..'); // fallback: scripts/ is one level below repo root
 
-// Ensure output dir exists
-if (!fs.existsSync(REPORT_DIR)) {
-    fs.mkdirSync(REPORT_DIR, { recursive: true });
-}
+const REPORT_DIR = path.join(WORKSPACE_DIR, 'docs', 'reports');
 
 // --- Date Logic ---
 const now = new Date();
 const oneDay = 24 * 60 * 60 * 1000;
 
 function isWithinWeek(dateStr) {
-    const sevenDaysAgo = new Date(now.getTime() - (7 * oneDay));
-    return isWithinRange(dateStr, sevenDaysAgo, now);
+    const ms = safeParseToMs(dateStr);
+    if (!Number.isFinite(ms)) return false;
+    const sevenDaysAgo = now.getTime() - (7 * oneDay);
+    return ms >= sevenDaysAgo && ms <= now.getTime();
 }
 
 function getFormattedDate() {
@@ -31,112 +42,87 @@ function getFormattedTime() {
     return `${hh}${mm}${ss}`;
 }
 
-// --- File Walking ---
-function walk(dir, fileList = []) {
-    const files = fs.readdirSync(dir);
-    files.forEach(file => {
-        const filePath = path.join(dir, file);
-        const stat = fs.statSync(filePath);
-        if (stat.isDirectory()) {
-            walk(filePath, fileList);
-        } else {
-            if (path.extname(file) === '.json') {
-                fileList.push(filePath);
-            }
-        }
-    });
-    return fileList;
-}
+// --- Report Generation ---
+async function generateWeeklyReport() {
+    await ready;
+
+    const start = new Date(now.getTime() - 7 * oneDay);
+    const end = now;
+
+    const dm = new DataManager();
+
+    // Fetch data from SQLite
+    const { completed: completedTasks } = dm.getTasks(start, end);
+    const { open: openBlockers, resolvedRecent } = dm.getBlockers(start, end);
+    const projectUpdates = dm.getProjectUpdates(start, end);
+    const careerEntries = dm.getCareerEntries ? dm.getCareerEntries(start, end) : [];
+
+    // Ensure output dir exists
+    if (!fs.existsSync(REPORT_DIR)) {
+        fs.mkdirSync(REPORT_DIR, { recursive: true });
+    }
 
-// --- Aggregation ---
-function generateWeeklyReport() {
-    const files = walk(DATA_DIR);
-    
-    const projects = [];
-    let taskLog = { schemaVersion: 1, tasks: [] };
-    let careerLog = { entries: [] };
-
-    // 1. Collect Data
-    files.forEach(file => {
-        try {
-            const content = fs.readFileSync(file, 'utf8');
-            const json = JSON.parse(content);
-
-            if (file.endsWith('task-log.json')) {
-                taskLog = json;
-            } else if (file.endsWith('career-log.json')) {
-                careerLog = json;
-            } else if (file.endsWith('status.json')) {
-                projects.push(json);
-            }
-        } catch (err) {
-            console.error(`Error reading ${file}: ${err.message}`);
-        }
-    });
-
-    // 2. Generate Content
     const reportDate = getFormattedDate();
     const reportTime = getFormattedTime();
     let report = `# Weekly Report - ${reportDate}\n\n`;
 
     // Projects
-    report += "## 🚀 Project Updates\n";
-    let hasProjectUpdates = false;
-    projects.forEach(p => {
-        if (p.history && Array.isArray(p.history)) {
-            const recentUpdates = p.history.filter(h => isWithinWeek(h.date));
-            if (recentUpdates.length > 0) {
-                hasProjectUpdates = true;
-                report += `### ${p.client} - ${p.project}\n`;
-                recentUpdates.forEach(u => {
-                    const dateStr = u.date ? u.date.split('T')[0] : 'Unknown Date';
-                    report += `- **${dateStr}**: ${u.content}\n`;
-                });
-                report += "\n";
-            }
-        }
-    });
-    if (!hasProjectUpdates) report += "No project updates recorded this week.\n\n";
-
-    // Tasks
-    report += "## ✅ Completed Tasks\n";
-    if (taskLog.tasks && Array.isArray(taskLog.tasks)) {
-        const recentTasks = taskLog.tasks.filter(t => t.status === "COMPLETED" && isWithinWeek(t.completedAt));
-        if (recentTasks.length > 0) {
-            recentTasks.forEach(t => {
-                report += `- ${t.description}\n`;
+    report += '## Project Updates\n';
+    if (projectUpdates.length > 0) {
+        projectUpdates.forEach(p => {
+            report += `### ${p.client || 'Unknown'} - ${p.project || p.slug || 'Unknown'}\n`;
+            const events = Array.isArray(p.events) ? p.events : [];
+            events.forEach(e => {
+                const dateStr = e.date ? String(e.date).slice(0, 10) : 'Unknown Date';
+                report += `- **${dateStr}**: ${e.content || ''}\n`;
             });
-        } else {
-            report += "No tasks completed this week.\n";
-        }
+            report += '\n';
+        });
     } else {
-        report += "No task log found.\n";
+        report += 'No project updates recorded this week.\n\n';
     }
-    report += "\n";
-
-    // Career
-    report += "## 🌟 Career Highlights\n";
-    if (careerLog.entries && Array.isArray(careerLog.entries)) {
-        const recentCareer = careerLog.entries.filter(e => isWithinWeek(e.date));
-        if (recentCareer.length > 0) {
-            recentCareer.forEach(e => {
-                report += `- **[${e.type}]**: ${e.description}\n`;
-            });
-        } else {
-            report += "No career updates this week.\n";
-        }
+
+    // Completed Tasks
+    report += '## Completed Tasks\n';
+    if (completedTasks.length > 0) {
+        completedTasks.forEach(t => {
+            const projectTag = t.projectSlug || t.project_slug ? `[${t.projectSlug || t.project_slug}] ` : '';
+            report += `- ${projectTag}${t.description}\n`;
+        });
     } else {
-        report += "No career log found.\n";
+        report += 'No tasks completed this week.\n';
+    }
+    report += '\n';
+
+    // Open Blockers
+    report += '## Open Blockers\n';
+    if (openBlockers.length > 0) {
+        openBlockers.forEach(b => {
+            const sev = b.severity ? `[${b.severity}] ` : '';
+            report += `- ${sev}${b.title}\n`;
+        });
+    } else {
+        report += 'No open blockers.\n';
+    }
+    report += '\n';
+
+    // Career entries (if DataManager supports it)
+    if (Array.isArray(careerEntries) && careerEntries.length > 0) {
+        report += '## Career Highlights\n';
+        careerEntries.forEach(e => {
+            report += `- **[${e.type || 'Note'}]**: ${e.description || e.content || ''}\n`;
+        });
+        report += '\n';
     }
 
     // 3. Save and Output
     const outputPath = path.join(REPORT_DIR, `weekly-${reportDate}-${reportTime}.md`);
     fs.writeFileSync(outputPath, report);
-    
-    console.log(`✅ Report generated at: ${outputPath}`);
-    console.log("---------------------------------------------------");
+
+    console.log(`Report generated at: ${outputPath}`);
+    console.log('---------------------------------------------------');
     console.log(report);
-    console.log("---------------------------------------------------");
+    console.log('---------------------------------------------------');
 }
 
-generateWeeklyReport();
+generateWeeklyReport().catch(err => { console.error(err); process.exit(1); });

package/scripts/lib/DataLayer.js

@@ -165,6 +165,15 @@ class SqlJsDatabase {
     };
   }
 
+  /**
+   * Public save — explicitly flush the in-memory database to disk.
+   * Use this when you need to ensure data is persisted before spawning a
+   * child process that will read the same SQLite file (e.g. in tests).
+   */
+  save() {
+    this._save();
+  }
+
   /**
    * Close the database.
    */
@@ -181,7 +190,13 @@ class SqlJsDatabase {
 class DataLayer {
   constructor(dbPath = null) {
     if (!dbPath) {
-      const dataDir = path.join(__dirname, '..', '..', 'data');
+      // Prefer FREYA_WORKSPACE_DIR env var so that the web server and report
+      // child processes always share the same SQLite file regardless of where
+      // each DataLayer.js lives on disk.
+      const workspaceDir = process.env.FREYA_WORKSPACE_DIR
+        ? path.resolve(process.env.FREYA_WORKSPACE_DIR)
+        : path.join(__dirname, '..', '..');
+      const dataDir = path.join(workspaceDir, 'data');
       if (!fs.existsSync(dataDir)) {
         fs.mkdirSync(dataDir, { recursive: true });
       }
@@ -332,4 +347,35 @@ const ready = defaultInstance.init().catch(err => {
   process.exit(1);
 });
 
-module.exports = { defaultInstance, DataLayer, ready };
+/**
+ * Configure the singleton to use a specific workspace directory.
+ * Call this before performing any DB operations against the target workspace.
+ * Closes the current in-memory DB (if open) and reinitializes from the new path.
+ *
+ * This is used by the web server to ensure it uses the same SQLite file as
+ * report child processes (both pointed at {workspaceDir}/data/freya.sqlite).
+ *
+ * @param {string} workspaceDir  Absolute path to the Freya workspace directory.
+ * @returns {Promise<void>}      Resolves when the new DB is ready.
+ */
+async function configure(workspaceDir) {
+  const newDbPath = path.join(path.resolve(workspaceDir), 'data', 'freya.sqlite');
+  if (defaultInstance._dbPath === newDbPath && defaultInstance.db) {
+    // Already pointing at the right file.
+    return;
+  }
+  // Close existing connection if open.
+  if (defaultInstance.db) {
+    try { defaultInstance.db.close(); } catch { /* ignore */ }
+    defaultInstance.db = null;
+  }
+  // Set the new path and reinitialize.
+  defaultInstance._dbPath = newDbPath;
+  const dataDir = path.dirname(newDbPath);
+  if (!fs.existsSync(dataDir)) {
+    fs.mkdirSync(dataDir, { recursive: true });
+  }
+  await defaultInstance.init();
+}
+
+module.exports = { defaultInstance, DataLayer, ready, configure };

package/scripts/lib/DataManager.js

@@ -25,7 +25,13 @@ class DataManager {
     // --- Tasks ---
     getTasksRaw() {
         return dl.db.prepare('SELECT * FROM tasks').all().map(t => {
-            const meta = t.metadata ? JSON.parse(t.metadata) : {};
+            // BUG-17: JSON.parse can throw on corrupted metadata; default to {}
+            let meta = {};
+            try {
+                meta = t.metadata ? JSON.parse(t.metadata) : {};
+            } catch {
+                meta = {};
+            }
             return {
                 id: t.id,
                 projectSlug: t.project_slug,
@@ -64,7 +70,13 @@ class DataManager {
     // --- Blockers ---
     getBlockersRaw() {
         return dl.db.prepare('SELECT * FROM blockers').all().map(b => {
-            const meta = b.metadata ? JSON.parse(b.metadata) : {};
+            // BUG-17: JSON.parse can throw on corrupted metadata; default to {}
+            let meta = {};
+            try {
+                meta = b.metadata ? JSON.parse(b.metadata) : {};
+            } catch {
+                meta = {};
+            }
             return {
                 id: b.id,
                 projectSlug: b.project_slug,
@@ -160,9 +172,17 @@ class DataManager {
 
     // --- Daily Logs ---
     getDailyLogs(start, end) {
-        function toIso(d) { return (d instanceof Date ? d : new Date(d)).toISOString().slice(0, 10); }
-        const startIso = formatDate ? formatDate(start) : toIso(start);
-        const endIso = formatDate ? formatDate(end) : toIso(end);
+        // BUG-41: use local date parts instead of toISOString().slice(0,10) to avoid
+        // timezone drift (UTC midnight may differ from local midnight)
+        function toLocalDate(d) {
+            const dt = d instanceof Date ? d : new Date(d);
+            const yyyy = dt.getFullYear();
+            const mm = String(dt.getMonth() + 1).padStart(2, '0');
+            const dd = String(dt.getDate()).padStart(2, '0');
+            return `${yyyy}-${mm}-${dd}`;
+        }
+        const startIso = formatDate ? formatDate(start) : toLocalDate(start);
+        const endIso = formatDate ? formatDate(end) : toLocalDate(end);
 
         return dl.db.prepare(`
             SELECT date, raw_markdown as content FROM daily_logs
@@ -171,6 +191,43 @@ class DataManager {
         `).all(startIso, endIso);
     }
 
+    // --- Timestamp helpers ---
+    // These accept a record (task or blocker) and return milliseconds since epoch, or NaN.
+
+    getCreatedAt(record) {
+        const { safeParseToMs } = require('./date-utils');
+        const candidates = [
+            record.createdAt,
+            record.created_at,
+            record.openedAt,
+            record.opened_at,
+            record.date,
+            record.loggedAt,
+        ];
+        for (const value of candidates) {
+            const ms = safeParseToMs(value);
+            if (Number.isFinite(ms)) return ms;
+        }
+        return NaN;
+    }
+
+    getResolvedAt(record) {
+        const { safeParseToMs } = require('./date-utils');
+        const candidates = [
+            record.resolvedAt,
+            record.resolved_at,
+            record.closedAt,
+            record.closed_at,
+            record.completedAt,
+            record.completed_at,
+        ];
+        for (const value of candidates) {
+            const ms = safeParseToMs(value);
+            if (Number.isFinite(ms)) return ms;
+        }
+        return NaN;
+    }
+
     // --- RAG (Vector Search) ---
     async semanticSearch(query, topK = 10) {
         const queryVector = await defaultEmbedder.embedText(query);

package/scripts/lib/index-utils.js

@@ -8,7 +8,8 @@ const ID_PATTERNS = [
 ];
 
 const TEXT_EXTS = new Set(['.md', '.txt', '.log', '.json', '.yaml', '.yml']);
-const TOKEN_RE = /[A-Za-z0-9_-]{3,}/g;
+// BUG-46: TOKEN_RE was a module-level global with /g flag — its lastIndex would
+// persist between calls causing random skipped tokens. Moved inside the function.
 
 const DEFAULT_MAX_SIZE = 2 * 1024 * 1024;
 const DEFAULT_TOKEN_LIMIT = 500;
@@ -142,6 +143,8 @@ function extractIdMatches(text) {
 }
 
 function extractKeywordIndexMap(textLower, tokenLimit) {
+  // BUG-46: create a fresh regex each call — module-level /g regex retains lastIndex
+  const TOKEN_RE = /[A-Za-z0-9_-]{3,}/g;
   const map = new Map();
   let m;
   while ((m = TOKEN_RE.exec(textLower)) !== null) {
@@ -151,7 +154,6 @@ function extractKeywordIndexMap(textLower, tokenLimit) {
       if (map.size >= tokenLimit) break;
     }
   }
-  TOKEN_RE.lastIndex = 0;
   return map;
 }
 

package/scripts/migrate-data.js

@@ -3,9 +3,16 @@ const path = require('path');
 
 const { safeReadJson, quarantineCorruptedFile } = require('./lib/fs-utils');
 
+// BUG-43: support FREYA_WORKSPACE_DIR (used by web server) in addition to DATA_DIR
+const WORKSPACE_DIR = process.env.FREYA_WORKSPACE_DIR
+  ? path.resolve(process.env.FREYA_WORKSPACE_DIR)
+  : null;
+
 const DATA_DIR = process.env.DATA_DIR
   ? path.resolve(process.env.DATA_DIR)
-  : path.join(__dirname, '../data');
+  : WORKSPACE_DIR
+    ? path.join(WORKSPACE_DIR, 'data')
+    : path.join(__dirname, '../data');
 
 const KNOWN_FILES = [
   { relPath: path.join('tasks', 'task-log.json'), label: 'tasks/task-log.json' },

package/scripts/validate-data.js

@@ -4,7 +4,12 @@ const path = require('path');
 const { safeReadJson, quarantineCorruptedFile } = require('./lib/fs-utils');
 const SCHEMA = require('./lib/schema');
 
-const DATA_DIR = path.join(__dirname, '../data');
+// BUG-30: use FREYA_WORKSPACE_DIR so the web server uses the correct workspace
+const WORKSPACE_DIR = process.env.FREYA_WORKSPACE_DIR
+  ? path.resolve(process.env.FREYA_WORKSPACE_DIR)
+  : path.join(__dirname, '..'); // fallback: scripts/ is one level below repo root
+
+const DATA_DIR = path.join(WORKSPACE_DIR, 'data');
 
 // --- Validation Helpers ---
 
@@ -173,8 +178,11 @@ function validateData() {
       // Route validation based on filename/path
       if (file.endsWith('career-log.json')) {
         fileErrors = validateCareerLog(json, relativePath);
-      } else if (file.endsWith('task-log.json') || file.endsWith('status.json') || file.endsWith('blocker-log.json')) {
-        // Obsoleted by SQLite, ignore
+      } else if (file.endsWith('task-log.json') || file.endsWith('blocker-log.json')) {
+        // BUG-06: These are legacy JSON files superseded by SQLite storage.
+        // They are no longer the source of truth; validation is skipped to avoid
+        // false positives on empty/stub files left behind after migration.
+        console.log(`ℹ️  [${relativePath}] Legacy file (superseded by SQLite). Skipping schema validation.`);
       } else {
         // Optional: warn about unknown files, or ignore
         // console.warn(`⚠️ [${relativePath}] Unknown JSON file type. Skipping schema validation.`);

package/templates/base/scripts/generate-blockers-report.js

@@ -5,7 +5,12 @@ const { toIsoDate, safeParseToMs, isWithinRange } = require('./lib/date-utils');
 
 const DataManager = require('./lib/DataManager');
 const { ready } = require('./lib/DataLayer');
-const REPORT_DIR = path.join(__dirname, '../docs/reports');
+// BUG-30: use FREYA_WORKSPACE_DIR instead of __dirname
+const WORKSPACE_DIR = process.env.FREYA_WORKSPACE_DIR
+  ? path.resolve(process.env.FREYA_WORKSPACE_DIR)
+  : path.join(__dirname, '..'); // fallback: scripts/ is one level below workspace root
+
+const REPORT_DIR = path.join(WORKSPACE_DIR, 'docs', 'reports');
 
 const SEVERITY_ORDER = {
   CRITICAL: 0,

package/templates/base/scripts/generate-daily-summary.js

@@ -4,9 +4,14 @@ const path = require('path');
 const DataManager = require('./lib/DataManager');
 const { ready } = require('./lib/DataLayer');
 
-const DATA_DIR = path.join(__dirname, '../data');
-const LOGS_DIR = path.join(__dirname, '../logs/daily');
-const REPORT_DIR = path.join(__dirname, '../docs/reports');
+// BUG-30: use FREYA_WORKSPACE_DIR instead of __dirname
+const WORKSPACE_DIR = process.env.FREYA_WORKSPACE_DIR
+  ? path.resolve(process.env.FREYA_WORKSPACE_DIR)
+  : path.join(__dirname, '..'); // fallback: scripts/ is one level below workspace root
+
+const DATA_DIR = path.join(WORKSPACE_DIR, 'data');
+const LOGS_DIR = path.join(WORKSPACE_DIR, 'logs', 'daily');
+const REPORT_DIR = path.join(WORKSPACE_DIR, 'docs', 'reports');
 
 const dm = new DataManager(DATA_DIR, LOGS_DIR);
 
@@ -24,9 +29,10 @@ async function generateDailySummary() {
         let summary = "";
 
         // 1. Ontem (Completed < 24h)
+        // BUG-09: use completedAt (not createdAt) to decide if a task appears in "yesterday"
         const completedRecently = tasks.filter(t => {
             if (t.status !== 'COMPLETED') return false;
-            const ms = dm.getCreatedAt(t) || Date.parse(t.completedAt || t.completed_at || ''); // Use native since no safeParse helper here
+            const ms = dm.getResolvedAt(t);
             if (!Number.isFinite(ms)) return false;
             return ms >= ms24h && ms <= now.getTime();
         });

package/templates/base/scripts/generate-executive-report.js

@@ -2,7 +2,7 @@
  * generate-executive-report.js
  * Generates a professional Markdown status report (Daily/Weekly)
  * aggregating Tasks, Project Updates, and Daily Logs.
- * 
+ *
  * Usage: node scripts/generate-executive-report.js --period [daily|weekly]
  */
 
@@ -13,10 +13,14 @@ const { toIsoDate, safeParseToMs } = require('./lib/date-utils');
 const DataManager = require('./lib/DataManager');
 const { ready } = require('./lib/DataLayer');
 
-// --- Configuration ---
-const DATA_DIR = path.join(__dirname, '../data');
-const LOGS_DIR = path.join(__dirname, '../logs/daily');
-const OUTPUT_DIR = path.join(__dirname, '../docs/reports');
+// --- Configuration (BUG-30: use FREYA_WORKSPACE_DIR instead of __dirname) ---
+const WORKSPACE_DIR = process.env.FREYA_WORKSPACE_DIR
+  ? path.resolve(process.env.FREYA_WORKSPACE_DIR)
+  : path.join(__dirname, '..'); // fallback: scripts/ is one level below workspace root
+
+const DATA_DIR = path.join(WORKSPACE_DIR, 'data');
+const LOGS_DIR = path.join(WORKSPACE_DIR, 'logs', 'daily');
+const OUTPUT_DIR = path.join(WORKSPACE_DIR, 'docs', 'reports');
 
 const dm = new DataManager(DATA_DIR, LOGS_DIR);
 

package/templates/base/scripts/generate-sm-weekly-report.js

@@ -5,9 +5,14 @@ const { toIsoDate, safeParseToMs } = require('./lib/date-utils');
 const DataManager = require('./lib/DataManager');
 const { ready } = require('./lib/DataLayer');
 
-const DATA_DIR = path.join(__dirname, '../data');
-const LOGS_DIR = path.join(__dirname, '../logs/daily');
-const REPORT_DIR = path.join(__dirname, '../docs/reports');
+// BUG-30: use FREYA_WORKSPACE_DIR instead of __dirname
+const WORKSPACE_DIR = process.env.FREYA_WORKSPACE_DIR
+  ? path.resolve(process.env.FREYA_WORKSPACE_DIR)
+  : path.join(__dirname, '..'); // fallback: scripts/ is one level below workspace root
+
+const DATA_DIR = path.join(WORKSPACE_DIR, 'data');
+const LOGS_DIR = path.join(WORKSPACE_DIR, 'logs', 'daily');
+const REPORT_DIR = path.join(WORKSPACE_DIR, 'docs', 'reports');
 
 const dm = new DataManager(DATA_DIR, LOGS_DIR);
 
@@ -109,7 +114,8 @@ async function generate() {
     projectsWithUpdates.forEach(p => {
       md += `### ${p.client} / ${p.project}\n`;
       if (p.currentStatus) md += `**Status:** ${p.currentStatus}\n`;
-      p.recent.forEach(e => {
+      const projectEvents = p.events || p.recent || [];
+      projectEvents.forEach(e => {
         md += `- [${e.date || e.timestamp}] ${e.content || ''}\n`;
       });
       md += `\n`;