@cccarv82/freya 2.7.0 → 2.8.2

package/templates/base/scripts/validate-data.js

@@ -4,7 +4,12 @@ const path = require('path');
 const { safeReadJson, quarantineCorruptedFile } = require('./lib/fs-utils');
 const SCHEMA = require('./lib/schema');
 
-const DATA_DIR = path.join(__dirname, '../data');
+// BUG-30: use FREYA_WORKSPACE_DIR so the web server uses the correct workspace
+const WORKSPACE_DIR = process.env.FREYA_WORKSPACE_DIR
+  ? path.resolve(process.env.FREYA_WORKSPACE_DIR)
+  : path.join(__dirname, '..'); // fallback: scripts/ is one level below workspace root
+
+const DATA_DIR = path.join(WORKSPACE_DIR, 'data');
 
 // --- Validation Helpers ---
 
@@ -140,10 +145,10 @@ function walk(dir, fileList = []) {
 }
 
 function validateData() {
-  console.log('🔍 Starting validation...');
+  console.log('Starting validation...');
   try {
     if (!fs.existsSync(DATA_DIR)) {
-      console.error('❌ Data directory not found:', DATA_DIR);
+      console.error('Data directory not found:', DATA_DIR);
       process.exit(1);
     }
 
@@ -158,9 +163,9 @@ function validateData() {
       if (!result.ok) {
         if (result.error.type === 'parse') {
           quarantineCorruptedFile(file, result.error.message);
-          console.warn(`⚠️ [${relativePath}] JSON parse failed; quarantined to _corrupted.`);
+          console.warn(`[${relativePath}] JSON parse failed; quarantined to _corrupted.`);
         } else {
-          console.error(`❌ [${relativePath}] Read failed: ${result.error.message}`);
+          console.error(`[${relativePath}] Read failed: ${result.error.message}`);
         }
         errorCount++;
         return;
@@ -173,29 +178,32 @@ function validateData() {
       // Route validation based on filename/path
       if (file.endsWith('career-log.json')) {
         fileErrors = validateCareerLog(json, relativePath);
-      } else if (file.endsWith('task-log.json') || file.endsWith('status.json') || file.endsWith('blocker-log.json')) {
-        // Obsoleted by SQLite, ignore
+      } else if (file.endsWith('task-log.json') || file.endsWith('blocker-log.json')) {
+        // BUG-06: These are legacy JSON files superseded by SQLite storage.
+        // They are no longer the source of truth; validation is skipped to avoid
+        // false positives on empty/stub files left behind after migration.
+        console.log(`[${relativePath}] Legacy file (superseded by SQLite). Skipping schema validation.`);
       } else {
         // Optional: warn about unknown files, or ignore
-        // console.warn(`⚠️ [${relativePath}] Unknown JSON file type. Skipping schema validation.`);
+        // console.warn(`[${relativePath}] Unknown JSON file type. Skipping schema validation.`);
       }
 
       if (fileErrors.length > 0) {
-        console.error(`❌ [${relativePath}] Validation failed:`);
+        console.error(`[${relativePath}] Validation failed:`);
         fileErrors.forEach(e => console.error(`   - ${e}`));
         errorCount++;
       }
     });
 
     if (errorCount === 0) {
-      console.log('✅ All systems operational');
+      console.log('All systems operational');
     } else {
-      console.error(`❌ Validation completed with errors in ${errorCount} file(s).`);
+      console.error(`Validation completed with errors in ${errorCount} file(s).`);
       process.exit(1);
     }
 
   } catch (err) {
-    console.error('❌ Fatal error:', err);
+    console.error('Fatal error:', err);
     process.exit(1);
   }
 }