@cbartens/bkit 5.0.0 → 5.0.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (61) hide show
  1. package/.bkit/README.md +10 -14
  2. package/.bkit/core/.bkit/README.md +9 -13
  3. package/.bkit/core/.bkit/cloud.md +15 -24
  4. package/.bkit/core/.bkit/comparison.md +4 -1
  5. package/.bkit/core/.bkit/install.md +54 -149
  6. package/.bkit/core/.bkit/jsonl.md +5 -5
  7. package/.bkit/core/.bkit/templates.md +2 -3
  8. package/.bkit/core/.bkit/workflows.md +7 -3
  9. package/.bkit/core/engine/checks/after/auth.ts +16 -114
  10. package/.bkit/core/engine/checks/after/ci-yml.ts +36 -74
  11. package/.bkit/core/engine/checks/after/index.ts +156 -182
  12. package/.bkit/core/engine/checks/after/suppression.ts +53 -0
  13. package/.bkit/core/engine/checks/before/env.ts +4 -18
  14. package/.bkit/core/engine/checks/before/files.ts +2 -0
  15. package/.bkit/core/engine/cli.ts +4 -8
  16. package/.bkit/core/engine/commands/install/doctor.ts +9 -2
  17. package/.bkit/core/engine/commands/install/install.ts +24 -2
  18. package/.bkit/core/engine/commands/install/uninstall.ts +23 -0
  19. package/.bkit/core/engine/commands/install/upgrade.ts +14 -3
  20. package/.bkit/core/engine/commands/lib.ts +4 -3
  21. package/.bkit/core/engine/install/cloud-env.ts +0 -1
  22. package/.bkit/core/engine/install/modules/cloud.ts +2 -3
  23. package/.bkit/core/engine/install/modules/core.ts +33 -13
  24. package/.bkit/core/engine/install/payload-links.ts +150 -0
  25. package/.bkit/core/engine/install/template-copies.ts +1 -1
  26. package/.bkit/core/engine/shared/egress.ts +1 -1
  27. package/.bkit/core/workflows/bkit-debug.md +19 -12
  28. package/.bkit/shared/.bkit/.env.example +2 -24
  29. package/.bkit/shared/docs/deployments.md +2 -7
  30. package/.bkit/shared/docs/security.md +1 -1
  31. package/.bkit/shared/gitignore +5 -0
  32. package/.bkit/templates/.claude/hooks/bkit-cloud-bootstrap.sh +0 -5
  33. package/.bkit/templates/.cursor/Dockerfile +1 -1
  34. package/.bkit/templates/.cursor/environment.json +1 -1
  35. package/.bkit/templates/.github/renovate.json5 +0 -15
  36. package/.bkit/templates/.github/workflows/bkit-ci.yml +2 -22
  37. package/.bkit/templates/.github/workflows/bkit-cloud.yml +0 -2
  38. package/.bkit/templates/.github/workflows/bkit-renovate.yml +0 -5
  39. package/CHANGELOG.md +17 -0
  40. package/README.md +5 -6
  41. package/dist/checks/after/auth.js +16 -108
  42. package/dist/checks/after/ci-yml.js +30 -67
  43. package/dist/checks/after/index.js +136 -152
  44. package/dist/checks/after/suppression.js +39 -0
  45. package/dist/checks/before/env.js +4 -14
  46. package/dist/checks/before/files.js +2 -0
  47. package/dist/cli.js +4 -8
  48. package/dist/commands/install/doctor.js +4 -2
  49. package/dist/commands/install/install.js +16 -2
  50. package/dist/commands/install/uninstall.js +24 -0
  51. package/dist/commands/install/upgrade.js +14 -3
  52. package/dist/commands/lib.js +4 -3
  53. package/dist/install/cloud-env.js +0 -1
  54. package/dist/install/modules/cloud.js +2 -3
  55. package/dist/install/modules/core.js +33 -13
  56. package/dist/install/payload-links.js +119 -0
  57. package/dist/install/template-copies.js +1 -1
  58. package/dist/shared/egress.js +1 -1
  59. package/package.json +2 -2
  60. package/.bkit/core/engine/checks/after/vercel.ts +0 -101
  61. package/dist/checks/after/vercel.js +0 -102
@@ -89,4 +89,9 @@ playwright/.auth/
89
89
  # Local MCP / agent secrets — never commit
90
90
  .bkit/.env
91
91
 
92
+ # Payload view links — `bkit install` / `upgrade` symlink these into
93
+ # node_modules/@cbartens/bkit; they dangle on a fresh clone or in CI, so never commit.
94
+ .bkit/core
95
+ .bkit/shared
96
+
92
97
  # <!-- bkit:end -->
@@ -55,11 +55,6 @@ if [ "${CLAUDE_CODE_REMOTE:-}" = "true" ] && command -v jq >/dev/null 2>&1; then
55
55
  fi
56
56
 
57
57
  if [ -f pnpm-lock.yaml ] && command -v pnpm >/dev/null 2>&1; then
58
- # Writes the GH Packages auth token into pnpm's user-level config before install,
59
- # alongside the project .npmrc auth token line.
60
- if [ -n "${BKIT_GH_TOKEN_INSTALL:-}" ]; then
61
- pnpm config set "//npm.pkg.github.com/:_authToken=$BKIT_GH_TOKEN_INSTALL" || log "pnpm config set failed (non-blocking)"
62
- fi
63
58
  log "pnpm install --frozen-lockfile"
64
59
  pnpm install --frozen-lockfile --prefer-offline || log "pnpm install failed (non-blocking)"
65
60
  fi
@@ -51,7 +51,7 @@ RUN cd /tmp \
51
51
  && rm -f "vale_${VALE_VERSION}_Linux_64-bit.tar.gz"
52
52
 
53
53
  # pnpm — corepack-pinned to match `packageManager` in package.json.
54
- RUN corepack enable && corepack prepare pnpm@10.34.3 --activate
54
+ RUN corepack enable && corepack prepare pnpm@10.34.4 --activate
55
55
 
56
56
  # --- Consumer extensions ---------------------------------------------------
57
57
  # Add per-repo install steps here. Uncomment / adapt as needed:
@@ -2,5 +2,5 @@
2
2
  "build": {
3
3
  "dockerfile": "Dockerfile"
4
4
  },
5
- "install": "pnpm config set //npm.pkg.github.com/:_authToken=$BKIT_GH_TOKEN_INSTALL && pnpm install --frozen-lockfile && ([ ! -f .vale.ini ] || vale sync)"
5
+ "install": "pnpm install --frozen-lockfile && ([ ! -f .vale.ini ] || vale sync)"
6
6
  }
@@ -88,21 +88,6 @@
88
88
  ".agents/skills/**",
89
89
  ],
90
90
 
91
- // Private-registry read auth for `@cbartens/bkit` on npm.pkg.github.com.
92
- // Renovate resolves the whole workspace to regenerate the lockfile and needs
93
- // a read token for this host to do so.
94
- // Mend: uncomment `token` and add BKIT_GH_TOKEN_INSTALL as a Mend repository
95
- // secret with "used during the scan as an environment variable" ticked.
96
- // Self-hosted: leave `token` commented; the example workflow injects
97
- // RENOVATE_HOST_RULES from the Actions secret instead. Do not commit a literal token.
98
- // hostRules: [
99
- // {
100
- // matchHost: "npm.pkg.github.com",
101
- // hostType: "npm",
102
- // token: "{{ secrets.BKIT_GH_TOKEN_INSTALL }}",
103
- // },
104
- // ],
105
-
106
91
  // Caps on open and hourly PRs.
107
92
  prConcurrentLimit: 10,
108
93
  prHourlyLimit: 4,
@@ -43,14 +43,6 @@ jobs:
43
43
  # (PR title for feature-branch pushes vs commit message for direct dev/main pushes)
44
44
  # and docs/testing.md § "CI verbosity" for the full knob list.
45
45
  #
46
- # BKIT_GH_TOKEN_INSTALL is declared at the job level so $BKIT_GH_TOKEN_INSTALL is available to the
47
- # install step's `pnpm config set` (the REQUIRED GH Packages auth — pnpm >=10.34.3
48
- # 401s on a project-.npmrc ${BKIT_GH_TOKEN_INSTALL} env-substitution) and to any later
49
- # pnpm/npx invocation. The committed project .npmrc carries ONLY the @cbartens
50
- # registry mapping; `pnpm config set` writes the shell-expanded literal token into
51
- # pnpm's user-level config before install (works across pnpm 10.x/11.x). The install
52
- # step also keeps its own env: block.
53
- #
54
46
  # NODE_OPTIONS is set HERE, in static YAML, and must NEVER be written to $GITHUB_ENV.
55
47
  # The runner blocklists NODE_OPTIONS for the $GITHUB_ENV / set-env workflow command:
56
48
  # the write is REJECTED with
@@ -63,7 +55,6 @@ jobs:
63
55
  TURBO_LOG_LEVEL: ${{ (contains(github.event.head_commit.message, '[verbose ci]') || contains(github.event.pull_request.title, '[verbose ci]')) && 'full' || 'errors-only' }}
64
56
  VERBOSE_CI: ${{ (contains(github.event.head_commit.message, '[verbose ci]') || contains(github.event.pull_request.title, '[verbose ci]')) && '1' || '' }}
65
57
  NODE_OPTIONS: ${{ (contains(github.event.head_commit.message, '[verbose ci]') || contains(github.event.pull_request.title, '[verbose ci]')) && '--trace-warnings --trace-deprecation' || '' }}
66
- BKIT_GH_TOKEN_INSTALL: ${{ secrets.BKIT_GH_TOKEN_INSTALL }}
67
58
  steps:
68
59
  - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
69
60
  with:
@@ -216,13 +207,7 @@ jobs:
216
207
 
217
208
  - name: Install Dependencies
218
209
  if: steps.cache.outputs.skip != 'true'
219
- # Write the GH Packages auth token into pnpm's user-level config before install
220
- # (REQUIRED — pnpm >=10.34.3 401s on a project-.npmrc ${BKIT_GH_TOKEN_INSTALL} ref).
221
- run: |
222
- pnpm config set "//npm.pkg.github.com/:_authToken=$BKIT_GH_TOKEN_INSTALL"
223
- pnpm install --frozen-lockfile
224
- env:
225
- BKIT_GH_TOKEN_INSTALL: ${{ secrets.BKIT_GH_TOKEN_INSTALL }}
210
+ run: pnpm install --frozen-lockfile
226
211
 
227
212
  # Static checks first — they read the source tree and must scan it CLEAN.
228
213
  # Vitest/build run AFTER (below): they write coverage, dist/, and other
@@ -318,7 +303,6 @@ jobs:
318
303
  TURBO_LOG_LEVEL: ${{ (contains(github.event.head_commit.message, '[verbose ci]') || contains(github.event.pull_request.title, '[verbose ci]')) && 'full' || 'errors-only' }}
319
304
  VERBOSE_CI: ${{ (contains(github.event.head_commit.message, '[verbose ci]') || contains(github.event.pull_request.title, '[verbose ci]')) && '1' || '' }}
320
305
  NODE_OPTIONS: ${{ (contains(github.event.head_commit.message, '[verbose ci]') || contains(github.event.pull_request.title, '[verbose ci]')) && '--trace-warnings --trace-deprecation' || '' }}
321
- BKIT_GH_TOKEN_INSTALL: ${{ secrets.BKIT_GH_TOKEN_INSTALL }}
322
306
  steps:
323
307
  - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
324
308
  with:
@@ -418,11 +402,7 @@ jobs:
418
402
 
419
403
  - name: Install Dependencies
420
404
  if: steps.cache.outputs.skip != 'true'
421
- run: |
422
- pnpm config set "//npm.pkg.github.com/:_authToken=$BKIT_GH_TOKEN_INSTALL"
423
- pnpm install --frozen-lockfile
424
- env:
425
- BKIT_GH_TOKEN_INSTALL: ${{ secrets.BKIT_GH_TOKEN_INSTALL }}
405
+ run: pnpm install --frozen-lockfile
426
406
 
427
407
  # bkit-stub:supabase-migrate — REMOTE `db push` belongs in `bkit-tests-migration`, NOT here
428
408
  # and NOT in `bkit-tests-e2e-web`. Prefer the migration-lane stub below
@@ -154,7 +154,6 @@ jobs:
154
154
  ref: dev
155
155
  fetch-depth: 0
156
156
  # The auto-provided GITHUB_TOKEN inherits the `permissions:` block above.
157
- # Do not swap in BKIT_GH_TOKEN_INSTALL — it has no access to the consumer repo.
158
157
  token: ${{ github.token }}
159
158
 
160
159
  - name: Configure git user
@@ -470,7 +469,6 @@ jobs:
470
469
  ref: dev
471
470
  fetch-depth: 0
472
471
  # The auto-provided GITHUB_TOKEN inherits the `permissions:` block above.
473
- # Do not swap in BKIT_GH_TOKEN_INSTALL — it has no access to the consumer repo.
474
472
  token: ${{ github.token }}
475
473
 
476
474
  # Installs the vale binary for bkit-cloud-bootstrap.sh's `vale sync` and the dispatched
@@ -95,11 +95,6 @@ jobs:
95
95
  # allowedEnv") and Renovate does nothing. Mend allows these via its safeEnv
96
96
  # preset; self-hosted must set it explicitly. Glob covers any future PNPM_* var.
97
97
  RENOVATE_ALLOWED_ENV: "PNPM_*"
98
- # Private-registry read auth for the restricted @cbartens/bkit package.
99
- # Leave the hostRules token line in renovate.json5 commented. BKIT_GH_TOKEN_INSTALL
100
- # (read:packages) is a repo Actions secret. See docs/deployments.md § Dependency updaters.
101
- RENOVATE_HOST_RULES: >-
102
- [{"matchHost":"npm.pkg.github.com","hostType":"npm","token":"${{ secrets.BKIT_GH_TOKEN_INSTALL }}"}]
103
98
  LOG_LEVEL: ${{ inputs.logLevel || 'info' }}
104
99
  RENOVATE_DRY_RUN: ${{ inputs.dryRun || 'null' }}
105
100
  # This env block declares NO ANTHROPIC_API_KEY / BKIT_LINEAR_API_KEY
package/CHANGELOG.md CHANGED
@@ -6,6 +6,23 @@ Format: `## [version] — YYYY-MM-DD`
6
6
 
7
7
  ---
8
8
 
9
+ ## [5.0.1] — 2026-10-12
10
+
11
+ ### Changed
12
+
13
+ - **`@cbartens/bkit` publishes to the public npm registry** (#408). Installs resolve from `https://registry.npmjs.org` with no token, no `@cbartens:registry` `.npmrc` mapping and no GitHub Packages auth; GitHub Packages is no longer updated. Releases publish through npm OIDC trusted publishing with a signed build-provenance attestation.
14
+
15
+ ### Added
16
+
17
+ - **Payload view links: `.bkit/core` and `.bkit/shared` symlink into the installed package** (#525). `bkit install` and `bkit upgrade` create both as relative links to `node_modules/@cbartens/bkit/.bkit/{core,shared}`, so the workflow / prompt / hook sources are browsable from the consumer repo. Views, not copies — always the installed version, never hashed, and `bkit check` flags a missing or broken link as drift. Both paths join the managed `.gitignore` block (they dangle on a fresh clone or in CI) and `BKIT_GITIGNORE_LINES`. A real directory or file at either path is never clobbered (advisory `payload-link-real-dir`); a platform that refuses symlinks (Windows without Developer Mode) falls back to a junction, then to advisory `payload-link-failed` — never a failure. `bkit uninstall` removes the links (symlinks only). Hand-rolled links from before this release keep working — re-pointed only if they resolve elsewhere — and the duplicates advisory asks you to drop the consumer-side `.gitignore` lines the managed block now covers.
18
+ - **Dismiss an advisory per package.** A detector can be right in general and still fire where the condition is deliberately not applicable — a rule-linter whose test titles mention `@live`, an integration lane mocked by design. `package.json` `bkit.ignoreAdvisories: string[]` opts a package out of an advisory id. The check runs inside each detector and drops only the owning package, so a sibling package's real finding still fires; a `blocker` is never suppressible. Suppressions print one line in the console banner and `.bkit/advisories.md`. Wired for `tagged-tests-no-ci-home` (the package holding the test file) and `test-integration-env-not-asserted` (the repo root — the only manifest that detector reads).
19
+
20
+ ### Removed
21
+
22
+ - **GitHub Packages install-auth machinery** (#408). `BKIT_GH_TOKEN_INSTALL`, the four-surface token presence matrix, the `.npmrc` registry-mapping migration, and the CI / Vercel / cloud / Renovate install-auth steps are gone; the templates that wired them (`bkit-ci.yml`, `bkit-cloud.yml`, `bkit-renovate.yml`) no longer reference them. `BKIT_GH_TOKEN` (GitHub MCP + self-hosted Renovate platform auth) is unchanged.
23
+
24
+ ---
25
+
9
26
  ## [5.0.0] — 2026-10-11
10
27
 
11
28
  bkit owns only what a workflow step runs or parses (#489). Everything a person or another tool runs — the CI workflow, git hooks, lint and prose configs, editor and cloud-agent setup, dependency updaters, helper scripts — ships as a template the consumer copies and owns. Every file bkit ships is in one of three groups: an owned file, an owned block in a shared file, or a template, copied to `.bkit/templates/`.
package/README.md CHANGED
@@ -26,7 +26,7 @@ AI coding agents are fast, but on their own they skip the parts that make softwa
26
26
  <p align="center">
27
27
  <picture>
28
28
  <source media="(prefers-color-scheme: dark)" srcset=".github/assets/bkit-features-dark.svg">
29
- <img alt="What ships with bkit: ready-made workflows, independent review, self-fixing builds, 35 audits, your sign-off, guardrails, honest CI, quality checks, any AI tool, laptop to cloud, parallel features, skills on demand, docs and memory kept current, best model per job, work stats, templates to adopt." src=".github/assets/bkit-features-light.svg" width="100%">
29
+ <img alt="What ships with bkit, one coloured row per phase. Design: independent review, three rival designs, runs on any AI tool, your sign-off. Plan: five reviewers, scope kept tight, 35 audits, best model per job. Build: writes and verifies, hunts bugs and security holes, quality checks, parallel features. Debug: self-fixing builds, root cause first, honest CI, context fetch. Ship: nothing quietly dropped, docs and memory, skills on demand, laptop to cloud." src=".github/assets/bkit-features-light.svg" width="100%">
30
30
  </picture>
31
31
  </p>
32
32
 
@@ -40,7 +40,7 @@ One command per job. Each one runs a team of specialised agents, 48 in total, so
40
40
  | Work out how to build it | `/bkit-design` | Three agents propose different approaches, two more critique them, and you get one design to approve. |
41
41
  | Plan the work | `/bkit-plan` | A step-by-step plan, stress-tested by five reviewers before any code is written. You approve it. |
42
42
  | Build it | `/bkit-build` | Writes the code, checks it against the plan, hunts for bugs and security holes, runs the tests, and opens a pull request. |
43
- | Fix what broke | `/bkit-debug` | Reads the failure logs, finds the cause, fixes it, re-tests, and writes down the lesson. |
43
+ | Fix what broke | `/bkit-debug` | Gathers external context from your platforms (CI, error trackers, hosting, databases and more), finds the cause, fixes it, re-tests, and writes down the lesson. |
44
44
  | Ship it | `/bkit-ship` | Checks nothing was missed, waits for every test to pass, updates the docs, and merges once you say so. |
45
45
  | Health check | 35 audits | Security, privacy, accessibility, performance, reliability, cost and more. Findings feed straight into `/bkit-plan`. |
46
46
  | Housekeeping | utility agents | Keep docs, decisions, known issues and the roadmap current. |
@@ -73,6 +73,7 @@ One command per job. Each one runs a team of specialised agents, 48 in total, so
73
73
 
74
74
  - **Everything is checked by an agent that didn't write it.** An AI checking its own work tends to approve it. bkit gives every design, plan and code change to separate reviewers, each with one job (one hunts bugs, another security holes). They never see each other's verdicts, and several review groups mix models on purpose, so one model's blind spot is less likely to get past all of them.
75
75
  - **Broken builds fix themselves, and stay fixed.** When tests fail you don't get a wall of red text. `/bkit-debug` finds the cause, fixes it and re-runs the tests, then records the lesson so the next debug session reads it first.
76
+ - **Debug starts from outside evidence, not a guess.** `/bkit-debug` gathers external context from the platforms you already use — CI, error trackers, hosting, databases, web search — so it diagnoses from the real failure rather than its memory. Ready-made templates cover the common services, and each one is easy to customise, extend or leave out.
76
77
  - **A green tick means every test ran.** The CI template runs test lanes side by side and fails the build if any planned lane was skipped, so a half-finished run can't pass as tested.
77
78
 
78
79
  ### It fits how you work
@@ -112,11 +113,9 @@ You need a GitHub repo, Node 20+, pnpm, and at least one of Claude Code, Cursor,
112
113
 
113
114
  **Easiest:** copy the [install prompt](.bkit/install.md#install--first-time) into your AI coding tool and let it do the setup.
114
115
 
115
- **By hand:** bkit is currently published to GitHub Packages, so you need a classic GitHub token with `read:packages` scope ([create one](https://github.com/settings/tokens)).
116
+ **By hand:** no token or registry setup — bkit is public on npmjs and installs like any other package.
116
117
 
117
118
  ```bash
118
- echo "@cbartens:registry=https://npm.pkg.github.com" >> .npmrc
119
- pnpm config set "//npm.pkg.github.com/:_authToken=<your-token>"
120
119
  pnpm add -D @cbartens/bkit
121
120
  pnpm bkit install --claude # pick your tools: --claude --cursor --codex --opencode=<provider>
122
121
  ```
@@ -127,7 +126,7 @@ Adopt the templates you want from `.bkit/templates/`, then open an issue and run
127
126
  /bkit-design ISSUE-123
128
127
  ```
129
128
 
130
- Full install, upgrade and CI/Vercel token setup: [`.bkit/install.md`](.bkit/install.md).
129
+ Full install, upgrade and CI setup: [`.bkit/install.md`](.bkit/install.md).
131
130
 
132
131
  ## FAQ
133
132
 
@@ -1,31 +1,15 @@
1
- // checks/after/auth.ts — credentials: shell and GitHub-MCP tokens, `.npmrc` auth, GitHub
2
- // secrets (incl. the cloud router's), and the cloud-dashboard secrets checklist.
1
+ // checks/after/auth.ts — credentials: the GitHub-MCP token, GitHub repo secrets (incl.
2
+ // the cloud router's), and the cloud-dashboard secrets checklist.
3
3
  import * as fs from "node:fs";
4
4
  import * as path from "node:path";
5
5
  import { execSync } from "node:child_process";
6
6
  import { readConsumerCloudAgents } from "./github.js";
7
7
  /**
8
- * Detect whether BKIT_GH_TOKEN_INSTALL is set in the shell environment.
9
- * - "present" → set and non-empty
10
- * - "missing" → not set at all (undefined)
11
- * - "empty" → set but empty string (`BKIT_GH_TOKEN_INSTALL=""`)
12
- *
13
- * Distinguishes empty from unset so action text can guide the user precisely.
14
- * Never reads the token value beyond truthiness.
15
- */
16
- export function detectShellToken() {
17
- if (process.env.BKIT_GH_TOKEN_INSTALL === undefined)
18
- return "missing";
19
- if (process.env.BKIT_GH_TOKEN_INSTALL === "")
20
- return "empty";
21
- return "present";
22
- }
23
- /**
24
- * Detect whether BKIT_GH_TOKEN is set in the shell environment. Mirrors
25
- * detectShellToken but for the token that authenticates the GitHub MCP server
26
- * (`Authorization: Bearer ${BKIT_GH_TOKEN}` in .mcp.json). Where BKIT_GH_TOKEN_INSTALL only
27
- * gates `pnpm install` from GH Packages, BKIT_GH_TOKEN powers the entire tracker +
28
- * PR + Projects MCP surface — so its absence is more functionally severe.
8
+ * Detect whether BKIT_GH_TOKEN is set in the shell environment. Distinguishes
9
+ * empty from unset so action text can guide the user precisely. Never reads the
10
+ * token value beyond truthiness. BKIT_GH_TOKEN authenticates the GitHub MCP
11
+ * server (`Authorization: Bearer ${BKIT_GH_TOKEN}` in .mcp.json), which powers
12
+ * the entire tracker + PR + Projects MCP surface.
29
13
  */
30
14
  export function detectShellGhMcpToken() {
31
15
  if (process.env.BKIT_GH_TOKEN === undefined)
@@ -58,45 +42,11 @@ export function hasGithubMcpServer(cwd) {
58
42
  return false;
59
43
  }
60
44
  /**
61
- * Detect whether .npmrc declares the @cbartens GH Packages registry mapping.
62
- *
63
- * On pnpm >=10.34.3 the _authToken is NOT stored in the project
64
- * .npmrc: a project-.npmrc `${BKIT_GH_TOKEN_INSTALL}` env-substitution 401s on download
65
- * (ERR_PNPM_FETCH_401), so the token lives in pnpm's user-level config (written via
66
- * `pnpm config set`). The only line the committed project .npmrc must carry is the
67
- * registry scope mapping.
68
- * - "present" → `@cbartens:registry=` present (registry-only is the correct shape)
69
- * - "missing" → .npmrc exists but lacks the registry mapping (emit advisory)
70
- * - "unknown" → .npmrc is absent (silent skip — absence alone is not misconfiguration)
71
- *
72
- * A project-.npmrc auth-token line (`//npm.pkg.github.com/:_authToken=…`) is neither
73
- * required nor flagged here; detectNpmrcAuthTokenLine flags it.
74
- */
75
- export function detectNpmrcAuth(cwd) {
76
- const npmrcPath = path.join(cwd, ".npmrc");
77
- if (!fs.existsSync(npmrcPath))
78
- return "unknown";
79
- const content = fs.readFileSync(npmrcPath, "utf-8");
80
- return content.includes("@cbartens:registry=") ? "present" : "missing";
81
- }
82
- /**
83
- * Detect a project-.npmrc auth-token line (`//npm.pkg.github.com/:_authToken=`).
84
- * On pnpm >=10.34.3 this line breaks installs: pnpm 401s on download
85
- * and, via config precedence (project .npmrc > user config), it shadows the user-level
86
- * token written by `pnpm config set`. Returns true when present.
87
- */
88
- export function detectNpmrcAuthTokenLine(cwd) {
89
- const npmrcPath = path.join(cwd, ".npmrc");
90
- if (!fs.existsSync(npmrcPath))
91
- return false;
92
- return fs.readFileSync(npmrcPath, "utf-8").includes("//npm.pkg.github.com/:_authToken=");
93
- }
94
- /**
95
- * Detect whether BKIT_GH_TOKEN_INSTALL secret is set on the consumer's GitHub repo.
45
+ * Detect whether a named secret is set on the consumer's GitHub repo.
96
46
  * Returns "present" | "missing" | "unknown".
97
47
  * "unknown" if gh CLI unavailable, unauthenticated, or not a GitHub repo.
98
48
  */
99
- export function detectGhSecret(secretName = "BKIT_GH_TOKEN_INSTALL") {
49
+ export function detectGhSecret(secretName) {
100
50
  try {
101
51
  const out = execSync(`gh secret list --json name -q '.[].name'`, {
102
52
  encoding: "utf-8",
@@ -133,16 +83,12 @@ export function buildCloudDashboardsAdvisory(cwd) {
133
83
  // Distinguish by recorded variant; fall back to presence-based detection.
134
84
  const recordedVariant = readConsumerCloudAgents(cwd);
135
85
  const isCursorCloud = recordedVariant === "cursor" || (!hasRouter && hasCursor);
136
- const secretList = isCursorCloud
137
- ? "`BKIT_LINEAR_API_KEY`, `BKIT_GH_TOKEN_INSTALL`"
138
- : "`ANTHROPIC_API_KEY`, `BKIT_GH_TOKEN_INSTALL`";
86
+ const secretList = isCursorCloud ? "`BKIT_LINEAR_API_KEY`" : "`ANTHROPIC_API_KEY`";
139
87
  const ghSetLines = isCursorCloud
140
- ? " gh secret set BKIT_LINEAR_API_KEY --body='<value>'\n" +
141
- ' gh secret set BKIT_GH_TOKEN_INSTALL --body="$BKIT_GH_TOKEN_INSTALL"\n\n' +
142
- " Verify: `gh secret list | grep -E 'BKIT_LINEAR_API_KEY|BKIT_GH_TOKEN_INSTALL'`\n\n"
143
- : " gh secret set ANTHROPIC_API_KEY --body='<value>'\n" +
144
- ' gh secret set BKIT_GH_TOKEN_INSTALL --body="$BKIT_GH_TOKEN_INSTALL"\n\n' +
145
- " Verify: `gh secret list | grep -E 'ANTHROPIC_API_KEY|BKIT_GH_TOKEN_INSTALL'`\n\n";
88
+ ? " gh secret set BKIT_LINEAR_API_KEY --body='<value>'\n\n" +
89
+ " Verify: `gh secret list | grep -E 'BKIT_LINEAR_API_KEY'`\n\n"
90
+ : " gh secret set ANTHROPIC_API_KEY --body='<value>'\n\n" +
91
+ " Verify: `gh secret list | grep -E 'ANTHROPIC_API_KEY'`\n\n";
146
92
  const vendorNote = isCursorCloud
147
93
  ? "BKIT_LINEAR_API_KEY is read from the Linear dashboard (https://linear.app/settings/api)."
148
94
  : "ANTHROPIC_API_KEY is read from the Anthropic dashboard (https://console.anthropic.com/settings/keys); `.bkit/.env` holds the same value as BKIT_ANTHROPIC_API_KEY. The Claude GitHub App (`/install-github-app`) is also required for `cloud=claude`.";
@@ -156,7 +102,7 @@ export function buildCloudDashboardsAdvisory(cwd) {
156
102
  "2. **Cursor Cloud Agents** (used by Cursor's cloud agent runner): open `https://cursor.com/dashboard/cloud-agents` → your environment → **Secrets** tab. Add each secret as a **Runtime Secret** (loaded as an env var, redacted from the agent's transcript). Cursor reads `.cursor/Dockerfile` + `.cursor/environment.json` from the repo but secrets come from this dashboard only; the resolved paste-ready values are in `.cursor/bkit-cloud.md` (gitignored).\n\n" +
157
103
  "3. **Claude Code (web)** (used by Claude.ai's cloud agent runner): open `https://claude.ai/code` → Settings → Setup → Environment Variables. Add each secret. Claude reads its setup script from the dashboard, NOT from the repo, so changes here do not require a commit.\n\n" +
158
104
  "**Context-fetch (`/bkit-debug` in the cloud):** if you run the debug workflow in these cloud agents, the observability creds your `.agents/context.md` context-fetch blocks use (e.g. `VERCEL_TOKEN`, `SUPABASE_ACCESS_TOKEN`) must ALSO be set in the same dashboards above — non-interactively, since headless agents cannot `vercel login`. These are operator/observability READ creds, not app-runtime secrets. Commit the non-secret selectors (team scope / project ref / `--environment`) in your copied block so they need no dashboard entry. The CLIs those blocks call install automatically in the cloud from each block's `context-fetch:provision` sibling — no manual setup.\n\n" +
159
- "Same VALUE in all places. BKIT_GH_TOKEN_INSTALL must be a PAT with `read:packages` (classic) or `Packages: read` (fine-grained) scope. " +
105
+ "Same VALUE in all places. " +
160
106
  vendorNote,
161
107
  };
162
108
  }
@@ -188,45 +134,7 @@ export function detectCiRouterSecrets(cwd) {
188
134
  `Then verify: \`gh secret list | grep ${name}\`. The workflow itself does not need redeploying — secrets are read at run time.`,
189
135
  });
190
136
  }
191
- // "unknown" → silent skip (CLI absent / unauthenticated — covered by gh-bkit-token-secret-unknown).
137
+ // "unknown" → silent skip (CLI absent / unauthenticated).
192
138
  }
193
139
  return findings;
194
140
  }
195
- // ---------------------------------------------------------------------------
196
- // BKIT_GH_TOKEN_INSTALL action strings (verbatim from install/modules/index.ts constants)
197
- // ---------------------------------------------------------------------------
198
- // Guidance appended to BKIT_GH_TOKEN_INSTALL missing-token actions for AI agents whose
199
- // permission rules block direct reads of .env* files. `source` is a shell
200
- // builtin (not file I/O), so it bypasses Read/grep/cat permission gates — the
201
- // token text never enters the agent's context. Must run in a SINGLE Bash call
202
- // because shell state does not persist across separate tool invocations.
203
- export const AGENT_INLINE_SOURCE_GUIDANCE = "AGENT NOTE — if you are an AI coding agent and your permission rules block reading `.env*` files directly (e.g. Read(./.env*) / Bash(grep ... .env*) denied), you can still export BKIT_GH_TOKEN_INSTALL into a single command's environment. Ask the user which `.env*` file holds BKIT_GH_TOKEN_INSTALL (commonly `apps/web/.env.preview` or `.env.local`), then run — in ONE Bash call:\n\n" +
204
- " set -a; source apps/web/.env.preview 2>/dev/null; set +a; <command-that-needs-token>\n\n" +
205
- "`source` is a shell builtin, not file I/O — the permission layer that gates Read/grep/cat does not see it, and the token text never enters your context. The consuming command (e.g. `pnpm view @cbartens/bkit`, `pnpm exec bkit check`) inherits BKIT_GH_TOKEN_INSTALL via the environment.\n\n" +
206
- "Shell state does NOT persist between separate Bash tool calls — `source` and the consuming command MUST run in the same invocation (chain with `;` or `&&`). Verify the token loaded without leaking its value:\n\n" +
207
- ' echo "len=${#BKIT_GH_TOKEN_INSTALL}"';
208
- export const BKIT_GH_TOKEN_INSTALL_MISSING_ACTION = "Add the @cbartens registry mapping to .npmrc at the repo root (the token is NOT stored here):\n\n" +
209
- " @cbartens:registry=https://npm.pkg.github.com\n\n" +
210
- "Write the token into pnpm's user-level config (run once locally; CI does this in its install step, shown below):\n\n" +
211
- ' pnpm config set "//npm.pkg.github.com/:_authToken=$BKIT_GH_TOKEN_INSTALL"\n\n' +
212
- "Then set the BKIT_GH_TOKEN_INSTALL secret on this repo. The token must be a GitHub PAT (classic or fine-grained) with read:packages scope (classic) OR Packages: read permission (fine-grained). Generate at: https://github.com/settings/tokens\n\n" +
213
- "Run ONE of these to set it:\n\n" +
214
- " gh secret set BKIT_GH_TOKEN_INSTALL --body='<paste-token-here>'\n\n" +
215
- "Ensure the install step in .github/workflows/bkit-ci.yml writes the token before install:\n\n" +
216
- " - name: Install Dependencies\n" +
217
- " run: |\n" +
218
- ' pnpm config set "//npm.pkg.github.com/:_authToken=$BKIT_GH_TOKEN_INSTALL"\n' +
219
- " pnpm install --frozen-lockfile\n" +
220
- " env:\n" +
221
- " BKIT_GH_TOKEN_INSTALL: ${{ secrets.BKIT_GH_TOKEN_INSTALL }}\n\n" +
222
- "IMPORTANT — pnpm >=10.34.3 does not authenticate a project-.npmrc ${BKIT_GH_TOKEN_INSTALL} env-substitution and 401s on download (ERR_PNPM_FETCH_401), so the token must be set via `pnpm config set` — the shell expands $BKIT_GH_TOKEN_INSTALL to the literal token before pnpm stores it in user-level config, version-proof across pnpm 10.x and 11.x. Metadata calls (pnpm view) can still resolve, so the failure only shows on a real install.\n\n" +
223
- "Verify secret set: gh secret list | grep BKIT_GH_TOKEN_INSTALL";
224
- export const BKIT_GH_TOKEN_INSTALL_UNKNOWN_ACTION = "Could not auto-check BKIT_GH_TOKEN_INSTALL secret (gh CLI unavailable, unauthenticated, or this isn't a GitHub repo yet).\n\n" +
225
- "Manually verify the BKIT_GH_TOKEN_INSTALL secret exists on the consumer's GitHub repo. It is required for the CI install step (`pnpm config set` + `pnpm install`) to authenticate against the GitHub Packages npm registry when installing @cbartens/bkit. bkit's ci.yml template (.bkit/templates/.github/workflows/bkit-ci.yml) carries that step; copy it into your own .github/workflows/bkit-ci.yml when you adopt the template.\n\n" +
226
- "IMPORTANT — pnpm >=10.34.3 does not authenticate a project-.npmrc ${BKIT_GH_TOKEN_INSTALL} env-substitution and 401s on download (ERR_PNPM_FETCH_401). The template's install step writes the token via `pnpm config set` (the shell expands $BKIT_GH_TOKEN_INSTALL to the literal token before pnpm stores it in user-level config); if BKIT_GH_TOKEN_INSTALL is unset there, that write is empty and the install 401s.\n\n" +
227
- "Once `gh` is installed and authenticated, get your token and export it:\n\n" +
228
- " export BKIT_GH_TOKEN_INSTALL=$(gh auth token)\n\n" +
229
- "Then verify the secret is set on the repo:\n\n" +
230
- " gh secret list | grep BKIT_GH_TOKEN_INSTALL\n\n" +
231
- "If absent, set it:\n\n" +
232
- " gh secret set BKIT_GH_TOKEN_INSTALL --body=$(gh auth token)";
@@ -4,71 +4,10 @@
4
4
  import * as fs from "node:fs";
5
5
  import * as path from "node:path";
6
6
  import { readPackageJson } from "../../shared/package-json.js";
7
+ import { isAdvisorySuppressed } from "./suppression.js";
7
8
  // ---------------------------------------------------------------------------
8
9
  // Other post-install detectors
9
10
  // ---------------------------------------------------------------------------
10
- /**
11
- * Detect whether the bkit-ci.yml install step is wired to authenticate to GH Packages.
12
- * Returns null if no bkit-ci.yml, no `pnpm install` step, or the step is correctly wired
13
- * (no false positives).
14
- *
15
- * On pnpm >=10.34.3 the correct shape requires BOTH:
16
- * (1) a `pnpm config set "//npm.pkg.github.com/:_authToken=$BKIT_GH_TOKEN_INSTALL"` step that
17
- * writes the token into pnpm's user-level config before install, AND
18
- * (2) the `BKIT_GH_TOKEN_INSTALL: ${{ secrets.BKIT_GH_TOKEN_INSTALL }}` env mapping that feeds it.
19
- * Either missing → the next install 401s on download. Severity is "blocker" when the
20
- * project .npmrc shows the repo authenticates to GH Packages (registry mapping or a
21
- * ${BKIT_GH_TOKEN_INSTALL} ref); otherwise "advisory". Phase 3 does not exit-1
22
- * (writes already happened).
23
- */
24
- export function detectCiYmlMissingTokenEnv(cwd) {
25
- const ciPath = path.join(cwd, ".github", "workflows", "bkit-ci.yml");
26
- if (!fs.existsSync(ciPath))
27
- return null;
28
- const content = fs.readFileSync(ciPath, "utf-8");
29
- // Require an install step before flagging (avoid false positives).
30
- if (!content.includes("pnpm install"))
31
- return null;
32
- // Env mapping (whitespace/quoting variations):
33
- // BKIT_GH_TOKEN_INSTALL: ${{ secrets.BKIT_GH_TOKEN_INSTALL }} | "${{ … }}" | ${{secrets.BKIT_GH_TOKEN_INSTALL}}
34
- const hasTokenEnv = /BKIT_GH_TOKEN_INSTALL\s*:\s*["']?\$\{\{\s*secrets\.BKIT_GH_TOKEN_INSTALL\s*\}\}["']?/.test(content);
35
- // User-level auth step: `pnpm config set "//npm.pkg.github.com/:_authToken=…"`.
36
- const hasConfigSet = /pnpm\s+config\s+set\s+["']?\/\/npm\.pkg\.github\.com\/:_authToken=/.test(content);
37
- // Correctly wired → no finding.
38
- if (hasTokenEnv && hasConfigSet)
39
- return null;
40
- // Blocker when .npmrc shows the repo authenticates to GH Packages — next run 401s.
41
- const npmrcPath = path.join(cwd, ".npmrc");
42
- let npmrcUsesGhPackages = false;
43
- if (fs.existsSync(npmrcPath)) {
44
- const npmrcContent = fs.readFileSync(npmrcPath, "utf-8");
45
- npmrcUsesGhPackages =
46
- npmrcContent.includes("@cbartens:registry=") ||
47
- npmrcContent.includes("${BKIT_GH_TOKEN_INSTALL}");
48
- }
49
- const missing = [];
50
- if (!hasConfigSet)
51
- missing.push("a `pnpm config set` auth step");
52
- if (!hasTokenEnv)
53
- missing.push("the BKIT_GH_TOKEN_INSTALL env mapping");
54
- const missingText = missing.join(" and ");
55
- return {
56
- id: "ci-yml-missing-token-env",
57
- severity: npmrcUsesGhPackages ? "blocker" : "advisory",
58
- detect: npmrcUsesGhPackages
59
- ? `.github/workflows/bkit-ci.yml has a pnpm install step but is missing ${missingText}, and .npmrc authenticates to the GitHub Packages registry. The next CI run will 401 on the @cbartens/bkit download.`
60
- : `.github/workflows/bkit-ci.yml has a pnpm install step but is missing ${missingText}.`,
61
- action: "Update the install step in .github/workflows/bkit-ci.yml to write the auth token into pnpm's user-level config BEFORE install:\n\n" +
62
- " - name: Install Dependencies\n" +
63
- " run: |\n" +
64
- ' pnpm config set "//npm.pkg.github.com/:_authToken=$BKIT_GH_TOKEN_INSTALL"\n' +
65
- " pnpm install --frozen-lockfile\n" +
66
- " env:\n" +
67
- " BKIT_GH_TOKEN_INSTALL: ${{ secrets.BKIT_GH_TOKEN_INSTALL }}\n\n" +
68
- "pnpm >=10.34.3 does not authenticate a project-.npmrc ${BKIT_GH_TOKEN_INSTALL} env-substitution (it 401s on download), so the token must be set via `pnpm config set` — the shell expands $BKIT_GH_TOKEN_INSTALL to the literal token before pnpm stores it in user-level config, version-proof across pnpm 10.x and 11.x.\n\n" +
69
- "Also confirm the secret exists: `gh secret list | grep BKIT_GH_TOKEN_INSTALL`. If absent: `gh secret set BKIT_GH_TOKEN_INSTALL --body=$BKIT_GH_TOKEN_INSTALL`.",
70
- };
71
- }
72
11
  /**
73
12
  * Detect the always-true `if:` gate in `.github/workflows/bkit-cloud.yml`: a `|`
74
13
  * block scalar wrapping ${{ }}. GitHub Actions sees extra characters around ${{ }}
@@ -418,8 +357,12 @@ function tagUsedInTestTitle(text, tag, mask) {
418
357
  * Only flags a tag when the convention is ACTIVE in the repo (at least one package
419
358
  * declares the script); a silent no-op otherwise. WARNING-only; the capstone's
420
359
  * `run_live => live_ran > 0` assertion is the runtime check.
360
+ *
361
+ * A package whose own `package.json` opts out (`bkit.ignoreAdvisories`) is dropped from the
362
+ * list and reported via `onSuppressed`; sibling packages keep flagging, because the finding
363
+ * aggregates every affected package into one entry.
421
364
  */
422
- export function detectTaggedTestsWithoutCiHome(cwd) {
365
+ export function detectTaggedTestsWithoutCiHome(cwd, onSuppressed) {
423
366
  const testFiles = [];
424
367
  const packageJsons = [];
425
368
  walkRepoForHomeCheck(cwd, testFiles, packageJsons);
@@ -453,6 +396,7 @@ export function detectTaggedTestsWithoutCiHome(cwd) {
453
396
  }
454
397
  };
455
398
  const homeless = new Map(); // tag -> set of "pkgdir (needs `script`)"
399
+ const suppressedPkgs = new Set(); // pkgs opted out — one note each, however many files
456
400
  for (const file of testFiles) {
457
401
  let text;
458
402
  try {
@@ -474,7 +418,15 @@ export function detectTaggedTestsWithoutCiHome(cwd) {
474
418
  if (!pj)
475
419
  continue;
476
420
  if (typeof pkgScripts.get(pj)?.[script] !== "string") {
477
- const rel = path.relative(cwd, path.dirname(pj)) || ".";
421
+ const pkgDir = path.dirname(pj);
422
+ const rel = path.relative(cwd, pkgDir) || ".";
423
+ if (isAdvisorySuppressed(pkgDir, "tagged-tests-no-ci-home", "advisory")) {
424
+ if (!suppressedPkgs.has(rel)) {
425
+ suppressedPkgs.add(rel);
426
+ onSuppressed?.({ id: "tagged-tests-no-ci-home", scope: rel });
427
+ }
428
+ continue; // drop only this package; a sibling package keeps flagging
429
+ }
478
430
  if (!homeless.has(tag))
479
431
  homeless.set(tag, new Set());
480
432
  homeless.get(tag)?.add(rel);
@@ -496,7 +448,9 @@ export function detectTaggedTestsWithoutCiHome(cwd) {
496
448
  detect: "Found `@live`/`@smoke`-tagged tests in package(s) that declare no matching `test:live`/`test:smoke` script. `turbo run test:live` skips a package with no such script and exits 0 — the tagged tests never run, and the tier reports green having executed nothing (ghost-green / 'no CI home').",
497
449
  action: "Give each tagged suite a CI home — add the matching script to the package's package.json so the live/smoke tier actually invokes it:\n\n" +
498
450
  lines.join("\n") +
499
- '\n\nExample: `"test:live": "vitest run --project live"` (or your runner\'s tag filter). The bkit-tests-check capstone\'s `run_live => live_ran > 0` assertion is the runtime backstop; this catches it earlier.',
451
+ '\n\nExample: `"test:live": "vitest run --project live"` (or your runner\'s tag filter). The bkit-tests-check capstone\'s `run_live => live_ran > 0` assertion is the runtime backstop; this catches it earlier.' +
452
+ "\n\nFalse positive? A title that only MENTIONS the tag (a rule linter describing it, a meta/guard test naming the scenario) is indistinguishable from a real tagged test. Opt that package out in its package.json — per-package, and it drops only that package from this list:\n\n" +
453
+ ' "bkit": { "ignoreAdvisories": ["tagged-tests-no-ci-home"] }',
500
454
  };
501
455
  }
502
456
  // ---------------------------------------------------------------------------
@@ -558,8 +512,11 @@ export function detectTurboIntegrationInputs(cwd) {
558
512
  * string itself, (2) the CI workflow job that invokes `test:integration` (an
559
513
  * env-agnostic script provisioned at the lane), (3) the vitest integration config the
560
514
  * script points at (home of the documented in-file guard).
515
+ *
516
+ * Root-scoped opt-out: this detector reads only the root `package.json`, so a `bkit.ignoreAdvisories`
517
+ * entry there drops the finding and reports it via `onSuppressed`.
561
518
  */
562
- export function detectTestIntegrationEnv(cwd) {
519
+ export function detectTestIntegrationEnv(cwd, onSuppressed) {
563
520
  const read = readPackageJson(cwd);
564
521
  if (!read.ok)
565
522
  return null;
@@ -567,6 +524,10 @@ export function detectTestIntegrationEnv(cwd) {
567
524
  const script = pkg.scripts?.["test:integration"];
568
525
  if (!script)
569
526
  return null;
527
+ if (isAdvisorySuppressed(cwd, "test-integration-env-not-asserted", "advisory")) {
528
+ onSuppressed?.({ id: "test-integration-env-not-asserted", scope: "." });
529
+ return null;
530
+ }
570
531
  const realServiceHints = [
571
532
  "TEST_REAL_APIS",
572
533
  "SUPABASE_SERVICE_ROLE",
@@ -613,7 +574,9 @@ export function detectTestIntegrationEnv(cwd) {
613
574
  action: "Confirm integration tests actually exercise real services — otherwise the CI integration step (your own, or the one in bkit's bkit-ci.yml template once adopted) is a no-op (KN-23 false-confidence loop). Provision the real-service env at ANY one of these layers (all are recognised):\n\n" +
614
575
  ' - script: "test:integration": "TEST_REAL_APIS=true SUPABASE_URL=$SUPABASE_DEV_URL vitest run --config=vitest.integration.config.ts"\n' +
615
576
  " - CI lane: set `TEST_REAL_APIS` / export the service-role URL / chain `supabase start` around `turbo run test:integration` in the `.github/workflows/*.yml` job that runs it (keeps local `pnpm test:integration` env-agnostic)\n" +
616
- " - vitest integration config: document/enforce the per-file `TEST_REAL_APIS` guard in the config the script `--config`s to.",
577
+ " - vitest integration config: document/enforce the per-file `TEST_REAL_APIS` guard in the config the script `--config`s to.\n\n" +
578
+ "Mocked by design (real-service coverage lives in E2E)? Opt out in the root package.json:\n\n" +
579
+ ' "bkit": { "ignoreAdvisories": ["test-integration-env-not-asserted"] }',
617
580
  };
618
581
  }
619
582
  /**