@caweb/css-audit-webpack-plugin 1.0.12 → 1.1.0

package/bin/auditor/package.json

@@ -12,21 +12,19 @@
   "author": "WordPress CSS Contributors",
   "license": "GPL-2.0-or-later",
   "dependencies": {
-    "@wordpress/eslint-plugin": "9.0.4",
-    "@wordpress/prettier-config": "1.0.3",
-    "chalk": "4.1.1",
-    "cli-table3": "0.6.0",
-    "cosmiconfig": "7.0.0",
-    "css-tree": "1.1.3",
-    "cssom": "0.4.4",
-    "eslint": "7.26.0",
-    "fs-extra": "10.0.0",
-    "glob": "7.1.7",
-    "minimist": "1.2.6",
-    "postcss": "8.2.15",
-    "postcss-values-parser": "5.0.0",
-    "prettier": "npm:wp-prettier@^2.0.5",
-    "tinycolor2": "1.4.2"
+    "@wordpress/eslint-plugin": "^22.0.0",
+    "chalk": "5.4.1",
+    "cli-table3": "0.6.5",
+    "cosmiconfig": "9.0.0",
+    "css-tree": "3.1.0",
+    "cssom": "0.5.0",
+    "eslint": "^8.57.1",
+    "glob": "11.0.3",
+    "minimist": "1.2.8",
+    "postcss": "8.5.6",
+    "postcss-values-parser": "6.0.2",
+    "prettier": "npm:wp-prettier@3.0.3",
+    "tinycolor2": "1.6.0"
   },
   "eslintConfig": {
     "extends": [
@@ -49,8 +47,8 @@
   },
   "prettier": "@wordpress/prettier-config",
   "devDependencies": {
-    "handlebars": "4.7.7",
-    "jest": "26.6.3",
-    "twing": "5.0.2"
+    "handlebars": "4.7.8",
+    "jest": "30.0.3",
+    "twig": "^1.17.1"
   }
 }

package/bin/auditor/src/__tests__/selectors.js

@@ -63,4 +63,18 @@ describe( 'Audit: Selectors', () => {
 		const { value } = results.find( ( { id } ) => 'count' === id );
 		expect( value ).toBe( 2 );
 	} );
+
+	it( 'should handle modern CSS', () => {
+		expect( () => {
+			audit( [
+				{
+					name: 'a.css',
+					content: `h1, h2 { color: green; }
+					div:not([hidden]) { color: black; }
+					body :is(h1, h2) { color: red; }
+					body :where(h1, h2) { color: orange; }`,
+				},
+			] );
+		} ).not.toThrow( SyntaxError );
+	} );
 } );

package/bin/auditor/src/audits/media-queries.js

@@ -17,11 +17,9 @@ module.exports = function ( files = [] ) {
 		csstree.walk( ast, {
 			visit: 'MediaQuery',
 			enter( node ) {
-				if ( node.children ) {
-					allQueries.push( csstree.generate( node ) );
-				}
+				allQueries.push( csstree.generate( node ) );
 				csstree.walk( node, {
-					visit: 'MediaFeature',
+					visit: 'Feature',
 					enter( sizeNode ) {
 						if (
 							sizeNode.name === 'max-width' ||

package/bin/auditor/src/audits/selectors.js

@@ -1,6 +1,7 @@
 /**
  * External dependencies
  */
+const csstree = require( 'css-tree' );
 const { parse } = require( 'postcss' );
 
 const { getSpecificityArray } = require( '../utils/get-specificity' );
@@ -12,10 +13,11 @@ module.exports = function ( files = [] ) {
 	files.forEach( ( { name, content } ) => {
 		const root = parse( content, { from: name } );
 		root.walkRules( function ( { selector } ) {
-			const selectorList = selector.split( ',' );
-			selectorList.forEach( ( selectorName ) => {
-				// Remove excess whitespace from selectors.
-				selectorName = selectorName.replace( /\s+/g, ' ' ).trim();
+			const selectorList = csstree.parse( selector, {
+				context: 'selectorList',
+			} );
+			selectorList.children.forEach( ( _selector ) => {
+				const selectorName = csstree.generate( _selector );
 				const [ a, b, c ] = getSpecificityArray( selectorName );
 				const sum = 100 * a + 10 * b + c; // eslint-disable-line no-mixed-operators
 				selectors.push( {

package/bin/auditor/src/formats/html.js

@@ -1,6 +1,6 @@
-const fs = require( 'fs-extra' );
+const fs = require( 'node:fs' );
 const path = require( 'path' );
-const { TwingEnvironment, TwingLoaderFilesystem } = require( 'twing' );
+const Twig = require( 'twig' );
 
 /**
  * Internal dependencies
@@ -23,9 +23,6 @@ function getTemplateFile( name ) {
 }
 
 module.exports = function ( reports ) {
-	const loader = new TwingLoaderFilesystem( templatePath );
-	const twing = new TwingEnvironment( loader, { debug: true } );
-
 	const reportName = getArg( '--filename' );
 	const reportTemplate = getTemplateFile( reportName );
 	const reportDestDir = path.join( __dirname, '..', '..', 'public' );
@@ -38,15 +35,18 @@ module.exports = function ( reports ) {
 	// Copy CSS src to /public
 	const cssSrc = path.join( __dirname, 'html', 'style.css' );
 	const cssDest = path.join( reportDestDir, 'style.css' );
-	fs.copyFile( cssSrc, cssDest );
+	fs.copyFileSync( cssSrc, cssDest );
 
-	twing
-		.render( reportTemplate, context )
-		.then( ( output ) => {
-			console.log( `Generated template for ${ reportName }.` );
-			fs.writeFileSync( reportDest, output );
-		} )
-		.catch( ( e ) => {
-			console.error( e );
-		} );
+	Twig.renderFile(
+		path.resolve( __dirname, 'html', reportTemplate ),
+		context,
+		( error, output ) => {
+			if ( error ) {
+				console.error( e );
+			} else {
+				console.log( `Generated template for ${ reportName }.` );
+				fs.writeFileSync( reportDest, output );
+			}
+		}
+	);
 };

package/bin/auditor/src/utils/__tests__/get-specificity.js

@@ -14,6 +14,8 @@ describe( 'Calculate Specificity', () => {
 	it( 'should calculate for pseudo-classes', () => {
 		expect( getSpecificity( ':checked' ) ).toBe( 10 );
 		expect( getSpecificity( 'a:link' ) ).toBe( 11 );
+		expect( getSpecificity( 'body:lang(en)' ) ).toBe( 11 );
+		expect( getSpecificity( 'body:lang(en,ja)' ) ).toBe( 11 );
 	} );
 
 	it( 'should calculate for class selectors', () => {
@@ -36,4 +38,25 @@ describe( 'Calculate Specificity', () => {
 			getSpecificity( 'li > a[href*="en-US"] > .inline-warning' )
 		).toBe( 22 );
 	} );
+
+	it( 'should calculate for :is selectors', () => {
+		expect( getSpecificity( ':is(h1)' ) ).toBe( 1 );
+		expect( getSpecificity( ':is(h1, .class)' ) ).toBe( 10 );
+		expect( getSpecificity( ':is(h1, .class, #id)' ) ).toBe( 100 );
+		expect( getSpecificity( 'span:is(h1)' ) ).toBe( 2 );
+	} );
+
+	it( 'should calculate for :where selectors', () => {
+		expect( getSpecificity( ':where(h1)' ) ).toBe( 0 );
+		expect( getSpecificity( ':where(h1, .class)' ) ).toBe( 0 );
+		expect( getSpecificity( ':where(h1, .class, #id)' ) ).toBe( 0 );
+		expect( getSpecificity( 'span:where(h1)' ) ).toBe( 1 );
+	} );
+
+	it( 'should calculate for :not selectors', () => {
+		expect( getSpecificity( ':not(h1)' ) ).toBe( 1 );
+		expect( getSpecificity( ':not(h1, .class)' ) ).toBe( 10 );
+		expect( getSpecificity( ':not(h1, .class, #id)' ) ).toBe( 100 );
+		expect( getSpecificity( 'span:not(h1)' ) ).toBe( 2 );
+	} );
 } );

package/bin/auditor/src/utils/get-specificity.js

@@ -14,10 +14,28 @@ function calculateSpecificity( [ a, b, c ], selector ) {
 	if ( ! selector.type ) {
 		return;
 	}
-	if ( 'lang' !== selector.name && selector.children ) {
-		return selector.children
-			.toArray()
-			.reduce( calculateSpecificity, [ a, b, c ] );
+
+	if ( 'PseudoClassSelector' === selector.type && 'lang' !== selector.name ) {
+		if ( 'where' === selector.name ) {
+			return [ a, b, c ];
+		}
+		if ( selector.children ) {
+			let maxSpec = [ 0, 0, 0 ];
+			let max = -1;
+			selector.children.forEach( ( list ) => {
+				if ( 'SelectorList' === list.type ) {
+					list.children.forEach( ( s ) => {
+						const _selector = csstree.generate( s );
+						const result = getSpecificity( _selector );
+						if ( result > max ) {
+							maxSpec = getSpecificityArray( _selector );
+							max = result;
+						}
+					} );
+				}
+			} );
+			return [ a + maxSpec[ 0 ], b + maxSpec[ 1 ], c + maxSpec[ 2 ] ];
+		}
 	}
 
 	switch ( selector.type ) {
@@ -65,11 +83,10 @@ function calculateSpecificity( [ a, b, c ], selector ) {
 function getSpecificity( selector ) {
 	const node = csstree.parse( selector, { context: 'selector' } );
 	const selectorList = node.children.toArray();
-	const [ a, b, c ] = selectorList.reduce( calculateSpecificity, [
-		0,
-		0,
-		0,
-	] );
+	const [ a, b, c ] = selectorList.reduce(
+		calculateSpecificity,
+		[ 0, 0, 0 ]
+	);
 	return 100 * a + 10 * b + c;
 }
 
@@ -82,11 +99,10 @@ function getSpecificity( selector ) {
 function getSpecificityArray( selector ) {
 	const node = csstree.parse( selector, { context: 'selector' } );
 	const selectorList = node.children.toArray();
-	const [ a, b, c ] = selectorList.reduce( calculateSpecificity, [
-		0,
-		0,
-		0,
-	] );
+	const [ a, b, c ] = selectorList.reduce(
+		calculateSpecificity,
+		[ 0, 0, 0 ]
+	);
 	return [ a, b, c ];
 }
 

package/index.js

@@ -24,14 +24,14 @@ const currentPath = path.dirname(fileURLToPath(import.meta.url));
 
 // CSS Audit Plugin
 class CSSAuditPlugin {
-    config = {}
+    config = {};
 
     constructor(opts = {}) {
-
-     // if no outputFolder is defined fallback to the default path
-     if( ! opts.outputFolder ){
-        opts.outputFolder = path.join(currentPath, 'bin', 'auditor', 'public')
-      // path must be absolute
+     
+      // if no outputFolder is defined fallback to the default path
+      if( ! opts.outputFolder ){
+        opts.outputFolder = path.join(process.cwd(), 'audits' )
+      // if outputfolder is set and not absolute
       }else if( ! path.isAbsolute(opts.outputFolder) ){
         opts.outputFolder = path.join(process.cwd(), opts.outputFolder );
       }
@@ -44,21 +44,15 @@ class CSSAuditPlugin {
         directory: this.config.outputFolder,
         watch: true
       }
-      let { devServer, output } = compiler.options;
-      let hostUrl = 'localhost' === devServer.host ? `http://${devServer.host}`: devServer.host;
-      let hostPort = devServer.port;
-
-      if( hostPort && 80 !== hostPort )
-      {
-          hostUrl = `${hostUrl}:${hostPort}`;
-      }
+      let { devServer } = compiler.options;
+      let auditUrl = `${devServer.server}://${devServer.host}:${devServer.port}`;
       
       // if dev server allows for multiple pages to be opened
       // add css-audit.html to open property.
       if( Array.isArray(devServer.open) ){
-        devServer.open.push(`${hostUrl}/${this.config.rewrite ? this.config.rewrite : this.config.filename}.html`)
+        devServer.open.push(`${auditUrl}/${this.config.filename}.html`)
       }else if( 'object' === typeof devServer.open && Array.isArray(devServer.open.target) ){
-        devServer.open.target.push(`${hostUrl}/${this.config.filename}.html`)
+        devServer.open.target.push(`${auditUrl}/${this.config.filename}.html`)
       }
 
       // add our static directory 
@@ -146,7 +140,7 @@ class CSSAuditPlugin {
               )
             }
             
-            console.log(`<i> ${boldGreen('[webpack-dev-middleware] CSS Audit can be viewed at')} ${ boldBlue(new URL(`${hostUrl}/${this.config.filename}.html`).toString())  }`);
+            console.log(`<i> ${boldGreen('[webpack-dev-middleware] CSS Audit can be viewed at')} ${ boldBlue(new URL(`${auditUrl}/${this.config.filename}.html`).toString())  }`);
 
             callback();
           }
@@ -156,6 +150,9 @@ class CSSAuditPlugin {
       
     }
 
+    
+
+
     /**
      * Run WordPress CSS Audit
      * 
@@ -191,10 +188,10 @@ class CSSAuditPlugin {
 
       let filesToBeAudited = [];
       let filesWithIssues = [];
- 
+      
       // the css audit tool always outputs to its own public directory
       let defaultOutputPath = path.join(currentPath, 'bin', 'auditor', 'public');
-      
+
       // we always make sure the output folder exists
       fs.mkdirSync( outputFolder, { recursive: true } );
 
@@ -258,7 +255,7 @@ class CSSAuditPlugin {
         important && ! processArgs.includes('--no-important') ? '--important' : '',
         displayNone && ! processArgs.includes('--no-display-none') ? '--display-none' : '',
         selectors && ! processArgs.includes('--no-selectors') ? '--selectors' : '',
-        mediaQueries && ! processArgs.includes('--no-media-queries') ? '--media-queries' : '',
+        // mediaQueries && ! processArgs.includes('--no-media-queries') ? '--media-queries' : '',
         typography && ! processArgs.includes('--no-typography') ? '--typography' : '',
         format  ? `--format=${format}` : '',
         filename ? `--filename=${path.basename(process.cwd())}` : ''
@@ -269,25 +266,27 @@ class CSSAuditPlugin {
           auditArgs.push(`--property-values=${p.replace(' ',',')}`)
         })
       }
-      
+
       let { stdout, stderr } = spawn.sync( 
-        'node ' + resolveBin('@caweb/css-audit-webpack-plugin', {executable: 'auditor'}),
+        'node',
         [
+          resolveBin('@caweb/css-audit-webpack-plugin', {executable: 'auditor'}),
+          // '--',
           ...filesToBeAudited,
           ...auditArgs
         ],
         {
+          shell: false,
           stdio: 'pipe',
           cwd: fs.existsSync(path.join(process.cwd(), 'css-audit.config.cjs')) ? process.cwd() : currentPath
         }
       )
-
+      
       if( stderr && stderr.toString() ){
         console.log( stderr.toString() )
       }
 
       if( stdout && stdout.toString() ){
-          
 
           // rename the file back to the intended file name instead of the project name
           let outputFile = path.join(outputFolder, `${filename}.html`);
@@ -305,7 +304,7 @@ class CSSAuditPlugin {
             )
           }
 
-          let msg = stdout.toString().replace('undefined', '');
+          let msg = stdout.toString().replace('undefined', '').replace('template', 'css audit');
       
           // the command was ran via cli
           if( 'audit' === process.argv[2] ){

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@caweb/css-audit-webpack-plugin",
-  "version": "1.0.12",
+  "version": "1.1.0",
   "description": "CAWebPublishing Webpack Plugin to run WordPress CSS Audit",
   "type": "module",
   "main": "index.js",
@@ -40,14 +40,15 @@
     "test": "echo \"Error: run tests from root\" && exit 0"
   },
   "dependencies": {
-    "chalk": "^5.3.0",
-    "cross-spawn": "^7.0.3",
+    "chalk": "^5.4.1",
+    "cross-spawn": "^7.0.6",
     "deepmerge": "^4.3.1",
     "get-all-files": "^5.0.0",
-    "resolve-bin": "^1.0.1"
+    "resolve-bin": "^1.0.1",
+    "twig": "^1.17.1"
   },
   "devDependencies": {
-    "webpack": "^5.96.1",
-    "webpack-cli": "^5.1.4"
+    "webpack": "^5.99.9",
+    "webpack-cli": "^6.0.1"
   }
 }