@caupulican/pi-adaptative 0.81.42 → 0.81.43

package/dist/modes/interactive/profile-menu-controller.js

@@ -17,12 +17,22 @@ import { resourceProfileSettingsChangedKinds } from "../../core/resource-profile
 import { validateSkillName } from "../../core/skills.js";
 import { allToolNames } from "../../core/tools/index.js";
 import { parseFrontmatter } from "../../utils/frontmatter.js";
-import { ExtensionInputComponent } from "./components/extension-input.js";
 import { ProfileResourceEditorComponent, resolveResourceEditPath, } from "./components/profile-resource-editor.js";
 import { ProfileSelectorComponent } from "./components/profile-selector.js";
 import { SelectSubmenu } from "./components/settings-selector.js";
 import { captureProfileFiles, restoreProfileFiles } from "./config-backup.js";
+import { confirmExternalResourceTrust, promptForTextInput } from "./interactive-selection-prompts.js";
 import { getAvailableThemesWithPaths } from "./theme/theme.js";
+const PROFILE_SCOPE_OPTIONS = [
+    { value: "session", label: "session", description: "Runtime only (not written to disk)" },
+    {
+        value: "directory",
+        label: "directory",
+        description: "~/.pi/agent/profiles/directories/<hash>/settings.json",
+    },
+    { value: "project", label: "project", description: ".pi/settings.json" },
+    { value: "global", label: "global", description: "~/.pi/agent/settings.json" },
+];
 export const NO_ACTIVE_PROFILE_DESCRIPTION = "Baseline resources; inline SDK extensions load, discovered extensions stay withheld";
 function deletionScopeForProfile(profile) {
     switch (profile.source) {
@@ -45,6 +55,13 @@ function deletionScopeForProfile(profile) {
             return undefined;
     }
 }
+function profileSelectionItems(profiles) {
+    return profiles.map((profile) => ({
+        value: profile.name,
+        label: profile.name,
+        description: profile.description || profile.source,
+    }));
+}
 function portableBasename(filePath) {
     return filePath.split(/[\\/]/).filter(Boolean).pop() ?? filePath;
 }
@@ -59,7 +76,6 @@ export function getProfileExtensionDisplayLabel(filePath, description) {
     return portableBasename(parentPath) || fileName;
 }
 export class ProfileMenuController {
-    deps;
     constructor(deps) {
         this.deps = deps;
     }
@@ -102,11 +118,7 @@ export class ProfileMenuController {
         const activeNames = this.settingsManager.getActiveResourceProfileNames();
         const options = [
             { value: "(none)", label: "(none)", description: NO_ACTIVE_PROFILE_DESCRIPTION },
-            ...profiles.map((p) => ({
-                value: p.name,
-                label: p.name,
-                description: p.description || p.source,
-            })),
+            ...profileSelectionItems(profiles),
         ];
         this.ui.showSelector((done) => {
             const selector = new SelectSubmenu("Profile / Situation", "Select the active runtime profile/situation for this session. This is session-only unless saved elsewhere.", options, activeNames[0] || "(none)", (value) => {
@@ -124,11 +136,7 @@ export class ProfileMenuController {
     async openManageProfilesFlow() {
         const registry = this.settingsManager.getProfileRegistry();
         const profiles = registry.listProfiles();
-        const editableProfiles = profiles.map((p) => ({
-            value: p.name,
-            label: p.name,
-            description: p.description || p.source,
-        }));
+        const editableProfiles = profileSelectionItems(profiles);
         const options = [
             {
                 value: "create",
@@ -232,18 +240,8 @@ export class ProfileMenuController {
         await this.saveProfileResources({ ...profile, model }, profile.resources, profile.resources, scope, this.settingsManager.getActiveResourceProfileNames().includes(profile.name), true);
     }
     async openPersistProfileSelector() {
-        const scopeOptions = [
-            { value: "session", label: "session", description: "Runtime only (not written to disk)" },
-            {
-                value: "directory",
-                label: "directory",
-                description: "~/.pi/agent/profiles/directories/<hash>/settings.json",
-            },
-            { value: "project", label: "project", description: ".pi/settings.json" },
-            { value: "global", label: "global", description: "~/.pi/agent/settings.json" },
-        ];
         this.ui.showSelector((done) => {
-            const selector = new SelectSubmenu("Persist Active Profile / Situation", "Choose where to write the active profile/situation selection.", scopeOptions, "directory", (value) => {
+            const selector = new SelectSubmenu("Persist Active Profile / Situation", "Choose where to write the active profile/situation selection.", PROFILE_SCOPE_OPTIONS, "directory", (value) => {
                 done();
                 this.persistActiveProfile(value);
                 void this.ui.showSettingsSelector();
@@ -256,11 +254,7 @@ export class ProfileMenuController {
     }
     async openDeleteProfileSelector() {
         const registry = this.settingsManager.getProfileRegistry();
-        const editableProfiles = registry.listProfiles().map((p) => ({
-            value: p.name,
-            label: p.name,
-            description: p.description || p.source,
-        }));
+        const editableProfiles = profileSelectionItems(registry.listProfiles());
         this.ui.showSelector((done) => {
             const selector = new SelectSubmenu("Delete Profile / Situation", "Pick a profile/situation to delete.", editableProfiles, "", (value) => {
                 done();
@@ -355,18 +349,7 @@ export class ProfileMenuController {
         void this.openLibraryEditorForProfile(profile.name, scope);
     }
     async createProfileAndOpenLibraryFlow() {
-        const name = await new Promise((resolve) => {
-            this.ui.showSelector((done) => {
-                const input = new ExtensionInputComponent("Create Profile / Situation", "Enter profile/situation name", (value) => {
-                    done();
-                    resolve(value);
-                }, () => {
-                    done();
-                    resolve(undefined);
-                }, { tui: this.ui.tui });
-                return { component: input, focus: input, onSuperseded: () => resolve(undefined) };
-            });
-        });
+        const name = await promptForTextInput(this.ui, "Create Profile / Situation", "Enter profile/situation name");
         if (name === undefined) {
             void this.openLibraryManagerFlow();
             return;
@@ -399,11 +382,7 @@ export class ProfileMenuController {
     async selectProfileAndOpenLibraryFlow() {
         const registry = this.settingsManager.getProfileRegistry();
         const profiles = registry.listProfiles();
-        const editableProfiles = profiles.map((p) => ({
-            value: p.name,
-            label: p.name,
-            description: p.description || p.source,
-        }));
+        const editableProfiles = profileSelectionItems(profiles);
         if (editableProfiles.length === 0) {
             this.ui.showWarning("No existing profiles/situations to select. Please create one.");
             void this.createProfileAndOpenLibraryFlow();
@@ -569,6 +548,22 @@ export class ProfileMenuController {
             },
         ];
     }
+    async editProfileResource(id, pathValue, kind, reopen) {
+        const resolvedEditPath = resolveResourceEditPath(id, pathValue, kind);
+        if (!resolvedEditPath) {
+            this.ui.showWarning(`Resource "${id}" of kind "${kind}" has no editable file path.`);
+            reopen();
+            return;
+        }
+        if (!fs.existsSync(resolvedEditPath)) {
+            this.ui.showError(`Resolved path for "${id}" does not exist: ${resolvedEditPath}`);
+            reopen();
+            return;
+        }
+        await this.ui.openEditorForPath(resolvedEditPath);
+        await this.ui.handleReloadCommand();
+        reopen();
+    }
     async openLibraryEditorForProfile(profileName, initialScope) {
         const currentScope = initialScope;
         const registry = this.settingsManager.getProfileRegistry();
@@ -603,20 +598,9 @@ export class ProfileMenuController {
                 },
                 onEdit: async (id, pathValue, kind) => {
                     done();
-                    const resolvedEditPath = resolveResourceEditPath(id, pathValue, kind);
-                    if (!resolvedEditPath) {
-                        this.ui.showWarning(`Resource "${id}" of kind "${kind}" has no editable file path.`);
-                        void this.openLibraryEditorForProfile(profileName, currentScope);
-                        return;
-                    }
-                    if (!fs.existsSync(resolvedEditPath)) {
-                        this.ui.showError(`Resolved path for "${id}" does not exist: ${resolvedEditPath}`);
+                    await this.editProfileResource(id, pathValue, kind, () => {
                         void this.openLibraryEditorForProfile(profileName, currentScope);
-                        return;
-                    }
-                    await this.ui.openEditorForPath(resolvedEditPath);
-                    await this.ui.handleReloadCommand();
-                    void this.openLibraryEditorForProfile(profileName, currentScope);
+                    });
                 },
             });
             return { component: editor, focus: editor };
@@ -672,19 +656,11 @@ export class ProfileMenuController {
             this.ui.showStatus(`Saved profile "${profile.name}" to ${scope}.`);
         }
         catch (error) {
-            const rollbackError = stagedRuntimeApplied
-                ? await this.rollbackValidatedProfileMutation(settingsSnapshot, {
-                    profileName: profile.name,
-                    scope,
-                    profileFilesSnapshot,
-                })
-                : undefined;
-            if (!stagedRuntimeApplied)
-                this.settingsManager.restoreReloadSnapshot(settingsSnapshot);
-            const message = error instanceof Error ? error.message : String(error);
-            this.ui.showError(rollbackError
-                ? `${message}; rollback failed: ${rollbackError instanceof Error ? rollbackError.message : String(rollbackError)}`
-                : message);
+            await this.reportProfileMutationFailure(error, settingsSnapshot, stagedRuntimeApplied, {
+                profileName: profile.name,
+                scope,
+                profileFilesSnapshot,
+            });
         }
     }
     async rollbackValidatedProfileMutation(settingsSnapshot, definition) {
@@ -720,19 +696,21 @@ export class ProfileMenuController {
         }
         return errors.length > 0 ? new Error(errors.join("; ")) : undefined;
     }
+    async reportProfileMutationFailure(error, settingsSnapshot, runtimeWasApplied, definition, restoreAdditional) {
+        const rollbackError = runtimeWasApplied
+            ? await this.rollbackValidatedProfileMutation(settingsSnapshot, definition)
+            : undefined;
+        if (!runtimeWasApplied)
+            this.settingsManager.restoreReloadSnapshot(settingsSnapshot);
+        restoreAdditional?.();
+        const message = error instanceof Error ? error.message : String(error);
+        this.ui.showError(rollbackError
+            ? `${message}; rollback failed: ${rollbackError instanceof Error ? rollbackError.message : String(rollbackError)}`
+            : message);
+    }
     async promptScopeChangeForProfile(profileName, currentScope) {
-        const scopeOptions = [
-            { value: "session", label: "session", description: "Runtime only (not written to disk)" },
-            {
-                value: "directory",
-                label: "directory",
-                description: "~/.pi/agent/profiles/directories/<hash>/settings.json",
-            },
-            { value: "project", label: "project", description: ".pi/settings.json" },
-            { value: "global", label: "global", description: "~/.pi/agent/settings.json" },
-        ];
         this.ui.showSelector((done) => {
-            const selector = new SelectSubmenu("Change Profile / Situation Scope", `Select new scope for profile/situation "${profileName}".`, scopeOptions, currentScope, (value) => {
+            const selector = new SelectSubmenu("Change Profile / Situation Scope", `Select new scope for profile/situation "${profileName}".`, PROFILE_SCOPE_OPTIONS, currentScope, (value) => {
                 done();
                 void this.openLibraryEditorForProfile(profileName, value);
             }, () => {
@@ -790,15 +768,7 @@ export class ProfileMenuController {
                 this.ui.showStatus(`Profile: ${activeProfileName}`);
             }
             catch (error) {
-                const rollbackError = stagedRuntimeApplied
-                    ? await this.rollbackValidatedProfileMutation(settingsSnapshot)
-                    : undefined;
-                if (!stagedRuntimeApplied)
-                    this.settingsManager.restoreReloadSnapshot(settingsSnapshot);
-                const message = error instanceof Error ? error.message : String(error);
-                this.ui.showError(rollbackError
-                    ? `${message}; rollback failed: ${rollbackError instanceof Error ? rollbackError.message : String(rollbackError)}`
-                    : message);
+                await this.reportProfileMutationFailure(error, settingsSnapshot, stagedRuntimeApplied);
             }
             return;
         }
@@ -856,17 +826,10 @@ export class ProfileMenuController {
             }
         }
         catch (error) {
-            const rollbackError = stagedRuntimeApplied
-                ? await this.rollbackValidatedProfileMutation(settingsSnapshot)
-                : undefined;
-            if (!stagedRuntimeApplied)
-                this.settingsManager.restoreReloadSnapshot(settingsSnapshot);
-            if (modelRegistrySnapshot)
-                this.session.modelRegistry.restoreReloadSnapshot(modelRegistrySnapshot);
-            const message = error instanceof Error ? error.message : String(error);
-            this.ui.showError(rollbackError
-                ? `${message}; rollback failed: ${rollbackError instanceof Error ? rollbackError.message : String(rollbackError)}`
-                : message);
+            await this.reportProfileMutationFailure(error, settingsSnapshot, stagedRuntimeApplied, undefined, () => {
+                if (modelRegistrySnapshot)
+                    this.session.modelRegistry.restoreReloadSnapshot(modelRegistrySnapshot);
+            });
         }
     }
     /** Map where a profile currently lives to the scope we should write it back to. */
@@ -896,18 +859,7 @@ export class ProfileMenuController {
         }
     }
     async createProfileFlow() {
-        const name = await new Promise((resolve) => {
-            this.ui.showSelector((done) => {
-                const input = new ExtensionInputComponent("Create Profile / Situation", "Enter profile/situation name", (value) => {
-                    done();
-                    resolve(value);
-                }, () => {
-                    done();
-                    resolve(undefined);
-                }, { tui: this.ui.tui });
-                return { component: input, focus: input, onSuperseded: () => resolve(undefined) };
-            });
-        });
+        const name = await promptForTextInput(this.ui, "Create Profile / Situation", "Enter profile/situation name");
         if (name === undefined) {
             this.ui.requestRender();
             return;
@@ -1005,20 +957,9 @@ export class ProfileMenuController {
                 },
                 onEdit: async (id, pathValue, kind) => {
                     done();
-                    const resolvedEditPath = resolveResourceEditPath(id, pathValue, kind);
-                    if (!resolvedEditPath) {
-                        this.ui.showWarning(`Resource "${id}" of kind "${kind}" has no editable file path.`);
-                        void this.openNewProfileEditor(profileName, profileModel);
-                        return;
-                    }
-                    if (!fs.existsSync(resolvedEditPath)) {
-                        this.ui.showError(`Resolved path for "${id}" does not exist: ${resolvedEditPath}`);
+                    await this.editProfileResource(id, pathValue, kind, () => {
                         void this.openNewProfileEditor(profileName, profileModel);
-                        return;
-                    }
-                    await this.ui.openEditorForPath(resolvedEditPath);
-                    await this.ui.handleReloadCommand();
-                    void this.openNewProfileEditor(profileName, profileModel);
+                    });
                 },
             });
             return { component: editor, focus: editor };
@@ -1096,34 +1037,15 @@ export class ProfileMenuController {
             this.ui.showStatus(`Deleted profile "${profileName}" from ${scope}.`);
         }
         catch (error) {
-            const rollbackError = switchedToNone
-                ? await this.rollbackValidatedProfileMutation(settingsSnapshot, {
-                    profileName,
-                    scope,
-                    profileFilesSnapshot,
-                })
-                : undefined;
-            if (!switchedToNone)
-                this.settingsManager.restoreReloadSnapshot(settingsSnapshot);
-            const message = error instanceof Error ? error.message : String(error);
-            this.ui.showError(rollbackError
-                ? `${message}; rollback failed: ${rollbackError instanceof Error ? rollbackError.message : String(rollbackError)}`
-                : message);
+            await this.reportProfileMutationFailure(error, settingsSnapshot, switchedToNone, {
+                profileName,
+                scope,
+                profileFilesSnapshot,
+            });
         }
     }
     async addExternalResourceRootFlow() {
-        const rootPath = await new Promise((resolve) => {
-            this.ui.showSelector((done) => {
-                const input = new ExtensionInputComponent("Add External Root", "Enter external root directory path", (value) => {
-                    done();
-                    resolve(value);
-                }, () => {
-                    done();
-                    resolve(undefined);
-                }, { tui: this.ui.tui });
-                return { component: input, focus: input, onSuperseded: () => resolve(undefined) };
-            });
-        });
+        const rootPath = await promptForTextInput(this.ui, "Add External Root", "Enter external root directory path");
         if (rootPath === undefined) {
             this.ui.requestRender();
             return;
@@ -1138,25 +1060,11 @@ export class ProfileMenuController {
             this.ui.showError(`Invalid path: ${trimmed}`);
             return;
         }
-        // Prompt for trust confirmation (Yes/No)
-        const trust = await new Promise((resolve) => {
-            this.ui.showSelector((done) => {
-                const submenu = new SelectSubmenu("Trust external source?", "This directory can load custom extensions that execute arbitrary code on your machine.", [
-                    { value: "yes", label: "Yes", description: "Trust this directory and enable loading resources." },
-                    { value: "no", label: "No", description: "Do not trust this directory. Skip loading resources." },
-                ], "no", (value) => {
-                    done();
-                    resolve(value === "yes");
-                }, () => {
-                    done();
-                    resolve(false);
-                });
-                return {
-                    component: submenu,
-                    focus: submenu.getSelectList(),
-                    onSuperseded: () => resolve(false),
-                };
-            });
+        const trust = await confirmExternalResourceTrust(this.ui, {
+            title: "Trust external source?",
+            description: "This directory can load custom extensions that execute arbitrary code on your machine.",
+            acceptDescription: "Trust this directory and enable loading resources.",
+            rejectDescription: "Do not trust this directory. Skip loading resources.",
         });
         if (!trust) {
             this.ui.showStatus("Aborted. External root was not trusted.");