@caupulican/pi-adaptative 0.81.12 → 0.81.15

package/dist/core/agent-session.js

@@ -59,6 +59,7 @@ const RAW_STREAM_MARKER = Symbol.for("pi.rawStreamSimple");
 const MODEL_ADAPTATION_REPAIR_THRESHOLD = 3;
 const TEXT_TOOL_PROTOCOL_VERSION = 1;
 const TEXT_TOOL_PROTOCOL_TRIALS_PER_VARIANT = 2;
+const TEXT_TOOL_PROTOCOL_PARSE_FAILURE_THRESHOLD = 3;
 const TEXT_TOOL_PROTOCOL_VARIANTS = ["tool-tag", "tool-call", "fenced-json"];
 const TEXT_TOOL_PROTOCOL_ECHO_TOOL = {
     name: "echo",
@@ -148,6 +149,9 @@ export class AgentSession {
     _localRuntimeController;
     _modelAdaptationStore;
     _repairModeSessionCounts = new Map();
+    _textProtocolParseFailures = new Map();
+    _textProtocolParseObservedThisTurn = false;
+    _textProtocolValidationOutcomeThisTurn;
     /** Assembles the session's base system prompt from live session state (see
      * system-prompt-builder.ts); owns the paired _baseSystemPromptOptions. */
     _systemPromptBuilder;
@@ -258,6 +262,7 @@ export class AgentSession {
         this._cwd = config.cwd;
         this._agentDir = config.agentDir ?? getAgentDir();
         this._modelAdaptationStore = ModelAdaptationStore.forAgentDir(this._agentDir);
+        this.agent.onTextToolProtocolParse = (event) => this._handleTextToolProtocolParse(event);
         this._applyToolRepairLayerSettings();
         this._collectWorkspaceSources = config.collectWorkspaceSources ?? collectWorkspaceSources;
         this._localRuntimeController = new LocalRuntimeController({
@@ -503,6 +508,7 @@ export class AgentSession {
             previousToolArgumentValidation?.(taggedEvent);
             this._analytics.recordToolArgumentValidation(taggedEvent);
             this._recordToolValidationBounce(taggedEvent);
+            this._handleTextToolProtocolValidationOutcome(taggedEvent);
             this._handleModelAdaptationTelemetry(taggedEvent);
         };
         this._treeNavigator = new SessionTreeNavigator({
@@ -801,8 +807,31 @@ export class AgentSession {
         return modelKey ? this._modelAdaptationStore.get(modelKey).rules : [];
     }
     _textProtocolFlag(model) {
+        // Phase 7 gating hierarchy: PI_TEXT_TOOL_CALL_PROTOCOL_DISABLED is resolved
+        // in _toolRepairSettings() as the env kill switch, then settings.toolRepair.textProtocol
+        // force-enables/disables globally, then Model.textToolCallProtocol opts in per model,
+        // then a persisted /toolprobe text-protocol verdict opts in that exact model. The
+        // calibration store is consulted after this flag; native provider tool calls still
+        // win when emitted, and this only enables the text-protocol fallback lane.
         const override = this._toolRepairSettings().textProtocol;
-        return override ?? model?.textToolCallProtocol === true;
+        if (override !== undefined)
+            return override;
+        if (model?.textToolCallProtocol === true)
+            return true;
+        const modelKey = this._modelAdaptationKeyFor(model);
+        return !!modelKey && this._modelAdaptationStore.get(modelKey).toolProbe?.status === "text-protocol";
+    }
+    async _streamForToolProbe(model, context, options) {
+        let requestOptions = options;
+        if (this._isRawStreamSimple(this.agent.streamFn)) {
+            const auth = await this._getRequiredRequestAuth(model);
+            requestOptions = {
+                ...options,
+                apiKey: auth.apiKey,
+                headers: auth.headers || options.headers ? { ...auth.headers, ...options.headers } : undefined,
+            };
+        }
+        return this.agent.streamFn(model, context, requestOptions);
     }
     _textProtocolCalibrationContext(variant, token) {
         const primer = generateTextToolProtocolPrimer([TEXT_TOOL_PROTOCOL_ECHO_TOOL], { variant });
@@ -810,18 +839,29 @@ export class AgentSession {
         return {
             systemPrompt: `${primer}\n\n${instruction}`,
             messages: [{ role: "user", content: [{ type: "text", text: instruction }], timestamp: Date.now() }],
-            tools: [TEXT_TOOL_PROTOCOL_ECHO_TOOL],
         };
     }
+    _messageHasEchoProbe(message, token) {
+        return message.content.some((block) => block.type === "toolCall" && block.name === "echo" && block.arguments.data === token);
+    }
+    async _runNativeToolProbeTrial(model, token) {
+        const instruction = `Native tool-call capability probe. Use provider-native tool calling, not prose. ` +
+            `Call echo with data exactly "${token}".`;
+        const stream = await this._streamForToolProbe(model, {
+            systemPrompt: instruction,
+            messages: [{ role: "user", content: [{ type: "text", text: instruction }], timestamp: Date.now() }],
+            tools: [TEXT_TOOL_PROTOCOL_ECHO_TOOL],
+        }, { textToolCallProtocol: false, maxRetries: 0, temperature: 0, maxTokens: 256 });
+        return this._messageHasEchoProbe(await stream.result(), token);
+    }
     async _runTextProtocolTrial(model, variant, token) {
-        const stream = await this.agent.streamFn(model, this._textProtocolCalibrationContext(variant, token), {
+        const stream = await this._streamForToolProbe(model, this._textProtocolCalibrationContext(variant, token), {
             textToolCallProtocol: false,
             maxRetries: 0,
+            temperature: 0,
+            maxTokens: 256,
         });
         const message = await stream.result();
-        if (message.content.some((block) => block.type === "toolCall" && block.name === "echo" && block.arguments.data === token)) {
-            return true;
-        }
         const text = message.content
             .filter((block) => block.type === "text")
             .map((block) => block.text)
@@ -832,6 +872,32 @@ export class AgentSession {
         const parsed = parseTextToolCalls(text, [TEXT_TOOL_PROTOCOL_ECHO_TOOL]);
         return parsed.calls.some((call) => call.name === "echo" && call.arguments.data === token);
     }
+    async _calibrateTextToolProtocolForModel(model, modelKey, options) {
+        const variantsTried = [];
+        for (const variant of TEXT_TOOL_PROTOCOL_VARIANTS) {
+            variantsTried.push(variant);
+            let passed = true;
+            for (let trial = 0; trial < TEXT_TOOL_PROTOCOL_TRIALS_PER_VARIANT; trial++) {
+                const ok = await this._runTextProtocolTrial(model, variant, `pi-calibration-${trial + 1}`);
+                if (!ok) {
+                    passed = false;
+                    break;
+                }
+            }
+            if (passed) {
+                const calibratedAt = new Date().toISOString();
+                if (modelKey) {
+                    this._modelAdaptationStore.setProtocol(modelKey, { version: TEXT_TOOL_PROTOCOL_VERSION, status: "calibrated", variant, calibratedAt }, calibratedAt);
+                }
+                return { status: "calibrated", variant, calibratedAt };
+            }
+        }
+        const attemptedAt = new Date().toISOString();
+        if (modelKey && options.persistFailure) {
+            this._modelAdaptationStore.setProtocol(modelKey, { version: TEXT_TOOL_PROTOCOL_VERSION, status: "failed", attemptedAt, variantsTried }, attemptedAt);
+        }
+        return { status: "failed", attemptedAt, variantsTried };
+    }
     async _ensureTextToolProtocolForActiveModel() {
         const model = this.agent.state.model;
         if (!this._textProtocolFlag(model)) {
@@ -845,27 +911,182 @@ export class AgentSession {
         }
         const profile = this._modelAdaptationStore.get(modelKey);
         if (profile.protocol?.version === TEXT_TOOL_PROTOCOL_VERSION) {
+            if (profile.protocol.status === "failed") {
+                this.agent.textToolCallProtocol = undefined;
+                throw new Error(`Previous text tool protocol calibration failed for ${modelKey} at ${profile.protocol.attemptedAt}. ` +
+                    `Variants tried: ${profile.protocol.variantsTried.join(", ")}. ` +
+                    `Run /toolhealth for details or /toolprotocol-reset ${modelKey} to retry calibration.`);
+            }
             this.agent.textToolCallProtocol = { variant: profile.protocol.variant };
             return;
         }
-        for (const variant of TEXT_TOOL_PROTOCOL_VARIANTS) {
-            let passed = true;
-            for (let trial = 0; trial < TEXT_TOOL_PROTOCOL_TRIALS_PER_VARIANT; trial++) {
-                const ok = await this._runTextProtocolTrial(model, variant, `pi-calibration-${trial + 1}`);
-                if (!ok) {
-                    passed = false;
-                    break;
-                }
+        const result = await this._calibrateTextToolProtocolForModel(model, modelKey, { persistFailure: true });
+        if (result.status === "calibrated") {
+            this.agent.textToolCallProtocol = { variant: result.variant };
+            return;
+        }
+        this.agent.textToolCallProtocol = undefined;
+        throw new Error(`Model ${modelKey} cannot follow the text tool protocol after calibration. ` +
+            `Run /toolhealth for details or /toolprotocol-reset ${modelKey} to retry calibration.`);
+    }
+    _modelRef(model) {
+        return `${model.provider}/${model.id}`;
+    }
+    _formatToolProbeReport(results) {
+        const lines = ["Tool probe results:", "Model | Verdict | Variant | Diagnostic", "--- | --- | --- | ---"];
+        for (const result of results) {
+            lines.push([
+                result.model,
+                result.verdict,
+                result.variant ?? "-",
+                result.diagnostic ? result.diagnostic.replace(/\s+/g, " ").slice(0, 160) : "-",
+            ].join(" | "));
+        }
+        return lines.join("\n");
+    }
+    _storeToolProbe(modelKey, probe) {
+        this._modelAdaptationStore.setToolProbe(modelKey, probe, probe.probedAt);
+    }
+    async _probeToolCallingForModel(model) {
+        const modelKey = this._modelRef(model);
+        const probedAt = new Date().toISOString();
+        let diagnostic;
+        try {
+            if (await this._runNativeToolProbeTrial(model, "pi-native-probe")) {
+                this._storeToolProbe(modelKey, { version: TEXT_TOOL_PROTOCOL_VERSION, status: "native", probedAt });
+                return { model: modelKey, verdict: "native" };
             }
-            if (passed) {
-                const calibratedAt = new Date().toISOString();
-                this._modelAdaptationStore.setProtocol(modelKey, { version: TEXT_TOOL_PROTOCOL_VERSION, variant, calibratedAt }, calibratedAt);
-                this.agent.textToolCallProtocol = { variant };
-                return;
+        }
+        catch (error) {
+            diagnostic = error instanceof Error ? error.message : String(error);
+        }
+        try {
+            const calibrated = await this._calibrateTextToolProtocolForModel(model, modelKey, { persistFailure: false });
+            if (calibrated.status === "calibrated") {
+                this._storeToolProbe(modelKey, {
+                    version: TEXT_TOOL_PROTOCOL_VERSION,
+                    status: "text-protocol",
+                    probedAt: calibrated.calibratedAt,
+                    variant: calibrated.variant,
+                });
+                return { model: modelKey, verdict: "text-protocol", variant: calibrated.variant };
             }
+            diagnostic ??= `Text protocol variants failed: ${calibrated.variantsTried.join(", ")}`;
         }
-        this.agent.textToolCallProtocol = undefined;
-        throw new Error(`Model ${modelKey} cannot follow the text tool protocol after calibration.`);
+        catch (error) {
+            diagnostic = error instanceof Error ? error.message : String(error);
+        }
+        this._storeToolProbe(modelKey, { version: TEXT_TOOL_PROTOCOL_VERSION, status: "none", probedAt, diagnostic });
+        return { model: modelKey, verdict: "none", diagnostic };
+    }
+    async _resolveToolProbeModels(target) {
+        const trimmed = target?.trim();
+        if (!trimmed)
+            return this._modelRegistry.getAvailable();
+        const [provider, ...modelParts] = trimmed.split("/");
+        const modelId = modelParts.join("/");
+        if (!provider || !modelId)
+            throw new Error("Usage: /toolprobe [provider/model]");
+        const exact = this._modelRegistry.find(provider, modelId);
+        if (exact)
+            return [exact];
+        const current = this.agent.state.model;
+        if (current?.provider === provider && current.id === modelId)
+            return [current];
+        throw new Error(`Model not found: ${trimmed}`);
+    }
+    async probeToolCalling(target) {
+        const models = await this._resolveToolProbeModels(target);
+        if (models.length === 0)
+            throw new Error("No available models to probe.");
+        const results = [];
+        for (const model of models) {
+            results.push(await this._probeToolCallingForModel(model));
+        }
+        return { results, table: this._formatToolProbeReport(results) };
+    }
+    _handleTextToolProtocolParse(event) {
+        this._textProtocolParseObservedThisTurn = true;
+        const modelKey = `${event.provider}/${event.model}`;
+        if (event.status === "parsed")
+            return;
+        const signature = `${event.variant}:${event.reason ?? "failed"}`;
+        const previous = this._textProtocolParseFailures.get(modelKey);
+        const repeats = previous?.signature === signature ? previous.repeats + 1 : 1;
+        this._textProtocolParseFailures.set(modelKey, { signature, repeats });
+        if (repeats < TEXT_TOOL_PROTOCOL_PARSE_FAILURE_THRESHOLD)
+            return;
+        const profile = this._modelAdaptationStore.get(modelKey);
+        if (profile.protocol?.version === TEXT_TOOL_PROTOCOL_VERSION && profile.protocol.status !== "failed") {
+            this._modelAdaptationStore.removeProtocol(modelKey);
+            this.agent.textToolCallProtocol = undefined;
+        }
+        this._textProtocolParseFailures.delete(modelKey);
+    }
+    _handleTextToolProtocolValidationOutcome(event) {
+        if (event.source !== "text-protocol")
+            return;
+        const protocol = this.agent.textToolCallProtocol;
+        const variant = protocol === true ? "tool-tag" : protocol ? protocol.variant : undefined;
+        if (!variant)
+            return;
+        const status = event.outcome === "bounced" ? "failed" : "parsed";
+        if (this._textProtocolValidationOutcomeThisTurn?.status === "parsed" && status === "failed")
+            return;
+        this._textProtocolValidationOutcomeThisTurn = {
+            provider: event.provider ?? this.agent.state.model.provider,
+            model: event.model ?? this.agent.state.model.id,
+            variant,
+            status,
+            callCount: 1,
+            textLength: 0,
+            ...(status === "failed" && {
+                reason: event.errorKeywords?.includes("unknown_tool") ? "unknown-tool" : "validation-failed",
+            }),
+        };
+    }
+    _recordTextToolProtocolParseOutcomeFromLastAssistant() {
+        const validationOutcome = this._textProtocolValidationOutcomeThisTurn;
+        this._textProtocolValidationOutcomeThisTurn = undefined;
+        if (validationOutcome?.status === "parsed") {
+            this._textProtocolParseObservedThisTurn = true;
+            this._textProtocolParseFailures.delete(`${validationOutcome.provider}/${validationOutcome.model}`);
+            return;
+        }
+        if (validationOutcome) {
+            this._handleTextToolProtocolParse(validationOutcome);
+            return;
+        }
+        if (this._textProtocolParseObservedThisTurn)
+            return;
+        const protocol = this.agent.textToolCallProtocol;
+        if (protocol === false || protocol === true || !protocol?.variant)
+            return;
+        const response = this._findLastAssistantMessage();
+        if (!response)
+            return;
+        const responseText = response.content
+            .filter((content) => content.type === "text")
+            .map((content) => content.text)
+            .join("\n");
+        if (!responseText)
+            return;
+        const parsed = parseTextToolCalls(responseText, this.agent.state.tools);
+        const attempted = parsed.attempted || this._looksLikeTextToolProtocolAttempt(responseText);
+        if (!attempted)
+            return;
+        this._handleTextToolProtocolParse({
+            provider: this.agent.state.model.provider,
+            model: this.agent.state.model.id,
+            variant: protocol.variant,
+            status: parsed.calls.length > 0 ? "parsed" : "failed",
+            reason: parsed.failure,
+            callCount: parsed.calls.length,
+            textLength: responseText.length,
+        });
+    }
+    _looksLikeTextToolProtocolAttempt(text) {
+        return /<pi:call\b|<tool_call\b|```(?:tool|tool_call)[\s\S]*"name"\s*:/i.test(text);
     }
     _recordToolValidationBounce(event) {
         if (event.outcome !== "bounced" || !event.failureShape || event.failureShape.length === 0)
@@ -1091,6 +1312,11 @@ export class AgentSession {
     removeToolRepairRule(model, mode) {
         return this._modelAdaptationStore.removeRule(model, mode);
     }
+    resetToolProtocolCalibration(model) {
+        const removed = this._modelAdaptationStore.removeProtocol(model);
+        this._textProtocolParseFailures.delete(model);
+        return removed;
+    }
     /** Curation status for diagnostics/dashboard: settings, live telemetry, last refusal reason. */
     /** Curation status for diagnostics/dashboard (delegates to {@link ContextPipeline.getContextCurationStatus}). */
     getContextCurationStatus() {
@@ -1986,7 +2212,10 @@ export class AgentSession {
             return;
         }
         preflightResult?.(true);
+        this._textProtocolParseObservedThisTurn = false;
+        this._textProtocolValidationOutcomeThisTurn = undefined;
         await this._modelRouter.runRoutedTurn(messages, routedTurnModel, routedTurnRouteDecision);
+        this._recordTextToolProtocolParseOutcomeFromLastAssistant();
         // R4: score whether the agent actually used the recalled context, so the recall gate can adapt.
         if (injectedRecall) {
             const response = this._findLastAssistantMessage();