@catladder/pipeline 0.0.0-next-6ea918c7 → 0.0.0-next-e3ccf7d4

package/dist/backends/github/createGithubJobs.js

@@ -283,6 +283,37 @@ var makeGithubJob = function (context, job, allJobs, uploadProviderIds, images,
   }))), isComponent ? getSecretsEnv(context, secretKinds) : {}), getReferencedSecretsEnv(runScript, secretKinds)), {
     CL_JOB_IMAGE: image !== null && image !== void 0 ? image : "runner"
   });
+  /**
+   * the github environment of the job — serving two purposes:
+   * deployment tracking on deploy jobs, and access to environment
+   * secrets (the repo-level cap of 100 secrets doesn't scale to
+   * multiple envs). Names are keyed by env NAME, never env type: an
+   * app can have several envs of the same type.
+   *
+   * - deploy jobs: `<env>-<component>` — static (unlike the former
+   *   per-PR review names), so environment secrets can attach, and
+   *   each component keeps its own deployment badge/url in the
+   *   github ui. For review, PRs share the component's environment:
+   *   a newer PR's deploy marks the previous one Inactive (the badge,
+   *   not the app) — the price of a static name.
+   * - other jobs referencing secrets join the shared `<env>`
+   *   environment — deliberately NOT the per-component one, whose
+   *   Active deploy badge their deployment records would displace.
+   *   NOTE: build-time and deploy-time vars are not differentiated
+   *   yet, so this environment holds roughly ALL of the env's
+   *   secrets (the build's dotenv references every component).
+   * - jobs without secret references get no environment
+   */
+  var referencesSecrets = Object.values(env).some(function (value) {
+    return typeof value === "string" && (value.includes("${{ secrets.") || value.includes("${{ vars."));
+  });
+  var githubEnvironment = job.environment && isComponent ? __assign({
+    name: "".concat(context.env, "-").concat(context.name)
+  }, createsJobEnv ? {
+    url: "${{ steps.main.outputs.url }}"
+  } : {}) : referencesSecrets ? {
+    name: context.env
+  } : undefined;
   var githubJob = __assign(__assign(__assign(__assign(__assign({
     name: githubJobName(context, job.name),
     "runs-on": "ubuntu-latest"
@@ -301,12 +332,8 @@ var makeGithubJob = function (context, job, allJobs, uploadProviderIds, images,
     } : {})
   } : {}), Object.keys(services).length > 0 ? {
     services: services
-  } : {}), job.environment && isComponent ? {
-    environment: __assign({
-      name: context.environment.envType === "review" ? "review-pr${{ github.event.number }}-".concat(context.name) : "".concat(context.env, "-").concat(context.name)
-    }, createsJobEnv ? {
-      url: "${{ steps.main.outputs.url }}"
-    } : {})
+  } : {}), githubEnvironment ? {
+    environment: githubEnvironment
   } : {}), {
     env: env,
     steps: __spreadArray(__spreadArray(__spreadArray(__spreadArray(__spreadArray([], __read(skipCheckout ? [] : [{

package/dist/constants.js

@@ -4,5 +4,5 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.DOCKER_REGISTRY = exports.PIPELINE_IMAGE_TAG = void 0;
-exports.PIPELINE_IMAGE_TAG = "next-6ea918c7" || "latest";
+exports.PIPELINE_IMAGE_TAG = "next-e3ccf7d4" || "latest";
 exports.DOCKER_REGISTRY = "git.panter.ch:5001/catladder/catladder" || "git.panter.ch:5001/catladder/catladder";