@catladder/cli 5.7.0 → 5.7.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/apps/cli/src/reviewApps/github.js +48 -4
- package/dist/apps/cli/src/reviewApps/github.js.map +1 -1
- package/dist/bundles/catci/index.js +4 -4
- package/dist/bundles/skills/catladder-pipelines/SKILL.md +8 -2
- package/dist/skills/catladder-pipelines/SKILL.md +8 -2
- package/dist/tsconfig.tsbuildinfo +1 -1
- package/package.json +1 -1
- package/src/reviewApps/__tests__/github.test.ts +118 -0
- package/src/reviewApps/github.ts +58 -4
|
@@ -115,11 +115,17 @@ through the `▶️ catladder deploy review` workflow
|
|
|
115
115
|
- when the review workflow is green but didn't deploy, its last job
|
|
116
116
|
(`▶️ trigger review deploy`) reads the PR's labels/draft state again
|
|
117
117
|
and dispatches the deploy if the policy now says so — a label set
|
|
118
|
-
while CI ran counts
|
|
118
|
+
while CI ran counts. The guard trusts that dispatch (the CI is green
|
|
119
|
+
by construction; it only verifies the PR is open and still on that
|
|
120
|
+
head) instead of re-reading the check, which raced the checks api.
|
|
121
|
+
Meanwhile the deploy workflow's guard of the label event defers
|
|
122
|
+
(the CI isn't finished) and sets the commit status
|
|
123
|
+
`catladder review app` to `pending` ("waiting for the CI"), so the PR
|
|
124
|
+
never shows no status;
|
|
119
125
|
- switching the label on (opt-in: add `label`, opt-out: remove
|
|
120
126
|
`skipLabel`) deploys right away if the PR's `catladder ✅` is green;
|
|
121
127
|
switching it off stops the review apps (`🛑 catladder stop review
|
|
122
|
-
|
|
128
|
+
app`), and so does closing the PR — the stop first waits for a
|
|
123
129
|
review run of the PR that may still be deploying (on close it
|
|
124
130
|
cancels it), so a late deploy can't outlive the teardown;
|
|
125
131
|
- on request, any time (agents included):
|
|
@@ -115,11 +115,17 @@ through the `▶️ catladder deploy review` workflow
|
|
|
115
115
|
- when the review workflow is green but didn't deploy, its last job
|
|
116
116
|
(`▶️ trigger review deploy`) reads the PR's labels/draft state again
|
|
117
117
|
and dispatches the deploy if the policy now says so — a label set
|
|
118
|
-
while CI ran counts
|
|
118
|
+
while CI ran counts. The guard trusts that dispatch (the CI is green
|
|
119
|
+
by construction; it only verifies the PR is open and still on that
|
|
120
|
+
head) instead of re-reading the check, which raced the checks api.
|
|
121
|
+
Meanwhile the deploy workflow's guard of the label event defers
|
|
122
|
+
(the CI isn't finished) and sets the commit status
|
|
123
|
+
`catladder review app` to `pending` ("waiting for the CI"), so the PR
|
|
124
|
+
never shows no status;
|
|
119
125
|
- switching the label on (opt-in: add `label`, opt-out: remove
|
|
120
126
|
`skipLabel`) deploys right away if the PR's `catladder ✅` is green;
|
|
121
127
|
switching it off stops the review apps (`🛑 catladder stop review
|
|
122
|
-
|
|
128
|
+
app`), and so does closing the PR — the stop first waits for a
|
|
123
129
|
review run of the PR that may still be deploying (on close it
|
|
124
130
|
cancels it), so a late deploy can't outlive the teardown;
|
|
125
131
|
- on request, any time (agents included):
|