@catladder/cli 1.89.3 → 1.90.0

package/package.json

@@ -24,7 +24,7 @@
     "node": ">=12.0.0"
   },
   "devDependencies": {
-    "@catladder/pipeline": "1.89.3",
+    "@catladder/pipeline": "1.90.0",
     "@kubernetes/client-node": "^0.16.2",
     "@tsconfig/node14": "^1.0.1",
     "@types/common-tags": "^1.8.0",
@@ -57,5 +57,5 @@
     "typescript": "^4.5.4",
     "vorpal": "^1.12.0"
   },
-  "version": "1.89.3"
+  "version": "1.90.0"
 }

package/src/apps/cli/commands/project/commandConfigSecrets.ts

@@ -45,12 +45,22 @@ const resolveJson = (v: Vars) =>
     })
   );
 
+const getNonHiddenSecretEnvVarKeys = async (
+  env: string,
+  componentName: string
+) => {
+  const { secretEnvVarKeys } = await getEnvironment(env, componentName);
+  return secretEnvVarKeys.filter((k) => !k.hidden).map((k) => k.key);
+};
 const getEnvVarsToEdit = async (
   instance: CommandInstance,
   env: string,
   componentName: string
 ) => {
-  const { secretEnvVarKeys } = await getEnvironment(env, componentName);
+  const secretEnvVarKeys = await getNonHiddenSecretEnvVarKeys(
+    env,
+    componentName
+  );
 
   const allEnvVars = await getEnvVars(instance, env, componentName);
   return Object.fromEntries(
@@ -107,7 +117,11 @@ const doItFor = async (
           ? Object.keys(valuesToEdit[componentName][env])
           : [];
         // check whether newValues have the exact number of keys
-        const { secretEnvVarKeys } = await getEnvironment(env, componentName);
+        const secretEnvVarKeys = await getNonHiddenSecretEnvVarKeys(
+          env,
+          componentName
+        );
+
         const extranous = difference(usedKeys, secretEnvVarKeys);
         const missing = difference(secretEnvVarKeys, usedKeys);
 

package/src/apps/cli/verify/migration/migrateSecrets.ts

@@ -30,7 +30,12 @@ export const migrateSecrets = async (
       );
       await upsertAllVariables(
         vorpal,
-        pick(secrets, environment.secretEnvVarKeys),
+        pick(
+          secrets,
+          environment.secretEnvVarKeys
+            .filter((k) => !k.hidden)
+            .map((k) => k.key)
+        ),
         newEnv,
         componentName
       );