@catalyst-cloud/schema 0.1.26 → 0.1.27

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@catalyst-cloud/schema",
-  "version": "0.1.26",
+  "version": "0.1.27",
   "type": "module",
   "description": "Typed Drizzle schema = single source of truth for the per-tenant Mirror DO SQLite store (CTC-13 / ADR-0002). Shared by the mirror Worker, the host-sync replica, and the browser OPFS replica.",
   "license": "MIT",
@@ -31,7 +31,7 @@
   },
   "devDependencies": {
     "@catalyst-cloud/typescript-config": "workspace:*",
-    "@types/node": "^25.9.3",
+    "@types/node": "^26.3.0",
     "drizzle-kit": "^0.31.0",
     "prettier": "^3.9.6",
     "typescript": "^7.0.2",

package/src/migrations.generated.ts

@@ -221,6 +221,20 @@ export const MIRROR_MIGRATIONS = {
         tag: "0029_square_silhouette",
         breakpoints: true,
       },
+      {
+        idx: 30,
+        version: "6",
+        when: 1787972489820,
+        tag: "0030_wandering_bastion",
+        breakpoints: true,
+      },
+      {
+        idx: 31,
+        version: "6",
+        when: 1787972497785,
+        tag: "0031_ctc851_comment_parent_backfill",
+        breakpoints: true,
+      },
     ],
   },
   migrations: {
@@ -281,5 +295,9 @@ export const MIRROR_MIGRATIONS = {
     "0028_burly_nemesis": "ALTER TABLE `check_suites` ADD `pull_request_numbers` text;",
     "0029_square_silhouette":
       "CREATE INDEX `idx_relations_type_related` ON `relations` (`type`,`related_identifier`);",
+    "0030_wandering_bastion":
+      "ALTER TABLE `comments` ADD `parent_type` text;--> statement-breakpoint\nALTER TABLE `comments` ADD `parent_entity_id` text;--> statement-breakpoint\nCREATE INDEX `idx_comments_parent` ON `comments` (`parent_type`,`parent_entity_id`,`removed_at`);",
+    "0031_ctc851_comment_parent_backfill":
+      "-- CTC-851 — backfill comment parents + quarantine the pre-fix empty-issue_id orphans.\n--\n-- 0030 adds the parent_type/parent_entity_id columns and fixes both WRITE legs (webhook normalizer +\n-- reconcile) so new/re-swept comments carry a real parent, but that alone converges only rows the\n-- reconcile re-sweeps — and it walks OPEN issues, so a non-issue comment (or a comment on a closed\n-- issue) keeps its corrupt shape forever. This backfill is what makes the CORPUS canonical rather\n-- than just the new writes.\n--\n-- ⭐ Deliberately a DATA migration in the SHARED bundle (the 0014 pattern): the DO and every host /\n-- OPFS replica apply the same MIRROR_MIGRATIONS through the same runner, so each side repairs its OWN\n-- rows locally. That converges every replica WITHOUT emitting a change_log delta per row (migrations\n-- bypass appendChange), so no ring-buffer flood (the CTC-279 concern).\n--\n-- (a) Healthy rows (a real issue_id) → parent_type='issue', parent_entity_id=issue_id.\n-- (b) Orphans (issue_id empty-string — the measured shape — or NULL, defensively) cannot be repaired\n--     from row data: the replica comments table has no `raw` column and no parent signal beyond the\n--     comment-reply parent_id. A pure in-bundle DML migration cannot call Linear, so it QUARANTINES\n--     them: parent_type='unresolved', issue_id nulled — MARKED with a stated reason, never deleted\n--     (the AC explicitly permits quarantine-with-reason). CTC-851 measured 54 such rows live.\n--\n-- Idempotent by the `parent_type IS NULL` guard: once a row is stamped it is skipped on replay, so a\n-- crash between a statement succeeding and its tag being recorded (execReplaySafe) is safe.\nUPDATE `comments`\n  SET `parent_type` = 'issue', `parent_entity_id` = `issue_id`\n  WHERE `parent_type` IS NULL AND `issue_id` IS NOT NULL AND `issue_id` <> '';\n--> statement-breakpoint\nUPDATE `comments`\n  SET `parent_type` = 'unresolved', `issue_id` = NULL\n  WHERE `parent_type` IS NULL AND (`issue_id` = '' OR `issue_id` IS NULL);\n",
   },
 } as const;

package/src/mirror.ts

@@ -422,6 +422,13 @@ export const comments = sqliteTable(
   {
     id: text("id").primaryKey(),
     issue_id: text("issue_id"),
+    // CTC-851: the real parent of a non-issue comment (project/initiative update, document, …).
+    // `parent_type` ∈ 'issue'|'projectUpdate'|'initiativeUpdate'|'documentContent'|'project'|
+    // 'initiative'|'unresolved'; `parent_entity_id` is the id of that parent. For an issue comment
+    // both `issue_id` and `parent_entity_id` hold the issue id (parent_type 'issue'), so every
+    // existing `WHERE issue_id = ?` read is untouched. Nullable: a quarantined orphan has neither.
+    parent_type: text("parent_type"),
+    parent_entity_id: text("parent_entity_id"),
     body: text("body"),
     author_id: text("author_id"),
     author_name: text("author_name"),
@@ -435,7 +442,12 @@ export const comments = sqliteTable(
   },
   // CTC-59: the detail comments fetch — `WHERE issue_id = ? AND removed_at IS NULL ORDER BY updated_at`.
   // Composite covers the filter AND the sort, so SQLite seeks instead of building a temp b-tree.
-  (t) => [index("idx_comments_issue").on(t.issue_id, t.removed_at, t.updated_at)],
+  (t) => [
+    index("idx_comments_issue").on(t.issue_id, t.removed_at, t.updated_at),
+    // CTC-851: retrievability by parent — `WHERE parent_type = ? AND parent_entity_id = ? AND
+    // removed_at IS NULL`. Makes the non-issue-comment corpus queryable without a table scan.
+    index("idx_comments_parent").on(t.parent_type, t.parent_entity_id, t.removed_at),
+  ],
 );
 
 // ── GitHub ───────────────────────────────────────────────────────────────────────────────────────