@catalyst-cloud/schema 0.1.17 → 0.1.18

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@catalyst-cloud/schema",
-  "version": "0.1.17",
+  "version": "0.1.18",
   "type": "module",
   "description": "Typed Drizzle schema = single source of truth for the per-tenant Mirror DO SQLite store (CTC-13 / ADR-0002). Shared by the mirror Worker, the host-sync replica, and the browser OPFS replica.",
   "license": "MIT",

package/src/migrations.generated.ts

@@ -207,6 +207,13 @@ export const MIRROR_MIGRATIONS = {
         tag: "0027_closed_miek",
         breakpoints: true,
       },
+      {
+        idx: 28,
+        version: "6",
+        when: 1787038129996,
+        tag: "0028_burly_nemesis",
+        breakpoints: true,
+      },
     ],
   },
   migrations: {
@@ -264,5 +271,6 @@ export const MIRROR_MIGRATIONS = {
       "CREATE TABLE `deployment_statuses` (\n\t`id` text PRIMARY KEY NOT NULL,\n\t`repo_id` text NOT NULL,\n\t`deployment_id` text NOT NULL,\n\t`state` text,\n\t`environment` text,\n\t`target_url` text,\n\t`environment_url` text,\n\t`description` text,\n\t`creator_id` text,\n\t`created_at` integer,\n\t`updated_at` integer\n);\n--> statement-breakpoint\nCREATE INDEX `idx_deployment_statuses_deployment` ON `deployment_statuses` (`deployment_id`,`created_at`);--> statement-breakpoint\nCREATE TABLE `deployments` (\n\t`id` text PRIMARY KEY NOT NULL,\n\t`repo_id` text NOT NULL,\n\t`ref` text,\n\t`sha` text,\n\t`task` text,\n\t`environment` text,\n\t`production_environment` integer,\n\t`transient_environment` integer,\n\t`description` text,\n\t`creator_id` text,\n\t`created_at` integer,\n\t`updated_at` integer\n);\n--> statement-breakpoint\nCREATE INDEX `idx_deployments_repo_env` ON `deployments` (`repo_id`,`environment`,`created_at`);--> statement-breakpoint\nCREATE TABLE `pr_review_threads` (\n\t`id` text PRIMARY KEY NOT NULL,\n\t`repo_id` text NOT NULL,\n\t`pr_number` integer NOT NULL,\n\t`resolved` integer,\n\t`resolved_at` integer,\n\t`resolver_id` text,\n\t`first_comment_id` text,\n\t`comment_count` integer,\n\t`updated_at` integer\n);\n--> statement-breakpoint\nCREATE INDEX `idx_pr_review_threads_pr` ON `pr_review_threads` (`repo_id`,`pr_number`);",
     "0027_closed_miek":
       "CREATE TABLE `check_suites` (\n\t`repo_id` text NOT NULL,\n\t`check_suite_id` text PRIMARY KEY NOT NULL,\n\t`head_sha` text,\n\t`head_branch` text,\n\t`status` text,\n\t`conclusion` text,\n\t`app_slug` text,\n\t`latest_check_runs_count` integer,\n\t`updated_at` integer\n);\n--> statement-breakpoint\nCREATE INDEX `idx_check_suites_sha` ON `check_suites` (`head_sha`);--> statement-breakpoint\nCREATE TABLE `push_events` (\n\t`delivery_id` text PRIMARY KEY NOT NULL,\n\t`repo_id` text NOT NULL,\n\t`ref` text NOT NULL,\n\t`before` text,\n\t`after` text,\n\t`forced` integer,\n\t`created` integer,\n\t`deleted` integer,\n\t`base_ref` text,\n\t`pusher_id` text,\n\t`head_commit_sha` text,\n\t`updated_at` integer\n);\n--> statement-breakpoint\nCREATE INDEX `idx_push_events_repo_ref` ON `push_events` (`repo_id`,`ref`,`updated_at`);--> statement-breakpoint\nALTER TABLE `pull_requests` ADD `merge_commit_sha` text;",
+    "0028_burly_nemesis": "ALTER TABLE `check_suites` ADD `pull_request_numbers` text;",
   },
 } as const;

package/src/mirror.ts

@@ -843,6 +843,37 @@ export const check_suites = sqliteTable(
     app_slug: text("app_slug"),
     /** GitHub's own count of the runs in the suite; useful for spotting a suite still filling up. */
     latest_check_runs_count: integer("latest_check_runs_count"),
+    /**
+     * CTC-712 — the PRs GitHub itself attributed this suite to, as a JSON array of numbers
+     * (`"[123,124]"`). ⛔ THE CONSUMER'S ONLY KEY. `broker/router.mjs:1497` reaches an interest for
+     * `github.check_suite.completed` exclusively through `detail.prNumbers`; an empty one means the
+     * CI wait is never resolved, and under `enforce` there is no smee copy to recover it from.
+     *
+     * ⛔⛔ DO NOT DERIVE THIS FROM `head_sha` → `pull_requests.head_sha`. `pull_requests.head_sha` is
+     * LAST-STATE, so a suite that ran against a head the PR has since moved past can never be joined
+     * back. Measured by CTL on mini-2 (CTC-712): of 202 suites, 93 joined (46%) and 109 missed (54%)
+     * — and the misses were active PR branches (`ryan/ctl-1944-direnv-fleet` 25, `ryan/ctl-1949-ask-
+     * traps` 19), not main. ⭐ The sharpest row: `ctc-pin-sdk-0.8.13` appears in BOTH the hits (10)
+     * and the misses (10) — one branch, where only the suites matching the PR's CURRENT head join.
+     * That is the superseded-head pattern isolated in a single branch, so the 46% is structural.
+     *
+     * ⚠️ Worse than a coverage gap, it is a RACE: the join cannot tell a legitimately-superseded
+     * suite from a current one whose PR moved a moment later, and it drops both — silently, as an
+     * emit-decline rather than an error. Same class as the `pushes` collapse (CTC-704), fixed the
+     * same way: store the EDGE the payload carries, not a projection of state.
+     *
+     * ⚠️ `null` AND `"[]"` ARE DIFFERENT ANSWERS and the distinction is deliberate. `null` = GitHub's
+     * payload carried no `pull_requests` field at all (we do not know); `"[]"` = GitHub told us this
+     * suite belongs to no PR (a `main` push, `release-please--*`). A consumer that must not
+     * distinguish them collapses both to the empty list — which is exactly what the tunnel producer
+     * already does (`webhook-events.ts` `parseCheckSuite` builds `prNumbers: []` for both), so this
+     * column is at PARITY with the tunnel it replaces and strictly more informative.
+     *
+     * ⚠️ KNOWN LIMIT, stated rather than discovered later: GitHub delivers an EMPTY `pull_requests`
+     * for a suite on a FORK's PR. That is a real blind spot — but it is the tunnel's blind spot too,
+     * for the same reason, so retiring the tunnel loses nothing here.
+     */
+    pull_request_numbers: text("pull_request_numbers"),
     updated_at: integer("updated_at"),
   },
   (t) => [index("idx_check_suites_sha").on(t.head_sha)],