@catalyst-cloud/schema 0.1.10 → 0.1.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@catalyst-cloud/schema",
-  "version": "0.1.10",
+  "version": "0.1.11",
   "type": "module",
   "description": "Typed Drizzle schema = single source of truth for the per-tenant Mirror DO SQLite store (CTC-13 / ADR-0002). Shared by the mirror Worker, the host-sync replica, and the browser OPFS replica.",
   "license": "MIT",
@@ -30,7 +30,7 @@
     "drizzle-orm": "0.44.7"
   },
   "devDependencies": {
-    "@catalyst-cloud/typescript-config": "0.0.0",
+    "@catalyst-cloud/typescript-config": "workspace:*",
     "@types/node": "^25.9.3",
     "drizzle-kit": "^0.31.0",
     "prettier": "^3.8.4",

package/src/index.ts

@@ -34,6 +34,7 @@ import {
   agent_activities,
   fleet_activity_pruned,
   pull_sweeps,
+  pr_review_backfill,
 } from "./mirror.js";
 
 export * from "./mirror.js";
@@ -86,6 +87,9 @@ export const mirrorSchema = {
   // migration bundle must produce) but DELIBERATELY ABSENT from `mirrorEntityTables` below — see the
   // no-feed arithmetic on the table definition in ./mirror.ts.
   pull_sweeps,
+  // CTC-575: the closed/merged-PR review-body backfill marker. Same posture as pull_sweeps — a real
+  // table, deliberately absent from mirrorEntityTables (see the doc on the table itself).
+  pr_review_backfill,
   // CTC-393: the fleet_activity anti-resurrection tombstone. Same posture as pull_sweeps — a real
   // table the DO creates, but pure internal bookkeeping that must NEVER ride the change-feed (a
   // consumer has no use for "a row was once terminal here"; see the doc on the table itself).

package/src/migrations.generated.ts

@@ -151,6 +151,13 @@ export const MIRROR_MIGRATIONS = {
         tag: "0019_mushy_sinister_six",
         breakpoints: true,
       },
+      {
+        idx: 20,
+        version: "6",
+        when: 1786856395245,
+        tag: "0020_wealthy_snowbird",
+        breakpoints: true,
+      },
     ],
   },
   migrations: {
@@ -192,5 +199,7 @@ export const MIRROR_MIGRATIONS = {
       "CREATE TABLE `agent_activities` (\n\t`id` text PRIMARY KEY NOT NULL,\n\t`session_id` text NOT NULL,\n\t`type` text,\n\t`body` text,\n\t`signal` text,\n\t`created_at` integer,\n\t`updated_at` integer,\n\t`raw` text\n);\n--> statement-breakpoint\nCREATE INDEX `idx_agent_activities_session_created` ON `agent_activities` (`session_id`,`created_at`);--> statement-breakpoint\nCREATE TABLE `agent_sessions` (\n\t`id` text PRIMARY KEY NOT NULL,\n\t`issue_id` text,\n\t`status` text,\n\t`app_user_id` text,\n\t`creator_id` text,\n\t`created_at` integer,\n\t`updated_at` integer,\n\t`removed_at` integer,\n\t`raw` text\n);\n--> statement-breakpoint\nCREATE INDEX `idx_agent_sessions_issue` ON `agent_sessions` (`issue_id`,`updated_at`);",
     "0019_mushy_sinister_six":
       "ALTER TABLE `agent_sessions` ADD `archived_at` integer;--> statement-breakpoint\nALTER TABLE `agent_sessions` ADD `dismissed_at` integer;--> statement-breakpoint\nALTER TABLE `agent_sessions` ADD `dismissed_by` text;",
+    "0020_wealthy_snowbird":
+      "CREATE TABLE `pr_review_backfill` (\n\t`repo_id` text NOT NULL,\n\t`pr_number` integer NOT NULL,\n\t`backfilled_at` integer NOT NULL,\n\tPRIMARY KEY(`repo_id`, `pr_number`)\n);\n--> statement-breakpoint\nALTER TABLE `reviews` ADD `body` text;",
   },
 } as const;

package/src/mirror.ts

@@ -438,6 +438,12 @@ export const reviews = sqliteTable("reviews", {
   user_id: text("user_id"),
   state: text("state"),
   submitted_at: integer("submitted_at"),
+  // CTC-575: the review's text. GitHub always sends it; it was destructured away at the type boundary
+  // in three places (github/queries.ts, normalize/github.ts ×2) before this. ⛔ `reviews` has NO
+  // updated_at, so upsertRow's last-write-wins guard is inert here — the reconcile's hand-rolled
+  // read-before-emit (github-reconcile.ts) is the ONLY thing that decides whether an edited body
+  // re-emits a change_log delta, and it must compare `body` too or an edit never propagates.
+  body: text("body"),
 });
 
 // ── Mirror infra (not domain entities — never ride the change-feed) ─────────────────────────────────
@@ -621,3 +627,41 @@ export const pull_sweeps = sqliteTable(
   },
   (t) => [primaryKey({ columns: [t.repo_id, t.pr_number] })],
 );
+
+/**
+ * CTC-575 — a marker that a CLOSED/MERGED PR's reviews have been swept AT LEAST ONCE for `body`.
+ *
+ * ⛔ WHY THIS EXISTS. `reconcileGithub`'s open-PR walk sweeps reviews only for PRs whose `state` is
+ * still `open` — a closed/merged PR's reviews are frozen at whatever the last webhook or open-PR sweep
+ * wrote, which for every review that predates this ticket is `body: null` (the column did not exist).
+ * Nothing else ever revisits a closed PR, so without a dedicated backfill leg every historical review
+ * body on every already-closed PR would stay null forever.
+ *
+ * ⛔ WHY A MARKER PER PR, NOT A SINGLE RESUME CURSOR. PR numbers are monotonic by CREATION order, not
+ * by CLOSE order — PR #5 can close well after PR #50 already did. A single "highest number backfilled"
+ * watermark (the `resumeEntity`/`mergeableEntity` pattern above) would permanently skip a low-numbered
+ * PR that closes late, once the watermark has already passed its number. A per-(repo_id, pr_number)
+ * marker is checked independently, so a PR is swept exactly once, whenever it happens to close.
+ *
+ * ⛔ DELIBERATELY NOT `pull_sweeps`. That table's three-state decode (no row / SHA-mismatch / count-or-
+ * error) is a documented invariant for the OPEN-PR CI-enrichment receipt (check_runs/commit_statuses),
+ * and this backfill sweeps reviews ONLY for a closed PR — writing a `pull_sweeps` row with
+ * check_run_count/commit_status_count left null and no *_error set would forge a fourth, undocumented
+ * state indistinguishable from "the checks fetch failed". A dedicated table keeps the two receipts'
+ * invariants independently true.
+ *
+ * ⛔ HUB-READ-ONLY, same posture as `pull_sweeps` / `fleet_activity_pruned`: never rides the change
+ * feed (absent from mirrorEntityTables / SNAPSHOT_TABLES / GITHUB_ENTITIES, no appendChange) — a
+ * consumer has no use for "we once swept this PR's reviews", and self-limiting at |closed PRs in the
+ * repo| (one row per PR, written once, never revisited).
+ */
+export const pr_review_backfill = sqliteTable(
+  "pr_review_backfill",
+  {
+    repo_id: text("repo_id").notNull(),
+    pr_number: integer("pr_number").notNull(),
+    /** When the backfill swept this PR's reviews (ms). */
+    backfilled_at: integer("backfilled_at").notNull(),
+  },
+  (t) => [primaryKey({ columns: [t.repo_id, t.pr_number] })],
+);