@catalyst-cloud/cli 0.15.1 → 0.15.3

package/dist/ready.js

@@ -3,7 +3,7 @@
 // is a note, never a failure; the HTTP SDK loading is a check for cloud reads.
 import { accessSync, constants, existsSync, readFileSync, realpathSync, statSync, } from "node:fs";
 import { basename, delimiter, dirname, join } from "node:path";
-import { LEGACY_PACKAGE_NAME, PACKAGE_NAME, defaultSkillsDirFor, loadConfig, normalizeBaseUrl, readManifest, upgradeCommand, } from "./config.js";
+import { DEFAULT_BASE_URL, LEGACY_PACKAGE_NAME, PACKAGE_NAME, defaultSkillsDirFor, loadConfig, normalizeBaseUrl, readManifest, upgradeCommand, } from "./config.js";
 import { contractVersionInRange, readContractCache } from "./contract.js";
 import { CliError } from "./errors.js";
 import { latestPublishedVersion } from "./published.js";
@@ -15,6 +15,7 @@ import { FIRST_STAMPED_VERSION } from "./skill-shape.js";
 import { installedBundleVersion } from "./skills.js";
 import { onboardingReadyReport, observeCloudOnboarding, } from "./onboard-ready.js";
 import { selectedOnboardTeam } from "./onboard-existing.js";
+import { dispatchGateCopy, teamCheckCopy, teamPage, valuesFix, whoFixes } from "./ready-copy.js";
 import { onboardStatePath, readOnboardJournal } from "./onboard.js";
 export { semverOlder };
 /** `ready`'s own wording for the replica. It never recommends adopting the replica — until the
@@ -40,7 +41,7 @@ function readyReplicaLine(s) {
         case "not-configured":
             return "replica: not configured — run login first";
         case "absent":
-            return `replica: absent at ${s.dbPath} — optional, and off by default for large tenants while the snapshot path is being made safe; every read works through the API`;
+            return `replica: absent at ${s.dbPath} — optional, and off by default for large workspaces while the snapshot path is being made safe; every read works through the API`;
         case "fresh":
             return `replica: fresh at ${s.dbPath} (cursor ${s.cursor}, heartbeat ${s.heartbeatAgeMs}ms ago${s.lag !== undefined ? `, ${s.lag} behind head ${s.head}` : ""})`;
         case "stale":
@@ -111,81 +112,6 @@ export function catalystCommandCheck(env, platform = process.platform) {
             "Keep using catalyst-skills on this machine, or put the npm global bin directory ahead of that one on PATH.",
     };
 }
-function nameList(v) {
-    return Array.isArray(v)
-        ? v.filter((n) => typeof n === "string" && n.length > 0)
-        : [];
-}
-/** Entries whose name and references are both present; anything malformed is dropped, not guessed. */
-function unresolvedList(v) {
-    if (!Array.isArray(v))
-        return [];
-    return v.flatMap((u) => {
-        if (typeof u !== "object" || u === null)
-            return [];
-        const { name, references } = u;
-        const refs = nameList(references);
-        return typeof name === "string" && name.length > 0 && refs.length > 0
-            ? [{ name, references: refs }]
-            : [];
-    });
-}
-function unresolvedLine(u) {
-    const which = u.references.length === 1 ? "which has" : "which have";
-    return `${u.name} references ${u.references.join(", ")}, ${which} no value; the checkout refuses it before work starts`;
-}
-/** A team check's fix line. A check that carries `names` (CTC-3561: `required_values`, contract
- *  1.24.0) names them and where to set them. CTC-3606: it also names each `unresolved` variable and
- *  the reference with no value, and each other repository's missing names from `repos[]`. `unresolved`
- *  is a subset of `names` (the variable exists; its reference does not), so those are not told to be
- *  "set". Every field is optional so an older cloud still works. Everything printed is a declared
- *  identifier or a repository name, never a value, and nothing here reads a value. Any other check
- *  keeps the generic line. */
-function teamCheckFix(label, c) {
-    const automationRules = {
-        linear_automation_pr_open: "On PR open",
-        linear_automation_pr_review: "On PR review request or activity",
-        linear_automation_pr_ready: "On PR ready for merge",
-        linear_automation_pr_merge: "On PR merge",
-    };
-    const rule = automationRules[c.id];
-    if (rule) {
-        return `in Linear, open Settings → Teams → ${label} → Workflow → Workflows & automations → Pull request and commit automations and set ${rule} to No action, including branch-specific overrides; then run catalyst team check ${label}`;
-    }
-    const unresolved = unresolvedList(c.unresolved);
-    const unresolvedNames = new Set(unresolved.map((u) => u.name));
-    const names = nameList(c.names).filter((n) => !unresolvedNames.has(n));
-    const parts = [];
-    if (names.length > 0) {
-        parts.push(`set ${names.join(", ")} on the repository's Environment page under Settings → Your projects → the project → Repositories → the repository ` +
-            `(team ${label}; ${names.length === 1 ? "it has" : "they have"} no value at repository or account scope)`);
-    }
-    for (const u of unresolved)
-        parts.push(unresolvedLine(u));
-    for (const note of Array.isArray(c.repos) ? c.repos : []) {
-        if (typeof note !== "object" ||
-            note === null ||
-            typeof note.repo !== "string" ||
-            note.repo.length === 0)
-            continue;
-        const repoUnresolved = unresolvedList(note.unresolved);
-        const skip = new Set(repoUnresolved.map((u) => u.name));
-        const missing = nameList(note.names).filter((n) => !skip.has(n));
-        if (missing.length > 0)
-            parts.push(`${note.repo} is missing ${missing.join(", ")}`);
-        for (const u of repoUnresolved)
-            parts.push(`in ${note.repo}, ${unresolvedLine(u)}`);
-    }
-    if (parts.length === 0)
-        return `open settings for team ${label} and resolve ${c.id}`;
-    return parts.join(". ");
-}
-function whoCanAnswer(doc) {
-    const roles = doc.humans.map((h) => `${h.role} ${h.linearUserId}`);
-    return roles.length
-        ? roles.join(", ")
-        : "a tenant owner or admin (none resolved on the contract)";
-}
 export async function readyReport(ctx, deps) {
     const checks = [];
     const facts = deps.runtime ?? detectRuntime();
@@ -265,7 +191,7 @@ export async function readyReport(ctx, deps) {
                 id: "bundle",
                 ok: false,
                 note: true,
-                line: `bundle: ${installed} installed is older than the tenant's minimum ${minVersion} — upgrade: ${upgradeCommand()}`,
+                line: `bundle: ${installed} installed is older than your workspace's minimum ${minVersion} — upgrade: ${upgradeCommand()}`,
             });
         }
     }
@@ -394,7 +320,7 @@ export async function readyReport(ctx, deps) {
     });
     if (cache) {
         const doc = cache.doc;
-        const who = whoCanAnswer(doc);
+        const base = (cfg?.baseUrl ?? DEFAULT_BASE_URL).replace(/\/+$/, "");
         for (const team of doc.teams) {
             const label = team.key ?? team.id;
             // The team's dispatch gate, straight off the cached contract: an older cloud omits it and this
@@ -404,28 +330,36 @@ export async function readyReport(ctx, deps) {
             // checked still reports its gate, which is exactly the team most likely to be unmapped.
             const dg = team.dispatchGate;
             if (dg && typeof dg.status === "string") {
-                const slots = (dg.missingSlots ?? []).join(", ");
-                checks.push(dg.status === "open"
+                // CTC-4680: the cloud's own remedy text names an API route and says "tenant", so the words
+                // come from ready-copy; the status and slots stay readable in the check id's JSON neighbours.
+                const copy = dispatchGateCopy(base, label, dg.status, dg.missingSlots ?? []);
+                checks.push(dg.status === "stages_syncing"
                     ? {
-                        id: `team:${label}:dispatchGate`,
-                        ok: true,
-                        line: `team ${label}: dispatch gate open`,
-                    }
-                    : {
                         id: `team:${label}:dispatchGate`,
                         ok: false,
-                        line: `team ${label}: dispatch gate ${dg.status}${slots ? ` (${slots})` : ""}, blocking`,
-                        fix: dg.remedy ??
-                            `open settings for team ${label} and map its stages`,
-                        who,
-                    });
+                        note: true,
+                        line: copy.line,
+                    }
+                    : dg.status === "open"
+                        ? {
+                            id: `team:${label}:dispatchGate`,
+                            ok: true,
+                            line: copy.line,
+                        }
+                        : {
+                            id: `team:${label}:dispatchGate`,
+                            ok: false,
+                            line: copy.line,
+                            ...(copy.fix ? { fix: copy.fix } : {}),
+                            who: whoFixes("mapping_total"),
+                        });
             }
             if (team.readiness.status === "unchecked") {
                 checks.push({
                     id: `team:${label}`,
                     ok: true,
                     note: true,
-                    line: `team ${label}: readiness not checked yet`,
+                    line: `team ${label}: Catalyst hasn't checked this team yet`,
                 });
                 continue;
             }
@@ -441,13 +375,14 @@ export async function readyReport(ctx, deps) {
             for (const c of bad) {
                 const meta = doc.readinessChecks.find((r) => r.id === c.id);
                 const needsAnswer = meta?.needsAnswer ?? true;
+                const copy = teamCheckCopy(base, label, c.id, c.state === "fail" ? "fail" : "unknown", valuesFix(base, c));
                 checks.push({
                     id: `team:${label}:${c.id}`,
                     ok: !needsAnswer && c.state !== "fail",
                     note: !needsAnswer,
-                    line: `team ${label}: ${c.id} is ${c.state}${c.reason ? ` (${c.reason}${c.count !== undefined ? ` ×${c.count}` : ""})` : ""}${meta ? `, ${meta.severity}` : ""}`,
-                    fix: teamCheckFix(label, c),
-                    who: needsAnswer ? who : "nobody yet; it is informational",
+                    line: copy.line,
+                    ...(copy.fix ? { fix: copy.fix } : {}),
+                    who: needsAnswer ? whoFixes(c.id) : "nobody yet; it is informational",
                 });
             }
             if (bad.length === 0 && team.readiness.status !== "ready") {
@@ -455,9 +390,11 @@ export async function readyReport(ctx, deps) {
                     id: `team:${label}`,
                     ok: team.readiness.status !== "blocked",
                     note: team.readiness.status === "degraded",
-                    line: `team ${label}: ${team.readiness.status}`,
-                    fix: `open settings for team ${label}`,
-                    who,
+                    line: team.readiness.status === "degraded"
+                        ? `team ${label}: works, with some optional settings still missing`
+                        : `team ${label}: not ready for work yet`,
+                    fix: `open ${teamPage(base, label)}`,
+                    who: whoFixes("mapping_total"),
                 });
             }
         }