@cat-factory/orchestration 0.6.0

package/dist/modules/execution/ReviewGateController.js

@@ -0,0 +1,251 @@
+import { assertFound, ConflictError, ValidationError } from '@cat-factory/kernel';
+import { hasNotesToIncorporate } from '../requirements/requirements.logic.js';
+/**
+ * Drives the two iterative review gates — `requirements-review` and `clarity-review` — which
+ * share the SAME control flow: an inline reviewer LLM raises findings, the run parks on a
+ * durable decision-wait, a human answers/dismisses through the dedicated window, an
+ * incorporation pass folds the answers into one standardized document, and the reviewer
+ * re-reviews it until it converges (or the iteration budget runs out). Only the subject and
+ * the persisted document differ; everything structural is shared, so each method below takes
+ * a {@link ReviewKind} and is written exactly once. Extracted out of `ExecutionService`; the
+ * shared step-graph primitives it calls (the parking gate, the resolved-gate advance, the
+ * iteration-cap dispatch, the block/instance writes) stay on the engine and are injected via
+ * {@link ReviewGateControllerDeps}.
+ */
+export class ReviewGateController {
+    deps;
+    constructor(deps) {
+        this.deps = deps;
+    }
+    /**
+     * Run a review gate step. When the reviewer isn't wired the step passes through (pipelines
+     * run unchanged without the feature). Otherwise it runs the initial reviewer pass: an
+     * auto-pass (no findings, or all at/below the task's tolerated severity) advances
+     * immediately, recording the findings; anything else parks the run for the dedicated review
+     * window to drive the iterative loop. Re-entrant on incorporation: when the human answered
+     * the findings and asked to incorporate, the (slow) fold + re-review LLM work runs here in
+     * the durable driver instead of in the HTTP request the user is no longer waiting on.
+     */
+    async evaluate(kind, workspaceId, instance, step, block, isFinalStep) {
+        if (!kind.enabled()) {
+            return this.completeStep(workspaceId, instance, step, isFinalStep);
+        }
+        // Re-entry: the human answered the findings and asked to incorporate. Do the (slow)
+        // LLM work here in the durable driver — fold the answers into a document, then
+        // re-review it — instead of in the HTTP request that the user is no longer waiting on.
+        // `reReview` raises the re-summon notification itself when it finds findings.
+        const pending = step.pendingIncorporation;
+        if (pending) {
+            step.pendingIncorporation = null;
+            const review = await this.runIncorporationCycle(kind, workspaceId, block.id, pending.feedback);
+            if (review.status === 'incorporated') {
+                return this.completeStep(workspaceId, instance, step, isFinalStep);
+            }
+            // `ready`/`exceeded`: re-park (a fresh decision id) and wait for the human again.
+            // At the cap, raise a notification so the three-choice decision is discoverable.
+            if (review.status === 'exceeded')
+                await this.deps.raiseDecisionRequired(workspaceId, instance);
+            return this.deps.parkStepOnDecision(workspaceId, instance, step);
+        }
+        // Fresh entry: run the initial reviewer pass with the task's preset knobs (shared with
+        // the off-path inspector surface). Auto-pass (status `incorporated`) → advance; the
+        // findings stay recorded on the review for transparency. `ready`/`exceeded` → park for
+        // the dedicated window.
+        const review = await this.review(kind, workspaceId, block.id);
+        if (review.status === 'incorporated') {
+            return this.completeStep(workspaceId, instance, step, isFinalStep);
+        }
+        if (review.status === 'exceeded')
+            await this.deps.raiseDecisionRequired(workspaceId, instance);
+        return this.deps.parkStepOnDecision(workspaceId, instance, step);
+    }
+    /**
+     * Fold the human's settled answers into a standardized document and re-review it (one
+     * iteration of the loop), emitting the live review-changed event after each phase so an
+     * open window/inspector tracks progress. Runs inside the durable driver (see
+     * {@link evaluate} re-entry); shared by the no-run inline fallback in {@link incorporate}.
+     * Returns the re-reviewed review.
+     */
+    async runIncorporationCycle(kind, workspaceId, blockId, feedback) {
+        const review = await this.currentReview(kind, workspaceId, blockId);
+        // Nothing to fold in (every finding dismissed, no answered replies, no redo
+        // feedback) → the requirements stand as-is. Skip the rework + re-review LLM calls
+        // and settle the review directly. `markIncorporated` preserves any
+        // incorporated document from an earlier iteration, so downstream consumes that
+        // prior doc when one exists, else falls back to the original description (nothing
+        // was clarified). Mirrors a polling gate's precheck skip.
+        if (!hasNotesToIncorporate(review.items, feedback)) {
+            const settled = await kind.markIncorporated(workspaceId, review.id);
+            await kind.emit(workspaceId, settled);
+            return settled;
+        }
+        const block = assertFound(await this.deps.blockRepository.get(workspaceId, blockId), 'Block', blockId);
+        const preset = await this.deps.resolveMergePreset(workspaceId, block);
+        await kind.incorporate(workspaceId, blockId, review.id, feedback);
+        // The fold is done; flag the SECOND stage (`reviewing`) so the board/window can show
+        // "re-reviewing" distinctly from "incorporating" — either of the two LLM calls can be
+        // the slow one, so the human needs to know which is currently running.
+        const reReviewing = await kind.markReReviewing(workspaceId, review.id);
+        await kind.emit(workspaceId, reReviewing);
+        const reviewed = await kind.reReview(workspaceId, review.id, preset);
+        await kind.emit(workspaceId, reviewed);
+        return reviewed;
+    }
+    /** Finish a review gate step and advance to the next step (or finish the run). */
+    async completeStep(workspaceId, instance, step, isFinalStep) {
+        this.deps.finishStep(step);
+        step.progress = 1;
+        step.subtasks = undefined;
+        step.approval = null;
+        if (isFinalStep) {
+            instance.status = 'done';
+            await this.deps.finalizeBlock(workspaceId, instance, undefined);
+            await this.deps.persistInstance(workspaceId, instance);
+            await this.deps.emitInstance(workspaceId, instance);
+            await this.deps.stopRunContainer(workspaceId, instance);
+            return { kind: 'done' };
+        }
+        instance.currentStep += 1;
+        const next = instance.steps[instance.currentStep];
+        if (next)
+            this.deps.startStep(next);
+        await this.deps.updateBlockProgress(workspaceId, instance, 'in_progress');
+        await this.deps.persistInstance(workspaceId, instance);
+        await this.deps.emitInstance(workspaceId, instance);
+        return { kind: 'continue' };
+    }
+    /** Resolve a block's current review or throw. */
+    async currentReview(kind, workspaceId, blockId) {
+        return assertFound(await kind.getForBlock(workspaceId, blockId), kind.entityName, blockId);
+    }
+    /**
+     * Run a fresh reviewer pass over a block, snapshotting the task's merge-preset knobs
+     * (iteration budget + tolerated severity) onto the review. Shared by the pipeline gate
+     * ({@link evaluate}) and the off-path inspector "Run review" surface, so both honour the
+     * task's preset identically.
+     */
+    async review(kind, workspaceId, blockId) {
+        const block = assertFound(await this.deps.blockRepository.get(workspaceId, blockId), 'Block', blockId);
+        const preset = await this.deps.resolveMergePreset(workspaceId, block);
+        return kind.review(workspaceId, block, preset);
+    }
+    /**
+     * Incorporate the human's settled answers ASYNCHRONOUSLY. Validates that every finding is
+     * answered/dismissed (so the user gets immediate feedback if not), flags the review
+     * `incorporating`, records the intent on the parked gate step, and signals the durable
+     * driver to wake — which folds the answers and re-reviews in the background (see
+     * {@link evaluate} re-entry). Returns at once with the `incorporating` review so the SPA
+     * can return the user to the board; they are summoned again only if the re-review yields
+     * findings (`ready`) or hits the cap (`exceeded`).
+     *
+     * No parked run (an off-path inspector review with no active pipeline) → there is no driver
+     * to offload to, so the fold + re-review run inline here. That path never had the
+     * pipeline-gate freeze this method exists to remove.
+     */
+    async incorporate(kind, workspaceId, blockId, feedback) {
+        const review = await this.currentReview(kind, workspaceId, blockId);
+        const open = review.items.filter((i) => i.status === 'open');
+        if (open.length > 0) {
+            throw new ValidationError(`Answer or dismiss all ${open.length} remaining item(s) before incorporating`);
+        }
+        const parked = await this.findParkedStep(kind, workspaceId, blockId);
+        if (!parked) {
+            // Off-path: no pipeline parked on this review. Do the work inline (it cannot be
+            // offloaded to a driver that isn't running) and return the re-reviewed result.
+            return this.runIncorporationCycle(kind, workspaceId, blockId, feedback);
+        }
+        const { instance, step } = parked;
+        step.pendingIncorporation = feedback ? { feedback } : {};
+        // Re-arm the run BEFORE signalling the driver: the park left it `blocked`, but
+        // `advanceInstance` no-ops unless the run is `running`/`paused`, so a woken driver
+        // would otherwise return `noop` (and the workflow would end) WITHOUT running the
+        // re-entrant incorporate + re-review cycle — leaving the review stuck `incorporating`
+        // forever. Mirrors every other resume path (e.g. `advancePastResolvedGate`).
+        if (instance.status === 'blocked')
+            instance.status = 'running';
+        const updated = await kind.markIncorporating(workspaceId, review.id);
+        await this.deps.persistInstance(workspaceId, instance);
+        await this.deps.emitInstance(workspaceId, instance);
+        await kind.emit(workspaceId, updated);
+        await this.deps.workRunner.signalDecision(workspaceId, instance.id, step.approval.id, 'incorporate');
+        return updated;
+    }
+    /** Locate the run + gate step a block's review is parked on (or null). */
+    async findParkedStep(kind, workspaceId, blockId) {
+        const block = await this.deps.blockRepository.get(workspaceId, blockId);
+        if (!block?.executionId)
+            return null;
+        const instance = await this.deps.executionRepository.get(workspaceId, block.executionId);
+        if (!instance)
+            return null;
+        const step = instance.steps.find((s) => s.agentKind === kind.agentKind &&
+            s.state === 'waiting_decision' &&
+            s.approval?.status === 'pending');
+        return step ? { instance, step } : null;
+    }
+    /**
+     * Re-review the incorporated document (one more reviewer pass). On convergence
+     * (`incorporated`) the parked run advances; otherwise the window shows the next cycle
+     * (`ready`) or the iteration-cap choices (`exceeded`). Only valid once an incorporation
+     * has produced a document to re-review (status `merged`).
+     */
+    async reReview(kind, workspaceId, blockId) {
+        const review = await this.currentReview(kind, workspaceId, blockId);
+        if (review.status !== 'merged') {
+            throw new ConflictError('Incorporate the answers before re-reviewing');
+        }
+        const block = assertFound(await this.deps.blockRepository.get(workspaceId, blockId), 'Block', blockId);
+        const preset = await this.deps.resolveMergePreset(workspaceId, block);
+        const updated = await kind.reReview(workspaceId, review.id, preset);
+        if (updated.status === 'incorporated')
+            await this.resumeRun(kind, workspaceId, blockId);
+        return updated;
+    }
+    /**
+     * Proceed: settle the review (the last incorporated doc, if any, becomes what downstream
+     * agents consume) and advance the parked run. Used when every finding is dismissed, or the
+     * human proceeds past the iteration cap.
+     */
+    async proceed(kind, workspaceId, blockId) {
+        const review = await this.currentReview(kind, workspaceId, blockId);
+        const updated = await kind.markIncorporated(workspaceId, review.id);
+        await this.resumeRun(kind, workspaceId, blockId);
+        return updated;
+    }
+    /**
+     * Resolve a review that hit its iteration cap: grant one more round, proceed with the last
+     * incorporated doc, or stop the task and reset it to phase zero (the run is cancelled, the
+     * block returns to `planned` and is editable again; the review — with its last incorporated
+     * doc — survives as a base for the next attempt).
+     */
+    async resolveExceeded(kind, workspaceId, blockId, choice) {
+        const review = await this.currentReview(kind, workspaceId, blockId);
+        await this.deps.dispatchIterationCap(workspaceId, blockId, choice, {
+            extraRound: () => kind.grantExtraRound(workspaceId, review.id),
+            proceed: () => this.proceed(kind, workspaceId, blockId),
+        });
+        // Re-read so the caller sees the post-resolution state (the doc survives stop-reset).
+        return this.currentReview(kind, workspaceId, blockId);
+    }
+    /**
+     * Resume a run parked on its review gate: finish the gate step, advance to the next step
+     * and wake the durable driver. A no-op when the block has no run parked on a review gate of
+     * this kind (e.g. an off-path inspector review with no active pipeline).
+     */
+    async resumeRun(kind, workspaceId, blockId) {
+        const block = await this.deps.blockRepository.get(workspaceId, blockId);
+        if (!block?.executionId)
+            return;
+        const instance = await this.deps.executionRepository.get(workspaceId, block.executionId);
+        if (!instance)
+            return;
+        const idx = instance.steps.findIndex((s) => s.agentKind === kind.agentKind &&
+            s.state === 'waiting_decision' &&
+            s.approval?.status === 'pending');
+        if (idx === -1)
+            return;
+        instance.steps[idx].approval.status = 'approved';
+        await this.deps.advancePastResolvedGate(workspaceId, instance, idx);
+    }
+}
+//# sourceMappingURL=ReviewGateController.js.map

package/dist/modules/execution/ReviewGateController.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"ReviewGateController.js","sourceRoot":"","sources":["../../../src/modules/execution/ReviewGateController.ts"],"names":[],"mappings":"AAUA,OAAO,EAAE,WAAW,EAAE,aAAa,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAA;AACjF,OAAO,EAAE,qBAAqB,EAAE,MAAM,uCAAuC,CAAA;AAuG7E;;;;;;;;;;;GAWG;AACH,MAAM,OAAO,oBAAoB;IACF,IAAI;IAAjC,YAA6B,IAA8B;oBAA9B,IAAI;IAA6B,CAAC;IAE/D;;;;;;;;OAQG;IACH,KAAK,CAAC,QAAQ,CACZ,IAAyB,EACzB,WAAmB,EACnB,QAA2B,EAC3B,IAAkB,EAClB,KAAY,EACZ,WAAoB;QAEpB,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,EAAE,CAAC;YACpB,OAAO,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,CAAC,CAAA;QACpE,CAAC;QAED,oFAAoF;QACpF,+EAA+E;QAC/E,uFAAuF;QACvF,8EAA8E;QAC9E,MAAM,OAAO,GAAG,IAAI,CAAC,oBAAoB,CAAA;QACzC,IAAI,OAAO,EAAE,CAAC;YACZ,IAAI,CAAC,oBAAoB,GAAG,IAAI,CAAA;YAChC,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,qBAAqB,CAAC,IAAI,EAAE,WAAW,EAAE,KAAK,CAAC,EAAE,EAAE,OAAO,CAAC,QAAQ,CAAC,CAAA;YAC9F,IAAI,MAAM,CAAC,MAAM,KAAK,cAAc,EAAE,CAAC;gBACrC,OAAO,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,CAAC,CAAA;YACpE,CAAC;YACD,kFAAkF;YAClF,iFAAiF;YACjF,IAAI,MAAM,CAAC,MAAM,KAAK,UAAU;gBAAE,MAAM,IAAI,CAAC,IAAI,CAAC,qBAAqB,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;YAC9F,OAAO,IAAI,CAAC,IAAI,CAAC,kBAAkB,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,CAAC,CAAA;QAClE,CAAC;QAED,uFAAuF;QACvF,oFAAoF;QACpF,uFAAuF;QACvF,wBAAwB;QACxB,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,WAAW,EAAE,KAAK,CAAC,EAAE,CAAC,CAAA;QAC7D,IAAI,MAAM,CAAC,MAAM,KAAK,cAAc,EAAE,CAAC;YACrC,OAAO,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,CAAC,CAAA;QACpE,CAAC;QACD,IAAI,MAAM,CAAC,MAAM,KAAK,UAAU;YAAE,MAAM,IAAI,CAAC,IAAI,CAAC,qBAAqB,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QAC9F,OAAO,IAAI,CAAC,IAAI,CAAC,kBAAkB,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,CAAC,CAAA;IAClE,CAAC;IAED;;;;;;OAMG;IACK,KAAK,CAAC,qBAAqB,CACjC,IAAyB,EACzB,WAAmB,EACnB,OAAe,EACf,QAAiB;QAEjB,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,CAAA;QACnE,4EAA4E;QAC5E,kFAAkF;QAClF,mEAAmE;QACnE,+EAA+E;QAC/E,kFAAkF;QAClF,0DAA0D;QAC1D,IAAI,CAAC,qBAAqB,CAAC,MAAM,CAAC,KAAK,EAAE,QAAQ,CAAC,EAAE,CAAC;YACnD,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,gBAAgB,CAAC,WAAW,EAAE,MAAM,CAAC,EAAE,CAAC,CAAA;YACnE,MAAM,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,OAAO,CAAC,CAAA;YACrC,OAAO,OAAO,CAAA;QAChB,CAAC;QACD,MAAM,KAAK,GAAG,WAAW,CACvB,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,WAAW,EAAE,OAAO,CAAC,EACzD,OAAO,EACP,OAAO,CACR,CAAA;QACD,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,kBAAkB,CAAC,WAAW,EAAE,KAAK,CAAC,CAAA;QACrE,MAAM,IAAI,CAAC,WAAW,CAAC,WAAW,EAAE,OAAO,EAAE,MAAM,CAAC,EAAE,EAAE,QAAQ,CAAC,CAAA;QACjE,qFAAqF;QACrF,sFAAsF;QACtF,uEAAuE;QACvE,MAAM,WAAW,GAAG,MAAM,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,MAAM,CAAC,EAAE,CAAC,CAAA;QACtE,MAAM,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,WAAW,CAAC,CAAA;QACzC,MAAM,QAAQ,GAAG,MAAM,IAAI,CAAC,QAAQ,CAAC,WAAW,EAAE,MAAM,CAAC,EAAE,EAAE,MAAM,CAAC,CAAA;QACpE,MAAM,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACtC,OAAO,QAAQ,CAAA;IACjB,CAAC;IAED,kFAAkF;IAC1E,KAAK,CAAC,YAAY,CACxB,WAAmB,EACnB,QAA2B,EAC3B,IAAkB,EAClB,WAAoB;QAEpB,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,CAAA;QAC1B,IAAI,CAAC,QAAQ,GAAG,CAAC,CAAA;QACjB,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAA;QACzB,IAAI,CAAC,QAAQ,GAAG,IAAI,CAAA;QACpB,IAAI,WAAW,EAAE,CAAC;YAChB,QAAQ,CAAC,MAAM,GAAG,MAAM,CAAA;YACxB,MAAM,IAAI,CAAC,IAAI,CAAC,aAAa,CAAC,WAAW,EAAE,QAAQ,EAAE,SAAS,CAAC,CAAA;YAC/D,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;YACtD,MAAM,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;YACnD,MAAM,IAAI,CAAC,IAAI,CAAC,gBAAgB,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;YACvD,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,CAAA;QACzB,CAAC;QACD,QAAQ,CAAC,WAAW,IAAI,CAAC,CAAA;QACzB,MAAM,IAAI,GAAG,QAAQ,CAAC,KAAK,CAAC,QAAQ,CAAC,WAAW,CAAC,CAAA;QACjD,IAAI,IAAI;YAAE,IAAI,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAA;QACnC,MAAM,IAAI,CAAC,IAAI,CAAC,mBAAmB,CAAC,WAAW,EAAE,QAAQ,EAAE,aAAa,CAAC,CAAA;QACzE,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACtD,MAAM,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACnD,OAAO,EAAE,IAAI,EAAE,UAAU,EAAE,CAAA;IAC7B,CAAC;IAED,iDAAiD;IACzC,KAAK,CAAC,aAAa,CACzB,IAAyB,EACzB,WAAmB,EACnB,OAAe;QAEf,OAAO,WAAW,CAAC,MAAM,IAAI,CAAC,WAAW,CAAC,WAAW,EAAE,OAAO,CAAC,EAAE,IAAI,CAAC,UAAU,EAAE,OAAO,CAAC,CAAA;IAC5F,CAAC;IAED;;;;;OAKG;IACH,KAAK,CAAC,MAAM,CACV,IAAyB,EACzB,WAAmB,EACnB,OAAe;QAEf,MAAM,KAAK,GAAG,WAAW,CACvB,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,WAAW,EAAE,OAAO,CAAC,EACzD,OAAO,EACP,OAAO,CACR,CAAA;QACD,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,kBAAkB,CAAC,WAAW,EAAE,KAAK,CAAC,CAAA;QACrE,OAAO,IAAI,CAAC,MAAM,CAAC,WAAW,EAAE,KAAK,EAAE,MAAM,CAAC,CAAA;IAChD,CAAC;IAED;;;;;;;;;;;;OAYG;IACH,KAAK,CAAC,WAAW,CACf,IAAyB,EACzB,WAAmB,EACnB,OAAe,EACf,QAAiB;QAEjB,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,CAAA;QACnE,MAAM,IAAI,GAAG,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,MAAM,CAAC,CAAA;QAC5D,IAAI,IAAI,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACpB,MAAM,IAAI,eAAe,CACvB,yBAAyB,IAAI,CAAC,MAAM,yCAAyC,CAC9E,CAAA;QACH,CAAC;QAED,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,cAAc,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,CAAA;QACpE,IAAI,CAAC,MAAM,EAAE,CAAC;YACZ,gFAAgF;YAChF,+EAA+E;YAC/E,OAAO,IAAI,CAAC,qBAAqB,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,EAAE,QAAQ,CAAC,CAAA;QACzE,CAAC;QAED,MAAM,EAAE,QAAQ,EAAE,IAAI,EAAE,GAAG,MAAM,CAAA;QACjC,IAAI,CAAC,oBAAoB,GAAG,QAAQ,CAAC,CAAC,CAAC,EAAE,QAAQ,EAAE,CAAC,CAAC,CAAC,EAAE,CAAA;QACxD,+EAA+E;QAC/E,mFAAmF;QACnF,iFAAiF;QACjF,sFAAsF;QACtF,6EAA6E;QAC7E,IAAI,QAAQ,CAAC,MAAM,KAAK,SAAS;YAAE,QAAQ,CAAC,MAAM,GAAG,SAAS,CAAA;QAC9D,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,iBAAiB,CAAC,WAAW,EAAE,MAAM,CAAC,EAAE,CAAC,CAAA;QACpE,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACtD,MAAM,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACnD,MAAM,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,OAAO,CAAC,CAAA;QACrC,MAAM,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,cAAc,CACvC,WAAW,EACX,QAAQ,CAAC,EAAE,EACX,IAAI,CAAC,QAAS,CAAC,EAAE,EACjB,aAAa,CACd,CAAA;QACD,OAAO,OAAO,CAAA;IAChB,CAAC;IAED,0EAA0E;IAClE,KAAK,CAAC,cAAc,CAC1B,IAAyB,EACzB,WAAmB,EACnB,OAAe;QAEf,MAAM,KAAK,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,WAAW,EAAE,OAAO,CAAC,CAAA;QACvE,IAAI,CAAC,KAAK,EAAE,WAAW;YAAE,OAAO,IAAI,CAAA;QACpC,MAAM,QAAQ,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,mBAAmB,CAAC,GAAG,CAAC,WAAW,EAAE,KAAK,CAAC,WAAW,CAAC,CAAA;QACxF,IAAI,CAAC,QAAQ;YAAE,OAAO,IAAI,CAAA;QAC1B,MAAM,IAAI,GAAG,QAAQ,CAAC,KAAK,CAAC,IAAI,CAC9B,CAAC,CAAC,EAAE,EAAE,CACJ,CAAC,CAAC,SAAS,KAAK,IAAI,CAAC,SAAS;YAC9B,CAAC,CAAC,KAAK,KAAK,kBAAkB;YAC9B,CAAC,CAAC,QAAQ,EAAE,MAAM,KAAK,SAAS,CACnC,CAAA;QACD,OAAO,IAAI,CAAC,CAAC,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,IAAI,CAAA;IACzC,CAAC;IAED;;;;;OAKG;IACH,KAAK,CAAC,QAAQ,CACZ,IAAyB,EACzB,WAAmB,EACnB,OAAe;QAEf,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,CAAA;QACnE,IAAI,MAAM,CAAC,MAAM,KAAK,QAAQ,EAAE,CAAC;YAC/B,MAAM,IAAI,aAAa,CAAC,6CAA6C,CAAC,CAAA;QACxE,CAAC;QACD,MAAM,KAAK,GAAG,WAAW,CACvB,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,WAAW,EAAE,OAAO,CAAC,EACzD,OAAO,EACP,OAAO,CACR,CAAA;QACD,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,kBAAkB,CAAC,WAAW,EAAE,KAAK,CAAC,CAAA;QACrE,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,QAAQ,CAAC,WAAW,EAAE,MAAM,CAAC,EAAE,EAAE,MAAM,CAAC,CAAA;QACnE,IAAI,OAAO,CAAC,MAAM,KAAK,cAAc;YAAE,MAAM,IAAI,CAAC,SAAS,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,CAAA;QACvF,OAAO,OAAO,CAAA;IAChB,CAAC;IAED;;;;OAIG;IACH,KAAK,CAAC,OAAO,CACX,IAAyB,EACzB,WAAmB,EACnB,OAAe;QAEf,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,CAAA;QACnE,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,gBAAgB,CAAC,WAAW,EAAE,MAAM,CAAC,EAAE,CAAC,CAAA;QACnE,MAAM,IAAI,CAAC,SAAS,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,CAAA;QAChD,OAAO,OAAO,CAAA;IAChB,CAAC;IAED;;;;;OAKG;IACH,KAAK,CAAC,eAAe,CACnB,IAAyB,EACzB,WAAmB,EACnB,OAAe,EACf,MAAyC;QAEzC,MAAM,MAAM,GAAG,MAAM,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,CAAA;QACnE,MAAM,IAAI,CAAC,IAAI,CAAC,oBAAoB,CAAC,WAAW,EAAE,OAAO,EAAE,MAAM,EAAE;YACjE,UAAU,EAAE,GAAG,EAAE,CAAC,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,MAAM,CAAC,EAAE,CAAC;YAC9D,OAAO,EAAE,GAAG,EAAE,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC;SACxD,CAAC,CAAA;QACF,sFAAsF;QACtF,OAAO,IAAI,CAAC,aAAa,CAAC,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,CAAA;IACvD,CAAC;IAED;;;;OAIG;IACK,KAAK,CAAC,SAAS,CACrB,IAAyB,EACzB,WAAmB,EACnB,OAAe;QAEf,MAAM,KAAK,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,WAAW,EAAE,OAAO,CAAC,CAAA;QACvE,IAAI,CAAC,KAAK,EAAE,WAAW;YAAE,OAAM;QAC/B,MAAM,QAAQ,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,mBAAmB,CAAC,GAAG,CAAC,WAAW,EAAE,KAAK,CAAC,WAAW,CAAC,CAAA;QACxF,IAAI,CAAC,QAAQ;YAAE,OAAM;QACrB,MAAM,GAAG,GAAG,QAAQ,CAAC,KAAK,CAAC,SAAS,CAClC,CAAC,CAAC,EAAE,EAAE,CACJ,CAAC,CAAC,SAAS,KAAK,IAAI,CAAC,SAAS;YAC9B,CAAC,CAAC,KAAK,KAAK,kBAAkB;YAC9B,CAAC,CAAC,QAAQ,EAAE,MAAM,KAAK,SAAS,CACnC,CAAA;QACD,IAAI,GAAG,KAAK,CAAC,CAAC;YAAE,OAAM;QACtB,QAAQ,CAAC,KAAK,CAAC,GAAG,CAAE,CAAC,QAAS,CAAC,MAAM,GAAG,UAAU,CAAA;QAClD,MAAM,IAAI,CAAC,IAAI,CAAC,uBAAuB,CAAC,WAAW,EAAE,QAAQ,EAAE,GAAG,CAAC,CAAA;IACrE,CAAC;CACF"}

package/dist/modules/execution/TesterController.d.ts

@@ -0,0 +1,61 @@
+import type { AgentExecutor, AgentRunResult, Block, BlockRepository, ExecutionInstance, PipelineStep } from '@cat-factory/kernel';
+import type { NotificationService } from '../notifications/NotificationService.js';
+import type { AdvanceResult } from './advance.js';
+import type { AgentContextBuilder } from './AgentContextBuilder.js';
+/** The engine collaborators the Tester gate drives (kept on the engine, injected here). */
+export interface TesterControllerDeps {
+    blockRepository: BlockRepository;
+    notificationService?: NotificationService;
+    agentExecutor: AgentExecutor;
+    contextBuilder: AgentContextBuilder;
+    /** The task's CI/test attempt budget (from the resolved merge preset). */
+    resolveMergePreset: (workspaceId: string, block: Block) => Promise<{
+        ciMaxAttempts: number;
+    }>;
+    /** Reclaim the run's finished container before dispatching the next job. */
+    stopRunContainer: (workspaceId: string, instance: ExecutionInstance) => Promise<void>;
+    persistInstance: (workspaceId: string, instance: ExecutionInstance) => Promise<void>;
+    emitInstance: (workspaceId: string, instance: ExecutionInstance) => Promise<void>;
+}
+/**
+ * Drives the Tester gate's fix loop: apply a Tester report to its step (greenlight →
+ * advance; withheld + budget left → dispatch the fixer and re-test on its completion;
+ * withheld + budget spent / unparseable → fail for a human), and re-dispatch the Tester
+ * after a fixer job finishes. Extracted out of `ExecutionService`; the shared engine writes
+ * (block reads, container reclaim, instance persistence/emit) stay on the engine and are
+ * injected via {@link TesterControllerDeps}.
+ */
+export declare class TesterController {
+    private readonly deps;
+    constructor(deps: TesterControllerDeps);
+    /**
+     * Apply a Tester report to its step's gate. Records the report on the step, then:
+     *  - greenlight → returns `null` so `recordStepResult` finishes + advances;
+     *  - withheld + budget left → dispatches the `fixer` and parks (re-tested on its
+     *    completion, see `pollAgentJob`);
+     *  - withheld + budget spent (or unparseable) → fails the run for human attention.
+     */
+    resolveTesterResult(workspaceId: string, instance: ExecutionInstance, step: PipelineStep, result: AgentRunResult): Promise<AdvanceResult | null>;
+    /**
+     * Re-dispatch the Tester after a Fixer job finished, against the (now-fixed) PR
+     * branch. Parks on the fresh Tester job; its report then drives greenlight-or-loop.
+     */
+    dispatchTester(workspaceId: string, instance: ExecutionInstance, step: PipelineStep, block: Block): Promise<AdvanceResult>;
+    /**
+     * Give up on a Tester gate that can't be greenlit. Persists the step (left
+     * un-`done`, like the CI gate — never falsely completed), raises a human-actionable
+     * `test_failed` notification, and fails the run for human attention. Returns the
+     * `job_failed` result the driver propagates.
+     */
+    private failTester;
+    /** Raise a `test_failed` notification when the Tester gate gives up. */
+    private raiseTestFailed;
+    /**
+     * Dispatch a `fixer` container job for a Tester step that withheld its greenlight:
+     * build the agent context with the kind overridden to `fixer` and the Tester's
+     * report folded in as resolved context, park on the job, and flip the gate to
+     * `fixing`. On the fixer's completion `pollAgentJob` re-dispatches the Tester.
+     */
+    private dispatchFixer;
+}
+//# sourceMappingURL=TesterController.d.ts.map

package/dist/modules/execution/TesterController.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"TesterController.d.ts","sourceRoot":"","sources":["../../../src/modules/execution/TesterController.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,aAAa,EAEb,cAAc,EACd,KAAK,EACL,eAAe,EACf,iBAAiB,EACjB,YAAY,EACb,MAAM,qBAAqB,CAAA;AAI5B,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,yCAAyC,CAAA;AAClF,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,cAAc,CAAA;AACjD,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,0BAA0B,CAAA;AA4CnE,2FAA2F;AAC3F,MAAM,WAAW,oBAAoB;IACnC,eAAe,EAAE,eAAe,CAAA;IAChC,mBAAmB,CAAC,EAAE,mBAAmB,CAAA;IACzC,aAAa,EAAE,aAAa,CAAA;IAC5B,cAAc,EAAE,mBAAmB,CAAA;IACnC,0EAA0E;IAC1E,kBAAkB,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,KAAK,EAAE,KAAK,KAAK,OAAO,CAAC;QAAE,aAAa,EAAE,MAAM,CAAA;KAAE,CAAC,CAAA;IAC7F,4EAA4E;IAC5E,gBAAgB,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,iBAAiB,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;IACrF,eAAe,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,iBAAiB,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;IACpF,YAAY,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,iBAAiB,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;CAClF;AAED;;;;;;;GAOG;AACH,qBAAa,gBAAgB;IACf,OAAO,CAAC,QAAQ,CAAC,IAAI;IAAjC,YAA6B,IAAI,EAAE,oBAAoB,EAAI;IAE3D;;;;;;OAMG;IACG,mBAAmB,CACvB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,iBAAiB,EAC3B,IAAI,EAAE,YAAY,EAClB,MAAM,EAAE,cAAc,GACrB,OAAO,CAAC,aAAa,GAAG,IAAI,CAAC,CA+D/B;IAED;;;OAGG;IACG,cAAc,CAClB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,iBAAiB,EAC3B,IAAI,EAAE,YAAY,EAClB,KAAK,EAAE,KAAK,GACX,OAAO,CAAC,aAAa,CAAC,CAsBxB;IAED;;;;;OAKG;YACW,UAAU;IAkBxB,wEAAwE;YAC1D,eAAe;IAuB7B;;;;;OAKG;YACW,aAAa;CA0D5B"}

package/dist/modules/execution/TesterController.js

@@ -0,0 +1,215 @@
+import { DEFAULT_MERGE_PRESET, isAsyncAgentExecutor } from '@cat-factory/kernel';
+import { parseTestReport } from '@cat-factory/contracts';
+import { FIXER_AGENT_KIND, TESTER_AGENT_KIND } from './ci.logic.js';
+/** Whether a Tester report raised any concern serious enough to block a release. */
+function hasBlockingConcerns(report) {
+    return report.concerns.some((c) => c.severity === 'high' || c.severity === 'critical');
+}
+/**
+ * The engine's release verdict for a Tester report: greenlit only when the Tester
+ * said so AND it raised no blocking (high/critical) concern. Defensive against a
+ * harness that greenlights with open blockers — low/medium concerns are advisory
+ * and do not, on their own, withhold the greenlight or loop the fixer.
+ */
+function isGreenlit(report) {
+    return report.greenlight === true && !hasBlockingConcerns(report);
+}
+/** One-line, human-readable summary of a Tester report's concerns, for failure messages. */
+function describeTestConcerns(report) {
+    if (!report.concerns.length)
+        return report.summary || 'No greenlight given.';
+    const names = report.concerns
+        .map((c) => `${c.title} (${c.severity})`)
+        .slice(0, 5)
+        .join(', ');
+    return `Concerns: ${names}${report.concerns.length > 5 ? ', …' : ''}`;
+}
+/** Render a Tester report as the resolved-context block handed to the fixer. */
+function renderReportForFixer(report) {
+    const lines = ['Tester report — fix the concerns below, then the tester will re-run.', ''];
+    if (report.summary)
+        lines.push(report.summary, '');
+    if (report.concerns.length) {
+        lines.push('Concerns to fix:');
+        for (const c of report.concerns)
+            lines.push(`- [${c.severity}] ${c.title}: ${c.detail}`);
+        lines.push('');
+    }
+    const failed = report.outcomes.filter((o) => o.status === 'failed');
+    if (failed.length) {
+        lines.push('Failed checks:');
+        for (const o of failed)
+            lines.push(`- ${o.name}${o.detail ? `: ${o.detail}` : ''}`);
+    }
+    return lines.join('\n').trim();
+}
+/**
+ * Drives the Tester gate's fix loop: apply a Tester report to its step (greenlight →
+ * advance; withheld + budget left → dispatch the fixer and re-test on its completion;
+ * withheld + budget spent / unparseable → fail for a human), and re-dispatch the Tester
+ * after a fixer job finishes. Extracted out of `ExecutionService`; the shared engine writes
+ * (block reads, container reclaim, instance persistence/emit) stay on the engine and are
+ * injected via {@link TesterControllerDeps}.
+ */
+export class TesterController {
+    deps;
+    constructor(deps) {
+        this.deps = deps;
+    }
+    /**
+     * Apply a Tester report to its step's gate. Records the report on the step, then:
+     *  - greenlight → returns `null` so `recordStepResult` finishes + advances;
+     *  - withheld + budget left → dispatches the `fixer` and parks (re-tested on its
+     *    completion, see `pollAgentJob`);
+     *  - withheld + budget spent (or unparseable) → fails the run for human attention.
+     */
+    async resolveTesterResult(workspaceId, instance, step, result) {
+        const block = await this.deps.blockRepository.get(workspaceId, instance.blockId);
+        let report = null;
+        try {
+            report = parseTestReport(result.testReport);
+        }
+        catch {
+            report = null;
+        }
+        if (!step.test) {
+            const maxAttempts = block
+                ? (await this.deps.resolveMergePreset(workspaceId, block)).ciMaxAttempts
+                : DEFAULT_MERGE_PRESET.ciMaxAttempts;
+            step.test = { phase: 'testing', attempts: 0, maxAttempts, lastReport: null };
+        }
+        if (report)
+            step.test.lastReport = report;
+        step.test.phase = 'testing';
+        step.subtasks = undefined;
+        // An unparseable report can't gate a release — fail loudly rather than silently
+        // greenlighting or looping forever.
+        if (!report) {
+            return this.failTester(workspaceId, instance, step, block, result.output ?? 'Tester returned an unparseable report.', 'Tester returned an unparseable test report.', step.test.attempts);
+        }
+        // The FIRST testing round always loops the fixer when the report flags ANYTHING — any
+        // concern (regardless of severity) or a withheld greenlight — so the first batch of
+        // findings is always handed to the fixer. From the SECOND round onward the normal
+        // threshold applies (`isGreenlit`: a greenlight stands unless a high/critical concern
+        // is open; low/medium concerns are advisory). The defensive greenlight+no-blocker
+        // check still protects every round against a harness that greenlights with blockers.
+        const firstRound = step.test.attempts === 0;
+        const accepted = firstRound
+            ? report.greenlight === true && report.concerns.length === 0
+            : isGreenlit(report);
+        if (accepted)
+            return null;
+        // Withheld greenlight: loop the fixer if any budget remains, else give up.
+        const executor = this.deps.agentExecutor;
+        if (isAsyncAgentExecutor(executor) && block && step.test.attempts < step.test.maxAttempts) {
+            // Reclaim the finished Tester container before dispatching the Fixer so the
+            // next job boots fresh — the per-run container would otherwise re-attach to the
+            // completed Tester job (idempotent dispatch by run id), replaying its result.
+            await this.deps.stopRunContainer(workspaceId, instance);
+            return this.dispatchFixer(workspaceId, instance, step, block, report);
+        }
+        // Budget spent (or no async executor to fix with): give up for human attention.
+        return this.failTester(workspaceId, instance, step, block, report.summary || 'Tester withheld its greenlight.', `Tester withheld its greenlight after ${step.test.attempts} fix attempt(s). ${describeTestConcerns(report)}`.trim(), step.test.attempts);
+    }
+    /**
+     * Re-dispatch the Tester after a Fixer job finished, against the (now-fixed) PR
+     * branch. Parks on the fresh Tester job; its report then drives greenlight-or-loop.
+     */
+    async dispatchTester(workspaceId, instance, step, block) {
+        const executor = this.deps.agentExecutor;
+        if (!isAsyncAgentExecutor(executor)) {
+            return { kind: 'job_failed', error: 'No async executor available to run the tester.' };
+        }
+        const isFinalStep = instance.currentStep === instance.steps.length - 1;
+        const context = await this.deps.contextBuilder.buildContext(workspaceId, instance, step, isFinalStep, block);
+        const handle = await executor.startJob(context);
+        step.jobId = handle.jobId;
+        if (handle.model)
+            step.model = handle.model;
+        step.startingContainer = true;
+        step.subtasks = undefined;
+        if (step.test)
+            step.test.phase = 'testing';
+        await this.deps.persistInstance(workspaceId, instance);
+        await this.deps.emitInstance(workspaceId, instance);
+        return { kind: 'awaiting_job', jobId: step.jobId, stepIndex: instance.currentStep };
+    }
+    /**
+     * Give up on a Tester gate that can't be greenlit. Persists the step (left
+     * un-`done`, like the CI gate — never falsely completed), raises a human-actionable
+     * `test_failed` notification, and fails the run for human attention. Returns the
+     * `job_failed` result the driver propagates.
+     */
+    async failTester(workspaceId, instance, step, block, output, error, attempts) {
+        step.output = output;
+        await this.deps.persistInstance(workspaceId, instance);
+        await this.raiseTestFailed(workspaceId, instance, block, error, attempts);
+        // Carry the precise classification (`agent`, not the generic container `job_failed`)
+        // and the Tester's own summary to the driver's single `failRun` funnel; failing the
+        // run here too would let the driver's second `failRun` clobber it.
+        return { kind: 'job_failed', failureKind: 'agent', error, detail: output || undefined };
+    }
+    /** Raise a `test_failed` notification when the Tester gate gives up. */
+    async raiseTestFailed(workspaceId, instance, block, summary, attempts) {
+        if (!this.deps.notificationService || !block)
+            return;
+        await this.deps.notificationService.raise(workspaceId, {
+            type: 'test_failed',
+            blockId: block.id,
+            executionId: instance.id,
+            title: `Tests are still failing for "${block.title}"`,
+            body: `The Fixer agent tried ${attempts} time(s) but the Tester still won't greenlight. ${summary} ` +
+                `Take a look and retry the run once fixed.`,
+            payload: {
+                ...(block.pullRequest?.url ? { prUrl: block.pullRequest.url } : {}),
+                pipelineName: instance.pipelineName,
+            },
+        });
+    }
+    /**
+     * Dispatch a `fixer` container job for a Tester step that withheld its greenlight:
+     * build the agent context with the kind overridden to `fixer` and the Tester's
+     * report folded in as resolved context, park on the job, and flip the gate to
+     * `fixing`. On the fixer's completion `pollAgentJob` re-dispatches the Tester.
+     */
+    async dispatchFixer(workspaceId, instance, step, block, report) {
+        const executor = this.deps.agentExecutor;
+        if (!isAsyncAgentExecutor(executor)) {
+            return { kind: 'job_failed', error: 'No async executor available to fix test failures.' };
+        }
+        // The fixer pushes its commits onto the implementation PR branch, so it can only
+        // run once a coder/integrator step opened one. A Tester-only pipeline (or one whose
+        // earlier step never produced a PR) can't be auto-fixed — fail cleanly with the
+        // report instead of letting the job-body builder throw out of the advance.
+        if (!block.pullRequest?.branch) {
+            return this.failTester(workspaceId, instance, step, block, report.summary || 'Tester withheld its greenlight.', `Tester withheld its greenlight and there is no PR branch for the fixer to push to. ${describeTestConcerns(report)}`.trim(), step.test?.attempts ?? 0);
+        }
+        const isFinalStep = instance.currentStep === instance.steps.length - 1;
+        const base = await this.deps.contextBuilder.buildContext(workspaceId, instance, step, isFinalStep, block);
+        const context = {
+            ...base,
+            agentKind: FIXER_AGENT_KIND,
+            // Hand the fixer the Tester's report (what failed + the concerns) as context.
+            priorOutputs: [
+                ...base.priorOutputs,
+                { agentKind: TESTER_AGENT_KIND, output: renderReportForFixer(report) },
+            ],
+        };
+        const handle = await executor.startJob(context);
+        step.jobId = handle.jobId;
+        if (handle.model)
+            step.model = handle.model;
+        step.startingContainer = true;
+        step.subtasks = undefined;
+        step.test = {
+            phase: 'fixing',
+            attempts: (step.test?.attempts ?? 0) + 1,
+            maxAttempts: step.test?.maxAttempts ?? DEFAULT_MERGE_PRESET.ciMaxAttempts,
+            lastReport: report,
+        };
+        await this.deps.persistInstance(workspaceId, instance);
+        await this.deps.emitInstance(workspaceId, instance);
+        return { kind: 'awaiting_job', jobId: step.jobId, stepIndex: instance.currentStep };
+    }
+}
+//# sourceMappingURL=TesterController.js.map

package/dist/modules/execution/TesterController.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"TesterController.js","sourceRoot":"","sources":["../../../src/modules/execution/TesterController.ts"],"names":[],"mappings":"AASA,OAAO,EAAE,oBAAoB,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAA;AAChF,OAAO,EAAmB,eAAe,EAAE,MAAM,wBAAwB,CAAA;AACzE,OAAO,EAAE,gBAAgB,EAAE,iBAAiB,EAAE,MAAM,eAAe,CAAA;AAKnE,oFAAoF;AACpF,SAAS,mBAAmB,CAAC,MAAkB;IAC7C,OAAO,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,MAAM,IAAI,CAAC,CAAC,QAAQ,KAAK,UAAU,CAAC,CAAA;AACxF,CAAC;AAED;;;;;GAKG;AACH,SAAS,UAAU,CAAC,MAAkB;IACpC,OAAO,MAAM,CAAC,UAAU,KAAK,IAAI,IAAI,CAAC,mBAAmB,CAAC,MAAM,CAAC,CAAA;AACnE,CAAC;AAED,4FAA4F;AAC5F,SAAS,oBAAoB,CAAC,MAAkB;IAC9C,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM;QAAE,OAAO,MAAM,CAAC,OAAO,IAAI,sBAAsB,CAAA;IAC5E,MAAM,KAAK,GAAG,MAAM,CAAC,QAAQ;SAC1B,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,GAAG,CAAC,CAAC,KAAK,KAAK,CAAC,CAAC,QAAQ,GAAG,CAAC;SACxC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC;SACX,IAAI,CAAC,IAAI,CAAC,CAAA;IACb,OAAO,aAAa,KAAK,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAA;AACvE,CAAC;AAED,gFAAgF;AAChF,SAAS,oBAAoB,CAAC,MAAkB;IAC9C,MAAM,KAAK,GAAG,CAAC,sEAAsE,EAAE,EAAE,CAAC,CAAA;IAC1F,IAAI,MAAM,CAAC,OAAO;QAAE,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,OAAO,EAAE,EAAE,CAAC,CAAA;IAClD,IAAI,MAAM,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC;QAC3B,KAAK,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAA;QAC9B,KAAK,MAAM,CAAC,IAAI,MAAM,CAAC,QAAQ;YAAE,KAAK,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,QAAQ,KAAK,CAAC,CAAC,KAAK,KAAK,CAAC,CAAC,MAAM,EAAE,CAAC,CAAA;QACxF,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IAChB,CAAC;IACD,MAAM,MAAM,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAA;IACnE,IAAI,MAAM,CAAC,MAAM,EAAE,CAAC;QAClB,KAAK,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAA;QAC5B,KAAK,MAAM,CAAC,IAAI,MAAM;YAAE,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,GAAG,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAA;IACrF,CAAC;IACD,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,CAAA;AAChC,CAAC;AAgBD;;;;;;;GAOG;AACH,MAAM,OAAO,gBAAgB;IACE,IAAI;IAAjC,YAA6B,IAA0B;oBAA1B,IAAI;IAAyB,CAAC;IAE3D;;;;;;OAMG;IACH,KAAK,CAAC,mBAAmB,CACvB,WAAmB,EACnB,QAA2B,EAC3B,IAAkB,EAClB,MAAsB;QAEtB,MAAM,KAAK,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,GAAG,CAAC,WAAW,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAA;QAChF,IAAI,MAAM,GAAsB,IAAI,CAAA;QACpC,IAAI,CAAC;YACH,MAAM,GAAG,eAAe,CAAC,MAAM,CAAC,UAAU,CAAC,CAAA;QAC7C,CAAC;QAAC,MAAM,CAAC;YACP,MAAM,GAAG,IAAI,CAAA;QACf,CAAC;QACD,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC;YACf,MAAM,WAAW,GAAG,KAAK;gBACvB,CAAC,CAAC,CAAC,MAAM,IAAI,CAAC,IAAI,CAAC,kBAAkB,CAAC,WAAW,EAAE,KAAK,CAAC,CAAC,CAAC,aAAa;gBACxE,CAAC,CAAC,oBAAoB,CAAC,aAAa,CAAA;YACtC,IAAI,CAAC,IAAI,GAAG,EAAE,KAAK,EAAE,SAAS,EAAE,QAAQ,EAAE,CAAC,EAAE,WAAW,EAAE,UAAU,EAAE,IAAI,EAAE,CAAA;QAC9E,CAAC;QACD,IAAI,MAAM;YAAE,IAAI,CAAC,IAAI,CAAC,UAAU,GAAG,MAAM,CAAA;QACzC,IAAI,CAAC,IAAI,CAAC,KAAK,GAAG,SAAS,CAAA;QAC3B,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAA;QAEzB,gFAAgF;QAChF,oCAAoC;QACpC,IAAI,CAAC,MAAM,EAAE,CAAC;YACZ,OAAO,IAAI,CAAC,UAAU,CACpB,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,KAAK,EACL,MAAM,CAAC,MAAM,IAAI,wCAAwC,EACzD,6CAA6C,EAC7C,IAAI,CAAC,IAAI,CAAC,QAAQ,CACnB,CAAA;QACH,CAAC;QAED,sFAAsF;QACtF,oFAAoF;QACpF,kFAAkF;QAClF,sFAAsF;QACtF,kFAAkF;QAClF,qFAAqF;QACrF,MAAM,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,QAAQ,KAAK,CAAC,CAAA;QAC3C,MAAM,QAAQ,GAAG,UAAU;YACzB,CAAC,CAAC,MAAM,CAAC,UAAU,KAAK,IAAI,IAAI,MAAM,CAAC,QAAQ,CAAC,MAAM,KAAK,CAAC;YAC5D,CAAC,CAAC,UAAU,CAAC,MAAM,CAAC,CAAA;QACtB,IAAI,QAAQ;YAAE,OAAO,IAAI,CAAA;QAEzB,2EAA2E;QAC3E,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,CAAA;QACxC,IAAI,oBAAoB,CAAC,QAAQ,CAAC,IAAI,KAAK,IAAI,IAAI,CAAC,IAAI,CAAC,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC;YAC1F,4EAA4E;YAC5E,gFAAgF;YAChF,8EAA8E;YAC9E,MAAM,IAAI,CAAC,IAAI,CAAC,gBAAgB,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;YACvD,OAAO,IAAI,CAAC,aAAa,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,MAAM,CAAC,CAAA;QACvE,CAAC;QACD,gFAAgF;QAChF,OAAO,IAAI,CAAC,UAAU,CACpB,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,KAAK,EACL,MAAM,CAAC,OAAO,IAAI,iCAAiC,EACnD,wCAAwC,IAAI,CAAC,IAAI,CAAC,QAAQ,oBAAoB,oBAAoB,CAAC,MAAM,CAAC,EAAE,CAAC,IAAI,EAAE,EACnH,IAAI,CAAC,IAAI,CAAC,QAAQ,CACnB,CAAA;IACH,CAAC;IAED;;;OAGG;IACH,KAAK,CAAC,cAAc,CAClB,WAAmB,EACnB,QAA2B,EAC3B,IAAkB,EAClB,KAAY;QAEZ,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,CAAA;QACxC,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAAC;YACpC,OAAO,EAAE,IAAI,EAAE,YAAY,EAAE,KAAK,EAAE,gDAAgD,EAAE,CAAA;QACxF,CAAC;QACD,MAAM,WAAW,GAAG,QAAQ,CAAC,WAAW,KAAK,QAAQ,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAA;QACtE,MAAM,OAAO,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,cAAc,CAAC,YAAY,CACzD,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,WAAW,EACX,KAAK,CACN,CAAA;QACD,MAAM,MAAM,GAAG,MAAM,QAAQ,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAA;QAC/C,IAAI,CAAC,KAAK,GAAG,MAAM,CAAC,KAAK,CAAA;QACzB,IAAI,MAAM,CAAC,KAAK;YAAE,IAAI,CAAC,KAAK,GAAG,MAAM,CAAC,KAAK,CAAA;QAC3C,IAAI,CAAC,iBAAiB,GAAG,IAAI,CAAA;QAC7B,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAA;QACzB,IAAI,IAAI,CAAC,IAAI;YAAE,IAAI,CAAC,IAAI,CAAC,KAAK,GAAG,SAAS,CAAA;QAC1C,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACtD,MAAM,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACnD,OAAO,EAAE,IAAI,EAAE,cAAc,EAAE,KAAK,EAAE,IAAI,CAAC,KAAK,EAAE,SAAS,EAAE,QAAQ,CAAC,WAAW,EAAE,CAAA;IACrF,CAAC;IAED;;;;;OAKG;IACK,KAAK,CAAC,UAAU,CACtB,WAAmB,EACnB,QAA2B,EAC3B,IAAkB,EAClB,KAAmB,EACnB,MAAc,EACd,KAAa,EACb,QAAgB;QAEhB,IAAI,CAAC,MAAM,GAAG,MAAM,CAAA;QACpB,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACtD,MAAM,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,QAAQ,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,CAAC,CAAA;QACzE,qFAAqF;QACrF,oFAAoF;QACpF,mEAAmE;QACnE,OAAO,EAAE,IAAI,EAAE,YAAY,EAAE,WAAW,EAAE,OAAO,EAAE,KAAK,EAAE,MAAM,EAAE,MAAM,IAAI,SAAS,EAAE,CAAA;IACzF,CAAC;IAED,wEAAwE;IAChE,KAAK,CAAC,eAAe,CAC3B,WAAmB,EACnB,QAA2B,EAC3B,KAAmB,EACnB,OAAe,EACf,QAAgB;QAEhB,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,mBAAmB,IAAI,CAAC,KAAK;YAAE,OAAM;QACpD,MAAM,IAAI,CAAC,IAAI,CAAC,mBAAmB,CAAC,KAAK,CAAC,WAAW,EAAE;YACrD,IAAI,EAAE,aAAa;YACnB,OAAO,EAAE,KAAK,CAAC,EAAE;YACjB,WAAW,EAAE,QAAQ,CAAC,EAAE;YACxB,KAAK,EAAE,gCAAgC,KAAK,CAAC,KAAK,GAAG;YACrD,IAAI,EACF,yBAAyB,QAAQ,mDAAmD,OAAO,GAAG;gBAC9F,2CAA2C;YAC7C,OAAO,EAAE;gBACP,GAAG,CAAC,KAAK,CAAC,WAAW,EAAE,GAAG,CAAC,CAAC,CAAC,EAAE,KAAK,EAAE,KAAK,CAAC,WAAW,CAAC,GAAG,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;gBACnE,YAAY,EAAE,QAAQ,CAAC,YAAY;aACpC;SACF,CAAC,CAAA;IACJ,CAAC;IAED;;;;;OAKG;IACK,KAAK,CAAC,aAAa,CACzB,WAAmB,EACnB,QAA2B,EAC3B,IAAkB,EAClB,KAAY,EACZ,MAAkB;QAElB,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,aAAa,CAAA;QACxC,IAAI,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAAC;YACpC,OAAO,EAAE,IAAI,EAAE,YAAY,EAAE,KAAK,EAAE,mDAAmD,EAAE,CAAA;QAC3F,CAAC;QACD,iFAAiF;QACjF,oFAAoF;QACpF,gFAAgF;QAChF,2EAA2E;QAC3E,IAAI,CAAC,KAAK,CAAC,WAAW,EAAE,MAAM,EAAE,CAAC;YAC/B,OAAO,IAAI,CAAC,UAAU,CACpB,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,KAAK,EACL,MAAM,CAAC,OAAO,IAAI,iCAAiC,EACnD,sFAAsF,oBAAoB,CAAC,MAAM,CAAC,EAAE,CAAC,IAAI,EAAE,EAC3H,IAAI,CAAC,IAAI,EAAE,QAAQ,IAAI,CAAC,CACzB,CAAA;QACH,CAAC;QACD,MAAM,WAAW,GAAG,QAAQ,CAAC,WAAW,KAAK,QAAQ,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAA;QACtE,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,IAAI,CAAC,cAAc,CAAC,YAAY,CACtD,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,WAAW,EACX,KAAK,CACN,CAAA;QACD,MAAM,OAAO,GAAoB;YAC/B,GAAG,IAAI;YACP,SAAS,EAAE,gBAAgB;YAC3B,8EAA8E;YAC9E,YAAY,EAAE;gBACZ,GAAG,IAAI,CAAC,YAAY;gBACpB,EAAE,SAAS,EAAE,iBAAiB,EAAE,MAAM,EAAE,oBAAoB,CAAC,MAAM,CAAC,EAAE;aACvE;SACF,CAAA;QACD,MAAM,MAAM,GAAG,MAAM,QAAQ,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAA;QAC/C,IAAI,CAAC,KAAK,GAAG,MAAM,CAAC,KAAK,CAAA;QACzB,IAAI,MAAM,CAAC,KAAK;YAAE,IAAI,CAAC,KAAK,GAAG,MAAM,CAAC,KAAK,CAAA;QAC3C,IAAI,CAAC,iBAAiB,GAAG,IAAI,CAAA;QAC7B,IAAI,CAAC,QAAQ,GAAG,SAAS,CAAA;QACzB,IAAI,CAAC,IAAI,GAAG;YACV,KAAK,EAAE,QAAQ;YACf,QAAQ,EAAE,CAAC,IAAI,CAAC,IAAI,EAAE,QAAQ,IAAI,CAAC,CAAC,GAAG,CAAC;YACxC,WAAW,EAAE,IAAI,CAAC,IAAI,EAAE,WAAW,IAAI,oBAAoB,CAAC,aAAa;YACzE,UAAU,EAAE,MAAM;SACnB,CAAA;QACD,MAAM,IAAI,CAAC,IAAI,CAAC,eAAe,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACtD,MAAM,IAAI,CAAC,IAAI,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,CAAC,CAAA;QACnD,OAAO,EAAE,IAAI,EAAE,cAAc,EAAE,KAAK,EAAE,IAAI,CAAC,KAAK,EAAE,SAAS,EAAE,QAAQ,CAAC,WAAW,EAAE,CAAA;IACrF,CAAC;CACF"}