@cat-factory/orchestration 0.251.0 → 0.253.0

package/dist/modules/execution/toolServers.logic.js.map

@@ -1 +1 @@
-{"version":3,"file":"toolServers.logic.js","sourceRoot":"","sources":["../../../src/modules/execution/toolServers.logic.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,0BAA0B,EAAE,MAAM,wBAAwB,CAAA;AAGnE,0FAA0F;AAC1F,2FAA2F;AAC3F,EAAE;AACF,kGAAkG;AAClG,gGAAgG;AAChG,gGAAgG;AAChG,gGAAgG;AAChG,+FAA+F;AAC/F,wCAAwC;AAExC;;;;;;;;;;;;;;;;;;;GAmBG;AACH,MAAM,UAAU,wBAAwB,CAAC,IAAkB,EAAE,GAAY;IACvE,MAAM,MAAM,GAAG,IAAI,CAAC,WAAW,CAAA;IAC/B,IAAI,CAAC,MAAM;QAAE,OAAO,KAAK,CAAA;IACzB,MAAM,QAAQ,GAAG,yBAAyB,CAAC,GAAG,CAAC,CAAA;IAC/C,IAAI,CAAC,QAAQ;QAAE,OAAO,KAAK,CAAA;IAC3B,IAAI,eAAe,CAAC,MAAM,CAAC,QAAQ,EAAE,QAAQ,CAAC;QAAE,OAAO,KAAK,CAAA;IAC5D,IAAI,CAAC,WAAW,GAAG,EAAE,GAAG,MAAM,EAAE,QAAQ,EAAE,CAAA;IAC1C,OAAO,IAAI,CAAA;AACb,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,yBAAyB,CAAC,GAAY;IACpD,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC;QAAE,OAAO,IAAI,CAAA;IACpC,MAAM,QAAQ,GAAyB,EAAE,CAAA;IACzC,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAA;IAC9B,KAAK,MAAM,KAAK,IAAI,GAAG,EAAE,CAAC;QACxB,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI;YAAE,SAAQ;QACzD,MAAM,MAAM,GAAG,KAAgC,CAAA;QAC/C,MAAM,EAAE,GAAG,MAAM,CAAC,EAAE,CAAA;QACpB,IAAI,OAAO,EAAE,KAAK,QAAQ,IAAI,EAAE,KAAK,EAAE,IAAI,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;YAAE,SAAQ;QACjE,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,CAAA;QACZ,MAAM,SAAS,GAAG,MAAM,CAAC,SAAS,CAAA;QAClC,QAAQ,CAAC,IAAI,CAAC;YACZ,EAAE;YACF,MAAM,EAAE,oBAAoB,CAAC,MAAM,CAAC,MAAM,CAAC;YAC3C,sFAAsF;YACtF,qFAAqF;YACrF,2DAA2D;YAC3D,GAAG,CAAC,OAAO,SAAS,KAAK,QAAQ,IAAI,MAAM,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,SAAS,IAAI,CAAC;gBAC/E,CAAC,CAAC,EAAE,SAAS,EAAE;gBACf,CAAC,CAAC,EAAE,CAAC;SACR,CAAC,CAAA;IACJ,CAAC;IACD,OAAO,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAA;AAC1C,CAAC;AAED,oFAAoF;AACpF,SAAS,oBAAoB,CAAC,GAAY;IACxC,OAAO,0BAA0B,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,SAAS,CAAA;AAC1D,CAAC;AAED;;;;GAIG;AACH,SAAS,eAAe,CACtB,QAAmD,EACnD,IAAmC;IAEnC,IAAI,CAAC,QAAQ,IAAI,QAAQ,CAAC,MAAM,KAAK,IAAI,CAAC,MAAM;QAAE,OAAO,KAAK,CAAA;IAC9D,OAAO,QAAQ,CAAC,KAAK,CAAC,CAAC,MAAM,EAAE,KAAK,EAAE,EAAE;QACtC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAE,CAAA;QAC1B,OAAO,CACL,MAAM,CAAC,EAAE,KAAK,KAAK,CAAC,EAAE;YACtB,MAAM,CAAC,MAAM,KAAK,KAAK,CAAC,MAAM;YAC9B,MAAM,CAAC,SAAS,KAAK,KAAK,CAAC,SAAS,CACrC,CAAA;IACH,CAAC,CAAC,CAAA;AACJ,CAAC"}
+{"version":3,"file":"toolServers.logic.js","sourceRoot":"","sources":["../../../src/modules/execution/toolServers.logic.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,0BAA0B,EAAE,MAAM,wBAAwB,CAAA;AAGnE,0FAA0F;AAC1F,2FAA2F;AAC3F,EAAE;AACF,kGAAkG;AAClG,gGAAgG;AAChG,gGAAgG;AAChG,gGAAgG;AAChG,+FAA+F;AAC/F,wCAAwC;AAExC;;;;;;;;;;;;;;;;;;;;;;GAsBG;AACH,MAAM,UAAU,wBAAwB,CAAC,IAAkB,EAAE,GAAY;IACvE,MAAM,MAAM,GAAG,IAAI,CAAC,WAAW,CAAA;IAC/B,IAAI,CAAC,MAAM;QAAE,OAAO,KAAK,CAAA;IACzB,MAAM,QAAQ,GAAG,yBAAyB,CAAC,GAAG,CAAC,CAAA;IAC/C,IAAI,CAAC,QAAQ;QAAE,OAAO,KAAK,CAAA;IAC3B,IAAI,eAAe,CAAC,MAAM,CAAC,QAAQ,EAAE,QAAQ,CAAC;QAAE,OAAO,KAAK,CAAA;IAC5D,IAAI,CAAC,WAAW,GAAG,EAAE,GAAG,MAAM,EAAE,QAAQ,EAAE,CAAA;IAC1C,OAAO,IAAI,CAAA;AACb,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,yBAAyB,CAAC,GAAY;IACpD,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC;QAAE,OAAO,IAAI,CAAA;IACpC,MAAM,QAAQ,GAAyB,EAAE,CAAA;IACzC,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAA;IAC9B,KAAK,MAAM,KAAK,IAAI,GAAG,EAAE,CAAC;QACxB,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI;YAAE,SAAQ;QACzD,MAAM,MAAM,GAAG,KAAgC,CAAA;QAC/C,MAAM,EAAE,GAAG,MAAM,CAAC,EAAE,CAAA;QACpB,IAAI,OAAO,EAAE,KAAK,QAAQ,IAAI,EAAE,KAAK,EAAE,IAAI,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;YAAE,SAAQ;QACjE,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,CAAA;QACZ,MAAM,SAAS,GAAG,MAAM,CAAC,SAAS,CAAA;QAClC,QAAQ,CAAC,IAAI,CAAC;YACZ,EAAE;YACF,MAAM,EAAE,oBAAoB,CAAC,MAAM,CAAC,MAAM,CAAC;YAC3C,sFAAsF;YACtF,qFAAqF;YACrF,2DAA2D;YAC3D,GAAG,CAAC,OAAO,SAAS,KAAK,QAAQ,IAAI,MAAM,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,SAAS,IAAI,CAAC;gBAC/E,CAAC,CAAC,EAAE,SAAS,EAAE;gBACf,CAAC,CAAC,EAAE,CAAC;SACR,CAAC,CAAA;IACJ,CAAC;IACD,OAAO,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAA;AAC1C,CAAC;AAED,oFAAoF;AACpF,SAAS,oBAAoB,CAAC,GAAY;IACxC,OAAO,0BAA0B,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,SAAS,CAAA;AAC1D,CAAC;AAED;;;;GAIG;AACH,SAAS,eAAe,CACtB,QAAmD,EACnD,IAAmC;IAEnC,IAAI,CAAC,QAAQ,IAAI,QAAQ,CAAC,MAAM,KAAK,IAAI,CAAC,MAAM;QAAE,OAAO,KAAK,CAAA;IAC9D,OAAO,QAAQ,CAAC,KAAK,CAAC,CAAC,MAAM,EAAE,KAAK,EAAE,EAAE;QACtC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAE,CAAA;QAC1B,OAAO,CACL,MAAM,CAAC,EAAE,KAAK,KAAK,CAAC,EAAE;YACtB,MAAM,CAAC,MAAM,KAAK,KAAK,CAAC,MAAM;YAC9B,MAAM,CAAC,SAAS,KAAK,KAAK,CAAC,SAAS,CACrC,CAAA;IACH,CAAC,CAAC,CAAA;AACJ,CAAC"}

package/dist/validation/validateBinaryGenerators.d.ts

@@ -0,0 +1,24 @@
+import type { BinaryGeneratorRegistry } from '@cat-factory/kernel';
+import type { RegistrationProblem } from './validateRegistrations.js';
+/**
+ * Section 9 of `collectRegistrationProblems`: every generative binary integration a deployment
+ * registers must be a definition the platform can actually dispatch against.
+ *
+ * Its own module rather than more of `validateRegistrations.ts` because the section is a cohesive
+ * concern with a growing rule set, and its host had reached the file-size ratchet.
+ *
+ * Boot is the only place these can be caught. There is no write boundary that ever refused them
+ * (they are code), and every failure below is silent at run time in the same expensive way: a
+ * malformed definition or an unparseable contract becomes an integration the brief describes with
+ * no operations, a credential key that is not a valid environment-variable name is dropped by the
+ * harness's env validation and reappears as an unexplained 401 mid-run, and a cleartext endpoint
+ * puts that credential on the wire from inside the run container. Each of those costs a run to
+ * discover and names nothing that points back at the registration.
+ *
+ * A declared MEDIA TYPE that contradicts the declared modalities is an error too, not a warning:
+ * both halves drive selection (a step's content-type coverage is checked against `modalities`,
+ * while the brief tells the agent the `mediaTypes`), so an integration claiming `audio` while
+ * listing `image/png` will be picked for one job and asked to do the other.
+ */
+export declare function checkBinaryGenerators(registry: BinaryGeneratorRegistry | undefined): RegistrationProblem[];
+//# sourceMappingURL=validateBinaryGenerators.d.ts.map

package/dist/validation/validateBinaryGenerators.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"validateBinaryGenerators.d.ts","sourceRoot":"","sources":["../../src/validation/validateBinaryGenerators.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,uBAAuB,EAAE,MAAM,qBAAqB,CAAA;AAelE,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAA;AAErE;;;;;;;;;;;;;;;;;;;GAmBG;AACH,wBAAgB,qBAAqB,CACnC,QAAQ,EAAE,uBAAuB,GAAG,SAAS,GAC5C,mBAAmB,EAAE,CAqBvB"}

package/dist/validation/validateBinaryGenerators.js

@@ -0,0 +1,138 @@
+import { describeFoundationalProblem, isAllowedMcpHttpUrl, validateFoundationalDefinition, } from '@cat-factory/kernel';
+import { binaryCredentialInjectionName, binaryGeneratorDefinitionIssues, comparableCredentialInjectionName, modalitiesOfMediaType, } from '@cat-factory/contracts';
+/**
+ * Section 9 of `collectRegistrationProblems`: every generative binary integration a deployment
+ * registers must be a definition the platform can actually dispatch against.
+ *
+ * Its own module rather than more of `validateRegistrations.ts` because the section is a cohesive
+ * concern with a growing rule set, and its host had reached the file-size ratchet.
+ *
+ * Boot is the only place these can be caught. There is no write boundary that ever refused them
+ * (they are code), and every failure below is silent at run time in the same expensive way: a
+ * malformed definition or an unparseable contract becomes an integration the brief describes with
+ * no operations, a credential key that is not a valid environment-variable name is dropped by the
+ * harness's env validation and reappears as an unexplained 401 mid-run, and a cleartext endpoint
+ * puts that credential on the wire from inside the run container. Each of those costs a run to
+ * discover and names nothing that points back at the registration.
+ *
+ * A declared MEDIA TYPE that contradicts the declared modalities is an error too, not a warning:
+ * both halves drive selection (a step's content-type coverage is checked against `modalities`,
+ * while the brief tells the agent the `mediaTypes`), so an integration claiming `audio` while
+ * listing `image/png` will be picked for one job and asked to do the other.
+ */
+export function checkBinaryGenerators(registry) {
+    const problems = [];
+    if (!registry)
+        return problems;
+    const valid = [];
+    for (const definition of registry.all()) {
+        const issues = binaryGeneratorDefinitionIssues(definition);
+        if (issues.length > 0) {
+            problems.push({
+                severity: 'error',
+                code: 'binary_generator_invalid',
+                message: `Generative binary integration "${definition.id}" is not a valid definition: ${issues.join('; ')}`,
+            });
+            // The checks below read fields this parse just called malformed, so reporting them too
+            // would restate one fault as several.
+            continue;
+        }
+        valid.push(definition);
+        problems.push(...checkBinaryGeneratorDetails(definition));
+    }
+    problems.push(...checkInjectionNameCollisions(valid));
+    return problems;
+}
+/**
+ * The one check that spans DEFINITIONS: two integrations may not inject different values into one
+ * environment variable.
+ *
+ * Within a definition the schema already refuses a repeated injection name. Across definitions the
+ * same name is legitimate and common, because one vendor behind an image endpoint and a music
+ * endpoint is one account: what makes that case safe is that both look the value up under the SAME
+ * key, so whichever integration is resolved first sets the variable to exactly what the other
+ * wanted. Different keys behind one name is the opposite, and there is no arbitration that makes
+ * it right. Serving the first claimant sets the variable the second integration's brief tells the
+ * agent to read, so the agent authenticates one vendor with another's key; withholding it (what
+ * dispatch does, since a mothership node validates nothing) costs both integrations every run.
+ *
+ * Neither outcome is what the deployment meant, and the remedy is one `envName` on one definition,
+ * which is why this is an error at boot rather than a warning nobody acts on. Only definitions
+ * that PARSED are compared: a malformed one has already been reported, and reading its credentials
+ * here would restate that fault as a second, more confusing one.
+ */
+function checkInjectionNameCollisions(definitions) {
+    // Grouped by the COMPARABLE (case-folded) name and reported under the spelling the deployment
+    // wrote, because `ACME_KEY` and `acme_key` are one variable wherever the environment is
+    // case-insensitive and two everywhere else: the pair collides on exactly the platform where the
+    // operator has the least chance of noticing.
+    const claims = new Map();
+    for (const definition of definitions) {
+        for (const credential of definition.credentials ?? []) {
+            const claim = claims.get(comparableCredentialInjectionName(credential)) ?? {
+                spelling: binaryCredentialInjectionName(credential),
+                byKey: new Map(),
+            };
+            claim.byKey.set(credential.key, [...(claim.byKey.get(credential.key) ?? []), definition.id]);
+            claims.set(comparableCredentialInjectionName(credential), claim);
+        }
+    }
+    const problems = [];
+    for (const [, { spelling: envName, byKey }] of claims) {
+        if (byKey.size < 2)
+            continue;
+        const described = [...byKey]
+            .map(([key, ids]) => `"${key}" (${ids.join(', ')})`)
+            .sort()
+            .join(' and ');
+        problems.push({
+            severity: 'error',
+            code: 'binary_generator_injection_name_collision',
+            message: `Generative binary integrations disagree about environment variable "${envName}": it is ` +
+                `declared for lookup keys ${described}. One variable cannot hold both values, so an agent ` +
+                `told to read it for one integration would authenticate with the other's credential. Give ` +
+                `one of them a distinct \`envName\`, or point both at the same lookup key if they really ` +
+                `share an account.`,
+        });
+    }
+    return problems;
+}
+/** The per-definition checks a valid PARSE cannot make: the endpoint, contracts, media types. */
+function checkBinaryGeneratorDetails(definition) {
+    const problems = [];
+    const invalid = (code, message) => {
+        problems.push({ severity: 'error', code, message });
+    };
+    // The same rule an HTTP tool server's URL is held to, and for the same reason the helper
+    // states: a declared credential rides this request, so cleartext off loopback puts it on the
+    // wire. (The helper is MCP-named because that was its first caller; the rule is not.)
+    if (definition.endpoint && !isAllowedMcpHttpUrl(definition.endpoint)) {
+        invalid('insecure_binary_generator_endpoint', `Generative binary integration "${definition.id}" has endpoint "${definition.endpoint}". Its ` +
+            `credential is sent with every request, so the endpoint must be https (plain http is ` +
+            `accepted only on loopback).`);
+    }
+    for (const problem of validateFoundationalDefinition({ contracts: definition.contracts })) {
+        invalid('binary_generator_invalid', `Generative binary integration "${definition.id}": ${describeFoundationalProblem(problem)}`);
+    }
+    const declared = new Set(definition.modalities);
+    for (const mediaType of definition.mediaTypes ?? []) {
+        const consistent = modalitiesOfMediaType(mediaType);
+        // An UNRECOGNISED media type is not a fault: the platform's classifier is not a registry of
+        // every format that exists, and refusing one would make registering a new codec impossible.
+        // A recognised one that CONTRADICTS the declaration is, because both drive selection.
+        //
+        // Contradiction is an empty INTERSECTION, not an absent member, and for 3D that is the whole
+        // difference: a `.glb` is consistent with both `3d-model` and `3d-scene` because the container
+        // does not record which it holds, so requiring every member would refuse a scene generator
+        // for declaring the only format it can emit.
+        if (consistent.length > 0 && !consistent.some((modality) => declared.has(modality))) {
+            const names = consistent.join('/');
+            invalid('binary_generator_modality_mismatch', `Generative binary integration "${definition.id}" declares media type "${mediaType}" ` +
+                `(${names}) but lists none of those among its modalities ` +
+                `(${definition.modalities.join(', ')}). A step selecting it for ${names} would be ` +
+                `refused, and one selecting it for the listed modalities would be told it can emit this.`);
+        }
+    }
+    return problems;
+}
+//# sourceMappingURL=validateBinaryGenerators.js.map

package/dist/validation/validateBinaryGenerators.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"validateBinaryGenerators.js","sourceRoot":"","sources":["../../src/validation/validateBinaryGenerators.ts"],"names":[],"mappings":"AACA,OAAO,EACL,2BAA2B,EAC3B,mBAAmB,EACnB,8BAA8B,GAC/B,MAAM,qBAAqB,CAAA;AAC5B,OAAO,EAEL,6BAA6B,EAC7B,+BAA+B,EAC/B,iCAAiC,EACjC,qBAAqB,GACtB,MAAM,wBAAwB,CAAA;AAK/B;;;;;;;;;;;;;;;;;;;GAmBG;AACH,MAAM,UAAU,qBAAqB,CACnC,QAA6C;IAE7C,MAAM,QAAQ,GAA0B,EAAE,CAAA;IAC1C,IAAI,CAAC,QAAQ;QAAE,OAAO,QAAQ,CAAA;IAC9B,MAAM,KAAK,GAAgC,EAAE,CAAA;IAC7C,KAAK,MAAM,UAAU,IAAI,QAAQ,CAAC,GAAG,EAAE,EAAE,CAAC;QACxC,MAAM,MAAM,GAAG,+BAA+B,CAAC,UAAU,CAAC,CAAA;QAC1D,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACtB,QAAQ,CAAC,IAAI,CAAC;gBACZ,QAAQ,EAAE,OAAO;gBACjB,IAAI,EAAE,0BAA0B;gBAChC,OAAO,EAAE,kCAAkC,UAAU,CAAC,EAAE,gCAAgC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;aAC5G,CAAC,CAAA;YACF,uFAAuF;YACvF,sCAAsC;YACtC,SAAQ;QACV,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;QACtB,QAAQ,CAAC,IAAI,CAAC,GAAG,2BAA2B,CAAC,UAAU,CAAC,CAAC,CAAA;IAC3D,CAAC;IACD,QAAQ,CAAC,IAAI,CAAC,GAAG,4BAA4B,CAAC,KAAK,CAAC,CAAC,CAAA;IACrD,OAAO,QAAQ,CAAA;AACjB,CAAC;AAED;;;;;;;;;;;;;;;;;GAiBG;AACH,SAAS,4BAA4B,CACnC,WAAiD;IAEjD,8FAA8F;IAC9F,wFAAwF;IACxF,gGAAgG;IAChG,6CAA6C;IAC7C,MAAM,MAAM,GAAG,IAAI,GAAG,EAA8D,CAAA;IACpF,KAAK,MAAM,UAAU,IAAI,WAAW,EAAE,CAAC;QACrC,KAAK,MAAM,UAAU,IAAI,UAAU,CAAC,WAAW,IAAI,EAAE,EAAE,CAAC;YACtD,MAAM,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,iCAAiC,CAAC,UAAU,CAAC,CAAC,IAAI;gBACzE,QAAQ,EAAE,6BAA6B,CAAC,UAAU,CAAC;gBACnD,KAAK,EAAE,IAAI,GAAG,EAAoB;aACnC,CAAA;YACD,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,UAAU,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC,EAAE,UAAU,CAAC,EAAE,CAAC,CAAC,CAAA;YAC5F,MAAM,CAAC,GAAG,CAAC,iCAAiC,CAAC,UAAU,CAAC,EAAE,KAAK,CAAC,CAAA;QAClE,CAAC;IACH,CAAC;IACD,MAAM,QAAQ,GAA0B,EAAE,CAAA;IAC1C,KAAK,MAAM,CAAC,EAAE,EAAE,QAAQ,EAAE,OAAO,EAAE,KAAK,EAAE,CAAC,IAAI,MAAM,EAAE,CAAC;QACtD,IAAI,KAAK,CAAC,IAAI,GAAG,CAAC;YAAE,SAAQ;QAC5B,MAAM,SAAS,GAAG,CAAC,GAAG,KAAK,CAAC;aACzB,GAAG,CAAC,CAAC,CAAC,GAAG,EAAE,GAAG,CAAC,EAAE,EAAE,CAAC,IAAI,GAAG,MAAM,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC;aACnD,IAAI,EAAE;aACN,IAAI,CAAC,OAAO,CAAC,CAAA;QAChB,QAAQ,CAAC,IAAI,CAAC;YACZ,QAAQ,EAAE,OAAO;YACjB,IAAI,EAAE,2CAA2C;YACjD,OAAO,EACL,uEAAuE,OAAO,WAAW;gBACzF,4BAA4B,SAAS,sDAAsD;gBAC3F,2FAA2F;gBAC3F,0FAA0F;gBAC1F,mBAAmB;SACtB,CAAC,CAAA;IACJ,CAAC;IACD,OAAO,QAAQ,CAAA;AACjB,CAAC;AAED,iGAAiG;AACjG,SAAS,2BAA2B,CAAC,UAAqC;IACxE,MAAM,QAAQ,GAA0B,EAAE,CAAA;IAC1C,MAAM,OAAO,GAAG,CAAC,IAAY,EAAE,OAAe,EAAQ,EAAE;QACtD,QAAQ,CAAC,IAAI,CAAC,EAAE,QAAQ,EAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC,CAAA;IACrD,CAAC,CAAA;IACD,yFAAyF;IACzF,6FAA6F;IAC7F,sFAAsF;IACtF,IAAI,UAAU,CAAC,QAAQ,IAAI,CAAC,mBAAmB,CAAC,UAAU,CAAC,QAAQ,CAAC,EAAE,CAAC;QACrE,OAAO,CACL,oCAAoC,EACpC,kCAAkC,UAAU,CAAC,EAAE,mBAAmB,UAAU,CAAC,QAAQ,SAAS;YAC5F,sFAAsF;YACtF,6BAA6B,CAChC,CAAA;IACH,CAAC;IACD,KAAK,MAAM,OAAO,IAAI,8BAA8B,CAAC,EAAE,SAAS,EAAE,UAAU,CAAC,SAAS,EAAE,CAAC,EAAE,CAAC;QAC1F,OAAO,CACL,0BAA0B,EAC1B,kCAAkC,UAAU,CAAC,EAAE,MAAM,2BAA2B,CAAC,OAAO,CAAC,EAAE,CAC5F,CAAA;IACH,CAAC;IACD,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,CAAA;IAC/C,KAAK,MAAM,SAAS,IAAI,UAAU,CAAC,UAAU,IAAI,EAAE,EAAE,CAAC;QACpD,MAAM,UAAU,GAAG,qBAAqB,CAAC,SAAS,CAAC,CAAA;QACnD,4FAA4F;QAC5F,4FAA4F;QAC5F,sFAAsF;QACtF,EAAE;QACF,6FAA6F;QAC7F,+FAA+F;QAC/F,2FAA2F;QAC3F,6CAA6C;QAC7C,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;YACpF,MAAM,KAAK,GAAG,UAAU,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;YAClC,OAAO,CACL,oCAAoC,EACpC,kCAAkC,UAAU,CAAC,EAAE,0BAA0B,SAAS,IAAI;gBACpF,IAAI,KAAK,iDAAiD;gBAC1D,IAAI,UAAU,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,8BAA8B,KAAK,YAAY;gBACnF,yFAAyF,CAC5F,CAAA;QACH,CAAC;IACH,CAAC;IACD,OAAO,QAAQ,CAAA;AACjB,CAAC"}

package/dist/validation/validateRegistrations.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"validateRegistrations.d.ts","sourceRoot":"","sources":["../../src/validation/validateRegistrations.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,qBAAqB,CAAA;AAE5D,OAAO,KAAK,EAEV,uBAAuB,EACvB,0BAA0B,EAC1B,2BAA2B,EAC3B,YAAY,EACZ,wBAAwB,EAGxB,gBAAgB,EAChB,sBAAsB,EACtB,oBAAoB,EACpB,gBAAgB,EACjB,MAAM,qBAAqB,CAAA;AAgE5B,4FAA4F;AAC5F,MAAM,WAAW,mBAAmB;IAClC,QAAQ,EAAE,OAAO,GAAG,MAAM,CAAA;IAC1B,IAAI,EAAE,MAAM,CAAA;IACZ,OAAO,EAAE,MAAM,CAAA;CAChB;AAED;;;;;;;;;;;;GAYG;AACH,MAAM,WAAW,mBAAmB;IAClC;;;OAGG;IACH,iBAAiB,EAAE,iBAAiB,CAAA;IACpC;;;;OAIG;IACH,YAAY,EAAE,YAAY,CAAA;IAC1B;;;;;;OAMG;IACH,gBAAgB,CAAC,EAAE,gBAAgB,CAAA;IACnC;;;;;OAKG;IACH,gBAAgB,CAAC,EAAE,gBAAgB,CAAA;IACnC;;;;;OAKG;IACH,wBAAwB,CAAC,EAAE,wBAAwB,CAAA;IACnD;;;;;;OAMG;IACH,2BAA2B,CAAC,EAAE,2BAA2B,CAAA;IACzD;;;;;;OAMG;IACH,uBAAuB,CAAC,EAAE,uBAAuB,CAAA;IACjD;;;;;OAKG;IACH,sBAAsB,CAAC,EAAE,sBAAsB,CAAA;IAC/C;;;;;;;;;OASG;IACH,eAAe,CAAC,EAAE,oBAAoB,CAAA;IACtC;;;;;;;OAOG;IACH,0BAA0B,CAAC,EAAE,0BAA0B,CAAA;CACxD;AAED,uFAAuF;AACvF,MAAM,WAAW,4BAA4B;IAC3C,+EAA+E;IAC/E,UAAU,EAAE,mBAAmB,CAAA;IAC/B,qGAAqG;IACrG,kBAAkB,CAAC,EAAE,WAAW,CAAC,MAAM,CAAC,CAAA;IACxC,qGAAqG;IACrG,kBAAkB,CAAC,EAAE,WAAW,CAAC,MAAM,CAAC,CAAA;IACxC;;;;;OAKG;IACH,eAAe,CAAC,EAAE,WAAW,CAAC,MAAM,CAAC,CAAA;IACrC;;;;OAIG;IACH,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,mBAAmB,KAAK,IAAI,CAAA;IAC/C;;;;;;;;;;;;;;;;;;;;;;OAsBG;IACH,eAAe,CAAC,EAAE,CAAC,OAAO,EAAE,mBAAmB,KAAK,OAAO,CAAA;CAC5D;AAED;;;GAGG;AACH,wBAAgB,2BAA2B,CACzC,IAAI,EAAE,4BAA4B,GACjC,mBAAmB,EAAE,CA4FvB;AA+kCD;;;;;;;;GAQG;AACH,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,4BAA4B,GAAG,IAAI,CAuB9E;AAOD,yGAAyG;AACzG,wBAAgB,yBAAyB,CAAC,IAAI,EAAE,4BAA4B,GAAG,IAAI,CASlF;AAED,uFAAuF;AACvF,wBAAgB,gCAAgC,IAAI,IAAI,CAEvD"}
+{"version":3,"file":"validateRegistrations.d.ts","sourceRoot":"","sources":["../../src/validation/validateRegistrations.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,qBAAqB,CAAA;AAG5D,OAAO,KAAK,EAEV,uBAAuB,EACvB,0BAA0B,EAC1B,2BAA2B,EAC3B,YAAY,EACZ,wBAAwB,EACxB,gBAAgB,EAChB,sBAAsB,EACtB,oBAAoB,EACpB,gBAAgB,EACjB,MAAM,qBAAqB,CAAA;AAiD5B,4FAA4F;AAC5F,MAAM,WAAW,mBAAmB;IAClC,QAAQ,EAAE,OAAO,GAAG,MAAM,CAAA;IAC1B,IAAI,EAAE,MAAM,CAAA;IACZ,OAAO,EAAE,MAAM,CAAA;CAChB;AAED;;;;;;;;;;;;GAYG;AACH,MAAM,WAAW,mBAAmB;IAClC;;;OAGG;IACH,iBAAiB,EAAE,iBAAiB,CAAA;IACpC;;;;OAIG;IACH,YAAY,EAAE,YAAY,CAAA;IAC1B;;;;;;OAMG;IACH,gBAAgB,CAAC,EAAE,gBAAgB,CAAA;IACnC;;;;;OAKG;IACH,gBAAgB,CAAC,EAAE,gBAAgB,CAAA;IACnC;;;;;OAKG;IACH,wBAAwB,CAAC,EAAE,wBAAwB,CAAA;IACnD;;;;;;OAMG;IACH,2BAA2B,CAAC,EAAE,2BAA2B,CAAA;IACzD;;;;;;OAMG;IACH,uBAAuB,CAAC,EAAE,uBAAuB,CAAA;IACjD;;;;;OAKG;IACH,sBAAsB,CAAC,EAAE,sBAAsB,CAAA;IAC/C;;;;;;;;;OASG;IACH,eAAe,CAAC,EAAE,oBAAoB,CAAA;IACtC;;;;;;;OAOG;IACH,0BAA0B,CAAC,EAAE,0BAA0B,CAAA;CACxD;AAED,uFAAuF;AACvF,MAAM,WAAW,4BAA4B;IAC3C,+EAA+E;IAC/E,UAAU,EAAE,mBAAmB,CAAA;IAC/B,qGAAqG;IACrG,kBAAkB,CAAC,EAAE,WAAW,CAAC,MAAM,CAAC,CAAA;IACxC,qGAAqG;IACrG,kBAAkB,CAAC,EAAE,WAAW,CAAC,MAAM,CAAC,CAAA;IACxC;;;;;OAKG;IACH,eAAe,CAAC,EAAE,WAAW,CAAC,MAAM,CAAC,CAAA;IACrC;;;;OAIG;IACH,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,mBAAmB,KAAK,IAAI,CAAA;IAC/C;;;;;;;;;;;;;;;;;;;;;;OAsBG;IACH,eAAe,CAAC,EAAE,CAAC,OAAO,EAAE,mBAAmB,KAAK,OAAO,CAAA;CAC5D;AAED;;;GAGG;AACH,wBAAgB,2BAA2B,CACzC,IAAI,EAAE,4BAA4B,GACjC,mBAAmB,EAAE,CA4FvB;AA6sBD;;;;;;;;GAQG;AACH,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,4BAA4B,GAAG,IAAI,CAuB9E;AAOD,yGAAyG;AACzG,wBAAgB,yBAAyB,CAAC,IAAI,EAAE,4BAA4B,GAAG,IAAI,CASlF;AAED,uFAAuF;AACvF,wBAAgB,gCAAgC,IAAI,IAAI,CAEvD"}

package/dist/validation/validateRegistrations.js

@@ -1,6 +1,8 @@
 import { INLINE_ENGINE_SYSTEM_PROMPTS, runsInContainer } from '@cat-factory/agents';
-import { CI_FIXER_AGENT_KIND, CONFLICT_RESOLVER_AGENT_KIND, FIXER_AGENT_KIND, ON_CALL_AGENT_KIND, MCP_OAUTH_DEFAULT_HEADER, MCP_SUPPORTED_HARNESSES, TOOL_SERVER_BUDGET, describeFoundationalProblem, isAllowedMcpHttpUrl, isValidMcpServerId, isValidMcpToolName, mcpServableHarnesses, seedPipelines, stubGateContext, toolServerDeclaredBytes, validateFoundationalDefinition, } from '@cat-factory/kernel';
-import { binaryGeneratorDefinitionIssues, descriptorConditionHasPredicate, duplicatedDescriptorSectionCaptions, isDeploymentScopedSource, foundationalServiceDefinitionIssues, isEnvVariableName, isNamespacedId, isReservedPlatformEnvKey, isToolchainEnvName, modalitiesOfMediaType, reservedEnvKeyMessage, toolchainEnvNameMessage, isValidResultViewId, RESULT_VIEW_ID_SET, } from '@cat-factory/contracts';
+import { checkBinaryGenerators } from './validateBinaryGenerators.js';
+import { CI_FIXER_AGENT_KIND, CONFLICT_RESOLVER_AGENT_KIND, FIXER_AGENT_KIND, ON_CALL_AGENT_KIND, describeFoundationalProblem, seedPipelines, stubGateContext, validateFoundationalDefinition, } from '@cat-factory/kernel';
+import { descriptorConditionHasPredicate, duplicatedDescriptorSectionCaptions, isDeploymentScopedSource, foundationalServiceDefinitionIssues, isNamespacedId, isValidResultViewId, RESULT_VIEW_ID_SET, } from '@cat-factory/contracts';
+import { checkKindToolServers } from './validateToolServers.js';
 // ---------------------------------------------------------------------------
 // Boot-time validation of the deployment's registered extensions (agent kinds, gates,
 // pipelines). A typo'd gate `helperKind`, an unknown `resultView`, or a pipeline naming a
@@ -101,7 +103,7 @@ export function collectRegistrationProblems(opts) {
     // 8. Deployment-registered FOUNDATIONAL SERVICES (only when a registry is supplied).
     problems.push(...checkFoundationalServices(opts));
     // 9. Deployment-registered GENERATIVE BINARY INTEGRATIONS (only when a registry is supplied).
-    problems.push(...checkBinaryGenerators(opts));
+    problems.push(...checkBinaryGenerators(opts.registries.binaryGeneratorRegistry));
     // 10. Deployment-registered PROMPT FRAGMENTS (only when a registry is supplied).
     problems.push(...checkPromptFragments(opts));
     return problems;
@@ -170,81 +172,6 @@ function checkPromptFragments(opts) {
     }
     return problems;
 }
-/**
- * Section 9 of {@link collectRegistrationProblems}: every generative binary integration a
- * deployment registers must be a definition the platform can actually dispatch against.
- *
- * Boot is the only place these can be caught. There is no write boundary that ever refused them
- * (they are code), and every failure below is silent at run time in the same expensive way: a
- * malformed definition or an unparseable contract becomes an integration the brief describes with
- * no operations, a credential key that is not a valid environment-variable name is dropped by the
- * harness's env validation and reappears as an unexplained 401 mid-run, and a cleartext endpoint
- * puts that credential on the wire from inside the run container. Each of those costs a run to
- * discover and names nothing that points back at the registration.
- *
- * A declared MEDIA TYPE that contradicts the declared modalities is an error too, not a warning:
- * both halves drive selection (a step's content-type coverage is checked against `modalities`,
- * while the brief tells the agent the `mediaTypes`), so an integration claiming `audio` while
- * listing `image/png` will be picked for one job and asked to do the other.
- */
-function checkBinaryGenerators(opts) {
-    const problems = [];
-    if (!opts.registries.binaryGeneratorRegistry)
-        return problems;
-    for (const definition of opts.registries.binaryGeneratorRegistry.all()) {
-        const issues = binaryGeneratorDefinitionIssues(definition);
-        if (issues.length > 0) {
-            problems.push({
-                severity: 'error',
-                code: 'binary_generator_invalid',
-                message: `Generative binary integration "${definition.id}" is not a valid definition: ${issues.join('; ')}`,
-            });
-            // The checks below read fields this parse just called malformed, so reporting them too
-            // would restate one fault as several.
-            continue;
-        }
-        problems.push(...checkBinaryGeneratorDetails(definition));
-    }
-    return problems;
-}
-/** The per-definition checks a valid PARSE cannot make: the endpoint, contracts, media types. */
-function checkBinaryGeneratorDetails(definition) {
-    const problems = [];
-    const invalid = (code, message) => {
-        problems.push({ severity: 'error', code, message });
-    };
-    // The same rule an HTTP tool server's URL is held to, and for the same reason the helper
-    // states: a declared credential rides this request, so cleartext off loopback puts it on the
-    // wire. (The helper is MCP-named because that was its first caller; the rule is not.)
-    if (definition.endpoint && !isAllowedMcpHttpUrl(definition.endpoint)) {
-        invalid('insecure_binary_generator_endpoint', `Generative binary integration "${definition.id}" has endpoint "${definition.endpoint}". Its ` +
-            `credential is sent with every request, so the endpoint must be https (plain http is ` +
-            `accepted only on loopback).`);
-    }
-    for (const problem of validateFoundationalDefinition({ contracts: definition.contracts })) {
-        invalid('binary_generator_invalid', `Generative binary integration "${definition.id}": ${describeFoundationalProblem(problem)}`);
-    }
-    const declared = new Set(definition.modalities);
-    for (const mediaType of definition.mediaTypes ?? []) {
-        const consistent = modalitiesOfMediaType(mediaType);
-        // An UNRECOGNISED media type is not a fault: the platform's classifier is not a registry of
-        // every format that exists, and refusing one would make registering a new codec impossible.
-        // A recognised one that CONTRADICTS the declaration is, because both drive selection.
-        //
-        // Contradiction is an empty INTERSECTION, not an absent member, and for 3D that is the whole
-        // difference: a `.glb` is consistent with both `3d-model` and `3d-scene` because the container
-        // does not record which it holds, so requiring every member would refuse a scene generator
-        // for declaring the only format it can emit.
-        if (consistent.length > 0 && !consistent.some((modality) => declared.has(modality))) {
-            const names = consistent.join('/');
-            invalid('binary_generator_modality_mismatch', `Generative binary integration "${definition.id}" declares media type "${mediaType}" ` +
-                `(${names}) but lists none of those among its modalities ` +
-                `(${definition.modalities.join(', ')}). A step selecting it for ${names} would be ` +
-                `refused, and one selecting it for the listed modalities would be told it can emit this.`);
-        }
-    }
-    return problems;
-}
 /**
  * Section 8 of {@link collectRegistrationProblems}: every foundational service a deployment
  * registers in code must be a definition the platform would have accepted over its own write
@@ -435,284 +362,6 @@ function checkKindSkills(kind, registry) {
     }
     return problems;
 }
-/**
- * A kind's declared TOOL SERVERS: the whole-list checks (unregistered ids, the per-dispatch budget,
- * the container surface), with each definition's own checks in
- * {@link checkToolServerDefinition}. "Declared for" includes assigned servers, see
- * {@link checkAgentCapabilities}.
- *
- * - an unregistered id is an ERROR, like an unregistered skill;
- * - past EITHER dimension of the per-dispatch budget is a WARNING, because the dispatch drops the
- *   excess under `over_budget` rather than failing: the run still works, with fewer tools than the
- *   deployment believes it wired, and boot is the only place the DECLARATIONS past the line can be
- *   named. A warning also keeps the accretion case honest, a kind going over budget through
- *   `assignToolServers` calls in several packages none of which is individually wrong. Both
- *   dimensions are checked because the dispatch enforces both, and a byte-driven drop is the one
- *   that surprises: a handful of servers with fat `env`/`args`/`headers` blocks is under the count
- *   and over the payload;
- * - tool servers on a NON-container kind is a WARNING: an inline LLM call has no CLI to wire them
- *   into, so they can never take effect. A warning rather than an error because a deployment may
- *   deliberately declare them ahead of moving the kind onto a container surface.
- */
-function checkKindToolServers(kind, registry) {
-    const problems = [];
-    const tools = registry.toolServersFor(kind);
-    for (const id of tools.unknown) {
-        problems.push({
-            severity: 'error',
-            code: 'unknown_tool_server',
-            message: `Agent kind "${kind}" declares tool server "${id}", which is not registered. Call ` +
-                `registry.registerToolServer({ id: '${id}', … }) before registering the kind, or ` +
-                `declare the server inline.`,
-        });
-    }
-    for (const server of tools.servers)
-        problems.push(...checkToolServerDefinition(kind, server));
-    problems.push(...checkToolServerBudget(kind, tools.servers));
-    if (tools.servers.length && !runsInContainer(kind, registry)) {
-        problems.push({
-            severity: 'warn',
-            code: 'tool_servers_without_container',
-            message: `Agent kind "${kind}" declares tool servers but does not run in a container — an ` +
-                `inline LLM step has no agent CLI to wire them into, so they will never be available. ` +
-                `Give the kind a container surface (agent.surface: 'container-explore' / ` +
-                `'container-coding') or drop the tool servers.`,
-        });
-    }
-    return problems;
-}
-/**
- * The per-dispatch budget, BOTH dimensions, as warnings: the dispatch drops the excess under
- * `over_budget` and the run works with fewer tools, so a registration fault belongs at boot rather
- * than in a refusal that takes the deployment down.
- *
- * The byte check measures {@link toolServerDeclaredBytes}, which is a FLOOR (a resolved credential
- * only adds to it), so a declaration already past the budget here is certainly past it at dispatch.
- * What boot deliberately does NOT claim is WHICH servers a run will lose: the dispatch keeps every
- * server that still fits, so once bytes are what bind the survivors are not a prefix of the
- * declaration. The count and the budget are what the author acts on, and the run itself names each
- * server it dropped.
- */
-function checkToolServerBudget(kind, servers) {
-    const problems = [];
-    if (servers.length > TOOL_SERVER_BUDGET.maxServers) {
-        problems.push({
-            severity: 'warn',
-            code: 'too_many_tool_servers',
-            message: `Agent kind "${kind}" has ${servers.length} tool servers declared for it, past the ` +
-                `per-dispatch budget of ${TOOL_SERVER_BUDGET.maxServers}. A dispatch wires the first ` +
-                `${TOOL_SERVER_BUDGET.maxServers} in declaration order and states the rest to the agent as ` +
-                `unavailable (over_budget). Drop some, or split the work across kinds.`,
-        });
-    }
-    const bytes = servers.reduce((total, server) => total + toolServerDeclaredBytes(server), 0);
-    if (bytes > TOOL_SERVER_BUDGET.maxTotalBytes) {
-        problems.push({
-            severity: 'warn',
-            code: 'tool_servers_over_byte_budget',
-            message: `Agent kind "${kind}" declares tool servers whose transport config alone measures ${bytes} ` +
-                `bytes, past the per-dispatch budget of ${TOOL_SERVER_BUDGET.maxTotalBytes}. A dispatch ` +
-                `wires servers until that budget is spent and states the rest to the agent as unavailable ` +
-                `(over_budget); resolved credentials only add to this figure, and which servers lose out ` +
-                `depends on their sizes. Trim the env/args/headers blocks, or split the work across kinds.`,
-        });
-    }
-    return problems;
-}
-/**
- * ONE tool server definition:
- *
- * - a malformed MCP server id is an ERROR, because it becomes both a tool-name fragment and a
- *   Codex TOML table key, so the CLI fails on it far from the registration that caused it;
- * - an `allowedTools` entry that is not a valid tool NAME is an ERROR, the comma case above all:
- *   the harness joins the whole list into one `--allowedTools` argument with commas, so an entry
- *   carrying one splits into two patterns and the second matches nothing, while the prompt goes on
- *   advertising the name verbatim. That is the "told about a tool it cannot call" failure the
- *   unavailability vocabulary exists to prevent;
- * - a definition NO harness could ever serve is a WARNING, and it is the only check here a run
- *   structurally cannot report: an `http` server narrowed to `harnesses: ['codex']` (whose client
- *   is stdio-only), or anything narrowed to `['pi']` (which has no MCP client), is never dropped
- *   FOR A REASON on any run. It simply never applies, so no prompt and no log line ever mentions
- *   it. A warning rather than an error because the declaration is inert rather than dangerous;
- * - a cleartext `http://` endpoint off loopback is an ERROR: a resolved credential rides that
- *   request as a header, and the harness refuses the same URL at the job boundary — so allowing
- *   it here only moves the failure to a place with no registration to point at.
- */
-function checkToolServerDefinition(kind, server) {
-    const problems = [];
-    const on = `(on agent kind "${kind}")`;
-    if (!isValidMcpServerId(server.id)) {
-        problems.push({
-            severity: 'error',
-            code: 'invalid_tool_server_id',
-            message: `Tool server "${server.id}" ${on} has an invalid id. It becomes part of the tool names ` +
-                `the CLI exposes (mcp__<id>__<tool>) and a Codex config key, so it must match ` +
-                `[a-z0-9][a-z0-9_-]*.`,
-        });
-    }
-    for (const tool of server.allowedTools ?? []) {
-        if (isValidMcpToolName(tool))
-            continue;
-        problems.push({
-            severity: 'error',
-            code: 'invalid_tool_server_tool_name',
-            message: `Tool server "${server.id}" ${on} restricts allowedTools to "${tool}", which is not a ` +
-                `single tool name (letters, digits, "_", "." and "-"). The harness joins the list into ` +
-                `one --allowedTools argument with commas, so an entry with a comma or whitespace becomes ` +
-                `patterns that match nothing while the prompt still advertises the name. List each tool ` +
-                `as its own entry.`,
-        });
-    }
-    const servable = mcpServableHarnesses(server);
-    if (servable.length === 0) {
-        problems.push({
-            severity: 'warn',
-            code: 'tool_server_unservable',
-            message: `Tool server "${server.id}" ${on} declares transport "${server.transport.kind}" for ` +
-                `harnesses [${(server.harnesses ?? MCP_SUPPORTED_HARNESSES).join(', ')}], and no harness ` +
-                `can serve that combination, so the server never applies to any run and no prompt or log ` +
-                `line will say why. Codex's MCP client is stdio-only and Pi has none at all. Widen the ` +
-                `harnesses, change the transport, or drop the declaration.`,
-        });
-    }
-    if (server.transport.kind === 'http' && !isAllowedMcpHttpUrl(server.transport.url)) {
-        problems.push({
-            severity: 'error',
-            code: 'insecure_tool_server_url',
-            message: `Tool server "${server.id}" ${on} has url "${server.transport.url}". An HTTP tool server ` +
-                `carries its resolved credential in a request header, so the url must be https (plain ` +
-                `http is accepted only on loopback).`,
-        });
-    }
-    for (const secret of server.secretKeys ?? []) {
-        problems.push(...checkToolServerSecret(kind, server, secret));
-    }
-    problems.push(...checkToolServerOAuth(kind, server));
-    return problems;
-}
-/**
- * A tool server's OAUTH declaration, when it has one. Four rules, and each of them names a failure
- * that is otherwise invisible until a run or a button press:
- *
- * - `oauth` on a `stdio` server is an ERROR. A stdio server is a child process the CLI spawns;
- *   there is no request to authorise, so the declaration is inert and reads as configured. The
- *   dispatch drops the OAuth half silently for the mothership case, which is exactly why boot is
- *   where the fault has to be named.
- * - a declared endpoint that fails the URL floor is an ERROR, and this is the sharpest one here:
- *   an OAuth exchange carries the client secret and the tokens, so a cleartext endpoint puts both
- *   on the wire. A DISCOVERED endpoint is held to the same rule at the moment it is read.
- * - a reserved `clientSecretKey` is an ERROR for the reason every capability credential is: the
- *   declaration names both the key it wants and the token endpoint that key is posted to.
- * - a `secretKeys` entry naming the same header the access token rides is a WARNING. Both would
- *   land in one header map and the granted token wins, so the static credential silently does
- *   nothing — which reads, to whoever declared it, as the platform ignoring their credential.
- */
-function checkToolServerOAuth(kind, server) {
-    const oauth = server.oauth;
-    if (!oauth)
-        return [];
-    const problems = [];
-    const on = `(on agent kind "${kind}")`;
-    if (server.transport.kind !== 'http') {
-        problems.push({
-            severity: 'error',
-            code: 'oauth_requires_http_transport',
-            message: `Tool server "${server.id}" ${on} declares OAuth on a "${server.transport.kind}" ` +
-                `transport. OAuth authenticates a REQUEST, and a stdio server is a child process the ` +
-                `agent CLI spawns with no request to authorise — pass its credential through secretKeys ` +
-                `instead.`,
-        });
-    }
-    for (const [field, url] of [
-        ['authorizationUrl', oauth.authorizationUrl],
-        ['tokenUrl', oauth.tokenUrl],
-    ]) {
-        if (url === undefined || isAllowedMcpHttpUrl(url))
-            continue;
-        problems.push({
-            severity: 'error',
-            code: 'insecure_oauth_endpoint',
-            message: `Tool server "${server.id}" ${on} declares OAuth ${field} "${url}". The exchange carries ` +
-                `the client secret and the access token, so the endpoint must be https (plain http is ` +
-                `accepted only on loopback).`,
-        });
-    }
-    if (oauth.clientSecretKey !== undefined && isReservedPlatformEnvKey(oauth.clientSecretKey)) {
-        problems.push({
-            severity: 'error',
-            code: 'reserved_credential_key',
-            message: `Tool server "${server.id}" ${on} declares OAuth client secret ` +
-                reservedEnvKeyMessage(oauth.clientSecretKey),
-        });
-    }
-    const tokenHeader = (oauth.header ?? MCP_OAUTH_DEFAULT_HEADER).toLowerCase();
-    for (const secret of server.secretKeys ?? []) {
-        if (secret.header?.toLowerCase() !== tokenHeader)
-            continue;
-        problems.push({
-            severity: 'warn',
-            code: 'oauth_header_collision',
-            message: `Tool server "${server.id}" ${on} declares credential "${secret.key}" on header ` +
-                `"${secret.header}", which is also where its OAuth access token is sent. The granted ` +
-                `token wins, so that credential reaches the server as nothing at all — send it under a ` +
-                `different header, or drop it.`,
-        });
-    }
-    return problems;
-}
-/**
- * ONE credential a tool server declares. The reserved-key check is the sharpest rule in this file:
- * a definition names both the key it wants and the endpoint that key is sent to, so
- * `{ key: 'ENCRYPTION_KEY', header: 'Authorization' }` is a registration that boots clean and ships
- * the deployment's master sealing key to a third party. The generative-integration half of the same
- * rule is enforced by its credential SCHEMA (there is no schema here — a tool server is a TypeScript
- * registration), and dispatch refuses both again for the mothership case.
- */
-function checkToolServerSecret(kind, server, secret) {
-    const problems = [];
-    const on = `(on agent kind "${kind}")`;
-    if (isReservedPlatformEnvKey(secret.key)) {
-        problems.push({
-            severity: 'error',
-            code: 'reserved_credential_key',
-            message: `Tool server "${server.id}" ${on} declares credential ${reservedEnvKeyMessage(secret.key)}`,
-        });
-    }
-    if (secret.envName === undefined)
-        return problems;
-    // The injection name is NOT held to the reserved floor (it reads nothing), so it carries its own
-    // rule: a value set as `PATH` or `npm_config_registry` reconfigures the server's process instead
-    // of authenticating a call. Dispatch drops one too, for the mothership case.
-    if (!isEnvVariableName(secret.envName)) {
-        problems.push({
-            severity: 'error',
-            code: 'invalid_credential_env_name',
-            message: `Tool server "${server.id}" ${on} declares credential envName "${secret.envName}", which ` +
-                `is not a valid environment variable name. It becomes a variable of the server's process, ` +
-                `and the harness drops anything else.`,
-        });
-    }
-    if (isToolchainEnvName(secret.envName)) {
-        problems.push({
-            severity: 'error',
-            code: 'toolchain_credential_env_name',
-            message: `Tool server "${server.id}" ${on} declares credential ${toolchainEnvNameMessage(secret.envName)}`,
-        });
-    }
-    // An `http` server sends its value as a HEADER, so an injection name would be read by nothing.
-    // A warning rather than an error: the declaration still works, it just says something that cannot
-    // take effect, and failing boot over it would be out of proportion.
-    if (server.transport.kind === 'http' && secret.header) {
-        problems.push({
-            severity: 'warn',
-            code: 'unused_credential_env_name',
-            message: `Tool server "${server.id}" ${on} declares credential envName "${secret.envName}" on a ` +
-                `key that names a header. An http server's value is sent as that header, so the injection ` +
-                `name is never used.`,
-        });
-    }
-    return problems;
-}
 /**
  * Section 3 of {@link collectRegistrationProblems}: a coherence WARNING for a kind that declares
  * postOps but whose agent step is not structured output — those post-ops read `result.custom` and