@cat-factory/orchestration 0.136.0 → 0.137.0

package/dist/modules/execution/gate-window-controllers.js

@@ -0,0 +1,212 @@
+/**
+ * The human-gate window controllers the engine composes: the Tester / Ralph / human-test /
+ * visual-confirmation gates, the shared review gate, the implementation-fork decision gate and
+ * the PR-review gate.
+ *
+ * Extracted verbatim from the {@link ExecutionService} constructor (which had grown past the
+ * per-function line budget — docs/initiatives/lint-complexity-size-ratchet.md) following the
+ * established `RunDispatcher` controller pattern: the factory takes ONE deps object of already-
+ * built collaborators plus BOUND call-backs for the engine methods the controllers reach back
+ * into (`resolveRiskPolicy` / `dispatchIterationCap` / `clockNow`), so every closure still
+ * resolves through the live engine instance exactly as before. Behaviour-neutral.
+ */
+import { TesterController } from './TesterController.js';
+import { RalphController } from './RalphController.js';
+import { HumanTestController } from './HumanTestController.js';
+import { VisualConfirmationController } from './VisualConfirmationController.js';
+import { ReviewGateController } from './ReviewGateController.js';
+import { ForkDecisionController } from './ForkDecisionController.js';
+import { PrReviewController } from './PrReviewController.js';
+import { InitiativeInterviewController } from './InitiativeInterviewController.js';
+import { DocInterviewController } from './DocInterviewController.js';
+import { buildBrainstormKind, buildClarityKind, buildRequirementsKind } from './review-kinds.js';
+import { ARCHITECTURE_BRAINSTORM_AGENT_KIND, REQUIREMENTS_BRAINSTORM_AGENT_KIND, } from './ci.logic.js';
+/**
+ * Build the human-gate window controllers over one shared deps bundle (see the module doc).
+ */
+export function buildGateWindowControllers(deps) {
+    const { blockRepository, executionRepository, workRunner, agentExecutor, notificationService, contextBuilder, stateMachine, stepGraph, idGenerator, clock, clockNow, resolveRiskPolicy, dispatchIterationCap, testerQualityReviewer, environmentProvisioning, environmentTeardown, branchUpdater, resolveBinaryArtifactStore, forkChatService, } = deps;
+    const testerController = new TesterController({
+        blockRepository,
+        notificationService,
+        agentExecutor,
+        contextBuilder,
+        resolveRiskPolicy,
+        stateMachine,
+        // The test quality-control companion's inline reviewer (when wired); absent → QC
+        // pass-through. Stamps its verdicts with the engine clock.
+        ...(testerQualityReviewer ? { qualityReviewer: testerQualityReviewer } : {}),
+        clockNow,
+    });
+    const ralphController = new RalphController({
+        blockRepository,
+        notificationService,
+        agentExecutor,
+        contextBuilder,
+        stateMachine,
+        clockNow,
+    });
+    const humanTestController = new HumanTestController({
+        blockRepository,
+        executionRepository,
+        workRunner,
+        agentExecutor,
+        contextBuilder,
+        notificationService,
+        // The human-test gate READS the env the upstream `deployer` step provisioned (it no longer
+        // stands up its own) — resolved by the block's OWN service frame, exactly as the tester
+        // context resolves it, so the gate and the tester(s) share the one provisioned env. Left
+        // undefined when no provider is wired (the gate degrades to manual mode).
+        ...(environmentProvisioning
+            ? {
+                readEnvironment: async (ws, block) => {
+                    const frame = await contextBuilder.resolveServiceFrame(ws, block.id);
+                    const handle = await environmentProvisioning.getHandleForBlock(ws, block.id, frame?.id);
+                    // Reconcile against the LIVE provider status when the stored record isn't yet
+                    // `ready`: the deployer records an async provider's env as `provisioning`, and nothing
+                    // re-polls that row once the deployer step completes, so a slow-but-now-ready env
+                    // would otherwise read stale and wrongly degrade the gate to manual mode. One refresh
+                    // reconciles it; an env still genuinely provisioning / failed degrades as before.
+                    // Best-effort — keep the stored handle if the status read throws.
+                    if (handle && handle.status !== 'ready') {
+                        try {
+                            return await environmentProvisioning.refreshStatus(ws, handle.id);
+                        }
+                        catch {
+                            return handle;
+                        }
+                    }
+                    return handle;
+                },
+            }
+            : {}),
+        ...(environmentTeardown
+            ? {
+                teardownEnvironment: async (ws, id) => {
+                    await environmentTeardown.teardown(ws, id);
+                },
+            }
+            : {}),
+        ...(branchUpdater ? { branchUpdater } : {}),
+        resolveRiskPolicy,
+        stateMachine,
+        stepGraph,
+        clockNow,
+    });
+    const visualConfirmationController = new VisualConfirmationController({
+        blockRepository,
+        executionRepository,
+        workRunner,
+        agentExecutor,
+        contextBuilder,
+        notificationService,
+        ...(resolveBinaryArtifactStore ? { resolveBinaryArtifactStore } : {}),
+        resolveRiskPolicy,
+        stateMachine,
+        stepGraph,
+        clockNow,
+    });
+    const reviewGate = new ReviewGateController({
+        blockRepository,
+        executionRepository,
+        workRunner,
+        stateMachine,
+        stepGraph,
+        resolveRiskPolicy,
+        dispatchIterationCap,
+    });
+    const forkDecisionController = new ForkDecisionController({
+        blockRepository,
+        executionRepository,
+        workRunner,
+        stateMachine,
+        stepGraph,
+        idGenerator,
+        clock,
+        notificationService,
+        ...(forkChatService ? { forkChatService } : {}),
+        resolveEffectiveDescription: (ws, block) => contextBuilder.resolveEffectiveDescription(ws, block),
+    });
+    const prReviewController = new PrReviewController({
+        executionRepository,
+        workRunner,
+        stateMachine,
+        stepGraph,
+        idGenerator,
+        clock,
+        notificationService,
+    });
+    return {
+        testerController,
+        ralphController,
+        humanTestController,
+        visualConfirmationController,
+        reviewGate,
+        forkDecisionController,
+        prReviewController,
+    };
+}
+/**
+ * Build the review-gate SUBJECTS (requirements / clarity / the two brainstorm stages) plus the
+ * two interactive interview gates (initiative planning, document interview). Extracted verbatim
+ * from the {@link ExecutionService} constructor for the per-function line budget — each
+ * subject's differentiators still live in `review-kinds.ts`, not on the engine.
+ */
+export function buildReviewSubjects(deps) {
+    const { blockRepository, executionRepository, workRunner, stateMachine, stepGraph, executionEventPublisher, requirementReviewService, clarityReviewService, brainstormServices, issueWriteback, initiativeService, initiativeInterviewService, docInterviewService, } = deps;
+    // The review-gate subjects (requirements / clarity / the two brainstorm stages), built by
+    // the factories in review-kinds.ts over one shared closure of collaborators — each subject's
+    // differentiators live there, not on the engine.
+    const reviewKindDeps = {
+        events: executionEventPublisher,
+        blockRepository,
+        executionRepository,
+        requirementReviewService,
+        clarityReviewService,
+        brainstormServices,
+        issueWriteback,
+    };
+    const requirementsKind = buildRequirementsKind(reviewKindDeps);
+    const clarityKind = buildClarityKind(reviewKindDeps);
+    const requirementsBrainstormKind = buildBrainstormKind('requirements', REQUIREMENTS_BRAINSTORM_AGENT_KIND, reviewKindDeps);
+    const architectureBrainstormKind = buildBrainstormKind('architecture', ARCHITECTURE_BRAINSTORM_AGENT_KIND, reviewKindDeps);
+    // The interactive-planning interviewer gate — wired whenever the initiative store is
+    // present (the entity is where its state lives). The interviewer LLM is optional: without
+    // it (or without a model) the gate passes through, so planning still runs off the raw
+    // block description. Absent initiative store → the `initiative-interviewer` step passes
+    // through in RunDispatcher (an initiative pipeline can't run without the store anyway).
+    const initiativeInterviewController = initiativeService
+        ? new InitiativeInterviewController({
+            blockRepository,
+            executionRepository,
+            workRunner,
+            stateMachine,
+            stepGraph,
+            interviewService: initiativeInterviewService,
+            initiativeService,
+        })
+        : undefined;
+    // The interactive document-interview gate (WS5) — wired whenever the interview service is
+    // present. Without it (or without a model) the gate passes through, so document pipelines
+    // still run off the raw outline. Self-contained persistence lives in the service.
+    const docInterviewController = docInterviewService
+        ? new DocInterviewController({
+            blockRepository,
+            executionRepository,
+            workRunner,
+            stateMachine,
+            stepGraph,
+            events: executionEventPublisher,
+            docInterviewService,
+        })
+        : undefined;
+    return {
+        requirementsKind,
+        clarityKind,
+        requirementsBrainstormKind,
+        architectureBrainstormKind,
+        initiativeInterviewController,
+        docInterviewController,
+    };
+}
+//# sourceMappingURL=gate-window-controllers.js.map

package/dist/modules/execution/gate-window-controllers.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"gate-window-controllers.js","sourceRoot":"","sources":["../../../src/modules/execution/gate-window-controllers.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAeH,OAAO,EAAE,gBAAgB,EAAE,MAAM,uBAAuB,CAAA;AACxD,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAA;AACtD,OAAO,EAAE,mBAAmB,EAAE,MAAM,0BAA0B,CAAA;AAC9D,OAAO,EAAE,4BAA4B,EAAE,MAAM,mCAAmC,CAAA;AAChF,OAAO,EAAE,oBAAoB,EAAiC,MAAM,2BAA2B,CAAA;AAC/F,OAAO,EAAE,sBAAsB,EAAE,MAAM,6BAA6B,CAAA;AACpE,OAAO,EAAE,kBAAkB,EAAE,MAAM,yBAAyB,CAAA;AAC5D,OAAO,EAAE,6BAA6B,EAAE,MAAM,oCAAoC,CAAA;AAClF,OAAO,EAAE,sBAAsB,EAAE,MAAM,6BAA6B,CAAA;AACpE,OAAO,EAAE,mBAAmB,EAAE,gBAAgB,EAAE,qBAAqB,EAAE,MAAM,mBAAmB,CAAA;AAChG,OAAO,EACL,kCAAkC,EAClC,kCAAkC,GACnC,MAAM,eAAe,CAAA;AA8BtB;;GAEG;AACH,MAAM,UAAU,0BAA0B,CAAC,IAA8B;IACvE,MAAM,EACJ,eAAe,EACf,mBAAmB,EACnB,UAAU,EACV,aAAa,EACb,mBAAmB,EACnB,cAAc,EACd,YAAY,EACZ,SAAS,EACT,WAAW,EACX,KAAK,EACL,QAAQ,EACR,iBAAiB,EACjB,oBAAoB,EACpB,qBAAqB,EACrB,uBAAuB,EACvB,mBAAmB,EACnB,aAAa,EACb,0BAA0B,EAC1B,eAAe,GAChB,GAAG,IAAI,CAAA;IACR,MAAM,gBAAgB,GAAG,IAAI,gBAAgB,CAAC;QAC5C,eAAe;QACf,mBAAmB;QACnB,aAAa;QACb,cAAc;QACd,iBAAiB;QACjB,YAAY;QACZ,iFAAiF;QACjF,2DAA2D;QAC3D,GAAG,CAAC,qBAAqB,CAAC,CAAC,CAAC,EAAE,eAAe,EAAE,qBAAqB,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAC5E,QAAQ;KACT,CAAC,CAAA;IACF,MAAM,eAAe,GAAG,IAAI,eAAe,CAAC;QAC1C,eAAe;QACf,mBAAmB;QACnB,aAAa;QACb,cAAc;QACd,YAAY;QACZ,QAAQ;KACT,CAAC,CAAA;IACF,MAAM,mBAAmB,GAAG,IAAI,mBAAmB,CAAC;QAClD,eAAe;QACf,mBAAmB;QACnB,UAAU;QACV,aAAa;QACb,cAAc;QACd,mBAAmB;QACnB,2FAA2F;QAC3F,wFAAwF;QACxF,yFAAyF;QACzF,0EAA0E;QAC1E,GAAG,CAAC,uBAAuB;YACzB,CAAC,CAAC;gBACE,eAAe,EAAE,KAAK,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE;oBACnC,MAAM,KAAK,GAAG,MAAM,cAAc,CAAC,mBAAmB,CAAC,EAAE,EAAE,KAAK,CAAC,EAAE,CAAC,CAAA;oBACpE,MAAM,MAAM,GAAG,MAAM,uBAAuB,CAAC,iBAAiB,CAAC,EAAE,EAAE,KAAK,CAAC,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,CAAA;oBACvF,8EAA8E;oBAC9E,uFAAuF;oBACvF,kFAAkF;oBAClF,sFAAsF;oBACtF,kFAAkF;oBAClF,kEAAkE;oBAClE,IAAI,MAAM,IAAI,MAAM,CAAC,MAAM,KAAK,OAAO,EAAE,CAAC;wBACxC,IAAI,CAAC;4BACH,OAAO,MAAM,uBAAuB,CAAC,aAAa,CAAC,EAAE,EAAE,MAAM,CAAC,EAAE,CAAC,CAAA;wBACnE,CAAC;wBAAC,MAAM,CAAC;4BACP,OAAO,MAAM,CAAA;wBACf,CAAC;oBACH,CAAC;oBACD,OAAO,MAAM,CAAA;gBACf,CAAC;aACF;YACH,CAAC,CAAC,EAAE,CAAC;QACP,GAAG,CAAC,mBAAmB;YACrB,CAAC,CAAC;gBACE,mBAAmB,EAAE,KAAK,EAAE,EAAE,EAAE,EAAE,EAAE,EAAE;oBACpC,MAAM,mBAAmB,CAAC,QAAQ,CAAC,EAAE,EAAE,EAAE,CAAC,CAAA;gBAC5C,CAAC;aACF;YACH,CAAC,CAAC,EAAE,CAAC;QACP,GAAG,CAAC,aAAa,CAAC,CAAC,CAAC,EAAE,aAAa,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAC3C,iBAAiB;QACjB,YAAY;QACZ,SAAS;QACT,QAAQ;KACT,CAAC,CAAA;IACF,MAAM,4BAA4B,GAAG,IAAI,4BAA4B,CAAC;QACpE,eAAe;QACf,mBAAmB;QACnB,UAAU;QACV,aAAa;QACb,cAAc;QACd,mBAAmB;QACnB,GAAG,CAAC,0BAA0B,CAAC,CAAC,CAAC,EAAE,0BAA0B,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QACrE,iBAAiB;QACjB,YAAY;QACZ,SAAS;QACT,QAAQ;KACT,CAAC,CAAA;IACF,MAAM,UAAU,GAAG,IAAI,oBAAoB,CAAC;QAC1C,eAAe;QACf,mBAAmB;QACnB,UAAU;QACV,YAAY;QACZ,SAAS;QACT,iBAAiB;QACjB,oBAAoB;KACrB,CAAC,CAAA;IACF,MAAM,sBAAsB,GAAG,IAAI,sBAAsB,CAAC;QACxD,eAAe;QACf,mBAAmB;QACnB,UAAU;QACV,YAAY;QACZ,SAAS;QACT,WAAW;QACX,KAAK;QACL,mBAAmB;QACnB,GAAG,CAAC,eAAe,CAAC,CAAC,CAAC,EAAE,eAAe,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;QAC/C,2BAA2B,EAAE,CAAC,EAAE,EAAE,KAAK,EAAE,EAAE,CACzC,cAAc,CAAC,2BAA2B,CAAC,EAAE,EAAE,KAAK,CAAC;KACxD,CAAC,CAAA;IACF,MAAM,kBAAkB,GAAG,IAAI,kBAAkB,CAAC;QAChD,mBAAmB;QACnB,UAAU;QACV,YAAY;QACZ,SAAS;QACT,WAAW;QACX,KAAK;QACL,mBAAmB;KACpB,CAAC,CAAA;IACF,OAAO;QACL,gBAAgB;QAChB,eAAe;QACf,mBAAmB;QACnB,4BAA4B;QAC5B,UAAU;QACV,sBAAsB;QACtB,kBAAkB;KACnB,CAAA;AACH,CAAC;AAsBD;;;;;GAKG;AACH,MAAM,UAAU,mBAAmB,CAAC,IAAuB;IACzD,MAAM,EACJ,eAAe,EACf,mBAAmB,EACnB,UAAU,EACV,YAAY,EACZ,SAAS,EACT,uBAAuB,EACvB,wBAAwB,EACxB,oBAAoB,EACpB,kBAAkB,EAClB,cAAc,EACd,iBAAiB,EACjB,0BAA0B,EAC1B,mBAAmB,GACpB,GAAG,IAAI,CAAA;IACR,0FAA0F;IAC1F,6FAA6F;IAC7F,iDAAiD;IACjD,MAAM,cAAc,GAAG;QACrB,MAAM,EAAE,uBAAuB;QAC/B,eAAe;QACf,mBAAmB;QACnB,wBAAwB;QACxB,oBAAoB;QACpB,kBAAkB;QAClB,cAAc;KACf,CAAA;IACD,MAAM,gBAAgB,GAAG,qBAAqB,CAAC,cAAc,CAAC,CAAA;IAC9D,MAAM,WAAW,GAAG,gBAAgB,CAAC,cAAc,CAAC,CAAA;IACpD,MAAM,0BAA0B,GAAG,mBAAmB,CACpD,cAAc,EACd,kCAAkC,EAClC,cAAc,CACf,CAAA;IACD,MAAM,0BAA0B,GAAG,mBAAmB,CACpD,cAAc,EACd,kCAAkC,EAClC,cAAc,CACf,CAAA;IACD,qFAAqF;IACrF,0FAA0F;IAC1F,sFAAsF;IACtF,wFAAwF;IACxF,wFAAwF;IACxF,MAAM,6BAA6B,GAAG,iBAAiB;QACrD,CAAC,CAAC,IAAI,6BAA6B,CAAC;YAChC,eAAe;YACf,mBAAmB;YACnB,UAAU;YACV,YAAY;YACZ,SAAS;YACT,gBAAgB,EAAE,0BAA0B;YAC5C,iBAAiB;SAClB,CAAC;QACJ,CAAC,CAAC,SAAS,CAAA;IACb,0FAA0F;IAC1F,0FAA0F;IAC1F,kFAAkF;IAClF,MAAM,sBAAsB,GAAG,mBAAmB;QAChD,CAAC,CAAC,IAAI,sBAAsB,CAAC;YACzB,eAAe;YACf,mBAAmB;YACnB,UAAU;YACV,YAAY;YACZ,SAAS;YACT,MAAM,EAAE,uBAAuB;YAC/B,mBAAmB;SACpB,CAAC;QACJ,CAAC,CAAC,SAAS,CAAA;IACb,OAAO;QACL,gBAAgB;QAChB,WAAW;QACX,0BAA0B;QAC1B,0BAA0B;QAC1B,6BAA6B;QAC7B,sBAAsB;KACvB,CAAA;AACH,CAAC"}

package/dist/modules/execution/prReport.logic.d.ts

@@ -0,0 +1,25 @@
+import type { Block, ExecutionInstance, PrReportIssue, PrVerificationReport } from '@cat-factory/kernel';
+/** The non-run inputs the composer needs beyond the instance itself. */
+export interface PrReportInputs {
+    block: Block;
+    /** Tracker issues linked to the task (one `listByBlock` read — never a per-issue loop). */
+    issues: PrReportIssue[];
+    /** `owner/name` of the repo the run targeted, when resolved. */
+    repo?: string | null;
+    /** The VCS provider that repo lives on (neutral vocabulary — never assumed GitHub). */
+    provider?: 'github' | 'gitlab' | null;
+    /** Deep link into the run's observability panel; null when no public app URL is configured. */
+    runUrl: string | null;
+    /** Epoch ms stamped as the report's `generatedAt`. */
+    now: number;
+}
+/** Compose the report from a run's in-memory state plus the few resolved inputs. */
+export declare function composePrVerificationReport(instance: ExecutionInstance, inputs: PrReportInputs): PrVerificationReport;
+/**
+ * Render the report as the managed PR-body section: human-readable markdown followed by a
+ * fenced JSON block carrying the exact {@link PrVerificationReport} shape, so external
+ * tooling can ingest it without scraping prose. The caller splices the result into the PR
+ * body between the kernel's markers — this function emits the section CONTENTS only.
+ */
+export declare function renderPrVerificationReport(report: PrVerificationReport): string;
+//# sourceMappingURL=prReport.logic.d.ts.map

package/dist/modules/execution/prReport.logic.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"prReport.logic.d.ts","sourceRoot":"","sources":["../../../src/modules/execution/prReport.logic.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,KAAK,EACL,iBAAiB,EAMjB,aAAa,EACb,oBAAoB,EAErB,MAAM,qBAAqB,CAAA;AAuD5B,wEAAwE;AACxE,MAAM,WAAW,cAAc;IAC7B,KAAK,EAAE,KAAK,CAAA;IACZ,2FAA2F;IAC3F,MAAM,EAAE,aAAa,EAAE,CAAA;IACvB,gEAAgE;IAChE,IAAI,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IACpB,uFAAuF;IACvF,QAAQ,CAAC,EAAE,QAAQ,GAAG,QAAQ,GAAG,IAAI,CAAA;IACrC,+FAA+F;IAC/F,MAAM,EAAE,MAAM,GAAG,IAAI,CAAA;IACrB,sDAAsD;IACtD,GAAG,EAAE,MAAM,CAAA;CACZ;AAmOD,oFAAoF;AACpF,wBAAgB,2BAA2B,CACzC,QAAQ,EAAE,iBAAiB,EAC3B,MAAM,EAAE,cAAc,GACrB,oBAAoB,CAiCtB;AAoJD;;;;;GAKG;AACH,wBAAgB,0BAA0B,CAAC,MAAM,EAAE,oBAAoB,GAAG,MAAM,CAsC/E"}