npm - @cat-factory/orchestration - Versions diffs - 0.129.2 → 0.129.4 - Mend

@cat-factory/orchestration 0.129.2 → 0.129.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (13) hide show

package/dist/modules/execution/dispatcher-registries.js ADDED Viewed

@@ -0,0 +1,451 @@
+import { INITIATIVE_ANALYST_AGENT_KIND, INITIATIVE_COMMITTER_AGENT_KIND, INITIATIVE_PLANNER_AGENT_KIND, } from '@cat-factory/kernel';
+import { FORK_PROPOSER_KIND, PR_REVIEWER_KIND, hasTrait, isCompanionKind, isContainerBackedCompanion, INTERVIEW_GATE_TRAIT, TASK_ESTIMATOR_AGENT_KIND, } from '@cat-factory/agents';
+import { DEPLOYER_AGENT_KIND, isDeployStep } from '@cat-factory/integrations';
+import { BUG_INTAKE_AGENT_KIND } from '../pipelines/pipelineShape.js';
+import { coerceTaskEstimate, summarizeEstimate } from '../estimation/estimate.logic.js';
+import { renderInvestigationDigest } from './bugInvestigation.logic.js';
+import { renderReproDigest } from './reproTest.logic.js';
+import { ARCHITECTURE_BRAINSTORM_AGENT_KIND, BLUEPRINTS_AGENT_KIND, BUG_INVESTIGATOR_AGENT_KIND, CLARITY_REVIEW_AGENT_KIND, HUMAN_TEST_AGENT_KIND, isTesterKind, MERGER_AGENT_KIND, REPRO_TEST_AGENT_KIND, REQUIREMENTS_BRAINSTORM_AGENT_KIND, REQUIREMENTS_REVIEW_AGENT_KIND, SPEC_WRITER_AGENT_KIND, TRACKER_AGENT_KIND, VISUAL_CONFIRM_AGENT_KIND, } from './ci.logic.js';
+import { PrReviewController, PR_REVIEW_STEP_KIND } from './PrReviewController.js';
+import { forkPhasePending, resolveForkTriState } from './forkDecision.logic.js';
+import { isRalphKind } from './ralph.logic.js';
+import { FALLTHROUGH_STEP_HANDLER_ORDER, } from './step-handler-registry.js';
+/**
+ * The inline review/brainstorm gate kinds, all driven through the {@link ReviewGateController}
+ * by the dispatcher's `review-gate` StepHandler. Kept in sync with the handler's `switch`.
+ */
+const REVIEW_GATE_AGENT_KINDS = new Set([
+    REQUIREMENTS_REVIEW_AGENT_KIND,
+    CLARITY_REVIEW_AGENT_KIND,
+    REQUIREMENTS_BRAINSTORM_AGENT_KIND,
+    ARCHITECTURE_BRAINSTORM_AGENT_KIND,
+]);
+/**
+ * Build the order-sorted per-step-kind handler list (built-ins constructed inline, closing over
+ * the injected {@link DispatcherRegistryDeps}). Engine-internal: there is no public
+ * `registerStepHandler` seam. Phase 0 registers only the generic fallthrough; later phases
+ * prepend more-specific handlers with lower `order`.
+ */
+export function buildStepHandlerRegistry(d) {
+    const handlers = [
+        // A `deployer` step provisions an ephemeral environment deterministically via the
+        // provider — no LLM, no token usage — when the integration is wired. Unwired, its
+        // `canHandle` is false so the step falls through to the generic agent path.
+        {
+            kind: DEPLOYER_AGENT_KIND,
+            order: 100,
+            canHandle: ({ step }) => !!d.environmentProvisioning && isDeployStep(step.agentKind),
+            handle: ({ workspaceId, instance, step, block, isFinalStep }) => d.deployer.runDeployerStep(workspaceId, instance, step, block, isFinalStep),
+        },
+        // A `tracker` step files a GitHub issue / Jira ticket from the preceding `analysis`
+        // output (the tech-debt pipeline) — no LLM of its own. It is a pass-through when no
+        // tracker provider is wired or none is configured for the workspace (handled inside
+        // {@link runTracker}, which still records a result), so it always claims the step.
+        {
+            kind: TRACKER_AGENT_KIND,
+            order: 110,
+            canHandle: ({ step }) => step.agentKind === TRACKER_AGENT_KIND,
+            handle: async ({ workspaceId, instance, step, block, isFinalStep }) => {
+                const result = await d.runTracker(workspaceId, instance, block);
+                return d.recordStepResult(workspaceId, instance, step, isFinalStep, result);
+            },
+        },
+        // A `bug-intake` step (the recurring bug-triage pipeline) pulls ONE matching open issue from
+        // the schedule's tracker board, claims it, and seeds the reused block from it — no LLM of its
+        // own, the inbound dual of `tracker`. On no match (or no task source wired) it completes the
+        // run successfully, skipping every remaining step. Handled entirely inside
+        // {@link runBugIntake}, so it always claims the step.
+        {
+            kind: BUG_INTAKE_AGENT_KIND,
+            order: 111,
+            canHandle: ({ step }) => step.agentKind === BUG_INTAKE_AGENT_KIND,
+            handle: ({ workspaceId, instance, step, block, isFinalStep }) => d.runBugIntake(workspaceId, instance, step, block, isFinalStep),
+        },
+        // The interactive-INTERVIEWER gates (`initiative-interviewer`, `doc-interviewer`, …): an
+        // inline LLM gate that PARKS the run on a decision-wait while the human answers the
+        // interviewer's questions through a dedicated window, then synthesizes a brief and advances
+        // (see {@link InterviewGateController}). Routed by the `interview-gate` TRAIT — the same
+        // marker the re-park + approval guards key off — and dispatched to the controller registered
+        // for the step's `agentKind`, so a new interviewer just carries the trait + wires its
+        // controller (no new branch here). Pass-through when the interviewer isn't wired (no model /
+        // no store) so pipelines + conformance run unchanged; a wired-but-unmatched trait kind is a
+        // pipeline authoring error, but we still advance rather than wedge the run.
+        {
+            kind: 'interview-gate',
+            order: 113,
+            canHandle: ({ step }) => hasTrait(step.agentKind, INTERVIEW_GATE_TRAIT, d.agentKindRegistry),
+            handle: ({ workspaceId, instance, step, block, isFinalStep }) => {
+                const controller = d.interviewControllers.get(step.agentKind);
+                return controller
+                    ? controller.evaluate(workspaceId, instance, step, block, isFinalStep)
+                    : d.recordStepResult(workspaceId, instance, step, isFinalStep, { output: '' });
+            },
+        },
+        // The `initiative-committer` step persists an APPROVED initiative plan: it runs
+        // strictly after the planner's human gate, flips the entity to `executing`, and
+        // mirrors the tracker into the repo (`docs/initiatives/<slug>/`) when GitHub is
+        // wired — no LLM of its own (the `tracker`-style deterministic one-shot).
+        {
+            kind: INITIATIVE_COMMITTER_AGENT_KIND,
+            order: 115,
+            canHandle: ({ step }) => step.agentKind === INITIATIVE_COMMITTER_AGENT_KIND,
+            handle: async ({ workspaceId, instance, step, block, isFinalStep }) => {
+                const outcome = await d.runInitiativeCommitter(workspaceId, block);
+                if (outcome.kind === 'failed') {
+                    return { kind: 'job_failed', error: outcome.error, failureKind: 'agent' };
+                }
+                return d.recordStepResult(workspaceId, instance, step, isFinalStep, outcome.result);
+            },
+        },
+        // The `requirements-review` / `clarity-review` / `requirements-brainstorm` /
+        // `architecture-brainstorm` steps are inline reviewers that park for their dedicated
+        // window and drive the iterative answer → incorporate → re-review loop — NOT
+        // container/prose agents. All four run through the {@link ReviewGateController},
+        // parameterised by their {@link ReviewKind} (the per-case `switch` binds each kind's
+        // review type so `evaluate`'s generic infers). Pass-through when the service isn't wired.
+        {
+            kind: 'review-gate',
+            order: 120,
+            canHandle: ({ step }) => REVIEW_GATE_AGENT_KINDS.has(step.agentKind),
+            handle: ({ workspaceId, instance, step, block, isFinalStep }) => {
+                switch (step.agentKind) {
+                    case REQUIREMENTS_REVIEW_AGENT_KIND:
+                        return d.reviewGate.evaluate(d.requirementsKind, workspaceId, instance, step, block, isFinalStep);
+                    case CLARITY_REVIEW_AGENT_KIND:
+                        return d.reviewGate.evaluate(d.clarityKind, workspaceId, instance, step, block, isFinalStep);
+                    case REQUIREMENTS_BRAINSTORM_AGENT_KIND:
+                        return d.reviewGate.evaluate(d.requirementsBrainstormKind, workspaceId, instance, step, block, isFinalStep);
+                    case ARCHITECTURE_BRAINSTORM_AGENT_KIND:
+                        return d.reviewGate.evaluate(d.architectureBrainstormKind, workspaceId, instance, step, block, isFinalStep);
+                    // `canHandle` admits only the kinds in REVIEW_GATE_AGENT_KINDS, so every member
+                    // must have an explicit case above. Throw loudly if the two ever drift (a new
+                    // review kind added to the Set without a case here) rather than silently routing
+                    // it to the wrong reviewer.
+                    default:
+                        throw new Error(`Unhandled review-gate agentKind "${step.agentKind}"`);
+                }
+            },
+        },
+        // A `human-test` gate spins up an ephemeral environment and PARKS for a human to
+        // validate the change in a live URL — NOT a container/prose agent and NOT a
+        // programmatic polling gate (the human is the verdict). Degrades to a manual (no-env)
+        // mode when no ephemeral-environment provider is wired. See {@link HumanTestController}.
+        {
+            kind: HUMAN_TEST_AGENT_KIND,
+            order: 130,
+            canHandle: ({ step }) => step.agentKind === HUMAN_TEST_AGENT_KIND,
+            handle: ({ workspaceId, instance, step, block, isFinalStep }) => d.humanTestController.evaluate(workspaceId, instance, step, block, isFinalStep),
+        },
+        // A `visual-confirmation` gate gathers the UI tester's screenshots + uploaded reference
+        // designs and PARKS for a human to review actual-vs-reference, then on demand dispatches
+        // the Tester's `fixer`. Passes through when no binary-artifact store is wired.
+        // See {@link VisualConfirmationController}.
+        {
+            kind: VISUAL_CONFIRM_AGENT_KIND,
+            order: 140,
+            canHandle: ({ step }) => step.agentKind === VISUAL_CONFIRM_AGENT_KIND,
+            handle: ({ workspaceId, instance, step, block, isFinalStep }) => d.visualConfirmationController.evaluate(workspaceId, instance, step, block, isFinalStep),
+        },
+        // A polling gate step (`ci` / `conflicts` / `post-release-health` / `human-review`) runs
+        // a programmatic precheck and only escalates to a helper container agent on a negative
+        // verdict — no LLM of its own. Pass-through when the gate's provider is not wired. One
+        // generic machine drives every gate; see {@link evaluateGate}. `canHandle` is the gate
+        // registry lookup, so this claims exactly the registered gate kinds.
+        {
+            kind: 'polling-gate',
+            order: 150,
+            canHandle: ({ step }) => d.gateFor(step.agentKind) !== undefined,
+            handle: ({ workspaceId, instance, step, block, isFinalStep }) => d.evaluateGate(workspaceId, instance, step, block, isFinalStep, d.gateFor(step.agentKind)),
+        },
+        // An INLINE companion (architect-companion / spec-companion) grades the nearest
+        // preceding producer right here and loops it back for automatic rework below the
+        // threshold before any human gate. CONTAINER-backed companions (reviewer / doc-reviewer)
+        // do NOT match — they fall through to the generic async container dispatch and have their
+        // verdict resolved by the completion interceptor instead. See {@link CompanionController}.
+        {
+            kind: 'inline-companion',
+            order: 160,
+            canHandle: ({ step }) => isCompanionKind(step.agentKind) && !isContainerBackedCompanion(step.agentKind),
+            handle: ({ workspaceId, instance, step, block, isFinalStep, options }) => d.companionController.evaluate(workspaceId, instance, step, block, isFinalStep, options),
+        },
+        // The optional implementation-fork decision phase on a Coder step (Phase A): when the
+        // per-task tri-state + the risk-policy gate call for it, dispatch the read-only
+        // `fork-proposer` explore job as a helper off THIS coder step. Claims the step only
+        // while the phase is pending (tri-state not `off`, not yet resolved); once resolved
+        // (`chosen` / `single_path` / `skipped`) it falls through so the Coder dispatches
+        // normally (Phase B). A parked `awaiting_choice` step is short-circuited by the
+        // run-lifecycle re-entry guard before this handler runs. See {@link handleForkDecisionPhase}.
+        {
+            kind: 'fork-decision',
+            order: 170,
+            canHandle: ({ step, block }) => forkPhasePending(step, resolveForkTriState(block.agentConfig)),
+            handle: (ctx) => d.handleForkDecisionPhase(ctx),
+        },
+        // The PR deep-review RESOLUTION phase (PR 3): after the human resolved a parked review with
+        // `fix` / `post`, `PrReviewController.resolve` re-armed this `pr-reviewer` step and woke the
+        // driver. Claim it by the re-armed status so it re-dispatches as the Fixer (`fixing`) or
+        // posts the selected findings as inline PR comments (`posting`) — never the generic
+        // pr-reviewer clone the fallthrough would run. A `reviewing`/`awaiting_selection`/resolved
+        // step falls through (this handler doesn't claim it). See {@link handlePrReviewResolution}.
+        {
+            kind: 'pr-review-resolution',
+            order: 175,
+            canHandle: ({ step }) => step.agentKind === PR_REVIEW_STEP_KIND &&
+                (step.prReview?.status === 'fixing' || step.prReview?.status === 'posting'),
+            handle: (ctx) => d.handlePrReviewResolution(ctx),
+        },
+        // The generic container/inline-agent step — claims every step no more-specific handler
+        // did. Highest order so it always runs last. See {@link handleAgentStep}.
+        {
+            kind: 'agent',
+            order: FALLTHROUGH_STEP_HANDLER_ORDER,
+            canHandle: () => true,
+            handle: (ctx) => d.handleAgentStep(ctx),
+        },
+    ];
+    return handlers.sort((a, b) => a.order - b.order);
+}
+/**
+ * Build the order-sorted completion-path interceptors (companion / tester verdict
+ * short-circuits), mirroring {@link buildStepHandlerRegistry}.
+ */
+export function buildStepCompletionInterceptors(d) {
+    const interceptors = [
+        // A container-backed companion (reviewer / doc-reviewer) just finished reviewing the
+        // real repository on the producer's PR branch and returned its verdict as
+        // `result.custom`. Hand it to the companion loop, which parses the verdict and applies
+        // the SAME threshold / rework / human-gate handling an inline companion gets. Routed
+        // here (not the normal step completion) so the verdict drives the loop instead of being
+        // recorded as plain output. Falls through (returns null) when the block can't be loaded.
+        {
+            kind: 'companion-verdict',
+            order: 100,
+            canIntercept: ({ step }) => isCompanionKind(step.agentKind) && isContainerBackedCompanion(step.agentKind),
+            intercept: async ({ workspaceId, instance, step, isFinalStep, result }) => {
+                const companionBlock = await d.blockRepository.get(workspaceId, instance.blockId);
+                if (!companionBlock)
+                    return null;
+                return d.companionController.resolveContainerVerdict(workspaceId, instance, step, companionBlock, isFinalStep, result);
+            },
+        },
+        // The `fork-proposer` explore job (Phase A of the fork decision) just finished on a
+        // coder step. Its structured `result.custom` is the proposal; record it onto the step's
+        // `forkDecision` and either park for the human to choose (≥2 usable forks) or auto-advance
+        // a single path — never the normal output/PR/follow-up/approval completion (none applies
+        // to the proposer). Keyed on the coder step carrying `forkDecision.status === 'proposing'`.
+        {
+            kind: 'fork-proposal',
+            order: 105,
+            canIntercept: ({ step }) => step.agentKind === 'coder' && step.forkDecision?.status === 'proposing',
+            intercept: ({ workspaceId, instance, step, result }) => {
+                const proposal = d.agentKindRegistry
+                    .structuredOutput(FORK_PROPOSER_KIND)
+                    ?.safeParse(result.custom);
+                return d.forkDecisionController.recordProposal(workspaceId, instance, step, proposal, step.model);
+            },
+        },
+        // The read-only `pr-reviewer` deep-review job just finished on a review task's step. Its
+        // structured `result.custom` is the sliced, prioritized findings; record them onto the
+        // step's `prReview` and PARK for the human to select which findings matter (≥1 finding),
+        // rather than the normal completion. A clean PR (no findings) returns null and falls
+        // through to the normal finish. Keyed on the `pr-reviewer` step kind.
+        {
+            kind: 'pr-review',
+            order: 106,
+            canIntercept: ({ step }) => step.agentKind === PR_REVIEW_STEP_KIND,
+            intercept: async ({ workspaceId, instance, step, result }) => {
+                const output = d.agentKindRegistry
+                    .structuredOutput(PR_REVIEWER_KIND)
+                    ?.safeParse(result.custom);
+                const block = await d.blockRepository.get(workspaceId, instance.blockId);
+                return d.prReviewController.recordFindings(workspaceId, instance, step, output, result.model ?? step.model, block);
+            },
+        },
+        // A `tester` step returned a structured report. On a withheld greenlight we do NOT
+        // finish the step: loop the `fixer` (within the attempt budget) and re-test, mirroring
+        // the CI gate. A greenlight (or no provider) returns null and falls through to the
+        // normal finish/advance below. Records the report on the step either way.
+        {
+            kind: 'tester-verdict',
+            order: 110,
+            canIntercept: ({ step, result }) => isTesterKind(step.agentKind) && result.testReport !== undefined,
+            intercept: ({ workspaceId, instance, step, result }) => d.testerController.resolveTesterResult(workspaceId, instance, step, result),
+        },
+        // A `ralph` iteration finished and the harness attached its programmatic validation
+        // verdict. Hand it to the ralph loop: a passing command finishes + advances (returns
+        // null → normal completion), a failing one re-dispatches a fresh iteration within the
+        // budget or gives up for a human — never the normal single-shot completion. Keyed on the
+        // `ralph` kind carrying a `ralphVerdict`; a ralph run that errored before validation (no
+        // verdict) falls through to the normal failure path.
+        {
+            kind: 'ralph-verdict',
+            order: 115,
+            canIntercept: ({ step, result }) => isRalphKind(step.agentKind) && result.ralphVerdict !== undefined,
+            intercept: ({ workspaceId, instance, step, result }) => d.ralphController.resolveRalphResult(workspaceId, instance, step, result),
+        },
+    ];
+    return interceptors.sort((a, b) => a.order - b.order);
+}
+/**
+ * Build the post-completion / terminal step-resolver registry, keyed by `agentKind`. The
+ * built-in `merger` resolver (which owns terminal status) plus the post-completion result
+ * reshapers are constructed inline; deployment-registered resolvers are merged last (last
+ * registration wins).
+ */
+export function buildStepResolverRegistry(d) {
+    const resolvers = [
+        // The `merger` agent OWNS the merge decision, but the merge itself is mechanical
+        // and uses backend-held GitHub credentials the sandboxed agent never sees — so the
+        // engine performs it deterministically from the agent's assessment here, the moment
+        // the merger step finishes (NOT only when it is the pipeline's last step, which is
+        // why a trailing `post-release-health` step no longer disables auto-merge).
+        {
+            kind: MERGER_AGENT_KIND,
+            applies: (result) => result.mergeAssessment !== undefined,
+            resolve: async ({ workspaceId, instance, step, result }) => {
+                // The real merge runs the engine GitHub client under the run initiator's
+                // ambient context, so a per-user PAT (when set) authors the merge.
+                const decision = await d.runInitiatorScope(instance.initiatedBy, () => d.mergeResolver.resolveMergerStep(workspaceId, instance, result.mergeAssessment));
+                // Record the structured verdict on the step so the SPA's dedicated merger result
+                // view renders the assessment + explains the auto-merge / awaiting-review decision,
+                // instead of showing the agent's raw JSON.
+                if (decision) {
+                    step.custom = decision;
+                    // Drop the raw JSON only when we captured a structured assessment (the view
+                    // renders it from `step.custom`). When the merger produced NO parseable
+                    // assessment, keep the raw reply so an operator can still diagnose what it sent.
+                    if (decision.assessment)
+                        step.output = '';
+                }
+                return { ownsTerminalStatus: true };
+            },
+        },
+        // POST-COMPLETION resolvers — run at the early slot (after output is recorded, before
+        // the follow-up/approval gates), reshaping the agent's structured result into domain
+        // state. Lifted verbatim from the old inline `recordStepResult` branches.
+        //
+        // A Blueprinter step produced a fresh service decomposition. Validate it with the
+        // authoritative schema (a bad payload must never touch the board), then reconcile it
+        // in place onto the run's service frame.
+        {
+            kind: BLUEPRINTS_AGENT_KIND,
+            phase: 'post-completion',
+            resolve: async ({ workspaceId, instance, result }) => {
+                if (result.blueprintService !== undefined) {
+                    await d.ingestBlueprint(workspaceId, instance.blockId, result.blueprintService);
+                }
+            },
+        },
+        // An initiative-analyst step produced a prose codebase analysis. Fold it onto the
+        // block's `initiatives` entity (`analysisSummary`) so the planner's prompt is grounded
+        // in it. Best-effort: an empty analysis or an unwired store simply leaves the summary
+        // unchanged (the planner still runs); never fail the run on a missing analysis.
+        {
+            kind: INITIATIVE_ANALYST_AGENT_KIND,
+            phase: 'post-completion',
+            resolve: async ({ workspaceId, instance, result }) => {
+                const summary = result.output?.trim();
+                if (!d.initiativeService || !summary)
+                    return;
+                await d.initiativeService.recordAnalysis(workspaceId, instance.blockId, summary);
+            },
+        },
+        // An initiative-planner step produced a plan draft. Ingest it into the block's
+        // `initiatives` entity (strict-parse at the trust boundary; replay-idempotent —
+        // the same draft re-applies to identical content). The run then parks at the
+        // planner's human gate; the committer step later mirrors the APPROVED plan into
+        // the repo. A malformed draft fails the step loudly — completing the run without
+        // an ingested plan would strand the initiative in `planning` with a green run.
+        {
+            kind: INITIATIVE_PLANNER_AGENT_KIND,
+            phase: 'post-completion',
+            resolve: async ({ workspaceId, instance, result }) => {
+                if (!d.initiativeService)
+                    return;
+                if (result.initiativePlan === undefined) {
+                    throw new Error('The initiative planner returned no usable plan (malformed or empty JSON)');
+                }
+                const ingested = await d.initiativeService.ingestPlan(workspaceId, instance.blockId, result.initiativePlan);
+                if (!ingested) {
+                    throw new Error('No initiative entity found for this block — cannot ingest the plan');
+                }
+            },
+        },
+        // A spec-writer step produced the service's unified specification (`spec.json`) and
+        // committed it to the implementation branch — strict-validate it then nudge clients —
+        // and reports its BUSINESS-vs-TECHNICAL determination. "No business specs" (a purely
+        // technical task) is a valid outcome the spec-companion's convergence later combines
+        // with its `technicalCorroborated` verdict; recorded even when false so a re-run
+        // reflects the latest.
+        {
+            kind: SPEC_WRITER_AGENT_KIND,
+            phase: 'post-completion',
+            resolve: async ({ workspaceId, step, result }) => {
+                if (result.spec !== undefined)
+                    await d.ingestSpec(workspaceId, result.spec);
+                step.noBusinessSpecs = result.noBusinessSpecs === true;
+            },
+        },
+        // A `task-estimator` step emits a JSON triage (complexity/risk/impact). Parse it
+        // tolerantly, persist it on the block (used to gate consensus steps + surfaced in the
+        // UI), and replace the raw JSON output with a readable summary. An unparseable estimate
+        // leaves the block untouched and keeps the raw output (no run failure). Works the same
+        // whether the single-actor estimator or the consensus ranked-scoring variant produced
+        // the JSON. Running at the post-completion slot keeps the summary in `step.output`
+        // before the approval gate reads it as the proposal.
+        // A `bug-investigator` step returns its STRUCTURED triage as `result.custom` (kept on
+        // `step.custom` for the generic-structured view + the clarity gate's structured read).
+        // Render a prose digest into `step.output` at the post-completion slot so downstream
+        // steps (estimator / repro-test / coder) read the investigation via `priorOutputs`
+        // (which carries only `step.output`), and the clarity gate's investigation-prose context
+        // sees it too. An unparseable result leaves the agent's raw reply on `step.output`.
+        {
+            kind: BUG_INVESTIGATOR_AGENT_KIND,
+            phase: 'post-completion',
+            applies: (result) => result.custom !== undefined,
+            resolve: async ({ result }) => {
+                const digest = renderInvestigationDigest(result.custom);
+                if (digest)
+                    return { output: digest };
+            },
+        },
+        // A `repro-test` step returns its STRUCTURED outcome as `result.custom` (kept on
+        // `step.custom` for the generic-structured view). Render a short prose digest into
+        // `step.output` at the post-completion slot so the coder reads the reproduction result
+        // (reproduced / conceded + why) via `priorOutputs` (which carries only `step.output`).
+        // Conceding never fails the run — the container tolerates a no-op (`noChangesTolerated`),
+        // so this only reshapes the output. An unparseable result leaves the raw reply on
+        // `step.output`.
+        {
+            kind: REPRO_TEST_AGENT_KIND,
+            phase: 'post-completion',
+            applies: (result) => result.custom !== undefined,
+            resolve: async ({ result }) => {
+                const digest = renderReproDigest(result.custom);
+                if (digest)
+                    return { output: digest };
+            },
+        },
+        {
+            kind: TASK_ESTIMATOR_AGENT_KIND,
+            phase: 'post-completion',
+            resolve: async ({ workspaceId, instance, step, result }) => {
+                const estimate = coerceTaskEstimate(step.output ?? '', result.model ?? step.model ?? null, d.clock.now());
+                if (estimate) {
+                    await d.blockRepository.update(workspaceId, instance.blockId, { estimate });
+                    return { output: summarizeEstimate(estimate) };
+                }
+            },
+        },
+    ];
+    const map = new Map(resolvers.map((r) => [r.kind, r]));
+    // Merge deployment-registered resolvers, mirroring the gate registry below. A
+    // registered resolver of the same kind replaces the built-in (last registration wins).
+    // The registry is the app-owned instance injected through `CoreDependencies`, not a
+    // module global.
+    const ctx = { runInitiatorScope: d.runInitiatorScope };
+    for (const { kind, factory } of d.stepResolverRegistry.factories())
+        map.set(kind, factory(ctx));
+    return map;
+}
+//# sourceMappingURL=dispatcher-registries.js.map

package/dist/modules/execution/dispatcher-registries.js.map ADDED Viewed

@@ -0,0 +1 @@

+ {"version":3,"file":"dispatcher-registries.js","sourceRoot":"","sources":["../../../src/modules/execution/dispatcher-registries.ts"],"names":[],"mappings":"AAkBA,OAAO,EACL,6BAA6B,EAC7B,+BAA+B,EAC/B,6BAA6B,GAC9B,MAAM,qBAAqB,CAAA;AAC5B,OAAO,EACL,kBAAkB,EAClB,gBAAgB,EAChB,QAAQ,EACR,eAAe,EACf,0BAA0B,EAC1B,oBAAoB,EACpB,yBAAyB,GAC1B,MAAM,qBAAqB,CAAA;AAE5B,OAAO,EAAE,mBAAmB,EAAE,YAAY,EAAE,MAAM,2BAA2B,CAAA;AAE7E,OAAO,EAAE,qBAAqB,EAAE,MAAM,+BAA+B,CAAA;AACrE,OAAO,EAAE,kBAAkB,EAAE,iBAAiB,EAAE,MAAM,iCAAiC,CAAA;AACvF,OAAO,EAAE,yBAAyB,EAAE,MAAM,6BAA6B,CAAA;AACvE,OAAO,EAAE,iBAAiB,EAAE,MAAM,sBAAsB,CAAA;AACxD,OAAO,EACL,kCAAkC,EAClC,qBAAqB,EACrB,2BAA2B,EAC3B,yBAAyB,EACzB,qBAAqB,EACrB,YAAY,EACZ,iBAAiB,EACjB,qBAAqB,EACrB,kCAAkC,EAClC,8BAA8B,EAC9B,sBAAsB,EACtB,kBAAkB,EAClB,yBAAyB,GAC1B,MAAM,eAAe,CAAA;AAOtB,OAAO,EAAE,kBAAkB,EAAE,mBAAmB,EAAE,MAAM,yBAAyB,CAAA;AACjF,OAAO,EAAE,gBAAgB,EAAE,mBAAmB,EAAE,MAAM,yBAAyB,CAAA;AAI/E,OAAO,EAAE,WAAW,EAAE,MAAM,kBAAkB,CAAA;AAE9C,OAAO,EACL,8BAA8B,GAI/B,MAAM,4BAA4B,CAAA;AAInC;;;GAGG;AACH,MAAM,uBAAuB,GAAwB,IAAI,GAAG,CAAC;IAC3D,8BAA8B;IAC9B,yBAAyB;IACzB,kCAAkC;IAClC,kCAAkC;CACnC,CAAC,CAAA;AAyEF;;;;;GAKG;AACH,MAAM,UAAU,wBAAwB,CAAC,CAAyB;IAChE,MAAM,QAAQ,GAAkB;QAC9B,kFAAkF;QAClF,kFAAkF;QAClF,4EAA4E;QAC5E;YACE,IAAI,EAAE,mBAAmB;YACzB,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,uBAAuB,IAAI,YAAY,CAAC,IAAI,CAAC,SAAS,CAAC;YACpF,MAAM,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,EAAE,EAAE,CAC9D,CAAC,CAAC,QAAQ,CAAC,eAAe,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,CAAC;SAC9E;QACD,oFAAoF;QACpF,oFAAoF;QACpF,oFAAoF;QACpF,mFAAmF;QACnF;YACE,IAAI,EAAE,kBAAkB;YACxB,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,KAAK,kBAAkB;YAC9D,MAAM,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,EAAE,EAAE;gBACpE,MAAM,MAAM,GAAG,MAAM,CAAC,CAAC,UAAU,CAAC,WAAW,EAAE,QAAQ,EAAE,KAAK,CAAC,CAAA;gBAC/D,OAAO,CAAC,CAAC,gBAAgB,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,EAAE,MAAM,CAAC,CAAA;YAC7E,CAAC;SACF;QACD,6FAA6F;QAC7F,8FAA8F;QAC9F,6FAA6F;QAC7F,2EAA2E;QAC3E,sDAAsD;QACtD;YACE,IAAI,EAAE,qBAAqB;YAC3B,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,KAAK,qBAAqB;YACjE,MAAM,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,EAAE,EAAE,CAC9D,CAAC,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,CAAC;SAClE;QACD,yFAAyF;QACzF,oFAAoF;QACpF,4FAA4F;QAC5F,yFAAyF;QACzF,6FAA6F;QAC7F,sFAAsF;QACtF,6FAA6F;QAC7F,4FAA4F;QAC5F,4EAA4E;QAC5E;YACE,IAAI,EAAE,gBAAgB;YACtB,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,QAAQ,CAAC,IAAI,CAAC,SAAS,EAAE,oBAAoB,EAAE,CAAC,CAAC,iBAAiB,CAAC;YAC5F,MAAM,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,EAAE,EAAE;gBAC9D,MAAM,UAAU,GAAG,CAAC,CAAC,oBAAoB,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;gBAC7D,OAAO,UAAU;oBACf,CAAC,CAAC,UAAU,CAAC,QAAQ,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,CAAC;oBACtE,CAAC,CAAC,CAAC,CAAC,gBAAgB,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,CAAC,CAAA;YAClF,CAAC;SACF;QACD,gFAAgF;QAChF,gFAAgF;QAChF,gFAAgF;QAChF,0EAA0E;QAC1E;YACE,IAAI,EAAE,+BAA+B;YACrC,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,KAAK,+BAA+B;YAC3E,MAAM,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,EAAE,EAAE;gBACpE,MAAM,OAAO,GAAG,MAAM,CAAC,CAAC,sBAAsB,CAAC,WAAW,EAAE,KAAK,CAAC,CAAA;gBAClE,IAAI,OAAO,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oBAC9B,OAAO,EAAE,IAAI,EAAE,YAAY,EAAE,KAAK,EAAE,OAAO,CAAC,KAAK,EAAE,WAAW,EAAE,OAAO,EAAE,CAAA;gBAC3E,CAAC;gBACD,OAAO,CAAC,CAAC,gBAAgB,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,EAAE,OAAO,CAAC,MAAM,CAAC,CAAA;YACrF,CAAC;SACF;QACD,6EAA6E;QAC7E,qFAAqF;QACrF,6EAA6E;QAC7E,iFAAiF;QACjF,qFAAqF;QACrF,0FAA0F;QAC1F;YACE,IAAI,EAAE,aAAa;YACnB,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,uBAAuB,CAAC,GAAG,CAAC,IAAI,CAAC,SAAS,CAAC;YACpE,MAAM,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,EAAE,EAAE;gBAC9D,QAAQ,IAAI,CAAC,SAAS,EAAE,CAAC;oBACvB,KAAK,8BAA8B;wBACjC,OAAO,CAAC,CAAC,UAAU,CAAC,QAAQ,CAC1B,CAAC,CAAC,gBAAgB,EAClB,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,KAAK,EACL,WAAW,CACZ,CAAA;oBACH,KAAK,yBAAyB;wBAC5B,OAAO,CAAC,CAAC,UAAU,CAAC,QAAQ,CAC1B,CAAC,CAAC,WAAW,EACb,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,KAAK,EACL,WAAW,CACZ,CAAA;oBACH,KAAK,kCAAkC;wBACrC,OAAO,CAAC,CAAC,UAAU,CAAC,QAAQ,CAC1B,CAAC,CAAC,0BAA0B,EAC5B,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,KAAK,EACL,WAAW,CACZ,CAAA;oBACH,KAAK,kCAAkC;wBACrC,OAAO,CAAC,CAAC,UAAU,CAAC,QAAQ,CAC1B,CAAC,CAAC,0BAA0B,EAC5B,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,KAAK,EACL,WAAW,CACZ,CAAA;oBACH,gFAAgF;oBAChF,8EAA8E;oBAC9E,iFAAiF;oBACjF,4BAA4B;oBAC5B;wBACE,MAAM,IAAI,KAAK,CAAC,oCAAoC,IAAI,CAAC,SAAS,GAAG,CAAC,CAAA;gBAC1E,CAAC;YACH,CAAC;SACF;QACD,iFAAiF;QACjF,4EAA4E;QAC5E,sFAAsF;QACtF,yFAAyF;QACzF;YACE,IAAI,EAAE,qBAAqB;YAC3B,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,KAAK,qBAAqB;YACjE,MAAM,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,EAAE,EAAE,CAC9D,CAAC,CAAC,mBAAmB,CAAC,QAAQ,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,CAAC;SAClF;QACD,wFAAwF;QACxF,yFAAyF;QACzF,+EAA+E;QAC/E,4CAA4C;QAC5C;YACE,IAAI,EAAE,yBAAyB;YAC/B,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,KAAK,yBAAyB;YACrE,MAAM,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,EAAE,EAAE,CAC9D,CAAC,CAAC,4BAA4B,CAAC,QAAQ,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,CAAC;SAC3F;QACD,yFAAyF;QACzF,uFAAuF;QACvF,uFAAuF;QACvF,uFAAuF;QACvF,qEAAqE;QACrE;YACE,IAAI,EAAE,cAAc;YACpB,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC,KAAK,SAAS;YAChE,MAAM,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,EAAE,EAAE,CAC9D,CAAC,CAAC,YAAY,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,SAAS,CAAE,CAAC;SAC9F;QACD,gFAAgF;QAChF,iFAAiF;QACjF,yFAAyF;QACzF,0FAA0F;QAC1F,2FAA2F;QAC3F;YACE,IAAI,EAAE,kBAAkB;YACxB,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CACtB,eAAe,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,0BAA0B,CAAC,IAAI,CAAC,SAAS,CAAC;YAChF,MAAM,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,OAAO,EAAE,EAAE,EAAE,CACvE,CAAC,CAAC,mBAAmB,CAAC,QAAQ,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,OAAO,CAAC;SAC3F;QACD,sFAAsF;QACtF,gFAAgF;QAChF,oFAAoF;QACpF,oFAAoF;QACpF,kFAAkF;QAClF,gFAAgF;QAChF,8FAA8F;QAC9F;YACE,IAAI,EAAE,eAAe;YACrB,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,EAAE,EAAE,CAC7B,gBAAgB,CAAC,IAAI,EAAE,mBAAmB,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC;YAChE,MAAM,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC,CAAC,uBAAuB,CAAC,GAAG,CAAC;SAChD;QACD,4FAA4F;QAC5F,6FAA6F;QAC7F,yFAAyF;QACzF,oFAAoF;QACpF,2FAA2F;QAC3F,4FAA4F;QAC5F;YACE,IAAI,EAAE,sBAAsB;YAC5B,KAAK,EAAE,GAAG;YACV,SAAS,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CACtB,IAAI,CAAC,SAAS,KAAK,mBAAmB;gBACtC,CAAC,IAAI,CAAC,QAAQ,EAAE,MAAM,KAAK,QAAQ,IAAI,IAAI,CAAC,QAAQ,EAAE,MAAM,KAAK,SAAS,CAAC;YAC7E,MAAM,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC,CAAC,wBAAwB,CAAC,GAAG,CAAC;SACjD;QACD,uFAAuF;QACvF,0EAA0E;QAC1E;YACE,IAAI,EAAE,OAAO;YACb,KAAK,EAAE,8BAA8B;YACrC,SAAS,EAAE,GAAG,EAAE,CAAC,IAAI;YACrB,MAAM,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC,CAAC,eAAe,CAAC,GAAG,CAAC;SACxC;KACF,CAAA;IACD,OAAO,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC,CAAA;AACnD,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,+BAA+B,CAC7C,CAAyB;IAEzB,MAAM,YAAY,GAAgC;QAChD,qFAAqF;QACrF,0EAA0E;QAC1E,uFAAuF;QACvF,qFAAqF;QACrF,wFAAwF;QACxF,yFAAyF;QACzF;YACE,IAAI,EAAE,mBAAmB;YACzB,KAAK,EAAE,GAAG;YACV,YAAY,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CACzB,eAAe,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,0BAA0B,CAAC,IAAI,CAAC,SAAS,CAAC;YAC/E,SAAS,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,EAAE,MAAM,EAAE,EAAE,EAAE;gBACxE,MAAM,cAAc,GAAG,MAAM,CAAC,CAAC,eAAe,CAAC,GAAG,CAAC,WAAW,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAA;gBACjF,IAAI,CAAC,cAAc;oBAAE,OAAO,IAAI,CAAA;gBAChC,OAAO,CAAC,CAAC,mBAAmB,CAAC,uBAAuB,CAClD,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,cAAc,EACd,WAAW,EACX,MAAM,CACP,CAAA;YACH,CAAC;SACF;QACD,oFAAoF;QACpF,wFAAwF;QACxF,2FAA2F;QAC3F,yFAAyF;QACzF,4FAA4F;QAC5F;YACE,IAAI,EAAE,eAAe;YACrB,KAAK,EAAE,GAAG;YACV,YAAY,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CACzB,IAAI,CAAC,SAAS,KAAK,OAAO,IAAI,IAAI,CAAC,YAAY,EAAE,MAAM,KAAK,WAAW;YACzE,SAAS,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE;gBACrD,MAAM,QAAQ,GAAG,CAAC,CAAC,iBAAiB;qBACjC,gBAAgB,CAAC,kBAAkB,CAAC;oBACrC,EAAE,SAAS,CAAC,MAAM,CAAC,MAAM,CAA6B,CAAA;gBACxD,OAAO,CAAC,CAAC,sBAAsB,CAAC,cAAc,CAC5C,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,QAAQ,EACR,IAAI,CAAC,KAAK,CACX,CAAA;YACH,CAAC;SACF;QACD,yFAAyF;QACzF,uFAAuF;QACvF,yFAAyF;QACzF,qFAAqF;QACrF,sEAAsE;QACtE;YACE,IAAI,EAAE,WAAW;YACjB,KAAK,EAAE,GAAG;YACV,YAAY,EAAE,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,KAAK,mBAAmB;YAClE,SAAS,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE;gBAC3D,MAAM,MAAM,GAAG,CAAC,CAAC,iBAAiB;qBAC/B,gBAAgB,CAAC,gBAAgB,CAAC;oBACnC,EAAE,SAAS,CAAC,MAAM,CAAC,MAAM,CAAoC,CAAA;gBAC/D,MAAM,KAAK,GAAG,MAAM,CAAC,CAAC,eAAe,CAAC,GAAG,CAAC,WAAW,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAA;gBACxE,OAAO,CAAC,CAAC,kBAAkB,CAAC,cAAc,CACxC,WAAW,EACX,QAAQ,EACR,IAAI,EACJ,MAAM,EACN,MAAM,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,EAC1B,KAAK,CACN,CAAA;YACH,CAAC;SACF;QACD,mFAAmF;QACnF,uFAAuF;QACvF,mFAAmF;QACnF,0EAA0E;QAC1E;YACE,IAAI,EAAE,gBAAgB;YACtB,KAAK,EAAE,GAAG;YACV,YAAY,EAAE,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,CACjC,YAAY,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,MAAM,CAAC,UAAU,KAAK,SAAS;YACjE,SAAS,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,CACrD,CAAC,CAAC,gBAAgB,CAAC,mBAAmB,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,CAAC;SAC9E;QACD,oFAAoF;QACpF,qFAAqF;QACrF,sFAAsF;QACtF,yFAAyF;QACzF,yFAAyF;QACzF,qDAAqD;QACrD;YACE,IAAI,EAAE,eAAe;YACrB,KAAK,EAAE,GAAG;YACV,YAAY,EAAE,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,CACjC,WAAW,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,MAAM,CAAC,YAAY,KAAK,SAAS;YAClE,SAAS,EAAE,CAAC,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,CACrD,CAAC,CAAC,eAAe,CAAC,kBAAkB,CAAC,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,CAAC;SAC5E;KACF,CAAA;IACD,OAAO,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,GAAG,CAAC,CAAC,KAAK,CAAC,CAAA;AACvD,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,yBAAyB,CACvC,CAAyB;IAEzB,MAAM,SAAS,GAA6B;QAC1C,iFAAiF;QACjF,mFAAmF;QACnF,oFAAoF;QACpF,mFAAmF;QACnF,4EAA4E;QAC5E;YACE,IAAI,EAAE,iBAAiB;YACvB,OAAO,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,eAAe,KAAK,SAAS;YACzD,OAAO,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE;gBACzD,yEAAyE;gBACzE,mEAAmE;gBACnE,MAAM,QAAQ,GAAG,MAAM,CAAC,CAAC,iBAAiB,CAAC,QAAQ,CAAC,WAAW,EAAE,GAAG,EAAE,CACpE,CAAC,CAAC,aAAa,CAAC,iBAAiB,CAAC,WAAW,EAAE,QAAQ,EAAE,MAAM,CAAC,eAAe,CAAC,CACjF,CAAA;gBACD,iFAAiF;gBACjF,oFAAoF;gBACpF,2CAA2C;gBAC3C,IAAI,QAAQ,EAAE,CAAC;oBACb,IAAI,CAAC,MAAM,GAAG,QAAQ,CAAA;oBACtB,4EAA4E;oBAC5E,wEAAwE;oBACxE,iFAAiF;oBACjF,IAAI,QAAQ,CAAC,UAAU;wBAAE,IAAI,CAAC,MAAM,GAAG,EAAE,CAAA;gBAC3C,CAAC;gBACD,OAAO,EAAE,kBAAkB,EAAE,IAAI,EAAE,CAAA;YACrC,CAAC;SACF;QACD,sFAAsF;QACtF,qFAAqF;QACrF,0EAA0E;QAC1E,EAAE;QACF,kFAAkF;QAClF,qFAAqF;QACrF,yCAAyC;QACzC;YACE,IAAI,EAAE,qBAAqB;YAC3B,KAAK,EAAE,iBAAiB;YACxB,OAAO,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE;gBACnD,IAAI,MAAM,CAAC,gBAAgB,KAAK,SAAS,EAAE,CAAC;oBAC1C,MAAM,CAAC,CAAC,eAAe,CAAC,WAAW,EAAE,QAAQ,CAAC,OAAO,EAAE,MAAM,CAAC,gBAAgB,CAAC,CAAA;gBACjF,CAAC;YACH,CAAC;SACF;QACD,kFAAkF;QAClF,uFAAuF;QACvF,sFAAsF;QACtF,gFAAgF;QAChF;YACE,IAAI,EAAE,6BAA6B;YACnC,KAAK,EAAE,iBAAiB;YACxB,OAAO,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE;gBACnD,MAAM,OAAO,GAAG,MAAM,CAAC,MAAM,EAAE,IAAI,EAAE,CAAA;gBACrC,IAAI,CAAC,CAAC,CAAC,iBAAiB,IAAI,CAAC,OAAO;oBAAE,OAAM;gBAC5C,MAAM,CAAC,CAAC,iBAAiB,CAAC,cAAc,CAAC,WAAW,EAAE,QAAQ,CAAC,OAAO,EAAE,OAAO,CAAC,CAAA;YAClF,CAAC;SACF;QACD,+EAA+E;QAC/E,gFAAgF;QAChF,6EAA6E;QAC7E,gFAAgF;QAChF,iFAAiF;QACjF,+EAA+E;QAC/E;YACE,IAAI,EAAE,6BAA6B;YACnC,KAAK,EAAE,iBAAiB;YACxB,OAAO,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE;gBACnD,IAAI,CAAC,CAAC,CAAC,iBAAiB;oBAAE,OAAM;gBAChC,IAAI,MAAM,CAAC,cAAc,KAAK,SAAS,EAAE,CAAC;oBACxC,MAAM,IAAI,KAAK,CACb,0EAA0E,CAC3E,CAAA;gBACH,CAAC;gBACD,MAAM,QAAQ,GAAG,MAAM,CAAC,CAAC,iBAAiB,CAAC,UAAU,CACnD,WAAW,EACX,QAAQ,CAAC,OAAO,EAChB,MAAM,CAAC,cAAc,CACtB,CAAA;gBACD,IAAI,CAAC,QAAQ,EAAE,CAAC;oBACd,MAAM,IAAI,KAAK,CAAC,oEAAoE,CAAC,CAAA;gBACvF,CAAC;YACH,CAAC;SACF;QACD,oFAAoF;QACpF,sFAAsF;QACtF,qFAAqF;QACrF,qFAAqF;QACrF,iFAAiF;QACjF,uBAAuB;QACvB;YACE,IAAI,EAAE,sBAAsB;YAC5B,KAAK,EAAE,iBAAiB;YACxB,OAAO,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE;gBAC/C,IAAI,MAAM,CAAC,IAAI,KAAK,SAAS;oBAAE,MAAM,CAAC,CAAC,UAAU,CAAC,WAAW,EAAE,MAAM,CAAC,IAAI,CAAC,CAAA;gBAC3E,IAAI,CAAC,eAAe,GAAG,MAAM,CAAC,eAAe,KAAK,IAAI,CAAA;YACxD,CAAC;SACF;QACD,iFAAiF;QACjF,sFAAsF;QACtF,wFAAwF;QACxF,uFAAuF;QACvF,sFAAsF;QACtF,mFAAmF;QACnF,qDAAqD;QACrD,sFAAsF;QACtF,uFAAuF;QACvF,qFAAqF;QACrF,mFAAmF;QACnF,yFAAyF;QACzF,oFAAoF;QACpF;YACE,IAAI,EAAE,2BAA2B;YACjC,KAAK,EAAE,iBAAiB;YACxB,OAAO,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,MAAM,KAAK,SAAS;YAChD,OAAO,EAAE,KAAK,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE;gBAC5B,MAAM,MAAM,GAAG,yBAAyB,CAAC,MAAM,CAAC,MAAM,CAAC,CAAA;gBACvD,IAAI,MAAM;oBAAE,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,CAAA;YACvC,CAAC;SACF;QACD,iFAAiF;QACjF,mFAAmF;QACnF,uFAAuF;QACvF,uFAAuF;QACvF,0FAA0F;QAC1F,kFAAkF;QAClF,iBAAiB;QACjB;YACE,IAAI,EAAE,qBAAqB;YAC3B,KAAK,EAAE,iBAAiB;YACxB,OAAO,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,MAAM,KAAK,SAAS;YAChD,OAAO,EAAE,KAAK,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE;gBAC5B,MAAM,MAAM,GAAG,iBAAiB,CAAC,MAAM,CAAC,MAAM,CAAC,CAAA;gBAC/C,IAAI,MAAM;oBAAE,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,CAAA;YACvC,CAAC;SACF;QACD;YACE,IAAI,EAAE,yBAAyB;YAC/B,KAAK,EAAE,iBAAiB;YACxB,OAAO,EAAE,KAAK,EAAE,EAAE,WAAW,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE;gBACzD,MAAM,QAAQ,GAAG,kBAAkB,CACjC,IAAI,CAAC,MAAM,IAAI,EAAE,EACjB,MAAM,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,IAAI,IAAI,EAClC,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,CACd,CAAA;gBACD,IAAI,QAAQ,EAAE,CAAC;oBACb,MAAM,CAAC,CAAC,eAAe,CAAC,MAAM,CAAC,WAAW,EAAE,QAAQ,CAAC,OAAO,EAAE,EAAE,QAAQ,EAAE,CAAC,CAAA;oBAC3E,OAAO,EAAE,MAAM,EAAE,iBAAiB,CAAC,QAAQ,CAAC,EAAE,CAAA;gBAChD,CAAC;YACH,CAAC;SACF;KACF,CAAA;IACD,MAAM,GAAG,GAAG,IAAI,GAAG,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,CAAA;IACtD,8EAA8E;IAC9E,uFAAuF;IACvF,oFAAoF;IACpF,iBAAiB;IACjB,MAAM,GAAG,GAAoB,EAAE,iBAAiB,EAAE,CAAC,CAAC,iBAAiB,EAAE,CAAA;IACvE,KAAK,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,IAAI,CAAC,CAAC,oBAAoB,CAAC,SAAS,EAAE;QAAE,GAAG,CAAC,GAAG,CAAC,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,CAAC,CAAA;IAC/F,OAAO,GAAG,CAAA;AACZ,CAAC"}

package/dist/modules/requirements/RequirementReviewService.d.ts CHANGED Viewed

@@ -123,6 +123,13 @@ export declare class RequirementReviewService extends IterativeReviewService<Req
     }): Promise<{
         produced: number;
     }>;
+    /**
+     * Apply one Writer suggestion to its live placeholder against a fresh read, mutating `review` in
+     * place. Extracted from the chunk-application loop so that loop stays within the max-depth ceiling
+     * (the auto-accept/answered branch nested three levels below the loop). Returns whether the target
+     * produced a recommendation and whether it became a `ready` card the human must review.
+     */
+    private applyRecommendationToTarget;
     /**
      * Drop every `pending` placeholder on a review and reopen its source finding (the same cleanup
      * the per-finding failure path does, applied to the whole batch). Used when the Writer can't run

package/dist/modules/requirements/RequirementReviewService.d.ts.map CHANGED Viewed

	@@ -1 +1 @@
1	- {"version":3,"file":"RequirementReviewService.d.ts","sourceRoot":"","sources":["../../../src/modules/requirements/RequirementReviewService.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,KAAK,EAIL,iBAAiB,EACjB,qBAAqB,EACrB,yBAAyB,EACzB,qBAAqB,EACtB,MAAM,qBAAqB,CAAA;AAC5B,OAAO,KAAK,EAAE,kBAAkB,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAA;AAC7E,OAAO,KAAK,EAAE,2BAA2B,EAAE,MAAM,qBAAqB,CAAA;AAUtE,OAAO,EACL,KAAK,mBAAmB,EACxB,sBAAsB,EACtB,KAAK,YAAY,EACjB,KAAK,gBAAgB,EACtB,MAAM,qCAAqC,CAAA;AAC5C,OAAO,EACL,KAAK,iBAAiB,EACtB,KAAK,kBAAkB,EAEvB,KAAK,mBAAmB,EAQzB,MAAM,yBAAyB,CAAA;AAShC,MAAM,WAAW,oCAAqC,SAAQ,mBAAmB;IAC/E,2BAA2B,EAAE,2BAA2B,CAAA;IACxD,sFAAsF;IACtF,kBAAkB,CAAC,EAAE,kBAAkB,CAAA;IACvC,qFAAqF;IACrF,cAAc,CAAC,EAAE,cAAc,CAAA;IAC/B;;;;OAIG;IACH,qBAAqB,CAAC,EAAE,qBAAqB,CAAA;IAC7C;;;OAGG;IACH,qBAAqB,CAAC,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,KAAK,OAAO,CAAC,iBAAiB,EAAE,CAAC,CAAA;IAC9F;;;;OAIG;IACH,SAAS,CAAC,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,KAAK,OAAO,CAAC,kBAAkB,EAAE,CAAC,CAAA;IACjF;;;;;OAKG;IACH,0BAA0B,CAAC,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,KAAK,OAAO,CAAC,MAAM,GAAG,SAAS,CAAC,CAAA;CACnG;AAED;;;;;;GAMG;AACH,qBAAa,wBAAyB,SAAQ,sBAAsB,CAClE,iBAAiB,EACjB,mBAAmB,CACpB;IACC,SAAS,CAAC,QAAQ,CAAC,UAAU,EAAE,gBAAgB,CAAC,iBAAiB,CAAC,CAAA;IAClE,OAAO,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAoB;IACxD,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAgB;IAChD,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAAC,CAAuB;IAC9D,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAAC,CAGN;IACjC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAuE;IAClG,OAAO,CAAC,QAAQ,CAAC,0BAA0B,CAAC,CAGZ;IAEhC,YAAY,IAAI,EAAE,oCAAoC,EASrD;IAED,SAAS,CAAC,QAAQ,CAAC,UAAU,wBAAuB;IACpD,SAAS,CAAC,QAAQ,CAAC,aAAa,2BAA0B;IAC1D,SAAS,CAAC,QAAQ,CAAC,eAAe,yBAAwB;IAC1D,SAAS,CAAC,QAAQ,CAAC,eAAe,yBAAwB;IAC1D,SAAS,CAAC,QAAQ,CAAC,kBAAkB,SAAuB;IAC5D,SAAS,CAAC,QAAQ,CAAC,kBAAkB,SAAuB;IAC5D,SAAS,CAAC,QAAQ,CAAC,cAAc,SAAQ;IACzC,SAAS,CAAC,QAAQ,CAAC,YAAY,SAAQ;IACvC,SAAS,CAAC,QAAQ,CAAC,WAAW,0BAAyB;IACvD,SAAS,CAAC,QAAQ,CAAC,iBAAiB,SAEwC;IAC5E,SAAS,CAAC,QAAQ,CAAC,gBAAgB,EAAG,oBAAoB,CAAS;IACnE,SAAS,CAAC,QAAQ,CAAC,mBAAmB,kBAAiB;IAEvD,SAAS,CAAC,iBAAiB,CAAC,KAAK,EAAE,KAAK,GAAG,MAAM,CAEhD;IAED,SAAS,CAAC,iBAAiB,CAAC,GAAG,EAAE,mBAAmB,GAAG,MAAM,CAE5D;IAED,SAAS,CAAC,iBAAiB,CAAC,GAAG,EAAE,mBAAmB,EAAE,KAAK,EAAE,qBAAqB,EAAE,GAAG,MAAM,CAE5F;IAED,SAAS,CAAC,oBAAoB,CAAC,GAAG,EAAE,mBAAmB,EAAE,GAAG,EAAE,MAAM,GAAG,IAAI,CAE1E;IAED,SAAS,CAAC,aAAa,CAAC,GAAG,EAAE,mBAAmB,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI,CAExE;IAED,SAAS,CAAC,OAAO,CAAC,MAAM,EAAE,iBAAiB,GAAG,MAAM,GAAG,IAAI,CAE1D;IAED,SAAS,CAAC,OAAO,CAAC,MAAM,EAAE,iBAAiB,EAAE,GAAG,EAAE,MAAM,GAAG,iBAAiB,CAE3E;IAED,SAAS,CAAC,SAAS,CAAC,MAAM,EAAE,YAAY,GAAG,iBAAiB,CAE3D;IAID,oEAAoE;IACpE,IAAI,aAAa,IAAI,OAAO,CAE3B;IAED;;;;;;;;;;;;;;OAcG;IACG,aAAa,CACjB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,IAAI,GAAE;QAAE,UAAU,CAAC,EAAE,CAAC,MAAM,EAAE,iBAAiB,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;KAAO,GACvE,OAAO,CAAC,iBAAiB,CAAC,CAa5B;IAED;;;;;;;;;;OAUG;IACG,sBAAsB,CAC1B,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,KAAK,EAAE,yBAAyB,EAAE,EAClC,IAAI,GAAE;QAAE,IAAI,CAAC,EAAE,OAAO,CAAA;KAAO,GAC5B,OAAO,CAAC,iBAAiB,CAAC,CAyC5B;IAED;;;;;;;;;;;;;OAaG;IACG,0BAA0B,CAC9B,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,IAAI,GAAE;QAAE,UAAU,CAAC,EAAE,CAAC,MAAM,EAAE,iBAAiB,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;KAAO,GACvE,OAAO,CAAC;QAAE,QAAQ,EAAE,MAAM,CAAA;KAAE,CAAC,~~CAgJ~~/B;IAED;;;;;OAKG;YACW,0BAA0B;IAuBxC;;;;;;OAMG;IACG,yBAAyB,CAC7B,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,KAAK,EAAE,MAAM,EACb,IAAI,EAAE,MAAM,GACX,OAAO,CAAC,iBAAiB,CAAC,CAe5B;IAED;;;;OAIG;IACG,oBAAoB,CACxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,KAAK,EAAE,MAAM,GACZ,OAAO,CAAC,iBAAiB,CAAC,CAU5B;IAED;;;;OAIG;IACG,oBAAoB,CACxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,KAAK,EAAE,MAAM,GACZ,OAAO,CAAC,iBAAiB,CAAC,CAS5B;IAED;;;;;;;OAOG;YACW,iBAAiB;YAgDjB,oBAAoB;IAqBlC;;;;OAIG;YACW,kBAAkB;IAgBhC;;;;;OAKG;YACW,gBAAgB;IAY9B;;;;;OAKG;YACW,0BAA0B;IA6BxC,4EAA4E;IAC5E,UAAgB,aAAa,CAAC,WAAW,EAAE,MAAM,EAAE,KAAK,EAAE,KAAK,GAAG,OAAO,CAAC,mBAAmB,CAAC,CA8B7F;CACF"}
1	+ {"version":3,"file":"RequirementReviewService.d.ts","sourceRoot":"","sources":["../../../src/modules/requirements/RequirementReviewService.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,KAAK,EAIL,iBAAiB,EACjB,qBAAqB,EACrB,yBAAyB,EACzB,qBAAqB,EACtB,MAAM,qBAAqB,CAAA;AAC5B,OAAO,KAAK,EAAE,kBAAkB,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAA;AAC7E,OAAO,KAAK,EAAE,2BAA2B,EAAE,MAAM,qBAAqB,CAAA;AAUtE,OAAO,EACL,KAAK,mBAAmB,EACxB,sBAAsB,EACtB,KAAK,YAAY,EACjB,KAAK,gBAAgB,EACtB,MAAM,qCAAqC,CAAA;AAC5C,OAAO,EACL,KAAK,iBAAiB,EACtB,KAAK,kBAAkB,EAEvB,KAAK,mBAAmB,EAQzB,MAAM,yBAAyB,CAAA;AAShC,MAAM,WAAW,oCAAqC,SAAQ,mBAAmB;IAC/E,2BAA2B,EAAE,2BAA2B,CAAA;IACxD,sFAAsF;IACtF,kBAAkB,CAAC,EAAE,kBAAkB,CAAA;IACvC,qFAAqF;IACrF,cAAc,CAAC,EAAE,cAAc,CAAA;IAC/B;;;;OAIG;IACH,qBAAqB,CAAC,EAAE,qBAAqB,CAAA;IAC7C;;;OAGG;IACH,qBAAqB,CAAC,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,KAAK,OAAO,CAAC,iBAAiB,EAAE,CAAC,CAAA;IAC9F;;;;OAIG;IACH,SAAS,CAAC,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,KAAK,OAAO,CAAC,kBAAkB,EAAE,CAAC,CAAA;IACjF;;;;;OAKG;IACH,0BAA0B,CAAC,EAAE,CAAC,WAAW,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,KAAK,OAAO,CAAC,MAAM,GAAG,SAAS,CAAC,CAAA;CACnG;AAED;;;;;;GAMG;AACH,qBAAa,wBAAyB,SAAQ,sBAAsB,CAClE,iBAAiB,EACjB,mBAAmB,CACpB;IACC,SAAS,CAAC,QAAQ,CAAC,UAAU,EAAE,gBAAgB,CAAC,iBAAiB,CAAC,CAAA;IAClE,OAAO,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAoB;IACxD,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAgB;IAChD,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAAC,CAAuB;IAC9D,OAAO,CAAC,QAAQ,CAAC,qBAAqB,CAAC,CAGN;IACjC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAuE;IAClG,OAAO,CAAC,QAAQ,CAAC,0BAA0B,CAAC,CAGZ;IAEhC,YAAY,IAAI,EAAE,oCAAoC,EASrD;IAED,SAAS,CAAC,QAAQ,CAAC,UAAU,wBAAuB;IACpD,SAAS,CAAC,QAAQ,CAAC,aAAa,2BAA0B;IAC1D,SAAS,CAAC,QAAQ,CAAC,eAAe,yBAAwB;IAC1D,SAAS,CAAC,QAAQ,CAAC,eAAe,yBAAwB;IAC1D,SAAS,CAAC,QAAQ,CAAC,kBAAkB,SAAuB;IAC5D,SAAS,CAAC,QAAQ,CAAC,kBAAkB,SAAuB;IAC5D,SAAS,CAAC,QAAQ,CAAC,cAAc,SAAQ;IACzC,SAAS,CAAC,QAAQ,CAAC,YAAY,SAAQ;IACvC,SAAS,CAAC,QAAQ,CAAC,WAAW,0BAAyB;IACvD,SAAS,CAAC,QAAQ,CAAC,iBAAiB,SAEwC;IAC5E,SAAS,CAAC,QAAQ,CAAC,gBAAgB,EAAG,oBAAoB,CAAS;IACnE,SAAS,CAAC,QAAQ,CAAC,mBAAmB,kBAAiB;IAEvD,SAAS,CAAC,iBAAiB,CAAC,KAAK,EAAE,KAAK,GAAG,MAAM,CAEhD;IAED,SAAS,CAAC,iBAAiB,CAAC,GAAG,EAAE,mBAAmB,GAAG,MAAM,CAE5D;IAED,SAAS,CAAC,iBAAiB,CAAC,GAAG,EAAE,mBAAmB,EAAE,KAAK,EAAE,qBAAqB,EAAE,GAAG,MAAM,CAE5F;IAED,SAAS,CAAC,oBAAoB,CAAC,GAAG,EAAE,mBAAmB,EAAE,GAAG,EAAE,MAAM,GAAG,IAAI,CAE1E;IAED,SAAS,CAAC,aAAa,CAAC,GAAG,EAAE,mBAAmB,EAAE,QAAQ,EAAE,MAAM,GAAG,IAAI,CAExE;IAED,SAAS,CAAC,OAAO,CAAC,MAAM,EAAE,iBAAiB,GAAG,MAAM,GAAG,IAAI,CAE1D;IAED,SAAS,CAAC,OAAO,CAAC,MAAM,EAAE,iBAAiB,EAAE,GAAG,EAAE,MAAM,GAAG,iBAAiB,CAE3E;IAED,SAAS,CAAC,SAAS,CAAC,MAAM,EAAE,YAAY,GAAG,iBAAiB,CAE3D;IAID,oEAAoE;IACpE,IAAI,aAAa,IAAI,OAAO,CAE3B;IAED;;;;;;;;;;;;;;OAcG;IACG,aAAa,CACjB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,IAAI,GAAE;QAAE,UAAU,CAAC,EAAE,CAAC,MAAM,EAAE,iBAAiB,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;KAAO,GACvE,OAAO,CAAC,iBAAiB,CAAC,CAa5B;IAED;;;;;;;;;;OAUG;IACG,sBAAsB,CAC1B,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,KAAK,EAAE,yBAAyB,EAAE,EAClC,IAAI,GAAE;QAAE,IAAI,CAAC,EAAE,OAAO,CAAA;KAAO,GAC5B,OAAO,CAAC,iBAAiB,CAAC,CAyC5B;IAED;;;;;;;;;;;;;OAaG;IACG,0BAA0B,CAC9B,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,IAAI,GAAE;QAAE,UAAU,CAAC,EAAE,CAAC,MAAM,EAAE,iBAAiB,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;KAAO,GACvE,OAAO,CAAC;QAAE,QAAQ,EAAE,MAAM,CAAA;KAAE,CAAC,CAqH/B;IAED;;;;;OAKG;IACH,OAAO,CAAC,2BAA2B;IA2CnC;;;;;OAKG;YACW,0BAA0B;IAuBxC;;;;;;OAMG;IACG,yBAAyB,CAC7B,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,KAAK,EAAE,MAAM,EACb,IAAI,EAAE,MAAM,GACX,OAAO,CAAC,iBAAiB,CAAC,CAe5B;IAED;;;;OAIG;IACG,oBAAoB,CACxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,KAAK,EAAE,MAAM,GACZ,OAAO,CAAC,iBAAiB,CAAC,CAU5B;IAED;;;;OAIG;IACG,oBAAoB,CACxB,WAAW,EAAE,MAAM,EACnB,QAAQ,EAAE,MAAM,EAChB,KAAK,EAAE,MAAM,GACZ,OAAO,CAAC,iBAAiB,CAAC,CAS5B;IAED;;;;;;;OAOG;YACW,iBAAiB;YAgDjB,oBAAoB;IAqBlC;;;;OAIG;YACW,kBAAkB;IAgBhC;;;;;OAKG;YACW,gBAAgB;IAY9B;;;;;OAKG;YACW,0BAA0B;IA6BxC,4EAA4E;IAC5E,UAAgB,aAAa,CAAC,WAAW,EAAE,MAAM,EAAE,KAAK,EAAE,KAAK,GAAG,OAAO,CAAC,mBAAmB,CAAC,CA8B7F;CACF"}

package/dist/modules/requirements/RequirementReviewService.js CHANGED Viewed

@@ -237,46 +237,12 @@ export class RequirementReviewService extends IterativeReviewService {
                 // Re-read fresh before applying: the human may have acted during the Writer call.
                 const review = assertFound(await this.repository.get(workspaceId, reviewId), this.entityName, reviewId);
                 const now = this.deps.clock.now();
-                for (const { ph, finding } of targets) {
-                    const rec = review.recommendations.find((r) => r.id === ph.id);
-                    if (!rec || rec.status !== 'pending')
-                        continue;
-                    const suggestion = finding ? suggestions.get(finding.id) : undefined;
-                    if (suggestion) {
-                        const standard = suggestion.fromStandard
-                            ? fragmentById.get(suggestion.fromStandard)
-                            : undefined;
-                        rec.recommendedText = suggestion.recommendation;
-                        rec.groundedInFragment = standard ? { id: standard.id, title: standard.title } : null;
-                        rec.updatedAt = now;
-                        if (rec.auto) {
-                            // Auto-recommendation: accept it immediately as the finding's default answer, so
-                            // the human sees it pre-filled (editable / dismissable) rather than a card to act
-                            // on. Mirrors `acceptRecommendation`, matching the finding against the fresh read.
-                            rec.status = 'accepted';
-                            const item = findSourceItem(review.items, ph.sourceFinding);
-                            if (item) {
-                                item.reply = suggestion.recommendation;
-                                item.status = 'answered';
-                                item.updatedAt = now;
-                            }
-                        }
-                        else {
-                            rec.status = 'ready';
-                            readyForReview += 1;
-                        }
+                for (const target of targets) {
+                    const outcome = this.applyRecommendationToTarget(target, review, suggestions, fragmentById, now);
+                    if (outcome.produced)
                         produced += 1;
-                    }
-                    else {
-                        // The Writer failed for (or no longer matches) this finding: drop the dead placeholder
-                        // and reopen its finding so the human can answer it by hand.
-                        review.recommendations = review.recommendations.filter((r) => r.id !== ph.id);
-                        const item = findSourceItem(review.items, ph.sourceFinding);
-                        if (item && item.status === 'recommend_requested') {
-                            item.status = 'open';
-                            item.updatedAt = now;
-                        }
-                    }
+                    if (outcome.readyForReview)
+                        readyForReview += 1;
                 }
                 review.updatedAt = now;
                 await this.repository.upsert(workspaceId, review);
@@ -287,6 +253,49 @@ export class RequirementReviewService extends IterativeReviewService {
             await this.notifyRecommendationsReady(workspaceId, block, readyForReview);
         return { produced };
     }
+    /**
+     * Apply one Writer suggestion to its live placeholder against a fresh read, mutating `review` in
+     * place. Extracted from the chunk-application loop so that loop stays within the max-depth ceiling
+     * (the auto-accept/answered branch nested three levels below the loop). Returns whether the target
+     * produced a recommendation and whether it became a `ready` card the human must review.
+     */
+    applyRecommendationToTarget(target, review, suggestions, fragmentById, now) {
+        const { ph, finding } = target;
+        const rec = review.recommendations.find((r) => r.id === ph.id);
+        if (!rec || rec.status !== 'pending')
+            return { produced: false, readyForReview: false };
+        const suggestion = finding ? suggestions.get(finding.id) : undefined;
+        if (!suggestion) {
+            // The Writer failed for (or no longer matches) this finding: drop the dead placeholder
+            // and reopen its finding so the human can answer it by hand.
+            review.recommendations = review.recommendations.filter((r) => r.id !== ph.id);
+            const item = findSourceItem(review.items, ph.sourceFinding);
+            if (item && item.status === 'recommend_requested') {
+                item.status = 'open';
+                item.updatedAt = now;
+            }
+            return { produced: false, readyForReview: false };
+        }
+        const standard = suggestion.fromStandard ? fragmentById.get(suggestion.fromStandard) : undefined;
+        rec.recommendedText = suggestion.recommendation;
+        rec.groundedInFragment = standard ? { id: standard.id, title: standard.title } : null;
+        rec.updatedAt = now;
+        if (!rec.auto) {
+            rec.status = 'ready';
+            return { produced: true, readyForReview: true };
+        }
+        // Auto-recommendation: accept it immediately as the finding's default answer, so the human
+        // sees it pre-filled (editable / dismissable) rather than a card to act on. Mirrors
+        // `acceptRecommendation`, matching the finding against the fresh read.
+        rec.status = 'accepted';
+        const item = findSourceItem(review.items, ph.sourceFinding);
+        if (item) {
+            item.reply = suggestion.recommendation;
+            item.status = 'answered';
+            item.updatedAt = now;
+        }
+        return { produced: true, readyForReview: false };
+    }
     /**
      * Drop every `pending` placeholder on a review and reopen its source finding (the same cleanup
      * the per-finding failure path does, applied to the whole batch). Used when the Writer can't run