@cat-factory/app 0.37.2 → 0.38.0

package/app/stores/execution.spec.ts

@@ -0,0 +1,43 @@
+import { describe, it, expect, beforeEach } from 'vitest'
+import { useExecutionStore } from '~/stores/execution'
+import type { ExecutionInstance } from '~/types/domain'
+
+/**
+ * Minimal instance shape — the `decisionsByBlock` / `approvalsByBlock` getters only read
+ * `id`, `blockId` and each step's `{ decision, approval, agentKind }`, so a cast keeps the
+ * fixtures focused on the grouping behaviour rather than the full wire contract.
+ */
+function instance(id: string, blockId: string, steps: unknown[]): ExecutionInstance {
+  return { id, blockId, steps } as unknown as ExecutionInstance
+}
+
+describe('execution store gate grouping', () => {
+  let store: ReturnType<typeof useExecutionStore>
+  beforeEach(() => {
+    store = useExecutionStore()
+  })
+
+  it('decisionsByBlock groups open (unchosen) decisions by block', () => {
+    store.hydrate([
+      instance('e1', 'b1', [
+        { agentKind: 'coder', decision: { id: 'd1', chosen: null } },
+        { agentKind: 'coder', decision: { id: 'd2', chosen: 'yes' } }, // chosen ⇒ excluded
+      ]),
+      instance('e2', 'b2', [{ agentKind: 'architect', decision: { id: 'd3', chosen: null } }]),
+    ])
+    expect(store.decisionsByBlock.get('b1')?.map((d) => d.decision.id)).toEqual(['d1'])
+    expect(store.decisionsByBlock.get('b2')?.map((d) => d.decision.id)).toEqual(['d3'])
+    expect(store.decisionsByBlock.has('missing')).toBe(false)
+  })
+
+  it('approvalsByBlock groups pending approvals by block', () => {
+    store.hydrate([
+      instance('e1', 'b1', [
+        { agentKind: 'merger', approval: { id: 'a1', status: 'pending' } },
+        { agentKind: 'merger', approval: { id: 'a2', status: 'approved' } }, // not pending ⇒ excluded
+      ]),
+    ])
+    expect(store.approvalsByBlock.get('b1')?.map((a) => a.approval.id)).toEqual(['a1'])
+    expect(store.approvalsByBlock.get('b2')).toBeUndefined()
+  })
+})

package/app/stores/execution.ts

@@ -106,6 +106,23 @@ export const useExecutionStore = defineStore('execution', () => {
     return out
   })
 
+  /**
+   * Open decisions/approvals grouped by the block they belong to, so a board card
+   * resolves its own + its tasks' pending gates with O(1) lookups instead of
+   * re-filtering the global lists once per frame on every execution event.
+   */
+  function groupByBlock<T extends { blockId: string }>(items: T[]): Map<string, T[]> {
+    const map = new Map<string, T[]>()
+    for (const item of items) {
+      const list = map.get(item.blockId)
+      if (list) list.push(item)
+      else map.set(item.blockId, [item])
+    }
+    return map
+  }
+  const decisionsByBlock = computed(() => groupByBlock(openDecisions.value))
+  const approvalsByBlock = computed(() => groupByBlock(openApprovals.value))
+
   /**
    * Start `pipeline` against a block; the server marks the block in-progress. A block
    * pinned to an individual-usage model (Claude) needs the initiator's personal
@@ -279,6 +296,8 @@ export const useExecutionStore = defineStore('execution', () => {
     pendingDecisionCount,
     openDecisions,
     openApprovals,
+    decisionsByBlock,
+    approvalsByBlock,
     pendingApprovalCount,
     start,
     resolveDecision,

package/app/stores/github.ts

@@ -259,6 +259,22 @@ export const useGitHubStore = defineStore('github', () => {
     return api.commentGitHubIssue(workspace.requireId(), repoGithubId, number, body)
   }
 
+  /**
+   * Drop the per-workspace projection + connection state (called on workspace switch)
+   * so the prior workspace's repos/PRs/issues don't linger until the re-probe + reload
+   * land. `available` returns to `null` (unknown) so the onboarding gate re-resolves.
+   */
+  function reset() {
+    available.value = null
+    connection.value = null
+    installations.value = []
+    repos.value = []
+    availableRepos.value = []
+    pulls.value = []
+    issues.value = []
+    branches.value = {}
+  }
+
   return {
     available,
     connection,
@@ -300,5 +316,6 @@ export const useGitHubStore = defineStore('github', () => {
     openPullRequest,
     mergePullRequest,
     comment,
+    reset,
   }
 })

package/app/stores/requirements.ts

@@ -97,6 +97,17 @@ export const useRequirementsStore = defineStore('requirements', () => {
     reviews.value = { ...reviews.value, [review.blockId]: review }
   }
 
+  /** Drop all cached reviews + in-flight state (called on workspace switch). */
+  function reset() {
+    available.value = null
+    reviews.value = {}
+    reviewing.value = new Set()
+    incorporating.value = new Set()
+    recommending.value = new Set()
+    loadingByBlock.value = new Set()
+    inFlight.clear()
+  }
+
   function withFlag(set: typeof reviewing, key: string, on: boolean) {
     const next = new Set(set.value)
     if (on) next.add(key)
@@ -265,6 +276,7 @@ export const useRequirementsStore = defineStore('requirements', () => {
     acceptRecommendation,
     rejectRecommendation,
     reRequestRecommendation,
+    reset,
     // Patch the cache from a live `requirements` stream event.
     upsert: store,
   }

package/app/stores/workspace.ts

@@ -16,6 +16,11 @@ import { useRecurringPipelinesStore } from '~/stores/recurringPipelines'
 import { useServicesStore } from '~/stores/services'
 import { useAgentsStore } from '~/stores/agents'
 import { useTrackerStore } from '~/stores/tracker'
+import { useRequirementsStore } from '~/stores/requirements'
+import { useClarityStore } from '~/stores/clarity'
+import { useBrainstormStore } from '~/stores/brainstorm'
+import { useConsensusStore } from '~/stores/consensus'
+import { useGitHubStore } from '~/stores/github'
 
 /**
  * Owns the active workspace and bootstraps the app against the backend. On load
@@ -58,6 +63,18 @@ export const useWorkspaceStore = defineStore(
 
     /** Push a snapshot into the data stores. */
     function hydrate(snapshot: WorkspaceSnapshot) {
+      // A change of active board (or the first load) — drop the per-block caches that are
+      // NOT part of the snapshot (reviews, brainstorm/consensus sessions, the GitHub
+      // projection) so a switched-to board never shows the previous one's stale state.
+      // These are lazily reloaded/re-probed per board, so clearing on a same-board refresh
+      // would needlessly wipe an open review window — hence only on an actual id change.
+      if (workspaceId.value !== snapshot.workspace.id) {
+        useRequirementsStore().reset()
+        useClarityStore().reset()
+        useBrainstormStore().reset()
+        useConsensusStore().reset()
+        useGitHubStore().reset()
+      }
       workspaceId.value = snapshot.workspace.id
       spend.value = snapshot.spend ?? null
       // Keep the board list in step (e.g. a freshly created board, or a rename).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cat-factory/app",
-  "version": "0.37.2",
+  "version": "0.38.0",
   "description": "Reusable Nuxt layer for the Agent Architecture Board SPA (components, stores, composables, pages). Consume it from a thin deployment app via `extends: ['@cat-factory/app']` and point it at your backend with NUXT_PUBLIC_API_BASE. See deploy/frontend for an example.",
   "repository": {
     "type": "git",
@@ -32,7 +32,7 @@
     "pinia-plugin-persistedstate": "^4.7.1",
     "vue": "^3.5.38",
     "wretch": "^3.0.9",
-    "@cat-factory/contracts": "0.36.0"
+    "@cat-factory/contracts": "0.37.0"
   },
   "devDependencies": {
     "@toad-contracts/testing": "0.3.1",