@cat-factory/app 0.316.0 → 0.317.0

package/app/components/github/AddServiceFromRepoModal.vue

@@ -27,6 +27,7 @@ import VcsConnectSurfaces from '~/components/vcs/VcsConnectSurfaces.vue'
 import ServiceTestConfig from '~/components/panels/inspector/ServiceTestConfig.vue'
 import ServiceFragments from '~/components/panels/inspector/ServiceFragments.vue'
 import { appInstallationManageUrl, VCS_PROVIDER_LABELS } from '~/utils/vcs'
+import { prefilledRepoMatch, prefillProviderMismatch } from '~/composables/useAddRepoDeepLink'
 import SectionLabel from '~/components/common/SectionLabel.vue'
 import IconButton from '~/components/common/IconButton.vue'
 import AppModal from '~/components/common/AppModal.vue'
@@ -305,10 +306,26 @@ watch(
     if (!isOpen) return
     resetSelection()
     void loadRepos()
+    if (ui.addServicePrefill) repoSearch.value = ui.addServicePrefill.repo
   },
   { immediate: true },
 )
 
+// A deep link names one repository: select it as soon as the search lists it, once. A repository
+// the connection cannot reach never lists, which leaves the search's own empty state (and its
+// grant-access remedy) in front of the person.
+const prefillMismatch = computed(() =>
+  prefillProviderMismatch(ui.addServicePrefill, github.connected ? github.provider : null),
+)
+watch(repoResults, (repos) => {
+  const prefill = ui.addServicePrefill
+  if (!prefill || prefillMismatch.value || selectedRepoId.value !== undefined) return
+  const match = prefilledRepoMatch(prefill, repos)
+  if (!match || toRepoItem(match).disabled) return
+  selectedRepoId.value = match.githubId
+  ui.addServicePrefill = null
+})
+
 // A whole-repo service is added once (then configured inline). A monorepo instead
 // multi-selects directories and adds them together via `addServices`.
 const canAdd = computed(
@@ -511,6 +528,19 @@ function done() {
             </div>
           </UFormField>
 
+          <p
+            v-if="prefillMismatch"
+            class="text-sm text-app-warning-200/90"
+            data-testid="add-service-prefill-mismatch"
+          >
+            {{
+              t('github.addService.prefillProviderMismatch', {
+                repo: ui.addServicePrefill?.repo,
+                connected: providerLabel,
+              })
+            }}
+          </p>
+
           <UFormField
             :label="t('github.addService.repoType')"
             :description="t('github.addService.repoTypeHint')"

package/app/composables/useAddRepoDeepLink.spec.ts

@@ -0,0 +1,66 @@
+import { createPinia, setActivePinia } from 'pinia'
+import { beforeEach, describe, expect, it } from 'vitest'
+import type { GitHubAvailableRepo } from '~/types/domain'
+import {
+  captureAddRepoDeepLink,
+  prefilledRepoMatch,
+  prefillProviderMismatch,
+} from './useAddRepoDeepLink'
+
+function setUrl(search: string): void {
+  history.replaceState(null, '', `/${search}`)
+}
+
+function repo(owner: string, name: string): GitHubAvailableRepo {
+  return { owner, name, githubId: owner.length + name.length } as GitHubAvailableRepo
+}
+
+describe('captureAddRepoDeepLink', () => {
+  beforeEach(() => {
+    setActivePinia(createPinia())
+    setUrl('')
+  })
+
+  it('parses the link an integration builds, and strips only its own params', () => {
+    setUrl('?addRepo=kibertoad%2Fsimpler-service3&provider=github&ws=ws_1&keep=yes')
+    expect(captureAddRepoDeepLink()).toEqual({
+      repo: 'kibertoad/simpler-service3',
+      provider: 'github',
+      workspaceId: 'ws_1',
+    })
+    expect(window.location.search).toBe('?keep=yes')
+    expect(captureAddRepoDeepLink()).toBeNull()
+  })
+
+  it('takes a GitLab project under nested groups', () => {
+    setUrl('?addRepo=acme/platform/payments')
+    expect(captureAddRepoDeepLink()).toMatchObject({ repo: 'acme/platform/payments' })
+  })
+
+  it('drops a value that is not a repository path, and still strips it', () => {
+    setUrl('?addRepo=payments')
+    expect(captureAddRepoDeepLink()).toBeNull()
+    expect(window.location.search).toBe('')
+  })
+})
+
+describe('prefilledRepoMatch', () => {
+  it('matches the full path regardless of case, never a longer name', () => {
+    const wanted = repo('Kibertoad', 'simpler-service3')
+    const found = prefilledRepoMatch({ repo: 'kibertoad/simpler-service3', provider: null }, [
+      repo('kibertoad', 'simpler-service30'),
+      wanted,
+    ])
+    expect(found).toBe(wanted)
+  })
+})
+
+describe('prefillProviderMismatch', () => {
+  it('flags a link for another host only when the board is connected', () => {
+    const prefill = { repo: 'acme/payments', provider: 'gitlab' }
+    expect(prefillProviderMismatch(prefill, 'github')).toBe(true)
+    expect(prefillProviderMismatch(prefill, 'gitlab')).toBe(false)
+    expect(prefillProviderMismatch(prefill, null)).toBe(false)
+    expect(prefillProviderMismatch({ ...prefill, provider: null }, 'github')).toBe(false)
+  })
+})

package/app/composables/useAddRepoDeepLink.ts

@@ -0,0 +1,92 @@
+/**
+ * Boot-time replay of an ADD-REPOSITORY deep link: `?addRepo=<owner>/<name>&provider=<id>&ws=<id>`.
+ *
+ * An integration that finds a repository the platform has no service for (sainte-beuve filing a
+ * review, say) cannot create the service itself, because adding one is a person's choice of board,
+ * role and layout. It sends the person here instead: the add-service window opens with the
+ * repository already searched for, and selected once the connection lists it. `provider` is the
+ * host the link means, so a link for a GitLab project is not silently matched against GitHub;
+ * `ws` pins the board the same way a run link does. Integrations build it on `GET
+ * /api/v1/deployment`; the format is published at
+ * https://catfactory.ai/extend/public-api.html#sending-a-person-to-add-a-repository
+ *
+ * Signing in first keeps the query (`postSignInUrl`), so a signed-out person lands here too.
+ */
+import { watch } from 'vue'
+import type { GitHubAvailableRepo } from '~/types/domain'
+import type { VcsProvider } from '~/types/vcs'
+import { useUiStore } from '../stores/ui'
+import { useWorkspaceStore } from '../stores/workspace'
+
+/** What the add-service window is opened with: the repository to look for, and its host. */
+export interface AddServicePrefill {
+  repo: string
+  provider: string | null
+}
+
+interface PendingAddRepoLink extends AddServicePrefill {
+  workspaceId: string | null
+}
+
+const ADD_REPO_LINK_PARAMS = ['addRepo', 'provider', 'ws'] as const
+
+/** `owner/name`, where a GitLab owner may itself be a nested group path. */
+const REPO_PATH = /^[\w.-]+(?:\/[\w.-]+)+$/
+
+/**
+ * Read (and strip) an add-repository link from the current URL, or null when there is none or its
+ * `addRepo` is not a repository path. Called before `workspace.init()` so `ws` can pin the board.
+ */
+export function captureAddRepoDeepLink(): PendingAddRepoLink | null {
+  if (typeof window === 'undefined') return null
+  const params = new URLSearchParams(window.location.search)
+  const repo = params.get('addRepo')?.trim()
+  if (!repo) return null
+  const link = { repo, provider: params.get('provider'), workspaceId: params.get('ws') }
+  for (const key of ADD_REPO_LINK_PARAMS) params.delete(key)
+  const qs = params.toString()
+  history.replaceState(null, '', window.location.pathname + (qs ? `?${qs}` : ''))
+  return REPO_PATH.test(repo) ? link : null
+}
+
+/** The listed repository a prefill names, matched on its full path regardless of case. */
+export function prefilledRepoMatch(
+  prefill: AddServicePrefill,
+  repos: readonly GitHubAvailableRepo[],
+): GitHubAvailableRepo | undefined {
+  const wanted = prefill.repo.toLowerCase()
+  return repos.find((r) => `${r.owner}/${r.name}`.toLowerCase() === wanted)
+}
+
+/** Whether the link names a host other than the one this board is connected to. */
+export function prefillProviderMismatch(
+  prefill: AddServicePrefill | null,
+  connected: VcsProvider | null,
+): boolean {
+  return prefill?.provider != null && connected !== null && prefill.provider !== connected
+}
+
+/** Capture an add-repository link and, once the board has hydrated, open the window with it. */
+export function useAddRepoDeepLink(): void {
+  const link = captureAddRepoDeepLink()
+  if (!link) return
+
+  const workspace = useWorkspaceStore()
+  const ui = useUiStore()
+  if (link.workspaceId) workspace.workspaceId = link.workspaceId
+
+  // One-shot, for the same reasons `useRunDeepLink` spells out: a later refresh must not reopen a
+  // window the person closed, and `immediate` runs the callback before `stop` is bound.
+  let applied = false
+  let stop: (() => void) | undefined
+  stop = watch(
+    () => workspace.ready,
+    (ready) => {
+      if (!ready || applied) return
+      applied = true
+      ui.openAddService({ repo: link.repo, provider: link.provider })
+      stop?.()
+    },
+    { immediate: true },
+  )
+}

package/app/pages/index.vue

@@ -183,6 +183,8 @@ onMounted(() => {
   // board it names is the one that opens. This is what makes the observability link on an
   // engine-published PR verification report resolve.
   useRunDeepLink()
+  // `?addRepo=<owner>/<name>`: an integration sending a person to add a service for a repository.
+  useAddRepoDeepLink()
   // `?view=queue` / `?view=board`: a link that opens one of the board's two views.
   views.consumeDeepLink()
   void workspace.init()

package/app/stores/ui/modals.ts

@@ -10,6 +10,7 @@ import type {
   InfrastructureTab,
   ProviderConnectionKind,
 } from '~/types/providerConnections'
+import type { AddServicePrefill } from '~/composables/useAddRepoDeepLink'
 import type { PendingContext } from '~/composables/useContextLinking'
 import {
   infraSetupDismissalKey,
@@ -523,6 +524,8 @@ function createOverlayModals() {
   const bootstrapOpen = ref(false)
   // "Add a service from an existing GitHub repo" modal (no bootstrap run).
   const addServiceOpen = ref(false)
+  // The repository an add-repository deep link opened the window for, consumed on open.
+  const addServicePrefill = ref<AddServicePrefill | null>(null)
   // Prompt-fragment library panel (manage the board's best-practice catalog +
   // linked guideline repos; ADR 0006).
   const fragmentLibraryOpen = ref(false)
@@ -546,11 +549,13 @@ function createOverlayModals() {
   function closeBootstrap() {
     bootstrapOpen.value = false
   }
-  function openAddService() {
+  function openAddService(prefill: AddServicePrefill | null = null) {
+    addServicePrefill.value = prefill
     addServiceOpen.value = true
   }
   function closeAddService() {
     addServiceOpen.value = false
+    addServicePrefill.value = null
   }
   function openFragmentLibrary() {
     fragmentLibraryOpen.value = true
@@ -601,6 +606,7 @@ function createOverlayModals() {
   return {
     bootstrapOpen,
     addServiceOpen,
+    addServicePrefill,
     fragmentLibraryOpen,
     foundationalServicesOpen,
     commandBarOpen,

package/i18n/locales/de.json

@@ -3813,7 +3813,8 @@
         "servicesAddedDescription": "{count} Service zum Board hinzugefügt. | {count} Services zum Board hinzugefügt.",
         "frontendLinkedNote": "{directory} wurde als Frontend hinzugefügt und mit den übrigen verknüpft. Benennen Sie die Umgebungsvariablen für die Backend-URLs im Inspector.",
         "frontendWiringFailedNote": "Die Frontend-Einstellungen wurden nicht gespeichert. Öffnen Sie den Inspector jeder Frontend-App, um ihr Unterverzeichnis und ihre Backend-Services zu setzen."
-      }
+      },
+      "prefillProviderMismatch": "Der Link verweist auf {repo} bei einem anderen Anbieter, dieses Board ist aber mit {connected} verbunden. Suche das Repository von Hand oder öffne den Link auf einem Board, das mit seinem Anbieter verbunden ist."
     },
     "repoTree": {
       "root": "root",

package/i18n/locales/en.json

@@ -4830,7 +4830,8 @@
         },
         "frontendLinkedNote": "{directory} was added as the frontend and linked to the others. Name its backend URL environment variables in its inspector.",
         "frontendWiringFailedNote": "The frontend settings did not save. Open each frontend app's inspector to set its subdirectory and its backend services."
-      }
+      },
+      "prefillProviderMismatch": "The link asked for {repo} on a different host, and this board is connected to {connected}. Search for the repository by hand, or open the link on a board connected to its host."
     },
     "repoTree": {
       "root": "root",

package/i18n/locales/es.json

@@ -4645,7 +4645,8 @@
         "frontendWiringFailedNote": "Los ajustes del frontend no se guardaron. Abre el inspector de cada aplicación frontend para definir su subdirectorio y sus servicios backend."
       },
       "repoType": "Tipo de repositorio",
-      "repoTypeHint": "Qué es este repositorio: un servicio backend, una aplicación frontend, una biblioteca compartida o un repositorio de documentación (solo documentos/spikes)."
+      "repoTypeHint": "Qué es este repositorio: un servicio backend, una aplicación frontend, una biblioteca compartida o un repositorio de documentación (solo documentos/spikes).",
+      "prefillProviderMismatch": "El enlace pedía {repo} en otro proveedor, y este tablero está conectado a {connected}. Busca el repositorio a mano o abre el enlace en un tablero conectado a su proveedor."
     },
     "repoTree": {
       "root": "raíz",

package/i18n/locales/fr.json

@@ -4645,7 +4645,8 @@
         "frontendWiringFailedNote": "Les réglages du frontend n'ont pas été enregistrés. Ouvrez l'inspecteur de chaque application frontend pour définir son sous-répertoire et ses services backend."
       },
       "repoType": "Type de dépôt",
-      "repoTypeHint": "Ce qu'est ce dépôt : un service backend, une application frontend, une bibliothèque partagée ou un dépôt de documentation (documents/spikes uniquement)."
+      "repoTypeHint": "Ce qu'est ce dépôt : un service backend, une application frontend, une bibliothèque partagée ou un dépôt de documentation (documents/spikes uniquement).",
+      "prefillProviderMismatch": "Le lien visait {repo} chez un autre hébergeur, et ce tableau est connecté à {connected}. Cherchez le dépôt à la main, ou ouvrez le lien sur un tableau connecté à son hébergeur."
     },
     "repoTree": {
       "root": "racine",

package/i18n/locales/he.json

@@ -4645,7 +4645,8 @@
         "frontendWiringFailedNote": "הגדרות הפרונט-אנד לא נשמרו. פתח את האינספקטור של כל אפליקציית פרונט-אנד כדי להגדיר את תת-הספרייה ואת שירותי הבק-אנד שלה."
       },
       "repoType": "סוג המאגר",
-      "repoTypeHint": "מה המאגר הזה: שירות בק-אנד, אפליקציית פרונט-אנד, ספרייה משותפת או מאגר תיעוד (מסמכים/ספייקים בלבד)."
+      "repoTypeHint": "מה המאגר הזה: שירות בק-אנד, אפליקציית פרונט-אנד, ספרייה משותפת או מאגר תיעוד (מסמכים/ספייקים בלבד).",
+      "prefillProviderMismatch": "הקישור ביקש את {repo} אצל ספק אחר, והלוח הזה מחובר ל-{connected}. חפשו את המאגר ידנית, או פתחו את הקישור בלוח שמחובר לספק שלו."
     },
     "repoTree": {
       "root": "שורש",

package/i18n/locales/it.json

@@ -3813,7 +3813,8 @@
         "servicesAddedDescription": "{count} servizio aggiunto alla board. | {count} servizi aggiunti alla board.",
         "frontendLinkedNote": "{directory} è stata aggiunta come frontend e collegata alle altre. Assegna il nome alle sue variabili d'ambiente con gli URL dei backend nel suo inspector.",
         "frontendWiringFailedNote": "Le impostazioni del frontend non sono state salvate. Apri l'inspector di ogni app frontend per impostarne la sottodirectory e i servizi backend."
-      }
+      },
+      "prefillProviderMismatch": "Il link chiedeva {repo} su un altro provider, e questa board è collegata a {connected}. Cerca il repository a mano, oppure apri il link su una board collegata al suo provider."
     },
     "repoTree": {
       "root": "root",

package/i18n/locales/ja.json

@@ -4645,7 +4645,8 @@
         "frontendWiringFailedNote": "フロントエンドの設定を保存できませんでした。各フロントエンドアプリのインスペクターを開き、サブディレクトリとバックエンドサービスを設定してください。"
       },
       "repoType": "リポジトリの種類",
-      "repoTypeHint": "このリポジトリの種類: バックエンドサービス、フロントエンドアプリ、共有ライブラリ、またはドキュメントリポジトリ（ドキュメント/スパイクのみ）。"
+      "repoTypeHint": "このリポジトリの種類: バックエンドサービス、フロントエンドアプリ、共有ライブラリ、またはドキュメントリポジトリ（ドキュメント/スパイクのみ）。",
+      "prefillProviderMismatch": "このリンクは別のホストにある {repo} を指していますが、このボードは {connected} に接続されています。リポジトリを手動で検索するか、そのホストに接続されたボードでリンクを開いてください。"
     },
     "repoTree": {
       "root": "ルート",

package/i18n/locales/pl.json

@@ -4645,7 +4645,8 @@
         "frontendWiringFailedNote": "Ustawienia frontendu nie zostały zapisane. Otwórz inspektor każdej aplikacji frontendowej, aby ustawić jej podkatalog i usługi backendowe."
       },
       "repoType": "Typ repozytorium",
-      "repoTypeHint": "Czym jest to repozytorium: usługą backendową, aplikacją frontendową, współdzieloną biblioteką lub repozytorium dokumentacji (tylko dokumenty/spike'i)."
+      "repoTypeHint": "Czym jest to repozytorium: usługą backendową, aplikacją frontendową, współdzieloną biblioteką lub repozytorium dokumentacji (tylko dokumenty/spike'i).",
+      "prefillProviderMismatch": "Link wskazywał {repo} u innego dostawcy, a ta tablica jest połączona z {connected}. Wyszukaj repozytorium ręcznie albo otwórz link na tablicy połączonej z jego dostawcą."
     },
     "repoTree": {
       "root": "katalog główny",

package/i18n/locales/tr.json

@@ -4645,7 +4645,8 @@
         "frontendWiringFailedNote": "Frontend ayarları kaydedilmedi. Alt dizinini ve backend servislerini ayarlamak için her frontend uygulamasının inspector’ını açın."
       },
       "repoType": "Depo türü",
-      "repoTypeHint": "Bu deponun türü: bir backend servisi, bir frontend uygulaması, paylaşılan bir kütüphane veya bir doküman deposu (yalnızca doküman/spike)."
+      "repoTypeHint": "Bu deponun türü: bir backend servisi, bir frontend uygulaması, paylaşılan bir kütüphane veya bir doküman deposu (yalnızca doküman/spike).",
+      "prefillProviderMismatch": "Bağlantı başka bir sağlayıcıdaki {repo} deposunu istiyordu, bu pano ise {connected} ile bağlı. Depoyu elle arayın veya bağlantıyı onun sağlayıcısına bağlı bir panoda açın."
     },
     "repoTree": {
       "root": "kök",

package/i18n/locales/uk.json

@@ -4645,7 +4645,8 @@
         "frontendWiringFailedNote": "Налаштування фронтенду не збережено. Відкрийте інспектор кожного фронтенд-застосунку, щоб указати його підкаталог і бекенд-сервіси."
       },
       "repoType": "Тип репозиторію",
-      "repoTypeHint": "Що це за репозиторій: бекенд-сервіс, фронтенд-застосунок, спільна бібліотека або репозиторій документації (лише документи/спайки)."
+      "repoTypeHint": "Що це за репозиторій: бекенд-сервіс, фронтенд-застосунок, спільна бібліотека або репозиторій документації (лише документи/спайки).",
+      "prefillProviderMismatch": "Посилання вказувало на {repo} в іншого провайдера, а ця дошка підключена до {connected}. Знайдіть репозиторій вручну або відкрийте посилання на дошці, підключеній до його провайдера."
     },
     "repoTree": {
       "root": "корінь",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cat-factory/app",
-  "version": "0.316.0",
+  "version": "0.317.0",
   "description": "Reusable Nuxt layer for the Agent Architecture Board SPA (components, stores, composables, pages). Consume it from a thin deployment app via `extends: ['@cat-factory/app']` and point it at your backend with NUXT_PUBLIC_API_BASE. See deploy/frontend for an example.",
   "repository": {
     "type": "git",
@@ -18,7 +18,7 @@
     "access": "public"
   },
   "dependencies": {
-    "@cat-factory/contracts": "0.370.0",
+    "@cat-factory/contracts": "0.371.0",
     "@modular-frontend/core": "0.6.0",
     "@modular-vue/core": "^1.5.0",
     "@modular-vue/journeys": "^1.4.0",