@cat-factory/app 0.312.0 → 0.314.0

package/README.md

@@ -1492,6 +1492,18 @@ example ships in [`deploy/frontend`](https://github.com/kibertoad/cat-factory/tr
   switchers, the `SpendWarningBanner`, and the toolbar (zoom, LOD, decision queue).
 - **Palettes** (`components/palettes`): drag blocks, pipelines and agents onto
   the board.
+- **Describe new work** (`components/queue/DescribeWorkModal.vue`, `utils/describeWork.ts`): the
+  one-sentence intake, from Create, the palette and the queue header. It files a feature or a bug
+  from a sentence and a service, titled by the first sentence; the overrides sit behind one
+  disclosure, and the merge policy and model preset follow the full form's tier rule
+  (`showOverrideField`), so basic mode and the designer role see the pipeline only.
+  It rebuilds no other kind: "More kinds" and "Attach context" hand the text to `AddTaskModal`,
+  which stays the one home of those rules. Both share `utils/reviewFriction.ts` for the review-debt 409.
+- **Setup checklist** (`components/setup/SetupChecklistPanel.vue`, `utils/setupChecklist.ts`):
+  every prerequisite for "a task can run and merge" in one list, for people who can change the
+  setup. It adds no probe of its own: each row reads what its banner or startup dialog already
+  reads (`useSetupChecklist`) and opens the same surface. "Checking" and "missing" are separate
+  states, because an unanswered probe and an absent capability are opposite facts.
 - **Inspector** (`components/panels` + `panels/inspector`): per-block tabs:
   structure, dependencies, model + fragment picker, live execution, and linked
   docs/issues/scenarios. Decisions resolve via `DecisionModal`. A `review` task

package/app/components/board/AddTaskModal.vue

@@ -36,6 +36,7 @@ import FragmentSelector from '~/components/fragments/FragmentSelector.vue'
 import ReviewSkillQueue from '~/components/skills/ReviewSkillQueue.vue'
 import RiskPolicyPicker from '~/components/riskPolicy/RiskPolicyPicker.vue'
 import { parseConflict } from '~/composables/usePipelineErrorToast'
+import { isReviewDebtConflict, reviewFrictionContext } from '~/utils/reviewFriction'
 import { apiErrorEnvelope } from '~/composables/api/errors'
 import type { ReviewTargetReason } from '@cat-factory/contracts'
 import {
@@ -526,6 +527,8 @@ function defaultPipelineIdFor(type: TaskTypeChoice): string {
   return offered ? preset : ''
 }
 
+// Set while a prefill's type is being seeded with a carried pipeline (see `onModalOpen` below).
+let seedingPrefill = false
 watch(taskType, (next) => {
   const custom = customTaskTypes.value.find((tt) => tt.taskType === next)
   // A custom type owns a fresh field bag on every switch (its descriptors differ per type), seeded
@@ -533,6 +536,10 @@ watch(taskType, (next) => {
   customFieldValues.value = descriptorFieldDefaults(custom?.fields ?? [])
   // An unresolvable preset leaves the current selection alone rather than blanking it: a type
   // switch is an edit to a form the user is already filling in, not a reset.
+  if (seedingPrefill) {
+    seedingPrefill = false
+    return
+  }
   const preset = defaultPipelineIdFor(next)
   if (preset) pipelineId.value = preset
 })
@@ -667,13 +674,23 @@ onModalOpen(open, () => {
   agentConfigValues.value = {}
   pendingContext.value = []
   // Seed from a prefill when opened from another surface (e.g. "create task from
-  // issue" sets the title + stages the issue as linked context). Pipeline / preset
-  // are intentionally left at their defaults so the user confirms them here.
+  // issue" sets the title + stages the issue as linked context). Pipeline / preset stay at their
+  // defaults unless the opener carries a choice the person already made (the one-sentence
+  // intake's kind and overrides), which the hand-off must not reset.
   const prefill = ui.addTaskPrefill
   if (prefill) {
     if (prefill.title) title.value = prefill.title
     if (prefill.description) description.value = prefill.description
     if (prefill.context?.length) pendingContext.value = [...prefill.context]
+    if (prefill.taskType && prefill.taskType !== taskType.value) {
+      taskType.value = prefill.taskType
+      // The type watcher runs after this block and would replace a carried pipeline with the
+      // new type's default; a seeded type is not the edit that watcher is for.
+      seedingPrefill = !!prefill.pipelineId
+    }
+    if (prefill.pipelineId) pipelineId.value = prefill.pipelineId
+    if (prefill.riskPolicyId) riskPolicyId.value = prefill.riskPolicyId
+    if (prefill.modelPresetId) modelPresetId.value = prefill.modelPresetId
   }
   documents.loadDocuments().catch(() => {})
   tasks.loadTasks().catch(() => {})
@@ -831,8 +848,15 @@ async function submitCreate(acknowledgeReviewDebt: boolean) {
     ui.closeAddTask()
   } catch (e) {
     const conflict = parseConflict(e)
-    if (conflict?.reason === 'review_debt_warn' || conflict?.reason === 'review_debt_blocked') {
-      openReviewFrictionDialog(conflict)
+    if (isReviewDebtConflict(conflict)) {
+      ui.openReviewFriction(
+        reviewFrictionContext(
+          conflict,
+          () => void submitCreate(true),
+          () => saving.value,
+          () => ui.closeAddTask(),
+        ),
+      )
       return
     }
     const refusal = createRefusalMessage(e)
@@ -883,32 +907,6 @@ function createRefusalMessage(error: unknown): string | null {
   if (reason === 'task_type_fields_invalid') return t('board.addTask.customFieldsInvalid')
   return REVIEW_TARGET_MESSAGES[reason as ReviewTargetReason]?.(details) ?? null
 }
-
-/** Turn a parsed review-debt friction 409 into the dialog context (see ReviewFrictionDialog.vue). */
-function openReviewFrictionDialog(conflict: NonNullable<ReturnType<typeof parseConflict>>) {
-  const details = conflict.details
-  const rawDebt = Array.isArray(details.debt) ? details.debt : []
-  const debt = rawDebt.map((d) => {
-    const row = (d ?? {}) as { blockId?: unknown; title?: unknown; waitingMinutes?: unknown }
-    return {
-      blockId: typeof row.blockId === 'string' ? row.blockId : '',
-      title: typeof row.title === 'string' ? row.title : null,
-      waitingMinutes: typeof row.waitingMinutes === 'number' ? row.waitingMinutes : 0,
-    }
-  })
-  const isWarn = conflict.reason === 'review_debt_warn'
-  ui.openReviewFriction({
-    kind: isWarn ? 'warn' : 'blocked',
-    reason:
-      details.friction === 'count' || details.friction === 'stuck' ? details.friction : undefined,
-    threshold: typeof details.threshold === 'number' ? details.threshold : null,
-    debt,
-    onConfirm: isWarn ? () => void submitCreate(true) : null,
-    // A getter, not a snapshot: the dialog reads it inside a computed so its button spins and
-    // locks for as long as the retry actually runs (UX-78).
-    pending: () => saving.value,
-  })
-}
 </script>
 
 <template>
@@ -954,6 +952,7 @@ function openReviewFrictionDialog(conflict: NonNullable<ReturnType<typeof parseC
                   :icon="ty.icon"
                   size="xs"
                   :title="ty.description"
+                  :aria-pressed="taskType === ty.value"
                   :data-testid="`task-type-${ty.value}`"
                   @click="
                     () => {

package/app/components/board/ReviewFrictionDialog.vue

@@ -53,17 +53,20 @@ const body = computed(() => {
 /** Deep-link to a waiting task's block and dismiss the whole friction flow. */
 function goToBlock(blockId: string) {
   if (blockId) ui.select(blockId)
+  leave()
+}
+
+/** Close the friction and the form that raised it. */
+function leave() {
+  const onLeave = ctx.value?.onLeave
   ui.closeReviewFriction()
-  ui.closeAddTask()
+  onLeave?.()
 }
 
 function goReview() {
   const first = ctx.value?.debt[0]
   if (first) goToBlock(first.blockId)
-  else {
-    ui.closeReviewFriction()
-    ui.closeAddTask()
-  }
+  else leave()
 }
 
 function createAnyway() {

package/app/components/layout/AiProvidersBanner.vue

@@ -8,6 +8,7 @@ import { computed } from 'vue'
 
 const { t } = useI18n()
 const ui = useUiStore()
+const remedies = useSetupRemedies()
 const { ready, hasUsableModel, defaultPresetBroken } = useAiReadiness()
 
 const showSetup = computed(() => ready.value && !hasUsableModel.value && !ui.aiSetupDismissed)
@@ -47,7 +48,7 @@ const show = computed(() => showSetup.value || showPreset.value)
               {{ t('layout.aiProvidersBanner.setup.body') }}
             </p>
             <div class="mt-4">
-              <UButton color="warning" icon="i-lucide-settings" @click="ui.openAiProviderSetup()">
+              <UButton color="warning" icon="i-lucide-settings" @click="remedies.openModelSetup()">
                 {{ t('layout.aiProvidersBanner.setup.action') }}
               </UButton>
             </div>
@@ -88,7 +89,7 @@ const show = computed(() => showSetup.value || showPreset.value)
                 size="sm"
                 color="warning"
                 icon="i-lucide-cpu"
-                @click="ui.openAiPresetMismatch()"
+                @click="remedies.openPresetMismatch()"
               >
                 {{ t('layout.aiProvidersBanner.preset.action') }}
               </UButton>

package/app/components/layout/GitHubPatBanner.vue

@@ -7,9 +7,9 @@ const { t } = useI18n()
 // repo-operating agent step (clone, push, open PR, CI gate, merge) will fail. The server
 // also logs this, but a dev terminal is easy to miss — so surface it in the UI with the
 // (scopes-preselected) creation URL as a one-click link straight to GitHub.
-const auth = useAuthStore()
+const { patSetupUrl } = useSetupRemedies()
 
-const setupUrl = computed(() => auth.localMode?.githubPatSetupUrl ?? '')
+const setupUrl = computed(() => patSetupUrl.value ?? '')
 const dismissed = ref(false)
 const show = computed(() => !!setupUrl.value && !dismissed.value)
 </script>

package/app/components/layout/GitHubPatPermissionsBanner.vue

@@ -3,11 +3,9 @@ import { computed, ref } from 'vue'
 import {
   GITHUB_PAT_FINE_GRAINED_PERMISSIONS,
   githubPatCheckNeedsAttention,
-  githubPatCheckSource,
   missingGitHubPatCapabilities,
 } from '@cat-factory/contracts'
-import type { GitHubPatCapability, GitHubPatKind } from '~/types/domain'
-import { githubPatRemintUrl } from '~/utils/vcs'
+import type { GitHubPatCapability } from '~/types/domain'
 
 // The token a run would authenticate with cannot do what the pipeline needs.
 //
@@ -67,14 +65,8 @@ function capabilityLabel(capability: GitHubPatCapability): string {
   return t(CAPABILITY_KEYS[capability])
 }
 
-/**
- * The kind carried over to the re-mint link. A rejected token was never classified, so it falls
- * back to `unknown` — which lands on the classic form, the only one GitHub lets us pre-fill.
- */
-const kind = computed<GitHubPatKind>(() => report.value?.kind ?? 'unknown')
-const remintUrl = computed(() =>
-  githubPatRemintUrl(kind.value, report.value?.webUrl ?? github.connection?.webUrl),
-)
+// The re-mint page and whose token it is: the map the setup checklist opens through too.
+const { patRemintUrl: remintUrl, patSource, patKind: kind } = useSetupRemedies()
 
 /**
  * Who has to act. A deployment token is replaced by whoever runs the deployment (local mode:
@@ -89,7 +81,7 @@ const remintUrl = computed(() =>
  * personal settings: the exact misrouting the wire field exists to prevent.
  */
 const sourceKey = computed(() =>
-  check.value && githubPatCheckSource(check.value) === 'deployment'
+  patSource.value === 'deployment'
     ? 'layout.githubPatPermissionsBanner.sourceDeployment'
     : 'layout.githubPatPermissionsBanner.sourceInitiator',
 )

package/app/components/layout/InfraSetupBanner.vue

@@ -65,6 +65,8 @@ const ui = useUiStore()
 const auth = useAuthStore()
 const workspace = useWorkspaceStore()
 const { actor } = useSetupActor()
+// Where each area is configured: the map the setup checklist opens through too.
+const remedies = useSetupRemedies()
 
 // Severity order: no executor blocks EVERY agent, so it leads; a missing test environment blocks
 // only testing agents; missing storage only degrades the UI-tester's screenshots.
@@ -73,32 +75,29 @@ const AREAS: InfraSetupArea[] = ['agentExecutor', 'ephemeralEnvironments', 'bina
 // Exhaustive per-area presentation (an exhaustive `Record<InfraSetupArea, …>`, so adding an area
 // without a meta entry fails typecheck — the tier-2 guard). The i18n keys are resolved
 // dynamically (`t(AREA_META[area].titleKey)`), so tier-1 typed-key checking doesn't cover them;
-// the `i18n:check` drift guard (tier 3) catches any that are absent from the catalog. `action`
-// deep-links into the relevant setup surface.
+// the `i18n:check` drift guard (tier 3) catches any that are absent from the catalog. The action
+// opens the area's setup surface through `useSetupRemedies`.
 const AREA_META: Record<
   InfraSetupArea,
-  { icon: string; titleKey: string; bodyKey: string; actionKey: string; onConfigure: () => void }
+  { icon: string; titleKey: string; bodyKey: string; actionKey: string }
 > = {
   agentExecutor: {
     icon: 'i-lucide-server-cog',
     titleKey: 'layout.infraSetupBanner.agentExecutor.title',
     bodyKey: 'layout.infraSetupBanner.agentExecutor.body',
     actionKey: 'layout.infraSetupBanner.agentExecutor.action',
-    onConfigure: () => ui.openProviderConnection('runner-pool'),
   },
   ephemeralEnvironments: {
     icon: 'i-lucide-flask-conical',
     titleKey: 'layout.infraSetupBanner.ephemeralEnvironments.title',
     bodyKey: 'layout.infraSetupBanner.ephemeralEnvironments.body',
     actionKey: 'layout.infraSetupBanner.ephemeralEnvironments.action',
-    onConfigure: () => ui.openProviderConnection('environment'),
   },
   binaryStorage: {
     icon: 'i-lucide-hard-drive',
     titleKey: 'layout.infraSetupBanner.binaryStorage.title',
     bodyKey: 'layout.infraSetupBanner.binaryStorage.body',
     actionKey: 'layout.infraSetupBanner.binaryStorage.action',
-    onConfigure: () => ui.openContentStorageSettings(),
   },
 }
 
@@ -291,7 +290,7 @@ function dismissMenu(card: Pick<AreaCard, 'area' | 'kind'>): DropdownMenuItem[][
                 :color="card.kind === 'outage' ? 'error' : 'warning'"
                 icon="i-lucide-settings"
                 :data-testid="`infra-setup-configure-${card.area}`"
-                @click="AREA_META[card.area].onConfigure()"
+                @click="remedies.openInfraArea(card.area)"
               >
                 {{
                   card.kind === 'outage'

package/app/components/pipeline/PipelinePicker.vue

@@ -21,6 +21,12 @@ const props = withDefaults(
      * chosen row — and the row is left out entirely.
      */
     noneLabel?: string
+    /**
+     * What the preview pane says about the "none" row. Defaults to the full form's meaning ("no
+     * default; you choose when you run it"); a surface whose "none" row means the workspace default
+     * names what that default resolves to instead.
+     */
+    noneHint?: string
     /**
      * Default-trigger text while nothing is selected. Defaults to {@link noneLabel}, which reads
      * correctly when the "none" row IS the empty state; a surface without that row supplies its
@@ -30,7 +36,7 @@ const props = withDefaults(
     /** Extra classes for the default trigger button (e.g. full-width in the modal). */
     triggerClass?: string
   }>(),
-  { noneLabel: undefined, placeholder: undefined, triggerClass: '' },
+  { noneLabel: undefined, noneHint: undefined, placeholder: undefined, triggerClass: '' },
 )
 
 const emit = defineEmits<{ 'update:modelValue': [string] }>()
@@ -59,7 +65,7 @@ const previewPipeline = computed<Pipeline | null>(() => {
  */
 const emptyHint = computed(() =>
   props.noneLabel !== undefined && (hoverId.value ?? props.modelValue) === ''
-    ? t('pipeline.picker.noneHint')
+    ? (props.noneHint ?? t('pipeline.picker.noneHint'))
     : t('pipeline.picker.hoverHint'),
 )