@cat-factory/app 0.289.0 → 0.290.0

package/app/components/environments/EnvironmentStatusPanel.logic.spec.ts

@@ -0,0 +1,70 @@
+import { describe, it, expect } from 'vitest'
+import { readStatusNote, showsProviderFailure } from './EnvironmentStatusPanel.logic'
+import type { RunEnvironment } from '~/types/execution'
+
+/**
+ * The panel is where a person watches an environment come up, so it is also where the two prose
+ * channels can be shown to contradict each other. The failure this pins is a fault going unshown:
+ * a note is only ever context, and rendering it while `lastError` is suppressed reports a healthy
+ * spin-up on a row that recorded a real problem.
+ */
+const env = (over: Partial<RunEnvironment>): RunEnvironment =>
+  ({ id: 'env-1', url: null, status: 'provisioning', ...over }) as RunEnvironment
+
+describe('readStatusNote', () => {
+  it('shows what a still-provisioning environment is waiting on', () => {
+    expect(readStatusNote(env({ statusNote: '  the deploy job is queued  ' }))).toBe(
+      'the deploy job is queued',
+    )
+  })
+
+  it('withholds the note whenever a fault is recorded, whatever the status', () => {
+    // A teardown carries the row's `lastError` forward, so a failed-then-torn-down environment is
+    // a real shape with both fields set and a status the error block does not cover. Keyed off
+    // that block's own render condition, the panel showed the note and NO fault at all.
+    expect(
+      readStatusNote(
+        env({ status: 'torn_down', lastError: 'quota exceeded', statusNote: 'still deploying' }),
+      ),
+    ).toBeNull()
+    expect(
+      readStatusNote(
+        env({ status: 'failed', lastError: 'quota exceeded', statusNote: 'still deploying' }),
+      ),
+    ).toBeNull()
+  })
+
+  it('says nothing beside an environment that reached the state the note explains', () => {
+    // "Provider note: the workload is not routed yet" beside a green READY badge is two claims,
+    // and the badge is the true one.
+    expect(readStatusNote(env({ status: 'ready', statusNote: 'not routed yet' }))).toBeNull()
+    expect(readStatusNote(env({ status: 'torn_down', statusNote: 'still deploying' }))).toBeNull()
+    expect(
+      readStatusNote(env({ status: 'tearing_down', statusNote: 'still deploying' })),
+    ).toBeNull()
+  })
+
+  it('keeps the note on a terminal status that recorded no fault', () => {
+    // The same disposition kernel's readiness verdict takes: with no error to show, the last
+    // thing the provider said is all there is.
+    expect(
+      readStatusNote(env({ status: 'failed', statusNote: 'the deploy job never started' })),
+    ).toBe('the deploy job never started')
+  })
+
+  it('reads a blank note, an absent one and no environment alike', () => {
+    expect(readStatusNote(env({ statusNote: '   ' }))).toBeNull()
+    expect(readStatusNote(env({}))).toBeNull()
+    expect(readStatusNote(null)).toBeNull()
+  })
+})
+
+describe('showsProviderFailure', () => {
+  it('is the fault block, on the statuses that stopped at one', () => {
+    expect(showsProviderFailure(env({ status: 'failed', lastError: 'quota' }))).toBe(true)
+    expect(showsProviderFailure(env({ status: 'expired', lastError: 'quota' }))).toBe(true)
+    expect(showsProviderFailure(env({ status: 'provisioning', lastError: 'quota' }))).toBe(false)
+    expect(showsProviderFailure(env({ status: 'failed' }))).toBe(false)
+    expect(showsProviderFailure(null)).toBe(false)
+  })
+})

package/app/components/environments/EnvironmentStatusPanel.logic.ts

@@ -0,0 +1,48 @@
+// Which of an environment's two prose channels the panel shows, extracted from
+// `EnvironmentStatusPanel.vue` so the precedence can be asserted without mounting the panel (see
+// `EnvironmentStatusPanel.logic.spec.ts`).
+//
+// The environment record carries two accounts of itself and they answer different questions.
+// `lastError` is a recorded FAULT: the provider's verbatim cause, written on a status the
+// environment will not leave. `statusNote` is the provider's account of a state it has NOT left
+// yet: why this environment is not ready. A row can carry both, and which one a reader is shown
+// decides which layer they go looking at.
+
+import type { RunEnvironment } from '~/types/execution'
+import type { EnvironmentStatus } from '@cat-factory/contracts'
+
+/**
+ * The statuses whose failure block the panel renders: a fault is shown as the headline account
+ * only where the environment actually stopped at one.
+ */
+const FAILURE_STATUSES = new Set<EnvironmentStatus>(['failed', 'expired'])
+
+/**
+ * The statuses a note still says something about. `ready` has REACHED the state the note explains
+ * not being in, and the two teardown statuses describe a spin-up nobody is waiting on any more (a
+ * teardown carries the row's note forward, so this is a live shape rather than a hypothetical
+ * one). On `failed` / `expired` the note is what a provider that recorded no fault last said,
+ * which is the disposition kernel's readiness verdict takes for the same pair.
+ */
+const NOTE_STATUSES = new Set<EnvironmentStatus>(['provisioning', 'failed', 'expired'])
+
+/** Whether the verbatim provider error is the panel's account of this environment. */
+export function showsProviderFailure(env: RunEnvironment | null | undefined): boolean {
+  return !!env?.lastError && FAILURE_STATUSES.has(env.status)
+}
+
+/**
+ * The note to render, or null.
+ *
+ * Two rules, and it is the FAULT's presence that decides the first rather than whether the error
+ * block happens to be on screen. A recorded `lastError` outranks a note wherever they collide,
+ * whatever the status: they are two claims about one environment and the fault is the more
+ * specific one, so keying this off the error block's own render condition hid a real fault on
+ * every status that block does not cover. And a status that has left the state the note describes
+ * has nothing left to add with it.
+ */
+export function readStatusNote(env: RunEnvironment | null | undefined): string | null {
+  if (!env || env.lastError) return null
+  if (!NOTE_STATUSES.has(env.status)) return null
+  return env.statusNote?.trim() || null
+}

package/app/components/environments/EnvironmentStatusPanel.vue

@@ -5,6 +5,10 @@
 // shows whether the env is spinning up / running / shut down / errored, with the error.
 import type { InfraEngine, ProvisionType } from '@cat-factory/contracts'
 import type { RunEnvironment, HumanTestEnvironmentStatus } from '~/types/execution'
+import {
+  readStatusNote,
+  showsProviderFailure,
+} from '~/components/environments/EnvironmentStatusPanel.logic'
 
 const props = defineProps<{
   environment: RunEnvironment | null
@@ -86,6 +90,12 @@ const ENV_STATUS_META = computed<
   },
 }))
 
+// Which of the environment's two prose channels this panel shows. Both predicates live in
+// `EnvironmentStatusPanel.logic.ts`, where the precedence between a recorded fault and a
+// still-coming-up note is stated once and asserted without mounting the panel.
+const failureShown = computed(() => showsProviderFailure(props.environment))
+const statusNote = computed(() => readStatusNote(props.environment))
+
 // The two statuses that describe a transition IN FLIGHT. Only these ever animate, and only
 // while the run driving the transition is still being driven itself.
 const envInTransition = computed(
@@ -140,12 +150,19 @@ const envInTransition = computed(
       </dl>
       <!-- The verbatim provider error when the environment failed/expired. -->
       <pre
-        v-if="
-          environment.lastError &&
-          (environment.status === 'failed' || environment.status === 'expired')
-        "
+        v-if="failureShown"
         class="mt-1 max-h-32 overflow-auto whitespace-pre-wrap rounded border border-rose-900/60 bg-rose-950/40 p-1.5 text-[11px] text-rose-200/90"
         >{{ environment.lastError }}</pre>
+      <!-- What the provider says it is still waiting on. Muted rather than alarming: an
+           environment mid-rollout is healthy, and styling this like the error above would report
+           a fault every deploy. Bounded like the error block, because the text is provider
+           prose. -->
+      <p
+        v-if="statusNote"
+        class="mt-1 max-h-32 overflow-auto whitespace-pre-wrap break-words text-[11px] text-slate-400"
+      >
+        {{ t('environments.statusNote', { note: statusNote }) }}
+      </p>
     </div>
     <p v-else class="text-[12px] text-slate-500">
       {{ degradedReason ?? t('environments.empty') }}

package/app/components/outcome/OutcomeSummaryWindow.logic.spec.ts

@@ -20,6 +20,7 @@ const env = (overrides: Partial<OutcomeEnvironment> = {}): OutcomeEnvironment =>
   frameId: 'frm_own',
   environmentId: 'env_1',
   detail: null,
+  detailKind: null,
   ...overrides,
 })
 

package/app/components/outcome/OutcomeSummaryWindow.vue

@@ -803,12 +803,21 @@ function openTestReport() {
                   : t('outcome.environments.expires', { date: d(new Date(row.expiresAt), 'long') })
               }}
             </p>
+            <!-- One slot, two kinds of claim. A provider's note about a spin-up in progress is
+                 labelled as one; a recorded fault is the row's own prose. Unlabelled they read
+                 identically, and "the deploy job is queued behind 3 others" in the slot that
+                 otherwise holds "quota exceeded" reports a fault the environment does not have. -->
             <p
               v-if="row.detail"
               class="mt-1 break-words text-[12px] leading-relaxed text-slate-500"
               data-testid="outcome-environment-detail"
+              :data-detail-kind="row.detailKind"
             >
-              {{ row.detail }}
+              {{
+                row.detailKind === 'note'
+                  ? t('environments.statusNote', { note: row.detail })
+                  : row.detail
+              }}
             </p>
           </div>
         </template>

package/app/components/provisioning/ProvisioningLogsDrawer.vue

@@ -96,6 +96,7 @@ const OPERATION_LABEL = computed<Record<ProvisioningOperation, string>>(() => ({
   teardown: t('provisioning.operation.teardown'),
   'teardown-verify': t('provisioning.operation.teardown-verify'),
   status: t('provisioning.operation.status'),
+  remediate: t('provisioning.operation.remediate'),
   dispatch: t('provisioning.operation.dispatch'),
   release: t('provisioning.operation.release'),
   'poll-failure': t('provisioning.operation.poll-failure'),

package/app/utils/runOutcome.ts

@@ -26,6 +26,7 @@ export type {
   OutcomeDisposition,
   OutcomeEnvironment,
   OutcomeEnvironments,
+  OutcomeEnvironmentDetailKind,
   OutcomeEnvironmentOrigin,
   OutcomeEnvironmentState,
   OutcomePullRequest,

package/i18n/locales/de.json

@@ -6874,6 +6874,7 @@
     "empty": "Keine ephemere Umgebung für diesen Lauf.",
     "provisionTypeLabel": "Bereitstellungstyp:",
     "engineLabel": "Engine:",
+    "statusNote": "Hinweis des Anbieters: {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6899,6 +6900,7 @@
       "teardown": "Abbauen",
       "teardown-verify": "Abbau-Prüfung",
       "status": "Statusprüfung",
+      "remediate": "Reparatur vor Ort",
       "dispatch": "Hochfahren",
       "release": "Abbauen",
       "poll-failure": "Health-Check"

package/i18n/locales/en.json

@@ -6597,6 +6597,7 @@
     "empty": "No ephemeral environment for this run.",
     "provisionTypeLabel": "Provision type:",
     "engineLabel": "Engine:",
+    "statusNote": "Provider note: {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6622,6 +6623,7 @@
       "teardown": "Tear down",
       "teardown-verify": "Teardown check",
       "status": "Status check",
+      "remediate": "Repair in place",
       "dispatch": "Spin up",
       "release": "Tear down",
       "poll-failure": "Health check"

package/i18n/locales/es.json

@@ -6293,6 +6293,7 @@
     "empty": "No hay entorno efímero para esta ejecución.",
     "provisionTypeLabel": "Tipo de aprovisionamiento:",
     "engineLabel": "Motor:",
+    "statusNote": "Nota del proveedor: {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6318,6 +6319,7 @@
       "teardown": "Desmontar",
       "teardown-verify": "Comprobación de desmontaje",
       "status": "Comprobación de estado",
+      "remediate": "Reparación en sitio",
       "dispatch": "Arrancar",
       "release": "Desmontar",
       "poll-failure": "Comprobación de salud"

package/i18n/locales/fr.json

@@ -6293,6 +6293,7 @@
     "empty": "Aucun environnement éphémère pour cette exécution.",
     "provisionTypeLabel": "Type de provisionnement :",
     "engineLabel": "Moteur :",
+    "statusNote": "Note du fournisseur : {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6318,6 +6319,7 @@
       "teardown": "Démanteler",
       "teardown-verify": "Vérification du démantèlement",
       "status": "Vérification de l'état",
+      "remediate": "Réparation sur place",
       "dispatch": "Démarrer",
       "release": "Démanteler",
       "poll-failure": "Contrôle de santé"

package/i18n/locales/he.json

@@ -6293,6 +6293,7 @@
     "empty": "אין סביבה זמנית להרצה הזו.",
     "provisionTypeLabel": "סוג אספקה:",
     "engineLabel": "מנוע:",
+    "statusNote": "הערת הספק: {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6318,6 +6319,7 @@
       "teardown": "פירוק",
       "teardown-verify": "בדיקת פירוק",
       "status": "בדיקת מצב",
+      "remediate": "תיקון במקום",
       "dispatch": "הקמה",
       "release": "פירוק",
       "poll-failure": "בדיקת תקינות"

package/i18n/locales/it.json

@@ -6874,6 +6874,7 @@
     "empty": "Nessun ambiente effimero per questa esecuzione.",
     "provisionTypeLabel": "Tipo di provisioning:",
     "engineLabel": "Motore:",
+    "statusNote": "Nota del provider: {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6899,6 +6900,7 @@
       "teardown": "Smantellamento",
       "teardown-verify": "Verifica dello smantellamento",
       "status": "Controllo dello stato",
+      "remediate": "Riparazione sul posto",
       "dispatch": "Avvio",
       "release": "Smantellamento",
       "poll-failure": "Controllo dello stato di salute"

package/i18n/locales/ja.json

@@ -6293,6 +6293,7 @@
     "empty": "この実行に一時環境はありません。",
     "provisionTypeLabel": "プロビジョニングタイプ:",
     "engineLabel": "エンジン:",
+    "statusNote": "プロバイダーからの注記: {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6318,6 +6319,7 @@
       "teardown": "破棄",
       "teardown-verify": "破棄の確認",
       "status": "ステータスチェック",
+      "remediate": "その場で修復",
       "dispatch": "起動",
       "release": "破棄",
       "poll-failure": "ヘルスチェック"

package/i18n/locales/pl.json

@@ -6293,6 +6293,7 @@
     "empty": "Brak środowiska efemerycznego dla tego uruchomienia.",
     "provisionTypeLabel": "Typ provisioningu:",
     "engineLabel": "Silnik:",
+    "statusNote": "Uwaga dostawcy: {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6318,6 +6319,7 @@
       "teardown": "Zatrzymaj",
       "teardown-verify": "Sprawdzenie zatrzymania",
       "status": "Sprawdzenie stanu",
+      "remediate": "Naprawa na miejscu",
       "dispatch": "Uruchom",
       "release": "Zatrzymaj",
       "poll-failure": "Kontrola kondycji"

package/i18n/locales/tr.json

@@ -6293,6 +6293,7 @@
     "empty": "Bu çalışma için geçici ortam yok.",
     "provisionTypeLabel": "Sağlama türü:",
     "engineLabel": "Motor:",
+    "statusNote": "Sağlayıcı notu: {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6318,6 +6319,7 @@
       "teardown": "Kapat",
       "teardown-verify": "Kapatma kontrolü",
       "status": "Durum kontrolü",
+      "remediate": "Yerinde onarım",
       "dispatch": "Başlat",
       "release": "Kapat",
       "poll-failure": "Sağlık kontrolü"

package/i18n/locales/uk.json

@@ -6293,6 +6293,7 @@
     "empty": "Для цього запуску немає ефемерного середовища.",
     "provisionTypeLabel": "Тип провіженінгу:",
     "engineLabel": "Рушій:",
+    "statusNote": "Примітка провайдера: {note}",
     "provisionType": {
       "kubernetes": "Kubernetes",
       "docker-compose": "Docker Compose",
@@ -6318,6 +6319,7 @@
       "teardown": "Згорнути",
       "teardown-verify": "Перевірка згортання",
       "status": "Перевірка стану",
+      "remediate": "Ремонт на місці",
       "dispatch": "Запустити",
       "release": "Згорнути",
       "poll-failure": "Перевірка справності"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cat-factory/app",
-  "version": "0.289.0",
+  "version": "0.290.0",
   "description": "Reusable Nuxt layer for the Agent Architecture Board SPA (components, stores, composables, pages). Consume it from a thin deployment app via `extends: ['@cat-factory/app']` and point it at your backend with NUXT_PUBLIC_API_BASE. See deploy/frontend for an example.",
   "repository": {
     "type": "git",
@@ -18,7 +18,7 @@
     "access": "public"
   },
   "dependencies": {
-    "@cat-factory/contracts": "0.335.0",
+    "@cat-factory/contracts": "0.336.0",
     "@modular-frontend/core": "0.6.0",
     "@modular-vue/core": "^1.5.0",
     "@modular-vue/journeys": "^1.4.0",