@cat-factory/app 0.269.1 → 0.270.1

package/app/components/settings/RiskPolicyCreateForm.vue

@@ -43,6 +43,7 @@ function submit() {
     ciMaxAttempts: draft.ciMaxAttempts,
     maxRequirementIterations: draft.maxRequirementIterations,
     maxRequirementConcernAllowed: draft.maxRequirementConcernAllowed,
+    companionMaxReworks: draft.companionMaxReworks,
     autoMergeEnabled: draft.autoMergeEnabled,
     autonomy: draft.unattended ? 'unattended' : 'attended',
     minAutoAnswerConfidence: draft.minAutoAnswerConfidence / 100,
@@ -127,6 +128,18 @@ function submit() {
           size="sm"
         />
       </label>
+      <label class="block w-20">
+        <span class="mb-1 block text-[10px] uppercase tracking-wide text-slate-500">
+          {{ t('settings.riskPolicy.create.companionRework') }}
+        </span>
+        <UInput
+          v-model.number="draft.companionMaxReworks"
+          type="number"
+          :min="0"
+          :max="10"
+          size="sm"
+        />
+      </label>
       <label class="block w-32">
         <span class="mb-1 block text-[10px] uppercase tracking-wide text-slate-500">
           {{ t('settings.riskPolicy.create.autoPass') }}

package/app/components/settings/RiskPolicyEditorRow.vue

@@ -185,6 +185,18 @@ const deleteBlocked = computed(
           size="sm"
         />
       </label>
+      <label class="block">
+        <span class="mb-1 block text-[10px] uppercase tracking-wide text-slate-500">
+          {{ t('settings.riskPolicy.field.companionMaxReworks') }}
+        </span>
+        <UInput
+          v-model.number="draft.companionMaxReworks"
+          type="number"
+          :min="0"
+          :max="10"
+          size="sm"
+        />
+      </label>
       <label class="block">
         <span class="mb-1 block text-[10px] uppercase tracking-wide text-slate-500">
           {{ t('settings.riskPolicy.field.maxRequirementConcernAllowed') }}

package/app/composables/useRunStart.spec.ts

@@ -25,6 +25,7 @@ const preset = (over: Partial<RiskPolicyLibraryEntry> = {}): RiskPolicyLibraryEn
     maxRequirementIterations: 6,
     maxRequirementConcernAllowed: 'none',
     maxTesterQualityIterations: 3,
+    companionMaxReworks: 3,
     releaseWatchWindowMinutes: 30,
     releaseMaxAttempts: 1,
     humanReviewGraceMinutes: 10,

package/app/utils/riskPolicy.spec.ts

@@ -20,6 +20,7 @@ const policy = (over: Partial<RiskPolicy> = {}): RiskPolicy =>
     maxRequirementIterations: 6,
     maxRequirementConcernAllowed: 'none',
     maxTesterQualityIterations: 3,
+    companionMaxReworks: 3,
     releaseWatchWindowMinutes: 30,
     releaseMaxAttempts: 1,
     humanReviewGraceMinutes: 10,

package/app/utils/riskPolicyDraft.spec.ts

@@ -0,0 +1,111 @@
+import { describe, expect, it } from 'vitest'
+import * as v from 'valibot'
+import { createRiskPolicySchema } from '@cat-factory/contracts'
+import type { RiskPolicy } from '~/types/merge'
+import {
+  blankRiskPolicyDraft,
+  riskPolicyPatchFromDraft,
+  toRiskPolicyDraft,
+  type RiskPolicyDraft,
+} from '~/utils/riskPolicyDraft'
+
+// The conversions either side of the policy editor's form state. They are worth their own spec
+// because the way they break is SILENT: a field the draft carries but nothing maps into the patch
+// renders a control that accepts an operator's edit, PATCHes without it, and re-renders the old
+// value with no error anywhere to say the save dropped something.
+
+const policy = (over: Partial<RiskPolicy> = {}): RiskPolicy =>
+  ({
+    id: 'mp_balanced',
+    name: 'Balanced',
+    maxComplexity: 0.6,
+    maxRisk: 0.4,
+    maxImpact: 0.5,
+    ciMaxAttempts: 10,
+    maxRequirementIterations: 6,
+    maxRequirementConcernAllowed: 'none',
+    maxTesterQualityIterations: 3,
+    companionMaxReworks: 3,
+    releaseWatchWindowMinutes: 30,
+    releaseMaxAttempts: 1,
+    humanReviewGraceMinutes: 10,
+    judgeMinScore: 0.7,
+    judgeMaxBounces: 2,
+    autoMergeEnabled: true,
+    autonomy: 'attended',
+    minAutoAnswerConfidence: 0.8,
+    classRules: {},
+    classRulesByRole: {},
+    dryRunRoles: [],
+    submissionClassesByRole: {},
+    isDefault: true,
+    isUnattendedDefault: false,
+    version: 1,
+    createdAt: 0,
+    updatedAt: 0,
+    ...over,
+  }) as RiskPolicy
+
+/**
+ * A different value of the same type, whatever the field holds. Generic on purpose: the assertion
+ * below iterates the draft's own keys, so it must not know which of them are numbers.
+ */
+function nudge(value: unknown): unknown {
+  if (typeof value === 'number') return value + 1
+  if (typeof value === 'boolean') return !value
+  if (typeof value === 'string') {
+    if (value === 'run') return 'skip'
+    if (value === 'none') return 'high'
+    return `${value} (edited)`
+  }
+  if (Array.isArray(value)) return ['admin']
+  return { feature: { maxRisk: 0.1 } }
+}
+
+describe('the risk-policy draft conversions', () => {
+  it('carries every field the draft holds into the patch body', () => {
+    // Iterating the draft's OWN keys is what makes this hold for a field added later: the interface
+    // is what a new control is added to, and anything on it that `riskPolicyPatchFromDraft` forgets
+    // fails here rather than in production.
+    const base = toRiskPolicyDraft(policy())
+    const unchanged = riskPolicyPatchFromDraft(base, 'Balanced')
+    for (const key of Object.keys(base) as (keyof RiskPolicyDraft)[]) {
+      const edited = { ...base, [key]: nudge(base[key]) } as RiskPolicyDraft
+      expect(
+        riskPolicyPatchFromDraft(edited, 'Balanced'),
+        `draft field '${key}' never reaches the patch body`,
+      ).not.toEqual(unchanged)
+    }
+  })
+
+  it('round-trips a stored policy unchanged when nothing is edited', () => {
+    const stored = policy({ companionMaxReworks: 7, maxRisk: 0.45, autonomy: 'unattended' })
+    const patch = riskPolicyPatchFromDraft(toRiskPolicyDraft(stored), 'fallback')
+
+    // The percentages went up by a hundred for editing and came back down; the counts and the
+    // posture are stored as typed.
+    expect(patch.maxRisk).toBe(0.45)
+    expect(patch.minAutoAnswerConfidence).toBe(0.8)
+    expect(patch.companionMaxReworks).toBe(7)
+    expect(patch.autonomy).toBe('unattended')
+  })
+
+  it('keeps a blanked name from saving over the stored one', () => {
+    const draft = { ...toRiskPolicyDraft(policy()), name: '   ' }
+    expect(riskPolicyPatchFromDraft(draft, 'Balanced').name).toBe('Balanced')
+  })
+
+  it('opens the create form on the value the API would have defaulted to', () => {
+    // Read off the create schema rather than restated, so a shipped default that moves takes the
+    // blank form with it instead of leaving it pre-filling a number nothing else states.
+    expect(blankRiskPolicyDraft().companionMaxReworks).toBe(
+      v.getDefault(createRiskPolicySchema.entries.companionMaxReworks),
+    )
+  })
+
+  it('never opens the create form on a granted licence', () => {
+    // The one default the blank form may NOT inherit from anywhere: an unattended posture is
+    // something a person grants, so a new policy parks on its own caps.
+    expect(blankRiskPolicyDraft().unattended).toBe(false)
+  })
+})

package/app/utils/riskPolicyDraft.ts

@@ -1,4 +1,4 @@
-import type { StepGating } from '@cat-factory/contracts'
+import { DEFAULT_COMPANION_MAX_ATTEMPTS, type StepGating } from '@cat-factory/contracts'
 import type {
   ClassRulesByRole,
   DryRunRoles,
@@ -25,6 +25,12 @@ export interface RiskPolicyDraft {
   ciMaxAttempts: number
   maxRequirementIterations: number
   maxRequirementConcernAllowed: RequirementConcernLevel
+  /**
+   * How many automatic rework rounds a companion (reviewer / architect-companion /
+   * spec-companion) may drive before the run parks for a person. `0` sends the first verdict below
+   * the bar straight to that park, which is a posture rather than a disabled loop.
+   */
+  companionMaxReworks: number
   autoMergeEnabled: boolean
   /**
    * Whether a run under this policy answers the parks its own automatic loops raise when they give
@@ -87,6 +93,7 @@ export function toRiskPolicyDraft(p: RiskPolicy): RiskPolicyDraft {
     ciMaxAttempts: p.ciMaxAttempts,
     maxRequirementIterations: p.maxRequirementIterations,
     maxRequirementConcernAllowed: p.maxRequirementConcernAllowed,
+    companionMaxReworks: p.companionMaxReworks,
     autoMergeEnabled: p.autoMergeEnabled,
     unattended: p.autonomy === 'unattended',
     minAutoAnswerConfidence: Math.round(p.minAutoAnswerConfidence * 100),
@@ -112,6 +119,10 @@ export function blankRiskPolicyDraft(): RiskPolicyDraft {
     ciMaxAttempts: 10,
     maxRequirementIterations: 6,
     maxRequirementConcernAllowed: 'none',
+    // Off the constant the create schema itself defaults to, so the form cannot pre-fill a number
+    // the platform has stopped shipping. The percentages above are literals because they are the
+    // EDITING scale (0..100) rather than the stored value; this one is stored as typed.
+    companionMaxReworks: DEFAULT_COMPANION_MAX_ATTEMPTS,
     autoMergeEnabled: true,
     // A new policy parks on its own caps, matching every built-in but the unattended default: a
     // licence to answer them is a posture somebody grants, never one a blank form assumes.
@@ -162,6 +173,7 @@ export function riskPolicyPatchFromDraft(
     ciMaxAttempts: d.ciMaxAttempts,
     maxRequirementIterations: d.maxRequirementIterations,
     maxRequirementConcernAllowed: d.maxRequirementConcernAllowed,
+    companionMaxReworks: d.companionMaxReworks,
     autoMergeEnabled: d.autoMergeEnabled,
     autonomy: d.unattended ? 'unattended' : 'attended',
     minAutoAnswerConfidence: d.minAutoAnswerConfidence / 100,

package/i18n/locales/de.json

@@ -538,6 +538,7 @@
         "ciMaxAttempts": "CI-Fix-Versuche",
         "maxRequirementIterations": "Anforderungs-Iterationen",
         "maxRequirementConcernAllowed": "Auto-Pass bei Bedenken auf oder unter",
+        "companionMaxReworks": "Begleiter-Überarbeitungsrunden",
         "autoMerge": "Auto-Merge"
       },
       "autoMergeOnHint": "Automatisch mergen, wenn innerhalb der Richtliniengrenzen.",
@@ -551,6 +552,7 @@
         "impact": "Ausw.%",
         "ciFix": "CI-Fix",
         "reqIter": "Anf.-Iter.",
+        "companionRework": "Überarb.",
         "autoPass": "Auto-Pass auf oder unter"
       },
       "add": "Hinzufügen",

package/i18n/locales/en.json

@@ -3275,6 +3275,7 @@
         "ciMaxAttempts": "CI-fix attempts",
         "maxRequirementIterations": "Requirement iterations",
         "maxRequirementConcernAllowed": "Auto-pass concerns at or below",
+        "companionMaxReworks": "Companion rework rounds",
         "autoMerge": "Auto-merge"
       },
       "autoMergeOnHint": "Merge automatically when within the policy limits.",
@@ -3288,6 +3289,7 @@
         "impact": "Impact%",
         "ciFix": "CI-fix",
         "reqIter": "Req iter",
+        "companionRework": "Rework",
         "autoPass": "Auto-pass at or below"
       },
       "add": "Add",

package/i18n/locales/es.json

@@ -3001,6 +3001,7 @@
         "ciMaxAttempts": "Intentos de corrección de CI",
         "maxRequirementIterations": "Iteraciones de requisitos",
         "maxRequirementConcernAllowed": "Aprobación automática de inquietudes hasta",
+        "companionMaxReworks": "Rondas de reelaboración del acompañante",
         "autoMerge": "Fusión automática"
       },
       "newPreset": "Nueva política",
@@ -3012,6 +3013,7 @@
         "impact": "Impacto%",
         "ciFix": "Corr. CI",
         "reqIter": "Iter. req.",
+        "companionRework": "Reelab.",
         "autoPass": "Aprob. auto. hasta"
       },
       "add": "Añadir",

package/i18n/locales/fr.json

@@ -3001,6 +3001,7 @@
         "ciMaxAttempts": "Tentatives de correction CI",
         "maxRequirementIterations": "Itérations d'exigences",
         "maxRequirementConcernAllowed": "Validation auto. des préoccupations jusqu'à",
+        "companionMaxReworks": "Cycles de retravail du compagnon",
         "autoMerge": "Fusion automatique"
       },
       "newPreset": "Nouvelle politique",
@@ -3012,6 +3013,7 @@
         "impact": "Impact%",
         "ciFix": "Corr. CI",
         "reqIter": "Itér. exig.",
+        "companionRework": "Retrav.",
         "autoPass": "Valid. auto. jusqu'à"
       },
       "add": "Ajouter",

package/i18n/locales/he.json

@@ -3143,6 +3143,7 @@
         "ciMaxAttempts": "ניסיונות תיקון CI",
         "maxRequirementIterations": "איטרציות דרישות",
         "maxRequirementConcernAllowed": "מעבר אוטומטי בחששות ברף או מתחתיו",
+        "companionMaxReworks": "סבבי עיבוד מחדש של המלווה",
         "autoMerge": "מיזוג אוטומטי"
       },
       "newPreset": "מדיניות חדשה",
@@ -3154,6 +3155,7 @@
         "impact": "השפעה%",
         "ciFix": "תיקון CI",
         "reqIter": "איטרציות דרישות",
+        "companionRework": "עיבוד מחדש",
         "autoPass": "מעבר אוטומטי ברף או מתחתיו"
       },
       "add": "הוסף",

package/i18n/locales/it.json

@@ -538,6 +538,7 @@
         "ciMaxAttempts": "Tentativi di correzione CI",
         "maxRequirementIterations": "Iterazioni sui requisiti",
         "maxRequirementConcernAllowed": "Auto-pass per criticita pari o inferiori a",
+        "companionMaxReworks": "Cicli di rielaborazione del companion",
         "autoMerge": "Auto-merge"
       },
       "autoMergeOnHint": "Mergia automaticamente quando rientra nei limiti del criterio.",
@@ -551,6 +552,7 @@
         "impact": "Impatto%",
         "ciFix": "Corr. CI",
         "reqIter": "Iter req",
+        "companionRework": "Rielab.",
         "autoPass": "Auto-pass pari o inferiore a"
       },
       "add": "Aggiungi",

package/i18n/locales/ja.json

@@ -3143,6 +3143,7 @@
         "ciMaxAttempts": "CI 修正の試行回数",
         "maxRequirementIterations": "要件のイテレーション回数",
         "maxRequirementConcernAllowed": "この水準以下の懸念を自動承認",
+        "companionMaxReworks": "コンパニオンの再作業回数",
         "autoMerge": "自動マージ"
       },
       "newPreset": "新しいポリシー",
@@ -3154,6 +3155,7 @@
         "impact": "影響度%",
         "ciFix": "CI 修正",
         "reqIter": "要件イテレ",
+        "companionRework": "再作業",
         "autoPass": "この水準以下を自動承認"
       },
       "add": "追加",

package/i18n/locales/pl.json

@@ -3001,6 +3001,7 @@
         "ciMaxAttempts": "Próby naprawy CI",
         "maxRequirementIterations": "Iteracje wymagań",
         "maxRequirementConcernAllowed": "Automatyczne zaliczenie zastrzeżeń do",
+        "companionMaxReworks": "Rundy przeróbek towarzysza",
         "autoMerge": "Auto-scalanie"
       },
       "newPreset": "Nowa zasada",
@@ -3012,6 +3013,7 @@
         "impact": "Wpływ%",
         "ciFix": "Napr. CI",
         "reqIter": "Iter. wym.",
+        "companionRework": "Przeróbki",
         "autoPass": "Auto-zalicz do"
       },
       "add": "Dodaj",

package/i18n/locales/tr.json

@@ -3143,6 +3143,7 @@
         "ciMaxAttempts": "CI düzeltme denemeleri",
         "maxRequirementIterations": "Gereksinim yinelemeleri",
         "maxRequirementConcernAllowed": "Şu düzeyde veya altında otomatik geç",
+        "companionMaxReworks": "Yardımcı yeniden çalışma turları",
         "autoMerge": "Otomatik birleştirme"
       },
       "newPreset": "Yeni ilke",
@@ -3154,6 +3155,7 @@
         "impact": "Etki%",
         "ciFix": "CI düzeltme",
         "reqIter": "Grks. yin.",
+        "companionRework": "Yen. çalışma",
         "autoPass": "Şu düzeyde veya altında otomatik geç"
       },
       "add": "Ekle",

package/i18n/locales/uk.json

@@ -3001,6 +3001,7 @@
         "ciMaxAttempts": "Спроби виправлення CI",
         "maxRequirementIterations": "Ітерації вимог",
         "maxRequirementConcernAllowed": "Авто-пропуск зауважень до",
+        "companionMaxReworks": "Цикли переробки компаньйона",
         "autoMerge": "Автозлиття"
       },
       "newPreset": "Нова політика",
@@ -3012,6 +3013,7 @@
         "impact": "Вплив%",
         "ciFix": "Випр. CI",
         "reqIter": "Ітер. вим.",
+        "companionRework": "Переробка",
         "autoPass": "Авто-пропуск до"
       },
       "add": "Додати",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cat-factory/app",
-  "version": "0.269.1",
+  "version": "0.270.1",
   "description": "Reusable Nuxt layer for the Agent Architecture Board SPA (components, stores, composables, pages). Consume it from a thin deployment app via `extends: ['@cat-factory/app']` and point it at your backend with NUXT_PUBLIC_API_BASE. See deploy/frontend for an example.",
   "repository": {
     "type": "git",
@@ -40,7 +40,7 @@
     "valibot": "^1.4.2",
     "vue": "3.5.41",
     "wretch": "^3.0.9",
-    "@cat-factory/contracts": "0.306.0"
+    "@cat-factory/contracts": "0.308.0"
   },
   "devDependencies": {
     "@toad-contracts/testing": "0.3.2",