@cat-factory/app 0.268.1 → 0.269.0

package/app/composables/useModelPresetHealth.spec.ts

@@ -0,0 +1,82 @@
+import { describe, expect, it } from 'vitest'
+import type { ModelPreset } from '~/types/model-presets'
+import { useModelPresetsStore } from '~/stores/modelPresets'
+import { useModelPresetHealth } from '~/composables/useModelPresetHealth'
+
+/**
+ * The startup model-preset advisory. Its sibling `usePipelineHealth` has had a spec since the
+ * catalog-drift bug; this one had none until `mdp_chatgpt` shipped and made the gap visible: the
+ * advisory NAMES a built-in the board holds no row for, and a name is the only thing in that modal
+ * a user can act on.
+ */
+
+let nextId = 0
+function stored(over: Partial<ModelPreset> = {}): ModelPreset {
+  return {
+    id: `mdp_stored_${nextId++}`,
+    name: 'Stored',
+    baseModelId: 'kimi-k2.7',
+    overrides: {},
+    isDefault: false,
+    version: 1,
+    createdAt: nextId,
+    ...over,
+  }
+}
+
+/** Seed the store the way a snapshot hydrate does (rows + the catalog version/name pair), then scan. */
+function scan(
+  presets: ModelPreset[],
+  versions: Record<string, number>,
+  names: Record<string, string> = {},
+) {
+  useModelPresetsStore().hydrate(presets, versions, names)
+  return useModelPresetHealth()
+}
+
+describe('useModelPresetHealth', () => {
+  it('names a new built-in from the catalog map, not from its humanised id', () => {
+    // The regression this file exists for. Every board created before the preset shipped hits this
+    // branch on its next load, and the humanised id reads "chatgpt" (rendered "Chatgpt" by the
+    // modal's `capitalize`) for a preset the rest of the product calls GPT-5.6 Sol.
+    const { newPresets } = scan([], { mdp_chatgpt: 1 }, { mdp_chatgpt: 'GPT-5.6 Sol' })
+    expect(newPresets.value).toEqual([{ type: 'new', id: 'mdp_chatgpt', name: 'GPT-5.6 Sol' }])
+  })
+
+  it('falls back to the humanised id when the facade ships no name map', () => {
+    // Forward-compatibility only: the field is optional on the wire, so an older facade's snapshot
+    // must still produce an offer rather than a blank row.
+    const { newPresets } = scan([], { mdp_chatgpt: 1 })
+    expect(newPresets.value).toEqual([{ type: 'new', id: 'mdp_chatgpt', name: 'chatgpt' }])
+  })
+
+  it('prefers the STORED row name over the catalog one for an outdated built-in', () => {
+    // A stored built-in is what the user sees in their library, and its name is what they renamed
+    // it to (or the older catalog name a reseed is about to replace). Reporting the catalog's newer
+    // name here would describe the row by the value the fix installs, not the one on screen.
+    const { outdated, newPresets } = scan(
+      [stored({ id: 'mdp_claude', name: 'Claude Opus 4.8', version: 1 })],
+      { mdp_claude: 2 },
+      { mdp_claude: 'Claude Opus 5' },
+    )
+    expect(newPresets.value).toEqual([])
+    expect(outdated.value).toEqual([
+      { type: 'outdated', id: 'mdp_claude', name: 'Claude Opus 4.8', fromVersion: 1, toVersion: 2 },
+    ])
+  })
+
+  it('reports nothing when every built-in is stored at its catalog version', () => {
+    const { issues, hasIssues } = scan(
+      [stored({ id: 'mdp_kimi', name: 'Kimi K2.7', version: 1 })],
+      { mdp_kimi: 1 },
+      { mdp_kimi: 'Kimi K2.7' },
+    )
+    expect(issues.value).toEqual([])
+    expect(hasIssues.value).toBe(false)
+  })
+
+  it('ignores a user-created preset, which no catalog version covers', () => {
+    const { issues } = scan([stored({ id: 'mdp_mine', version: 99 })], { mdp_kimi: 1 })
+    expect(issues.value.map((i) => i.id)).toEqual(['mdp_kimi'])
+  })
+})

package/app/composables/useModelPresetHealth.ts

@@ -17,11 +17,23 @@ export interface ModelPresetIssue {
   toVersion?: number
 }
 
-/** A built-in's display name for an issue message (humanise its catalog id as a fallback). */
-function builtinName(id: string, stored: ModelPreset | undefined): string {
+/**
+ * A built-in's display name for an issue message: the stored row's when there is one, else the
+ * catalog's own name from the snapshot's companion map.
+ *
+ * The humanised id (`mdp_kimi` to "kimi", rendered capitalised) is the FALLBACK for a facade that
+ * ships no name map, not the primary answer. It reads acceptably for the built-ins whose ids ARE
+ * their names and wrongly for the first one where it is not: `mdp_chatgpt` came out as "Chatgpt" in
+ * the modal offering to add it, a name for GPT-5.6 Sol that appears nowhere else in the product,
+ * on exactly the boards that predate the preset and therefore see this advisory.
+ */
+function builtinName(
+  id: string,
+  stored: ModelPreset | undefined,
+  names: Record<string, string>,
+): string {
   if (stored) return stored.name
-  // `mdp_claude` -> "claude" — only used until the row is reseeded into existence.
-  return id.replace(/^mdp_/, '').replace(/_/g, ' ')
+  return names[id] ?? id.replace(/^mdp_/, '').replace(/_/g, ' ')
 }
 
 /**
@@ -41,7 +53,7 @@ export function useModelPresetHealth() {
     for (const [id, catalogVersion] of Object.entries(store.catalogVersions)) {
       const stored = byId.get(id)
       if (!stored) {
-        out.push({ type: 'new', id, name: builtinName(id, undefined) })
+        out.push({ type: 'new', id, name: builtinName(id, undefined, store.catalogNames) })
         continue
       }
       if (catalogVersion > (stored.version ?? 0)) {

package/app/stores/modelPresets.ts

@@ -26,10 +26,27 @@ export const useModelPresetsStore = defineStore('modelPresets', () => {
    * `useModelPresetHealth`.
    */
   const catalogVersions = ref<Record<string, number>>({})
+  /**
+   * The catalog's own NAME per id in {@link catalogVersions}, from the same snapshot field pair.
+   * Read only where a built-in has no stored row to take a name off, which is the "new built-in"
+   * advisory and nothing else. Empty for a facade that ships no name map.
+   */
+  const catalogNames = ref<Record<string, string>>({})
 
-  function hydrate(list: ModelPreset[], versions?: Record<string, number>) {
+  function hydrate(
+    list: ModelPreset[],
+    versions?: Record<string, number>,
+    names?: Record<string, string>,
+  ) {
     presets.value = [...list].sort((a, b) => a.createdAt - b.createdAt)
-    if (versions) catalogVersions.value = versions
+    // The two catalog maps move TOGETHER, being one snapshot read split in two and keyed
+    // identically by construction. Assigning names on their own truthiness would let a facade
+    // shipping versions and no names leave the previous board's names indexed against this board's
+    // ids, which is the one way the pair can disagree (see the pipelines store).
+    if (versions) {
+      catalogVersions.value = versions
+      catalogNames.value = names ?? {}
+    }
   }
 
   /** The workspace default (fallback for a task that picks none). */
@@ -99,6 +116,7 @@ export const useModelPresetsStore = defineStore('modelPresets', () => {
   return {
     presets,
     catalogVersions,
+    catalogNames,
     defaultPreset,
     resolve,
     modelForKind,

package/app/stores/workspace/hydrate.ts

@@ -87,7 +87,11 @@ export function applySnapshotToStores(snapshot: WorkspaceSnapshot, baselines?: L
   useSharedStacksStore().hydrate(snapshot.sharedStacks ?? [])
   useWorkspaceSettingsStore().hydrate(snapshot.settings)
   useAgentConfigStore().hydrate(snapshot.agentConfigCatalog ?? [])
-  useModelPresetsStore().hydrate(snapshot.modelPresets ?? [], snapshot.modelPresetCatalogVersions)
+  useModelPresetsStore().hydrate(
+    snapshot.modelPresets ?? [],
+    snapshot.modelPresetCatalogVersions,
+    snapshot.modelPresetCatalogNames,
+  )
   useConsensusGroupsStore().hydrate(snapshot.consensusGroups ?? [])
   useServiceFragmentDefaultsStore().hydrate(snapshot.serviceFragmentDefaults?.fragmentIds)
   useRecurringPipelinesStore().hydrate(snapshot.recurringPipelines ?? [])

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cat-factory/app",
-  "version": "0.268.1",
+  "version": "0.269.0",
   "description": "Reusable Nuxt layer for the Agent Architecture Board SPA (components, stores, composables, pages). Consume it from a thin deployment app via `extends: ['@cat-factory/app']` and point it at your backend with NUXT_PUBLIC_API_BASE. See deploy/frontend for an example.",
   "repository": {
     "type": "git",
@@ -40,7 +40,7 @@
     "valibot": "^1.4.2",
     "vue": "3.5.41",
     "wretch": "^3.0.9",
-    "@cat-factory/contracts": "0.304.0"
+    "@cat-factory/contracts": "0.305.0"
   },
   "devDependencies": {
     "@toad-contracts/testing": "0.3.2",