@cat-factory/app 0.227.0 → 0.228.1

package/README.md

@@ -181,6 +181,15 @@ hoc where it can be avoided:
   control, editable, as soon as any value it edits is set (`false` included: a tri-state
   `false` is a choice, not absence), so basic mode can never conceal a setting a run will
   actually use.
+- **The tier may also change which of two routes to the same thing LEADS**, and that is not a
+  hidden capability: a `pr_ready` task card offers the outcome summary in both tiers and drops
+  the raw pull-request chip in basic, because the card the button opens carries that same link
+  at the top. What basic mode may never do is remove the only route (the rule above); ordering
+  two routes by which one a tier's reader wants first is what the tier is for. **Write the
+  condition as that INVARIANT, not as `isAdvanced` alone** (`TaskCard`'s `showPrChip`: keep the
+  chip wherever the outcome card is not offered), because the surface that carries the hidden
+  half is itself conditional, and two predicates that must agree by coincidence eventually do
+  not: the day the leading route hides, `isAdvanced` alone takes the last route with it.
 
 ## Agent tiers (basic / intermediate / advanced)
 
@@ -700,6 +709,22 @@ example ships in [`deploy/frontend`](../../deploy/frontend) (the `acme:security`
   additionally leads with `TaskReviewTarget`, linking the pull request it reviews:
   distinct from the execution panel's link to the PR a run PRODUCED, which a review
   task never has.
+- **Outcome summary** (`components/outcome`): the run-keyed result window, and what
+  the board card and the inspector open to "read the result". It renders the reduction
+  in `utils/runOutcome.ts` (requirement coverage joined to the service spec, the
+  tester's verdict, the captured views, the recorded checks) and keeps the pull request
+  at the top, so the diff stays one click away rather than being the starting point.
+  The only result window keyed by a RUN rather than a step: it opens with
+  `stepIndex: null` and composes from the whole instance, which is also why it passes
+  no `stepRef` to the shell (there is no step to restart from). Available in both
+  interface tiers; what `basic` changes is which affordance leads (see
+  [interface modes](#interface-modes-basic--advanced)).
+  Two rules bind anything added to it. Every entry point gates on `hasOutcomeToShow`
+  from the same reduction, so the card is never offered onto sections that all read
+  "nothing here". And the window is BLOCK-keyed with the run riding along: a block
+  naming a run the store never hydrated is a distinct fact from a task that never ran
+  (`RunUnavailableGap`), so a new section reports that case rather than composing from
+  the empty step list, which would read as a pipeline that produced nothing.
 - **Pipeline builder** (`components/pipeline`): assemble/edit agent chains and
   watch `PipelineProgress`. `PipelinePicker` (+ its `PipelinePreview` pane) is the
   single way a pipeline is chosen anywhere (add-task, run settings, the recurring

package/app/components/board/AddTaskModal.vue

@@ -59,12 +59,7 @@ const { t } = useI18n()
 
 const { linkPending, presentLinkFailures } = useContextLinking()
 
-const open = computed({
-  get: () => ui.addTaskContainerId !== null,
-  set: (v: boolean) => {
-    if (!v) void requestClose()
-  },
-})
+const open = computed(() => ui.addTaskContainerId !== null)
 
 const container = computed(() =>
   ui.addTaskContainerId ? board.getBlock(ui.addTaskContainerId) : undefined,
@@ -591,6 +586,15 @@ const { requestClose } = useUnsavedGuard({
   }),
 })
 
+// The template's v-model binding: dismissal (Escape / backdrop) routes through the guard.
+// Declared after the guard so the setter's `requestClose` reference is never in its TDZ.
+const modalOpen = computed({
+  get: () => open.value,
+  set: (v: boolean) => {
+    if (!v) void requestClose()
+  },
+})
+
 // A recurring task only needs a target frame (its details are filled in the schedule
 // modal); every other type needs a title. A review task additionally needs a target PR.
 // The Ralph loop's completion criterion (its `ralph.validationCommand` agent-config id). The
@@ -757,7 +761,7 @@ function openReviewFrictionDialog(conflict: NonNullable<ReturnType<typeof parseC
 </script>
 
 <template>
-  <UModal v-model:open="open" :title="t('board.addTask.title')">
+  <UModal v-model:open="modalOpen" :title="t('board.addTask.title')">
     <template #body>
       <div class="space-y-4" data-testid="add-task-modal">
         <p v-if="container" class="text-xs text-slate-400">

package/app/components/board/RecurringPipelineModal.vue

@@ -22,12 +22,7 @@ const toast = useToast()
 const access = useWorkspaceAccess()
 const { t, te } = useI18n()
 
-const open = computed({
-  get: () => ui.addRecurringFrameId !== null,
-  set: (v: boolean) => {
-    if (!v) void requestClose()
-  },
-})
+const open = computed(() => ui.addRecurringFrameId !== null)
 
 const frame = computed(() =>
   ui.addRecurringFrameId ? board.getBlock(ui.addRecurringFrameId) : undefined,
@@ -240,6 +235,15 @@ const { requestClose } = useUnsavedGuard({
   }),
 })
 
+// The template's v-model binding: dismissal (Escape / backdrop) routes through the guard.
+// Declared after the guard so the setter's `requestClose` reference is never in its TDZ.
+const modalOpen = computed({
+  get: () => open.value,
+  set: (v: boolean) => {
+    if (!v) void requestClose()
+  },
+})
+
 // The board field required for the picked source must be filled before a bug-intake schedule saves.
 const intakeReady = computed(() => {
   if (!showIntake.value) return true
@@ -339,7 +343,7 @@ async function add() {
 </script>
 
 <template>
-  <UModal v-model:open="open" :title="t('board.recurring.title')">
+  <UModal v-model:open="modalOpen" :title="t('board.recurring.title')">
     <template #body>
       <div class="space-y-4">
         <p v-if="frame" class="text-xs text-slate-400">

package/app/components/board/nodes/TaskCard.vue

@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import type { Block } from '~/types/domain'
 import { STATUS_META, MODULE_META, taskTypeMeta } from '~/utils/catalog'
+import { composeRunOutcome, hasOutcomeToShow } from '~/utils/runOutcome'
 import AgentFailureCard from '~/components/board/AgentFailureCard.vue'
 import TaskPipelineMini from './TaskPipelineMini.vue'
 
@@ -72,6 +73,40 @@ const prLabel = computed(() =>
   pr.value?.number ? t('board.task.prNumber', { number: pr.value.number }) : t('board.task.pr'),
 )
 
+/**
+ * Reading the result starts at the OUTCOME summary (what changed in product terms, with the
+ * captured evidence), and the pull request is one click inside it. In BASIC mode that replaces
+ * the card's raw PR chip: the diff is still exactly as reachable, through a surface that says
+ * what the diff is about first. Advanced mode keeps both, since a reader who wants the diff
+ * directly is the reader that tier is for.
+ *
+ * Offered only where there is something to read, asked of the SAME reduction the window renders
+ * and the inspector's button gates on: a card that offered "read the result" on a task whose
+ * every section says "nothing here" would teach people the surface is empty. A task marked done
+ * by hand, with no pull request and no run, is that task.
+ */
+const uiMode = useUiModeStore()
+const outcomeReadable = computed(() => {
+  const block = task.value
+  if (!block) return false
+  return hasOutcomeToShow(
+    composeRunOutcome({ block, instance: execution.getInstance(block.executionId) ?? null }),
+  )
+})
+/**
+ * The card's raw pull-request chip, which basic mode drops in favour of the outcome card
+ * carrying the same link at the top. Written as the INVARIANT ("the diff never stops being
+ * reachable from this card") rather than as `isAdvanced` alone, so the tier can only ever
+ * reorder two routes and never remove the last one: where the outcome card is not offered,
+ * the chip stays in both tiers.
+ */
+const showPrChip = computed(
+  () => Boolean(pr.value) && (uiMode.isAdvanced || !outcomeReadable.value),
+)
+function openOutcome() {
+  ui.openOutcome(props.taskId, task.value?.executionId ?? null)
+}
+
 // This task's current agent run (if any). A failed run must surface the shared
 // failure banner + retry — NOT a stuck progress bar — so the card never looks
 // like it's still working after the run has terminated.
@@ -402,8 +437,20 @@ function selectTask() {
 
       <template v-if="task.status === 'pr_ready'">
         <UButton
-          v-if="pr"
-          :to="pr.url"
+          v-if="outcomeReadable"
+          color="primary"
+          variant="soft"
+          size="xs"
+          icon="i-lucide-clipboard-check"
+          :title="t('board.task.readOutcomeHint')"
+          data-testid="task-open-outcome"
+          @click.stop="openOutcome"
+        >
+          {{ t('board.task.readOutcome') }}
+        </UButton>
+        <UButton
+          v-if="showPrChip"
+          :to="pr?.url"
           target="_blank"
           rel="noopener"
           external
@@ -436,12 +483,25 @@ function selectTask() {
         </UButton>
       </template>
 
-      <span
-        v-else-if="task.status === 'done'"
-        class="inline-flex items-center gap-1 text-[9px] text-emerald-400"
-      >
-        <UIcon name="i-lucide-check-check" class="h-3 w-3" /> {{ t('board.task.implemented') }}
-      </span>
+      <!-- A merged task is the one people come back to READ, so its result stays openable
+           rather than collapsing to a tick the moment it lands. -->
+      <template v-else-if="task.status === 'done'">
+        <span class="inline-flex items-center gap-1 text-[9px] text-emerald-400">
+          <UIcon name="i-lucide-check-check" class="h-3 w-3" /> {{ t('board.task.implemented') }}
+        </span>
+        <UButton
+          v-if="outcomeReadable"
+          color="neutral"
+          variant="ghost"
+          size="xs"
+          icon="i-lucide-clipboard-check"
+          :title="t('board.task.readOutcomeHint')"
+          data-testid="task-open-outcome"
+          @click.stop="openOutcome"
+        >
+          {{ t('board.task.readOutcome') }}
+        </UButton>
+      </template>
     </div>
 
     <!-- structural metadata: assigned module -->

package/app/components/bootstrap/BootstrapModal.vue

@@ -18,12 +18,7 @@ const { freeFramePosition, focusFrame } = useFramePlacement()
 const { t } = useI18n()
 const { confirmAction, toastDone } = useConfirmAction()
 
-const open = computed({
-  get: () => ui.bootstrapOpen,
-  set: (v: boolean) => {
-    if (!v) void requestClose()
-  },
-})
+const open = computed(() => ui.bootstrapOpen)
 
 // Load the workspace's reference architectures + recent jobs, plus (best-effort)
 // the GitHub repos the user can access so the base form can pick from them.
@@ -100,6 +95,15 @@ const { requestClose } = useUnsavedGuard({
   }),
 })
 
+// The template's v-model binding: dismissal (Escape / backdrop) routes through the guard.
+// Declared after the guard so the setter's `requestClose` reference is never in its TDZ.
+const modalOpen = computed({
+  get: () => open.value,
+  set: (v: boolean) => {
+    if (!v) void requestClose()
+  },
+})
+
 // Mirror of the backend `slugField` rule (@cat-factory/contracts bootstrap
 // schema): the new repo name is a SINGLE GitHub name segment — no "owner/"
 // prefix — so reject a bad value inline before we hit the API. Kept in sync with
@@ -420,7 +424,7 @@ const statusLabel = computed<Record<BootstrapStatus, string>>(() => ({
 </script>
 
 <template>
-  <UModal v-model:open="open" :title="t('bootstrap.title')" :ui="{ content: 'max-w-2xl' }">
+  <UModal v-model:open="modalOpen" :title="t('bootstrap.title')" :ui="{ content: 'max-w-2xl' }">
     <template #body>
       <div class="space-y-6">
         <!-- Three states, because each promises the user something different about the repo.

package/app/components/documents/RepoContextDocPicker.vue

@@ -75,6 +75,10 @@ watch(selectedRepoId, (id) => {
   if (found) selectedRepo.value = found
 })
 
+// The file-search query (its matches live in the file-selection section below). Declared
+// above `clearRepo` and the repo-switch watcher, which both reset it.
+const fileQuery = ref('')
+
 function clearRepo() {
   selectedRepoId.value = undefined
   selectedRepo.value = undefined
@@ -127,7 +131,6 @@ watch(selectedRepoId, (id) => {
   if (id !== undefined) void ensureFilesLoaded()
 })
 
-const fileQuery = ref('')
 // Matches are computed client-side from the cached tree (no per-keystroke server call).
 // A query is required so a large repo never renders thousands of rows at once; results
 // are capped for the same reason.

package/app/components/fragments/FragmentLibraryManager.vue

@@ -171,6 +171,19 @@ const editDraft = ref<{
   brief: string
   tags: string
 } | null>(null)
+// The linked SHORT VERSION is an OVERRIDE of what the platform does by default (condense a
+// long standard automatically, fold a short one in full), so it follows the override rule:
+// hidden in basic mode while unset, revealed as soon as the fragment carries one — a
+// basic-mode curator is never left unable to see or clear a brief a teammate linked.
+//
+// Both flags are LATCHED at the moment the form opens rather than tracking the live draft.
+// Recomputing per keystroke makes the control delete itself the instant a basic-mode curator
+// empties it — mid-edit, under the cursor, on the one interaction (clearing, to hand the
+// standard back to auto-generation) the rule exists to keep reachable.
+const uiMode = useUiModeStore()
+const showEditBrief = ref(false)
+const showDraftBrief = computed(() => showOverrideField(uiMode.isAdvanced, null))
+
 function startEdit(f: (typeof library.fragments)[number]) {
   editDraft.value = {
     id: f.id,
@@ -192,19 +205,6 @@ const editValid = computed(
     !!editDraft.value.summary.trim() &&
     !!editDraft.value.body.trim(),
 )
-// The linked SHORT VERSION is an OVERRIDE of what the platform does by default (condense a
-// long standard automatically, fold a short one in full), so it follows the override rule:
-// hidden in basic mode while unset, revealed as soon as the fragment carries one — a
-// basic-mode curator is never left unable to see or clear a brief a teammate linked.
-//
-// Both flags are LATCHED at the moment the form opens rather than tracking the live draft.
-// Recomputing per keystroke makes the control delete itself the instant a basic-mode curator
-// empties it — mid-edit, under the cursor, on the one interaction (clearing, to hand the
-// standard back to auto-generation) the rule exists to keep reachable.
-const uiMode = useUiModeStore()
-const showEditBrief = ref(false)
-const showDraftBrief = computed(() => showOverrideField(uiMode.isAdvanced, null))
-
 async function saveEdit() {
   const d = editDraft.value
   if (!d || !editValid.value) return
@@ -277,11 +277,6 @@ async function removeFragment(id: string) {
 // Link a Confluence/Notion page or GitHub file as a fragment that is re-resolved
 // from the source at run time (a living source of truth, not a frozen snapshot).
 const docDraft = ref({ source: '' as DocumentSourceKind | '', ref: '', tags: '' })
-const docDraftValid = computed(() => {
-  if (docLinkDisabled.value || !docDraft.value.source) return false
-  // The GitHub picker validates on staged files; every other path on the free-text ref.
-  return usingDocPicker.value ? docFilePaths.value.length > 0 : !!docDraft.value.ref.trim()
-})
 
 // ---- GitHub file picker (documents tab) -----------------------------------
 // For a GitHub source, let the user search a repo + browse to one or MORE files
@@ -364,6 +359,12 @@ const stagedDocRefs = computed(() =>
 /** When the rich picker drives the ref(s); otherwise the free-text field does. */
 const usingDocPicker = computed(() => showGithubDocPicker.value)
 
+const docDraftValid = computed(() => {
+  if (docLinkDisabled.value || !docDraft.value.source) return false
+  // The GitHub picker validates on staged files; every other path on the free-text ref.
+  return usingDocPicker.value ? docFilePaths.value.length > 0 : !!docDraft.value.ref.trim()
+})
+
 /**
  * A pasted GitHub file/directory URL resolved to a repo + location: select the repo
  * (through the same refs the search select drives), then stage the file or jump the

package/app/components/gates/GateResultView.vue

@@ -25,9 +25,6 @@ const access = useWorkspaceAccess()
 const { open, blockId, instanceId, stepIndex, close } = useResultView('gate')
 const block = computed(() => (blockId.value ? board.getBlock(blockId.value) : undefined))
 const prUrl = computed(() => block.value?.pullRequest?.url ?? null)
-const headerTitle = computed(
-  () => `${meta.value.label}${block.value ? ` — ${block.value.title}` : ''}`,
-)
 
 const instance = computed(() =>
   instanceId.value === null ? null : (execution.getInstance(instanceId.value) ?? null),
@@ -42,6 +39,9 @@ const isCi = computed(() => step.value?.agentKind === 'ci')
 const isHumanReview = computed(() => step.value?.agentKind === 'human-review')
 const isDocQuality = computed(() => step.value?.agentKind === 'doc-quality')
 const meta = computed(() => agentKindMeta(step.value?.agentKind ?? 'ci'))
+const headerTitle = computed(
+  () => `${meta.value.label}${block.value ? ` — ${block.value.title}` : ''}`,
+)
 const helperKind = computed(() =>
   isHumanReview.value
     ? 'fixer'

package/app/components/github/AddServiceFromRepoModal.vue

@@ -189,6 +189,16 @@ function removeSelected(path: string) {
   if (i >= 0) selectedDirectories.value.splice(i, 1)
 }
 
+// The just-added whole-repo service, kept on the board store so the user can configure it
+// (test infra + fragments) right here — the same controls as the inspector. Only the
+// whole-repo flow surfaces this inline configure step; a monorepo adds several services at
+// once and they're configured later in the inspector. Declared above the watcher and
+// `resetSelection` below, both of which clear it.
+const configuredBlockId = ref<string | undefined>(undefined)
+const configuredBlock = computed(() =>
+  configuredBlockId.value ? board.getBlock(configuredBlockId.value) : undefined,
+)
+
 // On repo change, capture the picked repo (from the volatile loaded list, before a later
 // search replaces it), seed the monorepo toggle from its persisted flag, and clear the rest.
 watch(selectedRepoId, (id) => {
@@ -227,15 +237,6 @@ function openManageInstall() {
   if (manageInstallUrl.value) window.open(manageInstallUrl.value, '_blank', 'noopener')
 }
 
-// The just-added whole-repo service, kept on the board store so the user can configure it
-// (test infra + fragments) right here — the same controls as the inspector. Only the
-// whole-repo flow surfaces this inline configure step; a monorepo adds several services at
-// once and they're configured later in the inspector.
-const configuredBlockId = ref<string | undefined>(undefined)
-const configuredBlock = computed(() =>
-  configuredBlockId.value ? board.getBlock(configuredBlockId.value) : undefined,
-)
-
 // On open: ensure we know the connection + which repos the App can access, and
 // the workspace's already-tracked repos (to flag ones already on the board).
 // Declared after every ref resetSelection() touches so the `immediate` run