@cat-factory/app 0.150.0 → 0.151.0

package/app/components/board/AddTaskModal.vue

@@ -28,6 +28,7 @@ import ContextDocumentPicker from '~/components/documents/ContextDocumentPicker.
 import ContextIssuePicker from '~/components/tasks/ContextIssuePicker.vue'
 import FragmentSelector from '~/components/fragments/FragmentSelector.vue'
 import { riskPolicyOptionLabel, riskPolicySummary } from '~/utils/riskPolicy'
+import { parseConflict } from '~/composables/usePipelineErrorToast'
 import { pipelineAllowedForManualStart } from '~/utils/pipeline'
 
 const ui = useUiStore()
@@ -678,8 +679,7 @@ const canAdd = computed(() => {
 })
 
 async function add() {
-  const containerId = ui.addTaskContainerId
-  if (!containerId || !canAdd.value) return
+  if (!canAdd.value) return
   // Recurring tasks are created via a schedule on the service frame — hand off to the
   // existing recurring-pipeline modal (which carries the cadence + prompt).
   if (isRecurring.value) {
@@ -689,6 +689,17 @@ async function add() {
     ui.openAddRecurring(frameId)
     return
   }
+  await submitCreate(false)
+}
+
+/**
+ * Create the task, optionally acknowledging review-debt friction. A `review_debt_*` 409 opens the
+ * friction dialog instead of a bare error toast: the soft `warn` tier's dialog can retry via
+ * `submitCreate(true)` (the `onConfirm`), while a hard `blocked` tier only offers "Go review".
+ */
+async function submitCreate(acknowledgeReviewDebt: boolean) {
+  const containerId = ui.addTaskContainerId
+  if (!containerId) return
   saving.value = true
   try {
     const typeFields = buildTypeFields()
@@ -718,6 +729,7 @@ async function add() {
       // re-seeded from the service. The task owns its fragments from here.
       fragmentIds: [...fragmentIds.value],
       ...(technical.value ? { technical: true } : {}),
+      ...(acknowledgeReviewDebt ? { acknowledgeReviewDebt: true } : {}),
     })
     if (block) {
       // Surface the SPECIFIC cause of any attachment that couldn't be linked (a GitHub
@@ -725,8 +737,14 @@ async function add() {
       // one-click "Copy details" for a bug report.
       presentLinkFailures(await linkPending(block.id, pendingContext.value), block.id)
     }
+    ui.closeReviewFriction()
     ui.closeAddTask()
   } catch (e) {
+    const conflict = parseConflict(e)
+    if (conflict?.reason === 'review_debt_warn' || conflict?.reason === 'review_debt_blocked') {
+      openReviewFrictionDialog(conflict)
+      return
+    }
     toast.add({
       title: t('board.addTask.addFailedTitle'),
       description: e instanceof Error ? e.message : String(e),
@@ -737,6 +755,29 @@ async function add() {
     saving.value = false
   }
 }
+
+/** Turn a parsed review-debt friction 409 into the dialog context (see ReviewFrictionDialog.vue). */
+function openReviewFrictionDialog(conflict: NonNullable<ReturnType<typeof parseConflict>>) {
+  const details = conflict.details
+  const rawDebt = Array.isArray(details.debt) ? details.debt : []
+  const debt = rawDebt.map((d) => {
+    const row = (d ?? {}) as { blockId?: unknown; title?: unknown; waitingMinutes?: unknown }
+    return {
+      blockId: typeof row.blockId === 'string' ? row.blockId : '',
+      title: typeof row.title === 'string' ? row.title : null,
+      waitingMinutes: typeof row.waitingMinutes === 'number' ? row.waitingMinutes : 0,
+    }
+  })
+  const isWarn = conflict.reason === 'review_debt_warn'
+  ui.openReviewFriction({
+    kind: isWarn ? 'warn' : 'blocked',
+    reason:
+      details.friction === 'count' || details.friction === 'stuck' ? details.friction : undefined,
+    threshold: typeof details.threshold === 'number' ? details.threshold : null,
+    debt,
+    onConfirm: isWarn ? () => void submitCreate(true) : null,
+  })
+}
 </script>
 
 <template>

package/app/components/board/ReviewDebtBadge.vue

@@ -0,0 +1,26 @@
+<script setup lang="ts">
+// A small pre-warn badge shown next to an "Add task" affordance when the workspace's opt-in
+// review-debt friction is at (or past) its threshold, so the friction dialog isn't a surprise.
+// Hidden entirely when friction is off or the queue is under the warn threshold. The server
+// remains the authority — this is a hint. See backend/docs/review-debt-friction.md.
+import { computed } from 'vue'
+import { useReviewDebt } from '~/composables/useReviewDebt'
+
+const { active, debtCount, blocked } = useReviewDebt()
+const { t } = useI18n()
+
+const color = computed(() => (blocked.value ? 'error' : 'warning'))
+</script>
+
+<template>
+  <UBadge
+    v-if="active"
+    :color="color"
+    variant="subtle"
+    size="sm"
+    icon="i-lucide-clock"
+    :title="t('errors.reviewFriction.badge', { count: debtCount })"
+  >
+    {{ debtCount }}
+  </UBadge>
+</template>

package/app/components/board/ReviewFrictionDialog.vue

@@ -0,0 +1,118 @@
+<script setup lang="ts">
+// Opt-in review-debt friction dialog. Shown when a task-create request is refused by the friction
+// gate (a `review_debt_warn` / `review_debt_blocked` 409). It lists exactly which tasks are waiting
+// on human review (worst first), each deep-linking to its block so "go review instead" is one
+// click. The soft `warn` tier offers a secondary "Create anyway" (retries with the acknowledge
+// flag); the hard `blocked` tier does not. Driven by `ui.reviewFrictionContext`, mounted in
+// pages/index.vue. See backend/docs/review-debt-friction.md.
+import { computed } from 'vue'
+
+const { t } = useI18n()
+const ui = useUiStore()
+
+const ctx = computed(() => ui.reviewFrictionContext)
+
+const open = computed({
+  get: () => ctx.value !== null,
+  set: (v: boolean) => {
+    if (!v) ui.closeReviewFriction()
+  },
+})
+
+const title = computed(() =>
+  ctx.value?.kind === 'blocked'
+    ? t('errors.reviewFriction.blockedTitle')
+    : t('errors.reviewFriction.warnTitle'),
+)
+
+const body = computed(() => {
+  const c = ctx.value
+  if (!c) return ''
+  if (c.kind === 'warn') return t('errors.reviewFriction.warnBody', { count: c.debt.length })
+  if (c.reason === 'stuck')
+    return t('errors.reviewFriction.blockedStuckBody', { minutes: c.threshold ?? 0 })
+  return t('errors.reviewFriction.blockedCountBody', {
+    count: c.debt.length,
+    threshold: c.threshold ?? 0,
+  })
+})
+
+/** Deep-link to a waiting task's block and dismiss the whole friction flow. */
+function goToBlock(blockId: string) {
+  if (blockId) ui.select(blockId)
+  ui.closeReviewFriction()
+  ui.closeAddTask()
+}
+
+function goReview() {
+  const first = ctx.value?.debt[0]
+  if (first) goToBlock(first.blockId)
+  else {
+    ui.closeReviewFriction()
+    ui.closeAddTask()
+  }
+}
+
+function createAnyway() {
+  ctx.value?.onConfirm?.()
+}
+</script>
+
+<template>
+  <UModal v-model:open="open" :title="title" :ui="{ content: 'max-w-xl' }">
+    <template #body>
+      <div v-if="ctx" class="space-y-5">
+        <p class="text-sm text-slate-300">{{ body }}</p>
+
+        <div class="rounded-lg border border-slate-700 bg-slate-900/50 p-2">
+          <p class="mb-1.5 px-1 text-[11px] font-semibold uppercase tracking-wide text-slate-500">
+            {{ t('errors.reviewFriction.waitingHeading') }}
+          </p>
+          <ul class="space-y-1">
+            <li v-for="item in ctx.debt" :key="item.blockId">
+              <button
+                type="button"
+                class="flex w-full items-center justify-between gap-3 rounded-md px-2 py-1.5 text-left text-sm hover:bg-slate-800/60"
+                @click="goToBlock(item.blockId)"
+              >
+                <span class="truncate text-slate-200">
+                  {{ item.title || t('errors.reviewFriction.untitled') }}
+                </span>
+                <span class="shrink-0 text-[12px] text-slate-500">
+                  {{ t('errors.reviewFriction.waiting', { minutes: item.waitingMinutes }) }}
+                </span>
+              </button>
+            </li>
+          </ul>
+        </div>
+
+        <div class="flex flex-wrap justify-end gap-2">
+          <UButton
+            color="neutral"
+            variant="ghost"
+            size="sm"
+            @click="
+              () => {
+                open = false
+              }
+            "
+          >
+            {{ t('errors.reviewFriction.close') }}
+          </UButton>
+          <UButton
+            v-if="ctx.onConfirm"
+            color="neutral"
+            variant="subtle"
+            size="sm"
+            @click="createAnyway"
+          >
+            {{ t('errors.reviewFriction.createAnyway') }}
+          </UButton>
+          <UButton color="primary" size="sm" icon="i-lucide-list-checks" @click="goReview">
+            {{ t('errors.reviewFriction.goReview') }}
+          </UButton>
+        </div>
+      </div>
+    </template>
+  </UModal>
+</template>

package/app/components/panels/inspector/ContainerSummary.vue

@@ -2,6 +2,7 @@
 import type { Block } from '~/types/domain'
 import { STATUS_META } from '~/utils/catalog'
 import InspectorSection from '~/components/panels/inspector/InspectorSection.vue'
+import ReviewDebtBadge from '~/components/board/ReviewDebtBadge.vue'
 
 const props = defineProps<{ block: Block }>()
 
@@ -61,9 +62,12 @@ function addTask() {
               : t('inspector.container.tasks', { count: tasks.length })
           }}
         </span>
-        <UButton size="xs" variant="soft" color="primary" icon="i-lucide-plus" @click="addTask">
-          {{ t('inspector.container.addTask') }}
-        </UButton>
+        <div class="flex items-center gap-1.5">
+          <ReviewDebtBadge />
+          <UButton size="xs" variant="soft" color="primary" icon="i-lucide-plus" @click="addTask">
+            {{ t('inspector.container.addTask') }}
+          </UButton>
+        </div>
       </div>
       <ul v-if="tasks.length" class="space-y-1">
         <li

package/app/components/settings/KubernetesEnvironmentForm.vue

@@ -77,6 +77,44 @@ const schemeItems = computed(() => [
   { label: 'http', value: 'http' },
 ])
 
+// A stored non-secret value is `unknown`; coerce it to the string the form field holds,
+// defaulting a missing/wrong-typed value to '' (the same `typeof … === 'string' ? … : ''`
+// each field used inline before).
+function readString(v: unknown): string {
+  return typeof v === 'string' ? v : ''
+}
+
+// Prefill the manifest-source fields from the stored discriminated config.
+function applyManifestSource(k: Record<string, unknown>): void {
+  const src = k.manifestSource as Record<string, unknown> | undefined
+  if (src?.type === 'separate') {
+    form.manifestSourceType = 'separate'
+    form.manifestRepo = readString(src.repo)
+    form.manifestRef = readString(src.ref)
+    form.manifestPath = readString(src.path)
+  } else if (src?.type === 'colocated') {
+    form.manifestSourceType = 'colocated'
+    form.manifestPath = readString(src.path)
+  }
+}
+
+// Prefill the URL-derivation fields (+ scheme) from the stored discriminated config.
+function applyUrl(k: Record<string, unknown>): void {
+  const url = k.url as Record<string, unknown> | undefined
+  if (url?.source === 'ingressTemplate') {
+    form.urlSource = 'ingressTemplate'
+    form.hostTemplate = readString(url.hostTemplate)
+  } else if (url?.source === 'ingressStatus') {
+    form.urlSource = 'ingressStatus'
+    form.ingressName = readString(url.ingressName)
+  } else if (url?.source === 'serviceStatus') {
+    form.urlSource = 'serviceStatus'
+    form.serviceName = readString(url.serviceName)
+    form.servicePort = typeof url.port === 'number' ? String(url.port) : ''
+  }
+  form.urlScheme = url && (url.scheme === 'http' || url.scheme === 'https') ? url.scheme : 'default'
+}
+
 // A registered k8s env connection exposes its non-secret config, so prefill every
 // non-secret field from it (never the token — secrets are write-only and re-entered on
 // update). This lets an edit change one field without re-typing the whole form.
@@ -89,36 +127,14 @@ watch(
         ? (c.config as { kubernetes: Record<string, unknown> }).kubernetes
         : undefined
     if (!k) return
-    form.label = typeof k.label === 'string' ? k.label : ''
-    form.apiServerUrl = typeof k.apiServerUrl === 'string' ? k.apiServerUrl : ''
-    form.caCertPem = typeof k.caCertPem === 'string' ? k.caCertPem : ''
+    form.label = readString(k.label)
+    form.apiServerUrl = readString(k.apiServerUrl)
+    form.caCertPem = readString(k.caCertPem)
     form.insecureSkipTlsVerify = k.insecureSkipTlsVerify === true
-    form.namespaceTemplate = typeof k.namespaceTemplate === 'string' ? k.namespaceTemplate : ''
-    form.imageTemplate = typeof k.imageTemplate === 'string' ? k.imageTemplate : ''
-    const src = k.manifestSource as Record<string, unknown> | undefined
-    if (src?.type === 'separate') {
-      form.manifestSourceType = 'separate'
-      form.manifestRepo = typeof src.repo === 'string' ? src.repo : ''
-      form.manifestRef = typeof src.ref === 'string' ? src.ref : ''
-      form.manifestPath = typeof src.path === 'string' ? src.path : ''
-    } else if (src?.type === 'colocated') {
-      form.manifestSourceType = 'colocated'
-      form.manifestPath = typeof src.path === 'string' ? src.path : ''
-    }
-    const url = k.url as Record<string, unknown> | undefined
-    if (url?.source === 'ingressTemplate') {
-      form.urlSource = 'ingressTemplate'
-      form.hostTemplate = typeof url.hostTemplate === 'string' ? url.hostTemplate : ''
-    } else if (url?.source === 'ingressStatus') {
-      form.urlSource = 'ingressStatus'
-      form.ingressName = typeof url.ingressName === 'string' ? url.ingressName : ''
-    } else if (url?.source === 'serviceStatus') {
-      form.urlSource = 'serviceStatus'
-      form.serviceName = typeof url.serviceName === 'string' ? url.serviceName : ''
-      form.servicePort = typeof url.port === 'number' ? String(url.port) : ''
-    }
-    form.urlScheme =
-      url && (url.scheme === 'http' || url.scheme === 'https') ? url.scheme : 'default'
+    form.namespaceTemplate = readString(k.namespaceTemplate)
+    form.imageTemplate = readString(k.imageTemplate)
+    applyManifestSource(k)
+    applyUrl(k)
   },
   { immediate: true },
 )

package/app/components/settings/WorkspaceSettingsPanel.vue

@@ -8,7 +8,7 @@
 // The latter three are body-only section components rendered in tabs here (no longer
 // standalone modals).
 import { reactive, ref, watch } from 'vue'
-import type { TaskLimitMode } from '~/types/domain'
+import type { ReviewFrictionMode, TaskLimitMode } from '~/types/domain'
 import RiskPolicyPanel from '~/components/settings/RiskPolicyPanel.vue'
 import IssueTrackerPanel from '~/components/settings/IssueTrackerPanel.vue'
 import ServiceFragmentDefaultsPanel from '~/components/settings/ServiceFragmentDefaultsPanel.vue'
@@ -129,6 +129,12 @@ const MODES = computed<{ value: TaskLimitMode; label: string }[]>(() => [
   { value: 'per_type', label: t('settings.workspaceSettings.taskLimit.modes.per_type') },
 ])
 
+const REVIEW_FRICTION_MODES = computed<{ value: ReviewFrictionMode; label: string }[]>(() => [
+  { value: 'off', label: t('settings.workspaceSettings.reviewFriction.modes.off') },
+  { value: 'warn', label: t('settings.workspaceSettings.reviewFriction.modes.warn') },
+  { value: 'enforce', label: t('settings.workspaceSettings.reviewFriction.modes.enforce') },
+])
+
 /** The localized "Max {type} tasks" label for a per-type running-task limit input. */
 function maxTaskTypeLabel(type: LimitTaskType): string {
   const key = TASK_TYPE_KEYS[type]
@@ -145,6 +151,12 @@ const draft = reactive({
   storeAgentContext: true,
   artifactRetentionDays: 14,
   kaizenEnabled: true,
+  reviewFrictionMode: 'off' as ReviewFrictionMode,
+  reviewFrictionWarnCount: 3,
+  reviewFrictionBlockCountEnabled: false,
+  reviewFrictionBlockCount: 10 as number,
+  reviewFrictionBlockStuckEnabled: false,
+  reviewFrictionBlockStuckMinutes: 1440 as number,
 })
 
 function hydrate() {
@@ -157,6 +169,14 @@ function hydrate() {
   draft.storeAgentContext = s.storeAgentContext
   draft.artifactRetentionDays = s.artifactRetentionDays
   draft.kaizenEnabled = s.kaizenEnabled
+  draft.reviewFrictionMode = s.reviewFrictionMode
+  draft.reviewFrictionWarnCount = s.reviewFrictionWarnCount
+  // The hard-block knobs are nullable (null ⇒ that trigger is off); a per-trigger checkbox is
+  // enabled from whether a value is stored, defaulting the input to a sensible starting number.
+  draft.reviewFrictionBlockCountEnabled = s.reviewFrictionBlockCount != null
+  draft.reviewFrictionBlockCount = s.reviewFrictionBlockCount ?? 10
+  draft.reviewFrictionBlockStuckEnabled = s.reviewFrictionBlockStuckMinutes != null
+  draft.reviewFrictionBlockStuckMinutes = s.reviewFrictionBlockStuckMinutes ?? 1440
 }
 
 // `store.settings` is always replaced wholesale (store hydrate/update reassign the ref),
@@ -166,6 +186,25 @@ watch(() => store.settings, hydrate, { immediate: true })
 const saving = ref(false)
 
 async function save() {
+  // The hard-block triggers only apply in `enforce` mode; a disabled trigger sends null.
+  const blockCount =
+    draft.reviewFrictionMode === 'enforce' && draft.reviewFrictionBlockCountEnabled
+      ? draft.reviewFrictionBlockCount
+      : null
+  const blockStuckMinutes =
+    draft.reviewFrictionMode === 'enforce' && draft.reviewFrictionBlockStuckEnabled
+      ? draft.reviewFrictionBlockStuckMinutes
+      : null
+  // Mirror the backend's enforce-mode validation client-side so the user gets an immediate,
+  // localized message instead of the raw 422 (enforce needs at least one hard trigger).
+  if (draft.reviewFrictionMode === 'enforce' && blockCount == null && blockStuckMinutes == null) {
+    toast.add({
+      title: t('settings.workspaceSettings.reviewFriction.needsTrigger'),
+      icon: 'i-lucide-triangle-alert',
+      color: 'warning',
+    })
+    return
+  }
   saving.value = true
   try {
     await store.update({
@@ -185,6 +224,10 @@ async function save() {
       storeAgentContext: draft.storeAgentContext,
       artifactRetentionDays: draft.artifactRetentionDays,
       kaizenEnabled: draft.kaizenEnabled,
+      reviewFrictionMode: draft.reviewFrictionMode,
+      reviewFrictionWarnCount: draft.reviewFrictionWarnCount,
+      reviewFrictionBlockCount: blockCount,
+      reviewFrictionBlockStuckMinutes: blockStuckMinutes,
     })
     toast.add({
       title: t('settings.workspaceSettings.toast.saved'),
@@ -288,6 +331,80 @@ async function save() {
               </div>
             </section>
 
+            <!-- Review-debt friction on task creation -->
+            <section class="space-y-2">
+              <h3 class="text-sm font-semibold text-slate-200">
+                {{ t('settings.workspaceSettings.reviewFriction.heading') }}
+              </h3>
+              <p class="text-[11px] text-slate-400">
+                {{ t('settings.workspaceSettings.reviewFriction.body') }}
+              </p>
+              <label class="block w-64">
+                <span class="mb-1 block text-[10px] uppercase tracking-wide text-slate-500">{{
+                  t('settings.workspaceSettings.reviewFriction.mode')
+                }}</span>
+                <USelect
+                  v-model="draft.reviewFrictionMode"
+                  :items="REVIEW_FRICTION_MODES"
+                  value-key="value"
+                  size="sm"
+                  class="w-full"
+                />
+              </label>
+
+              <label v-if="draft.reviewFrictionMode !== 'off'" class="block w-48">
+                <span class="mb-1 block text-[10px] uppercase tracking-wide text-slate-500">
+                  {{ t('settings.workspaceSettings.reviewFriction.warnCount') }}
+                </span>
+                <UInput
+                  v-model.number="draft.reviewFrictionWarnCount"
+                  type="number"
+                  :min="1"
+                  size="sm"
+                />
+              </label>
+
+              <div v-if="draft.reviewFrictionMode === 'enforce'" class="space-y-2">
+                <p class="text-[11px] text-slate-400">
+                  {{ t('settings.workspaceSettings.reviewFriction.enforceHint') }}
+                </p>
+                <label class="flex items-center gap-2">
+                  <USwitch v-model="draft.reviewFrictionBlockCountEnabled" size="sm" />
+                  <span class="text-[13px] text-slate-300">{{
+                    t('settings.workspaceSettings.reviewFriction.blockCountToggle')
+                  }}</span>
+                </label>
+                <label v-if="draft.reviewFrictionBlockCountEnabled" class="block w-48">
+                  <span class="mb-1 block text-[10px] uppercase tracking-wide text-slate-500">
+                    {{ t('settings.workspaceSettings.reviewFriction.blockCount') }}
+                  </span>
+                  <UInput
+                    v-model.number="draft.reviewFrictionBlockCount"
+                    type="number"
+                    :min="1"
+                    size="sm"
+                  />
+                </label>
+                <label class="flex items-center gap-2">
+                  <USwitch v-model="draft.reviewFrictionBlockStuckEnabled" size="sm" />
+                  <span class="text-[13px] text-slate-300">{{
+                    t('settings.workspaceSettings.reviewFriction.blockStuckToggle')
+                  }}</span>
+                </label>
+                <label v-if="draft.reviewFrictionBlockStuckEnabled" class="block w-48">
+                  <span class="mb-1 block text-[10px] uppercase tracking-wide text-slate-500">
+                    {{ t('settings.workspaceSettings.reviewFriction.blockStuckMinutes') }}
+                  </span>
+                  <UInput
+                    v-model.number="draft.reviewFrictionBlockStuckMinutes"
+                    type="number"
+                    :min="1"
+                    size="sm"
+                  />
+                </label>
+              </div>
+            </section>
+
             <!-- Agent observability -->
             <section class="space-y-2">
               <h3 class="text-sm font-semibold text-slate-200">

package/app/composables/api/board.ts

@@ -54,6 +54,7 @@ export function boardApi({ send, ws }: ApiContext) {
         pipelineId?: string
         agentConfig?: Record<string, string>
         technical?: boolean
+        acknowledgeReviewDebt?: boolean
       },
     ) => send(addTaskContract, { pathPrefix: ws(workspaceId), pathParams: { blockId }, body }),