@cat-factory/app 0.150.0 → 0.150.1

package/app/components/settings/KubernetesEnvironmentForm.vue

@@ -77,6 +77,44 @@ const schemeItems = computed(() => [
   { label: 'http', value: 'http' },
 ])
 
+// A stored non-secret value is `unknown`; coerce it to the string the form field holds,
+// defaulting a missing/wrong-typed value to '' (the same `typeof … === 'string' ? … : ''`
+// each field used inline before).
+function readString(v: unknown): string {
+  return typeof v === 'string' ? v : ''
+}
+
+// Prefill the manifest-source fields from the stored discriminated config.
+function applyManifestSource(k: Record<string, unknown>): void {
+  const src = k.manifestSource as Record<string, unknown> | undefined
+  if (src?.type === 'separate') {
+    form.manifestSourceType = 'separate'
+    form.manifestRepo = readString(src.repo)
+    form.manifestRef = readString(src.ref)
+    form.manifestPath = readString(src.path)
+  } else if (src?.type === 'colocated') {
+    form.manifestSourceType = 'colocated'
+    form.manifestPath = readString(src.path)
+  }
+}
+
+// Prefill the URL-derivation fields (+ scheme) from the stored discriminated config.
+function applyUrl(k: Record<string, unknown>): void {
+  const url = k.url as Record<string, unknown> | undefined
+  if (url?.source === 'ingressTemplate') {
+    form.urlSource = 'ingressTemplate'
+    form.hostTemplate = readString(url.hostTemplate)
+  } else if (url?.source === 'ingressStatus') {
+    form.urlSource = 'ingressStatus'
+    form.ingressName = readString(url.ingressName)
+  } else if (url?.source === 'serviceStatus') {
+    form.urlSource = 'serviceStatus'
+    form.serviceName = readString(url.serviceName)
+    form.servicePort = typeof url.port === 'number' ? String(url.port) : ''
+  }
+  form.urlScheme = url && (url.scheme === 'http' || url.scheme === 'https') ? url.scheme : 'default'
+}
+
 // A registered k8s env connection exposes its non-secret config, so prefill every
 // non-secret field from it (never the token — secrets are write-only and re-entered on
 // update). This lets an edit change one field without re-typing the whole form.
@@ -89,36 +127,14 @@ watch(
         ? (c.config as { kubernetes: Record<string, unknown> }).kubernetes
         : undefined
     if (!k) return
-    form.label = typeof k.label === 'string' ? k.label : ''
-    form.apiServerUrl = typeof k.apiServerUrl === 'string' ? k.apiServerUrl : ''
-    form.caCertPem = typeof k.caCertPem === 'string' ? k.caCertPem : ''
+    form.label = readString(k.label)
+    form.apiServerUrl = readString(k.apiServerUrl)
+    form.caCertPem = readString(k.caCertPem)
     form.insecureSkipTlsVerify = k.insecureSkipTlsVerify === true
-    form.namespaceTemplate = typeof k.namespaceTemplate === 'string' ? k.namespaceTemplate : ''
-    form.imageTemplate = typeof k.imageTemplate === 'string' ? k.imageTemplate : ''
-    const src = k.manifestSource as Record<string, unknown> | undefined
-    if (src?.type === 'separate') {
-      form.manifestSourceType = 'separate'
-      form.manifestRepo = typeof src.repo === 'string' ? src.repo : ''
-      form.manifestRef = typeof src.ref === 'string' ? src.ref : ''
-      form.manifestPath = typeof src.path === 'string' ? src.path : ''
-    } else if (src?.type === 'colocated') {
-      form.manifestSourceType = 'colocated'
-      form.manifestPath = typeof src.path === 'string' ? src.path : ''
-    }
-    const url = k.url as Record<string, unknown> | undefined
-    if (url?.source === 'ingressTemplate') {
-      form.urlSource = 'ingressTemplate'
-      form.hostTemplate = typeof url.hostTemplate === 'string' ? url.hostTemplate : ''
-    } else if (url?.source === 'ingressStatus') {
-      form.urlSource = 'ingressStatus'
-      form.ingressName = typeof url.ingressName === 'string' ? url.ingressName : ''
-    } else if (url?.source === 'serviceStatus') {
-      form.urlSource = 'serviceStatus'
-      form.serviceName = typeof url.serviceName === 'string' ? url.serviceName : ''
-      form.servicePort = typeof url.port === 'number' ? String(url.port) : ''
-    }
-    form.urlScheme =
-      url && (url.scheme === 'http' || url.scheme === 'https') ? url.scheme : 'default'
+    form.namespaceTemplate = readString(k.namespaceTemplate)
+    form.imageTemplate = readString(k.imageTemplate)
+    applyManifestSource(k)
+    applyUrl(k)
   },
   { immediate: true },
 )

package/app/composables/usePipelineErrorToast.ts

@@ -186,200 +186,231 @@ export function parseConflict(
   }
 }
 
+/** The non-null parsed shape of a backend conflict, as returned by {@link parseConflict}. */
+type ParsedConflict = NonNullable<ReturnType<typeof parseConflict>>
+
 export function usePipelineErrorToast() {
   const toast = useToast()
   const ui = useUiStore()
   const { t, te } = useI18n()
 
-  /**
-   * Present `error` as a toast. `fallbackTitleKey` is an i18n message key used for
-   * non-conflict failures and any conflict reason without a dedicated title.
-   */
-  function present(error: unknown, fallbackTitleKey = 'common.actionFailed'): void {
-    const conflict = parseConflict(error)
+  // The headline case: a pipeline step's model has no usable provider. Name the
+  // offending model(s), explain no provider is available, and offer the one-click jump
+  // to the AI setup — the same remedy the startup "No AI model configured" banner gives.
+  function presentProvidersUnconfigured(conflict: ParsedConflict): void {
+    const models = Array.isArray(conflict.details.models) ? conflict.details.models : []
+    const list = models.join(', ')
+    toast.add({
+      title: t('errors.conflict.providersUnconfigured.title'),
+      description: list
+        ? t('errors.conflict.providersUnconfigured.body', { models: list })
+        : (conflict.message ?? t('errors.conflict.fallbackMessage')),
+      color: 'error',
+      icon: 'i-lucide-cpu',
+      // Stay until dismissed: an actionable toast whose remedy button vanishes on the ~5s
+      // auto-dismiss takes the one-click fix with it before the user can reach it.
+      duration: 0,
+      actions: [
+        {
+          label: t('errors.conflict.providersUnconfigured.action'),
+          icon: 'i-lucide-settings',
+          onClick: () => ui.openAiProviderSetup(),
+        },
+      ],
+    })
+  }
 
-    // The headline case: a pipeline step's model has no usable provider. Name the
-    // offending model(s), explain no provider is available, and offer the one-click jump
-    // to the AI setup — the same remedy the startup "No AI model configured" banner gives.
-    if (conflict?.reason === 'providers_unconfigured') {
-      const models = Array.isArray(conflict.details.models) ? conflict.details.models : []
-      const list = models.join(', ')
-      toast.add({
-        title: t('errors.conflict.providersUnconfigured.title'),
-        description: list
-          ? t('errors.conflict.providersUnconfigured.body', { models: list })
-          : (conflict.message ?? t('errors.conflict.fallbackMessage')),
-        color: 'error',
-        icon: 'i-lucide-cpu',
-        // Stay until dismissed: an actionable toast whose remedy button vanishes on the ~5s
-        // auto-dismiss takes the one-click fix with it before the user can reach it.
-        duration: 0,
-        actions: [
-          {
-            label: t('errors.conflict.providersUnconfigured.action'),
-            icon: 'i-lucide-settings',
-            onClick: () => ui.openAiProviderSetup(),
-          },
-        ],
-      })
-      return
-    }
+  // A pipeline step relies on binary-artifact storage (the UI Tester uploads screenshots)
+  // but the account has none configured. Explain it and offer the jump to the content-storage
+  // settings — the same shape as the providers-unconfigured case above. Prefer the localized
+  // body (it carries no runtime interpolation) so non-English users see translated copy; the
+  // raw backend prose is only the last-resort fallback when the locale lacks the key.
+  function presentBinaryStorageUnconfigured(conflict: ParsedConflict): void {
+    toast.add({
+      title: t('errors.conflict.binaryStorageUnconfigured.title'),
+      description: te('errors.conflict.binaryStorageUnconfigured.body')
+        ? t('errors.conflict.binaryStorageUnconfigured.body')
+        : (conflict.message ?? t('errors.conflict.fallbackMessage')),
+      color: 'error',
+      icon: 'i-lucide-image',
+      // Sticky, like the providers-unconfigured toast above: keep the "Configure storage"
+      // remedy reachable instead of letting it auto-dismiss.
+      duration: 0,
+      actions: [
+        {
+          label: t('errors.conflict.binaryStorageUnconfigured.action'),
+          icon: 'i-lucide-settings',
+          onClick: () => ui.openContentStorageSettings(),
+        },
+      ],
+    })
+  }
 
-    // A pipeline step relies on binary-artifact storage (the UI Tester uploads screenshots)
-    // but the account has none configured. Explain it and offer the jump to the content-storage
-    // settings — the same shape as the providers-unconfigured case above. Prefer the localized
-    // body (it carries no runtime interpolation) so non-English users see translated copy; the
-    // raw backend prose is only the last-resort fallback when the locale lacks the key.
-    if (conflict?.reason === 'binary_storage_unconfigured') {
-      toast.add({
-        title: t('errors.conflict.binaryStorageUnconfigured.title'),
-        description: te('errors.conflict.binaryStorageUnconfigured.body')
-          ? t('errors.conflict.binaryStorageUnconfigured.body')
-          : (conflict.message ?? t('errors.conflict.fallbackMessage')),
-        color: 'error',
-        icon: 'i-lucide-image',
-        // Sticky, like the providers-unconfigured toast above: keep the "Configure storage"
-        // remedy reachable instead of letting it auto-dismiss.
-        duration: 0,
-        actions: [
-          {
-            label: t('errors.conflict.binaryStorageUnconfigured.action'),
-            icon: 'i-lucide-settings',
-            onClick: () => ui.openContentStorageSettings(),
+  // A pipeline includes a Deployer, but the SERVICE's ephemeral-environment config (the in-repo
+  // "what/where") is incomplete for its declared type. Steer the user straight to THAT service's
+  // environment config — the compose wizard for docker-compose, the service inspector otherwise —
+  // falling back to the workspace infrastructure window if the frame id wasn't carried.
+  function presentDeployerServiceConfig(conflict: ParsedConflict): void {
+    const frameId =
+      typeof conflict.details.frameId === 'string' ? conflict.details.frameId : undefined
+    const provisionType =
+      typeof conflict.details.provisionType === 'string'
+        ? conflict.details.provisionType
+        : undefined
+    const missing = Array.isArray(conflict.details.missing)
+      ? conflict.details.missing.join(', ')
+      : ''
+    toast.add({
+      title: t('errors.conflict.deployerServiceConfig.title'),
+      description: missing
+        ? t('errors.conflict.deployerServiceConfig.body', { missing })
+        : (conflict.message ?? t('errors.conflict.fallbackMessage')),
+      color: 'error',
+      icon: 'i-lucide-server',
+      // Sticky, like the other actionable conflicts: keep the "Fix configuration" jump reachable.
+      duration: 0,
+      actions: [
+        {
+          label: t('errors.conflict.deployerServiceConfig.action'),
+          icon: 'i-lucide-settings',
+          onClick: () => {
+            if (frameId && provisionType === 'docker-compose') ui.openEnvironmentSetup(frameId)
+            else if (frameId) ui.select(frameId)
+            else ui.openProviderConnection('environment')
           },
-        ],
-      })
-      return
-    }
+        },
+      ],
+    })
+  }
 
-    // A pipeline includes a Deployer, but the SERVICE's ephemeral-environment config (the in-repo
-    // "what/where") is incomplete for its declared type. Steer the user straight to THAT service's
-    // environment config — the compose wizard for docker-compose, the service inspector otherwise —
-    // falling back to the workspace infrastructure window if the frame id wasn't carried.
-    if (conflict?.reason === 'deployer_service_provisioning_incomplete') {
-      const frameId =
-        typeof conflict.details.frameId === 'string' ? conflict.details.frameId : undefined
-      const provisionType =
-        typeof conflict.details.provisionType === 'string'
-          ? conflict.details.provisionType
-          : undefined
-      const missing = Array.isArray(conflict.details.missing)
-        ? conflict.details.missing.join(', ')
-        : ''
-      toast.add({
-        title: t('errors.conflict.deployerServiceConfig.title'),
-        description: missing
-          ? t('errors.conflict.deployerServiceConfig.body', { missing })
-          : (conflict.message ?? t('errors.conflict.fallbackMessage')),
-        color: 'error',
-        icon: 'i-lucide-server',
-        // Sticky, like the other actionable conflicts: keep the "Fix configuration" jump reachable.
-        duration: 0,
-        actions: [
-          {
-            label: t('errors.conflict.deployerServiceConfig.action'),
-            icon: 'i-lucide-settings',
-            onClick: () => {
-              if (frameId && provisionType === 'docker-compose') ui.openEnvironmentSetup(frameId)
-              else if (frameId) ui.select(frameId)
-              else ui.openProviderConnection('environment')
-            },
-          },
-        ],
-      })
-      return
-    }
+  // A pipeline includes a Deployer and the service config is sound, but no WORKSPACE handler
+  // resolves for the service's provision type (missing or ambiguous). Steer to the Infrastructure
+  // window's Test-environments tab. (Also raised by the Tester start gate — same fix applies.)
+  function presentProvisionTypeUnhandled(conflict: ParsedConflict): void {
+    const type =
+      typeof conflict.details.provisionType === 'string' ? conflict.details.provisionType : ''
+    toast.add({
+      title: t('errors.conflict.provisionTypeUnhandled.title'),
+      description: type
+        ? t('errors.conflict.provisionTypeUnhandled.body', { type })
+        : (conflict.message ?? t('errors.conflict.fallbackMessage')),
+      color: 'error',
+      icon: 'i-lucide-server-cog',
+      duration: 0,
+      actions: [
+        {
+          label: t('errors.conflict.provisionTypeUnhandled.action'),
+          icon: 'i-lucide-settings',
+          onClick: () => ui.openProviderConnection('environment'),
+        },
+      ],
+    })
+  }
 
-    // A pipeline includes a Deployer and the service config is sound, but no WORKSPACE handler
-    // resolves for the service's provision type (missing or ambiguous). Steer to the Infrastructure
-    // window's Test-environments tab. (Also raised by the Tester start gate — same fix applies.)
-    if (conflict?.reason === 'provision_type_unhandled') {
-      const type =
-        typeof conflict.details.provisionType === 'string' ? conflict.details.provisionType : ''
-      toast.add({
-        title: t('errors.conflict.provisionTypeUnhandled.title'),
-        description: type
-          ? t('errors.conflict.provisionTypeUnhandled.body', { type })
-          : (conflict.message ?? t('errors.conflict.fallbackMessage')),
-        color: 'error',
-        icon: 'i-lucide-server-cog',
-        duration: 0,
-        actions: [
-          {
-            label: t('errors.conflict.provisionTypeUnhandled.action'),
-            icon: 'i-lucide-settings',
-            onClick: () => ui.openProviderConnection('environment'),
-          },
-        ],
-      })
-      return
+  // A pipeline includes a Deployer, the config is structurally complete, but the live connection
+  // probe of the resolved deployment integration failed (unreachable endpoint / apiserver, bad
+  // token). Surface the provider's failure detail and steer to the handler to fix + re-test it.
+  function presentDeployerConnectionFailed(conflict: ParsedConflict): void {
+    const detail = typeof conflict.details.detail === 'string' ? conflict.details.detail : undefined
+    toast.add({
+      title: t('errors.conflict.deployerConnectionFailed.title'),
+      description: detail
+        ? t('errors.conflict.deployerConnectionFailed.body', { detail })
+        : (conflict.message ?? t('errors.conflict.fallbackMessage')),
+      color: 'error',
+      icon: 'i-lucide-plug',
+      duration: 0,
+      actions: [
+        {
+          label: t('errors.conflict.deployerConnectionFailed.action'),
+          icon: 'i-lucide-settings',
+          onClick: () => ui.openProviderConnection('environment'),
+        },
+      ],
+    })
+  }
+
+  /**
+   * Dispatch the bespoke conflict reasons (a runtime-interpolated body + a "configure X" action,
+   * each with its own key namespace — the ones excluded from `CONFLICT_INFO`). Returns `true` when
+   * the reason was one of them (and the toast was raised), `false` to fall through to the generic
+   * map. The reason values are mutually exclusive, so dispatch order is irrelevant.
+   */
+  function presentBespokeConflict(conflict: ParsedConflict): boolean {
+    switch (conflict.reason) {
+      case 'providers_unconfigured':
+        presentProvidersUnconfigured(conflict)
+        return true
+      case 'binary_storage_unconfigured':
+        presentBinaryStorageUnconfigured(conflict)
+        return true
+      case 'deployer_service_provisioning_incomplete':
+        presentDeployerServiceConfig(conflict)
+        return true
+      case 'provision_type_unhandled':
+        presentProvisionTypeUnhandled(conflict)
+        return true
+      case 'deployer_connection_test_failed':
+        presentDeployerConnectionFailed(conflict)
+        return true
+      default:
+        return false
     }
+  }
 
-    // A pipeline includes a Deployer, the config is structurally complete, but the live connection
-    // probe of the resolved deployment integration failed (unreachable endpoint / apiserver, bad
-    // token). Surface the provider's failure detail and steer to the handler to fix + re-test it.
-    if (conflict?.reason === 'deployer_connection_test_failed') {
-      const detail =
-        typeof conflict.details.detail === 'string' ? conflict.details.detail : undefined
+  /**
+   * Per-reason copy from the exhaustive map: a translated title + description, and a jump
+   * action for the reasons a UI panel can fix. `te` (translation-exists) guards every lookup,
+   * so a key missing from the active locale falls back rather than leaking a raw key: the
+   * title falls to the caller's key, the description to the raw backend `message`. An unknown
+   * reason (not in the map) gets the same generic title + raw-message fallback.
+   */
+  function presentMappedConflict(conflict: ParsedConflict, fallbackTitleKey: string): void {
+    const info = conflict.reason
+      ? CONFLICT_INFO[conflict.reason as Exclude<ConflictReason, BespokeConflictReason>]
+      : undefined
+    if (info) {
       toast.add({
-        title: t('errors.conflict.deployerConnectionFailed.title'),
-        description: detail
-          ? t('errors.conflict.deployerConnectionFailed.body', { detail })
+        title: te(info.titleKey) ? t(info.titleKey) : t(fallbackTitleKey),
+        description: te(info.descriptionKey)
+          ? t(info.descriptionKey)
           : (conflict.message ?? t('errors.conflict.fallbackMessage')),
-        color: 'error',
-        icon: 'i-lucide-plug',
-        duration: 0,
-        actions: [
-          {
-            label: t('errors.conflict.deployerConnectionFailed.action'),
-            icon: 'i-lucide-settings',
-            onClick: () => ui.openProviderConnection('environment'),
-          },
-        ],
+        color: 'warning',
+        icon: 'i-lucide-triangle-alert',
+        // A reason with a jump action becomes an actionable, sticky toast (like the bespoke
+        // conflicts above) so the one-click remedy doesn't auto-dismiss before it's reached.
+        ...(info.action
+          ? {
+              duration: 0,
+              actions: [
+                {
+                  label: t(info.action.labelKey),
+                  icon: info.action.icon,
+                  onClick: () => info.action?.run(ui),
+                },
+              ],
+            }
+          : {}),
       })
       return
     }
+    toast.add({
+      title: t(fallbackTitleKey),
+      description: conflict.message ?? t('errors.conflict.fallbackMessage'),
+      color: 'warning',
+      icon: 'i-lucide-triangle-alert',
+    })
+  }
 
+  /**
+   * Present `error` as a toast. `fallbackTitleKey` is an i18n message key used for
+   * non-conflict failures and any conflict reason without a dedicated title.
+   */
+  function present(error: unknown, fallbackTitleKey = 'common.actionFailed'): void {
+    const conflict = parseConflict(error)
     if (conflict) {
-      // Per-reason copy from the exhaustive map: a translated title + description, and a jump
-      // action for the reasons a UI panel can fix. `te` (translation-exists) guards every lookup,
-      // so a key missing from the active locale falls back rather than leaking a raw key: the
-      // title falls to the caller's key, the description to the raw backend `message`. An unknown
-      // reason (not in the map) gets the same generic title + raw-message fallback.
-      const info = conflict.reason
-        ? CONFLICT_INFO[conflict.reason as Exclude<ConflictReason, BespokeConflictReason>]
-        : undefined
-      if (info) {
-        toast.add({
-          title: te(info.titleKey) ? t(info.titleKey) : t(fallbackTitleKey),
-          description: te(info.descriptionKey)
-            ? t(info.descriptionKey)
-            : (conflict.message ?? t('errors.conflict.fallbackMessage')),
-          color: 'warning',
-          icon: 'i-lucide-triangle-alert',
-          // A reason with a jump action becomes an actionable, sticky toast (like the bespoke
-          // conflicts above) so the one-click remedy doesn't auto-dismiss before it's reached.
-          ...(info.action
-            ? {
-                duration: 0,
-                actions: [
-                  {
-                    label: t(info.action.labelKey),
-                    icon: info.action.icon,
-                    onClick: () => info.action?.run(ui),
-                  },
-                ],
-              }
-            : {}),
-        })
-        return
-      }
-      toast.add({
-        title: t(fallbackTitleKey),
-        description: conflict.message ?? t('errors.conflict.fallbackMessage'),
-        color: 'warning',
-        icon: 'i-lucide-triangle-alert',
-      })
+      if (presentBespokeConflict(conflict)) return
+      presentMappedConflict(conflict, fallbackTitleKey)
       return
     }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cat-factory/app",
-  "version": "0.150.0",
+  "version": "0.150.1",
   "description": "Reusable Nuxt layer for the Agent Architecture Board SPA (components, stores, composables, pages). Consume it from a thin deployment app via `extends: ['@cat-factory/app']` and point it at your backend with NUXT_PUBLIC_API_BASE. See deploy/frontend for an example.",
   "repository": {
     "type": "git",