@cat-factory/app 0.147.2 → 0.147.4

package/app/components/layout/NotificationsInbox.vue

@@ -77,6 +77,10 @@ const META: Record<Notification['type'], { icon: string; color: Accent }> = {
   // Runs were paused by the spend safeguard. Workspace-scoped (no block to reveal); "act" just
   // marks it read (the human raises the budget then resumes from the spend panel).
   budget_paused: { icon: 'i-lucide-wallet', color: 'warning' },
+  // Stored credentials could not be decrypted (the ENCRYPTION_KEY changed since they were
+  // sealed). Not block-scoped; "act" drops the listed stale ciphertexts so they can be re-entered
+  // (or restore the previous key to recover them instead).
+  key_drift: { icon: 'i-lucide-key-round', color: 'error' },
 }
 
 // Per-type primary-action label. An exhaustive Record keyed off the notification
@@ -100,6 +104,7 @@ const ACTION_KEYS: Record<Notification['type'], string> = {
   initiative: 'layout.notifications.action.initiative',
   platform_health: 'layout.notifications.action.platform_health',
   budget_paused: 'layout.notifications.action.budget_paused',
+  key_drift: 'layout.notifications.action.key_drift',
 }
 
 /** The localized primary-action label for a notification (te()-guarded against a

package/app/components/prReview/PrReviewPhaseBadge.vue

@@ -23,7 +23,7 @@ const phase = computed(() => prReviewPhase(props.step.prReview, props.step.subta
 // working (suppressed on a failed run). `awaiting` is the parked "findings ready" state — a
 // steady amber prompt, not a spinner.
 const PHASE_META: Record<PrReviewPhaseKind, { icon: string; spin: boolean; class: string }> = {
-  slicing: { icon: 'i-lucide-loader-circle', spin: true, class: 'text-indigo-300' },
+  planning: { icon: 'i-lucide-loader-circle', spin: true, class: 'text-indigo-300' },
   reviewing: { icon: 'i-lucide-loader-circle', spin: true, class: 'text-indigo-300' },
   awaiting: { icon: 'i-lucide-clipboard-check', spin: false, class: 'text-amber-300' },
   challenging: { icon: 'i-lucide-gavel', spin: true, class: 'text-indigo-300' },
@@ -35,7 +35,7 @@ const PHASE_META: Record<PrReviewPhaseKind, { icon: string; spin: boolean; class
 // label fails the typecheck (the sanctioned dynamic enum→key guard — tier 1 can't see a
 // runtime-built key), matching the `CHUNK_STATUS_KEY` pattern in PrReviewWindow.vue.
 const PHASE_LABEL_KEY: Record<PrReviewPhaseKind, string> = {
-  slicing: 'prReview.phase.slicing',
+  planning: 'prReview.phase.planning',
   reviewing: 'prReview.phase.reviewing',
   awaiting: 'prReview.phase.awaiting',
   challenging: 'prReview.phase.challenging',

package/app/components/prReview/PrReviewWindow.vue

@@ -21,7 +21,7 @@ import type {
   StepSubtasks,
 } from '~/types/execution'
 import { subtaskIconClass } from '~/utils/pipelineRender'
-import { activeChunkLabels, chunkReviewPercent, isSlicingChunks } from '~/utils/prReviewProgress'
+import { activeChunkLabels, chunkReviewPercent, hasNoSlicePlan } from '~/utils/prReviewProgress'
 import ResultWindowShell from '~/components/panels/ResultWindowShell.vue'
 import StepRunMeta from '~/components/panels/StepRunMeta.vue'
 
@@ -55,15 +55,18 @@ const awaiting = computed(() => status.value === 'awaiting_selection')
 const challenging = computed(() => status.value === 'challenging')
 // The reviewer's live todo list while it works, streamed onto the step. Its entries are the
 // cohesive slices/chunks the agent grouped the diff into (plus a final "aggregate" step). The
-// derivation of the two `reviewing`-phase sub-states from it lives in `~/utils/prReviewProgress`
-// (pure + unit-tested); see that module for the slicing-vs-reviewing signal.
+// derivation of the `reviewing`-phase sub-states from it lives in `~/utils/prReviewProgress`
+// (pure + unit-tested); see that module for the has-a-plan signal.
 const subtasks = computed<StepSubtasks | null>(() => step.value?.subtasks ?? null)
 
 /**
- * Slicing sub-phase: the reviewer is still grouping the diff into chunks (no todo list yet).
- * Once the list exists, slicing is done and we render the per-chunk status list instead.
+ * Planning sub-phase: no per-slice todo plan has been reported yet. This is NEUTRAL — the
+ * reviewer may still be grouping the diff, OR it may be reviewing via parallel subagents that
+ * never write a parent todo plan (ADR 0026 D2.2). Either way we must NOT claim a specific
+ * "slicing" phase; we show a neutral "reviewing…" state and switch to the per-slice list the
+ * moment a plan exists.
  */
-const slicing = computed(() => status.value === 'reviewing' && isSlicingChunks(subtasks.value))
+const planning = computed(() => status.value === 'reviewing' && hasNoSlicePlan(subtasks.value))
 
 /** Chunk-review completion, clamped 0..100 for the progress bar. */
 const chunkPercent = computed(() => chunkReviewPercent(subtasks.value))
@@ -256,28 +259,29 @@ async function onDismiss(id: string): Promise<void> {
 
     <div class="flex min-h-0 flex-1">
       <div class="min-w-0 flex-1 overflow-y-auto px-5 py-4">
-        <!-- Reviewing: the read-only reviewer is still working. The phase is told apart precisely —
-           SLICING (still grouping the diff into chunks, no plan yet) vs REVIEWING (slicing done,
-           working through the chunks) — so the copy never claims "reviewing" while it's slicing. -->
+        <!-- Reviewing: the read-only reviewer is still working. Two sub-states, told apart by
+           whether a per-slice todo plan exists — a NEUTRAL "planning" state (no plan reported yet;
+           may be grouping OR reviewing via subagents that write no parent plan) vs the per-slice
+           list. The copy never asserts a specific "slicing" phase from an empty todo list. -->
         <div
           v-if="status === 'reviewing'"
           data-testid="pr-review-reviewing"
           class="flex h-full flex-col"
         >
-          <!-- SLICING: no todo list yet — the reviewer is still grouping the diff into chunks. -->
+          <!-- PLANNING: no per-slice plan yet — a neutral "reviewing…" state, not a "slicing" claim. -->
           <div
-            v-if="slicing"
-            data-testid="pr-review-slicing"
+            v-if="planning"
+            data-testid="pr-review-planning"
             class="flex h-full flex-col items-center justify-center gap-2 py-10 text-center text-slate-400"
           >
             <UIcon name="i-lucide-loader-circle" class="h-8 w-8 animate-spin opacity-60" />
-            <p class="text-sm text-slate-200">{{ t('prReview.reviewing.slicing.title') }}</p>
+            <p class="text-sm text-slate-200">{{ t('prReview.reviewing.planning.title') }}</p>
             <p class="max-w-sm text-[11px] text-slate-500">
-              {{ t('prReview.reviewing.slicing.hint') }}
+              {{ t('prReview.reviewing.planning.hint') }}
             </p>
           </div>
 
-          <!-- REVIEWING: slicing is done — show every chunk with its status + which are active now. -->
+          <!-- REVIEWING: a per-slice plan exists — show every slice with its status + which are active now. -->
           <div v-else data-testid="pr-review-reviewing-chunks" class="py-2">
             <div class="mb-1 flex items-center gap-2 text-sm text-slate-200">
               <UIcon

package/app/components/slack/SlackPanel.vue

@@ -70,6 +70,8 @@ const routes = reactive<Record<NotificationType, SlackRoute>>({
   initiative: { enabled: false, channel: '' },
   platform_health: { enabled: false, channel: '' },
   budget_paused: { enabled: false, channel: '' },
+  // In-app only (not in ROUTABLE), but the map is exhaustive over the type.
+  key_drift: { enabled: false, channel: '' },
 })
 const mentionsEnabled = ref(false)
 // Editable member rows carry a client-only stable `uid` (see `slackMemberMapping`) so

package/app/stores/personalSubscriptions.spec.ts

@@ -1,17 +1,22 @@
 import { describe, it, expect, beforeEach, vi } from 'vitest'
 import { ApiError } from '~/composables/api/errors'
-import { usePersonalSubscriptionsStore } from '~/stores/personalSubscriptions'
+import {
+  personalPasswordCacheKey,
+  usePersonalSubscriptionsStore,
+} from '~/stores/personalSubscriptions'
 
-// The single localStorage key the store caches the personal password under (private to the
-// store; hard-coded here so the buffer/expiry semantics can be asserted directly).
-const CACHE_KEY = 'cf.personal-pw'
+// The scoped localStorage key the store caches under, for the stubbed apiBase ('') + user
+// (null → 'anon') the default test setup provides (see test/setup.ts). ADR 0026 D7.
+const CACHE_KEY = personalPasswordCacheKey('', null)
+/** The retired pre-scoping global key. */
+const LEGACY_CACHE_KEY = 'cf.personal-pw'
 const HOUR = 60 * 60 * 1000
 /** Mirrors PASSWORD_EXPIRY_BUFFER_MS in the store — the runway a key must have to be ridden. */
 const BUFFER_MS = 8 * HOUR
 
 /** Write a cache entry with an explicit remaining lifetime (positive = valid, negative = past). */
-function seedCache(password: string, msFromNow: number) {
-  localStorage.setItem(CACHE_KEY, JSON.stringify({ password, expiresAt: Date.now() + msFromNow }))
+function seedCache(password: string, msFromNow: number, key = CACHE_KEY) {
+  localStorage.setItem(key, JSON.stringify({ password, expiresAt: Date.now() + msFromNow }))
 }
 
 /** A 428 credential_required error shaped like the server envelope the store parses. */
@@ -61,6 +66,52 @@ describe('personal-password cache expiry buffer', () => {
   })
 })
 
+// ADR 0026 D7: the cache is scoped per installation (apiBase) + user, and the retired global
+// `cf.personal-pw` key is purged on sight and never reused.
+describe('per-installation + per-user cache scoping', () => {
+  beforeEach(() => {
+    localStorage.clear()
+  })
+
+  it('derives distinct keys per installation and per user', () => {
+    // Same origin, different installations (apiBase) → different keys.
+    expect(personalPasswordCacheKey('https://a.example', 'usr_1')).not.toBe(
+      personalPasswordCacheKey('https://b.example', 'usr_1'),
+    )
+    // Same installation, different users → different keys.
+    expect(personalPasswordCacheKey('https://a.example', 'usr_1')).not.toBe(
+      personalPasswordCacheKey('https://a.example', 'usr_2'),
+    )
+    // A missing user id collapses to a stable `anon` segment (auth disabled).
+    expect(personalPasswordCacheKey('https://a.example', null)).toBe(
+      personalPasswordCacheKey('https://a.example', undefined),
+    )
+  })
+
+  it('does NOT read another installation/user cache entry', () => {
+    const store = usePersonalSubscriptionsStore()
+    // A healthy entry belonging to a DIFFERENT scope must be invisible to this store.
+    seedCache('other-secret', 40 * HOUR, personalPasswordCacheKey('https://other', 'usr_x'))
+    expect(store.getCachedPassword()).toBeUndefined()
+  })
+
+  it('purges the retired global `cf.personal-pw` key on read and never reuses it', () => {
+    const store = usePersonalSubscriptionsStore()
+    seedCache('legacy-secret', 40 * HOUR, LEGACY_CACHE_KEY)
+    // The legacy value is not offered (the scoped key is absent)…
+    expect(store.getCachedPassword()).toBeUndefined()
+    // …and the retired global key is removed so it can't be reused across installs/users.
+    expect(localStorage.getItem(LEGACY_CACHE_KEY)).toBeNull()
+  })
+
+  it('round-trips a password under the scoped key', () => {
+    const store = usePersonalSubscriptionsStore()
+    seedCache('mine', 40 * HOUR)
+    expect(store.getCachedPassword()).toBe('mine')
+    expect(localStorage.getItem(CACHE_KEY)).not.toBeNull()
+  })
+})
+
 describe('withCredential early re-entry', () => {
   beforeEach(() => {
     localStorage.clear()

package/app/stores/personalSubscriptions.ts

@@ -12,12 +12,22 @@ import type {
 // a personal PASSWORD. The token itself is double-encrypted server-side and never returned;
 // this store only carries metadata + the renewal warning.
 //
-// To keep the password mostly transparent, it is cached CLIENT-SIDE in localStorage under a
-// SINGLE key with a TTL: the backend gate applies one password to ALL of a run's
-// individual-usage vendors, so there's no point keying the cache per vendor. A task
-// start/retry (and each interaction with a live run) rides along with the cached password —
-// sent as the `X-Personal-Password` header — and the user is only re-prompted once it
-// expires (or is wrong).
+// To keep the password mostly transparent, it is cached CLIENT-SIDE in localStorage with a
+// TTL: the backend gate applies one password to ALL of a run's individual-usage vendors, so
+// there's no point keying the cache per vendor. A task start/retry (and each interaction with a
+// live run) rides along with the cached password — sent as the `X-Personal-Password` header —
+// and the user is only re-prompted once it expires (or is wrong).
+//
+// The cache key is scoped PER INSTALLATION and PER USER (ADR 0026 D7): `cf.personal-pw:<hash of
+// the configured API base>:<user id>`. The bare `cf.personal-pw` it replaced was keyed only by
+// browser origin, so on a shared origin (two local installs on localhost, or one hosted origin
+// fronting several deployments) one installation's cached password was offered to another as
+// `X-Personal-Password`, and a second signed-in user on a shared browser profile inherited the
+// first user's password. Keying on the API base (distinct per installation even when the origin
+// is shared) and the user id closes both: another installation or user sees no cache and is
+// challenged normally. Per-workspace scoping is NOT added — the password is a per-user secret
+// (the backend applies one to all of a run's individual-usage vendors), so it would only add
+// redundant prompts.
 //
 // Every gated action (start / retry / confirm) re-validates the cache against an 8h EXPIRY
 // BUFFER: a key with less than that runway left is withheld (treated as absent) so the
@@ -43,7 +53,37 @@ const PASSWORD_TTL_MS = 40 * 60 * 60 * 1000
  * EARLY — a buffer wide enough that a pipeline kicked off now won't outlive the key (8h).
  */
 const PASSWORD_EXPIRY_BUFFER_MS = 8 * 60 * 60 * 1000
-const CACHE_KEY = 'cf.personal-pw'
+
+/** Prefix for the per-installation + per-user cache key (see the file header). */
+const CACHE_KEY_PREFIX = 'cf.personal-pw'
+/**
+ * The pre-scoping GLOBAL key (origin-only), retired by ADR 0026 D7. It is purged on sight and
+ * its value is NEVER reused — migrating it would re-introduce exactly the cross-installation /
+ * cross-user reuse the scoping removes, so the affected user is simply re-challenged once.
+ */
+const LEGACY_CACHE_KEY = 'cf.personal-pw'
+
+/** A short, stable non-cryptographic hash (FNV-1a → base36) of the API base, for the key scope. */
+function scopeHash(input: string): string {
+  let h = 0x811c9dc5
+  for (let i = 0; i < input.length; i++) {
+    h ^= input.charCodeAt(i)
+    h = Math.imul(h, 0x01000193)
+  }
+  return (h >>> 0).toString(36)
+}
+
+/**
+ * The localStorage key the personal password is cached under, scoped per installation (the
+ * configured `apiBase`, hashed) and per user (`userId`, or `anon` when auth is off / nobody is
+ * signed in). Exported for the store's unit test to seed/read the exact key the store uses.
+ */
+export function personalPasswordCacheKey(
+  apiBase: string,
+  userId: string | null | undefined,
+): string {
+  return `${CACHE_KEY_PREFIX}:${scopeHash(apiBase)}:${userId ?? 'anon'}`
+}
 
 /** A credential prompt the UI must satisfy (set when the server replies 428). */
 export interface PendingCredential {
@@ -71,6 +111,14 @@ export function parseCredentialError(
 
 export const usePersonalSubscriptionsStore = defineStore('personalSubscriptions', () => {
   const api = useApi()
+  const auth = useAuthStore()
+  // The configured API base is a static per-installation fact, so hash it once at setup; the user
+  // id is dynamic, so it is read lazily off the auth store when the key is computed.
+  const apiBase = String(useRuntimeConfig().public.apiBase ?? '')
+  /** The current per-installation + per-user cache key. */
+  function cacheKey(): string {
+    return personalPasswordCacheKey(apiBase, auth.user?.id)
+  }
   const subscriptions = ref<PersonalSubscriptionStatus[]>([])
   const loading = ref(false)
   /** When set, a credential modal should open to satisfy the pending prompt. */
@@ -119,12 +167,15 @@ export const usePersonalSubscriptionsStore = defineStore('personalSubscriptions'
    */
   function getCachedPassword(bufferMs = 0): string | undefined {
     if (typeof localStorage === 'undefined') return undefined
+    // Retire the pre-scoping global key on sight (never reused — see LEGACY_CACHE_KEY).
+    purgeLegacyCache()
     try {
-      const raw = localStorage.getItem(CACHE_KEY)
+      const key = cacheKey()
+      const raw = localStorage.getItem(key)
       if (!raw) return undefined
       const { password, expiresAt } = JSON.parse(raw) as { password: string; expiresAt: number }
       if (Date.now() > expiresAt) {
-        localStorage.removeItem(CACHE_KEY)
+        localStorage.removeItem(key)
         return undefined
       }
       // Within the buffer the key is still valid — keep it, but withhold it so the action
@@ -140,7 +191,7 @@ export const usePersonalSubscriptionsStore = defineStore('personalSubscriptions'
     if (typeof localStorage === 'undefined') return
     try {
       localStorage.setItem(
-        CACHE_KEY,
+        cacheKey(),
         JSON.stringify({ password, expiresAt: Date.now() + PASSWORD_TTL_MS }),
       )
     } catch {
@@ -151,7 +202,17 @@ export const usePersonalSubscriptionsStore = defineStore('personalSubscriptions'
   function clearCachedPassword() {
     if (typeof localStorage === 'undefined') return
     try {
-      localStorage.removeItem(CACHE_KEY)
+      localStorage.removeItem(cacheKey())
+    } catch {
+      // best-effort
+    }
+  }
+
+  /** Remove the retired global `cf.personal-pw` key so its value can never be offered again. */
+  function purgeLegacyCache() {
+    if (typeof localStorage === 'undefined') return
+    try {
+      localStorage.removeItem(LEGACY_CACHE_KEY)
     } catch {
       // best-effort
     }

package/app/utils/prReviewProgress.spec.ts

@@ -3,7 +3,7 @@ import type { PrReviewStepState, StepSubtasks } from '~/types/execution'
 import {
   activeChunkLabels,
   chunkReviewPercent,
-  isSlicingChunks,
+  hasNoSlicePlan,
   prReviewPhase,
 } from './prReviewProgress'
 
@@ -14,18 +14,19 @@ const subtasks = (over: Partial<StepSubtasks>): StepSubtasks => ({
   ...over,
 })
 
-describe('isSlicingChunks', () => {
-  it('is slicing when there is no todo list yet (null/undefined or empty)', () => {
-    // No plan committed → the reviewer is still grouping the diff into chunks.
-    expect(isSlicingChunks(null)).toBe(true)
-    expect(isSlicingChunks(undefined)).toBe(true)
-    expect(isSlicingChunks(subtasks({ total: 0 }))).toBe(true)
+describe('hasNoSlicePlan', () => {
+  it('has no plan when there is no todo list yet (null/undefined or empty)', () => {
+    // No per-slice plan reported — a NEUTRAL signal (grouping, OR a subagent review that never
+    // writes a parent plan), NOT proof of "slicing".
+    expect(hasNoSlicePlan(null)).toBe(true)
+    expect(hasNoSlicePlan(undefined)).toBe(true)
+    expect(hasNoSlicePlan(subtasks({ total: 0 }))).toBe(true)
   })
 
-  it('is not slicing once the todo list exists (slicing is done)', () => {
-    expect(isSlicingChunks(subtasks({ total: 3, completed: 1 }))).toBe(false)
-    // A single-chunk plan still counts as sliced — a plan of size 1 is a committed plan.
-    expect(isSlicingChunks(subtasks({ total: 1 }))).toBe(false)
+  it('has a plan once the todo list exists', () => {
+    expect(hasNoSlicePlan(subtasks({ total: 3, completed: 1 }))).toBe(false)
+    // A single-slice plan still counts — a plan of size 1 is a committed plan.
+    expect(hasNoSlicePlan(subtasks({ total: 1 }))).toBe(false)
   })
 })
 
@@ -89,15 +90,16 @@ describe('prReviewPhase', () => {
     expect(prReviewPhase(state('skipped'), null)).toBeNull()
   })
 
-  it('is slicing while reviewing with no todo list yet (counts zeroed)', () => {
-    // No plan committed → don't leak a misleading 0/0 slice count.
+  it('is the neutral `planning` kind while reviewing with no todo list yet (counts zeroed)', () => {
+    // No plan reported → surface a neutral "reviewing, planning" phase (NOT "slicing") and don't
+    // leak a misleading 0/0 slice count.
     expect(prReviewPhase(state('reviewing'), null)).toEqual({
-      kind: 'slicing',
+      kind: 'planning',
       completed: 0,
       total: 0,
     })
     expect(prReviewPhase(state('reviewing'), subtasks({ total: 0 }))).toEqual({
-      kind: 'slicing',
+      kind: 'planning',
       completed: 0,
       total: 0,
     })

package/app/utils/prReviewProgress.ts

@@ -3,14 +3,21 @@ import type { PrReviewStepState, StepSubtasks } from '~/types/execution'
 // Pure derivation of the PR deep-reviewer's `reviewing`-phase progress, factored out of
 // `PrReviewWindow.vue` so it is unit-testable independently of the Vue component.
 //
-// The reviewer maintains a per-slice todo list (`step.subtasks`) once it has grouped the diff
-// into cohesive chunks. The PRESENCE of that list is the signal that slicing is done, so the two
-// `reviewing` sub-phases are told apart by it:
-//   - no todo list yet (`total === 0`) → still SLICING the diff into chunks (no plan committed).
-//   - todo list present (`total > 0`) → slicing DONE, working through the chunks.
+// When the reviewer maintains a per-slice todo list (`step.subtasks`) — one entry per cohesive
+// chunk of the diff — the UI shows per-slice progress. But that list is NOT always present: the
+// reviewer often reviews via parallel general-purpose subagents, which never write a parent-level
+// TodoWrite plan, so `subtasks` stays empty for the whole review (ADR 0026 P2/D2.2). So an empty
+// todo list is NOT proof the reviewer is "still slicing" — it only means no per-slice plan has
+// been reported yet. We therefore surface a NEUTRAL "reviewing, planning slices" state and switch
+// to per-slice status the moment a plan exists — the UI never asserts a specific "slicing" phase
+// purely because the parent stream emitted no todo list.
 
-/** True while the reviewer is still grouping the diff into chunks (it has not committed a plan). */
-export function isSlicingChunks(subtasks: StepSubtasks | null | undefined): boolean {
+/**
+ * True while NO per-slice todo plan has been reported (`total <= 0`). This is a neutral
+ * "no plan yet" signal — the reviewer may be grouping the diff OR reviewing via subagents that
+ * don't write a parent plan — NOT an assertion that it is "still slicing" (see the note above).
+ */
+export function hasNoSlicePlan(subtasks: StepSubtasks | null | undefined): boolean {
   return (subtasks?.total ?? 0) <= 0
 }
 
@@ -29,13 +36,16 @@ export function activeChunkLabels(subtasks: StepSubtasks | null | undefined): st
 
 /**
  * The at-a-glance phase of a `pr-reviewer` step, collapsing its `prReview.status` (+ the
- * slicing-vs-reviewing signal from the todo list) into a single kind the board surfaces label
- * without re-deriving. `completed`/`total` carry the slice counts for the `reviewing` kind.
+ * has-a-plan signal from the todo list) into a single kind the board surfaces label without
+ * re-deriving. `completed`/`total` carry the slice counts for the `reviewing` kind. The
+ * `planning` kind is the NEUTRAL "reviewing, no per-slice plan reported yet" state (see
+ * {@link hasNoSlicePlan}) — it deliberately does NOT claim a specific "slicing" phase, since an
+ * empty todo list is the normal shape of a subagent-driven review, not proof of slicing.
  * Returns `null` for the terminal / passed-through states (`done`/`skipped`) and when there is
  * no live review — those have no in-flight phase to show.
  */
 export type PrReviewPhaseKind =
-  | 'slicing'
+  | 'planning'
   | 'reviewing'
   | 'awaiting'
   | 'challenging'
@@ -44,9 +54,9 @@ export type PrReviewPhaseKind =
 
 export interface PrReviewPhase {
   kind: PrReviewPhaseKind
-  /** Slices whose review is finished (0 while slicing). */
+  /** Slices whose review is finished (0 while planning). */
   completed: number
-  /** Total slices the reviewer grouped the diff into (0 while slicing). */
+  /** Total slices the reviewer grouped the diff into (0 while planning). */
   total: number
 }
 
@@ -60,9 +70,10 @@ export function prReviewPhase(
   const total = subtasks?.total ?? 0
   switch (status) {
     case 'reviewing':
-      // No todo list yet ⇒ still grouping the diff; otherwise working through the chunks.
-      return isSlicingChunks(subtasks)
-        ? { kind: 'slicing', completed: 0, total: 0 }
+      // No per-slice plan reported yet ⇒ neutral "planning" (don't claim "slicing"); once a plan
+      // exists, work through the chunks with live counts.
+      return hasNoSlicePlan(subtasks)
+        ? { kind: 'planning', completed: 0, total: 0 }
         : { kind: 'reviewing', completed, total }
     case 'awaiting_selection':
       return { kind: 'awaiting', completed, total }

package/i18n/locales/de.json

@@ -1745,7 +1745,8 @@
         "markRead": "Als gelesen markieren",
         "fork_decision_pending": "Als gelesen markieren",
         "pr_review_ready": "Als gelesen markieren",
-        "budget_paused": "Als gelesen markieren"
+        "budget_paused": "Als gelesen markieren",
+        "key_drift": "Veraltete Zugangsdaten entfernen"
       }
     },
     "aiProvidersBanner": {
@@ -4943,9 +4944,9 @@
     "suggestedFix": "Lösungsvorschlag:",
     "line": "Zeile {line}",
     "reviewing": {
-      "slicing": {
-        "title": "Diff wird in Abschnitte zerlegt…",
-        "hint": "Die geänderten Dateien werden in zusammenhängende Abschnitte gruppiert, damit jeder einzeln geprüft werden kann. Die Abschnittsliste erscheint hier, sobald die Zerlegung abgeschlossen ist."
+      "planning": {
+        "title": "Pull Request wird geprüft…",
+        "hint": "Der Prüfer arbeitet den Diff durch. Der Fortschritt pro Abschnitt erscheint hier, sobald die Änderungen in Abschnitte gruppiert werden."
       },
       "reviewingChunks": {
         "title": "Abschnitte werden geprüft…",
@@ -4962,7 +4963,7 @@
       }
     },
     "phase": {
-      "slicing": "Wird aufgeteilt…",
+      "planning": "Wird geprüft…",
       "reviewing": "Prüfe {completed}/{total} Abschnitte",
       "awaiting": "Ergebnisse bereit",
       "challenging": "Wird untersucht…",

package/i18n/locales/en.json

@@ -1725,7 +1725,8 @@
         "markRead": "Mark read",
         "fork_decision_pending": "Mark read",
         "pr_review_ready": "Mark read",
-        "budget_paused": "Mark read"
+        "budget_paused": "Mark read",
+        "key_drift": "Drop stale credentials"
       }
     },
     "aiProvidersBanner": {
@@ -5072,9 +5073,9 @@
     "suggestedFix": "Suggested fix:",
     "line": "line {line}",
     "reviewing": {
-      "slicing": {
-        "title": "Slicing the diff into chunks…",
-        "hint": "Grouping the changed files into cohesive chunks so each can be reviewed on its own. The chunk list appears here once slicing is done."
+      "planning": {
+        "title": "Reviewing the pull request…",
+        "hint": "The reviewer is working through the diff. Per-slice progress appears here once it groups the changes into slices."
       },
       "reviewingChunks": {
         "title": "Reviewing the chunks…",
@@ -5091,7 +5092,7 @@
       }
     },
     "phase": {
-      "slicing": "Slicing…",
+      "planning": "Reviewing…",
       "reviewing": "Reviewing {completed}/{total} slices",
       "awaiting": "Findings ready",
       "challenging": "Investigating…",

package/i18n/locales/es.json

@@ -1656,7 +1656,8 @@
         "markRead": "Marcar como leída",
         "fork_decision_pending": "Marcar como leído",
         "pr_review_ready": "Marcar como leída",
-        "budget_paused": "Marcar como leída"
+        "budget_paused": "Marcar como leída",
+        "key_drift": "Descartar credenciales obsoletas"
       },
       "toast": {
         "acted": "Marcado como resuelto",
@@ -4931,9 +4932,9 @@
     "suggestedFix": "Corrección sugerida:",
     "line": "línea {line}",
     "reviewing": {
-      "slicing": {
-        "title": "Dividiendo el diff en fragmentos…",
-        "hint": "Agrupando los archivos modificados en fragmentos coherentes para revisar cada uno por separado. La lista de fragmentos aparecerá aquí cuando termine la división."
+      "planning": {
+        "title": "Revisando la pull request…",
+        "hint": "El revisor está analizando el diff. El progreso por sección aparecerá aquí cuando agrupe los cambios en secciones."
       },
       "reviewingChunks": {
         "title": "Revisando los fragmentos…",
@@ -4950,7 +4951,7 @@
       }
     },
     "phase": {
-      "slicing": "Dividiendo…",
+      "planning": "Revisando…",
       "reviewing": "Revisando {completed}/{total} secciones",
       "awaiting": "Resultados listos",
       "challenging": "Investigando…",

package/i18n/locales/fr.json

@@ -1656,7 +1656,8 @@
         "markRead": "Marquer comme lu",
         "fork_decision_pending": "Marquer comme lu",
         "pr_review_ready": "Marquer comme lu",
-        "budget_paused": "Marquer comme lu"
+        "budget_paused": "Marquer comme lu",
+        "key_drift": "Supprimer les identifiants obsolètes"
       },
       "toast": {
         "acted": "Marqué comme traité",
@@ -4931,9 +4932,9 @@
     "suggestedFix": "Correction suggérée :",
     "line": "ligne {line}",
     "reviewing": {
-      "slicing": {
-        "title": "Découpage du diff en sections…",
-        "hint": "Regroupement des fichiers modifiés en sections cohérentes afin de pouvoir examiner chacune séparément. La liste des sections apparaîtra ici une fois le découpage terminé."
+      "planning": {
+        "title": "Révision de la pull request…",
+        "hint": "Le relecteur parcourt le diff. La progression par section apparaîtra ici une fois les modifications regroupées en sections."
       },
       "reviewingChunks": {
         "title": "Revue des sections…",
@@ -4950,7 +4951,7 @@
       }
     },
     "phase": {
-      "slicing": "Découpage…",
+      "planning": "Révision…",
       "reviewing": "Révision {completed}/{total} sections",
       "awaiting": "Résultats prêts",
       "challenging": "Analyse en cours…",

package/i18n/locales/he.json

@@ -1656,7 +1656,8 @@
         "markRead": "סמן כנקרא",
         "fork_decision_pending": "סמן כנקרא",
         "pr_review_ready": "סמן כנקרא",
-        "budget_paused": "סמן כנקרא"
+        "budget_paused": "סמן כנקרא",
+        "key_drift": "מחק אישורים מיושנים"
       },
       "toast": {
         "acted": "סומן כטופל",
@@ -4942,9 +4943,9 @@
     "suggestedFix": "תיקון מוצע:",
     "line": "שורה {line}",
     "reviewing": {
-      "slicing": {
-        "title": "מחלק את ההבדלים למקטעים…",
-        "hint": "מקבץ את הקבצים שהשתנו למקטעים לכידים כדי לבדוק כל אחד בנפרד. רשימת המקטעים תופיע כאן לאחר סיום החלוקה."
+      "planning": {
+        "title": "בודק את בקשת המשיכה…",
+        "hint": "הבודק עובר על ההבדלים. ההתקדמות לפי מקטע תופיע כאן לאחר שהשינויים יקובצו למקטעים."
       },
       "reviewingChunks": {
         "title": "בודק את המקטעים…",
@@ -4961,7 +4962,7 @@
       }
     },
     "phase": {
-      "slicing": "מחלק…",
+      "planning": "בודק…",
       "reviewing": "בודק {completed}/{total} מקטעים",
       "awaiting": "הממצאים מוכנים",
       "challenging": "חוקר…",

package/i18n/locales/it.json

@@ -1745,7 +1745,8 @@
         "markRead": "Segna come letto",
         "fork_decision_pending": "Segna come letto",
         "pr_review_ready": "Segna come letto",
-        "budget_paused": "Segna come letto"
+        "budget_paused": "Segna come letto",
+        "key_drift": "Elimina credenziali obsolete"
       }
     },
     "aiProvidersBanner": {
@@ -4943,9 +4944,9 @@
     "suggestedFix": "Correzione suggerita:",
     "line": "riga {line}",
     "reviewing": {
-      "slicing": {
-        "title": "Suddivisione del diff in blocchi…",
-        "hint": "Raggruppamento dei file modificati in blocchi coerenti per esaminare ciascuno separatamente. L'elenco dei blocchi comparirà qui al termine della suddivisione."
+      "planning": {
+        "title": "Revisione della pull request…",
+        "hint": "Il revisore sta esaminando il diff. L'avanzamento per sezione comparirà qui una volta raggruppate le modifiche in sezioni."
       },
       "reviewingChunks": {
         "title": "Revisione dei blocchi…",
@@ -4962,7 +4963,7 @@
       }
     },
     "phase": {
-      "slicing": "Suddivisione…",
+      "planning": "Revisione…",
       "reviewing": "Revisione {completed}/{total} sezioni",
       "awaiting": "Risultati pronti",
       "challenging": "Analisi in corso…",

package/i18n/locales/ja.json

@@ -1656,7 +1656,8 @@
         "markRead": "既読にする",
         "fork_decision_pending": "既読にする",
         "pr_review_ready": "既読にする",
-        "budget_paused": "既読にする"
+        "budget_paused": "既読にする",
+        "key_drift": "古い認証情報を削除"
       },
       "toast": {
         "acted": "対応済みにしました",
@@ -4943,9 +4944,9 @@
     "suggestedFix": "修正案:",
     "line": "{line}行目",
     "reviewing": {
-      "slicing": {
-        "title": "差分をチャンクに分割中…",
-        "hint": "変更されたファイルをまとまりのあるチャンクにグループ化し、各チャンクを個別にレビューできるようにしています。分割が完了すると、ここにチャンク一覧が表示されます。"
+      "planning": {
+        "title": "プルリクエストをレビュー中…",
+        "hint": "レビュー担当者が差分を確認しています。変更が区分にグループ化されると、区分ごとの進捗がここに表示されます。"
       },
       "reviewingChunks": {
         "title": "チャンクをレビュー中…",
@@ -4962,7 +4963,7 @@
       }
     },
     "phase": {
-      "slicing": "分割中…",
+      "planning": "レビュー中…",
       "reviewing": "レビュー中 {completed}/{total} 区分",
       "awaiting": "指摘の準備完了",
       "challenging": "調査中…",

package/i18n/locales/pl.json

@@ -1656,7 +1656,8 @@
         "markRead": "Oznacz jako przeczytane",
         "fork_decision_pending": "Oznacz jako przeczytane",
         "pr_review_ready": "Oznacz jako przeczytane",
-        "budget_paused": "Oznacz jako przeczytane"
+        "budget_paused": "Oznacz jako przeczytane",
+        "key_drift": "Usuń nieaktualne poświadczenia"
       },
       "toast": {
         "acted": "Oznaczono jako obsłużone",
@@ -4931,9 +4932,9 @@
     "suggestedFix": "Sugerowana poprawka:",
     "line": "wiersz {line}",
     "reviewing": {
-      "slicing": {
-        "title": "Dzielenie zmian na fragmenty…",
-        "hint": "Grupowanie zmienionych plików w spójne fragmenty, aby każdy można było przejrzeć osobno. Lista fragmentów pojawi się tutaj po zakończeniu podziału."
+      "planning": {
+        "title": "Przeglądanie pull requesta…",
+        "hint": "Recenzent analizuje zmiany. Postęp poszczególnych fragmentów pojawi się tutaj po pogrupowaniu zmian we fragmenty."
       },
       "reviewingChunks": {
         "title": "Przeglądanie fragmentów…",
@@ -4950,7 +4951,7 @@
       }
     },
     "phase": {
-      "slicing": "Dzielenie…",
+      "planning": "Przegląd…",
       "reviewing": "Przegląd {completed}/{total} fragmentów",
       "awaiting": "Wyniki gotowe",
       "challenging": "Analizowanie…",

package/i18n/locales/tr.json

@@ -1656,7 +1656,8 @@
         "markRead": "Okundu işaretle",
         "fork_decision_pending": "Okundu olarak işaretle",
         "pr_review_ready": "Okundu işaretle",
-        "budget_paused": "Okundu işaretle"
+        "budget_paused": "Okundu işaretle",
+        "key_drift": "Eski kimlik bilgilerini kaldır"
       },
       "toast": {
         "acted": "İşlendi olarak işaretlendi",
@@ -4943,9 +4944,9 @@
     "suggestedFix": "Önerilen düzeltme:",
     "line": "satır {line}",
     "reviewing": {
-      "slicing": {
-        "title": "Fark parçalara bölünüyor…",
-        "hint": "Değiştirilen dosyalar, her biri ayrı ayrı incelenebilsin diye tutarlı parçalara gruplanıyor. Bölme tamamlandığında parça listesi burada görünecek."
+      "planning": {
+        "title": "Pull request inceleniyor…",
+        "hint": "İnceleyici farkı gözden geçiriyor. Değişiklikler bölümlere gruplandığında bölüm bazlı ilerleme burada görünecek."
       },
       "reviewingChunks": {
         "title": "Parçalar inceleniyor…",
@@ -4962,7 +4963,7 @@
       }
     },
     "phase": {
-      "slicing": "Dilimleniyor…",
+      "planning": "İnceleniyor…",
       "reviewing": "İnceleniyor {completed}/{total} bölüm",
       "awaiting": "Bulgular hazır",
       "challenging": "Araştırılıyor…",

package/i18n/locales/uk.json

@@ -1656,7 +1656,8 @@
         "markRead": "Позначити прочитаним",
         "fork_decision_pending": "Позначити прочитаним",
         "pr_review_ready": "Позначити прочитаним",
-        "budget_paused": "Позначити прочитаним"
+        "budget_paused": "Позначити прочитаним",
+        "key_drift": "Видалити застарілі облікові дані"
       },
       "toast": {
         "acted": "Позначено як опрацьоване",
@@ -4931,9 +4932,9 @@
     "suggestedFix": "Пропоноване виправлення:",
     "line": "рядок {line}",
     "reviewing": {
-      "slicing": {
-        "title": "Поділ змін на фрагменти…",
-        "hint": "Групування змінених файлів у цілісні фрагменти, щоб кожен можна було переглянути окремо. Список фрагментів з'явиться тут після завершення поділу."
+      "planning": {
+        "title": "Перевірка pull request…",
+        "hint": "Рецензент переглядає зміни. Прогрес за фрагментами з'явиться тут після групування змін у фрагменти."
       },
       "reviewingChunks": {
         "title": "Огляд фрагментів…",
@@ -4950,7 +4951,7 @@
       }
     },
     "phase": {
-      "slicing": "Розбиття…",
+      "planning": "Перевірка…",
       "reviewing": "Перевірка {completed}/{total} фрагментів",
       "awaiting": "Результати готові",
       "challenging": "Дослідження…",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cat-factory/app",
-  "version": "0.147.2",
+  "version": "0.147.4",
   "description": "Reusable Nuxt layer for the Agent Architecture Board SPA (components, stores, composables, pages). Consume it from a thin deployment app via `extends: ['@cat-factory/app']` and point it at your backend with NUXT_PUBLIC_API_BASE. See deploy/frontend for an example.",
   "repository": {
     "type": "git",
@@ -40,7 +40,7 @@
     "valibot": "^1.4.2",
     "vue": "3.5.40",
     "wretch": "^3.0.9",
-    "@cat-factory/contracts": "0.154.0"
+    "@cat-factory/contracts": "0.154.1"
   },
   "devDependencies": {
     "@toad-contracts/testing": "0.3.2",