@cat-factory/app 0.147.1 → 0.147.2

package/app/utils/prReviewProgress.spec.ts

@@ -1,6 +1,11 @@
 import { describe, it, expect } from 'vitest'
-import type { StepSubtasks } from '~/types/execution'
-import { activeChunkLabels, chunkReviewPercent, isSlicingChunks } from './prReviewProgress'
+import type { PrReviewStepState, StepSubtasks } from '~/types/execution'
+import {
+  activeChunkLabels,
+  chunkReviewPercent,
+  isSlicingChunks,
+  prReviewPhase,
+} from './prReviewProgress'
 
 const subtasks = (over: Partial<StepSubtasks>): StepSubtasks => ({
   completed: 0,
@@ -71,3 +76,47 @@ describe('activeChunkLabels', () => {
     ).toEqual([])
   })
 })
+
+// `prReviewPhase` reads only `status`; the other PrReviewStepState fields are irrelevant here.
+const state = (status: PrReviewStepState['status']): PrReviewStepState =>
+  ({ status }) as PrReviewStepState
+
+describe('prReviewPhase', () => {
+  it('is null with no live review or a terminal/passed-through status', () => {
+    expect(prReviewPhase(null, null)).toBeNull()
+    expect(prReviewPhase(undefined, subtasks({ total: 3, completed: 3 }))).toBeNull()
+    expect(prReviewPhase(state('done'), subtasks({ total: 3, completed: 3 }))).toBeNull()
+    expect(prReviewPhase(state('skipped'), null)).toBeNull()
+  })
+
+  it('is slicing while reviewing with no todo list yet (counts zeroed)', () => {
+    // No plan committed → don't leak a misleading 0/0 slice count.
+    expect(prReviewPhase(state('reviewing'), null)).toEqual({
+      kind: 'slicing',
+      completed: 0,
+      total: 0,
+    })
+    expect(prReviewPhase(state('reviewing'), subtasks({ total: 0 }))).toEqual({
+      kind: 'slicing',
+      completed: 0,
+      total: 0,
+    })
+  })
+
+  it('is reviewing with the slice counts once the todo list exists', () => {
+    expect(prReviewPhase(state('reviewing'), subtasks({ total: 4, completed: 1 }))).toEqual({
+      kind: 'reviewing',
+      completed: 1,
+      total: 4,
+    })
+  })
+
+  it('maps the parked / resolving statuses to their phase', () => {
+    expect(
+      prReviewPhase(state('awaiting_selection'), subtasks({ total: 4, completed: 4 }))?.kind,
+    ).toBe('awaiting')
+    expect(prReviewPhase(state('challenging'), null)?.kind).toBe('challenging')
+    expect(prReviewPhase(state('fixing'), null)?.kind).toBe('fixing')
+    expect(prReviewPhase(state('posting'), null)?.kind).toBe('posting')
+  })
+})

package/app/utils/prReviewProgress.ts

@@ -1,4 +1,4 @@
-import type { StepSubtasks } from '~/types/execution'
+import type { PrReviewStepState, StepSubtasks } from '~/types/execution'
 
 // Pure derivation of the PR deep-reviewer's `reviewing`-phase progress, factored out of
 // `PrReviewWindow.vue` so it is unit-testable independently of the Vue component.
@@ -26,3 +26,54 @@ export function chunkReviewPercent(subtasks: StepSubtasks | null | undefined): n
 export function activeChunkLabels(subtasks: StepSubtasks | null | undefined): string[] {
   return subtasks?.items?.filter((i) => i.status === 'in_progress').map((i) => i.label) ?? []
 }
+
+/**
+ * The at-a-glance phase of a `pr-reviewer` step, collapsing its `prReview.status` (+ the
+ * slicing-vs-reviewing signal from the todo list) into a single kind the board surfaces label
+ * without re-deriving. `completed`/`total` carry the slice counts for the `reviewing` kind.
+ * Returns `null` for the terminal / passed-through states (`done`/`skipped`) and when there is
+ * no live review — those have no in-flight phase to show.
+ */
+export type PrReviewPhaseKind =
+  | 'slicing'
+  | 'reviewing'
+  | 'awaiting'
+  | 'challenging'
+  | 'fixing'
+  | 'posting'
+
+export interface PrReviewPhase {
+  kind: PrReviewPhaseKind
+  /** Slices whose review is finished (0 while slicing). */
+  completed: number
+  /** Total slices the reviewer grouped the diff into (0 while slicing). */
+  total: number
+}
+
+export function prReviewPhase(
+  state: PrReviewStepState | null | undefined,
+  subtasks: StepSubtasks | null | undefined,
+): PrReviewPhase | null {
+  const status = state?.status
+  if (!status) return null
+  const completed = subtasks?.completed ?? 0
+  const total = subtasks?.total ?? 0
+  switch (status) {
+    case 'reviewing':
+      // No todo list yet ⇒ still grouping the diff; otherwise working through the chunks.
+      return isSlicingChunks(subtasks)
+        ? { kind: 'slicing', completed: 0, total: 0 }
+        : { kind: 'reviewing', completed, total }
+    case 'awaiting_selection':
+      return { kind: 'awaiting', completed, total }
+    case 'challenging':
+      return { kind: 'challenging', completed, total }
+    case 'fixing':
+      return { kind: 'fixing', completed, total }
+    case 'posting':
+      return { kind: 'posting', completed, total }
+    default:
+      // done / skipped — no live phase to surface.
+      return null
+  }
+}

package/i18n/locales/de.json

@@ -4961,6 +4961,14 @@
         "pending": "In Warteschlange"
       }
     },
+    "phase": {
+      "slicing": "Wird aufgeteilt…",
+      "reviewing": "Prüfe {completed}/{total} Abschnitte",
+      "awaiting": "Ergebnisse bereit",
+      "challenging": "Wird untersucht…",
+      "fixing": "Wird behoben…",
+      "posting": "Wird veröffentlicht…"
+    },
     "challenge": {
       "action": "Anfechten",
       "reChallenge": "Erneut anfechten",

package/i18n/locales/en.json

@@ -5090,6 +5090,14 @@
         "pending": "Queued"
       }
     },
+    "phase": {
+      "slicing": "Slicing…",
+      "reviewing": "Reviewing {completed}/{total} slices",
+      "awaiting": "Findings ready",
+      "challenging": "Investigating…",
+      "fixing": "Fixing…",
+      "posting": "Posting…"
+    },
     "challenge": {
       "action": "Challenge",
       "reChallenge": "Challenge again",

package/i18n/locales/es.json

@@ -4949,6 +4949,14 @@
         "pending": "En cola"
       }
     },
+    "phase": {
+      "slicing": "Dividiendo…",
+      "reviewing": "Revisando {completed}/{total} secciones",
+      "awaiting": "Resultados listos",
+      "challenging": "Investigando…",
+      "fixing": "Corrigiendo…",
+      "posting": "Publicando…"
+    },
     "challenge": {
       "action": "Cuestionar",
       "reChallenge": "Cuestionar de nuevo",

package/i18n/locales/fr.json

@@ -4949,6 +4949,14 @@
         "pending": "En attente"
       }
     },
+    "phase": {
+      "slicing": "Découpage…",
+      "reviewing": "Révision {completed}/{total} sections",
+      "awaiting": "Résultats prêts",
+      "challenging": "Analyse en cours…",
+      "fixing": "Correction…",
+      "posting": "Publication…"
+    },
     "challenge": {
       "action": "Contester",
       "reChallenge": "Contester à nouveau",

package/i18n/locales/he.json

@@ -4960,6 +4960,14 @@
         "pending": "בתור"
       }
     },
+    "phase": {
+      "slicing": "מחלק…",
+      "reviewing": "בודק {completed}/{total} מקטעים",
+      "awaiting": "הממצאים מוכנים",
+      "challenging": "חוקר…",
+      "fixing": "מתקן…",
+      "posting": "מפרסם…"
+    },
     "challenge": {
       "action": "ערער",
       "reChallenge": "ערער שוב",

package/i18n/locales/it.json

@@ -4961,6 +4961,14 @@
         "pending": "In coda"
       }
     },
+    "phase": {
+      "slicing": "Suddivisione…",
+      "reviewing": "Revisione {completed}/{total} sezioni",
+      "awaiting": "Risultati pronti",
+      "challenging": "Analisi in corso…",
+      "fixing": "Correzione…",
+      "posting": "Pubblicazione…"
+    },
     "challenge": {
       "action": "Contesta",
       "reChallenge": "Contesta di nuovo",

package/i18n/locales/ja.json

@@ -4961,6 +4961,14 @@
         "pending": "待機中"
       }
     },
+    "phase": {
+      "slicing": "分割中…",
+      "reviewing": "レビュー中 {completed}/{total} 区分",
+      "awaiting": "指摘の準備完了",
+      "challenging": "調査中…",
+      "fixing": "修正中…",
+      "posting": "投稿中…"
+    },
     "challenge": {
       "action": "異議を唱える",
       "reChallenge": "再度異議を唱える",

package/i18n/locales/pl.json

@@ -4949,6 +4949,14 @@
         "pending": "W kolejce"
       }
     },
+    "phase": {
+      "slicing": "Dzielenie…",
+      "reviewing": "Przegląd {completed}/{total} fragmentów",
+      "awaiting": "Wyniki gotowe",
+      "challenging": "Analizowanie…",
+      "fixing": "Naprawianie…",
+      "posting": "Publikowanie…"
+    },
     "challenge": {
       "action": "Zakwestionuj",
       "reChallenge": "Zakwestionuj ponownie",

package/i18n/locales/tr.json

@@ -4961,6 +4961,14 @@
         "pending": "Sırada"
       }
     },
+    "phase": {
+      "slicing": "Dilimleniyor…",
+      "reviewing": "İnceleniyor {completed}/{total} bölüm",
+      "awaiting": "Bulgular hazır",
+      "challenging": "Araştırılıyor…",
+      "fixing": "Düzeltiliyor…",
+      "posting": "Yayınlanıyor…"
+    },
     "challenge": {
       "action": "İtiraz et",
       "reChallenge": "Tekrar itiraz et",

package/i18n/locales/uk.json

@@ -4949,6 +4949,14 @@
         "pending": "У черзі"
       }
     },
+    "phase": {
+      "slicing": "Розбиття…",
+      "reviewing": "Перевірка {completed}/{total} фрагментів",
+      "awaiting": "Результати готові",
+      "challenging": "Дослідження…",
+      "fixing": "Виправлення…",
+      "posting": "Публікація…"
+    },
     "challenge": {
       "action": "Оскаржити",
       "reChallenge": "Оскаржити знову",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cat-factory/app",
-  "version": "0.147.1",
+  "version": "0.147.2",
   "description": "Reusable Nuxt layer for the Agent Architecture Board SPA (components, stores, composables, pages). Consume it from a thin deployment app via `extends: ['@cat-factory/app']` and point it at your backend with NUXT_PUBLIC_API_BASE. See deploy/frontend for an example.",
   "repository": {
     "type": "git",