@cat-factory/app 0.147.0 → 0.147.2

package/app/utils/prReviewProgress.spec.ts

@@ -0,0 +1,122 @@
+import { describe, it, expect } from 'vitest'
+import type { PrReviewStepState, StepSubtasks } from '~/types/execution'
+import {
+  activeChunkLabels,
+  chunkReviewPercent,
+  isSlicingChunks,
+  prReviewPhase,
+} from './prReviewProgress'
+
+const subtasks = (over: Partial<StepSubtasks>): StepSubtasks => ({
+  completed: 0,
+  inProgress: 0,
+  total: 0,
+  ...over,
+})
+
+describe('isSlicingChunks', () => {
+  it('is slicing when there is no todo list yet (null/undefined or empty)', () => {
+    // No plan committed → the reviewer is still grouping the diff into chunks.
+    expect(isSlicingChunks(null)).toBe(true)
+    expect(isSlicingChunks(undefined)).toBe(true)
+    expect(isSlicingChunks(subtasks({ total: 0 }))).toBe(true)
+  })
+
+  it('is not slicing once the todo list exists (slicing is done)', () => {
+    expect(isSlicingChunks(subtasks({ total: 3, completed: 1 }))).toBe(false)
+    // A single-chunk plan still counts as sliced — a plan of size 1 is a committed plan.
+    expect(isSlicingChunks(subtasks({ total: 1 }))).toBe(false)
+  })
+})
+
+describe('chunkReviewPercent', () => {
+  it('is 0 with no plan (avoids 0/0 → NaN)', () => {
+    expect(chunkReviewPercent(null)).toBe(0)
+    expect(chunkReviewPercent(subtasks({ total: 0, completed: 0 }))).toBe(0)
+  })
+
+  it('rounds completion to an integer percent', () => {
+    expect(chunkReviewPercent(subtasks({ total: 4, completed: 1 }))).toBe(25)
+    // 1/3 → 33.33… rounds to 33 (the old inline math emitted a fractional width).
+    expect(chunkReviewPercent(subtasks({ total: 3, completed: 1 }))).toBe(33)
+  })
+
+  it('clamps to 0..100 even if counts are inconsistent', () => {
+    expect(chunkReviewPercent(subtasks({ total: 2, completed: 5 }))).toBe(100)
+    expect(chunkReviewPercent(subtasks({ total: 2, completed: -1 }))).toBe(0)
+  })
+})
+
+describe('activeChunkLabels', () => {
+  it('returns only the in-progress chunk labels, in order', () => {
+    const s = subtasks({
+      total: 3,
+      completed: 1,
+      inProgress: 1,
+      items: [
+        { label: 'auth', status: 'completed' },
+        { label: 'db layer', status: 'in_progress' },
+        { label: 'ui', status: 'pending' },
+      ],
+    })
+    expect(activeChunkLabels(s)).toEqual(['db layer'])
+  })
+
+  it('is empty with no items or no in-progress chunk', () => {
+    expect(activeChunkLabels(null)).toEqual([])
+    expect(activeChunkLabels(subtasks({ total: 2 }))).toEqual([])
+    expect(
+      activeChunkLabels(
+        subtasks({
+          total: 1,
+          completed: 1,
+          items: [{ label: 'only', status: 'completed' }],
+        }),
+      ),
+    ).toEqual([])
+  })
+})
+
+// `prReviewPhase` reads only `status`; the other PrReviewStepState fields are irrelevant here.
+const state = (status: PrReviewStepState['status']): PrReviewStepState =>
+  ({ status }) as PrReviewStepState
+
+describe('prReviewPhase', () => {
+  it('is null with no live review or a terminal/passed-through status', () => {
+    expect(prReviewPhase(null, null)).toBeNull()
+    expect(prReviewPhase(undefined, subtasks({ total: 3, completed: 3 }))).toBeNull()
+    expect(prReviewPhase(state('done'), subtasks({ total: 3, completed: 3 }))).toBeNull()
+    expect(prReviewPhase(state('skipped'), null)).toBeNull()
+  })
+
+  it('is slicing while reviewing with no todo list yet (counts zeroed)', () => {
+    // No plan committed → don't leak a misleading 0/0 slice count.
+    expect(prReviewPhase(state('reviewing'), null)).toEqual({
+      kind: 'slicing',
+      completed: 0,
+      total: 0,
+    })
+    expect(prReviewPhase(state('reviewing'), subtasks({ total: 0 }))).toEqual({
+      kind: 'slicing',
+      completed: 0,
+      total: 0,
+    })
+  })
+
+  it('is reviewing with the slice counts once the todo list exists', () => {
+    expect(prReviewPhase(state('reviewing'), subtasks({ total: 4, completed: 1 }))).toEqual({
+      kind: 'reviewing',
+      completed: 1,
+      total: 4,
+    })
+  })
+
+  it('maps the parked / resolving statuses to their phase', () => {
+    expect(
+      prReviewPhase(state('awaiting_selection'), subtasks({ total: 4, completed: 4 }))?.kind,
+    ).toBe('awaiting')
+    expect(prReviewPhase(state('challenging'), null)?.kind).toBe('challenging')
+    expect(prReviewPhase(state('fixing'), null)?.kind).toBe('fixing')
+    expect(prReviewPhase(state('posting'), null)?.kind).toBe('posting')
+  })
+})

package/app/utils/prReviewProgress.ts

@@ -0,0 +1,79 @@
+import type { PrReviewStepState, StepSubtasks } from '~/types/execution'
+
+// Pure derivation of the PR deep-reviewer's `reviewing`-phase progress, factored out of
+// `PrReviewWindow.vue` so it is unit-testable independently of the Vue component.
+//
+// The reviewer maintains a per-slice todo list (`step.subtasks`) once it has grouped the diff
+// into cohesive chunks. The PRESENCE of that list is the signal that slicing is done, so the two
+// `reviewing` sub-phases are told apart by it:
+//   - no todo list yet (`total === 0`) → still SLICING the diff into chunks (no plan committed).
+//   - todo list present (`total > 0`) → slicing DONE, working through the chunks.
+
+/** True while the reviewer is still grouping the diff into chunks (it has not committed a plan). */
+export function isSlicingChunks(subtasks: StepSubtasks | null | undefined): boolean {
+  return (subtasks?.total ?? 0) <= 0
+}
+
+/** Chunk-review completion as an integer percent, clamped 0..100, for the progress bar. */
+export function chunkReviewPercent(subtasks: StepSubtasks | null | undefined): number {
+  const total = subtasks?.total ?? 0
+  if (total <= 0) return 0
+  const completed = subtasks?.completed ?? 0
+  return Math.min(100, Math.max(0, Math.round((completed / total) * 100)))
+}
+
+/** Labels of the chunk(s) the reviewer is actively working through right now (for the callout). */
+export function activeChunkLabels(subtasks: StepSubtasks | null | undefined): string[] {
+  return subtasks?.items?.filter((i) => i.status === 'in_progress').map((i) => i.label) ?? []
+}
+
+/**
+ * The at-a-glance phase of a `pr-reviewer` step, collapsing its `prReview.status` (+ the
+ * slicing-vs-reviewing signal from the todo list) into a single kind the board surfaces label
+ * without re-deriving. `completed`/`total` carry the slice counts for the `reviewing` kind.
+ * Returns `null` for the terminal / passed-through states (`done`/`skipped`) and when there is
+ * no live review — those have no in-flight phase to show.
+ */
+export type PrReviewPhaseKind =
+  | 'slicing'
+  | 'reviewing'
+  | 'awaiting'
+  | 'challenging'
+  | 'fixing'
+  | 'posting'
+
+export interface PrReviewPhase {
+  kind: PrReviewPhaseKind
+  /** Slices whose review is finished (0 while slicing). */
+  completed: number
+  /** Total slices the reviewer grouped the diff into (0 while slicing). */
+  total: number
+}
+
+export function prReviewPhase(
+  state: PrReviewStepState | null | undefined,
+  subtasks: StepSubtasks | null | undefined,
+): PrReviewPhase | null {
+  const status = state?.status
+  if (!status) return null
+  const completed = subtasks?.completed ?? 0
+  const total = subtasks?.total ?? 0
+  switch (status) {
+    case 'reviewing':
+      // No todo list yet ⇒ still grouping the diff; otherwise working through the chunks.
+      return isSlicingChunks(subtasks)
+        ? { kind: 'slicing', completed: 0, total: 0 }
+        : { kind: 'reviewing', completed, total }
+    case 'awaiting_selection':
+      return { kind: 'awaiting', completed, total }
+    case 'challenging':
+      return { kind: 'challenging', completed, total }
+    case 'fixing':
+      return { kind: 'fixing', completed, total }
+    case 'posting':
+      return { kind: 'posting', completed, total }
+    default:
+      // done / skipped — no live phase to surface.
+      return null
+  }
+}

package/i18n/locales/de.json

@@ -4943,10 +4943,31 @@
     "suggestedFix": "Lösungsvorschlag:",
     "line": "Zeile {line}",
     "reviewing": {
-      "title": "Pull Request wird geprüft…",
-      "hint": "Der Diff wird in zusammenhängende Teile zerlegt und einzeln geprüft.",
+      "slicing": {
+        "title": "Diff wird in Abschnitte zerlegt…",
+        "hint": "Die geänderten Dateien werden in zusammenhängende Abschnitte gruppiert, damit jeder einzeln geprüft werden kann. Die Abschnittsliste erscheint hier, sobald die Zerlegung abgeschlossen ist."
+      },
+      "reviewingChunks": {
+        "title": "Abschnitte werden geprüft…",
+        "hint": "Die Zerlegung ist abgeschlossen. Jeder Abschnitt wird nacheinander geprüft und die Ergebnisse werden gesammelt."
+      },
       "chunks": "{completed} von {total} Abschnitten geprüft",
-      "inProgress": "{count} in Bearbeitung"
+      "inProgress": "{count} in Bearbeitung",
+      "activeHeading": "Wird jetzt geprüft",
+      "chunksHeading": "Abschnitte",
+      "chunkStatus": {
+        "completed": "Geprüft",
+        "in_progress": "Wird geprüft…",
+        "pending": "In Warteschlange"
+      }
+    },
+    "phase": {
+      "slicing": "Wird aufgeteilt…",
+      "reviewing": "Prüfe {completed}/{total} Abschnitte",
+      "awaiting": "Ergebnisse bereit",
+      "challenging": "Wird untersucht…",
+      "fixing": "Wird behoben…",
+      "posting": "Wird veröffentlicht…"
     },
     "challenge": {
       "action": "Anfechten",

package/i18n/locales/en.json

@@ -5072,10 +5072,31 @@
     "suggestedFix": "Suggested fix:",
     "line": "line {line}",
     "reviewing": {
-      "title": "Reviewing the pull request…",
-      "hint": "Slicing the diff into cohesive chunks and reviewing each one.",
+      "slicing": {
+        "title": "Slicing the diff into chunks…",
+        "hint": "Grouping the changed files into cohesive chunks so each can be reviewed on its own. The chunk list appears here once slicing is done."
+      },
+      "reviewingChunks": {
+        "title": "Reviewing the chunks…",
+        "hint": "Slicing is done. Working through each chunk one at a time and collecting findings."
+      },
       "chunks": "{completed} of {total} chunks reviewed",
-      "inProgress": "{count} in progress"
+      "inProgress": "{count} in progress",
+      "activeHeading": "Reviewing now",
+      "chunksHeading": "Chunks",
+      "chunkStatus": {
+        "completed": "Reviewed",
+        "in_progress": "Reviewing…",
+        "pending": "Queued"
+      }
+    },
+    "phase": {
+      "slicing": "Slicing…",
+      "reviewing": "Reviewing {completed}/{total} slices",
+      "awaiting": "Findings ready",
+      "challenging": "Investigating…",
+      "fixing": "Fixing…",
+      "posting": "Posting…"
     },
     "challenge": {
       "action": "Challenge",

package/i18n/locales/es.json

@@ -4931,10 +4931,31 @@
     "suggestedFix": "Corrección sugerida:",
     "line": "línea {line}",
     "reviewing": {
-      "title": "Revisando el pull request…",
-      "hint": "Dividiendo el diff en bloques coherentes y revisando cada uno.",
+      "slicing": {
+        "title": "Dividiendo el diff en fragmentos…",
+        "hint": "Agrupando los archivos modificados en fragmentos coherentes para revisar cada uno por separado. La lista de fragmentos aparecerá aquí cuando termine la división."
+      },
+      "reviewingChunks": {
+        "title": "Revisando los fragmentos…",
+        "hint": "La división ha terminado. Revisando cada fragmento de uno en uno y recopilando los hallazgos."
+      },
       "chunks": "{completed} de {total} fragmentos revisados",
-      "inProgress": "{count} en curso"
+      "inProgress": "{count} en curso",
+      "activeHeading": "Revisando ahora",
+      "chunksHeading": "Fragmentos",
+      "chunkStatus": {
+        "completed": "Revisado",
+        "in_progress": "Revisando…",
+        "pending": "En cola"
+      }
+    },
+    "phase": {
+      "slicing": "Dividiendo…",
+      "reviewing": "Revisando {completed}/{total} secciones",
+      "awaiting": "Resultados listos",
+      "challenging": "Investigando…",
+      "fixing": "Corrigiendo…",
+      "posting": "Publicando…"
     },
     "challenge": {
       "action": "Cuestionar",

package/i18n/locales/fr.json

@@ -4931,10 +4931,31 @@
     "suggestedFix": "Correction suggérée :",
     "line": "ligne {line}",
     "reviewing": {
-      "title": "Revue de la pull request…",
-      "hint": "Découpage du diff en blocs cohérents et revue de chacun.",
+      "slicing": {
+        "title": "Découpage du diff en sections…",
+        "hint": "Regroupement des fichiers modifiés en sections cohérentes afin de pouvoir examiner chacune séparément. La liste des sections apparaîtra ici une fois le découpage terminé."
+      },
+      "reviewingChunks": {
+        "title": "Revue des sections…",
+        "hint": "Le découpage est terminé. Chaque section est examinée l'une après l'autre et les remarques sont rassemblées."
+      },
       "chunks": "{completed} sur {total} sections examinées",
-      "inProgress": "{count} en cours"
+      "inProgress": "{count} en cours",
+      "activeHeading": "Revue en cours",
+      "chunksHeading": "Sections",
+      "chunkStatus": {
+        "completed": "Examinée",
+        "in_progress": "En cours d'examen…",
+        "pending": "En attente"
+      }
+    },
+    "phase": {
+      "slicing": "Découpage…",
+      "reviewing": "Révision {completed}/{total} sections",
+      "awaiting": "Résultats prêts",
+      "challenging": "Analyse en cours…",
+      "fixing": "Correction…",
+      "posting": "Publication…"
     },
     "challenge": {
       "action": "Contester",

package/i18n/locales/he.json

@@ -4942,10 +4942,31 @@
     "suggestedFix": "תיקון מוצע:",
     "line": "שורה {line}",
     "reviewing": {
-      "title": "בודק את בקשת המשיכה…",
-      "hint": "מחלק את ההבדלים לקטעים לכידים ובודק כל אחד.",
+      "slicing": {
+        "title": "מחלק את ההבדלים למקטעים…",
+        "hint": "מקבץ את הקבצים שהשתנו למקטעים לכידים כדי לבדוק כל אחד בנפרד. רשימת המקטעים תופיע כאן לאחר סיום החלוקה."
+      },
+      "reviewingChunks": {
+        "title": "בודק את המקטעים…",
+        "hint": "החלוקה הסתיימה. בודק כל מקטע בנפרד ואוסף את הממצאים."
+      },
       "chunks": "{completed} מתוך {total} מקטעים נבדקו",
-      "inProgress": "{count} בתהליך"
+      "inProgress": "{count} בתהליך",
+      "activeHeading": "נבדק כעת",
+      "chunksHeading": "מקטעים",
+      "chunkStatus": {
+        "completed": "נבדק",
+        "in_progress": "בבדיקה…",
+        "pending": "בתור"
+      }
+    },
+    "phase": {
+      "slicing": "מחלק…",
+      "reviewing": "בודק {completed}/{total} מקטעים",
+      "awaiting": "הממצאים מוכנים",
+      "challenging": "חוקר…",
+      "fixing": "מתקן…",
+      "posting": "מפרסם…"
     },
     "challenge": {
       "action": "ערער",

package/i18n/locales/it.json

@@ -4943,10 +4943,31 @@
     "suggestedFix": "Correzione suggerita:",
     "line": "riga {line}",
     "reviewing": {
-      "title": "Revisione della pull request…",
-      "hint": "Suddivisione del diff in blocchi coerenti e revisione di ciascuno.",
+      "slicing": {
+        "title": "Suddivisione del diff in blocchi…",
+        "hint": "Raggruppamento dei file modificati in blocchi coerenti per esaminare ciascuno separatamente. L'elenco dei blocchi comparirà qui al termine della suddivisione."
+      },
+      "reviewingChunks": {
+        "title": "Revisione dei blocchi…",
+        "hint": "La suddivisione è terminata. Ogni blocco viene esaminato uno alla volta e le osservazioni vengono raccolte."
+      },
       "chunks": "{completed} di {total} sezioni esaminate",
-      "inProgress": "{count} in corso"
+      "inProgress": "{count} in corso",
+      "activeHeading": "In revisione ora",
+      "chunksHeading": "Blocchi",
+      "chunkStatus": {
+        "completed": "Esaminato",
+        "in_progress": "In revisione…",
+        "pending": "In coda"
+      }
+    },
+    "phase": {
+      "slicing": "Suddivisione…",
+      "reviewing": "Revisione {completed}/{total} sezioni",
+      "awaiting": "Risultati pronti",
+      "challenging": "Analisi in corso…",
+      "fixing": "Correzione…",
+      "posting": "Pubblicazione…"
     },
     "challenge": {
       "action": "Contesta",

package/i18n/locales/ja.json

@@ -4943,10 +4943,31 @@
     "suggestedFix": "修正案:",
     "line": "{line}行目",
     "reviewing": {
-      "title": "プルリクエストをレビュー中…",
-      "hint": "差分をまとまりのある単位に分割し、各単位をレビューしています。",
+      "slicing": {
+        "title": "差分をチャンクに分割中…",
+        "hint": "変更されたファイルをまとまりのあるチャンクにグループ化し、各チャンクを個別にレビューできるようにしています。分割が完了すると、ここにチャンク一覧が表示されます。"
+      },
+      "reviewingChunks": {
+        "title": "チャンクをレビュー中…",
+        "hint": "分割は完了しました。各チャンクを一つずつレビューし、指摘事項を収集しています。"
+      },
       "chunks": "{total} 個中 {completed} 個のチャンクをレビュー済み",
-      "inProgress": "{count} 件処理中"
+      "inProgress": "{count} 件処理中",
+      "activeHeading": "レビュー中",
+      "chunksHeading": "チャンク",
+      "chunkStatus": {
+        "completed": "レビュー済み",
+        "in_progress": "レビュー中…",
+        "pending": "待機中"
+      }
+    },
+    "phase": {
+      "slicing": "分割中…",
+      "reviewing": "レビュー中 {completed}/{total} 区分",
+      "awaiting": "指摘の準備完了",
+      "challenging": "調査中…",
+      "fixing": "修正中…",
+      "posting": "投稿中…"
     },
     "challenge": {
       "action": "異議を唱える",

package/i18n/locales/pl.json

@@ -4931,10 +4931,31 @@
     "suggestedFix": "Sugerowana poprawka:",
     "line": "wiersz {line}",
     "reviewing": {
-      "title": "Przeglądanie pull requesta…",
-      "hint": "Dzielenie zmian na spójne części i przeglądanie każdej z nich.",
+      "slicing": {
+        "title": "Dzielenie zmian na fragmenty…",
+        "hint": "Grupowanie zmienionych plików w spójne fragmenty, aby każdy można było przejrzeć osobno. Lista fragmentów pojawi się tutaj po zakończeniu podziału."
+      },
+      "reviewingChunks": {
+        "title": "Przeglądanie fragmentów…",
+        "hint": "Podział zakończony. Przeglądanie każdego fragmentu po kolei i zbieranie uwag."
+      },
       "chunks": "Sprawdzono {completed} z {total} fragmentów",
-      "inProgress": "{count} w toku"
+      "inProgress": "{count} w toku",
+      "activeHeading": "Przeglądane teraz",
+      "chunksHeading": "Fragmenty",
+      "chunkStatus": {
+        "completed": "Sprawdzony",
+        "in_progress": "Przeglądanie…",
+        "pending": "W kolejce"
+      }
+    },
+    "phase": {
+      "slicing": "Dzielenie…",
+      "reviewing": "Przegląd {completed}/{total} fragmentów",
+      "awaiting": "Wyniki gotowe",
+      "challenging": "Analizowanie…",
+      "fixing": "Naprawianie…",
+      "posting": "Publikowanie…"
     },
     "challenge": {
       "action": "Zakwestionuj",

package/i18n/locales/tr.json

@@ -4943,10 +4943,31 @@
     "suggestedFix": "Önerilen düzeltme:",
     "line": "satır {line}",
     "reviewing": {
-      "title": "Pull request inceleniyor…",
-      "hint": "Fark tutarlı parçalara bölünüp her biri inceleniyor.",
+      "slicing": {
+        "title": "Fark parçalara bölünüyor…",
+        "hint": "Değiştirilen dosyalar, her biri ayrı ayrı incelenebilsin diye tutarlı parçalara gruplanıyor. Bölme tamamlandığında parça listesi burada görünecek."
+      },
+      "reviewingChunks": {
+        "title": "Parçalar inceleniyor…",
+        "hint": "Bölme tamamlandı. Her parça tek tek inceleniyor ve bulgular toplanıyor."
+      },
       "chunks": "{total} bölümden {completed} tanesi incelendi",
-      "inProgress": "{count} devam ediyor"
+      "inProgress": "{count} devam ediyor",
+      "activeHeading": "Şimdi inceleniyor",
+      "chunksHeading": "Parçalar",
+      "chunkStatus": {
+        "completed": "İncelendi",
+        "in_progress": "İnceleniyor…",
+        "pending": "Sırada"
+      }
+    },
+    "phase": {
+      "slicing": "Dilimleniyor…",
+      "reviewing": "İnceleniyor {completed}/{total} bölüm",
+      "awaiting": "Bulgular hazır",
+      "challenging": "Araştırılıyor…",
+      "fixing": "Düzeltiliyor…",
+      "posting": "Yayınlanıyor…"
     },
     "challenge": {
       "action": "İtiraz et",

package/i18n/locales/uk.json

@@ -4931,10 +4931,31 @@
     "suggestedFix": "Пропоноване виправлення:",
     "line": "рядок {line}",
     "reviewing": {
-      "title": "Перевірка pull request…",
-      "hint": "Поділ змін на цілісні частини та огляд кожної з них.",
+      "slicing": {
+        "title": "Поділ змін на фрагменти…",
+        "hint": "Групування змінених файлів у цілісні фрагменти, щоб кожен можна було переглянути окремо. Список фрагментів з'явиться тут після завершення поділу."
+      },
+      "reviewingChunks": {
+        "title": "Огляд фрагментів…",
+        "hint": "Поділ завершено. Кожен фрагмент переглядається по черзі, а зауваження збираються."
+      },
       "chunks": "Перевірено {completed} з {total} фрагментів",
-      "inProgress": "{count} у процесі"
+      "inProgress": "{count} у процесі",
+      "activeHeading": "Переглядається зараз",
+      "chunksHeading": "Фрагменти",
+      "chunkStatus": {
+        "completed": "Переглянуто",
+        "in_progress": "Огляд…",
+        "pending": "У черзі"
+      }
+    },
+    "phase": {
+      "slicing": "Розбиття…",
+      "reviewing": "Перевірка {completed}/{total} фрагментів",
+      "awaiting": "Результати готові",
+      "challenging": "Дослідження…",
+      "fixing": "Виправлення…",
+      "posting": "Публікація…"
     },
     "challenge": {
       "action": "Оскаржити",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cat-factory/app",
-  "version": "0.147.0",
+  "version": "0.147.2",
   "description": "Reusable Nuxt layer for the Agent Architecture Board SPA (components, stores, composables, pages). Consume it from a thin deployment app via `extends: ['@cat-factory/app']` and point it at your backend with NUXT_PUBLIC_API_BASE. See deploy/frontend for an example.",
   "repository": {
     "type": "git",