@cassiomc1/forgeloop 1.14.0 → 2.0.0-rc.4

package/src/core/diagnostic-projection.js

@@ -1,9 +1,17 @@
+import { ledgerEventsOfTypes } from "./ledger-event-collection.js";
+
 export function diagnosticEventsForTask(events, taskId) {
   return (events ?? []).filter((event) =>
     (event.event === "DIAGNOSTIC_CASE_RECORDED" || event.event === "DIAGNOSIS_RECORDED")
     && (!taskId || event.taskId === taskId));
 }
 
+export function* iterateDiagnosticEvents(events, taskId) {
+  for (const event of ledgerEventsOfTypes(events ?? [], ["DIAGNOSTIC_CASE_RECORDED", "DIAGNOSIS_RECORDED"])) {
+    if (!taskId || event.taskId === taskId) yield event;
+  }
+}
+
 function structuredProjection(event) {
   const details = event.details ?? {};
   return {
@@ -26,20 +34,29 @@ function legacyProjection(event) {
   };
 }
 
+function resolveArrayCurrentCycleDiagnostic(events, taskId, verificationCycle) {
+  const candidates = diagnosticEventsForTask(events, taskId).filter(event => {
+    const cycle = event.details?.verificationCycle;
+    return verificationCycle === null || verificationCycle === undefined || cycle === null || cycle === undefined || cycle === verificationCycle;
+  }).sort((a, b) => (a.seq ?? 0) - (b.seq ?? 0));
+  const structured = [...candidates].reverse().find(event => event.event === "DIAGNOSTIC_CASE_RECORDED");
+  const legacy = [...candidates].reverse().find(event => event.event === "DIAGNOSIS_RECORDED");
+  return structured ? structuredProjection(structured) : (legacy ? legacyProjection(legacy) : null);
+}
+
 export function resolveCurrentCycleDiagnostic(events, taskId, verificationCycle) {
-  const candidates = diagnosticEventsForTask(events, taskId)
-    .filter((event) => {
-      const cycle = event.details?.verificationCycle;
-      return (verificationCycle === null || verificationCycle === undefined)
-        || (cycle === null || cycle === undefined)
-        || cycle === verificationCycle;
-    })
-    .sort((a, b) => (a.seq ?? 0) - (b.seq ?? 0));
-
-  const structured = [...candidates].reverse().find((event) => event.event === "DIAGNOSTIC_CASE_RECORDED");
+  if (Array.isArray(events)) return resolveArrayCurrentCycleDiagnostic(events, taskId, verificationCycle);
+  let structured = null;
+  let legacy = null;
+  for (const event of iterateDiagnosticEvents(events, taskId)) {
+    const cycle = event.details?.verificationCycle;
+    if (verificationCycle !== null && verificationCycle !== undefined
+      && cycle !== null && cycle !== undefined && cycle !== verificationCycle) continue;
+    if (event.event === "DIAGNOSTIC_CASE_RECORDED") {
+      if (!structured || (event.seq ?? 0) >= (structured.seq ?? 0)) structured = event;
+    } else if (!legacy || (event.seq ?? 0) >= (legacy.seq ?? 0)) legacy = event;
+  }
   if (structured) return structuredProjection(structured);
-
-  const legacy = [...candidates].reverse().find((event) => event.event === "DIAGNOSIS_RECORDED");
   if (legacy) return legacyProjection(legacy);
 
   return null;

package/src/core/diagnostic-record.js

@@ -1,5 +1,6 @@
 import { appendProtocolEvent, validateEventLedger } from "./events.js";
 import { readWorkState, mutateWorkState } from "./work-state.js";
+import { getTaskTransaction, withTaskTransaction } from "./transaction.js";
 import {
   DIAGNOSTIC_SCHEMA_VERSION,
   DISPOSITION_TRANSITIONS,
@@ -80,7 +81,15 @@ export function legacyDiagnosisToDiagnosticCase(diagnosisDetails) {
   };
 }
 
-export async function recordStructuredDiagnosticCase({
+export async function recordStructuredDiagnosticCase(options) {
+  if (await getTaskTransaction(options.target)) return recordDiagnosticCase(options);
+  const state = await readWorkState(options.target, { packageRoot: options.packageRoot, taskId: options.taskId });
+  if (!state) return recordDiagnosticCase(options);
+  return withTaskTransaction({ target: options.target, taskId: options.taskId ?? state.taskId,
+    packageRoot: options.packageRoot, operation: "record-diagnostic-case" }, () => recordDiagnosticCase(options));
+}
+
+async function recordDiagnosticCase({
   target,
   packageRoot,
   caseFile = null,
@@ -218,7 +227,15 @@ export async function recordStructuredDiagnosticCase({
   return { event, state: updatedState, diagnosticCase: details, idempotent: false };
 }
 
-export async function recordIntervention({
+export async function recordIntervention(options) {
+  if (await getTaskTransaction(options.target)) return recordInterventionInternal(options);
+  const state = await readWorkState(options.target, { packageRoot: options.packageRoot, taskId: options.taskId });
+  if (!state) return recordInterventionInternal(options);
+  return withTaskTransaction({ target: options.target, taskId: options.taskId ?? state.taskId,
+    packageRoot: options.packageRoot, operation: "record-intervention" }, () => recordInterventionInternal(options));
+}
+
+async function recordInterventionInternal({
   target,
   packageRoot,
   interventionFile = null,
@@ -303,7 +320,15 @@ export async function recordIntervention({
   };
 }
 
-export async function recordHypothesisDisposition({
+export async function recordHypothesisDisposition(options) {
+  if (await getTaskTransaction(options.target)) return recordDisposition(options);
+  const state = await readWorkState(options.target, { packageRoot: options.packageRoot, taskId: options.taskId });
+  if (!state) return recordDisposition(options);
+  return withTaskTransaction({ target: options.target, taskId: options.taskId ?? state.taskId,
+    packageRoot: options.packageRoot, operation: "record-hypothesis-disposition" }, () => recordDisposition(options));
+}
+
+async function recordDisposition({
   target,
   packageRoot,
   hypothesisRef,

package/src/core/efficiency.js

@@ -4,6 +4,7 @@ import { assertSafePath, ensureWithin } from "./filesystem.js";
 import { readContract } from "./contract.js";
 import { currentRepositoryFingerprint } from "./repository.js";
 import { buildTrajectoryMetrics } from "./trajectory-metrics.js";
+import { withProjectReadSnapshot } from "../storage/project-read-snapshot.js";
 
 function efficiencyError(code, message) {
   const error = new Error(message);
@@ -92,7 +93,11 @@ export async function readEfficiencyBaseline(target, baselinePath) {
   }
 }
 
-export async function buildEfficiencyReport({ target, packageRoot, taskId, baselinePath = null, runtimeContext = null } = {}) {
+export async function buildEfficiencyReport(options = {}) {
+  return withProjectReadSnapshot(options.target, () => projectEfficiencyReport(options));
+}
+
+async function projectEfficiencyReport({ target, packageRoot, taskId, baselinePath = null, runtimeContext = null } = {}) {
   const metrics = await buildTrajectoryMetrics({ target, packageRoot, taskId, runtimeContext });
   const repository = await currentRepositoryFingerprint(target);
   let promptSpecFingerprint = null;