@cassiomc1/forgeloop 1.13.0 → 1.14.0

package/src/core/decision/result.js

@@ -0,0 +1,58 @@
+import { PINNED_JEV_MODEL } from "./constants.js";
+import { DECISION_ERROR_CODES, decisionError } from "./errors.js";
+import { normalizeCanonicalDecision } from "./normalizers/index.js";
+
+function finite(value) { return typeof value === "number" && Number.isFinite(value); }
+
+function normalizeAnswer(value) {
+  if (value === null || typeof value === "string" || typeof value === "boolean" || finite(value)) return value;
+  if (value && typeof value === "object" && !Array.isArray(value)) {
+    const result = {};
+    for (const [key, child] of Object.entries(value)) result[key] = normalizeAnswer(child);
+    return result;
+  }
+  if (Array.isArray(value)) return value.slice(0, 64).map(normalizeAnswer);
+  throw decisionError(DECISION_ERROR_CODES.RESULT_INVALID, "Semantic decision answer has an unsupported shape.");
+}
+
+function normalizeAnswers(rawAnswers, questionSet) {
+  return Object.fromEntries(Object.keys(questionSet.questions).map((key) => {
+    if (!Object.prototype.hasOwnProperty.call(rawAnswers, key)) {
+      throw decisionError(DECISION_ERROR_CODES.RESULT_INVALID, `Semantic decision result is missing answer ${key}.`);
+    }
+    return [key, normalizeAnswer(rawAnswers[key])];
+  }));
+}
+
+function normalizeConfidence(confidence, questionSet) {
+  if (!confidence || typeof confidence !== "object" || Array.isArray(confidence)) {
+    throw decisionError(DECISION_ERROR_CODES.RESULT_INVALID, "Semantic decision result confidence is invalid.");
+  }
+  return Object.fromEntries(Object.keys(questionSet.questions).map((key) => [key, confidence[key] ?? null]));
+}
+
+function normalizeUsage(raw) {
+  const inputTokens = raw?.input_tokens ?? raw?.inputTokens;
+  const outputTokens = raw?.output_tokens ?? raw?.outputTokens;
+  if (!Number.isInteger(inputTokens) || inputTokens < 0 || !Number.isInteger(outputTokens) || outputTokens < 0) {
+    throw decisionError(DECISION_ERROR_CODES.RESULT_INVALID, "Semantic decision result usage is invalid.");
+  }
+  return { inputTokens, outputTokens, reportedBy: "PROVIDER" };
+}
+
+export function normalizeDecisionResult(raw, { questionSet, input = {}, model = PINNED_JEV_MODEL } = {}) {
+  if (!raw || typeof raw !== "object" || Array.isArray(raw)) throw decisionError(DECISION_ERROR_CODES.RESULT_INVALID, "Semantic decision result must be an object.");
+  if (raw.model !== model || raw.model !== PINNED_JEV_MODEL) throw decisionError(DECISION_ERROR_CODES.MODEL_UNSUPPORTED, "Semantic decision result used an unsupported model.");
+  if (!raw.answers || typeof raw.answers !== "object" || Array.isArray(raw.answers)) throw decisionError(DECISION_ERROR_CODES.RESULT_INVALID, "Semantic decision result is missing answers.");
+  const answers = normalizeAnswers(raw.answers, questionSet);
+  const confidence = normalizeConfidence(raw.confidence, questionSet);
+  const usage = normalizeUsage(raw.usage);
+  return {
+    model,
+    questionSetId: questionSet?.id ?? null,
+    answers,
+    confidence: Object.fromEntries(Object.keys(questionSet.questions).map((key) => [key, confidence[key] ?? null])),
+    decision: normalizeCanonicalDecision({ questionSet, answers, confidence, input }),
+    usage,
+  };
+}

package/src/core/decision/service.js

@@ -0,0 +1,156 @@
+import { canonicalFingerprint } from "../artifacts.js";
+import { readConfig } from "../config.js";
+import { appendProtocolEvent, readEvents } from "../events.js";
+import { withTaskMutation } from "../task-command.js";
+import { DECISION_DEFAULT_POLICY, PINNED_JEV_MODEL, SEMANTIC_DECISION_RECORDED_EVENT } from "./constants.js";
+import { buildDecisionArtifact, decisionArtifactFingerprint, readDecisionArtifact, writeDecisionArtifact } from "./artifact.js";
+import { decisionEventDetails, decisionSupersededEventDetails } from "./events.js";
+import { createTypesafeEngine } from "../../adapters/typesafe/engine.js";
+import { normalizeDecisionPolicy, decisionPolicyFingerprint } from "./policy.js";
+import { validateDecisionRequest } from "./request.js";
+import { normalizeDecisionResult } from "./result.js";
+import { randomUUID } from "node:crypto";
+import { readCurrentDecisionBindings } from "./task-bindings.js";
+import { resolveRequiredSemanticDecision } from "./resolver.js";
+import { DECISION_ERROR_CODES, decisionError } from "./errors.js";
+import { getTaskTransaction } from "../transaction.js";
+import { getTestSemanticProvider } from "./test-provider.js";
+
+function resolveProvider(provider) {
+  return provider ?? getTestSemanticProvider();
+}
+
+async function loadPolicy(target, packageRoot) {
+  try {
+    const config = await readConfig(target, packageRoot);
+    return normalizeDecisionPolicy(config.decisionEngine ?? DECISION_DEFAULT_POLICY);
+  } catch (error) {
+    if (error.code === "ARTIFACT_MISSING") return normalizeDecisionPolicy(DECISION_DEFAULT_POLICY);
+    throw error;
+  }
+}
+
+async function readCachedDecision({ target, packageRoot, taskId, decisionKind, currentBindings }) {
+  try {
+    return await resolveRequiredSemanticDecision({ target, packageRoot, taskId, decisionKind, currentBindings });
+  } catch (error) {
+    if (["E_DECISION_REQUIRED", "E_DECISION_STALE", "E_DECISION_BINDING_INVALID"].includes(error.code)) return null;
+    throw error;
+  }
+}
+
+function buildArtifact({ taskId, decisionId, policy, validated, result, request, taskBindings }) {
+  return buildDecisionArtifact({
+    taskId,
+    decisionId,
+    decisionKind: validated.decisionKind,
+    model: result.model ?? PINNED_JEV_MODEL,
+    questionSetId: validated.questionSet.id,
+    questionSetVersion: validated.questionSet.version,
+    questionSetFingerprint: validated.questionSet.fingerprint,
+    questionSet: validated.questionSet,
+    stateFingerprint: canonicalFingerprint(validated.state),
+    taskStateFingerprint: canonicalFingerprint(validated.state.lifecycle),
+    semanticStateFingerprint: canonicalFingerprint(validated.state.semantic),
+    policyVersion: policy.policyVersion,
+    policyFingerprint: decisionPolicyFingerprint(policy),
+    repositoryFingerprint: request.repositoryFingerprint ?? taskBindings.repositoryFingerprint,
+    contractFingerprint: request.contractFingerprint ?? taskBindings.contractFingerprint,
+    routeFingerprint: request.routeFingerprint ?? taskBindings.routeFingerprint,
+    verificationCycle: request.verificationCycle ?? taskBindings.verificationCycle,
+    candidateSetFingerprint: request.candidateSetFingerprint,
+    answers: result.answers,
+    confidence: result.confidence ?? {},
+    decision: result.decision,
+    usage: result.usage,
+    latencyMs: result.latencyMs ?? null,
+  });
+}
+
+async function readCachedSemanticDecision({ policy, decisionId, target, taskId, packageRoot, validated, taskBindings, request }) {
+  if (!policy.cache || decisionId || !target || !taskId || await getTaskTransaction(target)) return null;
+  return readCachedDecision({
+    target,
+    packageRoot,
+    taskId,
+    decisionKind: validated.decisionKind,
+    currentBindings: {
+      ...taskBindings,
+      stateFingerprint: canonicalFingerprint(validated.state),
+      taskStateFingerprint: canonicalFingerprint(validated.state.lifecycle),
+      semanticStateFingerprint: canonicalFingerprint(validated.state.semantic),
+      questionSetFingerprint: validated.questionSet.fingerprint,
+      policyFingerprint: decisionPolicyFingerprint(policy),
+      model: PINNED_JEV_MODEL,
+      ...(request?.candidateSetFingerprint !== undefined ? { candidateSetFingerprint: request.candidateSetFingerprint } : {}),
+      ...(request?.policyFingerprint !== undefined ? { policyFingerprint: request.policyFingerprint } : {}),
+    },
+  });
+}
+
+async function persistDecision(target, packageRoot, resolvedDecisionId, artifact, ctx) {
+  await writeDecisionArtifact(target, ctx.taskId, resolvedDecisionId, artifact, packageRoot, { taskId: ctx.taskId, operation: "semantic-decision" });
+  const priorEvents = await readEvents(target, packageRoot, { taskId: ctx.taskId });
+  const event = await appendProtocolEvent(target, { taskId: ctx.taskId, event: SEMANTIC_DECISION_RECORDED_EVENT, details: decisionEventDetails(artifact) }, packageRoot, { taskId: ctx.taskId });
+  const previous = priorEvents.findLast((candidate) => candidate.event === SEMANTIC_DECISION_RECORDED_EVENT
+    && candidate.taskId === ctx.taskId
+    && candidate.details?.decisionKind === artifact.decisionKind
+    && !priorEvents.some((superseded) => superseded.event === "SEMANTIC_DECISION_SUPERSEDED"
+      && superseded.details?.decisionId === candidate.details?.decisionId));
+  if (!previous) return { artifact, artifactFingerprint: decisionArtifactFingerprint(artifact), event, supersededEvent: null };
+  const previousArtifact = await readDecisionArtifact(target, ctx.taskId, previous.details.decisionId, packageRoot);
+  const supersededEvent = await appendProtocolEvent(target, {
+    taskId: ctx.taskId,
+    event: "SEMANTIC_DECISION_SUPERSEDED",
+    details: decisionSupersededEventDetails(previousArtifact.value, resolvedDecisionId),
+  }, packageRoot, { taskId: ctx.taskId });
+  return { artifact, artifactFingerprint: decisionArtifactFingerprint(artifact), event, supersededEvent };
+}
+
+export async function recordSemanticDecision({ target, packageRoot, taskId, decisionId, request, provider = null } = {}) {
+  const resolvedDecisionId = decisionId ?? `${String(request?.decisionKind ?? "decision").toLowerCase()}-${Date.now()}-${randomUUID().slice(0, 8)}`;
+  const policy = await loadPolicy(target, packageRoot);
+  const taskBindings = target && taskId ? await readCurrentDecisionBindings(target, packageRoot, taskId) : {};
+  const validated = validateDecisionRequest({
+    ...request,
+    taskId,
+    state: { lifecycle: taskBindings.state ?? {}, semantic: request?.state ?? {} },
+  });
+  const cached = await readCachedSemanticDecision({ policy, decisionId, target, taskId, packageRoot, validated, taskBindings, request });
+  if (cached) return { artifact: cached, artifactFingerprint: decisionArtifactFingerprint(cached), event: null, supersededEvent: null, cached: true, policy };
+  const engine = resolveProvider(provider) ?? createTypesafeEngine({ policy });
+  if (provider && (provider.id !== "typesafe-jev" || provider.model !== PINNED_JEV_MODEL || typeof provider.evaluate !== "function")) {
+    throw decisionError(DECISION_ERROR_CODES.MODEL_UNSUPPORTED, "Semantic decision provider must be the pinned ForgeLoop Jev engine.");
+  }
+  const result = normalizeDecisionResult(await engine.evaluate(validated), { questionSet: validated.questionSet, input: validated });
+  const artifact = buildArtifact({ taskId, decisionId: resolvedDecisionId, policy, validated, result, request, taskBindings });
+  const persisted = await withTaskMutation(target, { taskId, packageRoot }, "semantic-decision", (ctx) => persistDecision(target, packageRoot, resolvedDecisionId, artifact, ctx), { explicitRequired: true });
+  return { ...persisted, policy };
+}
+
+export async function ensureSemanticDecision({ target, packageRoot, taskId, decisionId, request, provider = null, allowNetwork = true } = {}) {
+  const policy = await loadPolicy(target, packageRoot);
+  const taskBindings = await readCurrentDecisionBindings(target, packageRoot, taskId);
+  const validated = validateDecisionRequest({
+    ...request,
+    taskId,
+    state: { lifecycle: taskBindings.state ?? {}, semantic: request?.state ?? {} },
+  });
+  const currentBindings = {
+    ...taskBindings,
+    stateFingerprint: canonicalFingerprint(validated.state),
+    taskStateFingerprint: canonicalFingerprint(validated.state.lifecycle),
+    semanticStateFingerprint: canonicalFingerprint(validated.state.semantic),
+    questionSetFingerprint: validated.questionSet.fingerprint,
+    policyFingerprint: decisionPolicyFingerprint(policy),
+    model: PINNED_JEV_MODEL,
+    ...(request?.candidateSetFingerprint !== undefined ? { candidateSetFingerprint: request.candidateSetFingerprint } : {}),
+  };
+  const cached = await getTaskTransaction(target) ? null : await readCachedDecision({
+    target, packageRoot, taskId, decisionKind: validated.decisionKind,
+    currentBindings,
+  });
+  if (cached) return { artifact: cached, artifactFingerprint: decisionArtifactFingerprint(cached), cached: true, policy };
+  if (!allowNetwork && !provider) throw decisionError(DECISION_ERROR_CODES.REQUIRED, `A current ${validated.decisionKind} decision is required.`);
+  return recordSemanticDecision({ target, packageRoot, taskId, decisionId, request: { ...request, questionSet: validated.questionSet }, provider });
+}

package/src/core/decision/state-builder.js

@@ -0,0 +1,65 @@
+import { Buffer } from "node:buffer";
+import { DECISION_LIMITS } from "./constants.js";
+import { DECISION_ERROR_CODES, decisionError } from "./errors.js";
+
+const SECRET_KEY = /(^|[_-])(api[_-]?key|password|passwd|secret|token|refresh|cookie|authorization|private[_-]?key|credential|database[_-]?url|connection[_-]?string|access[_-]?key|client[_-]?secret)([_-]|$)/i;
+const SECRET_VALUE = /^(?:bearer\s+)?(?:sk-|pk-|ghp_|github_pat_|xox[baprs]-|AIza|AKIA)[A-Za-z0-9._-]{12,}$/i;
+
+function isHomePath(value) {
+  return typeof value === "string" && (/^\/Users\/[^/]+\//.test(value) || /^\/home\/[^/]+\//.test(value));
+}
+
+function sanitize(value, depth, counters) {
+  if (depth > DECISION_LIMITS.maxDepth) throw decisionError(DECISION_ERROR_CODES.STATE_LIMIT, "Decision state nesting exceeds the supported limit.");
+  if (value === null || typeof value === "boolean" || typeof value === "number") return value;
+  if (typeof value === "string") {
+    if (/[^\x09\x0A\x0D\x20-\uD7FF\uE000-\uFFFD]/u.test(value)) throw decisionError(DECISION_ERROR_CODES.STATE_UNSAFE, "Decision state contains unsafe control characters.");
+    if (SECRET_VALUE.test(value)) throw decisionError(DECISION_ERROR_CODES.STATE_UNSAFE, "Decision state contains a secret-like value.");
+    if (isHomePath(value)) return "<redacted-user-path>";
+    counters.bytes += Buffer.byteLength(value);
+    if (value.length > DECISION_LIMITS.maxStringChars) return `${value.slice(0, DECISION_LIMITS.maxStringChars)}…<truncated>`;
+    return value;
+  }
+  if (Array.isArray(value)) {
+    if (value.length > DECISION_LIMITS.maxItems) throw decisionError(DECISION_ERROR_CODES.STATE_LIMIT, "Decision state contains too many items.");
+    return value.map((item) => sanitize(item, depth + 1, counters));
+  }
+  if (typeof value === "object") {
+    const entries = Object.entries(value);
+    if (entries.length > DECISION_LIMITS.maxItems) throw decisionError(DECISION_ERROR_CODES.STATE_LIMIT, "Decision state contains too many fields.");
+    const result = {};
+    for (const [key, child] of entries) {
+      if (SECRET_KEY.test(key) || key.toLowerCase() === "env" || key.toLowerCase() === "environment") continue;
+      result[key] = sanitize(child, depth + 1, counters);
+    }
+    return result;
+  }
+  throw decisionError(DECISION_ERROR_CODES.STATE_UNSAFE, "Decision state contains an unsupported value.");
+}
+
+export function buildDecisionState(value) {
+  const counters = { bytes: 0 };
+  const sanitized = sanitize(value, 0, counters);
+  const bytes = Buffer.byteLength(JSON.stringify(sanitized));
+  if (bytes > DECISION_LIMITS.maxStateBytes) throw decisionError(DECISION_ERROR_CODES.STATE_LIMIT, "Decision state exceeds the supported byte limit.");
+  return sanitized;
+}
+
+export function buildLifecycleDecisionState(value = {}) {
+  return buildDecisionState(value ?? {});
+}
+
+export function buildSemanticDecisionState(value = {}) {
+  return buildDecisionState(value ?? {});
+}
+
+export function buildCombinedDecisionState({ lifecycle = {}, semantic = {} } = {}) {
+  return {
+    lifecycle: buildLifecycleDecisionState(lifecycle),
+    semantic: buildSemanticDecisionState(semantic),
+  };
+}
+
+export function decisionStateFingerprint(value, canonicalFingerprint) {
+  return canonicalFingerprint(buildDecisionState(value));
+}

package/src/core/decision/task-bindings.js

@@ -0,0 +1,30 @@
+import { canonicalFingerprint } from "../artifacts.js";
+import { readContract } from "../contract.js";
+import { readPersistedRoute } from "../route-artifact.js";
+import { readWorkState } from "../work-state.js";
+
+async function readOptionalArtifact(reader) {
+  try {
+    return await reader();
+  } catch (error) {
+    if (error.code === "ARTIFACT_MISSING") return null;
+    throw error;
+  }
+}
+
+export async function readCurrentDecisionBindings(target, packageRoot, taskId, { candidateSetFingerprint, policyFingerprint } = {}) {
+  const state = await readWorkState(target, { packageRoot, taskId });
+  const contract = await readOptionalArtifact(() => readContract(target, packageRoot, { taskId }));
+  const route = await readOptionalArtifact(() => readPersistedRoute(target, packageRoot, { taskId }));
+  return {
+    state,
+    ...(state ? { stateFingerprint: canonicalFingerprint(state) } : {}),
+    ...(state ? { taskStateFingerprint: canonicalFingerprint(state) } : {}),
+    ...(state?.repositoryFingerprint ? { repositoryFingerprint: state.repositoryFingerprint } : {}),
+    ...((contract?.fingerprint ?? state?.contractFingerprint) ? { contractFingerprint: contract?.fingerprint ?? state.contractFingerprint } : {}),
+    ...((route?.fingerprint ?? state?.routeFingerprint) ? { routeFingerprint: route?.fingerprint ?? state.routeFingerprint } : {}),
+    ...(state?.verificationCycle !== undefined ? { verificationCycle: state.verificationCycle } : {}),
+    ...(candidateSetFingerprint !== undefined ? { candidateSetFingerprint } : {}),
+    ...(policyFingerprint !== undefined ? { policyFingerprint } : {}),
+  };
+}

package/src/core/decision/test-provider.js

@@ -0,0 +1,32 @@
+// This provider is deliberately reachable only through repository test injection.
+// Production commands always use the pinned TypeSafe Jev engine or fail closed.
+export const testSemanticProvider = Object.freeze({
+  id: "typesafe-jev",
+  model: "jev-1.13.0",
+  async evaluate(request) {
+    const answers = Object.fromEntries(Object.entries(request.questionSet.questions).map(([name, question]) => [
+      name,
+      question.type === "choice" ? Object.keys(question.criteria)[0] : { noul: true },
+    ]));
+    return {
+      model: "jev-1.13.0",
+      answers,
+      confidence: Object.fromEntries(Object.keys(answers).map((name) => [name, 0.95])),
+      usage: { inputTokens: 0, outputTokens: 0 },
+    };
+  },
+});
+
+let activeTestSemanticProvider = null;
+
+export function installTestSemanticProvider(provider = testSemanticProvider) {
+  activeTestSemanticProvider = provider;
+}
+
+export function clearTestSemanticProvider() {
+  activeTestSemanticProvider = null;
+}
+
+export function getTestSemanticProvider() {
+  return activeTestSemanticProvider;
+}

package/src/core/decision/thresholds.js

@@ -0,0 +1,15 @@
+export const DECISION_RISK_TIERS = Object.freeze(["LOW_RISK", "NORMAL", "HIGH_RISK", "CRITICAL"]);
+export const DECISION_THRESHOLDS = Object.freeze({
+  LOW_RISK: 0.65,
+  NORMAL: 0.75,
+  HIGH_RISK: 0.9,
+  CRITICAL: 0.97,
+});
+
+export function decisionConfidenceThreshold(risk = "NORMAL") {
+  return DECISION_THRESHOLDS[risk] ?? DECISION_THRESHOLDS.NORMAL;
+}
+
+export function requiresEscalation(confidence, risk = "NORMAL") {
+  return typeof confidence !== "number" || confidence < decisionConfidenceThreshold(risk);
+}