@caspeco/eslint-config-react 5.4.1 → 5.5.0-beta.0

package/README.md

@@ -72,8 +72,7 @@ This configuration includes everything from our TypeScript config plus React-spe
 
 This package requires the following peer dependencies (automatically installed by npm 7+):
 
-- `eslint`
-- `eslint-plugin-react`
+- `eslint` (9 or 10)
 - `eslint-plugin-react-hooks`
 - `eslint-plugin-react-refresh`
 - `globals`
@@ -82,6 +81,16 @@ See [package.json](./package.json) for specific version requirements.
 
 **Note:** Additional TypeScript-related peer dependencies are inherited from `@caspeco/eslint-config-ts` (installed automatically as a regular dependency).
 
+`eslint-plugin-react` is a regular dependency, not a peer. It has no release that supports ESLint 10 yet, so this package patches it with `fixupRule` from `@eslint/compat`.
+
+### ESLint 10
+
+- Remove `eslint-plugin-react` from your own `package.json`, or npm fails with `ERESOLVE`.
+- npm prints `npm warn ERESOLVE overriding peer dependency` for `eslint-plugin-react`. The install succeeds and linting works.
+- Installs with strict peer dependencies (e.g. pnpm `strict-peer-dependencies`) fail until `eslint-plugin-react` supports ESLint 10.
+- Use `@eslint/js` 10 with ESLint 10. Its `recommended` adds `no-useless-assignment`, `no-unassigned-vars` and `preserve-caught-error`.
+- On ESLint 9, keep `@eslint/js` on `^9`. A fresh install without a lockfile otherwise picks `@eslint/js` 10.
+
 ## Plugins
 
 ### eslint-plugin-react

package/dist/create-config.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"create-config.d.ts","sourceRoot":"","sources":["../src/create-config.js"],"names":[],"mappings":"AAOA;;;;;;;GAOG;AACH,kDAHG;IAAqD,eAAe,EAA5D,OAAO,QAAQ,EAAE,MAAM,CAAC,WAAW;CAC3C,GAAU,OAAO,mBAAmB,EAAE,WAAW,CA4DnD"}
+{"version":3,"file":"create-config.d.ts","sourceRoot":"","sources":["../src/create-config.js"],"names":[],"mappings":"AAiBA;;;;;;;GAOG;AACH,kDAHG;IAAqD,eAAe,EAA5D,OAAO,QAAQ,EAAE,MAAM,CAAC,WAAW;CAC3C,GAAU,OAAO,mBAAmB,EAAE,WAAW,CA4DnD"}

package/dist/plugins/caspeco-react.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"caspeco-react.d.ts","sourceRoot":"","sources":["../../src/plugins/caspeco-react.js"],"names":[],"mappings":";mBACa,OAAO,QAAQ,EAAE,IAAI,CAAC,UAAU;AAD7C;;GAEG;AAEH;;GAEG;AACH,uBAFU;IAAE,KAAK,EAAE;QAAE,CAAC,GAAG,EAAE,MAAM,GAAG,IAAI,CAAA;KAAE,CAAA;CAAE,CAqC1C"}
+{"version":3,"file":"caspeco-react.d.ts","sourceRoot":"","sources":["../../src/plugins/caspeco-react.js"],"names":[],"mappings":";mBACa,OAAO,QAAQ,EAAE,IAAI,CAAC,UAAU;AAD7C;;GAEG;AAEH;;GAEG;AACH,uBAFU;IAAE,KAAK,EAAE;QAAE,CAAC,GAAG,EAAE,MAAM,GAAG,IAAI,CAAA;KAAE,CAAA;CAAE,CAoC1C"}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@caspeco/eslint-config-react",
-	"version": "5.4.1",
+	"version": "5.5.0-beta.0",
 	"description": "Caspeco ESLint configuration for React projects",
 	"keywords": [
 		"eslint",
@@ -45,24 +45,24 @@
 		"build": "tsc --project tsconfig.build.json",
 		"check:types": "attw --pack . --ignore-rules=cjs-resolves-to-esm --profile node16",
 		"prepublishOnly": "npm run build",
-		"test": "vitest"
+		"test": "vitest --config ../../vitest.config.ts"
 	},
 	"dependencies": {
-		"@caspeco/eslint-config-ts": "5.4.1"
+		"@caspeco/eslint-config-ts": "5.5.0-beta.0",
+		"@eslint/compat": "^2.1.1",
+		"eslint-plugin-react": "^7.37.5"
 	},
 	"devDependencies": {
 		"@caspeco/test-utils": "*",
-		"eslint": "^9.39.4",
-		"eslint-plugin-react": "^7.37.5",
+		"eslint": "^10.13.0",
 		"eslint-plugin-react-hooks": "^7.1.1",
-		"eslint-plugin-react-refresh": "^0.5.2",
-		"globals": "^17.5.0"
+		"eslint-plugin-react-refresh": "^0.5.7",
+		"globals": "^17.13.0"
 	},
 	"peerDependencies": {
-		"eslint": "^9.39.4",
-		"eslint-plugin-react": "^7.37.5",
+		"eslint": "^9.39.4 || ^10.0.0",
 		"eslint-plugin-react-hooks": "^7.0.1",
-		"eslint-plugin-react-refresh": "^0.5.2",
+		"eslint-plugin-react-refresh": "^0.5.4",
 		"globals": "^17.4.0"
 	},
 	"publishConfig": {

package/src/create-config.js

@@ -1,3 +1,4 @@
+import { fixupRule } from "@eslint/compat";
 import tsConfig from "@caspeco/eslint-config-ts";
 import reactRefresh from "eslint-plugin-react-refresh";
 import reactPlugin from "eslint-plugin-react";
@@ -5,6 +6,15 @@ import reactHooksPlugin from "eslint-plugin-react-hooks";
 import caspecoReactPlugin from "./plugins/caspeco-react.js";
 import globals from "globals";
 
+// eslint-plugin-react calls rule context and SourceCode methods that ESLint 10
+// removed. Patched in place rather than with `fixupPluginRules`, which returns
+// a copy: `configs.flat.recommended` registers the original object, and two
+// different objects under "react" fail with `Cannot redefine plugin "react"`.
+const reactRules = /** @type {Record<string, any>} */ (reactPlugin.rules);
+for (const [name, rule] of Object.entries(reactRules)) {
+	reactRules[name] = fixupRule(rule);
+}
+
 /**
  * Builds the Caspeco React flat config. The only part that varies between the
  * default and the React Compiler opt-in config is the set of `react-hooks` rules.

package/src/plugins/caspeco-react.js

@@ -13,7 +13,6 @@ const caspeco = {
 				docs: {
 					description:
 						'Discourage importing anything from "@chakra-ui/*". Use imports from "@caspeco/casper-ui-library" instead.',
-					category: "Best Practices",
 					url: "https://caspeco.github.io/eslint-config/#/plugins/caspeco?id=caspecodiscourage-chakra-import",
 					recommended: false,
 				},