@caseyharalson/orrery 0.13.0 → 0.13.1

package/lib/orchestration/agent-invoker.js

@@ -251,14 +251,28 @@ function createDefaultResult(stepId, exitCode, stderr) {
 }
 
 /**
- * Check if an error condition should trigger failover to another agent
+ * Check if agent stdout contains valid structured output (indicating a
+ * legitimate task-level result rather than an infrastructure failure).
+ * @param {string} stdout - Raw stdout from agent
+ * @returns {boolean}
+ */
+function hasValidAgentOutput(stdout) {
+  if (!stdout) return false;
+  const results = parseAgentResults(stdout);
+  return results.length > 0;
+}
+
+/**
+ * Check if an error condition should trigger failover to another agent.
+ * Failover triggers on any non-zero exit unless the agent produced valid
+ * structured output (indicating a legitimate task-level failure, not an
+ * infrastructure issue).
  * @param {Object} result - Process result with exitCode, stdout, stderr
  * @param {Error} spawnError - Error from spawn (if any)
  * @param {boolean} timedOut - Whether the process timed out
- * @param {Object} errorPatterns - Regex patterns for error detection
  * @returns {{shouldFailover: boolean, reason: string}}
  */
-function shouldTriggerFailover(result, spawnError, timedOut, errorPatterns) {
+function shouldTriggerFailover(result, spawnError, timedOut) {
   // 1. Spawn failures (command not found, ENOENT)
   if (spawnError) {
     if (spawnError.code === "ENOENT") {
@@ -272,23 +286,12 @@ function shouldTriggerFailover(result, spawnError, timedOut, errorPatterns) {
     return { shouldFailover: true, reason: "timeout" };
   }
 
-  // 3. Non-zero exit with error patterns in stderr (but NOT legitimate blocked)
+  // 3. Non-zero exit — failover unless agent produced valid structured output
   if (result && result.exitCode !== 0) {
-    const stderr = result.stderr || "";
-
-    // Check API error patterns
-    for (const pattern of errorPatterns.apiError || []) {
-      if (pattern.test(stderr)) {
-        return { shouldFailover: true, reason: "api_error" };
-      }
-    }
-
-    // Check token limit patterns
-    for (const pattern of errorPatterns.tokenLimit || []) {
-      if (pattern.test(stderr)) {
-        return { shouldFailover: true, reason: "token_limit" };
-      }
+    if (hasValidAgentOutput(result.stdout)) {
+      return { shouldFailover: false, reason: null };
     }
+    return { shouldFailover: true, reason: "agent_error" };
   }
 
   return { shouldFailover: false, reason: null };
@@ -513,8 +516,7 @@ function invokeAgentWithFailover(
         const { shouldFailover, reason } = shouldTriggerFailover(
           result,
           null,
-          result.timedOut,
-          failoverConfig.errorPatterns || {}
+          result.timedOut
         );
 
         if (shouldFailover && i < availableAgents.length - 1) {
@@ -535,8 +537,7 @@ function invokeAgentWithFailover(
         const { shouldFailover, reason } = shouldTriggerFailover(
           null,
           spawnError,
-          false,
-          failoverConfig.errorPatterns || {}
+          false
         );
 
         if (shouldFailover && i < availableAgents.length - 1) {
@@ -595,6 +596,7 @@ module.exports = {
   invokeAgentWithFailover,
   parseAgentResults,
   createDefaultResult,
+  shouldTriggerFailover,
   waitForAll,
   waitForAny
 };

package/lib/orchestration/config.js

@@ -146,30 +146,7 @@ module.exports = {
 
     // Timeout in milliseconds before trying next agent (15 minutes)
     // Can be overridden via ORRERY_AGENT_TIMEOUT environment variable
-    timeoutMs: 900000,
-
-    // Patterns to detect failover-triggering errors from stderr
-    errorPatterns: {
-      // API/connection errors
-      apiError: [
-        /API error/i,
-        /connection refused/i,
-        /ECONNRESET/i,
-        /ETIMEDOUT/i,
-        /network error/i,
-        /rate limit/i,
-        /429/,
-        /502/,
-        /503/
-      ],
-      // Token/context limit errors
-      tokenLimit: [
-        /token limit/i,
-        /context.*(limit|length|exceeded)/i,
-        /maximum.*tokens/i,
-        /too long/i
-      ]
-    }
+    timeoutMs: 900000
   },
 
   // Concurrency control

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@caseyharalson/orrery",
-  "version": "0.13.0",
+  "version": "0.13.1",
   "description": "Workflow planning and orchestration CLI for AI agents",
   "license": "MIT",
   "author": "Casey Haralson",