@carto/ps-react-ui 4.24.0 → 4.25.0

package/src/widgets-v2/category/category-ui.test.tsx

@@ -814,4 +814,143 @@ describe('<CategoryUI>', () => {
       fills.forEach((f) => expect(f.style.backgroundColor).toBe(DIM))
     })
   })
+
+  // ── Signed values ──────────────────────────────────────────────────
+  describe('negative values', () => {
+    const MIXED = [
+      [
+        { name: 'Income', value: 0.8 },
+        { name: 'Transit', value: -0.4 },
+        { name: 'Size', value: 0 },
+      ],
+    ]
+    const fills = (c: HTMLElement) =>
+      Array.from(c.querySelectorAll<HTMLElement>('[data-bar-fill="true"]'))
+    const ticks = (c: HTMLElement) =>
+      Array.from(c.querySelectorAll<HTMLElement>('[data-zero-tick="true"]'))
+
+    it('centres the zero with a symmetric domain and keeps the series color', () => {
+      const { container } = render(<CategoryUI data={MIXED} />)
+      const [income, transit, size] = fills(container)
+      expect([income!.style.left, income!.style.width]).toEqual(['50%', '50%'])
+      expect([transit!.style.left, transit!.style.width]).toEqual([
+        '25%',
+        '25%',
+      ])
+      expect(size!.style.width).toBe('0%')
+      expect(transit!.style.backgroundColor).toBe(income!.style.backgroundColor)
+    })
+
+    it('marks the zero with one tick per bar, none on "Others"', () => {
+      const { container } = render(<CategoryUI data={MIXED} maxItems={2} />)
+      expect(ticks(container).map((t) => t.style.left)).toEqual(['50%', '50%'])
+      expect(screen.getByText('Others')).toBeTruthy()
+    })
+
+    it('draws one zero line per multi-series row, spanning every bar', () => {
+      const { container } = render(
+        <CategoryUI
+          data={[
+            [
+              { name: 'A', value: 1 },
+              { name: 'B', value: 2 },
+            ],
+            [
+              { name: 'A', value: -1 },
+              { name: 'B', value: 0.5 },
+            ],
+            [
+              { name: 'A', value: 0 },
+              { name: 'B', value: -2 },
+            ],
+          ]}
+        />,
+      )
+      const t = ticks(container)
+      expect(t).toHaveLength(2)
+      expect(t[0]!.style.left).toBe('50%')
+      expect(t[0]!.parentElement!.style.gridRow).toBe('2 / span 3')
+    })
+
+    it.each([
+      ['positive-only', [1, 2]],
+      ['negative-only', [-1, -2]],
+      ['all-zero', [0, 0]],
+    ])('draws no zero tick for %s data', (_, values) => {
+      const { container } = render(
+        <CategoryUI
+          data={[values.map((value, i) => ({ name: `R${i}`, value }))]}
+        />,
+      )
+      expect(ticks(container)).toHaveLength(0)
+    })
+
+    it('hangs negative-only bars from the right edge', () => {
+      const { container } = render(
+        <CategoryUI
+          data={[
+            [
+              { name: 'A', value: -2 },
+              { name: 'B', value: -1 },
+            ],
+          ]}
+        />,
+      )
+      const [a, b] = fills(container)
+      expect([a!.style.left, a!.style.width]).toEqual(['0%', '100%'])
+      expect([b!.style.left, b!.style.width]).toEqual(['50%', '50%'])
+    })
+
+    it('treats maxOverride as a magnitude for signed data', () => {
+      const { container } = render(
+        <CategoryUI data={MIXED} maxOverride={1.6} />,
+      )
+      const [income, transit] = fills(container)
+      // domain [-1.6, 1.6]
+      expect([income!.style.left, income!.style.width]).toEqual(['50%', '25%'])
+      expect(transit!.style.width).toBe('12.5%')
+    })
+
+    it('minOverride pins the zero even when the data has no negatives', () => {
+      const { container } = render(
+        <CategoryUI data={[[{ name: 'A', value: 1 }]]} minOverride={-1} />,
+      )
+      expect(fills(container)[0]!.style.left).toBe('50%')
+      expect(ticks(container)).toHaveLength(1)
+    })
+
+    it('prefixes U+2212 itself and hands the formatter |v|', () => {
+      const formatter = vi.fn((n: number) => `$${n}`)
+      render(
+        <CategoryUI
+          data={[
+            [
+              { name: 'A', value: -0.5 },
+              { name: 'B', value: -0 },
+              { name: 'C', value: 0 },
+            ],
+          ]}
+          formatter={formatter}
+        />,
+      )
+      expect(screen.getByText('\u2212$0.5')).toBeTruthy()
+      expect(screen.getAllByText('$0')).toHaveLength(2)
+      formatter.mock.calls.forEach(([n]) => expect(n).toBeGreaterThanOrEqual(0))
+    })
+
+    it('stacked mode diverges around the shared zero and shows the signed total', () => {
+      const { container } = render(
+        <CategoryUI
+          stacked
+          data={[[{ name: 'A', value: 3 }], [{ name: 'A', value: -1 }]]}
+        />,
+      )
+      const [pos, neg] = fills(container)
+      // zero at 50%, longer side (3) fills its half
+      expect([pos!.style.left, pos!.style.width]).toEqual(['50%', '50%'])
+      expect(parseFloat(neg!.style.left)).toBeCloseTo(50 - 50 / 3)
+      expect(screen.getByText('2')).toBeTruthy()
+      expect(screen.getByText('Series 2: \u22121')).toBeTruthy()
+    })
+  })
 })

package/src/widgets-v2/category/category-ui.tsx

@@ -78,8 +78,16 @@ export interface CategoryUIProps {
    * overflow row stays a static summary.
    */
   onShowAll?: () => void
-  /** Manual override for the bar-width denominator. */
+  /**
+   * Manual override for the top of the bar scale. With signed data it is a
+   * magnitude: the scale stays symmetric around the centred zero.
+   */
   maxOverride?: number
+  /**
+   * Manual override for the bottom of the bar scale, the negative mirror of
+   * `maxOverride`. Ignored unless negative.
+   */
+  minOverride?: number
   /**
    * Visual density of the bar primitive. `'small'` (default) keeps the
    * historical 4px-tall pill; `'medium'` switches to a 12px-tall track
@@ -147,6 +155,42 @@ function generateGroupedData(data: CategoryWidgetData): GroupedRow[] {
   return order.map((k) => grouped.get(k)!)
 }
 
+/**
+ * Bar domain `[lo, hi]`, always containing zero. Positive-only data keeps
+ * the zero at the left edge and negative-only at the right; mixed data is
+ * made symmetric so the zero sits in the middle of the track.
+ */
+function signedDomain(
+  rows: readonly GroupedRow[],
+  minOverride?: number,
+  maxOverride?: number,
+): [lo: number, hi: number] {
+  let lo = 0
+  let hi = 0
+  for (const row of rows) {
+    for (const v of row.values) {
+      if (v < lo) lo = v
+      if (v > hi) hi = v
+    }
+  }
+  if (typeof minOverride === 'number' && minOverride < 0) lo = minOverride
+  if (typeof maxOverride === 'number' && maxOverride > 0) hi = maxOverride
+  if (lo < 0 && hi > 0) {
+    const m = Math.max(-lo, hi)
+    return [-m, m]
+  }
+  return [lo, hi]
+}
+
+/**
+ * The widget owns the sign: `formatter` only ever sees `|v|`, so a formatter
+ * that prefixes a unit reads `−$5`, not `$-5`, and one that emits its own
+ * `-` cannot double it. U+2212 is as wide as a tabular digit.
+ */
+function formatSigned(fmt: (n: number) => string, v: number): string {
+  return (v < 0 ? '\u2212' : '') + fmt(Math.abs(v))
+}
+
 /**
  * Pure presentational component for the Category widget. Renders
  * single-series rows (`data.length === 1`) as a compact grid or
@@ -173,13 +217,15 @@ export function CategoryUI({
   labels,
   onShowAll,
   maxOverride,
+  minOverride,
   size = 'small',
   stacked = false,
   hiddenSeries: hiddenSeriesProp,
   onHiddenSeriesChange,
 }: CategoryUIProps) {
   const theme = useTheme()
-  const fmt = formatter ?? ((n: number) => String(n))
+  const baseFmt = formatter ?? ((n: number) => String(n))
+  const fmt = (n: number) => formatSigned(baseFmt, n)
 
   const hasSelection = !!selection && selection.length > 0
   const selectionSet = useMemo(
@@ -231,14 +277,14 @@ export function CategoryUI({
 
   const grouped = useMemo(() => generateGroupedData(data), [data])
 
-  const maxValue = useMemo(() => {
-    if (typeof maxOverride === 'number' && maxOverride > 0) return maxOverride
-    let m = 0
-    for (const row of grouped) {
-      for (const v of row.values) if (v > m) m = v
-    }
-    return m
-  }, [grouped, maxOverride])
+  const [minValue, maxValue] = useMemo(
+    () => signedDomain(grouped, minOverride, maxOverride),
+    [grouped, minOverride, maxOverride],
+  )
+  // Where the zero sits on the track, handed to stacked rows so their zero
+  // matches the other rows'. Positive-only data keeps it at the left edge.
+  const zeroPct =
+    maxValue > minValue ? (-minValue / (maxValue - minValue)) * 100 : 0
 
   // Three modes:
   //   * positive finite N (default `DEFAULT_MAX_ITEMS = 20` when prop
@@ -363,7 +409,11 @@ export function CategoryUI({
     <Box sx={styles.root}>
       <Box
         ref={listRefCallback}
-        sx={scrollMode ? { ...styles.list, ...styles.listScroll } : styles.list}
+        sx={{
+          ...styles.list,
+          ...(isMulti && !stacked && styles.listMulti),
+          ...(scrollMode && styles.listScroll),
+        }}
         style={
           scrollMaxHeight !== undefined
             ? { maxHeight: scrollMaxHeight, overflowY: 'auto' }
@@ -413,6 +463,7 @@ export function CategoryUI({
                   selected={selected}
                   onToggle={toggle}
                   size={size}
+                  zeroPct={zeroPct}
                 />
               )
             }
@@ -424,6 +475,7 @@ export function CategoryUI({
                 values={visibleIdx.map((i) => row.values[i]!)}
                 colors={visibleIdx.map((i) => fill(i))}
                 maxValue={maxValue}
+                minValue={minValue}
                 formatter={fmt}
                 selected={selected}
                 onToggle={toggle}
@@ -438,6 +490,7 @@ export function CategoryUI({
               displayName={displayName}
               value={row.values[0] ?? 0}
               maxValue={maxValue}
+              minValue={minValue}
               color={fill(0)}
               formatter={fmt}
               selected={selected}

package/src/widgets-v2/category/category.test.tsx

@@ -238,6 +238,73 @@ describe('<Category> bridge', () => {
       expect(fills[0]!.style.width).toBe('25%')
     })
 
+    it('keeps the zero centred when a transform hides every negative row', () => {
+      render(
+        <Provider
+          id='cat-bridge-auto-neg'
+          data={[
+            [
+              { name: 'A', value: 1 },
+              { name: 'B', value: -1 },
+            ],
+          ]}
+        >
+          <Category />
+        </Provider>,
+      )
+      act(() => {
+        getWidgetStore('cat-bridge-auto-neg').setState({
+          data: [[{ name: 'A', value: 1 }]],
+        })
+      })
+      const fills = getBarFills()
+      expect(fills).toHaveLength(1)
+      expect(fills[0]!.style.left).toBe('50%')
+      expect(fills[0]!.style.width).toBe('50%')
+    })
+
+    it.each([
+      [
+        'positive-only',
+        [50, 25],
+        [
+          ['0%', '50%'],
+          ['0%', '25%'],
+        ],
+      ],
+      [
+        'negative-only',
+        [-50, -25],
+        [
+          ['50%', '50%'],
+          ['75%', '25%'],
+        ],
+      ],
+      [
+        'mixed',
+        [50, -25],
+        [
+          ['50%', '25%'],
+          ['37.5%', '12.5%'],
+        ],
+      ],
+    ])(
+      'applies ±100 overrides only on the side %s data reaches',
+      (_, values, expected) => {
+        render(
+          <Provider
+            id={`cat-bridge-side-${values.join('')}`}
+            data={[values.map((value, i) => ({ name: `R${i}`, value }))]}
+          >
+            <Category maxOverride={100} minOverride={-100} />
+          </Provider>,
+        )
+        expect(getBarFills().map((f) => [f.style.left, f.style.width])).toEqual(
+          expected,
+        )
+      },
+    )
+
     it('consumer-supplied maxOverride wins over the rawData auto-fill', () => {
       render(
         <Provider id='cat-bridge-auto-3' data={PEAK_DATA}>

package/src/widgets-v2/category/category.tsx

@@ -42,13 +42,19 @@ interface CategoryWidgetState extends WidgetState {
 
 const NO_HIDDEN: ReadonlySet<number> = new Set()
 
-function maxFromCategoryData(d: CategoryWidgetData | undefined): number {
-  if (!d) return 0
-  let m = 0
-  for (const series of d) {
-    for (const item of series) if (item.value > m) m = item.value
+/** `[min, max]` of every value, each clamped to include zero. */
+function extentFromCategoryData(
+  d: CategoryWidgetData | undefined,
+): [min: number, max: number] {
+  let min = 0
+  let max = 0
+  for (const series of d ?? []) {
+    for (const item of series) {
+      if (item.value < min) min = item.value
+      if (item.value > max) max = item.value
+    }
   }
-  return m
+  return [min, max]
 }
 
 export interface CategoryProps {
@@ -84,6 +90,12 @@ export interface CategoryProps {
    * regardless of the data.
    */
   maxOverride?: number
+  /**
+   * Bottom of the bar scale for negative values, the mirror of
+   * `maxOverride`. Auto-filled from `rawData` the same way, so the zero
+   * does not move when the Searcher hides every negative row.
+   */
+  minOverride?: number
   /**
    * Visual density of the bar primitive. `'small'` (default) keeps the
    * historical 4px-tall pill; `'medium'` switches to a 12px-tall track
@@ -113,23 +125,27 @@ export function Category({
   labels,
   onShowAll,
   maxOverride,
+  minOverride,
   size,
   stacked,
 }: CategoryProps) {
   const id = useWidgetId()
   const slice = useWidgetShallow(id, categorySelector)
-  // Auto-fill `maxOverride` from `rawData` so bar widths stay coherent
-  // across data transforms (e.g., the Searcher filtering rows in/out).
-  // Consumer's explicit value always wins; we only fill when omitted
-  // AND `rawData` has at least one positive value (CategoryUI's
-  // `maxOverride > 0` guard would reject 0 anyway, but skipping is
-  // cleaner — it lets the live fallback path handle the empty case).
-  const naturalMax = useMemo(
-    () => maxFromCategoryData(slice.rawData),
+  // Auto-fill both ends of the scale from `rawData` so bar widths and the
+  // zero stay coherent across data transforms (e.g., the Searcher filtering
+  // rows in/out). Consumer's explicit value wins, but each end only applies
+  // when `rawData` reaches past zero on that side: a relative-data wiring can
+  // then pass `100` / `-100` unconditionally and positive-only data keeps its
+  // zero at the left edge, negative-only at the right. With no data on a side
+  // we pass nothing and CategoryUI falls back to the live `data`.
+  const [naturalMin, naturalMax] = useMemo(
+    () => extentFromCategoryData(slice.rawData),
     [slice.rawData],
   )
   const effectiveMaxOverride =
-    maxOverride ?? (naturalMax > 0 ? naturalMax : undefined)
+    naturalMax > 0 ? (maxOverride ?? naturalMax) : undefined
+  const effectiveMinOverride =
+    naturalMin < 0 ? (minOverride ?? naturalMin) : undefined
 
   const seriesKey = JSON.stringify(series?.map((s) => s.name) ?? [])
   const stored = useWidget<
@@ -156,6 +172,7 @@ export function Category({
       labels={labels}
       onShowAll={onShowAll}
       maxOverride={effectiveMaxOverride}
+      minOverride={effectiveMinOverride}
       size={size}
       stacked={stacked}
       hiddenSeries={hiddenSeries}

package/src/widgets-v2/category/components/category-bar-stacked.test.tsx

@@ -118,4 +118,22 @@ describe('<CategoryBarStacked>', () => {
     const track = container.querySelector('[data-size]')
     expect(track!.getAttribute('data-size')).toBe('medium')
   })
+
+  it('diverges from zeroPct: positives stack rightwards, negatives leftwards', () => {
+    const { container } = render(
+      <CategoryBarStacked
+        values={[20, -10, 30, -20]}
+        colors={['a', 'b', 'c', 'd']}
+        maxValue={100}
+        zeroPct={50}
+      />,
+    )
+    const segs = getSegments(container)
+    expect(segs.map((s) => [s.style.left, s.style.width])).toEqual([
+      ['50%', '20%'],
+      ['40%', '10%'],
+      ['70%', '30%'],
+      ['20%', '20%'],
+    ])
+  })
 })

package/src/widgets-v2/category/components/category-bar-stacked.tsx

@@ -1,6 +1,7 @@
 import { Box } from '@mui/material'
 import type { CategorySize } from '../types'
 import { styles } from '../style'
+import { ZeroTickWrap } from './category-bar'
 
 export interface CategoryBarStackedProps {
   /** One value per series. Zero values render no segment (visually + in the DOM). */
@@ -13,6 +14,13 @@ export interface CategoryBarStackedProps {
    * so cross-row comparison is preserved.
    */
   maxValue: number
+  /**
+   * Where the zero sits, as a percentage of the track. `0` (default) is the
+   * positive-only layout. Positive segments stack rightwards from it and
+   * negative ones leftwards, both scaled by `maxValue` against the full
+   * track width.
+   */
+  zeroPct?: number
   /** Visual density. Forwarded to the track styling; segments inherit height. */
   size?: CategorySize
 }
@@ -33,41 +41,46 @@ export function CategoryBarStacked({
   values,
   colors,
   maxValue,
+  zeroPct = 0,
   size = 'small',
 }: CategoryBarStackedProps) {
-  // Cumulative offsets pre-computed up front so the render map function
-  // stays pure (no mutable closure variable — keeps the React Compiler
-  // immutability check happy).
-  const offsets: number[] = []
+  // Left edges pre-computed up front so the render map function stays pure
+  // (no mutable closure variable — keeps the React Compiler immutability
+  // check happy). Each sign keeps its own running sum away from the zero.
+  const lefts: number[] = []
   {
-    let acc = 0
+    let pos = 0
+    let neg = 0
     for (const v of values) {
-      offsets.push(acc)
-      acc += v
+      if (v < 0) neg -= v
+      lefts.push(v < 0 ? -neg : pos)
+      if (v > 0) pos += v
     }
   }
   return (
-    <Box sx={styles.bar[size]} data-size={size}>
-      {values.map((v, i) => {
-        if (v <= 0) return null
-        const leftPct = maxValue > 0 ? (offsets[i]! / maxValue) * 100 : 0
-        const pct = maxValue > 0 ? (v / maxValue) * 100 : 0
-        return (
-          <Box
-            // Segments are keyed by per-series colour (the only stable
-            // distinguishing field on this side) plus the segment index for
-            // when callers reuse palette colours across series.
-            key={`seg-${colors[i] ?? 'none'}-${i}`}
-            sx={styles.stackedSegment[size]}
-            style={{
-              left: `${leftPct}%`,
-              width: `${pct}%`,
-              backgroundColor: colors[i] ?? '',
-            }}
-            data-bar-fill='true'
-          />
-        )
-      })}
-    </Box>
+    <ZeroTickWrap zeroPct={zeroPct > 0 && zeroPct < 100 ? zeroPct : undefined}>
+      <Box sx={styles.bar[size]} data-size={size}>
+        {values.map((v, i) => {
+          if (v === 0 || maxValue <= 0) return null
+          const leftPct = zeroPct + (lefts[i]! / maxValue) * 100
+          const pct = (Math.abs(v) / maxValue) * 100
+          return (
+            <Box
+              // Segments are keyed by per-series colour (the only stable
+              // distinguishing field on this side) plus the segment index for
+              // when callers reuse palette colours across series.
+              key={`seg-${colors[i] ?? 'none'}-${i}`}
+              sx={styles.stackedSegment[size]}
+              style={{
+                left: `${leftPct}%`,
+                width: `${pct}%`,
+                backgroundColor: colors[i] ?? '',
+              }}
+              data-bar-fill='true'
+            />
+          )
+        })}
+      </Box>
+    </ZeroTickWrap>
   )
 }

package/src/widgets-v2/category/components/category-bar.test.tsx

@@ -61,4 +61,70 @@ describe('<CategoryBar>', () => {
     expect(track).toBeTruthy()
     expect(track!.getAttribute('data-size')).toBe('medium')
   })
+
+  describe('signed domain (minValue < 0)', () => {
+    it('grows a positive value rightwards from the zero', () => {
+      const { container } = render(
+        <CategoryBar
+          value={0.5}
+          minValue={-1}
+          maxValue={1}
+          color='rgb(0, 0, 0)'
+        />,
+      )
+      const fill = getFill(container)!
+      expect(fill.style.left).toBe('50%')
+      expect(fill.style.width).toBe('25%')
+    })
+
+    it('grows a negative value leftwards from the zero, in the same color', () => {
+      const { container } = render(
+        <CategoryBar
+          value={-0.5}
+          minValue={-1}
+          maxValue={1}
+          color='rgb(0, 200, 0)'
+        />,
+      )
+      const fill = getFill(container)!
+      expect(fill.style.left).toBe('25%')
+      expect(fill.style.width).toBe('25%')
+      expect(fill.style.backgroundColor).toBe('rgb(0, 200, 0)')
+    })
+
+    it('squares the end that grows out of the zero', () => {
+      const { container: pos } = render(
+        <CategoryBar value={1} minValue={-1} maxValue={1} color='red' />,
+      )
+      const { container: neg } = render(
+        <CategoryBar value={-1} minValue={-1} maxValue={1} color='red' />,
+      )
+      expect(getFill(pos)!.style.borderTopLeftRadius).toBe('0px')
+      expect(getFill(pos)!.style.borderTopRightRadius).toBe('')
+      expect(getFill(neg)!.style.borderTopRightRadius).toBe('0px')
+      expect(getFill(neg)!.style.borderTopLeftRadius).toBe('')
+    })
+
+    it('puts the zero tick before the track so the bar paints over it', () => {
+      const { container } = render(
+        <CategoryBar value={1} minValue={-1} maxValue={1} color='red' />,
+      )
+      const tick = container.querySelector('[data-zero-tick="true"]')!
+      expect(tick.nextElementSibling!.getAttribute('data-size')).toBe('small')
+    })
+
+    it('hangs from the right edge when the domain is negative-only', () => {
+      const { container } = render(
+        <CategoryBar
+          value={-1}
+          minValue={-4}
+          maxValue={0}
+          color='rgb(0, 0, 0)'
+        />,
+      )
+      const fill = getFill(container)!
+      expect(fill.style.left).toBe('75%')
+      expect(fill.style.width).toBe('25%')
+    })
+  })
 })