@carto/api-client 0.4.2-alpha.0 → 0.4.2

package/CHANGELOG.md

@@ -4,9 +4,13 @@
 
 ## 0.4
 
+### 0.4.2
+
+- fix: Fix incorrect column name lowercasing in Picking Model API
+
 ### 0.4.1
 
-- add cache control mechanism for sources and query APIs
+- feat: Add cache control mechanism for sources and query APIs
 
 ### 0.4.0
 

package/build/api/query.d.ts

@@ -1,3 +1,3 @@
 import type { SourceOptions, QuerySourceOptions, QueryResult } from '../sources/types';
-export type QueryOptions = SourceOptions & QuerySourceOptions;
+export type QueryOptions = SourceOptions & Omit<QuerySourceOptions, 'spatialDataColumn'>;
 export declare const query: (options: QueryOptions) => Promise<QueryResult>;

package/build/api-client.cjs

@@ -509,43 +509,41 @@ function executeModel(props) {
     data,
     filters,
     filtersLogicalOperator = 'and',
-    spatialDataType = 'geo',
-    spatialFiltersMode = 'intersects',
-    spatialFiltersResolution = 0
+    geoColumn = DEFAULT_GEO_COLUMN
   } = source;
+  const queryParameters = source.queryParameters ? JSON.stringify(source.queryParameters) : '';
   const queryParams = {
     type,
     client: clientId,
     source: data,
-    params,
-    queryParameters: source.queryParameters || '',
-    filters,
+    params: JSON.stringify(params),
+    queryParameters,
+    filters: JSON.stringify(filters),
     filtersLogicalOperator
   };
-  const spatialDataColumn = source.spatialDataColumn || DEFAULT_GEO_COLUMN;
   // Picking Model API requires 'spatialDataColumn'.
   if (model === 'pick') {
-    queryParams.spatialDataColumn = spatialDataColumn;
+    queryParams.spatialDataColumn = geoColumn;
   }
-  // API supports multiple filters, we apply it only to spatialDataColumn
+  // API supports multiple filters, we apply it only to geoColumn
   const spatialFilters = source.spatialFilter ? {
-    [spatialDataColumn]: source.spatialFilter
+    [geoColumn]: source.spatialFilter
   } : undefined;
   if (spatialFilters) {
-    queryParams.spatialFilters = spatialFilters; // JSON.stringify(spatialFilters);
-    queryParams.spatialDataColumn = spatialDataColumn;
-    queryParams.spatialDataType = spatialDataType;
-  }
-  if (spatialDataType !== 'geo') {
-    if (spatialFiltersResolution > 0) {
-      queryParams.spatialFiltersResolution = spatialFiltersResolution;
-    }
-    queryParams.spatialFiltersMode = spatialFiltersMode;
+    queryParams.spatialFilters = JSON.stringify(spatialFilters);
   }
-  const urlWithSearchParams = url + '?' + objectToURLSearchParams(queryParams).toString();
+  const urlWithSearchParams = url + '?' + new URLSearchParams(queryParams).toString();
   const isGet = urlWithSearchParams.length <= REQUEST_GET_MAX_URL_LENGTH;
   if (isGet) {
     url = urlWithSearchParams;
+  } else {
+    // undo the JSON.stringify, @TODO find a better pattern
+    queryParams.params = params;
+    queryParams.filters = filters;
+    queryParams.queryParameters = source.queryParameters;
+    if (spatialFilters) {
+      queryParams.spatialFilters = spatialFilters;
+    }
   }
   return makeCall({
     url,
@@ -559,68 +557,6 @@ function executeModel(props) {
     }
   });
 }
-function objectToURLSearchParams(object) {
-  const params = new URLSearchParams();
-  for (const key in object) {
-    if (isPureObject(object[key])) {
-      params.append(key, JSON.stringify(object[key]));
-    } else if (Array.isArray(object[key])) {
-      params.append(key, JSON.stringify(object[key]));
-    } else if (object[key] === null) {
-      params.append(key, 'null');
-    } else if (object[key] !== undefined) {
-      params.append(key, String(object[key]));
-    }
-  }
-  return params;
-}
-
-const DEFAULT_TILE_SIZE = 512;
-const QUADBIN_ZOOM_MAX_OFFSET = 4;
-function getSpatialFiltersResolution(_ref) {
-  let {
-    source,
-    viewState
-  } = _ref;
-  assert(viewState, 'viewState prop is required to compute automatic spatialFiltersResolution when using spatialFilter with spatial indexes. Either pass a `spatialFiltersResolution` prop or a `viewState` prop to avoid this error');
-  const dataResolution = source.dataResolution ?? Number.MAX_VALUE;
-  const aggregationResLevel = source.aggregationResLevel ?? (source.spatialDataType === 'h3' ? DEFAULT_AGGREGATION_RES_LEVEL_H3 : DEFAULT_AGGREGATION_RES_LEVEL_QUADBIN);
-  const aggregationResLevelOffset = Math.max(0, Math.floor(aggregationResLevel));
-  const currentZoomInt = Math.ceil(viewState.zoom);
-  if (source.spatialDataType === 'h3') {
-    const tileSize = DEFAULT_TILE_SIZE;
-    const maxResolutionForZoom = maxH3SpatialFiltersResolutions.find(_ref2 => {
-      let [zoom] = _ref2;
-      return zoom === currentZoomInt;
-    })?.[1] ?? Math.max(0, currentZoomInt - 3);
-    const maxSpatialFiltersResolution = maxResolutionForZoom ? Math.min(dataResolution, maxResolutionForZoom) : dataResolution;
-    const hexagonResolution = getHexagonResolution(viewState, tileSize) + aggregationResLevelOffset;
-    return Math.min(hexagonResolution, maxSpatialFiltersResolution);
-  }
-  if (source.spatialDataType === 'quadbin') {
-    const maxResolutionForZoom = currentZoomInt + QUADBIN_ZOOM_MAX_OFFSET;
-    const maxSpatialFiltersResolution = Math.min(dataResolution, maxResolutionForZoom);
-    const quadsResolution = Math.floor(viewState.zoom) + aggregationResLevelOffset;
-    return Math.min(quadsResolution, maxSpatialFiltersResolution);
-  }
-  return undefined;
-}
-const maxH3SpatialFiltersResolutions = [[20, 14], [19, 13], [18, 12], [17, 11], [16, 10], [15, 9], [14, 8], [13, 7], [12, 7], [11, 7], [10, 6], [9, 6], [8, 5], [7, 4], [6, 4], [5, 3], [4, 2], [3, 1], [2, 1], [1, 0]];
-// stolen from https://github.com/visgl/deck.gl/blob/master/modules/carto/src/layers/h3-tileset-2d.ts
-// Relative scale factor (0 = no biasing, 2 = a few hexagons cover view)
-const BIAS = 2;
-// Resolution conversion function. Takes a WebMercatorViewport and returns
-// a H3 resolution such that the screen space size of the hexagons is
-// similar
-function getHexagonResolution(viewport, tileSize) {
-  // Difference in given tile size compared to deck's internal 512px tile size,
-  // expressed as an offset to the viewport zoom.
-  const zoomOffset = Math.log2(tileSize / DEFAULT_TILE_SIZE);
-  const hexagonScaleFactor = 2 / 3 * (viewport.zoom - zoomOffset);
-  const latitudeScaleFactor = Math.log(1 / Math.cos(Math.PI * viewport.latitude / 180));
-  // Clip and bias
-  return Math.max(0, Math.floor(hexagonScaleFactor + latitudeScaleFactor - BIAS));
-}
 
 /**
  * Source for Widget API requests on a data source defined by a SQL query.
@@ -645,9 +581,7 @@ class WidgetBaseSource {
       connectionName: props.connectionName,
       filters: getApplicableFilters(owner, props.filters),
       filtersLogicalOperator: props.filtersLogicalOperator,
-      spatialDataType: props.spatialDataType,
-      spatialDataColumn: props.spatialDataColumn,
-      dataResolution: props.dataResolution
+      geoColumn: props.geoColumn
     };
   }
   /****************************************************************************
@@ -663,9 +597,7 @@ class WidgetBaseSource {
       const {
         filterOwner,
         spatialFilter,
-        spatialFiltersMode,
         abortController,
-        viewState,
         ...params
       } = options;
       const {
@@ -673,20 +605,10 @@ class WidgetBaseSource {
         operation,
         operationColumn
       } = params;
-      const source = _this.getModelSource(filterOwner);
-      let spatialFiltersResolution;
-      if (spatialFilter && source.spatialDataType !== 'geo') {
-        spatialFiltersResolution = getSpatialFiltersResolution({
-          source,
-          viewState
-        });
-      }
       return Promise.resolve(executeModel({
         model: 'category',
         source: {
-          ...source,
-          spatialFiltersResolution,
-          spatialFiltersMode,
+          ..._this.getModelSource(filterOwner),
           spatialFilter
         },
         params: {
@@ -719,9 +641,7 @@ class WidgetBaseSource {
       const {
         filterOwner,
         spatialFilter,
-        spatialFiltersMode,
         abortController,
-        viewState,
         ...params
       } = options;
       const {
@@ -732,20 +652,10 @@ class WidgetBaseSource {
         limit,
         tileResolution
       } = params;
-      const source = _this2.getModelSource(filterOwner);
-      let spatialFiltersResolution;
-      if (spatialFilter && source.spatialDataType !== 'geo') {
-        spatialFiltersResolution = getSpatialFiltersResolution({
-          source,
-          viewState
-        });
-      }
       return Promise.resolve(executeModel({
         model: 'pick',
         source: {
-          ...source,
-          spatialFiltersResolution,
-          spatialFiltersMode,
+          ..._this2.getModelSource(filterOwner),
           spatialFilter
         },
         params: {
@@ -759,9 +669,15 @@ class WidgetBaseSource {
         opts: {
           abortController
         }
-      }).then(res => ({
-        rows: normalizeObjectKeys(res.rows)
-      })));
+        // Avoid `normalizeObjectKeys()`, which changes column names.
+      }).then(_ref => {
+        let {
+          rows
+        } = _ref;
+        return {
+          rows
+        };
+      }));
     } catch (e) {
       return Promise.reject(e);
     }
@@ -779,30 +695,18 @@ class WidgetBaseSource {
       const {
         filterOwner,
         spatialFilter,
-        spatialFiltersMode,
         abortController,
         operationExp,
-        viewState,
         ...params
       } = options;
       const {
         column,
         operation
       } = params;
-      const source = _this3.getModelSource(filterOwner);
-      let spatialFiltersResolution;
-      if (spatialFilter && source.spatialDataType !== 'geo') {
-        spatialFiltersResolution = getSpatialFiltersResolution({
-          source,
-          viewState
-        });
-      }
       return Promise.resolve(executeModel({
         model: 'formula',
         source: {
-          ...source,
-          spatialFiltersResolution,
-          spatialFiltersMode,
+          ..._this3.getModelSource(filterOwner),
           spatialFilter
         },
         params: {
@@ -831,9 +735,7 @@ class WidgetBaseSource {
       const {
         filterOwner,
         spatialFilter,
-        spatialFiltersMode,
         abortController,
-        viewState,
         ...params
       } = options;
       const {
@@ -841,20 +743,10 @@ class WidgetBaseSource {
         operation,
         ticks
       } = params;
-      const source = _this4.getModelSource(filterOwner);
-      let spatialFiltersResolution;
-      if (spatialFilter && source.spatialDataType !== 'geo') {
-        spatialFiltersResolution = getSpatialFiltersResolution({
-          source,
-          viewState
-        });
-      }
       return Promise.resolve(executeModel({
         model: 'histogram',
         source: {
-          ...source,
-          spatialFiltersResolution,
-          spatialFiltersMode,
+          ..._this4.getModelSource(filterOwner),
           spatialFilter
         },
         params: {
@@ -870,11 +762,11 @@ class WidgetBaseSource {
           // Given N ticks the API returns up to N+1 bins, omitting any empty bins. Bins
           // include 1 bin below the lowest tick, N-1 between ticks, and 1 bin above the highest tick.
           const result = Array(ticks.length + 1).fill(0);
-          data.forEach(_ref => {
+          data.forEach(_ref2 => {
             let {
               tick,
               value
-            } = _ref;
+            } = _ref2;
             return result[tick] = value;
           });
           return result;
@@ -899,28 +791,16 @@ class WidgetBaseSource {
       const {
         filterOwner,
         spatialFilter,
-        spatialFiltersMode,
         abortController,
-        viewState,
         ...params
       } = options;
       const {
         column
       } = params;
-      const source = _this5.getModelSource(filterOwner);
-      let spatialFiltersResolution;
-      if (spatialFilter && source.spatialDataType !== 'geo') {
-        spatialFiltersResolution = getSpatialFiltersResolution({
-          source,
-          viewState
-        });
-      }
       return Promise.resolve(executeModel({
         model: 'range',
         source: {
-          ...source,
-          spatialFiltersResolution,
-          spatialFiltersMode,
+          ..._this5.getModelSource(filterOwner),
           spatialFilter
         },
         params: {
@@ -947,9 +827,7 @@ class WidgetBaseSource {
       const {
         filterOwner,
         spatialFilter,
-        spatialFiltersMode,
         abortController,
-        viewState,
         ...params
       } = options;
       const {
@@ -958,22 +836,12 @@ class WidgetBaseSource {
         yAxisColumn,
         yAxisJoinOperation
       } = params;
-      const source = _this6.getModelSource(filterOwner);
-      let spatialFiltersResolution;
-      if (spatialFilter && source.spatialDataType !== 'geo') {
-        spatialFiltersResolution = getSpatialFiltersResolution({
-          source,
-          viewState
-        });
-      }
       // Make sure this is sync with the same constant in cloud-native/maps-api
       const HARD_LIMIT = 500;
       return Promise.resolve(executeModel({
         model: 'scatterplot',
         source: {
-          ...source,
-          spatialFiltersResolution,
-          spatialFiltersMode,
+          ..._this6.getModelSource(filterOwner),
           spatialFilter
         },
         params: {
@@ -986,11 +854,11 @@ class WidgetBaseSource {
         opts: {
           abortController
         }
-      }).then(res => normalizeObjectKeys(res.rows)).then(res => res.map(_ref2 => {
+      }).then(res => normalizeObjectKeys(res.rows)).then(res => res.map(_ref3 => {
         let {
           x,
           y
-        } = _ref2;
+        } = _ref3;
         return [x, y];
       })));
     } catch (e) {
@@ -1010,9 +878,7 @@ class WidgetBaseSource {
       const {
         filterOwner,
         spatialFilter,
-        spatialFiltersMode,
         abortController,
-        viewState,
         ...params
       } = options;
       const {
@@ -1022,20 +888,10 @@ class WidgetBaseSource {
         offset = 0,
         limit = 10
       } = params;
-      const source = _this7.getModelSource(filterOwner);
-      let spatialFiltersResolution;
-      if (spatialFilter && source.spatialDataType !== 'geo') {
-        spatialFiltersResolution = getSpatialFiltersResolution({
-          source,
-          viewState
-        });
-      }
       return Promise.resolve(executeModel({
         model: 'table',
         source: {
-          ...source,
-          spatialFiltersResolution,
-          spatialFiltersMode,
+          ..._this7.getModelSource(filterOwner),
           spatialFilter
         },
         params: {
@@ -1071,8 +927,6 @@ class WidgetBaseSource {
         filterOwner,
         abortController,
         spatialFilter,
-        spatialFiltersMode,
-        viewState,
         ...params
       } = options;
       const {
@@ -1086,20 +940,10 @@ class WidgetBaseSource {
         splitByCategoryLimit,
         splitByCategoryValues
       } = params;
-      const source = _this8.getModelSource(filterOwner);
-      let spatialFiltersResolution;
-      if (spatialFilter && source.spatialDataType !== 'geo') {
-        spatialFiltersResolution = getSpatialFiltersResolution({
-          source,
-          viewState
-        });
-      }
       return Promise.resolve(executeModel({
         model: 'timeseries',
         source: {
-          ...source,
-          spatialFiltersResolution,
-          spatialFiltersMode,
+          ..._this8.getModelSource(filterOwner),
           spatialFilter
         },
         params: {
@@ -1130,7 +974,8 @@ WidgetBaseSource.defaultProps = {
   apiBaseUrl: DEFAULT_API_BASE_URL,
   clientId: getClient(),
   filters: {},
-  filtersLogicalOperator: 'and'
+  filtersLogicalOperator: 'and',
+  geoColumn: DEFAULT_GEO_COLUMN
 };
 
 /**
@@ -1610,12 +1455,7 @@ const h3QuerySource = function (options) {
     }
     return Promise.resolve(baseSource('query', options, urlParameters).then(result => ({
       ...result,
-      widgetSource: new WidgetQuerySource({
-        ...options,
-        // NOTE: passing redundant spatialDataColumn here to apply the default value 'h3'
-        spatialDataColumn,
-        spatialDataType: 'h3'
-      })
+      widgetSource: new WidgetQuerySource(options)
     })));
   } catch (e) {
     return Promise.reject(e);
@@ -1646,12 +1486,7 @@ const h3TableSource = function (options) {
     }
     return Promise.resolve(baseSource('table', options, urlParameters).then(result => ({
       ...result,
-      widgetSource: new WidgetTableSource({
-        ...options,
-        // NOTE: passing redundant spatialDataColumn here to apply the default value 'h3'
-        spatialDataColumn,
-        spatialDataType: 'h3'
-      })
+      widgetSource: new WidgetTableSource(options)
     })));
   } catch (e) {
     return Promise.reject(e);
@@ -1720,12 +1555,7 @@ const quadbinQuerySource = function (options) {
     }
     return Promise.resolve(baseSource('query', options, urlParameters).then(result => ({
       ...result,
-      widgetSource: new WidgetQuerySource({
-        ...options,
-        // NOTE: passing redundant spatialDataColumn here to apply the default value 'quadbin'
-        spatialDataColumn,
-        spatialDataType: 'quadbin'
-      })
+      widgetSource: new WidgetQuerySource(options)
     })));
   } catch (e) {
     return Promise.reject(e);
@@ -1756,12 +1586,7 @@ const quadbinTableSource = function (options) {
     }
     return Promise.resolve(baseSource('table', options, urlParameters).then(result => ({
       ...result,
-      widgetSource: new WidgetTableSource({
-        ...options,
-        // NOTE: passing redundant spatialDataColumn here to apply the default value 'quadbin'
-        spatialDataColumn,
-        spatialDataType: 'quadbin'
-      })
+      widgetSource: new WidgetTableSource(options)
     })));
   } catch (e) {
     return Promise.reject(e);
@@ -1811,10 +1636,7 @@ const vectorQuerySource = function (options) {
     }
     return Promise.resolve(baseSource('query', options, urlParameters).then(result => ({
       ...result,
-      widgetSource: new WidgetQuerySource({
-        ...options,
-        spatialDataType: 'geo'
-      })
+      widgetSource: new WidgetQuerySource(options)
     })));
   } catch (e) {
     return Promise.reject(e);
@@ -1845,10 +1667,7 @@ const vectorTableSource = function (options) {
     }
     return Promise.resolve(baseSource('table', options, urlParameters).then(result => ({
       ...result,
-      widgetSource: new WidgetTableSource({
-        ...options,
-        spatialDataType: 'geo'
-      })
+      widgetSource: new WidgetTableSource(options)
     })));
   } catch (e) {
     return Promise.reject(e);