@carto-knowledge/runner 0.1.0 → 0.2.1

package/bun.lock

@@ -4,8 +4,8 @@
     "": {
       "name": "@carto/runner",
       "dependencies": {
-        "@carto-knowledge/commands": "file:../carto-commands",
-        "@carto-knowledge/core": "file:../carto-core",
+        "@carto-knowledge/commands": "^0.1.0",
+        "@carto-knowledge/core": "^0.1.0",
         "clipanion": "^4.0.0-rc.4",
       },
       "devDependencies": {
@@ -15,9 +15,9 @@
     },
   },
   "packages": {
-    "@carto-knowledge/commands": ["@carto-knowledge/commands@file:../carto-commands", { "dependencies": { "@carto-knowledge/core": "file:../carto-core", "clipanion": "^4.0.0-rc.4" }, "devDependencies": { "@types/bun": "latest", "@types/node": "^22.0.0", "typescript": "^5.4.0" } }],
+    "@carto-knowledge/commands": ["@carto-knowledge/commands@0.1.0", "", { "dependencies": { "@carto-knowledge/core": "^0.1.0", "clipanion": "^4.0.0-rc.4" } }, "sha512-/6JxxaDdyYsyh+Y8Bw9WN4ZMa3yowQN+TBDl8NkymcMyYHnQ6g8DHHOm0vEt0s6U45AlmHlxXn8dNJXHS96I6Q=="],
 
-    "@carto-knowledge/core": ["@carto-knowledge/core@file:../carto-core", { "dependencies": { "zod": "^3.23.0" }, "devDependencies": { "@types/bun": "latest", "typescript": "^5.4.0" } }],
+    "@carto-knowledge/core": ["@carto-knowledge/core@0.1.0", "", { "dependencies": { "zod": "^3.23.0" } }, "sha512-MVYEeSWZY4uNKwVF/WvJEf4vqMNNeYnCnxaR43m4UL5PzIPRdu8+Q/0DLUAzwLktqHXpv9kXIFsVZETXfC7J3g=="],
 
     "@types/bun": ["@types/bun@1.3.6", "", { "dependencies": { "bun-types": "1.3.6" } }, "sha512-uWCv6FO/8LcpREhenN1d1b6fcspAB+cefwD7uti8C8VffIv0Um08TKMn98FynpTiU38+y2dUO55T11NgDt8VAA=="],
 
@@ -34,7 +34,5 @@
     "undici-types": ["undici-types@6.21.0", "", {}, "sha512-iwDZqg0QAGrg9Rav5H4n0M64c3mkR59cJ6wQp+7C4nI0gsmExaedaYLNO44eT4AtBBwjbTiGPMlt2Md0T9H9JQ=="],
 
     "zod": ["zod@3.25.76", "", {}, "sha512-gzUt/qt81nXsFGKIFcC3YnfEAx5NkunCfnDlvuBSSFS02bcXu4Lmea0AFIUwbLWxWPx3d9p8S5QoaujKcNQxcQ=="],
-
-    "@carto-knowledge/commands/@carto-knowledge/core": ["@carto-knowledge/core@file:../carto-core", {}],
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@carto-knowledge/runner",
-  "version": "0.1.0",
+  "version": "0.2.1",
   "type": "module",
   "main": "./src/index.ts",
   "types": "./src/index.ts",
@@ -19,12 +19,13 @@
     "typecheck": "bun x tsc --noEmit"
   },
   "dependencies": {
-    "@carto-knowledge/core": "^0.1.0",
-    "@carto-knowledge/commands": "^0.1.0",
+    "@carto-knowledge/core": "^0.2.0",
+    "@carto-knowledge/commands": "^0.2.1",
     "clipanion": "^4.0.0-rc.4"
   },
   "devDependencies": {
     "@types/bun": "latest",
+    "bun-types": "latest",
     "typescript": "^5.4.0"
   }
 }

package/src/allowlist.test.ts

@@ -52,16 +52,39 @@ describe('checkAllowlist', () => {
 });
 
 describe('DEFAULT_ALLOWLIST', () => {
-  it('includes read-only operations', () => {
+  it('includes read-only folder operations', () => {
     expect(DEFAULT_ALLOWLIST.commands).toContain('folder tree');
     expect(DEFAULT_ALLOWLIST.commands).toContain('folder list');
+    expect(DEFAULT_ALLOWLIST.commands).toContain('folder get');
+  });
+
+  it('includes read-only item operations', () => {
     expect(DEFAULT_ALLOWLIST.commands).toContain('item search');
     expect(DEFAULT_ALLOWLIST.commands).toContain('item get');
+    expect(DEFAULT_ALLOWLIST.commands).toContain('item list');
+    expect(DEFAULT_ALLOWLIST.commands).toContain('item get-by-uri');
+    expect(DEFAULT_ALLOWLIST.commands).toContain('item segments');
+  });
+
+  it('includes read-only edge operations', () => {
+    expect(DEFAULT_ALLOWLIST.commands).toContain('edge list');
+    expect(DEFAULT_ALLOWLIST.commands).toContain('edge get');
+  });
+
+  it('includes read-only share-link operations', () => {
+    expect(DEFAULT_ALLOWLIST.commands).toContain('share-link list');
+    expect(DEFAULT_ALLOWLIST.commands).toContain('share-link analytics');
+  });
+
+  it('includes librarian chat', () => {
+    expect(DEFAULT_ALLOWLIST.commands).toContain('librarian chat');
   });
 
   it('does not include write operations', () => {
     expect(DEFAULT_ALLOWLIST.commands).not.toContain('folder create');
     expect(DEFAULT_ALLOWLIST.commands).not.toContain('item create');
+    expect(DEFAULT_ALLOWLIST.commands).not.toContain('edge create');
+    expect(DEFAULT_ALLOWLIST.commands).not.toContain('share-link create');
   });
 });
 
@@ -72,7 +95,32 @@ describe('WRITE_ALLOWLIST', () => {
     }
   });
 
-  it('includes write operations', () => {
+  it('includes folder write operations', () => {
     expect(WRITE_ALLOWLIST.commands).toContain('folder create');
+    expect(WRITE_ALLOWLIST.commands).toContain('folder update');
+    expect(WRITE_ALLOWLIST.commands).toContain('folder delete');
+    expect(WRITE_ALLOWLIST.commands).toContain('folder move');
+    expect(WRITE_ALLOWLIST.commands).toContain('folder restructure');
+    expect(WRITE_ALLOWLIST.commands).toContain('folder create-tree');
+  });
+
+  it('includes item write operations', () => {
+    expect(WRITE_ALLOWLIST.commands).toContain('item create');
+    expect(WRITE_ALLOWLIST.commands).toContain('item update');
+    expect(WRITE_ALLOWLIST.commands).toContain('item delete');
+    expect(WRITE_ALLOWLIST.commands).toContain('item update content');
+    expect(WRITE_ALLOWLIST.commands).toContain('item upload');
+    expect(WRITE_ALLOWLIST.commands).toContain('item assign');
+  });
+
+  it('includes edge write operations', () => {
+    expect(WRITE_ALLOWLIST.commands).toContain('edge create');
+    expect(WRITE_ALLOWLIST.commands).toContain('edge update');
+    expect(WRITE_ALLOWLIST.commands).toContain('edge delete');
+  });
+
+  it('includes share-link write operations', () => {
+    expect(WRITE_ALLOWLIST.commands).toContain('share-link create');
+    expect(WRITE_ALLOWLIST.commands).toContain('share-link delete');
   });
 });

package/src/allowlist.ts

@@ -52,10 +52,23 @@ export function checkAllowlist(
  */
 export const DEFAULT_ALLOWLIST: AllowlistConfig = {
   commands: [
+    // Folder reads
     'folder tree',
     'folder list',
+    'folder get',
+    // Item reads
     'item search',
     'item get',
+    'item list',
+    'item get-by-uri',
+    'item segments',
+    // Edge reads
+    'edge list',
+    'edge get',
+    // Share link reads
+    'share-link list',
+    'share-link analytics',
+    // Librarian
     'librarian chat',
   ],
 };
@@ -67,9 +80,26 @@ export const DEFAULT_ALLOWLIST: AllowlistConfig = {
 export const WRITE_ALLOWLIST: AllowlistConfig = {
   commands: [
     ...DEFAULT_ALLOWLIST.commands,
+    // Folder writes
     'folder create',
+    'folder update',
+    'folder delete',
     'folder move',
+    'folder restructure',
+    'folder create-tree',
+    // Item writes
     'item create',
+    'item update',
+    'item delete',
+    'item update content',
+    'item upload',
     'item assign',
+    // Edge writes
+    'edge create',
+    'edge update',
+    'edge delete',
+    // Share link writes
+    'share-link create',
+    'share-link delete',
   ],
 };

package/src/runner.test.ts

@@ -66,4 +66,30 @@ describe('runInProcess', () => {
     });
     expect(result.schemaVersion).toBe(1);
   });
+
+  it('extracts folder restructure command path from disallowed command error', async () => {
+    const result = await runInProcess(
+      'folder restructure --library 00000000-0000-0000-0000-000000000001 --item-folder-map "{\\"item-1\\":\\"folder-a\\"}"',
+      {
+        ...baseOptions,
+        allowlist: { commands: ['folder tree'] },
+      }
+    );
+
+    expect(result.ok).toBe(false);
+    expect(result.command).toBe('folder restructure');
+  });
+
+  it('extracts folder create-tree command path from disallowed command error', async () => {
+    const result = await runInProcess(
+      'folder create-tree --library 00000000-0000-0000-0000-000000000001 --spec "{\\"name\\":\\"Root\\",\\"children\\":[]}"',
+      {
+        ...baseOptions,
+        allowlist: { commands: ['folder tree'] },
+      }
+    );
+
+    expect(result.ok).toBe(false);
+    expect(result.command).toBe('folder create-tree');
+  });
 });