@carthooks/arcubase-cli 0.1.9 → 0.1.12

package/src/tests/help.test.ts

@@ -1,10 +1,13 @@
 import test from 'node:test'
 import assert from 'node:assert/strict'
 import { executeCLI } from '../runtime/execute.js'
+import { listCommands, type CommandScope } from '../runtime/command_registry.js'
+import { getTypeHints } from '../runtime/zod_registry.js'
 
 const env = {
   ARCUBASE_BASE_URL: 'https://arcubase.example.com',
   ARCUBASE_ACCESS_TOKEN: 'tok',
+  ARCUBASE_SDK_ROOT: '/runtime/arcubase-sdk',
   ARCUBASE_TRACE_ID: '',
   ARCUBASE_SUBJECT_TYPE: '',
   ARCUBASE_SUBJECT_ID: '',
@@ -48,33 +51,74 @@ test('admin module help lists reset app commands', async () => {
 })
 
 test('user row help replaces workflow row commands', async () => {
-  const out = await executeCLI('user', ['row', 'query', '--help'], undefined, async () => new Response('{}'))
+  const out = await executeCLI('user', ['row', 'query', '--help'], env as any, async () => new Response('{}'))
   assert.equal(out.kind, 'help')
-  assert.match(out.text, /body: .*--body-file or --body-json/)
+  assert.match(out.text, /body: .*--body-json <json-string> \| --body-file <file>\.json/)
   assert.match(out.text, /query flags: --query-file/)
   assert.doesNotMatch(out.text, /workflow query-entity/)
   assert.doesNotMatch(out.text, /--entity-id/)
 })
 
+test('user row help does not expose internal policy id input', async () => {
+  const out = await executeCLI('user', ['row', 'get', '--help'], env as any, async () => new Response('{}'))
+  assert.equal(out.kind, 'help')
+  assert.doesNotMatch(out.text, /--policy-id/)
+  assert.doesNotMatch(out.text, /policy_id/)
+})
+
 test('admin table update-schema help uses table nouns and body-json', async () => {
-  const out = await executeCLI('admin', ['table', 'update-schema', '--help'], undefined, async () => new Response('{}'))
+  const out = await executeCLI('admin', ['table', 'update-schema', '--help'], env as any, async () => new Response('{}'))
   assert.equal(out.kind, 'help')
-  assert.match(out.text, /body: .*--body-file or --body-json/)
+  assert.match(out.text, /body: .*--body-json <json-string> \| --body-file <file>\.json/)
+  assert.match(out.text, /prefer --body-json/)
   assert.match(out.text, /path flags: --app-id, --table-id/)
   assert.doesNotMatch(out.text, /--entity-id/)
   assert.doesNotMatch(out.text, /admin-save-entity/)
 })
 
+test('admin table create help gives one-call body-json example', async () => {
+  const out = await executeCLI('admin', ['table', 'create', '--help'], env as any, async () => new Response('{}'))
+  assert.equal(out.kind, 'help')
+  assert.match(out.text, /body-json example:/)
+  assert.match(out.text, /"field_id_seq":1003/)
+  assert.match(out.text, /"label":"投票描述"/)
+  assert.match(out.text, /"type":"textarea"/)
+})
+
 test('admin access-rule help gives update whitelist and assign-users body-json examples', async () => {
-  const update = await executeCLI('admin', ['access-rule', 'update', '--help'], undefined, async () => new Response('{}'))
+  const create = await executeCLI('admin', ['access-rule', 'create', '--help'], env as any, async () => new Response('{}'))
+  assert.equal(create.kind, 'help')
+  assert.match(create.text, /Access rule/)
+  assert.match(create.text, /access-rule\.md/)
+  assert.match(create.text, /"user_scope":\[\{"type":"user","id":2188889901\}\]/)
+  assert.doesNotMatch(create.text, /"user_scope":\[\{"type":"member"/)
+
+  const update = await executeCLI('admin', ['access-rule', 'update', '--help'], env as any, async () => new Response('{}'))
   assert.equal(update.kind, 'help')
   assert.match(update.text, /--app-id/)
   assert.match(update.text, /--table-id/)
   assert.match(update.text, /--rule-id/)
   assert.match(update.text, /"update":\["enabled"\]/)
+  assert.match(update.text, /"actions":\["view","add","edit"\]/)
 
-  const assign = await executeCLI('admin', ['access-rule', 'assign-users', '--help'], undefined, async () => new Response('{}'))
+  const assign = await executeCLI('admin', ['access-rule', 'assign-users', '--help'], env as any, async () => new Response('{}'))
   assert.equal(assign.kind, 'help')
   assert.match(assign.text, /"update":\["user_scope"\]/)
-  assert.match(assign.text, /"options":\{"user_scope":\[/)
+  assert.match(assign.text, /\{"update":\["user_scope"\],"options":\{"user_scope":\[\{"type":"user","id":2188889901\}\]\}\}/)
+  assert.doesNotMatch(assign.text, /"type":"member"/)
+  assert.doesNotMatch(assign.text, /"users"/)
+  assert.doesNotMatch(assign.text, /"allowedUsers"/)
+})
+
+test('every body command help exposes readable TypeScript type paths', async () => {
+  for (const scope of ['admin', 'user'] as const satisfies readonly CommandScope[]) {
+    for (const command of listCommands(scope).filter((item) => item.requestType)) {
+      const out = await executeCLI(scope, [...command.commandPath, '--help'], env as any, async () => new Response('{}'))
+      assert.equal(out.kind, 'help')
+      assert.match(out.text, /^types:$/m, `${scope} ${command.commandPath.join(' ')} must expose types section`)
+      for (const hint of getTypeHints(command.requestType ?? '', env)) {
+        assert.match(out.text, new RegExp(`${hint.symbol}: ${hint.file}`.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')))
+      }
+    }
+  }
 })

package/src/tests/upload.test.ts

@@ -1,132 +1,75 @@
 import test from 'node:test'
 import assert from 'node:assert/strict'
-import fs from 'fs'
-import os from 'os'
-import path from 'path'
 import { executeCLI } from '../runtime/execute.js'
+import { CLIError } from '../runtime/errors.js'
 
 const env = {
   ARCUBASE_BASE_URL: 'https://arcubase.example.com',
   ARCUBASE_ACCESS_TOKEN: 'tok',
+  ARCUBASE_SDK_ROOT: '/runtime/arcubase-sdk',
   ARCUBASE_TRACE_ID: '',
   ARCUBASE_SUBJECT_TYPE: '',
   ARCUBASE_SUBJECT_ID: '',
   ARCUBASE_TOKEN_EXPIRES_AT: '',
 }
 
-test('upload help works without runtime env', async () => {
-  const out = await executeCLI('user', ['upload', '--help'], undefined, async () => new Response('{}'))
+test('upload module help exposes reset upload commands with injected SDK root', async () => {
+  const out = await executeCLI('user', ['upload', '--help'], env as any, async () => new Response('{}'))
   assert.equal(out.kind, 'help')
-  assert.match(out.text, /arcubase upload <local-file>/)
-  assert.match(out.text, /uploads\.md/)
+  assert.match(out.text, /commands:/)
+  assert.match(out.text, /token/)
+  assert.match(out.text, /preview/)
+  assert.match(out.text, /mobile/)
+  assert.match(out.text, /check-mobile/)
+  assert.doesNotMatch(out.text, /<local-file>/)
 })
 
-test('upload returns file field value array for row payloads', async () => {
-  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'arcubase-upload-'))
-  const sourceFile = path.join(tempDir, 'contract.pdf')
-  fs.writeFileSync(sourceFile, 'fake pdf bytes')
-
-  const calls: Array<{ url: string; method?: string }> = []
-
-  const result = await executeCLI(
-    'user',
-    ['upload', sourceFile],
-    env as any,
-    async (input, init) => {
-      const url = String(input)
-      calls.push({ url, method: init?.method })
-      if (url === 'https://arcubase.example.com/api/upload/token') {
-        return new Response(
-          JSON.stringify({
-            data: {
-              id: 123456,
-              mode: 'aliyun-oss',
-              token_data: {
-                dir: 'upload/123456/',
-                policy: 'policy',
-                accessid: 'accessid',
-                signature: 'signature',
-                host: 'https://uploads.example.com',
-              },
-            },
-          }),
-          { status: 200, headers: { 'Content-Type': 'application/json' } },
-        )
-      }
-      if (url === 'https://uploads.example.com') {
-        return new Response('', { status: 200 })
-      }
-      throw new Error(`unexpected fetch url: ${url}`)
+test('upload rejects local file shortcut', async () => {
+  await assert.rejects(
+    async () => {
+      await executeCLI('user', ['upload', './contract.pdf'], env as any, async () => new Response('{}'))
     },
-  )
-
-  assert.equal(result.kind, 'result')
-  assert.deepEqual(calls, [
-    { url: 'https://arcubase.example.com/api/upload/token', method: 'POST' },
-    { url: 'https://uploads.example.com', method: 'POST' },
-  ])
-  assert.deepEqual(result.data, [
-    {
-      upload_id: 123456,
-      file: 'contract.pdf',
-      file_name: 'contract.pdf',
-      meta: {},
+    (error: unknown) => {
+      assert.ok(error instanceof CLIError)
+      assert.equal(error.code, 'UNKNOWN_COMMAND')
+      assert.match(error.message, /unknown command: upload \.\/contract\.pdf/)
+      return true
     },
-  ])
+  )
 })
 
-test('upload supports s3-post-policy tokens', async () => {
-  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'arcubase-upload-s3-'))
-  const sourceFile = path.join(tempDir, 'contract.pdf')
-  fs.writeFileSync(sourceFile, 'fake pdf bytes')
-
-  const calls: Array<{ url: string; method?: string }> = []
-
+test('upload token executes the explicit API command', async () => {
+  const calls: Array<{ url: string; method?: string; body?: string }> = []
   const result = await executeCLI(
     'user',
-    ['upload', sourceFile],
+    ['upload', 'token', '--body-json', '{"global":false}'],
     env as any,
     async (input, init) => {
       const url = String(input)
-      calls.push({ url, method: init?.method })
+      calls.push({ url, method: init?.method, body: typeof init?.body === 'string' ? init.body : undefined })
       if (url === 'https://arcubase.example.com/api/upload/token') {
         return new Response(
           JSON.stringify({
             data: {
-              id: 654321,
-              mode: 's3-post-policy',
-              token_data: {
-                dir: 'upload/654321/',
-                policy: 'policy',
-                host: 'https://uploads.example.com/private-bucket',
-                x_amz_algorithm: 'AWS4-HMAC-SHA256',
-                x_amz_credential: 'test/20260504/us-east-1/s3/aws4_request',
-                x_amz_date: '20260504T010203Z',
-                x_amz_signature: 'abc123',
-              },
+              id: 123456,
+              mode: 'aliyun-oss',
+              token_data: { host: 'https://uploads.example.com' },
             },
           }),
           { status: 200, headers: { 'Content-Type': 'application/json' } },
         )
       }
-      if (url === 'https://uploads.example.com/private-bucket') {
-        return new Response('', { status: 200 })
-      }
       throw new Error(`unexpected fetch url: ${url}`)
     },
   )
 
   assert.equal(result.kind, 'result')
-  assert.deepEqual(calls, [
-    { url: 'https://arcubase.example.com/api/upload/token', method: 'POST' },
-    { url: 'https://uploads.example.com/private-bucket', method: 'POST' },
-  ])
-  assert.deepEqual(result.data, [
-    {
-      upload_id: 654321,
-      file: 'contract.pdf',
-      file_name: 'contract.pdf',
-      meta: {},
+  assert.deepEqual(calls, [{ url: 'https://arcubase.example.com/api/upload/token', method: 'POST', body: '{"global":false}' }])
+  assert.deepEqual(result.data, {
+    data: {
+      id: 123456,
+      mode: 'aliyun-oss',
+      token_data: { host: 'https://uploads.example.com' },
     },
-  ])
+  })
 })