@carthooks/arcubase-cli 0.1.6 → 0.1.8

package/src/tests/bootstrap.test.ts

@@ -3,23 +3,20 @@ import assert from 'node:assert/strict'
 
 import { loadRuntimeEnv } from '../runtime/env.js'
 
-test('loadRuntimeEnv requires base url, tenant id and access token', () => {
+test('loadRuntimeEnv requires base url and access token', () => {
   assert.throws(() => loadRuntimeEnv('admin', {}), /ARCUBASE_BASE_URL is required/)
 })
 
 test('loadRuntimeEnv returns normalized runtime env', () => {
   const env = loadRuntimeEnv('admin', {
     ARCUBASE_BASE_URL: ' http://example.com ',
-    ARCUBASE_TENANT_ID: ' tenant-1 ',
     ARCUBASE_ACCESS_TOKEN: ' token-1 ',
     ARCUBASE_TRACE_ID: ' trace-1 '
   })
 
   assert.deepEqual(env, {
     ARCUBASE_BASE_URL: 'http://example.com',
-    ARCUBASE_TENANT_ID: 'tenant-1',
     ARCUBASE_ACCESS_TOKEN: 'token-1',
-    ARCUBASE_HOST: undefined,
     ARCUBASE_TRACE_ID: 'trace-1',
     ARCUBASE_SUBJECT_TYPE: undefined,
     ARCUBASE_SUBJECT_ID: undefined,
@@ -30,18 +27,14 @@ test('loadRuntimeEnv returns normalized runtime env', () => {
 test('loadRuntimeEnv accepts admin-prefixed runtime env', () => {
   const env = loadRuntimeEnv('admin', {
     ARCUBASE_ADMIN_BASE_URL: ' https://admin.example.com ',
-    ARCUBASE_ADMIN_TENANT_ID: ' tenant-admin ',
     ARCUBASE_ADMIN_ACCESS_TOKEN: ' token-admin ',
-    ARCUBASE_ADMIN_HOST: ' tenant-admin.arcubase.co ',
     ARCUBASE_ADMIN_SUBJECT_TYPE: ' system_admin ',
     ARCUBASE_ADMIN_SUBJECT_ID: ' user-admin ',
   })
 
   assert.deepEqual(env, {
     ARCUBASE_BASE_URL: 'https://admin.example.com',
-    ARCUBASE_TENANT_ID: 'tenant-admin',
     ARCUBASE_ACCESS_TOKEN: 'token-admin',
-    ARCUBASE_HOST: 'tenant-admin.arcubase.co',
     ARCUBASE_TRACE_ID: undefined,
     ARCUBASE_SUBJECT_TYPE: 'system_admin',
     ARCUBASE_SUBJECT_ID: 'user-admin',
@@ -52,18 +45,14 @@ test('loadRuntimeEnv accepts admin-prefixed runtime env', () => {
 test('loadRuntimeEnv accepts user-prefixed runtime env', () => {
   const env = loadRuntimeEnv('user', {
     ARCUBASE_USER_BASE_URL: ' https://user.example.com ',
-    ARCUBASE_USER_TENANT_ID: ' tenant-user ',
     ARCUBASE_USER_ACCESS_TOKEN: ' token-user ',
-    ARCUBASE_USER_HOST: ' tenant-user.arcubase.co ',
     ARCUBASE_USER_SUBJECT_TYPE: ' service_account ',
     ARCUBASE_USER_SUBJECT_ID: ' sa-user ',
   })
 
   assert.deepEqual(env, {
     ARCUBASE_BASE_URL: 'https://user.example.com',
-    ARCUBASE_TENANT_ID: 'tenant-user',
     ARCUBASE_ACCESS_TOKEN: 'token-user',
-    ARCUBASE_HOST: 'tenant-user.arcubase.co',
     ARCUBASE_TRACE_ID: undefined,
     ARCUBASE_SUBJECT_TYPE: 'service_account',
     ARCUBASE_SUBJECT_ID: 'sa-user',

package/src/tests/command_registry.test.ts

@@ -2,41 +2,91 @@ import test from 'node:test'
 import assert from 'node:assert/strict'
 
 import { adminCommands, userCommands } from '../generated/command_registry.generated.js'
-import { findCommandSuggestions } from '../runtime/command_registry.js'
 
-test('admin app create-entity command exists', () => {
-  assert.ok(adminCommands.some((c) => c.commandPath.join(' ') === 'app create-entity'))
-})
-
-test('admin app list-apps command exists', () => {
-  assert.ok(adminCommands.some((c) => c.commandPath.join(' ') === 'app list-apps'))
-})
-
-test('admin app inventory command exists', () => {
-  const suggestions = findCommandSuggestions('app', 'inventory', 20)
-  assert.ok(suggestions.some((item) => item.binary === 'arcubase-admin' && item.moduleName === 'app' && item.commandName === 'inventory'))
-})
-
-test('user rows query-entity command exists', () => {
-  assert.ok(userCommands.some((c) => c.commandPath.join(' ') === 'rows query-entity'))
-})
+function commandPaths(commands: ReadonlyArray<{ commandPath: readonly string[] }>): string[] {
+  return commands.map((item) => item.commandPath.join(' ')).sort()
+}
 
-test('inline request type keeps full object text instead of truncated brace', () => {
-  const command = adminCommands.find((c) => c.commandPath.join(' ') === 'dashboard clone-dashboard')
-  assert.ok(command)
-  const typed = command!
-  assert.match(String(typed.requestType), /^\{\s*name:\s*string\s*\}$/)
+test('admin surface is restricted to reset white list', () => {
+  const actual = commandPaths(adminCommands)
+  const expected = [
+    'app create',
+    'app delete',
+    'app get',
+    'app list',
+    'app update',
+    'table create',
+    'table delete',
+    'table get',
+    'table list',
+    'table rename',
+    'table update-schema',
+    'access-rule assign-users',
+    'access-rule create',
+    'access-rule delete',
+    'access-rule get',
+    'access-rule list',
+    'access-rule update',
+    'workflow create-version',
+    'workflow deploy',
+    'workflow get',
+    'workflow update',
+  ].sort()
+  assert.deepEqual(actual, expected)
 })
 
-test('tag commands no longer emit truncated inline request type', () => {
-  const command = adminCommands.find((c) => c.commandPath.join(' ') === 'entity-tags batch-add-entity-tags')
-  assert.ok(command)
-  const typed = command!
-  assert.match(String(typed.requestType), /^\{\s*policy_id:\s*string.*selection:\s*any.*tag_names:\s*string\[\]\s*\}$/)
-  assert.equal(typed.scalarParams.length, 0)
+test('user surface is restricted to reset white list', () => {
+  const actual = commandPaths(userCommands)
+  const expected = [
+    'entry',
+    'profile get',
+    'profile update',
+    'row bulk-update',
+    'row create',
+    'row delete',
+    'row get',
+    'row query',
+    'row selection-action',
+    'row update',
+    'table dataset',
+    'table get',
+    'table relation-options',
+    'upload check-mobile',
+    'upload mobile',
+    'upload preview',
+    'upload token',
+    'workflow approve',
+    'workflow countersign',
+    'workflow forward',
+    'workflow process-map',
+    'workflow query-approve-users',
+    'workflow query-nodes',
+    'workflow resolve',
+    'workflow retract',
+    'workflow rollback',
+  ].sort()
+  assert.deepEqual(actual, expected)
 })
 
-test('suggestions can point wrong admin delete guess to user rows delete command', () => {
-  const suggestions = findCommandSuggestions('entity', 'admin-delete-entity-row')
-  assert.ok(suggestions.some((item) => item.binary === 'arcubase' && item.moduleName === 'rows' && item.commandName === 'delete-entity-row'))
+test('black list commands are removed from registry', () => {
+  const all = new Set([...commandPaths(adminCommands), ...commandPaths(userCommands)])
+  const forbidden = [
+    'app inventory',
+    'app list-apps',
+    'app create-entity',
+    'entity admin-get-entity-info',
+    'entity admin-save-entity',
+    'ingress create-entity-ingress',
+    'workflow query-entity',
+    'workflow insert-entity',
+    'workflow update-entity-row',
+    'workflow delete-entity-row',
+    'workflow restore-entity-row',
+    'workflow query-entity-selection',
+    'profile change-password',
+    'profile auth-channels',
+  ]
+  for (const item of forbidden) {
+    assert.equal(all.has(item), false, `${item} should not exist`)
+  }
 })