@carlonicora/nextjs-jsonapi 6.21.0 → 6.22.0

package/src/components/forms/__tests__/EditorSheet.spec.tsx

@@ -77,6 +77,22 @@ describe("EditorSheet", () => {
       expect(screen.getByText("Custom")).toBeTruthy();
     });
 
+    it("should render a labelled edit trigger as a primary button", () => {
+      render(<TestEditor isEdit={true} showLabel={true} />);
+      const trigger = document.querySelector('[data-help="editor.edit"]');
+      expect(trigger?.textContent).toContain("ui.buttons.edit");
+      expect(trigger?.className).toContain("bg-primary");
+      expect(trigger?.className).not.toContain("text-muted-foreground");
+    });
+
+    it("should render an unlabelled edit trigger as a muted glyph", () => {
+      render(<TestEditor isEdit={true} showLabel={false} />);
+      const trigger = document.querySelector('[data-help="editor.edit"]');
+      expect(trigger?.textContent).not.toContain("ui.buttons.edit");
+      expect(trigger?.className).not.toContain("bg-primary");
+      expect(trigger?.className).toContain("text-muted-foreground");
+    });
+
     it("should not render trigger when dialogOpen is controlled", () => {
       render(<TestEditor dialogOpen={false} />);
       expect(screen.queryByText("ui.buttons.create")).toBeNull();

package/src/features/oauth/components/OAuthClientDetail.tsx

@@ -201,7 +201,7 @@ export function OAuthClientDetail({
           {/* Actions */}
           <div className="flex gap-3 pt-4">
             {onEdit && (
-              <Button variant="outline" onClick={onEdit} disabled={isLoading}>
+              <Button onClick={onEdit} disabled={isLoading}>
                 <Pencil className="h-4 w-4 me-2" />
                 {t("ui.buttons.edit")}
               </Button>

package/src/features/user/contexts/UserContext.tsx

@@ -76,6 +76,7 @@ export const UserProvider = ({ children, dehydratedUser }: UserProviderProps) =>
     };
 
     const functions: ReactNode[] = [];
+    const actionBar: ReactNode[] = [];
 
     if (user) {
       response.element = `${user.name}${user.isDeleted ? ` (${t(`user.deleted`)})` : ""}`;
@@ -86,17 +87,20 @@ export const UserProvider = ({ children, dehydratedUser }: UserProviderProps) =>
         if (!user.isActivated)
           functions.push(<UserResentInvitationEmail key={`UserResentInvitationEmail`} user={user} />);
 
-        functions.push(<UserDeleter key={`UserDeleter`} user={user} />);
+        actionBar.push(<UserDeleter key={`UserDeleter`} user={user} />);
 
         // Opt-in: only apps that registered AccountDeletionModule, platform administrators only.
         if (hasRole(getRoleId().Administrator) && isAccountDeletionEnabled())
           functions.push(<AccountDeletionAdminTrigger key={`AccountDeletionAdminTrigger`} user={user} />);
       }
 
-      functions.push(<UserEditor key={`UserEditor`} user={user} propagateChanges={setUser} />);
+      // Delete and Edit live in the secondary header (action bar), where they
+      // render as labelled buttons, like every other entity page.
+      actionBar.push(<UserEditor key={`UserEditor`} user={user} propagateChanges={setUser} />);
     }
 
     if (functions.length > 0) response.functions = functions;
+    if (actionBar.length > 0) response.actionBar = actionBar;
 
     return response;
   };