@carlonicora/nextjs-jsonapi 6.14.0 → 6.14.1

package/src/hooks/__tests__/usePageTracker.spec.tsx

@@ -299,4 +299,65 @@ describe("usePageTracker", () => {
 
     await waitFor(() => expect(pages(store)[0]?.title).toBe("Venezia Obscura"));
   });
+
+  describe("most-specific-first titles (`Name · Type · Context | App`)", () => {
+    it("records the entity name on a hard load", async () => {
+      pathnameRef.current = "/npcs/npc-1";
+      document.title = "Charlie · NPC · Venezia Obscura | App";
+      const store = createStore();
+      store.set(recentPagesAtom, []);
+
+      mount(store);
+
+      await waitFor(() => expect(pages(store)).toHaveLength(1));
+      expect(pages(store)[0]).toMatchObject({ url: "/npcs/npc-1", title: "Charlie", moduleType: "npcs" });
+    });
+
+    it("records a single-part title such as a campaign's", async () => {
+      pathnameRef.current = "/campaigns/camp-1";
+      document.title = "Venezia Obscura | App";
+      const store = createStore();
+      store.set(recentPagesAtom, []);
+
+      mount(store);
+
+      await waitFor(() => expect(pages(store)[0]?.title).toBe("Venezia Obscura"));
+    });
+
+    it("never stamps an entity with the previous page's name, then upgrades when the title lands", async () => {
+      pathnameRef.current = "/campaigns/camp-1";
+      document.title = "Venezia Obscura | App";
+      const store = createStore();
+      store.set(recentPagesAtom, []);
+      const view = mount(store);
+      await waitFor(() => expect(pages(store)[0]?.title).toBe("Venezia Obscura"));
+
+      pathnameRef.current = "/npcs/npc-1";
+      view.rerender(
+        <Provider store={store}>
+          <Harness />
+        </Provider>,
+      );
+
+      await waitFor(() => expect(pages(store)[0]?.url).toBe("/npcs/npc-1"));
+      expect(pages(store)[0].title).toBe("npcs");
+
+      document.title = "Charlie · NPC · Venezia Obscura | App";
+
+      await waitFor(() => expect(pages(store)[0]?.title).toBe("Charlie"));
+      expect(pages(store).find((page) => page.url === "/campaigns/camp-1")?.title).toBe("Venezia Obscura");
+    });
+
+    it("keeps the module name when the title is only the app name", async () => {
+      pathnameRef.current = "/npcs/npc-1";
+      document.title = "App";
+      const store = createStore();
+      store.set(recentPagesAtom, []);
+
+      mount(store);
+
+      await waitFor(() => expect(pages(store)).toHaveLength(1));
+      expect(pages(store)[0].title).toBe("npcs");
+    });
+  });
 });

package/src/hooks/usePageTracker.ts

@@ -10,18 +10,28 @@ import { getTrackablePages } from "../client/config";
 const EXCLUDED_ROUTES = ["/", "/login", "/register", "/forgot-password", "/reset-password", "/activate"];
 
 /**
- * Detail pages title themselves `[Entity type] Entity name | App name`. Returns
- * the entity name, or null when the document title is not (yet) a detail-page
- * title — the normal state for the first tick after a client-side navigation,
- * before the route's streamed metadata replaces the <title>.
+ * Detail pages title themselves in one of two shapes:
+ *
+ *   `[Entity type] Entity name | App name`        (bracketed)
+ *   `Entity name · Entity type · Context | App name` (most-specific-first)
+ *
+ * Returns the entity name, or null when the document title carries no page
+ * name — just the bare app name. Whether the title belongs to THIS route (and
+ * not the page we left) is decided by the caller, not here.
  */
 function readEntityTitle(): string | null {
   if (typeof document === "undefined") return null;
 
-  const afterEntityType = document.title.split("]")[1];
-  if (!afterEntityType) return null;
+  const title = document.title;
 
-  return afterEntityType.split("|")[0]?.trim() || null;
+  if (title.includes("]")) {
+    const afterEntityType = title.split("]")[1];
+    return afterEntityType?.split("|")[0]?.trim() || null;
+  }
+
+  if (!title.includes("|")) return null;
+
+  return title.split("|")[0].split("·")[0]?.trim() || null;
 }
 
 export function usePageTracker() {