@carlonicora/nextjs-jsonapi 5.7.0 → 5.7.1

package/src/features/billing/stripe-coupon/components/containers/CouponContainer.tsx

@@ -2,10 +2,10 @@
 
 import { useTranslations } from "next-intl";
 import { RoundPageContainer } from "../../../../../components";
-import { Modules } from "../../../../../core";
 import { useCouponContext } from "../../../contexts/CouponContext";
 import { CouponDetails } from "../details/CouponDetails";
 import { CouponCodesList } from "../lists/CouponCodesList";
+import { couponPageModule } from "../../utils/coupon-page-module";
 
 export function CouponContainer() {
   const t = useTranslations();
@@ -15,7 +15,7 @@ export function CouponContainer() {
 
   return (
     <RoundPageContainer
-      module={Modules.StripeCoupon}
+      module={couponPageModule()}
       id={coupon.id}
       tabs={[
         {

package/src/features/billing/stripe-coupon/components/forms/CouponEditor.tsx

@@ -27,7 +27,7 @@ import {
   StripeCouponInput,
   StripeCouponInterface,
 } from "../../data/stripe-coupon.interface";
-import { STRIPE_COUPON_DETAIL_PAGE_URL } from "../../stripe-coupon.module";
+import { couponPageModule } from "../../utils/coupon-page-module";
 import { formatCouponDiscount } from "../../utils/format-coupon-discount";
 import {
   CouponCodeFields,
@@ -151,16 +151,6 @@ function toCouponInput(values: CouponCreateValues): StripeCouponInput {
   return payload;
 }
 
-/**
- * The module with the coupon's own route as pageUrl: the module's pageUrl is the
- * products page (the coupons list is its Codes tab), so EditorSheet's
- * navigate / revalidate after a save would otherwise land on
- * `/administration/products/<couponId>`.
- */
-function couponPageModule() {
-  return { ...Modules.StripeCoupon, pageUrl: STRIPE_COUPON_DETAIL_PAGE_URL };
-}
-
 function CouponRenameEditor({
   coupon,
   propagateChanges,

package/src/features/billing/stripe-coupon/utils/__tests__/coupon-page-module.spec.ts

@@ -0,0 +1,32 @@
+import { beforeAll, describe, expect, it } from "vitest";
+import { ApiRequestDataTypeInterface } from "../../../../../core/interfaces/ApiRequestDataTypeInterface";
+import { ModuleRegistry } from "../../../../../core/registry/ModuleRegistry";
+import { StripeCoupon } from "../../data/stripe-coupon";
+import { STRIPE_COUPON_DETAIL_PAGE_URL } from "../../stripe-coupon.module";
+import { couponPageModule } from "../coupon-page-module";
+
+// couponPageModule() resolves Modules.StripeCoupon through the real ModuleRegistry.
+const registerIfAbsent = (key: string, module: ApiRequestDataTypeInterface) => {
+  try {
+    ModuleRegistry.get(key as any);
+  } catch {
+    ModuleRegistry.register(key, module);
+  }
+};
+
+beforeAll(() => {
+  registerIfAbsent("StripeCoupon", {
+    name: "stripe-coupons",
+    pageUrl: "/administration/products",
+    model: StripeCoupon,
+  } as any);
+});
+
+describe("couponPageModule", () => {
+  // The coupon page's tabs and the editor build `<pageUrl>/<couponId>` from this module:
+  // with the products pageUrl that is a products route, which answers Not Found.
+  it("points at the coupon's own route, not the products page", () =>
+    expect(couponPageModule().pageUrl).toBe(STRIPE_COUPON_DETAIL_PAGE_URL));
+
+  it("keeps the rest of the coupon module", () => expect(couponPageModule().name).toBe("stripe-coupons"));
+});

package/src/features/billing/stripe-coupon/utils/coupon-page-module.ts

@@ -0,0 +1,13 @@
+import { Modules } from "../../../../core";
+import { STRIPE_COUPON_DETAIL_PAGE_URL } from "../stripe-coupon.module";
+
+/**
+ * The module with the coupon's own route as pageUrl: the module's pageUrl is the
+ * products page (the coupons list is its Codes tab), so anything that builds a
+ * URL for one coupon from the module (EditorSheet's navigate / revalidate after a
+ * save, RoundPageContainer's tab rewrite) would otherwise land on
+ * `/administration/products/<couponId>`.
+ */
+export function couponPageModule() {
+  return { ...Modules.StripeCoupon, pageUrl: STRIPE_COUPON_DETAIL_PAGE_URL };
+}