@carecard/validate 3.18.0 → 3.20.0

package/scripts/testParallel/runIndexedMochaTests.cjs

@@ -9,63 +9,65 @@ const DEFAULT_MAX_PARALLEL_JOBS = 4;
 
 // Pattern: Configuration Boundary - bounds workers without accepting invalid input.
 function resolveParallelJobCount(
-    configuredJobCount,
-    testFileCount,
-    defaultMaximum = DEFAULT_MAX_PARALLEL_JOBS,
-    availableJobCount = availableParallelism(),
+  configuredJobCount,
+  testFileCount,
+  defaultMaximum = DEFAULT_MAX_PARALLEL_JOBS,
+  availableJobCount = availableParallelism(),
 ) {
-    const requestedJobCount =
-        configuredJobCount === undefined ? Math.min(availableJobCount, defaultMaximum) : Number.parseInt(configuredJobCount, 10);
+  const requestedJobCount =
+    configuredJobCount === undefined
+      ? Math.min(availableJobCount, defaultMaximum)
+      : Number.parseInt(configuredJobCount, 10);
 
-    if (!Number.isInteger(requestedJobCount) || requestedJobCount < 1) {
-        throw new Error('TEST_PARALLEL_JOBS must be a positive integer.');
-    }
-    return Math.min(requestedJobCount, testFileCount);
+  if (!Number.isInteger(requestedJobCount) || requestedJobCount < 1) {
+    throw new Error('TEST_PARALLEL_JOBS must be a positive integer.');
+  }
+  return Math.min(requestedJobCount, testFileCount);
 }
 
 // Pattern: Command Builder - keeps Mocha worker details out of package metadata.
 function buildMochaArguments(testFiles, jobCount) {
-    const requireFromRunner = createRequire(__filename);
-    return [
-        requireFromRunner.resolve('mocha/bin/mocha.js'),
-        '--parallel',
-        '--jobs',
-        String(jobCount),
-        '--require',
-        resolve('scripts/testOrder/randomizeTestOrder.cjs'),
-        ...testFiles,
-    ];
+  const requireFromRunner = createRequire(__filename);
+  return [
+    requireFromRunner.resolve('mocha/bin/mocha.js'),
+    '--parallel',
+    '--jobs',
+    String(jobCount),
+    '--require',
+    resolve('scripts/testOrder/randomizeTestOrder.cjs'),
+    ...testFiles,
+  ];
 }
 
 // Pattern: Process Adapter - returns the exact test process result to the index.
 function runIndexedMochaTests(testFiles) {
-    if (testFiles.length === 0) {
-        throw new Error('The package test index must select at least one test file.');
-    }
+  if (testFiles.length === 0) {
+    throw new Error('The package test index must select at least one test file.');
+  }
 
-    const jobCount = resolveParallelJobCount(process.env.TEST_PARALLEL_JOBS, testFiles.length);
-    const child = spawn(process.execPath, buildMochaArguments(testFiles, jobCount), {
-        env: {
-            ...process.env,
-            NODE_ENV: 'test',
-        },
-        stdio: 'inherit',
-    });
+  const jobCount = resolveParallelJobCount(process.env.TEST_PARALLEL_JOBS, testFiles.length);
+  const child = spawn(process.execPath, buildMochaArguments(testFiles, jobCount), {
+    env: {
+      ...process.env,
+      NODE_ENV: 'test',
+    },
+    stdio: 'inherit',
+  });
 
-    return new Promise((resolveExit, rejectExit) => {
-        child.once('error', rejectExit);
-        child.once('exit', (code, signal) => {
-            if (signal) {
-                rejectExit(new Error(`Mocha exited from signal ${signal}.`));
-                return;
-            }
-            resolveExit(code ?? 1);
-        });
+  return new Promise((resolveExit, rejectExit) => {
+    child.once('error', rejectExit);
+    child.once('exit', (code, signal) => {
+      if (signal) {
+        rejectExit(new Error(`Mocha exited from signal ${signal}.`));
+        return;
+      }
+      resolveExit(code ?? 1);
     });
+  });
 }
 
 module.exports = {
-    buildMochaArguments,
-    resolveParallelJobCount,
-    runIndexedMochaTests,
+  buildMochaArguments,
+  resolveParallelJobCount,
+  runIndexedMochaTests,
 };

package/scripts/testParallel/runIndexedMochaTests.test.mjs

@@ -6,16 +6,22 @@ const require = createRequire(import.meta.url);
 const { buildMochaArguments, resolveParallelJobCount } = require('./runIndexedMochaTests.cjs');
 
 test('uses bounded Mocha file workers without randomized default ordering', () => {
-    assert.equal(resolveParallelJobCount(undefined, 8, 4, 12), 4);
-    assert.equal(resolveParallelJobCount('2', 8, 4, 12), 2);
+  assert.equal(resolveParallelJobCount(undefined, 8, 4, 12), 4);
+  assert.equal(resolveParallelJobCount('2', 8, 4, 12), 2);
 
-    const argumentsList = buildMochaArguments(['test/example.test.js'], 2);
+  const argumentsList = buildMochaArguments(['test/example.test.js'], 2);
 
-    assert.ok(argumentsList.includes('--parallel'));
-    assert.deepEqual(argumentsList.slice(argumentsList.indexOf('--jobs'), argumentsList.indexOf('--jobs') + 2), ['--jobs', '2']);
-    assert.ok(argumentsList.includes('test/example.test.js'));
+  assert.ok(argumentsList.includes('--parallel'));
+  assert.deepEqual(
+    argumentsList.slice(argumentsList.indexOf('--jobs'), argumentsList.indexOf('--jobs') + 2),
+    ['--jobs', '2'],
+  );
+  assert.ok(argumentsList.includes('test/example.test.js'));
 });
 
 test('rejects invalid worker configuration instead of changing execution silently', () => {
-    assert.throws(() => resolveParallelJobCount('0', 8, 4, 12), /TEST_PARALLEL_JOBS must be a positive integer/);
+  assert.throws(
+    () => resolveParallelJobCount('0', 8, 4, 12),
+    /TEST_PARALLEL_JOBS must be a positive integer/,
+  );
 });

package/scripts/testOrder/testOrderPolicy.test.mjs

@@ -1,48 +0,0 @@
-import assert from 'node:assert/strict';
-import { execFileSync } from 'node:child_process';
-import { readFileSync } from 'node:fs';
-import { test } from 'node:test';
-
-const TEST_ORDER_INVARIANCE_RULE =
-    "Non-negotiable test order invariance rule: Every test must pass independently of which tests run before or after it, and the suite must pass in every execution order. Each test must establish the state it needs, isolate mutable state, and clean up state it owns; it must never rely on another test's setup, mutations, or cleanup. Default test, CI, and Husky commands must use the test framework's ordinary ordering and must not force randomized ordering. Random-order execution is an explicit diagnostic only, and every failure it exposes must be fixed at the root cause.";
-
-function listRepositoryFiles() {
-    return execFileSync('git', ['ls-files', '--cached', '--others', '--exclude-standard'], { encoding: 'utf8' })
-        .trim()
-        .split('\n')
-        .filter(Boolean);
-}
-
-function isRequiredTestGuidance(filePath) {
-    return (
-        /^readme\.md$/i.test(filePath) ||
-        filePath === '.codex/AGENTS.md' ||
-        filePath === '.junie/guidelines.md' ||
-        filePath === '.agents/skills/carecard-workspace-standards/SKILL.md' ||
-        /^\.agents\/skills\/[^/]*(?:test|testing)[^/]*\/(?:SKILL\.md|references\/[^/]*(?:test|testing|coding-principles)[^/]*\.md)$/i.test(
-            filePath,
-        )
-    );
-}
-
-test('keeps the non-negotiable test order rule in repository guidance', () => {
-    const guidanceFiles = listRepositoryFiles().filter(isRequiredTestGuidance);
-    assert.ok(guidanceFiles.length > 0, 'No repository test guidance was found.');
-
-    for (const guidanceFile of guidanceFiles) {
-        const normalizedGuidance = readFileSync(guidanceFile, 'utf8').replace(/\s+/g, ' ').trim();
-        assert.ok(
-            normalizedGuidance.includes(TEST_ORDER_INVARIANCE_RULE),
-            `${guidanceFile} must document the non-negotiable test order invariance rule.`,
-        );
-    }
-});
-
-test('keeps default package scripts on the test framework ordinary ordering', () => {
-    const packageJson = JSON.parse(readFileSync('package.json', 'utf8'));
-
-    for (const [scriptName, command] of Object.entries(packageJson.scripts ?? {})) {
-        assert.equal(typeof command, 'string', `${scriptName} must be a string command.`);
-        assert.doesNotMatch(command, /--test-randomize|--test-random-seed/, `${scriptName} must not force randomized test ordering.`);
-    }
-});

package/scripts/testParallel/parallelTestPolicy.test.mjs

@@ -1,43 +0,0 @@
-import assert from 'node:assert/strict';
-import { readdirSync, readFileSync } from 'node:fs';
-import { createRequire } from 'node:module';
-import { join, relative, resolve } from 'node:path';
-import test from 'node:test';
-
-const require = createRequire(import.meta.url);
-const repositoryRoot = resolve(import.meta.dirname, '../..');
-const packageJson = JSON.parse(readFileSync(new URL('../../package.json', import.meta.url), 'utf8'));
-const packageTaskRunnerSource = readFileSync(new URL('../runPackageTask.mjs', import.meta.url), 'utf8');
-const testIndexSource = readFileSync(new URL('../../test/index.test.js', import.meta.url), 'utf8');
-const { parallelTestFiles } = require('../../test/index.test.js');
-
-function listRuntimeTestFiles(directoryPath) {
-    return readdirSync(directoryPath, { withFileTypes: true }).flatMap(entry => {
-        const entryPath = join(directoryPath, entry.name);
-        if (entry.isDirectory()) return listRuntimeTestFiles(entryPath);
-        if (!/\.test\.(?:js|mjs)$/.test(entry.name) || entry.name === 'index.test.js') {
-            return [];
-        }
-        return [relative(repositoryRoot, entryPath)];
-    });
-}
-
-test('keeps runtime test selection in the index and package scripts short', () => {
-    assert.equal(packageJson.scripts.test, 'node scripts/runPackageTask.mjs test');
-    assert.equal(packageJson.scripts['test:coverage'], 'node scripts/runPackageTask.mjs test:coverage');
-    assert.match(packageTaskRunnerSource, /arguments: \['run', 'test:order'\]/);
-    assert.match(packageTaskRunnerSource, /arguments: \['test\/index\.test\.js'\]/);
-    assert.match(packageTaskRunnerSource, /command: 'nyc'/);
-    assert.match(testIndexSource, /parallelTestFiles/);
-    assert.match(testIndexSource, /runIndexedMochaTests/);
-    assert.match(testIndexSource, /if \(require\.main === module\)/);
-});
-
-test('runs the parallel execution contract in the test-order gate', () => {
-    assert.match(packageJson.scripts['test:order'], /scripts\/testParallel\/parallelTestPolicy\.test\.mjs/);
-    assert.match(packageJson.scripts['test:order'], /scripts\/testParallel\/runIndexedMochaTests\.test\.mjs/);
-});
-
-test('selects every runtime test file exactly once', () => {
-    assert.deepEqual([...parallelTestFiles].sort(), listRuntimeTestFiles(resolve(repositoryRoot, 'test')).sort());
-});